2 ** Splint - annotation-assisted static program checker
3 ** Copyright (C) 1994-2003 University of Virginia,
4 ** Massachusetts Institute of Technology
6 ** This program is free software; you can redistribute it and/or modify it
7 ** under the terms of the GNU General Public License as published by the
8 ** Free Software Foundation; either version 2 of the License, or (at your
9 ** option) any later version.
11 ** This program is distributed in the hope that it will be useful, but
12 ** WITHOUT ANY WARRANTY; without even the implied warranty of
13 ** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 ** General Public License for more details.
16 ** The GNU General Public License is available from http://www.gnu.org/ or
17 ** the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
18 ** MA 02111-1307, USA.
20 ** For information on splint: info@splint.org
21 ** To report a bug: splint-bug@splint.org
22 ** For more information: http://www.splint.org
28 # include "splintMacros.nf"
30 # include "cgrammar.h"
31 # include "cgrammar_tokens.h"
32 # include "transferChecks.h"
33 # include "exprChecks.h"
36 ** for now, allow exprChecks to access exprNode.
37 ** may remove this in future
42 static bool checkCallModifyAux (/*@exposed@*/ sRef p_s, exprNode p_f, sRef p_alias, exprNode p_err);
43 static bool checkModifyValAux (/*@exposed@*/ sRef p_s, exprNode p_f, sRef p_alias, exprNode p_err);
44 static bool checkModifyAux (/*@exposed@*/ sRef p_s, exprNode p_f, sRef p_alias, exprNode p_err);
45 static void checkSafeReturnExpr (/*@notnull@*/ exprNode p_e);
48 ** called at end of expression statement
50 ** of e->kind is not an assign, empty, body or modop
51 ** verify the the value is void
55 static int inCompoundStatementExpression = 0;
58 exprChecks_inCompoundStatementExpression (void)
60 inCompoundStatementExpression++;
64 exprChecks_leaveCompoundStatementExpression (void)
66 inCompoundStatementExpression--;
67 llassert (inCompoundStatementExpression >= 0);
71 exprChecks_checkStatementEffect (exprNode e)
73 bool hasError = FALSE;
75 if (inCompoundStatementExpression > 0)
78 ** Okay to have effectless statments in compound statement expression (should check
79 ** it is the last statement, but we don't for now).
85 if (!exprNode_isError (e))
87 exprKind ek = e->kind;
89 if (ek == XPR_CALL && !(ctype_isRealVoid (e->typ)))
91 if (ctype_isKnown (e->typ))
93 if (ctype_isManifestBool (ctype_realishType (e->typ)))
95 hasError = optgenerror
97 message ("Return value (type %t) ignored: %s",
99 exprNode_unparseFirst (e)),
102 else if (ctype_isDirectInt (e->typ))
104 hasError = optgenerror
106 message ("Return value (type %t) ignored: %s",
108 exprNode_unparseFirst (e)),
113 hasError = optgenerror
115 message ("Return value (type %t) ignored: %s",
117 exprNode_unparseFirst (e)),
123 if (!hasError && !(exprNode_mayEscape (e))
124 && !(e->canBreak)) /* control changes are effects too! */
126 if (sRefSet_hasRealElement (e->sets)
127 || sRefSet_hasRealElement (e->msets))
133 if (sRefSet_isEmpty (e->sets) && sRefSet_isEmpty (e->msets))
137 message ("Statement has no effect: %s",
138 exprNode_unparseFirst (e)),
143 if (context_maybeSet (FLG_NOEFFECTUNCON))
145 if (sRefSet_hasUnconstrained (e->sets))
149 message ("Statement has no effect (possible "
150 "undected modification through "
152 sRefSet_unparseUnconstrained (e->sets),
153 exprNode_unparseFirst (e)),
156 else if (sRefSet_hasUnconstrained (e->msets))
160 message ("Statement has no effect (possible "
161 "undected modification through "
163 sRefSet_unparseUnconstrained (e->msets),
164 exprNode_unparseFirst (e)),
169 ; /* statement has unknown modification */
179 checkRepExposed (sRef base, /*@notnull@*/ exprNode e, sRef alias,
180 /*@unused@*/ exprNode unused)
184 if (sRef_isInvalid (alias) || sRef_sameName (base, alias))
186 btype = sRef_getType (base);
188 if (ctype_isAbstract (btype) && ctype_isVisiblySharable (e->typ))
190 voptgenerror (FLG_RETEXPOSE,
191 message ("Return value exposes rep of %s: %s",
192 ctype_unparse (btype),
193 exprNode_unparse (e)),
200 sRef rbase = sRef_getRootBase (base);
201 btype = sRef_getType (rbase);
203 if (ctype_isAbstract (btype) && ctype_isVisiblySharable (e->typ))
207 message ("Return value may expose rep of %s through alias %q: %s",
208 ctype_unparse (btype),
209 sRef_unparse (rbase),
210 exprNode_unparse (e)),
220 checkRefGlobParam (sRef base, /*@notnull@*/ exprNode e,
221 sRef alias, /*@unused@*/ exprNode unused)
223 if (sRef_isInvalid (alias) || sRef_sameName (base, alias))
227 if (ctype_isUnknown (ct))
229 ct = sRef_getType (base);
232 if (ctype_isVisiblySharable (ct))
234 if (sRef_isFileOrGlobalScope (base))
236 uentry fcn = context_getHeader ();
237 bool noerror = FALSE;
239 if (uentry_isValid (fcn) && uentry_isFunction (fcn))
241 sRef res = uentry_getSref (fcn);
243 /* If result is dependent and global is owned, this is okay... */
244 if (sRef_isDependent (res)
245 && sRef_isOwned (base))
256 message ("Function returns reference to global %q: %s",
258 exprNode_unparse (e)),
264 else if (sRef_isAnyParam (base))
266 uentryList params = context_getParams ();
267 int paramno = sRef_getParam (base);
269 if (paramno < uentryList_size (params))
271 uentry arg = uentryList_getN (params, paramno);
272 sRef ref = uentry_getSref (arg);
274 if (uentry_isReturned (arg)
276 || sRef_isExposed (ref)
277 || sRef_isRefCounted (ref))
285 message ("Function returns reference to parameter %q: %s",
287 exprNode_unparse (e)),
293 llbuglit ("ret alias: bad paramno");
306 if (ctype_isVisiblySharable (e->typ))
308 if (sRef_isFileOrGlobalScope (base))
312 message ("Function may return reference to global %q through alias %q: %s",
313 sRef_unparse (alias),
315 exprNode_unparse (e)),
319 else if (sRef_isAnyParam (base) && !(sRef_isOnly (base)))
321 uentryList params = context_getParams ();
322 int paramno = sRef_getParam (base);
324 if (paramno < uentryList_size (params))
326 uentry arg = uentryList_getN (params, paramno);
328 if (!uentry_isReturned (arg))
333 ("Function may return reference to parameter %q through alias %q: %s",
335 sRef_unparse (alias),
336 exprNode_unparse (e)),
347 ("Function may return reference to parameter %q through alias %q: %s",
349 sRef_unparse (alias),
350 exprNode_unparse (e)),
367 exprNode_checkModify (exprNode e, exprNode err)
369 llassert (exprNode_isDefined (e));
371 DPRINTF (("Check modify: %s", exprNode_unparse (e)));
373 if (sRef_isValid (e->sref))
375 sRef_aliasCheckPred (checkModifyAux, sRef_isReference, e->sref, e, err);
380 exprNode_checkModifyVal (exprNode e, exprNode err)
382 llassert (exprNode_isDefined (e));
384 DPRINTF (("Check modify val: %s", exprNode_unparse (e)));
386 if (sRef_isValid (e->sref))
388 sRef_aliasCheckPred (checkModifyValAux, sRef_isReference, e->sref, e, err);
393 exprChecks_checkNullReturn (fileloc loc)
395 if (!context_inRealFunction ())
398 llmsg ("exprChecks_checkNullReturnExpr: not in function context");
404 if (ctype_isFunction (context_currentFunctionType ()))
406 ctype tr = ctype_getReturnType (context_currentFunctionType ());
408 if (!ctype_isFirstVoid (tr))
410 if (ctype_isUnknown (tr))
414 cstring_makeLiteral ("Empty return in function declared to implicitly return int"),
419 voptgenerror (FLG_EMPTYRETURN,
420 message ("Empty return in function declared to return %t", tr),
429 exprNode_checkReturn (exprNode e)
431 if (!exprNode_isError (e))
433 if (!context_inRealFunction ())
435 if (context_inMacro ())
437 llerror (FLG_MACRORETURN,
438 message ("Macro %s uses return (not functional)",
439 context_inFunctionName ()));
444 llbuglit ("exprNode_checkReturn: not in function context");
450 if (ctype_isFunction (context_currentFunctionType ()))
452 checkSafeReturnExpr (e);
463 exprNode_checkPred (cstring c, exprNode e)
467 if (exprNode_isError (e))
470 ct = exprNode_getType (e);
472 if (exprNode_isAssign (e))
476 message ("Test expression for %s is assignment expression: %s",
477 c, exprNode_unparse (e)),
481 if (ctype_isRealBool (ct) || ctype_isUnknown (ct))
482 /* evs 2000-12-20 added || ctype_isUnknown to avoid spurious messages */
486 else if (ctype_isRealPointer (ct))
490 message ("Test expression for %s not %s, type %t: %s", c,
491 context_printBoolName (),
492 ct, exprNode_unparse (e)),
495 else if (ctype_isRealInt (ct))
499 message ("Test expression for %s not %s, type %t: %s", c,
500 context_printBoolName (), ct, exprNode_unparse (e)),
507 message ("Test expression for %s not %s, type %t: %s", c,
508 context_printBoolName (), ct, exprNode_unparse (e)),
514 exprChecks_checkUsedGlobs (globSet decl, globSet used)
516 fileloc fl = uentry_whereSpecified (context_getHeader ());
518 if (fileloc_isUndefined (fl))
520 fl = uentry_whereDeclared (context_getHeader ());
523 globSet_allElements (decl, el)
525 if (!globSet_member (used, el))
527 if (sRef_isSpecInternalState (el)
528 || sRef_isNothing (el))
534 cstring sname = sRef_unparse (el);
536 if (fileloc_isLib (fl))
538 voptgenerror (FLG_USEALLGLOBS,
539 message ("Global %s listed (%q) but not used",
540 sname, fileloc_unparse (fl)),
545 voptgenerror (FLG_USEALLGLOBS,
546 message ("Global %s listed but not used", sname),
550 cstring_free (sname);
553 } end_globSet_allElements;
557 exprNode_checkAllMods (sRefSet mods, uentry ue)
559 bool realParams = FALSE;
560 uentry le = context_getHeader ();
561 fileloc fl = uentry_whereSpecified (le);
562 uentryList specParamNames = uentryList_undefined;
563 uentryList paramNames = context_getParams ();
565 if (uentry_isFunction (le))
567 specParamNames = uentry_getParams (le);
569 if (uentryList_isUndefined (specParamNames))
571 ; /* unknown params */
573 else if (uentryList_size (paramNames) != uentryList_size (specParamNames))
576 (message ("exprNode_checkAllMods: parameter lists have different sizes: "
578 uentryList_unparse (paramNames),
579 uentryList_size (paramNames),
580 uentryList_unparse (specParamNames),
581 uentryList_size (specParamNames)));
583 else if (uentryList_size (paramNames) > 0
584 && !uentry_hasRealName (uentryList_getN (specParamNames, 0)))
586 /* loaded from a library */
594 sRefSet_allElements (mods, sr)
596 if (sRef_isNothing (sr) || sRef_isSpecState (sr))
598 ; /* should report on anything? */
600 else if (sRef_isInternalState (sr))
602 if (!sRef_isModified (sr))
604 if (sRefSet_hasStatic (mods))
613 ("Function %s specified to modify internal state "
614 "but no internal state is modified",
615 uentry_rawName (ue)),
616 uentry_whereLast (ue)))
618 uentry_showWhereSpecified (le);
625 if (!sRef_isModified (sr))
627 cstring sname = realParams ? sRef_unparse (sr) : sRef_unparse (sr);
629 if (fileloc_isLib (fl) && !realParams)
633 message ("Suspect object listed (%q) in modifies "
634 "clause of %s not modified: %s",
635 fileloc_unparse (fl),
638 uentry_whereLast (ue));
644 message ("Suspect object listed in modifies of %s "
648 uentry_whereLast (ue)))
650 uentry_showWhereSpecified (le);
653 cstring_free (sname);
656 } end_sRefSet_allElements;
659 void exprNode_checkMacroBody (/*@only@*/ exprNode e)
661 if (!exprNode_isError (e))
665 if (!(context_inFunctionLike () || context_inMacroConstant ()
666 || context_inUnknownMacro ()))
670 ("exprNode_checkMacroBody: not in macro function or constant: %q",
671 context_unparse ()));
676 hdr = context_getHeader ();
678 if (e->kind == XPR_STMTLIST || e->kind == XPR_BODY)
683 ("Macro %q definition is statement list (recommend "
684 "do { ... } while (0) constuction to ensure multiple "
685 "statement macro is syntactic function)",
686 uentry_getName (hdr)),
687 fileloc_isDefined (e->loc) ? e->loc : g_currentloc);
690 if (context_inMacroConstant ())
692 ctype t = uentry_getType (hdr);
694 uentry_setDefined (hdr, e->loc);
696 if (!(exprNode_matchType (t, e)))
698 cstring uname = uentry_getName (hdr);
700 if (cstring_equal (uname, context_getTrueName ())
701 || cstring_equal (uname, context_getFalseName ()))
704 ** We need to do something special to allow FALSE and TRUE
705 ** to be defined without reporting errors. This is a tad
706 ** bogus, but otherwise lots of things would break.
710 llassert (ctype_isManifestBool (t));
711 /* Should also check type of e is a reasonable (?) bool type. */
718 ("Constant %q specified as %s, but defined as %s: %s",
719 uentry_getName (hdr),
721 ctype_unparse (e->typ),
722 exprNode_unparse (e)),
725 uentry_showWhereSpecified (hdr);
729 cstring_free (uname);
733 if (context_maybeSet (FLG_NULLSTATE)
735 && ctype_isRealPointer (t)
736 && exprNode_isNullValue (e))
738 uentry ue = usymtab_getTypeEntry (ctype_typeId (t));
739 sRef sr = uentry_getSref (ue);
741 if (!sRef_possiblyNull (sr))
745 message ("Constant %q of non-null type %s defined "
747 uentry_getName (hdr), ctype_unparse (t),
748 exprNode_unparse (e)),
749 message ("If %s can be null, add a /*@null@*/ "
750 "qualifer to its typedef.",
755 uentry_mergeConstantValue (hdr, e->val);
756 e->val = multiVal_undefined;
760 else if (context_inMacroFunction () || context_inUnknownMacro ())
762 ctype rettype = context_getRetType ();
764 if (context_isMacroMissingParams ())
766 llassert (context_inMacroFunction ());
769 ** # define newname oldname
771 ** newname is a function
772 ** specification of oldname should match
773 ** specification of newname.
776 if (!ctype_isFunction (e->typ))
780 message ("Function %s defined by unparameterized "
781 "macro not corresponding to function",
782 context_inFunctionName ()),
787 uentry ue = exprNode_getUentry (e);
789 if (uentry_isValid (ue))
792 ** Okay, for now --- should check for consistency
795 ** uentry oldue = usymtab_lookup (cfname);
798 /* check var conformance here! */
804 message ("Function %s defined by unparameterized "
805 "macro not corresponding to function",
806 context_inFunctionName ()),
810 e->typ = ctype_getReturnType (e->typ);
811 rettype = e->typ; /* avoid aditional errors */
815 if (ctype_isVoid (rettype) || ctype_isUnknown (rettype))
817 ; /* don't complain when void macros have values */
819 else if (!exprNode_matchType (rettype, e))
823 message ("Function %q specified to return %s, "
824 "implemented as macro having type %s: %s",
825 uentry_getName (hdr),
826 ctype_unparse (rettype), ctype_unparse (e->typ),
827 exprNode_unparse (e)),
830 uentry_showWhereSpecified (hdr);
837 /* these expressions have values: */
838 case XPR_PARENS: case XPR_ASSIGN:
839 case XPR_EMPTY: case XPR_VAR:
840 case XPR_OP: case XPR_POSTOP:
841 case XPR_PREOP: case XPR_CALL:
842 case XPR_SIZEOFT: case XPR_SIZEOF:
843 case XPR_ALIGNOFT: case XPR_ALIGNOF:
844 case XPR_CAST: case XPR_FETCH:
845 case XPR_COMMA: case XPR_COND:
846 case XPR_ARROW: case XPR_CONST:
847 case XPR_STRINGLITERAL: case XPR_NUMLIT:
848 case XPR_FACCESS: case XPR_OFFSETOF:
850 transferChecks_return (e, hdr);
853 /* these expressions don't */
855 case XPR_VAARG: case XPR_ITER:
856 case XPR_FOR: case XPR_FORPRED:
857 case XPR_GOTO: case XPR_CONTINUE:
858 case XPR_BREAK: case XPR_RETURN:
859 case XPR_NULLRETURN: case XPR_IF:
860 case XPR_IFELSE: case XPR_DOWHILE:
861 case XPR_WHILE: case XPR_STMT:
862 case XPR_STMTLIST: case XPR_SWITCH:
863 case XPR_INIT: case XPR_BODY:
864 case XPR_NODE: case XPR_ITERCALL:
865 case XPR_TOK: case XPR_CASE:
866 case XPR_FTCASE: case XPR_FTDEFAULT:
867 case XPR_DEFAULT: case XPR_WHILEPRED:
868 case XPR_BLOCK: case XPR_INITBLOCK:
871 message ("Function %q specified to return %s, "
872 "implemented as macro with no result: %s",
873 uentry_getName (hdr),
874 ctype_unparse (rettype),
875 exprNode_unparse (e)),
878 uentry_showWhereSpecified (hdr);
883 usymtab_checkFinalScope (FALSE);
887 llbug (message ("exprNode_checkMacroBody: not in macro function: %q", context_unparse ()));
893 context_exitFunction ();
897 void exprNode_checkFunctionBody (exprNode body)
899 if (!exprNode_isError (body))
901 bool noret = context_getFlag (FLG_NORETURN);
902 bool checkret = exprNode_mustEscape (body);
906 && !exprNode_errorEscape (body)
907 && context_inRealFunction ()
908 && ctype_isFunction (context_currentFunctionType ()))
910 ctype tr = ctype_getReturnType (context_currentFunctionType ());
912 if (!ctype_isFirstVoid (tr))
914 if (ctype_isUnknown (tr))
918 cstring_makeLiteral ("Path with no return in function declared to implicity return int"),
925 message ("Path with no return in function declared to return %t",
934 context_returnFunction ();
941 void exprNode_checkFunction (/*@unused@*/ uentry ue, /*@only@*/ exprNode body)
943 constraintList c, t, post;
944 constraintList c2, fix;
945 constraintList implicitFcnConstraints;
946 context_enterInnerContext ();
948 llassert (exprNode_isDefined (body));
951 if we're not going to be printing any errors for buffer overflows
952 we can skip the checking to improve performance
954 FLG_DEBUGFUNCTIONCONSTRAINT controls wheather we perform the check anyway
955 in order to find potential problems like assert failures and seg faults...
958 if (!context_getFlag(FLG_DEBUGFUNCTIONCONSTRAINT))
960 /* check if errors will printed */
961 if (!(context_getFlag(FLG_DEBUGFUNCTIONCONSTRAINT) ||
962 context_getFlag(FLG_BOUNDSWRITE) ||
963 context_getFlag(FLG_BOUNDSREAD) ||
964 context_getFlag(FLG_LIKELYBOUNDSWRITE) ||
965 context_getFlag(FLG_LIKELYBOUNDSREAD) ||
966 context_getFlag(FLG_CHECKPOST) ))
968 exprNode_free (body);
969 context_exitInnerPlain();
974 exprNode_generateConstraints (body); /* evans 2002-03-02: this should not be declared to take a
975 dependent... fix it! */
977 c = uentry_getFcnPreconditions (ue);
979 if (constraintList_isDefined (c))
981 DPRINTF ((message ("Function preconditions are %s \n\n\n\n\n",
982 constraintList_unparseDetailed (c) ) ) );
984 body->requiresConstraints =
985 constraintList_reflectChangesFreePre (body->requiresConstraints, c);
987 c2 = constraintList_copy (c);
988 fix = constraintList_makeFixedArrayConstraints (body->uses);
989 c2 = constraintList_reflectChangesFreePre (c2, fix);
991 constraintList_free (fix);
993 if (context_getFlag (FLG_ORCONSTRAINT))
995 t = constraintList_reflectChangesOr (body->requiresConstraints, c2 );
999 t = constraintList_reflectChanges(body->requiresConstraints, c2);
1002 constraintList_free (body->requiresConstraints);
1003 DPRINTF ((message ("The body has the required constraints: %s", constraintList_unparseDetailed (t) ) ) );
1005 body->requiresConstraints = t;
1007 t = constraintList_mergeEnsures (c, body->ensuresConstraints);
1008 constraintList_free(body->ensuresConstraints);
1010 body->ensuresConstraints = t;
1012 DPRINTF ((message ("The body has the ensures constraints: %s", constraintList_unparseDetailed (t) ) ) );
1013 constraintList_free(c2);
1016 if (constraintList_isDefined(c))
1018 DPRINTF ((message ("The Function %s has the preconditions %s",
1019 uentry_unparse(ue), constraintList_unparseDetailed(c))));
1023 DPRINTF((message ("The Function %s has no preconditions", uentry_unparse(ue))));
1026 implicitFcnConstraints = getImplicitFcnConstraints();
1028 if (constraintList_isDefined(implicitFcnConstraints) )
1030 if (context_getFlag (FLG_IMPLICTCONSTRAINT) )
1032 body->requiresConstraints = constraintList_reflectChangesFreePre (body->requiresConstraints,
1033 implicitFcnConstraints );
1037 body->requiresConstraints = constraintList_sort (body->requiresConstraints);
1039 constraintList_printError(body->requiresConstraints, g_currentloc);
1041 post = uentry_getFcnPostconditions (ue);
1043 if (context_getFlag (FLG_CHECKPOST))
1045 if (constraintList_isDefined (post))
1047 constraintList post2;
1049 DPRINTF ((message ("The declared function postconditions are %s \n\n\n\n\n",
1050 constraintList_unparseDetailed (post) ) ) );
1052 post = constraintList_reflectChangesFreePre (post, body->ensuresConstraints);
1054 post2 = constraintList_copy (post);
1055 fix = constraintList_makeFixedArrayConstraints (body->uses);
1056 post2 = constraintList_reflectChangesFreePre (post2, fix);
1057 constraintList_free(fix);
1058 if ( context_getFlag (FLG_ORCONSTRAINT) )
1060 t = constraintList_reflectChangesOr (post2, body->ensuresConstraints);
1064 t = constraintList_reflectChanges(post2, body->ensuresConstraints);
1067 constraintList_free(post2);
1068 constraintList_free(post);
1071 printf("Unresolved post conditions\n");
1072 constraintList_printErrorPostConditions(post, g_currentloc);
1076 if (constraintList_isDefined (post))
1078 constraintList_free (post);
1081 body->ensuresConstraints = constraintList_sort(body->ensuresConstraints);
1083 if ( context_getFlag (FLG_FUNCTIONPOST) )
1085 constraintList_printError(body->ensuresConstraints, g_currentloc);
1088 /* ConPrint (message ("Unable to resolve function constraints:\n%s", constraintList_printDetailed(body->requiresConstraints) ), g_currentloc);
1090 ConPrint (message ("Splint has found function post conditions:\n%s", constraintList_printDetailed(body->ensuresConstraints) ), g_currentloc);
1092 printf ("The required constraints are:\n%s", constraintList_printDetailed(body->requiresConstraints) );
1093 printf ("The ensures constraints are:\n%s", constraintList_unparseDetailed(body->ensuresConstraints) );
1096 if (constraintList_isDefined(c) )
1097 constraintList_free(c);
1099 context_exitInnerPlain();
1101 /* is it okay not to free this? */
1102 DPRINTF (("Done checking constraints..."));
1103 exprNode_free (body);
1106 void exprChecks_checkEmptyMacroBody (void)
1110 if (!(context_inFunctionLike () || context_inMacroConstant ()
1111 || context_inUnknownMacro ()))
1114 (message ("exprNode_checkEmptyMacroBody: not in macro function or constant: %q",
1115 context_unparse ()));
1119 hdr = context_getHeader ();
1123 if (uentry_isFunction (hdr))
1128 ("Macro definition for %q is empty", uentry_getName (hdr)),
1131 usymtab_checkFinalScope (FALSE);
1134 context_exitFunction ();
1138 void exprNode_checkIterBody (/*@only@*/ exprNode body)
1140 context_exitAllClauses ();
1142 context_exitFunction ();
1143 exprNode_free (body);
1146 void exprNode_checkIterEnd (/*@only@*/ exprNode body)
1148 context_exitAllClauses ();
1149 context_exitFunction ();
1150 exprNode_free (body);
1154 bool checkModifyAuxAux (/*@exposed@*/ sRef s, exprNode f, sRef alias, exprNode err)
1156 bool hasMods = context_hasMods ();
1157 flagcode errCode = hasMods ? FLG_MODIFIES : FLG_MODNOMODS;
1159 if (exprNode_isDefined (f))
1161 f->sets = sRefSet_insert (f->sets, s);
1164 if (context_getFlag (FLG_MODIFIES)
1165 && (hasMods || context_getFlag (FLG_MODNOMODS)))
1167 sRefSet mods = context_modList ();
1169 if (!sRef_canModify (s, mods))
1171 sRef rb = sRef_getRootBase (s);
1174 if (sRef_isFileOrGlobalScope (rb))
1176 if (!context_checkGlobMod (rb))
1182 if (sRef_isInvalid (alias) || sRef_sameName (s, alias))
1184 if (sRef_isLocalVar (sRef_getRootBase (s)))
1189 ("Undocumented modification of internal state (%q): %s",
1190 sRef_unparse (s), exprNode_unparse (err)),
1191 exprNode_isDefined (f) ? f->loc : g_currentloc);
1195 if (sRef_isSystemState (s))
1197 if (errCode == FLG_MODNOMODS)
1199 if (context_getFlag (FLG_MODNOMODS))
1201 errCode = FLG_MODFILESYSTEM;
1206 errCode = FLG_MODFILESYSTEM;
1212 message ("Undocumented modification of %q: %s",
1213 sRef_unparse (s), exprNode_unparse (err)),
1214 exprNode_isDefined (f) ? f->loc : g_currentloc);
1221 if (sRef_isReference (s) && !sRef_isAddress (alias))
1226 ("Possible undocumented modification of %q through alias %q: %s",
1228 sRef_unparse (alias),
1229 exprNode_unparse (err)),
1230 exprNode_isDefined (f) ? f->loc : g_currentloc);
1238 if (context_maybeSet (FLG_MUSTMOD))
1240 (void) sRef_canModify (s, context_modList ());
1243 if (sRef_isRefsField (s))
1245 sRef_setModified (s);
1253 bool checkModifyAux (/*@exposed@*/ sRef s, exprNode f, sRef alias, exprNode err)
1255 DPRINTF (("Check modify aux: %s", sRef_unparseFull (s)));
1257 if (sRef_isReference (s) && sRef_isObserver (s)
1258 && context_maybeSet (FLG_MODOBSERVER))
1262 if (sRef_isPointer (s))
1264 sRef base = sRef_getBase (s);
1265 sname = sRef_unparse (base);
1269 if (sRef_isAddress (s))
1271 sRef p = sRef_constructPointer (s);
1272 sname = sRef_unparse (p);
1276 sname = sRef_unparse (s);
1280 if (!sRef_isValid (alias) || sRef_sameName (s, alias))
1282 if (sRef_isMeaningful (s))
1286 message ("Suspect modification of observer %s: %s",
1287 sname, exprNode_unparse (err)),
1288 exprNode_isDefined (f) ? f->loc : g_currentloc))
1290 sRef_showExpInfo (s);
1297 message ("Suspect modification of observer returned by "
1298 "function call: %s",
1299 exprNode_unparse (err)),
1300 exprNode_isDefined (f) ? f->loc : g_currentloc);
1307 message ("Suspect modification of observer %s through alias %q: %s",
1308 sname, sRef_unparse (alias), exprNode_unparse (err)),
1309 exprNode_isDefined (f) ? f->loc : g_currentloc))
1311 sRef_showExpInfo (s);
1315 cstring_free (sname);
1318 (void) checkModifyAuxAux (s, f, alias, err);
1323 bool checkModifyValAux (/*@exposed@*/ sRef s, exprNode f, sRef alias, exprNode err)
1325 (void) checkModifyAuxAux (s, f, alias, err);
1330 bool checkCallModifyAux (/*@exposed@*/ sRef s, exprNode f, sRef alias, exprNode err)
1332 bool result = FALSE;
1334 DPRINTF (("Check modify aux: %s / %s",
1335 sRef_unparse (s), sRef_unparse (alias)));
1337 if (sRef_isObserver (s) && context_maybeSet (FLG_MODOBSERVER))
1339 sRef p = sRef_isAddress (s) ? sRef_constructPointer (s) : s;
1340 cstring sname = sRef_unparse (p);
1342 if (!sRef_isValid (alias) || sRef_sameName (s, alias))
1344 if (sRef_isMeaningful (s))
1346 result = optgenerror
1348 message ("Suspect modification of observer %s: %s",
1349 sname, exprNode_unparse (err)),
1350 exprNode_isDefined (f) ? f->loc : g_currentloc);
1354 result = optgenerror
1356 message ("Suspect modification of observer returned by "
1357 "function call: %s",
1358 exprNode_unparse (err)),
1359 exprNode_isDefined (f) ? f->loc : g_currentloc);
1364 result = optgenerror
1367 ("Suspect modification of observer %s through alias %q: %s",
1368 sname, sRef_unparse (alias), exprNode_unparse (err)),
1369 exprNode_isDefined (f) ? f->loc : g_currentloc);
1372 cstring_free (sname);
1374 else if (context_maybeSet (FLG_MODIFIES))
1376 DPRINTF (("can modify: %s / %s",
1378 sRefSet_unparse (context_modList ())));
1380 if (!(sRef_canModifyVal (s, context_modList ())))
1382 sRef p = sRef_isAddress (s) ? sRef_constructPointer (s) : s;
1383 cstring sname = sRef_unparse (p);
1384 bool hasMods = context_hasMods ();
1385 sRef rb = sRef_getRootBase (s);
1386 flagcode errCode = hasMods ? FLG_MODIFIES : FLG_MODNOMODS;
1389 DPRINTF (("Can't modify! %s", sRef_unparse (s)));
1391 if (sRef_isFileOrGlobalScope (rb))
1393 uentry ue = sRef_getUentry (rb);
1395 /* be more specific here! */
1396 if (!uentry_isCheckedModify (ue))
1404 if (!sRef_isValid (alias) || sRef_sameName (s, alias))
1406 if (sRef_isLocalVar (sRef_getRootBase (s)))
1411 ("Undocumented modification of internal "
1412 "state (%q) through call to %s: %s",
1413 sRef_unparse (s), exprNode_unparse (f),
1414 exprNode_unparse (err)),
1415 exprNode_isDefined (f) ? f->loc : g_currentloc);
1419 if (sRef_isSystemState (s))
1421 if (errCode == FLG_MODNOMODS)
1423 if (context_getFlag (FLG_MODNOMODS))
1425 errCode = FLG_MODFILESYSTEM;
1430 errCode = FLG_MODFILESYSTEM;
1434 result = optgenerror
1436 message ("Undocumented modification of %s "
1437 "possible from call to %s: %s",
1439 exprNode_unparse (f),
1440 exprNode_unparse (err)),
1441 exprNode_isDefined (f) ? f->loc : g_currentloc);
1446 result = optgenerror
1448 message ("Undocumented modification of %s possible "
1449 "from call to %s (through alias %q): %s",
1451 exprNode_unparse (f),
1452 sRef_unparse (alias),
1453 exprNode_unparse (err)),
1454 exprNode_isDefined (f) ? f->loc : g_currentloc);
1457 cstring_free (sname);
1462 if (context_maybeSet (FLG_MUSTMOD))
1464 (void) sRef_canModifyVal (s, context_modList ());
1471 void exprNode_checkCallModifyVal (sRef s, exprNodeList args, exprNode f, exprNode err)
1473 s = sRef_fixBaseParam (s, args);
1474 DPRINTF (("Check call modify: %s", sRef_unparse (s)));
1475 sRef_aliasCheckPred (checkCallModifyAux, NULL, s, f, err);
1479 exprChecks_checkExport (uentry e)
1481 if (context_checkExport (e))
1483 fileloc fl = uentry_whereDeclared (e);
1485 if (fileloc_isHeader (fl) && !fileloc_isLib (fl)
1486 && !fileloc_isImport (fl) && !uentry_isStatic (e))
1488 if (uentry_isFunction (e) ||
1489 (uentry_isVariable (e) && ctype_isFunction (uentry_getType (e))))
1493 message ("Function exported, but not specified: %q",
1494 uentry_getName (e)),
1497 else if (uentry_isExpandedMacro (e))
1501 message ("Expanded macro exported, but not specified: %q",
1502 uentry_getName (e)),
1505 else if (uentry_isVariable (e) && !uentry_isParam (e))
1509 message ("Variable exported, but not specified: %q",
1510 uentry_getName (e)),
1513 else if (uentry_isEitherConstant (e))
1517 message ("Constant exported, but not specified: %q",
1518 uentry_getName (e)),
1521 else if (uentry_isIter (e) || uentry_isEndIter (e))
1525 message ("Iterator exported, but not specified: %q",
1526 uentry_getName (e)),
1530 else if (uentry_isDatatype (e))
1532 ; /* error already reported */
1542 static void checkSafeReturnExpr (/*@notnull@*/ exprNode e)
1544 ctype tr = ctype_getReturnType (context_currentFunctionType ());
1545 ctype te = exprNode_getType (e);
1547 /* evans 2001-08-21: added test to warn about void returns from void functions */
1548 if (ctype_isVoid (tr))
1551 (te, e, tr, exprNode_undefined,
1552 message ("Return expression from function declared void: %s", exprNode_unparse (e)),
1557 if (!ctype_forceMatch (tr, te) && !exprNode_matchLiteral (tr, e))
1560 (te, e, tr, exprNode_undefined,
1561 message ("Return value type %t does not match declared type %t: %s",
1562 te, tr, exprNode_unparse (e)),
1568 uentry rval = context_getHeader ();
1569 sRef resultref = uentry_getSref (rval);
1571 DPRINTF (("Check return: %s / %s / %s",
1572 exprNode_unparse (e),
1573 sRef_unparseFull (e->sref),
1574 uentry_unparse (rval)));
1576 transferChecks_return (e, rval);
1578 DPRINTF (("After return: %s / %s / %s",
1579 exprNode_unparse (e),
1580 sRef_unparseFull (e->sref),
1581 uentry_unparse (rval)));
1583 if (!(sRef_isExposed (uentry_getSref (context_getHeader ()))
1584 || sRef_isObserver (uentry_getSref (context_getHeader ())))
1585 && (context_getFlag (FLG_RETALIAS)
1586 || context_getFlag (FLG_RETEXPOSE)))
1588 sRef base = sRef_getRootBase (ret);
1589 ctype rtype = e->typ;
1591 if (ctype_isUnknown (rtype))
1596 if (ctype_isVisiblySharable (rtype))
1598 if (context_getFlag (FLG_RETALIAS))
1600 sRef_aliasCheckPred (checkRefGlobParam, NULL, base,
1601 e, exprNode_undefined);
1604 if (context_getFlag (FLG_RETEXPOSE) && sRef_isIReference (ret)
1605 && !sRef_isExposed (resultref) && !sRef_isObserver (resultref))
1607 sRef_aliasCheckPred (checkRepExposed, NULL, base, e,
1608 exprNode_undefined);