- djm@cvs.openbsd.org 2010/01/04 02:25:15

     [sftp-server.c]
     bz#1566 don't unnecessarily dup() in and out fds for sftp-server;
     ok markus@

diff --git a/ChangeLog b/ChangeLog
index 70e3c15e9ea107df01297c0a0b83bb23ca224ba6..05b99b160a76adf878527db284ec6c67e981eb5c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -150,6 +150,10 @@
      by quoted filenames, but the UI could still be slightly improved.
      In particular, it is quite slow for remote completion on large directories.
      bz#200; ok markus@
+   - djm@cvs.openbsd.org 2010/01/04 02:25:15
+     [sftp-server.c]
+     bz#1566 don't unnecessarily dup() in and out fds for sftp-server;
+     ok markus@
 
 20091226
  - (tim) [contrib/cygwin/Makefile] Install ssh-copy-id and ssh-copy-id.1

diff --git a/sftp-server.c b/sftp-server.c
index 20a601f99e370ea984c30b60fd10aa75bf28d894..cf4e273f8403c07dcfdaaf5da6ccb78ec03440f8 100644 (file)
--- a/sftp-server.c
+++ b/sftp-server.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp-server.c,v 1.88 2009/10/17 12:10:39 sobrado Exp $ */
+/* $OpenBSD: sftp-server.c,v 1.89 2010/01/04 02:25:15 djm Exp $ */
 /*
  * Copyright (c) 2000-2004 Markus Friedl.  All rights reserved.
  *
@@ -1397,8 +1397,8 @@ sftp_server_main(int argc, char **argv, struct passwd *user_pw)
        logit("session opened for local user %s from [%s]",
            pw->pw_name, client_addr);
 
-       in = dup(STDIN_FILENO);
-       out = dup(STDOUT_FILENO);
+       in = STDIN_FILENO;
+       out = STDOUT_FILENO;
 
 #ifdef HAVE_CYGWIN
        setmode(in, O_BINARY);