- (djm) Another off-by-one fix from Pavel Kankovsky

   <peak@argo.troja.mff.cuni.cz>

diff --git a/CREDITS b/CREDITS
index 0bae5a1a5994f53675476d76e62f16087cf6e75b..78ce2d697be7f3d22d7b73eb576439b500e1f8de 100644 (file)
--- a/CREDITS
+++ b/CREDITS
@@ -57,6 +57,7 @@ Michael Stone <mstone@cs.loyola.edu> - Irix enhancements
 Nalin Dahyabhai <nalin.dahyabhai@pobox.com> - PAM environment patch
 Nate Itkin <nitkin@europa.com> - SunOS 4.1.x fixes
 Niels Kristian Bech Jensen <nkbj@image.dk> - Assorted patches
+Pavel Kankovsky <peak@argo.troja.mff.cuni.cz> - Security fixes
 Pavel Troller <patrol@omni.sinus.cz> - Bugfixes
 Pekka Savola <pekkas@netcore.fi> - Bugfixes
 Peter Kocks <peter.kocks@baygate.com> - Makefile fixes

diff --git a/fake-getnameinfo.c b/fake-getnameinfo.c
index ce992d111af3325c89054ab387b7ea2a7cc849ba..203621f0d7477fb1aad6d74791e62c37699319f3 100644 (file)
--- a/fake-getnameinfo.c
+++ b/fake-getnameinfo.c
@@ -22,7 +22,7 @@ int getnameinfo(const struct sockaddr *sa, size_t salen, char *host,
 
        if (serv) {
                snprintf(tmpserv, sizeof(tmpserv), "%d", ntohs(sin->sin_port));
-               if (strlen(tmpserv) > servlen)
+               if (strlen(tmpserv) >= servlen)
                        return EAI_MEMORY;
                else
                        strcpy(serv, tmpserv);