- (djm) Add back radix.o (used by AFS support), after it went missing from

   Makefile many moons ago
 - (djm) Apply "owl-always-auth" patch from Openwall/Solar Designer
 - (djm) Fix blibpath specification for AIX/gcc
 - (djm) Some systems have basename in -lgen. Fix from ayamura@ayamura.org

diff --git a/CREDITS b/CREDITS
index 487a41d8cd96189f6dc7f7ac106ab2032a7e4ccd..7ce3e9270476c88799606d6ac379aba781ffba9d 100644 (file)
--- a/CREDITS
+++ b/CREDITS
@@ -5,7 +5,7 @@ Theo de Raadt, and Dug Song - Creators of OpenSSH
 
 Alain St-Denis <Alain.St-Denis@ec.gc.ca> - Irix fix
 Alexandre Oliva <oliva@lsd.ic.unicamp.br> - AIX fixes
-Andre Lucas <andre.lucas@dial.pipex.com> - new login code, many fixes
+Andre Lucas <andre@ae-35.com> - new login code, many fixes
 Andreas Steinmetz <ast@domdv.de> - Shadow password expiry support
 Andrew McGill <andrewm@datrix.co.za> - SCO fixes
 Andrew Morgan <morgan@transmeta.com> - PAM bugfixes

diff --git a/ChangeLog b/ChangeLog
index a69ef5698aea16644648f7b8d0dd905100ab7c9b..c6ad9d4b451869411979382ce760a7dfb9da4253 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+20030429
+ - (djm) Add back radix.o (used by AFS support), after it went missing from
+   Makefile many moons ago
+ - (djm) Apply "owl-always-auth" patch from Openwall/Solar Designer
+ - (djm) Fix blibpath specification for AIX/gcc
+ - (djm) Some systems have basename in -lgen. Fix from ayamura@ayamura.org
+
 20030428
  - (bal) [defines.h progressmeter.c scp.c] Some more culling of non 64bit 
    hacked code.

diff --git a/Makefile.in b/Makefile.in
index 583d49140aa07c7fe624235ab01b1c2271efaa10..270b267799756244d5c1c2f62afff8e955ad3e65 100644 (file)
--- a/Makefile.in
+++ b/Makefile.in
@@ -62,7 +62,7 @@ TARGETS=ssh$(EXEEXT) sshd$(EXEEXT) ssh-add$(EXEEXT) ssh-keygen$(EXEEXT) ssh-keys
 
 LIBSSH_OBJS=authfd.o authfile.o bufaux.o buffer.o canohost.o channels.o \
        cipher.o compat.o compress.o crc32.o deattack.o fatal.o \
-       hostfile.o log.o match.o mpaux.o nchan.o packet.o readpass.o \
+       hostfile.o log.o match.o mpaux.o nchan.o packet.o radix.o readpass.o \
        rsa.o tildexpand.o ttymodes.o xmalloc.o atomicio.o \
        key.o dispatch.o kex.o mac.o uuencode.o misc.o \
        rijndael.o ssh-dss.o ssh-rsa.o dh.o kexdh.o kexgex.o \

diff --git a/auth-pam.c b/auth-pam.c
index a0ec90fe45141dbaa2b3b625f551428722128348..da624e382f645c1fd76062389b55ac6f149d8585 100644 (file)
--- a/auth-pam.c
+++ b/auth-pam.c
@@ -201,7 +201,7 @@ void do_pam_cleanup_proc(void *context)
        }
 }
 
-/* Attempt password authentation using PAM */
+/* Attempt password authentication using PAM */
 int auth_pam_password(Authctxt *authctxt, const char *password)
 {
        extern ServerOptions options;
@@ -215,13 +215,13 @@ int auth_pam_password(Authctxt *authctxt, const char *password)
        pamstate = INITIAL_LOGIN;
        pam_retval = do_pam_authenticate(
            options.permit_empty_passwd == 0 ? PAM_DISALLOW_NULL_AUTHTOK : 0);
-       if (pam_retval == PAM_SUCCESS) {
-               debug("PAM Password authentication accepted for "
-                   "user \"%.100s\"", pw->pw_name);
+       if (pam_retval == PAM_SUCCESS && pw) {
+               debug("PAM password authentication accepted for "
+                   "%.100s", pw->pw_name);
                return 1;
        } else {
-               debug("PAM Password authentication for \"%.100s\" "
-                   "failed[%d]: %s", pw->pw_name, pam_retval, 
+               debug("PAM password authentication failed for "
+                   "%.100s: %s", pw ? pw->pw_name : "an illegal user",
                    PAM_STRERROR(__pamh, pam_retval));
                return 0;
        }

diff --git a/auth-passwd.c b/auth-passwd.c
index 9901d48425ffcfd327cc24eeaae930b5d38d1a2d..62ea3a52dd6227e66f1d9292c9051ff2ff43e749 100644 (file)
--- a/auth-passwd.c
+++ b/auth-passwd.c
@@ -93,6 +93,7 @@ int
 auth_password(Authctxt *authctxt, const char *password)
 {
        struct passwd * pw = authctxt->pw;
+       int ok = authctxt->valid;
 #if !defined(USE_PAM) && !defined(HAVE_OSF_SIA)
        char *encrypted_password;
        char *pw_password;
@@ -115,19 +116,23 @@ auth_password(Authctxt *authctxt, const char *password)
 
        /* deny if no user. */
        if (pw == NULL)
-               return 0;
+               ok = 0;
 #ifndef HAVE_CYGWIN
-       if (pw->pw_uid == 0 && options.permit_root_login != PERMIT_YES)
-               return 0;
+       if (pw && pw->pw_uid == 0 && options.permit_root_login != PERMIT_YES)
+               ok = 0;
 #endif
        if (*password == '\0' && options.permit_empty_passwd == 0)
-               return 0;
+               ok = 0;
 
 #if defined(USE_PAM)
-       return auth_pam_password(authctxt, password);
+       return auth_pam_password(authctxt, password) && ok;
 #elif defined(HAVE_OSF_SIA)
+       if (!ok)
+               return 0;
        return auth_sia_password(authctxt, password);
 #else
+       if (!ok)
+               return 0;
 # ifdef KRB5
        if (options.kerberos_authentication == 1) {
                int ret = auth_krb5_password(authctxt, password);

diff --git a/auth2-none.c b/auth2-none.c
index c07b2dd814883e80969e780538028d4250845cb1..692a2961f9e7b10cfbfd26d44c78cd725eed950d 100644 (file)
--- a/auth2-none.c
+++ b/auth2-none.c
@@ -100,7 +100,7 @@ userauth_none(Authctxt *authctxt)
        if (check_nt_auth(1, authctxt->pw) == 0)
                return(0);
 #endif
-       return (authctxt->valid ? PRIVSEP(auth_password(authctxt, "")) : 0);
+       return PRIVSEP(auth_password(authctxt, "")) && authctxt->valid;
 }
 
 Authmethod method_none = {

diff --git a/auth2-passwd.c b/auth2-passwd.c
index a8f15161ac89e2bf3f4162b1c00d37884b9baf81..3c2734b56df55bed804fa1c6522be6b2af970f48 100644 (file)
--- a/auth2-passwd.c
+++ b/auth2-passwd.c
@@ -47,11 +47,11 @@ userauth_passwd(Authctxt *authctxt)
                logit("password change not supported");
        password = packet_get_string(&len);
        packet_check_eom();
-       if (authctxt->valid &&
+       if (PRIVSEP(auth_password(authctxt, password)) == 1 && authctxt->valid
 #ifdef HAVE_CYGWIN
-           check_nt_auth(1, authctxt->pw) &&
+           && check_nt_auth(1, authctxt->pw)
 #endif
-           PRIVSEP(auth_password(authctxt, password)) == 1)
+           )
                authenticated = 1;
        memset(password, 0, len);
        xfree(password);

diff --git a/configure.ac b/configure.ac
index ef937f13ccdb8284869db8ee413f944d75431ddd..dfd87c9d07745eea01af92d63d6e716920851e56 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -57,20 +57,24 @@ case "$host" in
        AFS_LIBS="-lld"
        CPPFLAGS="$CPPFLAGS -I/usr/local/include"
        LDFLAGS="$LDFLAGS -L/usr/local/lib"
-       if (test "$LD" != "gcc" && test -z "$blibpath"); then
-               AC_MSG_CHECKING([if linkage editor ($LD) accepts -blibpath])
-               saved_LDFLAGS="$LDFLAGS"
-               LDFLAGS="$LDFLAGS -blibpath:/usr/lib:/lib:/usr/local/lib"
-               AC_TRY_LINK([],
-                       [],
-                       [
-                               AC_MSG_RESULT(yes)
-                               blibpath="/usr/lib:/lib:/usr/local/lib"
-                       ],
-                       [ AC_MSG_RESULT(no) ]
-               )
-               LDFLAGS="$saved_LDFLAGS"
+       AC_MSG_CHECKING([how to specify blibpath for linker ($LD)]) 
+       if (test -z "$blibpath"); then
+               blibpath="/usr/lib:/lib:/usr/local/lib"
+       fi
+       saved_LDFLAGS="$LDFLAGS"
+       for tryflags in -blibpath: -Wl,-blibpath: -Wl,-rpath, ;do
+               if (test -z "$blibflags"); then
+                       LDFLAGS="$saved_LDFLAGS $tryflags$blibpath"
+                       AC_TRY_LINK([], [], [blibflags=$tryflags])
+               fi
+       done
+       if (test -z "$blibflags"); then
+               AC_MSG_RESULT(not found)
+               AC_MSG_ERROR([*** must be able to specify blibpath on AIX - check config.log])
+       else
+               AC_MSG_RESULT($blibflags)
        fi
+       LDFLAGS="$saved_LDFLAGS"
        AC_CHECK_FUNC(authenticate, [AC_DEFINE(WITH_AIXAUTHENTICATE)],
                [AC_CHECK_LIB(s,authenticate,
                        [ AC_DEFINE(WITH_AIXAUTHENTICATE)
@@ -618,6 +622,7 @@ AC_CHECK_FUNCS(\
 )
 
 AC_SEARCH_LIBS(nanosleep, rt posix4, AC_DEFINE(HAVE_NANOSLEEP))
+AC_SEARCH_LIBS(basename, gen, AC_DEFINE(HAVE_BASENAME))
 
 dnl Make sure strsep prototype is defined before defining HAVE_STRSEP
 AC_CHECK_DECL(strsep, [AC_CHECK_FUNCS(strsep)])
@@ -2473,8 +2478,8 @@ fi
 
 
 if test ! -z "$blibpath" ; then
-       LDFLAGS="$LDFLAGS -blibpath:$blibpath"
-       AC_MSG_WARN([Please check and edit -blibpath in LDFLAGS in Makefile])
+       LDFLAGS="$LDFLAGS $blibflags$blibpath"
+       AC_MSG_WARN([Please check and edit blibpath in LDFLAGS in Makefile])
 fi
 
 dnl remove pam and dl because they are in $LIBPAM

diff --git a/contrib/caldera/openssh.spec b/contrib/caldera/openssh.spec
index 63aaa2124b32519a1197ce279056261f03a7223a..68e59c76b890a890c4a1d8a7b096dcb04fb5e27c 100644 (file)
--- a/contrib/caldera/openssh.spec
+++ b/contrib/caldera/openssh.spec
@@ -17,7 +17,7 @@
 #old cvs stuff.  please update before use.  may be deprecated.
 %define use_stable     1
 %if %{use_stable}
-  %define version      3.6.1p1
+  %define version      3.6.1p2
   %define cvs          %{nil}
   %define release      2
 %else

diff --git a/contrib/redhat/openssh.spec b/contrib/redhat/openssh.spec
index 11d86a83c16a70f48f03b93c6f58d635062cf270..8809ded7094ae7c574db1894dc8da318ce4f1184 100644 (file)
--- a/contrib/redhat/openssh.spec
+++ b/contrib/redhat/openssh.spec
@@ -1,5 +1,5 @@
-%define ver 3.6.1p1
-%define rel 2
+%define ver 3.6.1p2
+%define rel 1
 
 # OpenSSH privilege separation requires a user & group ID
 %define sshd_uid    74

diff --git a/contrib/suse/openssh.spec b/contrib/suse/openssh.spec
index 194dbb7d10b3776dfff06464a67d7f4e15377812..707c3a221d8bbe3d674dc1ec4c0dc4a628c5d11f 100644 (file)
--- a/contrib/suse/openssh.spec
+++ b/contrib/suse/openssh.spec
@@ -1,6 +1,6 @@
 Summary: OpenSSH, a free Secure Shell (SSH) protocol implementation
 Name: openssh
-Version: 3.6.1p1
+Version: 3.6.1p2
 URL: http://www.openssh.com/
 Release: 1
 Source0: openssh-%{version}.tar.gz

diff --git a/monitor.c b/monitor.c
index 46db0e9b0b113ebd4463a7b70ef2c4e7c1eeb2c2..99b4d56ec5bb656ce0c7fb373b0a3af4047d0475 100644 (file)
--- a/monitor.c
+++ b/monitor.c
@@ -606,7 +606,7 @@ mm_answer_authpassword(int socket, Buffer *m)
        passwd = buffer_get_string(m, &plen);
        /* Only authenticate if the context is valid */
        authenticated = options.password_authentication &&
-           authctxt->valid && auth_password(authctxt, passwd);
+           auth_password(authctxt, passwd) && authctxt->valid;
        memset(passwd, 0, strlen(passwd));
        xfree(passwd);
 

diff --git a/version.h b/version.h
index 75a2b2554c4ab17990f7fe01b6d57193c81e24a3..3b2a35d9160768369712db276c0204c79641572c 100644 (file)
--- a/version.h
+++ b/version.h
@@ -1,3 +1,3 @@
 /* $OpenBSD: version.h,v 1.37 2003/04/01 10:56:46 markus Exp $ */
 
-#define SSH_VERSION    "OpenSSH_3.6.1p1"
+#define SSH_VERSION    "OpenSSH_3.6.1p2"