- dtucker@cvs.openbsd.org 2004/12/11 01:48:56

     [auth-rsa.c auth2-pubkey.c authfile.c misc.c misc.h]
     Fix debug call in error path of authorized_keys processing and fix related
     warnings; ok djm@

diff --git a/ChangeLog b/ChangeLog
index 0893cc400ac5ed91a6977131978898ca961fff60..a970c7bb04b10254b9929c7354d27d46d045188e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -12,6 +12,10 @@
        ignore).
      - don't do extra do_lstat() if we only have one matching file.
      djm@ ok
+   - dtucker@cvs.openbsd.org 2004/12/11 01:48:56
+     [auth-rsa.c auth2-pubkey.c authfile.c misc.c misc.h]
+     Fix debug call in error path of authorized_keys processing and fix related
+     warnings; ok djm@
 
 20041208
  - (tim) [configure.ac] Comment some non obvious platforms in the

diff --git a/auth-rsa.c b/auth-rsa.c
index 2060f8394587fe316ee6387879989f17428140bd..4378008d36166a0b031438fcfe0cce12f89dcc3a 100644 (file)
--- a/auth-rsa.c
+++ b/auth-rsa.c
@@ -14,7 +14,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: auth-rsa.c,v 1.61 2004/12/06 11:41:03 dtucker Exp $");
+RCSID("$OpenBSD: auth-rsa.c,v 1.62 2004/12/11 01:48:56 dtucker Exp $");
 
 #include <openssl/rsa.h>
 #include <openssl/md5.h>
@@ -33,6 +33,7 @@ RCSID("$OpenBSD: auth-rsa.c,v 1.61 2004/12/06 11:41:03 dtucker Exp $");
 #include "hostfile.h"
 #include "monitor_wrap.h"
 #include "ssh.h"
+#include "misc.h"
 
 /* import */
 extern ServerOptions options;

diff --git a/auth2-pubkey.c b/auth2-pubkey.c
index 41e23bebd0f2567d995e3bb1ecbd4ba7589bf3e7..a97d0f430b93f298b0111ac6e8eeb8d78db15caf 100644 (file)
--- a/auth2-pubkey.c
+++ b/auth2-pubkey.c
@@ -23,7 +23,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: auth2-pubkey.c,v 1.8 2004/12/06 11:41:03 dtucker Exp $");
+RCSID("$OpenBSD: auth2-pubkey.c,v 1.9 2004/12/11 01:48:56 dtucker Exp $");
 
 #include "ssh.h"
 #include "ssh2.h"
@@ -41,6 +41,7 @@ RCSID("$OpenBSD: auth2-pubkey.c,v 1.8 2004/12/06 11:41:03 dtucker Exp $");
 #include "auth-options.h"
 #include "canohost.h"
 #include "monitor_wrap.h"
+#include "misc.h"
 
 /* import */
 extern ServerOptions options;

diff --git a/authfile.c b/authfile.c
index 4038ab6922fdc7d3c7bc6731b5259874378b6f34..6a04cd7a95a290caa9b806b221a374fd3d478ed0 100644 (file)
--- a/authfile.c
+++ b/authfile.c
@@ -36,7 +36,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: authfile.c,v 1.59 2004/12/06 11:41:03 dtucker Exp $");
+RCSID("$OpenBSD: authfile.c,v 1.60 2004/12/11 01:48:56 dtucker Exp $");
 
 #include <openssl/err.h>
 #include <openssl/evp.h>
@@ -51,6 +51,7 @@ RCSID("$OpenBSD: authfile.c,v 1.59 2004/12/06 11:41:03 dtucker Exp $");
 #include "log.h"
 #include "authfile.h"
 #include "rsa.h"
+#include "misc.h"
 
 /* Version identification string for SSH v1 identity files. */
 static const char authfile_id_string[] =
@@ -603,7 +604,7 @@ key_try_load_public(Key *k, const char *filename, char **commentp)
        FILE *f;
        char line[SSH_MAX_PUBKEY_BYTES];
        char *cp;
-       int linenum = 0;
+       u_long linenum = 0;
 
        f = fopen(filename, "r");
        if (f != NULL) {

diff --git a/misc.c b/misc.c
index d0cc538230b3c77d2a02137bfe1a8c4d8d9e8d0e..a9012550598dedf9513ca235ab3c93dc27ce868e 100644 (file)
--- a/misc.c
+++ b/misc.c
@@ -23,7 +23,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: misc.c,v 1.26 2004/12/06 11:41:03 dtucker Exp $");
+RCSID("$OpenBSD: misc.c,v 1.27 2004/12/11 01:48:56 dtucker Exp $");
 
 #include "misc.h"
 #include "log.h"
@@ -339,15 +339,15 @@ addargs(arglist *args, char *fmt, ...)
  */
 int
 read_keyfile_line(FILE *f, const char *filename, char *buf, size_t bufsz,
-   int *lineno)
+   u_long *lineno)
 {
        while (fgets(buf, bufsz, f) != NULL) {
                (*lineno)++;
                if (buf[strlen(buf) - 1] == '\n' || feof(f)) {
                        return 0;
                } else {
-                       debug("%s: %s line %d exceeds size limit", __func__,
-                           filename, lineno);
+                       debug("%s: %s line %lu exceeds size limit", __func__,
+                           filename, *lineno);
                        /* discard remainder of line */
                        while(fgetc(f) != '\n' && !feof(f))
                                ;       /* nothing */

diff --git a/misc.h b/misc.h
index 4aab2ca0135b734a8dc6b26f15caa15bdd52eb27..193216fa942a9a7da9903abc101b842cfe71a9a7 100644 (file)
--- a/misc.h
+++ b/misc.h
@@ -1,4 +1,4 @@
-/*     $OpenBSD: misc.h,v 1.19 2004/12/06 11:41:03 dtucker Exp $       */
+/*     $OpenBSD: misc.h,v 1.20 2004/12/11 01:48:56 dtucker Exp $       */
 
 /*
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
@@ -47,4 +47,4 @@ char  *tilde_expand_filename(const char *, uid_t);
 
 char   *read_passphrase(const char *, int);
 int     ask_permission(const char *, ...) __attribute__((format(printf, 1, 2)));
-int     read_keyfile_line(FILE *, const char *, char *, size_t, int *);
+int     read_keyfile_line(FILE *, const char *, char *, size_t, u_long *);