2 - (dtucker) OpenBSD CVS Sync
3 - dtucker@cvs.openbsd.org 2009/06/22 05:39:28
4 [monitor_wrap.c monitor_mm.c ssh-keygen.c auth2.c gss-genr.c sftp-client.c]
5 alphabetize includes; reduces diff vs portable and style(9).
7 (Id sync only; these were already in order in -portable)
10 - (dtucker) OpenBSD CVS Sync
11 - markus@cvs.openbsd.org 2009/03/17 21:37:00
13 pass correct argv[0] to openlog(); ok djm@
14 - jmc@cvs.openbsd.org 2009/03/19 15:15:09
16 for "Ciphers", just point the reader to the keyword in ssh_config(5), just
17 as we do for "MACs": this stops us getting out of sync when the lists
19 fixes documentation/6102, submitted by Peter J. Philipp
20 alternative fix proposed by djm
22 - tobias@cvs.openbsd.org 2009/03/23 08:31:19
24 Fixed a possible out-of-bounds memory access if the environment variable
25 SHELL is shorter than 3 characters.
26 with input by and ok dtucker
27 - tobias@cvs.openbsd.org 2009/03/23 19:38:04
29 My previous commit didn't fix the problem at all, so stick at my first
30 version of the fix presented to dtucker.
31 Issue notified by Matthias Barkhoff (matthias dot barkhoff at gmx dot de).
33 - sobrado@cvs.openbsd.org 2009/03/26 08:38:39
34 [sftp-server.8 sshd.8 ssh-agent.1]
35 fix a few typographical errors found by spell(1).
37 - stevesk@cvs.openbsd.org 2009/04/13 19:07:44
39 fix possessive; ok djm@
40 - stevesk@cvs.openbsd.org 2009/04/14 16:33:42
42 remove unused option character from getopt() optstring; ok markus@
43 - jj@cvs.openbsd.org 2009/04/14 21:10:54
45 Fixed a few the-the misspellings in comments. Skipped a bunch in
46 binutils,gcc and so on. ok jmc@
47 - stevesk@cvs.openbsd.org 2009/04/17 19:23:06
49 use INTERNAL_SFTP_NAME for setproctitle() of in-process sftp-server;
51 - stevesk@cvs.openbsd.org 2009/04/17 19:40:17
53 clarify that even internal-sftp needs /dev/log for logging to work; ok
55 - jmc@cvs.openbsd.org 2009/04/18 18:39:10
57 tweak previous; ok stevesk
58 - stevesk@cvs.openbsd.org 2009/04/21 15:13:17
60 clarify we cd to user's home after chroot; ok markus@ on
61 earlier version; tweaks and ok jmc@
62 - andreas@cvs.openbsd.org 2009/05/25 06:48:01
63 [channels.c packet.c clientloop.c packet.h serverloop.c monitor_wrap.c
65 Put the globals in packet.c into a struct and don't access it directly
66 from other files. No functional changes.
68 - andreas@cvs.openbsd.org 2009/05/27 06:31:25
69 [canohost.h canohost.c]
70 Add clear_cached_addr(), needed for upcoming changes allowing the peer
73 - andreas@cvs.openbsd.org 2009/05/27 06:33:39
75 Send SSH2_MSG_DISCONNECT when the client disconnects. From a larger
76 change from Martin Forssen, maf at appgate dot com.
78 - andreas@cvs.openbsd.org 2009/05/27 06:34:36
80 Move the KEX_COOKIE_LEN define to kex.h
82 - andreas@cvs.openbsd.org 2009/05/27 06:36:07
84 Add packet_put_int64() and packet_get_int64(), part of a larger change
87 - andreas@cvs.openbsd.org 2009/05/27 06:38:16
88 [sshconnect.h sshconnect.c]
89 Un-static ssh_exchange_identification(), part of a larger change from
90 Martin Forssen and needed for upcoming changes.
92 - andreas@cvs.openbsd.org 2009/05/28 16:50:16
93 [sshd.c packet.c serverloop.c monitor_wrap.c clientloop.c sshconnect.c
94 monitor.c Added roaming.h roaming_common.c roaming_dummy.c]
95 Keep track of number of bytes read and written. Needed for upcoming
96 changes. Most code from Martin Forssen, maf at appgate dot com.
98 Also, applied appropriate changes to Makefile.in
99 - andreas@cvs.openbsd.org 2009/06/12 20:43:22
101 Fix warnings found by chl@ and djm@ and change roaming_atomicio's
102 return type to match atomicio's
103 Diff from djm@, ok markus@
104 - andreas@cvs.openbsd.org 2009/06/12 20:58:32
106 Move some more statics into session_state
108 - dtucker@cvs.openbsd.org 2009/06/21 07:37:15
110 abort if key_sign fails, preventing possible null deref. Based on report
111 from Paolo Ganci, ok markus@ djm@
112 - dtucker@cvs.openbsd.org 2009/06/21 09:04:03
113 [roaming.h roaming_common.c roaming_dummy.c]
114 Add tags for the benefit of the sync scripts
115 Also: pull in the changes for 1.1->1.2 missed in the previous sync.
116 - (dtucker) [auth2-jpake.c auth2.c canohost.h session.c] Whitespace and
117 header-order changes to reduce diff vs OpenBSD.
118 - (dtucker) [servconf.c sshd.c] More whitespace sync.
119 - (dtucker) [roaming_common.c roaming_dummy.c] Wrap #include <inttypes.h> in
123 - (dtucker) [configure.ac defines.h] Bug #1607: handle the case where fsid_t
124 is a struct with a __val member. Fixes build on, eg, Redhat 6.2.
127 - (dtucker) [sshlogin.c] Move the NO_SSH_LASTLOG #ifndef line to include
128 variable declarations. Should prevent unused warnings anywhere it's set
129 (only Crays as far as I can tell) and be a no-op everywhere else.
132 - (tim) [configure.ac] Remove setting IP_TOS_IS_BROKEN for Cygwin. The problem
133 that setsockopt(IP_TOS) doesn't work on Cygwin has been fixed since 2005.
134 Based on patch from vinschen at redhat com.
137 - (dtucker) [auth-passwd.c auth1.c auth2-kbdint.c auth2-none.c auth2-passwd.c
138 auth2-pubkey.c session.c openbsd-compat/bsd-cygwin_util.{c,h}
139 openbsd-compat/daemon.c] Remove support for Windows 95/98/ME and very old
140 version of Cygwin. Patch from vinschen at redhat com.
143 - (dtucker) [contrib/aix/buildbff.sh] Only try to rename ssh_prng_cmds if it
144 exists (it's not created if OpenSSL's PRNG is self-seeded, eg if the OS
146 - (dtucker) [schnorr.c openbsd-compat/openssl-compat.{c,h}] Add
147 EVP_DigestUpdate to the OLD_EVP compatibility functions and tell schnorr.c
148 to use them. Allows building with older OpenSSL versions.
149 - (dtucker) [configure.ac defines.h] Check for in_port_t and typedef if needed.
150 - (dtucker) [configure.ac] Missing comma in type list.
151 - (dtucker) [configure.ac openbsd-compat/openssl-compat.{c,h}]
152 EVP_DigestUpdate does not exactly match the other OLD_EVP functions (eg
153 in openssl 0.9.6) so add an explicit test for it.
156 - (djm) OpenBSD CVS Sync
157 - djm@cvs.openbsd.org 2009/03/05 07:18:19
158 [auth2-jpake.c jpake.c jpake.h monitor_wrap.c monitor_wrap.h schnorr.c]
160 refactor the (disabled) Schnorr proof code to make it a little more
162 - djm@cvs.openbsd.org 2009/03/05 11:30:50
164 document what these functions do so I don't ever have to recuse into
165 b64_pton/ntop to remember their return values
168 - (djm) OpenBSD CVS Sync
169 - djm@cvs.openbsd.org 2009/02/22 23:50:57
170 [ssh_config.5 sshd_config.5]
171 don't advertise experimental options
172 - djm@cvs.openbsd.org 2009/02/22 23:59:25
175 - djm@cvs.openbsd.org 2009/02/23 00:06:15
178 - (djm) [README] update for 5.2
179 - (djm) Release openssh-5.2p1
182 - (djm) OpenBSD CVS Sync
183 - tobias@cvs.openbsd.org 2009/02/21 19:32:04
184 [misc.c sftp-server-main.c ssh-keygen.c]
185 Added missing newlines in error messages.
189 - (djm) OpenBSD CVS Sync
190 - djm@cvs.openbsd.org 2009/02/17 01:28:32
192 sync with revised default ciphers; pointed out by dkrause@
193 - djm@cvs.openbsd.org 2009/02/18 04:31:21
195 signature should hash over the entire group, not just the generator
196 (this is still disabled code)
197 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
198 [contrib/suse/openssh.spec] Prepare for 5.2p1
201 - (djm) [regress/conch-ciphers.sh regress/putty-ciphers.sh]
202 [regress/putty-kex.sh regress/putty-transfer.sh] Downgrade disabled
203 interop tests from FATAL error to a warning. Allows some interop
204 tests to proceed if others are missing necessary prerequisites.
205 - (djm) [configure.ac] support GNU/kFreeBSD and GNU/kOpensolaris
206 systems; patch from Aurelien Jarno via rmh AT aybabtu.com
209 - (djm) OpenBSD CVS Sync
210 - dtucker@cvs.openbsd.org 2009/02/02 11:15:14
212 Initialize a few variables to prevent spurious "may be used
213 uninitialized" warnings from newer gcc's. ok djm@
214 - djm@cvs.openbsd.org 2009/02/12 03:00:56
215 [canohost.c canohost.h channels.c channels.h clientloop.c readconf.c]
216 [readconf.h serverloop.c ssh.c]
217 support remote port forwarding with a zero listen port (-R0:...) to
218 dyamically allocate a listen port at runtime (this is actually
219 specified in rfc4254); bz#1003 ok markus@
220 - djm@cvs.openbsd.org 2009/02/12 03:16:01
222 tighten check for -R0:... forwarding: only allow dynamic allocation
223 if want_reply is set in the packet
224 - djm@cvs.openbsd.org 2009/02/12 03:26:22
226 some paranoia: check that the serialised key is really KEY_RSA before
227 diddling its internals
228 - djm@cvs.openbsd.org 2009/02/12 03:42:09
230 document -R0:... usage
231 - djm@cvs.openbsd.org 2009/02/12 03:44:25
233 consistency: Dq => Ql
234 - djm@cvs.openbsd.org 2009/02/12 03:46:17
236 document RemoteForward usage with 0 listen port
237 - jmc@cvs.openbsd.org 2009/02/12 07:34:20
239 kill trailing whitespace;
240 - markus@cvs.openbsd.org 2009/02/13 11:50:21
242 check for enc !=NULL in packet_start_discard
243 - djm@cvs.openbsd.org 2009/02/14 06:35:49
245 mention that eow and no-more-sessions extensions are sent only to
249 - (djm) [sshpty.c] bz#1419: OSX uses cloning ptys that automagically
250 set ownership and modes, so avoid explicitly setting them
251 - (djm) [configure.ac loginrec.c] bz#1421: fix lastlog support for OSX.
252 OSX provides a getlastlogxbyname function that automates the reading of
253 a lastlog file. Also, the pututxline function will update lastlog so
254 there is no need for loginrec.c to do it explicitly. Collapse some
255 overly verbose code while I'm in there.
258 - (dtucker) [defines.h sshconnect.c] INET6_ADDRSTRLEN is now needed in
259 channels.c too, so move the definition for non-IP6 platforms to defines.h
260 where it can be shared.
263 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
264 If the CYGWIN environment variable is empty, the installer script
265 should not install the service with an empty CYGWIN variable, but
266 rather without setting CYGWNI entirely.
267 - (tim) [contrib/cygwin/ssh-host-config] Whitespace cleanup. No code changes.
270 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
271 Changes to work on Cygwin 1.5.x as well as on the new Cygwin 1.7.x.
272 The information given for the setting of the CYGWIN environment variable
273 is wrong for both releases so I just removed it, together with the
274 unnecessary (Cygwin 1.5.x) or wrong (Cygwin 1.7.x) default setting.
277 - (djm) OpenBSD CVS Sync
278 - stevesk@cvs.openbsd.org 2008/12/09 03:20:42
279 [channels.c servconf.c]
280 channel_print_adm_permitted_opens() should deal with all the printing
281 for that config option. suggested by markus@; ok markus@ djm@
283 - djm@cvs.openbsd.org 2008/12/09 04:32:22
285 replace by-hand string building with xasprinf(); ok deraadt@
286 - sobrado@cvs.openbsd.org 2008/12/09 15:35:00
288 update for the synopses displayed by the 'help' command, there are a
289 few missing flags; add 'bye' to the output of 'help'; sorting and spacing.
290 jmc@ suggested replacing .Oo/.Oc with a single .Op macro.
292 - stevesk@cvs.openbsd.org 2008/12/09 22:37:33
294 fix typo in error message
295 - stevesk@cvs.openbsd.org 2008/12/10 03:55:20
297 o cannot be NULL here but use xfree() to be consistent; ok djm@
298 - stevesk@cvs.openbsd.org 2008/12/29 01:12:36
300 fix example, default key type is rsa for 3+ years; from
301 frederic.perrin@resel.fr
302 - stevesk@cvs.openbsd.org 2008/12/29 02:23:26
304 no need to escape single quotes in comments
305 - okan@cvs.openbsd.org 2008/12/30 00:46:56
307 add AllowAgentForwarding to available Match keywords list
309 - djm@cvs.openbsd.org 2009/01/01 21:14:35
311 call channel destroy callbacks on receipt of open failure messages.
312 fixes client hangs when connecting to a server that has MaxSessions=0
313 set spotted by imorgan AT nas.nasa.gov; ok markus@
314 - djm@cvs.openbsd.org 2009/01/01 21:17:36
316 fix hash calculation for KEXGEX: hash over the original client-supplied
317 values and not the sanity checked versions that we acutally use;
318 bz#1540 reported by john.smith AT arrows.demon.co.uk
320 - djm@cvs.openbsd.org 2009/01/14 01:38:06
322 support SOCKS4A protocol, from dwmw2 AT infradead.org via bz#1482;
324 - stevesk@cvs.openbsd.org 2009/01/15 17:38:43
326 1) use obsolete instead of alias for consistency
327 2) oUserKnownHostsFile not obsolete but oGlobalKnownHostsFile2 is
329 3) reorder so like options are together
331 - djm@cvs.openbsd.org 2009/01/22 09:46:01
332 [channels.c channels.h session.c]
333 make Channel->path an allocated string, saving a few bytes here and
334 there and fixing bz#1380 in the process; ok markus@
335 - djm@cvs.openbsd.org 2009/01/22 09:49:57
337 oops! I committed the wrong version of the Channel->path diff,
338 it was missing some tweaks suggested by stevesk@
339 - djm@cvs.openbsd.org 2009/01/22 10:02:34
340 [clientloop.c misc.c readconf.c readconf.h servconf.c servconf.h]
341 [serverloop.c ssh-keyscan.c ssh.c sshd.c]
342 make a2port() return -1 when it encounters an invalid port number
343 rather than 0, which it will now treat as valid (needed for future work)
344 adjust current consumers of a2port() to check its return value is <= 0,
345 which in turn required some things to be converted from u_short => int
346 make use of int vs. u_short consistent in some other places too
347 feedback & ok markus@
348 - djm@cvs.openbsd.org 2009/01/22 10:09:16
350 another chunk of a2port() diff that got away. wtfdjm??
351 - djm@cvs.openbsd.org 2009/01/23 07:58:11
353 prefer CTR modes and revised arcfour (i.e w/ discard) modes to CBC
355 - naddy@cvs.openbsd.org 2009/01/24 17:10:22
356 [ssh_config.5 sshd_config.5]
357 sync list of preferred ciphers; ok djm@
358 - markus@cvs.openbsd.org 2009/01/26 09:58:15
359 [cipher.c cipher.h packet.c]
360 Work around the CPNI-957037 Plaintext Recovery Attack by always
361 reading 256K of data on packet size or HMAC errors (in CBC mode only).
362 Help, feedback and ok djm@
363 Feedback from Martin Albrecht and Paterson Kenny
366 - (djm) [uidswap.c] bz#1412: Support >16 supplemental groups in OS X.
367 Patch based on one from vgiffin AT apple.com; ok dtucker@
368 - (djm) [channels.c] bz#1419: support "on demand" X11 forwarding via
369 launchd on OS X; patch from vgiffin AT apple.com, slightly tweaked;
371 - (djm) [contrib/ssh-copy-id.1 contrib/ssh-copy-id] bz#1492: Make
372 ssh-copy-id copy id_rsa.pub by default (instead of the legacy "identity"
373 key). Patch from cjwatson AT debian.org
376 - (tim) [configure.ac defines.h openbsd-compat/port-uw.c
377 openbsd-compat/xcrypt.c] Add SECUREWARE support to OpenServer 6 SVR5 ABI.
379 - (tim) [configure.ac] Move check_for_libcrypt_later=1 in *-*-sysv5*) section.
380 OpenServer 6 doesn't need libcrypt.
383 - (djm) OpenBSD CVS Sync
384 - djm@cvs.openbsd.org 2008/12/09 02:38:18
386 The ~C escape handler does not work correctly for multiplexed sessions -
387 it opens a commandline on the master session, instead of on the slave
388 that requested it. Disable it on slave sessions until such time as it
389 is fixed; bz#1543 report from Adrian Bridgett via Colin Watson
391 - djm@cvs.openbsd.org 2008/12/09 02:39:59
393 Deal correctly with failures in remote stat() operation in sftp,
394 correcting fail-on-error behaviour in batchmode. bz#1541 report and
395 fix from anedvedicky AT gmail.com; ok markus@
396 - djm@cvs.openbsd.org 2008/12/09 02:58:16
398 don't leave junk (free'd) pointers around in Forward *fwd argument on
399 failure; avoids double-free in ~C -L handler when given an invalid
400 forwarding specification; bz#1539 report from adejong AT debian.org
401 via Colin Watson; ok markus@ dtucker@
402 - djm@cvs.openbsd.org 2008/12/09 03:02:37
404 correct sftp(1) and corresponding usage syntax;
405 bz#1518 patch from imorgan AT nas.nasa.gov; ok deraadt@ improved diff jmc@
408 - (djm) [configure.ac] bz#1538: better test for ProPolice/SSP: actually
409 use some stack in main().
410 Report and suggested fix from vapier AT gentoo.org
411 - (djm) OpenBSD CVS Sync
412 - markus@cvs.openbsd.org 2008/12/02 19:01:07
414 we have to use the recipient's channel number (RFC 4254) for
415 SSH2_MSG_CHANNEL_SUCCESS/SSH2_MSG_CHANNEL_FAILURE messages,
416 otherwise we trigger 'Non-public channel' error messages on sshd
417 systems with clientkeepalive enabled; noticed by sturm; ok djm;
418 - markus@cvs.openbsd.org 2008/12/02 19:08:59
420 backout 1.149, since it's not necessary and openssh clients send
421 broken CHANNEL_FAILURE/SUCCESS messages since about 2004; ok djm@
422 - markus@cvs.openbsd.org 2008/12/02 19:09:38
424 s/remote_id/id/ to be more consistent with other code; ok djm@
427 - (dtucker) [contrib/cygwin/{Makefile,ssh-host-config}] Add new doc files
428 and tweak the is-sshd-running check in ssh-host-config. Patch from
429 vinschen at redhat com.
430 - (dtucker) OpenBSD CVS Sync
431 - markus@cvs.openbsd.org 2008/11/21 15:47:38
433 packet_disconnect() on padding error, too. should reduce the success
434 probability for the CPNI-957037 Plaintext Recovery Attack to 2^-18
436 - dtucker@cvs.openbsd.org 2008/11/30 11:59:26
438 Retry sendmsg/recvmsg on EAGAIN and EINTR; ok djm@
441 - (dtucker) [monitor_fdpass.c] Reduce diff vs OpenBSD by moving some
442 declarations, removing an unnecessary union member and adding whitespace.
443 cmsgbuf.tmp thing spotted by des at des no, ok djm some time ago.
446 - (tim) [addrmatch.c configure.ac] Some platforms do not have sin6_scope_id
447 member of sockaddr_in6. Also reported in Bug 1491 by David Leonard. OK and
451 - (dtucker) OpenBSD CVS Sync
452 - jmc@cvs.openbsd.org 2008/11/05 11:22:54
455 fixes user/5975 from Rene Maroufi
456 - stevesk@cvs.openbsd.org 2008/11/07 00:42:12
458 spelling/typo in comment
459 - stevesk@cvs.openbsd.org 2008/11/07 18:50:18
461 add space to some log/debug messages for readability; ok djm@ markus@
462 - dtucker@cvs.openbsd.org 2008/11/07 23:34:48
464 Move JPAKE define to make life easier for portable. ok djm@
465 - tobias@cvs.openbsd.org 2008/11/09 12:34:47
467 typo fixed (overriden -> overridden)
469 - stevesk@cvs.openbsd.org 2008/11/11 02:58:09
471 USE_AFS not referenced so remove #ifdef. fixes sshd -T not printing
472 kerberosgetafstoken. ok dtucker@
473 (Id sync only, we still want the ifdef in portable)
474 - stevesk@cvs.openbsd.org 2008/11/11 03:55:11
476 for sshd -T print 'permitopen any' vs. 'permitopen' for case of no
477 permitopen's; ok and input dtucker@
478 - djm@cvs.openbsd.org 2008/11/10 02:06:35
479 [regress/putty-ciphers.sh]
480 PuTTY supports AES CTR modes, so interop test against them too
484 - djm@cvs.openbsd.org 2008/11/03 08:59:41
486 include MaxSessions in sshd -T output; patch from imorgan AT nas.nasa.gov
487 - djm@cvs.openbsd.org 2008/11/04 07:58:09
489 need unistd.h for close() prototype
491 - djm@cvs.openbsd.org 2008/11/04 08:22:13
492 [auth.h auth2.c monitor.c monitor.h monitor_wrap.c monitor_wrap.h]
493 [readconf.c readconf.h servconf.c servconf.h ssh2.h ssh_config.5]
494 [sshconnect2.c sshd_config.5 jpake.c jpake.h schnorr.c auth2-jpake.c]
496 Add support for an experimental zero-knowledge password authentication
497 method using the J-PAKE protocol described in F. Hao, P. Ryan,
498 "Password Authenticated Key Exchange by Juggling", 16th Workshop on
499 Security Protocols, Cambridge, April 2008.
501 This method allows password-based authentication without exposing
502 the password to the server. Instead, the client and server exchange
503 cryptographic proofs to demonstrate of knowledge of the password while
504 revealing nothing useful to an attacker or compromised endpoint.
506 This is experimental, work-in-progress code and is presently
507 compiled-time disabled (turn on -DJPAKE in Makefile.inc).
509 "just commit it. It isn't too intrusive." deraadt@
510 - stevesk@cvs.openbsd.org 2008/11/04 19:18:00
512 because parse_forward() is now used to parse all forward types (DLR),
513 and it malloc's space for host variables, we don't need to malloc
514 here. fixes small memory leaks.
516 previously dynamic forwards were not parsed in parse_forward() and
517 space was not malloc'd in that case.
520 - stevesk@cvs.openbsd.org 2008/11/05 03:23:09
522 add dynamic forward escape command line; ok djm@
526 - sthen@cvs.openbsd.org 2008/07/24 23:55:30
528 Add "ssh-keygen -F -l" to synopsis (displays fingerprint from
529 known_hosts). ok djm@
530 - grunk@cvs.openbsd.org 2008/07/25 06:56:35
532 Add VisualHostKey to example file, ok djm@
533 - grunk@cvs.openbsd.org 2008/07/25 07:05:16
535 In random art visualization, make sure to use the end marker only at the
536 end. Initial diff by Dirk Loss, tweaks and ok djm@
537 - markus@cvs.openbsd.org 2008/07/31 14:48:28
539 don't allocate space for empty banners; report t8m at centrum.cz;
541 - krw@cvs.openbsd.org 2008/08/02 04:29:51
543 whitepsace -> whitespace. From Matthew Clarke via bugs@.
544 - djm@cvs.openbsd.org 2008/08/21 04:09:57
546 allow ForceCommand internal-sftp with arguments. based on patch from
547 michael.barabanov AT gmail.com; ok markus@
548 - djm@cvs.openbsd.org 2008/09/06 12:24:13
550 OpenSSL 0.9.8h supplies a real EVP_sha256 so we do not need our
552 (ID sync only for portable - we still need this)
553 - markus@cvs.openbsd.org 2008/09/11 14:22:37
554 [compat.c compat.h nchan.c ssh.c]
555 only send eow and no-more-sessions requests to openssh 5 and newer;
556 fixes interop problems with broken ssh v2 implementations; ok djm@
557 - millert@cvs.openbsd.org 2008/10/02 14:39:35
559 Convert an unchecked strdup to xstrdup. OK deraadt@
560 - jmc@cvs.openbsd.org 2008/10/03 13:08:12
562 do not give an example of how to chmod files: we can presume the user
563 knows that. removes an ambiguity in the permission of authorized_keys;
565 - deraadt@cvs.openbsd.org 2008/10/03 23:56:28
567 Repair strnvis() buffersize of 4*n+1, with termination gauranteed by the
569 spotted by des@freebsd, who commited an incorrect fix to the freebsd tree
570 and (as is fairly typical) did not report the problem to us. But this fix
573 - djm@cvs.openbsd.org 2008/10/08 23:34:03
575 Add -y option to force logging via syslog rather than stderr.
576 Useful for daemonised ssh connection (ssh -f). Patch originally from
578 - djm@cvs.openbsd.org 2008/10/09 03:50:54
579 [servconf.c sshd_config.5]
580 support setting PermitEmptyPasswords in a Match block
581 requested in PR3891; ok dtucker@
582 - jmc@cvs.openbsd.org 2008/10/09 06:54:22
585 - stevesk@cvs.openbsd.org 2008/10/10 04:55:16
587 spelling in comment; ok djm@
588 - stevesk@cvs.openbsd.org 2008/10/10 05:00:12
590 typo in error message; ok djm@
591 - stevesk@cvs.openbsd.org 2008/10/10 16:43:27
593 use 'Privileged ports can be forwarded only when logging in as root on
594 the remote machine.' for RemoteForward just like ssh.1 -R.
596 - stevesk@cvs.openbsd.org 2008/10/14 18:11:33
598 use #define ROQUIET here; no binary change. ok dtucker@
599 - stevesk@cvs.openbsd.org 2008/10/17 18:36:24
601 correct and clarify VisualHostKey; ok jmc@
602 - stevesk@cvs.openbsd.org 2008/10/30 19:31:16
603 [clientloop.c sshd.c]
604 don't need to #include "monitor_fdpass.h"
605 - stevesk@cvs.openbsd.org 2008/10/31 15:05:34
607 remove unused #define DISPATCH_MIN; ok markus@
608 - djm@cvs.openbsd.org 2008/11/01 04:50:08
610 sprinkle ARGSUSED on dispatch handlers
611 nuke stale unusued prototype
612 - stevesk@cvs.openbsd.org 2008/11/01 06:43:33
614 fix some typos in log messages; ok djm@
615 - sobrado@cvs.openbsd.org 2008/11/01 11:14:36
616 [ssh-keyscan.1 ssh-keyscan.c]
617 the ellipsis is not an optional argument; while here, improve spacing.
618 - stevesk@cvs.openbsd.org 2008/11/01 17:40:33
619 [clientloop.c readconf.c readconf.h ssh.c]
620 merge dynamic forward parsing into parse_forward();
621 'i think this is OK' djm@
622 - stevesk@cvs.openbsd.org 2008/11/02 00:16:16
624 protocol 2 tty modes support is now 7.5 years old so remove these
625 debug3()s; ok deraadt@
626 - stevesk@cvs.openbsd.org 2008/11/03 01:07:02
628 remove valueless comment
629 - stevesk@cvs.openbsd.org 2008/11/03 02:44:41
632 - (djm) [contrib/caldera/ssh-host-keygen contrib/suse/rc.sshd]
633 Make example scripts generate keys with default sizes rather than fixed,
634 non-default 1024 bits; patch from imorgan AT nas.nasa.gov
635 - (djm) [contrib/sshd.pam.generic contrib/caldera/sshd.pam]
636 [contrib/redhat/sshd.pam] Move pam_nologin to account group from
637 incorrect auth group in example files;
638 patch from imorgan AT nas.nasa.gov
641 - (dtucker) [config.guess config.sub] Update to latest versions from
642 http://git.savannah.gnu.org/gitweb/ (2008-04-14 and 2008-06-16
646 - (dtucker) [openbsd-compat/bsd-poll.c] correctly check for number of FDs
647 larger than FD_SETSIZE (OpenSSH only ever uses poll with one fd). Patch
648 from Nicholas Marriott.
651 - (djm) OpenBSD CVS Sync
652 - djm@cvs.openbsd.org 2008/07/23 07:36:55
654 do not try to print options that have been compile-time disabled
655 in config test mode (sshd -T); report from nix-corp AT esperi.org.uk
657 - (djm) [servconf.c] Print UsePAM option in config test mode (when it
658 has been compiled in); report from nix-corp AT esperi.org.uk
662 - (djm) OpenBSD CVS Sync
663 - jmc@cvs.openbsd.org 2008/07/18 22:51:01
665 no need for .Pp before or after .Sh;
666 - djm@cvs.openbsd.org 2008/07/21 08:19:07
669 - (djm) [README contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
670 [contrib/suse/openssh.spec] Update version number in README and RPM specs
671 - (djm) Release OpenSSH-5.1
674 - (djm) OpenBSD CVS Sync
675 - djm@cvs.openbsd.org 2008/07/17 08:48:00
677 strnvis preauth banner; pointed out by mpf@ ok markus@
678 - djm@cvs.openbsd.org 2008/07/17 08:51:07
680 strip trailing '.' from hostname when HostbasedUsesNameFromPacketOnly=yes
681 report and patch from res AT qoxp.net (bz#1200); ok markus@
682 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Remove long-unneeded compat
683 code, replace with equivalent cygwin library call. Patch from vinschen
684 at redhat.com, ok djm@.
685 - (djm) [sshconnect2.c] vis.h isn't available everywhere
689 - djm@cvs.openbsd.org 2008/07/15 02:23:14
691 number of pipelined requests is now 64;
692 prodded by Iain.Morgan AT nasa.gov
693 - djm@cvs.openbsd.org 2008/07/16 11:51:14
695 rename variable first_gc -> last_gc (since it is actually the last
697 - djm@cvs.openbsd.org 2008/07/16 11:52:19
699 this loop index should be automatic, not static
702 - (djm) OpenBSD CVS Sync
703 - sthen@cvs.openbsd.org 2008/07/13 21:22:52
705 Change "ssh-keygen -F [host] -l" to not display random art unless
706 -v is also specified, making it consistent with the manual and other
709 - djm@cvs.openbsd.org 2008/07/13 22:13:07
711 use struct sockaddr_storage instead of struct sockaddr for accept(2)
712 address argument. from visibilis AT yahoo.com in bz#1485; ok markus@
713 - djm@cvs.openbsd.org 2008/07/13 22:16:03
715 increase number of piplelined requests so they properly fill the
716 (recently increased) channel window. prompted by rapier AT psc.edu;
718 - djm@cvs.openbsd.org 2008/07/14 01:55:56
720 mention requirement for /dev/log inside chroot when using sftp-server
722 - (djm) [openbsd-compat/bindresvport.c] Rename variables s/sin/in/ to
723 avoid clash with sin(3) function; reported by
724 cristian.ionescu-idbohrn AT axis.com
725 - (djm) [openbsd-compat/rresvport.c] Add unistd.h for missing close()
726 prototype; reported by cristian.ionescu-idbohrn AT axis.com
727 - (djm) [umac.c] Rename variable s/buffer_ptr/bufp/ to avoid clash;
728 reported by cristian.ionescu-idbohrn AT axis.com
729 - (djm) [contrib/cygwin/Makefile contrib/cygwin/ssh-host-config]
730 [contrib/cygwin/ssh-user-config contrib/cygwin/sshd-inetd]
731 Revamped and simplified Cygwin ssh-host-config script that uses
732 unified csih configuration tool. Requires recent Cygwin.
733 Patch from vinschen AT redhat.com
736 - (djm) OpenBSD CVS Sync
737 - djm@cvs.openbsd.org 2008/07/12 04:52:50
739 unbreak; move clearing of cctx struct to before first use
741 - djm@cvs.openbsd.org 2008/07/12 05:33:41
743 better description for -i flag:
744 s/RSA authentication/public key authentication/
745 - (djm) [openbsd-compat/fake-rfc2553.c openbsd-compat/fake-rfc2553.h]
746 return EAI_FAMILY when trying to lookup unsupported address family;
747 from vinschen AT redhat.com
750 - (djm) OpenBSD CVS Sync
751 - stevesk@cvs.openbsd.org 2008/07/07 00:31:41
753 we don't need arg after the debug3() was removed. from lint.
755 - stevesk@cvs.openbsd.org 2008/07/07 23:32:51
757 /*NOTREACHED*/ for lint warning:
758 warning: function key_equal falls off bottom without returning value
760 - markus@cvs.openbsd.org 2008/07/10 18:05:58
762 missing bzero; from mickey; ok djm@
763 - markus@cvs.openbsd.org 2008/07/10 18:08:11
764 [clientloop.c monitor.c monitor_wrap.c packet.c packet.h sshd.c]
765 sync v1 and v2 traffic accounting; add it to sshd, too;
769 - (djm) [Makefile.in] Print "all tests passed" when all regress tests pass
770 - (djm) [auth1.c] Fix format string vulnerability in protocol 1 PAM
771 account check failure path. The vulnerable format buffer is supplied
772 from PAM and should not contain attacker-supplied data.
773 - (djm) [auth.c] Missing unistd.h for close()
774 - (djm) [configure.ac] Add -Wformat-security to CFLAGS for gcc 3.x and 4.x
777 - (djm) [auth.c] Fixed test for locked account on HP/UX with shadowed
778 passwords disabled. bz#1083 report & patch from senthilkumar_sen AT
779 hotpop.com, w/ dtucker@
780 - (djm) [atomicio.c configure.ac] Disable poll() fallback in atomiciov for
781 Tru64. readv doesn't seem to be a comparable object there.
782 bz#1386, patch from dtucker@ ok me
783 - (djm) [Makefile.in] Pass though pass to conch for interop tests
784 - (djm) [configure.ac] unbreak: remove extra closing brace
785 - (djm) OpenBSD CVS Sync
786 - djm@cvs.openbsd.org 2008/07/04 23:08:25
788 handle EINTR in packet_write_poll()l ok dtucker@
789 - djm@cvs.openbsd.org 2008/07/04 23:30:16
791 Make protocol 1 MaxAuthTries logic match protocol 2's.
792 Do not treat the first protocol 2 authentication attempt as
793 a failure IFF it is for method "none".
794 Makes MaxAuthTries' user-visible behaviour identical for
797 - djm@cvs.openbsd.org 2008/07/05 05:16:01
802 - (dtucker) OpenBSD CVS Sync
803 - djm@cvs.openbsd.org 2008/07/02 13:30:34
805 really really remove the freebie "none" auth try for protocol 2
806 - djm@cvs.openbsd.org 2008/07/02 13:47:39
808 When forking after authentication ("ssh -f") with ExitOnForwardFailure
809 enabled, delay the fork until after replies for any -R forwards have
810 been seen. Allows for robust detection of -R forward failure when
811 using -f (similar to bz#92); ok dtucker@
812 - otto@cvs.openbsd.org 2008/07/03 21:46:58
814 avoid nasty double free; ok dtucker@ djm@
815 - djm@cvs.openbsd.org 2008/07/04 03:44:59
816 [servconf.c groupaccess.h groupaccess.c]
817 support negation of groups in "Match group" block (bz#1315); ok dtucker@
818 - dtucker@cvs.openbsd.org 2008/07/04 03:47:02
820 Make debug a little clearer. ok djm@
821 - djm@cvs.openbsd.org 2008/06/30 08:07:34
822 [regress/key-options.sh]
823 shell portability: use "=" instead of "==" in test(1) expressions,
824 double-quote string with backslash escaped /
825 - djm@cvs.openbsd.org 2008/06/30 10:31:11
826 [regress/{putty-transfer,putty-kex,putty-ciphers}.sh]
827 remove "set -e" left over from debugging
828 - djm@cvs.openbsd.org 2008/06/30 10:43:03
829 [regress/conch-ciphers.sh]
830 explicitly disable conch options that could interfere with the test
831 - (dtucker) [sftp-server.c] Bug #1447: fall back to racy rename if link
832 returns EXDEV. Patch from Mike Garrison, ok djm@
833 - (djm) [atomicio.c channels.c clientloop.c defines.h includes.h]
834 [packet.c scp.c serverloop.c sftp-client.c ssh-agent.c ssh-keyscan.c]
835 [sshd.c] Explicitly handle EWOULDBLOCK wherever we handle EAGAIN, on
836 some platforms (HP nonstop) it is a distinct errno;
837 bz#1467 reported by sconeu AT yahoo.com; ok dtucker@
840 - (dtucker) OpenBSD CVS Sync
841 - djm@cvs.openbsd.org 2008/06/30 08:05:59
843 typo: s/constraint_date/constraint_data/
844 - djm@cvs.openbsd.org 2008/06/30 12:15:39
846 only pass channel requests on session channels through to the session
847 channel handler, avoiding spurious log messages; ok! markus@
848 - djm@cvs.openbsd.org 2008/06/30 12:16:02
850 only send eow@openssh.com notifications for session channels; ok! markus@
851 - djm@cvs.openbsd.org 2008/06/30 12:18:34
853 clarify that eow@openssh.com is only sent on session channels
854 - dtucker@cvs.openbsd.org 2008/07/01 07:20:52
856 Check ExitOnForwardFailure if forwardings are disabled due to a failed
857 host key check. ok djm@
858 - dtucker@cvs.openbsd.org 2008/07/01 07:24:22
859 [sshconnect.c sshd.c]
860 Send CR LF during protocol banner exchanges, but only for Protocol 2 only,
861 in order to comply with RFC 4253. bz #1443, ok djm@
862 - stevesk@cvs.openbsd.org 2008/07/01 23:12:47
864 fix some typos; ok djm@
865 - djm@cvs.openbsd.org 2008/07/02 02:24:18
866 [sshd_config sshd_config.5 sshd.8 servconf.c]
867 increase default size of ssh protocol 1 ephemeral key from 768 to 1024
868 bits; prodded by & ok dtucker@ ok deraadt@
869 - dtucker@cvs.openbsd.org 2008/07/02 12:03:51
870 [auth-rsa.c auth.c auth2-pubkey.c auth.h]
871 Merge duplicate host key file checks, based in part on a patch from Rob
872 Holland via bz #1348 . Also checks for non-regular files during protocol
874 - djm@cvs.openbsd.org 2008/07/02 12:36:39
875 [auth2-none.c auth2.c]
876 Make protocol 2 MaxAuthTries behaviour a little more sensible:
877 Check whether client has exceeded MaxAuthTries before running
878 an authentication method and skip it if they have, previously it
879 would always allow one try (for "none" auth).
880 Preincrement failure count before post-auth test - previously this
881 checked and postincremented, also to allow one "none" try.
882 Together, these two changes always count the "none" auth method
883 which could be skipped by a malicious client (e.g. an SSH worm)
884 to get an extra attempt at a real auth method. They also make
885 MaxAuthTries=0 a useful way to block users entirely (esp. in a
886 sshd_config Match block).
887 Also, move sending of any preauth banner from "none" auth method
888 to the first call to input_userauth_request(), so worms that skip
889 the "none" method get to see it too.
892 - (djm) OpenBSD CVS Sync
893 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
894 [regress/Makefile regress/key-options.sh]
895 Add regress test for key options. ok djm@
896 - dtucker@cvs.openbsd.org 2008/06/11 23:11:40
898 Don't run cipher-speed test by default; mistakenly enabled by me
899 - djm@cvs.openbsd.org 2008/06/28 13:57:25
900 [regress/Makefile regress/test-exec.sh regress/conch-ciphers.sh]
901 very basic regress test against Twisted Conch in "make interop"
902 target (conch is available in ports/devel/py-twisted/conch);
904 - (djm) [regress/Makefile] search for conch by path, like we do putty
907 - (djm) OpenBSD CVS Sync
908 - martynas@cvs.openbsd.org 2008/06/21 07:46:46
910 use optopt to get invalid flag, instead of return value of getopt,
911 which is always '?'; ok djm@
912 - otto@cvs.openbsd.org 2008/06/25 11:13:43
914 add key length to visual fingerprint; zap magical constants;
916 - djm@cvs.openbsd.org 2008/06/26 06:10:09
917 [sftp-client.c sftp-server.c]
918 allow the sftp chmod(2)-equivalent operation to set set[ug]id/sticky
919 bits. Note that this only affects explicit setting of modes (e.g. via
920 sftp(1)'s chmod command) and not file transfers. (bz#1310)
922 - djm@cvs.openbsd.org 2008/06/26 09:19:40
924 when loading moduli from /etc/moduli in sshd(8), check that they
925 are of the expected "safe prime" structure and have had
926 appropriate primality tests performed;
927 feedback and ok dtucker@
928 - grunk@cvs.openbsd.org 2008/06/26 11:46:31
929 [readconf.c readconf.h ssh.1 ssh_config.5 sshconnect.c]
930 Move SSH Fingerprint Visualization away from sharing the config option
931 CheckHostIP to an own config option named VisualHostKey.
932 While there, fix the behaviour that ssh would draw a random art picture
933 on every newly seen host even when the option was not enabled.
934 prodded by deraadt@, discussions,
935 help and ok markus@ djm@ dtucker@
936 - jmc@cvs.openbsd.org 2008/06/26 21:11:46
938 add VisualHostKey to the list of options listed in -o;
939 - djm@cvs.openbsd.org 2008/06/28 07:25:07
942 - djm@cvs.openbsd.org 2008/06/28 13:58:23
944 refuse to add a key that has unknown constraints specified;
946 - djm@cvs.openbsd.org 2008/06/28 14:05:15
948 reset global compat flag after processing a protocol 2 signature
949 request with the legacy DSA encoding flag set; ok markus
950 - djm@cvs.openbsd.org 2008/06/28 14:08:30
951 [PROTOCOL PROTOCOL.agent]
952 document the protocol used by ssh-agent; "looks ok" markus@
955 - (djm) [RFC.nroff contrib/cygwin/Makefile contrib/suse/openssh.spec]
956 RFC.nroff lacks a license, remove it (it is long gone in OpenBSD).
959 - (djm) [Makefile.in moduli.5] Include moduli(5) manpage from OpenBSD.
961 - (djm) [ contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
962 [contrib/suse/openssh.spec] Include moduli.5 in RPM spec files.
965 - (dtucker) OpenBSD CVS Sync
966 - dtucker@cvs.openbsd.org 2008/06/16 13:22:53
967 [session.c channels.c]
968 Rename the isatty argument to is_tty so we don't shadow
969 isatty(3). ok markus@
970 - (dtucker) [channels.c] isatty -> is_tty here too.
973 - (dtucker) [configure.ac] Enable -fno-builtin-memset when using gcc.
975 - dtucker@cvs.openbsd.org 2008/06/14 15:49:48
977 wrap long line at 80 chars
978 - dtucker@cvs.openbsd.org 2008/06/14 17:07:11
980 ensure default umask disallows at least group and world write; ok djm@
981 - djm@cvs.openbsd.org 2008/06/14 18:33:43
983 suppress the warning message from chdir(homedir) failures
984 when chrooted (bz#1461); ok dtucker
985 - dtucker@cvs.openbsd.org 2008/06/14 19:42:10
987 Mention that scp follows symlinks during -r. bz #1466,
989 - dtucker@cvs.openbsd.org 2008/06/15 16:55:38
991 MaxSessions is allowed in a Match block too
992 - dtucker@cvs.openbsd.org 2008/06/15 16:58:40
993 [servconf.c sshd_config.5]
994 Allow MaxAuthTries within a Match block. ok djm@
995 - djm@cvs.openbsd.org 2008/06/15 20:06:26
996 [channels.c channels.h session.c]
997 don't call isatty() on a pty master, instead pass a flag down to
998 channel_set_fds() indicating that te fds refer to a tty. Fixes a
999 hang on exit on Solaris (bz#1463) in portable but is actually
1000 a generic bug; ok dtucker deraadt markus
1003 - (djm) [openbsd-compat/sigact.c] Avoid NULL derefs in ancient sigaction
1004 replacement code; patch from ighighi AT gmail.com in bz#1240;
1008 - (dtucker) OpenBSD CVS Sync
1009 - deraadt@cvs.openbsd.org 2008/06/13 09:44:36
1011 compile on older gcc; no decl after code
1012 - dtucker@cvs.openbsd.org 2008/06/13 13:56:59
1014 Clear key options in the monitor on failed authentication, prevents
1015 applying additional restrictions to non-pubkey authentications in
1016 the case where pubkey fails but another method subsequently succeeds.
1017 bz #1472, found by Colin Watson, ok markus@ djm@
1018 - dtucker@cvs.openbsd.org 2008/06/13 14:18:51
1019 [auth2-pubkey.c auth-rhosts.c]
1020 Include unistd.h for close(), prevents warnings in -portable
1021 - dtucker@cvs.openbsd.org 2008/06/13 17:21:20
1023 Friendlier error messages for mux fallback. ok djm@
1024 - dtucker@cvs.openbsd.org 2008/06/13 18:55:22
1026 Prevent -Wsign-compare warnings on LP64 systems. bz #1192, ok deraadt@
1027 - grunk@cvs.openbsd.org 2008/06/13 20:13:26
1029 Explain the use of SSH fpr visualization using random art, and cite the
1030 original scientific paper inspiring that technique.
1031 Much help with English and nroff by jmc@, thanks.
1032 - (dtucker) [configure.ac] Bug #1276: avoid linking against libgssapi, which
1033 despite its name doesn't seem to implement all of GSSAPI. Patch from
1034 Jan Engelhardt, sanity checked by Simon Wilkinson.
1037 - (dtucker) OpenBSD CVS Sync
1038 - jmc@cvs.openbsd.org 2008/06/11 07:30:37
1040 kill trailing whitespace;
1041 - grunk@cvs.openbsd.org 2008/06/11 21:01:35
1042 [ssh_config.5 key.h readconf.c readconf.h ssh-keygen.1 ssh-keygen.c key.c
1044 Introduce SSH Fingerprint ASCII Visualization, a technique inspired by the
1045 graphical hash visualization schemes known as "random art", and by
1046 Dan Kaminsky's musings on the subject during a BlackOp talk at the
1048 Scientific publication (original paper):
1049 "Hash Visualization: a New Technique to improve Real-World Security",
1050 Perrig A. and Song D., 1999, International Workshop on Cryptographic
1051 Techniques and E-Commerce (CrypTEC '99)
1052 http://sparrow.ece.cmu.edu/~adrian/projects/validation/validation.pdf
1053 The algorithm used here is a worm crawling over a discrete plane,
1054 leaving a trace (augmenting the field) everywhere it goes.
1055 Movement is taken from dgst_raw 2bit-wise. Bumping into walls
1056 makes the respective movement vector be ignored for this turn,
1057 thus switching to the other color of the chessboard.
1058 Graphs are not unambiguous for now, because circles in graphs can be
1059 walked in either direction.
1060 discussions with several people,
1061 help, corrections and ok markus@ djm@
1062 - grunk@cvs.openbsd.org 2008/06/11 21:38:25
1064 ssh-keygen -lv -f /etc/ssh/ssh_host_rsa_key.pub
1065 would not display you the random art as intended, spotted by canacar@
1066 - grunk@cvs.openbsd.org 2008/06/11 22:20:46
1067 [ssh-keygen.c ssh-keygen.1]
1068 ssh-keygen would write fingerprints to STDOUT, and random art to STDERR,
1069 that is not how it was envisioned.
1070 Also correct manpage saying that -v is needed along with -l for it to work.
1072 - otto@cvs.openbsd.org 2008/06/11 23:02:22
1074 simpler way of computing the augmentations; ok grunk@
1075 - grunk@cvs.openbsd.org 2008/06/11 23:03:56
1077 CheckHostIP set to ``fingerprint'' will display both hex and random art
1079 - grunk@cvs.openbsd.org 2008/06/11 23:51:57
1081 #define statements that are not atoms need braces around them, else they
1082 will cause trouble in some cases.
1083 Also do a computation of -1 once, and not in a loop several times.
1085 - dtucker@cvs.openbsd.org 2008/06/12 00:03:49
1086 [dns.c canohost.c sshconnect.c]
1087 Do not pass "0" strings as ports to getaddrinfo because the lookups
1088 can slow things down and we never use the service info anyway. bz
1089 #859, patch from YOSHIFUJI Hideaki and John Devitofranceschi. ok
1091 djm belives that the reason for the "0" strings is to ensure that
1092 it's not possible to call getaddrinfo with both host and port being
1093 NULL. In the case of canohost.c host is a local array. In the
1094 case of sshconnect.c, it's checked for null immediately before use.
1095 In dns.c it ultimately comes from ssh.c:main() and is guaranteed to
1096 be non-null but it's not obvious, so I added a warning message in
1097 case it is ever passed a null.
1098 - grunk@cvs.openbsd.org 2008/06/12 00:13:55
1100 Make ssh print the random art also when ssh'ing to a host using IP only.
1101 spotted by naddy@, ok and help djm@ dtucker@
1102 - otto@cvs.openbsd.org 2008/06/12 00:13:13
1104 use an odd number of rows and columns and a separate start marker, looks
1106 - djm@cvs.openbsd.org 2008/06/12 03:40:52
1107 [clientloop.h mux.c channels.c clientloop.c channels.h]
1108 Enable ~ escapes for multiplex slave sessions; give each channel
1109 its own escape state and hook the escape filters up to muxed
1111 Mux slaves do not currently support the ~^Z and ~& escapes.
1112 NB. this change cranks the mux protocol version, so a new ssh
1113 mux client will not be able to connect to a running old ssh
1116 - djm@cvs.openbsd.org 2008/06/12 04:06:00
1117 [clientloop.h ssh.c clientloop.c]
1118 maintain an ordered queue of outstanding global requests that we
1119 expect replies to, similar to the per-channel confirmation queue.
1120 Use this queue to verify success or failure for remote forward
1121 establishment in a race free way.
1123 - djm@cvs.openbsd.org 2008/06/12 04:17:47
1125 thall shalt not code past the eightieth column
1126 - djm@cvs.openbsd.org 2008/06/12 04:24:06
1128 thal shalt not code past the eightieth column
1129 - djm@cvs.openbsd.org 2008/06/12 05:15:41
1131 document tun@openssh.com forwarding method
1132 - djm@cvs.openbsd.org 2008/06/12 05:32:30
1134 some more TODO for me
1135 - grunk@cvs.openbsd.org 2008/06/12 05:42:46
1137 supply the key type (rsa1, rsa, dsa) as a caption in the frame of the
1138 random art. while there, stress the fact that the field base should at
1139 least be 8 characters for the pictures to make sense.
1141 - grunk@cvs.openbsd.org 2008/06/12 06:32:59
1143 We already mark the start of the worm, now also mark the end of the worm
1144 in our random art drawings.
1146 - djm@cvs.openbsd.org 2008/06/12 15:19:17
1147 [clientloop.h channels.h clientloop.c channels.c mux.c]
1148 The multiplexing escape char handler commit last night introduced a
1149 small memory leak per session; plug it.
1150 - dtucker@cvs.openbsd.org 2008/06/12 16:35:31
1151 [ssh_config.5 ssh.c]
1152 keyword expansion for localcommand. ok djm@
1153 - jmc@cvs.openbsd.org 2008/06/12 19:10:09
1154 [ssh_config.5 ssh-keygen.1]
1155 tweak the ascii art text; ok grunk
1156 - dtucker@cvs.openbsd.org 2008/06/12 20:38:28
1157 [sshd.c sshconnect.c packet.h misc.c misc.h packet.c]
1158 Make keepalive timeouts apply while waiting for a packet, particularly
1159 during key renegotiation (bz #1363). With djm and Matt Day, ok djm@
1160 - djm@cvs.openbsd.org 2008/06/12 20:47:04
1162 print extension revisions for extensions that we understand
1163 - djm@cvs.openbsd.org 2008/06/12 21:06:25
1165 I was coalescing expected global request confirmation replies at
1166 the wrong end of the queue - fix; prompted by markus@
1167 - grunk@cvs.openbsd.org 2008/06/12 21:14:46
1169 make ssh-keygen -lf show the key type just as ssh-add -l would do it
1171 - grunk@cvs.openbsd.org 2008/06/12 22:03:36
1173 add my copyright, ok djm@
1174 - ian@cvs.openbsd.org 2008/06/12 23:24:58
1176 tweak wording in message, ok deraadt@ jmc@
1177 - dtucker@cvs.openbsd.org 2008/06/13 00:12:02
1179 replace __dead with __attribute__((noreturn)), makes things
1180 a little easier to port. Also, add it to sigdie(). ok djm@
1181 - djm@cvs.openbsd.org 2008/06/13 00:16:49
1183 fall back to creating a new TCP connection on most multiplexing errors
1184 (socket connect fail, invalid version, refused permittion, corrupted
1185 messages, etc.); bz #1329 ok dtucker@
1186 - dtucker@cvs.openbsd.org 2008/06/13 00:47:53
1188 upcast size_t to u_long to match format arg; ok djm@
1189 - dtucker@cvs.openbsd.org 2008/06/13 00:51:47
1191 upcast another size_t to u_long to match format
1192 - dtucker@cvs.openbsd.org 2008/06/13 01:38:23
1194 upcast uid to long with matching %ld, prevents warnings in portable
1195 - djm@cvs.openbsd.org 2008/06/13 04:40:22
1196 [auth2-pubkey.c auth-rhosts.c]
1197 refuse to read ~/.shosts or ~/.ssh/authorized_keys that are not
1198 regular files; report from Solar Designer via Colin Watson in bz#1471
1200 - (dtucker) [clientloop.c serverloop.c] channel_register_filter now
1201 takes 2 more args. with djm@
1202 - (dtucker) [defines.h] Bug #1112: __dead is, well dead. Based on a patch
1204 - (dtucker) [auth-sia.c] Bug #1241: support password expiry on Tru64 SIA
1205 systems. Patch from R. Scott Bailey.
1206 - (dtucker) [umac.c] STORE_UINT32_REVERSED and endian_convert are never used
1207 on big endian machines, so ifdef them for little-endian only to prevent
1208 unused function warnings on big-endians.
1209 - (dtucker) [openbsd-compat/setenv.c] Make offsets size_t to prevent
1210 compiler warnings on some platforms. Based on a discussion with otto@
1213 - (djm) [channels.c configure.ac]
1214 Do not set SO_REUSEADDR on wildcard X11 listeners (X11UseLocalhost=no)
1218 - (dtucker) OpenBSD CVS Sync
1219 - djm@cvs.openbsd.org 2008/06/10 03:57:27
1220 [servconf.c match.h sshd_config.5]
1221 support CIDR address matching in sshd_config "Match address" blocks, with
1222 full support for negation and fall-back to classic wildcard matching.
1224 Match address 192.0.2.0/24,3ffe:ffff::/32,!10.*
1225 PasswordAuthentication yes
1226 addrmatch.c code mostly lifted from flowd's addr.c
1227 feedback and ok dtucker@
1228 - djm@cvs.openbsd.org 2008/06/10 04:17:46
1230 better reference for pattern-list
1231 - dtucker@cvs.openbsd.org 2008/06/10 04:50:25
1232 [sshd.c channels.h channels.c log.c servconf.c log.h servconf.h sshd.8]
1233 Add extended test mode (-T) and connection parameters for test mode (-C).
1234 -T causes sshd to write its effective configuration to stdout and exit.
1235 -C causes any relevant Match rules to be applied before output. The
1236 combination allows tesing of the parser and config files. ok deraadt djm
1237 - jmc@cvs.openbsd.org 2008/06/10 07:12:00
1240 - jmc@cvs.openbsd.org 2008/06/10 08:17:40
1243 - fix SYNOPSIS, and sort options
1244 - some minor additional fixes
1245 - dtucker@cvs.openbsd.org 2008/06/09 18:06:32
1246 [regress/test-exec.sh]
1247 Don't generate putty keys if we're not going to use them. ok djm
1248 - dtucker@cvs.openbsd.org 2008/06/10 05:23:32
1249 [regress/addrmatch.sh regress/Makefile]
1250 Regress test for Match CIDR rules. ok djm@
1251 - dtucker@cvs.openbsd.org 2008/06/10 15:21:41
1253 Use a more portable construct for checking if we're running a putty test
1254 - dtucker@cvs.openbsd.org 2008/06/10 15:28:49
1257 - dtucker@cvs.openbsd.org 2008/06/10 18:21:24
1259 clarify that Host patterns are space-separated. ok deraadt
1260 - djm@cvs.openbsd.org 2008/06/10 22:15:23
1261 [PROTOCOL ssh.c serverloop.c]
1262 Add a no-more-sessions@openssh.com global request extension that the
1263 client sends when it knows that it will never request another session
1264 (i.e. when session multiplexing is disabled). This allows a server to
1265 disallow further session requests and terminate the session.
1266 Why would a non-multiplexing client ever issue additional session
1267 requests? It could have been attacked with something like SSH'jack:
1268 http://www.storm.net.nz/projects/7
1269 feedback & ok markus
1270 - djm@cvs.openbsd.org 2008/06/10 23:06:19
1271 [auth-options.c match.c servconf.c addrmatch.c sshd.8]
1272 support CIDR address matching in .ssh/authorized_keys from="..." stanzas
1273 ok and extensive testing dtucker@
1274 - dtucker@cvs.openbsd.org 2008/06/10 23:21:34
1276 Use '\0' for a nul byte rather than unadorned 0. ok djm@
1277 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
1278 [Makefile regress/key-options.sh]
1279 Add regress test for key options. ok djm@
1280 - (dtucker) [openbsd-compat/fake-rfc2553.h] Add sin6_scope_id to sockaddr_in6
1281 since the new CIDR code in addmatch.c references it.
1282 - (dtucker) [Makefile.in configure.ac regress/addrmatch.sh] Skip IPv6
1283 specific tests on platforms that don't do IPv6.
1284 - (dtucker) [Makefile.in] Define TEST_SSH_IPV6 in make's arguments as well
1286 - (dtucker) [Makefile.in] Move addrmatch.o to libssh.a where it's needed now.
1289 - (dtucker) OpenBSD CVS Sync
1290 - dtucker@cvs.openbsd.org 2008/06/08 17:04:41
1292 Add case for ENOSYS in errno_to_portable; ok deraadt
1293 - dtucker@cvs.openbsd.org 2008/06/08 20:15:29
1294 [sftp.c sftp-client.c sftp-client.h]
1295 Have the sftp client store the statvfs replies in wire format,
1296 which prevents problems when the server's native sizes exceed the
1298 Also extends the sizes of the remaining 32bit wire format to 64bit,
1299 they're specified as unsigned long in the standard.
1300 - dtucker@cvs.openbsd.org 2008/06/09 13:02:39
1302 Extend 32bit -> 64bit values for statvfs extension missed in previous
1304 - dtucker@cvs.openbsd.org 2008/06/09 13:38:46
1306 Use a $OpenBSD tag so our scripts will sync changes.
1309 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c
1310 openbsd-compat/Makefile.in openbsd-compat/openbsd-compat.h
1311 openbsd-compat/bsd-statvfs.{c,h}] Add a null implementation of statvfs and
1312 fstatvfs and remove #defines around statvfs code. ok djm@
1313 - (dtucker) [configure.ac defines.h sftp-client.c M sftp-server.c] Add a
1314 macro to convert fsid to unsigned long for platforms where fsid is a
1318 - (dtucker) [mux.c] Include paths.h inside ifdef HAVE_PATHS_H.
1319 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c]
1320 Do not enable statvfs extensions on platforms that do not have statvfs.
1321 - (dtucker) OpenBSD CVS Sync
1322 - djm@cvs.openbsd.org 2008/05/19 06:14:02
1323 [packet.c] unbreak protocol keepalive timeouts bz#1465; ok dtucker@
1324 - djm@cvs.openbsd.org 2008/05/19 15:45:07
1325 [sshtty.c ttymodes.c sshpty.h]
1326 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1327 we would send the modes corresponding to a zeroed struct termios,
1328 whereas we should have been sending an empty list of modes.
1329 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1330 - djm@cvs.openbsd.org 2008/05/19 15:46:31
1332 support -l (print fingerprint) in combination with -F (find host) to
1333 search for a host in ~/.ssh/known_hosts and display its fingerprint;
1335 - djm@cvs.openbsd.org 2008/05/19 20:53:52
1337 unbreak tree by committing this bit that I missed from:
1338 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1339 we would send the modes corresponding to a zeroed struct termios,
1340 whereas we should have been sending an empty list of modes.
1341 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1344 - (djm) [openbsd-compat/bsd-arc4random.c] Fix math bug that caused bias
1345 in arc4random_uniform with upper_bound in (2^30,2*31). Note that
1346 OpenSSH did not make requests with upper bounds in this range.
1349 - (djm) [configure.ac mux.c sftp.c openbsd-compat/Makefile.in]
1350 [openbsd-compat/fmt_scaled.c openbsd-compat/openbsd-compat.h]
1351 Fix compilation on Linux, including pulling in fmt_scaled(3)
1352 implementation from OpenBSD's libutil.
1355 - (djm) OpenBSD CVS Sync
1356 - djm@cvs.openbsd.org 2008/04/04 05:14:38
1358 ChrootDirectory is supported in Match blocks (in fact, it is most useful
1359 there). Spotted by Minstrel AT minstrel.org.uk
1360 - djm@cvs.openbsd.org 2008/04/04 06:44:26
1362 oops, some unrelated stuff crept into that commit - backout.
1364 - djm@cvs.openbsd.org 2008/04/05 02:46:02
1366 HostbasedAuthentication is supported under Match too
1367 - (djm) [openbsd-compat/bsd-arc4random.c openbsd-compat/openbsd-compat.c]
1368 [configure.ac] Implement arc4random_buf(), import implementation of
1369 arc4random_uniform() from OpenBSD
1370 - (djm) [openbsd-compat/bsd-arc4random.c] Warning fixes
1371 - (djm) [openbsd-compat/port-tun.c] needs sys/queue.h
1372 - (djm) OpenBSD CVS Sync
1373 - djm@cvs.openbsd.org 2008/04/13 00:22:17
1375 Use arc4random_buf() when requesting more than a single word of output
1376 Use arc4random_uniform() when the desired random number upper bound
1377 is not a power of two
1378 ok deraadt@ millert@
1379 - djm@cvs.openbsd.org 2008/04/18 12:32:11
1380 [sftp-client.c sftp-client.h sftp-server.c sftp.1 sftp.c sftp.h]
1381 introduce sftp extension methods statvfs@openssh.com and
1382 fstatvfs@openssh.com that implement statvfs(2)-like operations,
1383 based on a patch from miklos AT szeredi.hu (bz#1399)
1384 also add a "df" command to the sftp client that uses the
1385 statvfs@openssh.com to produce a df(1)-like display of filesystem
1386 space and inode utilisation
1388 - jmc@cvs.openbsd.org 2008/04/18 17:15:47
1391 - djm@cvs.openbsd.org 2008/04/18 22:01:33
1393 remove unneccessary parentheses
1394 - otto@cvs.openbsd.org 2008/04/29 11:20:31
1396 garbage collect two unused fields in struct mm_master; ok markus@
1397 - djm@cvs.openbsd.org 2008/04/30 10:14:03
1398 [ssh-keyscan.1 ssh-keyscan.c]
1399 default to rsa (protocol 2) keys, instead of rsa1 keys; spotted by
1400 larsnooden AT openoffice.org
1401 - pyr@cvs.openbsd.org 2008/05/07 05:49:37
1402 [servconf.c servconf.h session.c sshd_config.5]
1403 Enable the AllowAgentForwarding option in sshd_config (global and match
1404 context), to specify if agents should be permitted on the server.
1405 As the man page states:
1406 ``Note that disabling Agent forwarding does not improve security
1407 unless users are also denied shell access, as they can always install
1408 their own forwarders.''
1409 ok djm@, ok and a mild frown markus@
1410 - pyr@cvs.openbsd.org 2008/05/07 06:43:35
1412 push the sshd_config bits in, spotted by ajacoutot@
1413 - jmc@cvs.openbsd.org 2008/05/07 08:00:14
1416 - markus@cvs.openbsd.org 2008/05/08 06:59:01
1417 [bufaux.c buffer.h channels.c packet.c packet.h]
1418 avoid extra malloc/copy/free when receiving data over the net;
1419 ~10% speedup for localhost-scp; ok djm@
1420 - djm@cvs.openbsd.org 2008/05/08 12:02:23
1421 [auth-options.c auth1.c channels.c channels.h clientloop.c gss-serv.c]
1422 [monitor.c monitor_wrap.c nchan.c servconf.c serverloop.c session.c]
1424 Implement a channel success/failure status confirmation callback
1425 mechanism. Each channel maintains a queue of callbacks, which will
1426 be drained in order (RFC4253 guarantees confirm messages are not
1427 reordered within an channel).
1428 Also includes a abandonment callback to clean up if a channel is
1429 closed without sending confirmation messages. This probably
1430 shouldn't happen in compliant implementations, but it could be
1431 abused to leak memory.
1432 ok markus@ (as part of a larger diff)
1433 - djm@cvs.openbsd.org 2008/05/08 12:21:16
1434 [monitor.c monitor_wrap.c session.h servconf.c servconf.h session.c]
1435 [sshd_config sshd_config.5]
1436 Make the maximum number of sessions run-time controllable via
1437 a sshd_config MaxSessions knob. This is useful for disabling
1438 login/shell/subsystem access while leaving port-forwarding working
1439 (MaxSessions 0), disabling connection multiplexing (MaxSessions 1) or
1440 simply increasing the number of allows multiplexed sessions.
1441 Because some bozos are sure to configure MaxSessions in excess of the
1442 number of available file descriptors in sshd (which, at peak, might be
1443 as many as 9*MaxSessions), audit sshd to ensure that it doesn't leak fds
1444 on error paths, and make it fail gracefully on out-of-fd conditions -
1445 sending channel errors instead of than exiting with fatal().
1446 bz#1090; MaxSessions config bits and manpage from junyer AT gmail.com
1448 - djm@cvs.openbsd.org 2008/05/08 13:06:11
1449 [clientloop.c clientloop.h ssh.c]
1450 Use new channel status confirmation callback system to properly deal
1451 with "important" channel requests that fail, in particular command exec,
1452 shell and subsystem requests. Previously we would optimistically assume
1453 that the requests would always succeed, which could cause hangs if they
1454 did not (e.g. when the server runs out of fds) or were unimplemented by
1455 the server (bz #1384)
1456 Also, properly report failing multiplex channel requests via the mux
1457 client stderr (subject to LogLevel in the mux master) - better than
1459 most bits ok markus@ (as part of a larger diff)
1460 - djm@cvs.openbsd.org 2008/05/09 04:55:56
1461 [channels.c channels.h clientloop.c serverloop.c]
1462 Try additional addresses when connecting to a port forward destination
1463 whose DNS name resolves to more than one address. The previous behaviour
1464 was to try the first address and give up.
1465 Reported by stig AT venaas.com in bz#343
1466 great feedback and ok markus@
1467 - djm@cvs.openbsd.org 2008/05/09 14:18:44
1468 [clientloop.c clientloop.h ssh.c mux.c]
1469 tidy up session multiplexing code, moving it into its own file and
1470 making the function names more consistent - making ssh.c and
1471 clientloop.c a fair bit more readable.
1473 - djm@cvs.openbsd.org 2008/05/09 14:26:08
1475 dingo stole my diff hunk
1476 - markus@cvs.openbsd.org 2008/05/09 16:16:06
1478 re-add the USE_PIPES code and enable it.
1479 without pipes shutdown-read from the sshd does not trigger
1480 a SIGPIPE when the forked program does a write.
1482 (Id sync only, USE_PIPES never left portable OpenSSH)
1483 - markus@cvs.openbsd.org 2008/05/09 16:17:51
1485 error-fd race: don't enable the error fd in the select bitmask
1486 for channels with both in- and output closed, since the channel
1487 will go away before we call select();
1488 report, lots of debugging help and ok djm@
1489 - markus@cvs.openbsd.org 2008/05/09 16:21:13
1490 [channels.h clientloop.c nchan.c serverloop.c]
1492 ssh -2 localhost od /bin/ls | true
1493 ignoring SIGPIPE by adding a new channel message (EOW) that signals
1494 the peer that we're not interested in any data it might send.
1495 fixes bz #85; discussion, debugging and ok djm@
1496 - pvalchev@cvs.openbsd.org 2008/05/12 20:52:20
1498 Ensure nh_result lies on a 64-bit boundary (fixes warnings observed
1499 on Itanium on Linux); from Dale Talcott (bug #1462); ok djm@
1500 - djm@cvs.openbsd.org 2008/05/15 23:52:24
1502 document eow message in ssh protocol 2 channel state machine;
1503 feedback and ok markus@
1504 - djm@cvs.openbsd.org 2008/05/18 21:29:05
1506 comment extension announcement
1507 - djm@cvs.openbsd.org 2008/05/16 08:30:42
1509 document our protocol extensions and deviations; ok markus@
1510 - djm@cvs.openbsd.org 2008/05/17 01:31:56
1512 grammar and correctness fixes from stevesk@
1515 - (djm) [openbsd-compat/bsd-poll.c] Include stdlib.h to avoid compile-
1516 time warnings on LynxOS. Patch from ops AT iki.fi
1517 - (djm) Force string arguments to replacement setproctitle() though
1518 strnvis first. Ok dtucker@
1521 - (djm) OpenBSD CVS sync:
1522 - markus@cvs.openbsd.org 2008/04/02 15:36:51
1524 avoid possible hijacking of x11-forwarded connections (back out 1.183)
1525 CVE-2008-1483; ok djm@
1526 - jmc@cvs.openbsd.org 2008/03/27 22:37:57
1528 remove trailing whitespace;
1529 - djm@cvs.openbsd.org 2008/04/03 09:50:14
1532 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
1533 [contrib/suse/openssh.spec] Crank version numbers in RPM spec files
1534 - (djm) [README] Update link to release notes
1535 - (djm) Release 5.0p1