2 - (dtucker) OpenBSD CVS Sync
3 - markus@cvs.openbsd.org 2009/03/17 21:37:00
5 pass correct argv[0] to openlog(); ok djm@
6 - jmc@cvs.openbsd.org 2009/03/19 15:15:09
8 for "Ciphers", just point the reader to the keyword in ssh_config(5), just
9 as we do for "MACs": this stops us getting out of sync when the lists
11 fixes documentation/6102, submitted by Peter J. Philipp
12 alternative fix proposed by djm
14 - tobias@cvs.openbsd.org 2009/03/23 08:31:19
16 Fixed a possible out-of-bounds memory access if the environment variable
17 SHELL is shorter than 3 characters.
18 with input by and ok dtucker
19 - tobias@cvs.openbsd.org 2009/03/23 19:38:04
21 My previous commit didn't fix the problem at all, so stick at my first
22 version of the fix presented to dtucker.
23 Issue notified by Matthias Barkhoff (matthias dot barkhoff at gmx dot de).
25 - sobrado@cvs.openbsd.org 2009/03/26 08:38:39
26 [sftp-server.8 sshd.8 ssh-agent.1]
27 fix a few typographical errors found by spell(1).
29 - stevesk@cvs.openbsd.org 2009/04/13 19:07:44
31 fix possessive; ok djm@
32 - stevesk@cvs.openbsd.org 2009/04/14 16:33:42
34 remove unused option character from getopt() optstring; ok markus@
35 - jj@cvs.openbsd.org 2009/04/14 21:10:54
37 Fixed a few the-the misspellings in comments. Skipped a bunch in
38 binutils,gcc and so on. ok jmc@
39 - stevesk@cvs.openbsd.org 2009/04/17 19:23:06
41 use INTERNAL_SFTP_NAME for setproctitle() of in-process sftp-server;
43 - stevesk@cvs.openbsd.org 2009/04/17 19:40:17
45 clarify that even internal-sftp needs /dev/log for logging to work; ok
47 - jmc@cvs.openbsd.org 2009/04/18 18:39:10
49 tweak previous; ok stevesk
50 - stevesk@cvs.openbsd.org 2009/04/21 15:13:17
52 clarify we cd to user's home after chroot; ok markus@ on
53 earlier version; tweaks and ok jmc@
54 - andreas@cvs.openbsd.org 2009/05/25 06:48:01
55 [channels.c packet.c clientloop.c packet.h serverloop.c monitor_wrap.c
57 Put the globals in packet.c into a struct and don't access it directly
58 from other files. No functional changes.
60 - andreas@cvs.openbsd.org 2009/05/27 06:31:25
61 [canohost.h canohost.c]
62 Add clear_cached_addr(), needed for upcoming changes allowing the peer
65 - andreas@cvs.openbsd.org 2009/05/27 06:33:39
67 Send SSH2_MSG_DISCONNECT when the client disconnects. From a larger
68 change from Martin Forssen, maf at appgate dot com.
70 - andreas@cvs.openbsd.org 2009/05/27 06:34:36
72 Move the KEX_COOKIE_LEN define to kex.h
74 - andreas@cvs.openbsd.org 2009/05/27 06:36:07
76 Add packet_put_int64() and packet_get_int64(), part of a larger change
79 - andreas@cvs.openbsd.org 2009/05/27 06:38:16
80 [sshconnect.h sshconnect.c]
81 Un-static ssh_exchange_identification(), part of a larger change from
82 Martin Forssen and needed for upcoming changes.
84 - andreas@cvs.openbsd.org 2009/05/28 16:50:16
85 [sshd.c packet.c serverloop.c monitor_wrap.c clientloop.c sshconnect.c
86 monitor.c Added roaming.h roaming_common.c roaming_dummy.c]
87 Keep track of number of bytes read and written. Needed for upcoming
88 changes. Most code from Martin Forssen, maf at appgate dot com.
90 Also, applied appropriate changes to Makefile.in
93 - (dtucker) [configure.ac defines.h] Bug #1607: handle the case where fsid_t
94 is a struct with a __val member. Fixes build on, eg, Redhat 6.2.
97 - (dtucker) [sshlogin.c] Move the NO_SSH_LASTLOG #ifndef line to include
98 variable declarations. Should prevent unused warnings anywhere it's set
99 (only Crays as far as I can tell) and be a no-op everywhere else.
102 - (tim) [configure.ac] Remove setting IP_TOS_IS_BROKEN for Cygwin. The problem
103 that setsockopt(IP_TOS) doesn't work on Cygwin has been fixed since 2005.
104 Based on patch from vinschen at redhat com.
107 - (dtucker) [auth-passwd.c auth1.c auth2-kbdint.c auth2-none.c auth2-passwd.c
108 auth2-pubkey.c session.c openbsd-compat/bsd-cygwin_util.{c,h}
109 openbsd-compat/daemon.c] Remove support for Windows 95/98/ME and very old
110 version of Cygwin. Patch from vinschen at redhat com.
113 - (dtucker) [contrib/aix/buildbff.sh] Only try to rename ssh_prng_cmds if it
114 exists (it's not created if OpenSSL's PRNG is self-seeded, eg if the OS
116 - (dtucker) [schnorr.c openbsd-compat/openssl-compat.{c,h}] Add
117 EVP_DigestUpdate to the OLD_EVP compatibility functions and tell schnorr.c
118 to use them. Allows building with older OpenSSL versions.
119 - (dtucker) [configure.ac defines.h] Check for in_port_t and typedef if needed.
120 - (dtucker) [configure.ac] Missing comma in type list.
121 - (dtucker) [configure.ac openbsd-compat/openssl-compat.{c,h}]
122 EVP_DigestUpdate does not exactly match the other OLD_EVP functions (eg
123 in openssl 0.9.6) so add an explicit test for it.
126 - (djm) OpenBSD CVS Sync
127 - djm@cvs.openbsd.org 2009/03/05 07:18:19
128 [auth2-jpake.c jpake.c jpake.h monitor_wrap.c monitor_wrap.h schnorr.c]
130 refactor the (disabled) Schnorr proof code to make it a little more
132 - djm@cvs.openbsd.org 2009/03/05 11:30:50
134 document what these functions do so I don't ever have to recuse into
135 b64_pton/ntop to remember their return values
138 - (djm) OpenBSD CVS Sync
139 - djm@cvs.openbsd.org 2009/02/22 23:50:57
140 [ssh_config.5 sshd_config.5]
141 don't advertise experimental options
142 - djm@cvs.openbsd.org 2009/02/22 23:59:25
145 - djm@cvs.openbsd.org 2009/02/23 00:06:15
148 - (djm) [README] update for 5.2
149 - (djm) Release openssh-5.2p1
152 - (djm) OpenBSD CVS Sync
153 - tobias@cvs.openbsd.org 2009/02/21 19:32:04
154 [misc.c sftp-server-main.c ssh-keygen.c]
155 Added missing newlines in error messages.
159 - (djm) OpenBSD CVS Sync
160 - djm@cvs.openbsd.org 2009/02/17 01:28:32
162 sync with revised default ciphers; pointed out by dkrause@
163 - djm@cvs.openbsd.org 2009/02/18 04:31:21
165 signature should hash over the entire group, not just the generator
166 (this is still disabled code)
167 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
168 [contrib/suse/openssh.spec] Prepare for 5.2p1
171 - (djm) [regress/conch-ciphers.sh regress/putty-ciphers.sh]
172 [regress/putty-kex.sh regress/putty-transfer.sh] Downgrade disabled
173 interop tests from FATAL error to a warning. Allows some interop
174 tests to proceed if others are missing necessary prerequisites.
175 - (djm) [configure.ac] support GNU/kFreeBSD and GNU/kOpensolaris
176 systems; patch from Aurelien Jarno via rmh AT aybabtu.com
179 - (djm) OpenBSD CVS Sync
180 - dtucker@cvs.openbsd.org 2009/02/02 11:15:14
182 Initialize a few variables to prevent spurious "may be used
183 uninitialized" warnings from newer gcc's. ok djm@
184 - djm@cvs.openbsd.org 2009/02/12 03:00:56
185 [canohost.c canohost.h channels.c channels.h clientloop.c readconf.c]
186 [readconf.h serverloop.c ssh.c]
187 support remote port forwarding with a zero listen port (-R0:...) to
188 dyamically allocate a listen port at runtime (this is actually
189 specified in rfc4254); bz#1003 ok markus@
190 - djm@cvs.openbsd.org 2009/02/12 03:16:01
192 tighten check for -R0:... forwarding: only allow dynamic allocation
193 if want_reply is set in the packet
194 - djm@cvs.openbsd.org 2009/02/12 03:26:22
196 some paranoia: check that the serialised key is really KEY_RSA before
197 diddling its internals
198 - djm@cvs.openbsd.org 2009/02/12 03:42:09
200 document -R0:... usage
201 - djm@cvs.openbsd.org 2009/02/12 03:44:25
203 consistency: Dq => Ql
204 - djm@cvs.openbsd.org 2009/02/12 03:46:17
206 document RemoteForward usage with 0 listen port
207 - jmc@cvs.openbsd.org 2009/02/12 07:34:20
209 kill trailing whitespace;
210 - markus@cvs.openbsd.org 2009/02/13 11:50:21
212 check for enc !=NULL in packet_start_discard
213 - djm@cvs.openbsd.org 2009/02/14 06:35:49
215 mention that eow and no-more-sessions extensions are sent only to
219 - (djm) [sshpty.c] bz#1419: OSX uses cloning ptys that automagically
220 set ownership and modes, so avoid explicitly setting them
221 - (djm) [configure.ac loginrec.c] bz#1421: fix lastlog support for OSX.
222 OSX provides a getlastlogxbyname function that automates the reading of
223 a lastlog file. Also, the pututxline function will update lastlog so
224 there is no need for loginrec.c to do it explicitly. Collapse some
225 overly verbose code while I'm in there.
228 - (dtucker) [defines.h sshconnect.c] INET6_ADDRSTRLEN is now needed in
229 channels.c too, so move the definition for non-IP6 platforms to defines.h
230 where it can be shared.
233 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
234 If the CYGWIN environment variable is empty, the installer script
235 should not install the service with an empty CYGWIN variable, but
236 rather without setting CYGWNI entirely.
237 - (tim) [contrib/cygwin/ssh-host-config] Whitespace cleanup. No code changes.
240 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
241 Changes to work on Cygwin 1.5.x as well as on the new Cygwin 1.7.x.
242 The information given for the setting of the CYGWIN environment variable
243 is wrong for both releases so I just removed it, together with the
244 unnecessary (Cygwin 1.5.x) or wrong (Cygwin 1.7.x) default setting.
247 - (djm) OpenBSD CVS Sync
248 - stevesk@cvs.openbsd.org 2008/12/09 03:20:42
249 [channels.c servconf.c]
250 channel_print_adm_permitted_opens() should deal with all the printing
251 for that config option. suggested by markus@; ok markus@ djm@
253 - djm@cvs.openbsd.org 2008/12/09 04:32:22
255 replace by-hand string building with xasprinf(); ok deraadt@
256 - sobrado@cvs.openbsd.org 2008/12/09 15:35:00
258 update for the synopses displayed by the 'help' command, there are a
259 few missing flags; add 'bye' to the output of 'help'; sorting and spacing.
260 jmc@ suggested replacing .Oo/.Oc with a single .Op macro.
262 - stevesk@cvs.openbsd.org 2008/12/09 22:37:33
264 fix typo in error message
265 - stevesk@cvs.openbsd.org 2008/12/10 03:55:20
267 o cannot be NULL here but use xfree() to be consistent; ok djm@
268 - stevesk@cvs.openbsd.org 2008/12/29 01:12:36
270 fix example, default key type is rsa for 3+ years; from
271 frederic.perrin@resel.fr
272 - stevesk@cvs.openbsd.org 2008/12/29 02:23:26
274 no need to escape single quotes in comments
275 - okan@cvs.openbsd.org 2008/12/30 00:46:56
277 add AllowAgentForwarding to available Match keywords list
279 - djm@cvs.openbsd.org 2009/01/01 21:14:35
281 call channel destroy callbacks on receipt of open failure messages.
282 fixes client hangs when connecting to a server that has MaxSessions=0
283 set spotted by imorgan AT nas.nasa.gov; ok markus@
284 - djm@cvs.openbsd.org 2009/01/01 21:17:36
286 fix hash calculation for KEXGEX: hash over the original client-supplied
287 values and not the sanity checked versions that we acutally use;
288 bz#1540 reported by john.smith AT arrows.demon.co.uk
290 - djm@cvs.openbsd.org 2009/01/14 01:38:06
292 support SOCKS4A protocol, from dwmw2 AT infradead.org via bz#1482;
294 - stevesk@cvs.openbsd.org 2009/01/15 17:38:43
296 1) use obsolete instead of alias for consistency
297 2) oUserKnownHostsFile not obsolete but oGlobalKnownHostsFile2 is
299 3) reorder so like options are together
301 - djm@cvs.openbsd.org 2009/01/22 09:46:01
302 [channels.c channels.h session.c]
303 make Channel->path an allocated string, saving a few bytes here and
304 there and fixing bz#1380 in the process; ok markus@
305 - djm@cvs.openbsd.org 2009/01/22 09:49:57
307 oops! I committed the wrong version of the Channel->path diff,
308 it was missing some tweaks suggested by stevesk@
309 - djm@cvs.openbsd.org 2009/01/22 10:02:34
310 [clientloop.c misc.c readconf.c readconf.h servconf.c servconf.h]
311 [serverloop.c ssh-keyscan.c ssh.c sshd.c]
312 make a2port() return -1 when it encounters an invalid port number
313 rather than 0, which it will now treat as valid (needed for future work)
314 adjust current consumers of a2port() to check its return value is <= 0,
315 which in turn required some things to be converted from u_short => int
316 make use of int vs. u_short consistent in some other places too
317 feedback & ok markus@
318 - djm@cvs.openbsd.org 2009/01/22 10:09:16
320 another chunk of a2port() diff that got away. wtfdjm??
321 - djm@cvs.openbsd.org 2009/01/23 07:58:11
323 prefer CTR modes and revised arcfour (i.e w/ discard) modes to CBC
325 - naddy@cvs.openbsd.org 2009/01/24 17:10:22
326 [ssh_config.5 sshd_config.5]
327 sync list of preferred ciphers; ok djm@
328 - markus@cvs.openbsd.org 2009/01/26 09:58:15
329 [cipher.c cipher.h packet.c]
330 Work around the CPNI-957037 Plaintext Recovery Attack by always
331 reading 256K of data on packet size or HMAC errors (in CBC mode only).
332 Help, feedback and ok djm@
333 Feedback from Martin Albrecht and Paterson Kenny
336 - (djm) [uidswap.c] bz#1412: Support >16 supplemental groups in OS X.
337 Patch based on one from vgiffin AT apple.com; ok dtucker@
338 - (djm) [channels.c] bz#1419: support "on demand" X11 forwarding via
339 launchd on OS X; patch from vgiffin AT apple.com, slightly tweaked;
341 - (djm) [contrib/ssh-copy-id.1 contrib/ssh-copy-id] bz#1492: Make
342 ssh-copy-id copy id_rsa.pub by default (instead of the legacy "identity"
343 key). Patch from cjwatson AT debian.org
346 - (tim) [configure.ac defines.h openbsd-compat/port-uw.c
347 openbsd-compat/xcrypt.c] Add SECUREWARE support to OpenServer 6 SVR5 ABI.
349 - (tim) [configure.ac] Move check_for_libcrypt_later=1 in *-*-sysv5*) section.
350 OpenServer 6 doesn't need libcrypt.
353 - (djm) OpenBSD CVS Sync
354 - djm@cvs.openbsd.org 2008/12/09 02:38:18
356 The ~C escape handler does not work correctly for multiplexed sessions -
357 it opens a commandline on the master session, instead of on the slave
358 that requested it. Disable it on slave sessions until such time as it
359 is fixed; bz#1543 report from Adrian Bridgett via Colin Watson
361 - djm@cvs.openbsd.org 2008/12/09 02:39:59
363 Deal correctly with failures in remote stat() operation in sftp,
364 correcting fail-on-error behaviour in batchmode. bz#1541 report and
365 fix from anedvedicky AT gmail.com; ok markus@
366 - djm@cvs.openbsd.org 2008/12/09 02:58:16
368 don't leave junk (free'd) pointers around in Forward *fwd argument on
369 failure; avoids double-free in ~C -L handler when given an invalid
370 forwarding specification; bz#1539 report from adejong AT debian.org
371 via Colin Watson; ok markus@ dtucker@
372 - djm@cvs.openbsd.org 2008/12/09 03:02:37
374 correct sftp(1) and corresponding usage syntax;
375 bz#1518 patch from imorgan AT nas.nasa.gov; ok deraadt@ improved diff jmc@
378 - (djm) [configure.ac] bz#1538: better test for ProPolice/SSP: actually
379 use some stack in main().
380 Report and suggested fix from vapier AT gentoo.org
381 - (djm) OpenBSD CVS Sync
382 - markus@cvs.openbsd.org 2008/12/02 19:01:07
384 we have to use the recipient's channel number (RFC 4254) for
385 SSH2_MSG_CHANNEL_SUCCESS/SSH2_MSG_CHANNEL_FAILURE messages,
386 otherwise we trigger 'Non-public channel' error messages on sshd
387 systems with clientkeepalive enabled; noticed by sturm; ok djm;
388 - markus@cvs.openbsd.org 2008/12/02 19:08:59
390 backout 1.149, since it's not necessary and openssh clients send
391 broken CHANNEL_FAILURE/SUCCESS messages since about 2004; ok djm@
392 - markus@cvs.openbsd.org 2008/12/02 19:09:38
394 s/remote_id/id/ to be more consistent with other code; ok djm@
397 - (dtucker) [contrib/cygwin/{Makefile,ssh-host-config}] Add new doc files
398 and tweak the is-sshd-running check in ssh-host-config. Patch from
399 vinschen at redhat com.
400 - (dtucker) OpenBSD CVS Sync
401 - markus@cvs.openbsd.org 2008/11/21 15:47:38
403 packet_disconnect() on padding error, too. should reduce the success
404 probability for the CPNI-957037 Plaintext Recovery Attack to 2^-18
406 - dtucker@cvs.openbsd.org 2008/11/30 11:59:26
408 Retry sendmsg/recvmsg on EAGAIN and EINTR; ok djm@
411 - (dtucker) [monitor_fdpass.c] Reduce diff vs OpenBSD by moving some
412 declarations, removing an unnecessary union member and adding whitespace.
413 cmsgbuf.tmp thing spotted by des at des no, ok djm some time ago.
416 - (tim) [addrmatch.c configure.ac] Some platforms do not have sin6_scope_id
417 member of sockaddr_in6. Also reported in Bug 1491 by David Leonard. OK and
421 - (dtucker) OpenBSD CVS Sync
422 - jmc@cvs.openbsd.org 2008/11/05 11:22:54
425 fixes user/5975 from Rene Maroufi
426 - stevesk@cvs.openbsd.org 2008/11/07 00:42:12
428 spelling/typo in comment
429 - stevesk@cvs.openbsd.org 2008/11/07 18:50:18
431 add space to some log/debug messages for readability; ok djm@ markus@
432 - dtucker@cvs.openbsd.org 2008/11/07 23:34:48
434 Move JPAKE define to make life easier for portable. ok djm@
435 - tobias@cvs.openbsd.org 2008/11/09 12:34:47
437 typo fixed (overriden -> overridden)
439 - stevesk@cvs.openbsd.org 2008/11/11 02:58:09
441 USE_AFS not referenced so remove #ifdef. fixes sshd -T not printing
442 kerberosgetafstoken. ok dtucker@
443 (Id sync only, we still want the ifdef in portable)
444 - stevesk@cvs.openbsd.org 2008/11/11 03:55:11
446 for sshd -T print 'permitopen any' vs. 'permitopen' for case of no
447 permitopen's; ok and input dtucker@
448 - djm@cvs.openbsd.org 2008/11/10 02:06:35
449 [regress/putty-ciphers.sh]
450 PuTTY supports AES CTR modes, so interop test against them too
454 - djm@cvs.openbsd.org 2008/11/03 08:59:41
456 include MaxSessions in sshd -T output; patch from imorgan AT nas.nasa.gov
457 - djm@cvs.openbsd.org 2008/11/04 07:58:09
459 need unistd.h for close() prototype
461 - djm@cvs.openbsd.org 2008/11/04 08:22:13
462 [auth.h auth2.c monitor.c monitor.h monitor_wrap.c monitor_wrap.h]
463 [readconf.c readconf.h servconf.c servconf.h ssh2.h ssh_config.5]
464 [sshconnect2.c sshd_config.5 jpake.c jpake.h schnorr.c auth2-jpake.c]
466 Add support for an experimental zero-knowledge password authentication
467 method using the J-PAKE protocol described in F. Hao, P. Ryan,
468 "Password Authenticated Key Exchange by Juggling", 16th Workshop on
469 Security Protocols, Cambridge, April 2008.
471 This method allows password-based authentication without exposing
472 the password to the server. Instead, the client and server exchange
473 cryptographic proofs to demonstrate of knowledge of the password while
474 revealing nothing useful to an attacker or compromised endpoint.
476 This is experimental, work-in-progress code and is presently
477 compiled-time disabled (turn on -DJPAKE in Makefile.inc).
479 "just commit it. It isn't too intrusive." deraadt@
480 - stevesk@cvs.openbsd.org 2008/11/04 19:18:00
482 because parse_forward() is now used to parse all forward types (DLR),
483 and it malloc's space for host variables, we don't need to malloc
484 here. fixes small memory leaks.
486 previously dynamic forwards were not parsed in parse_forward() and
487 space was not malloc'd in that case.
490 - stevesk@cvs.openbsd.org 2008/11/05 03:23:09
492 add dynamic forward escape command line; ok djm@
496 - sthen@cvs.openbsd.org 2008/07/24 23:55:30
498 Add "ssh-keygen -F -l" to synopsis (displays fingerprint from
499 known_hosts). ok djm@
500 - grunk@cvs.openbsd.org 2008/07/25 06:56:35
502 Add VisualHostKey to example file, ok djm@
503 - grunk@cvs.openbsd.org 2008/07/25 07:05:16
505 In random art visualization, make sure to use the end marker only at the
506 end. Initial diff by Dirk Loss, tweaks and ok djm@
507 - markus@cvs.openbsd.org 2008/07/31 14:48:28
509 don't allocate space for empty banners; report t8m at centrum.cz;
511 - krw@cvs.openbsd.org 2008/08/02 04:29:51
513 whitepsace -> whitespace. From Matthew Clarke via bugs@.
514 - djm@cvs.openbsd.org 2008/08/21 04:09:57
516 allow ForceCommand internal-sftp with arguments. based on patch from
517 michael.barabanov AT gmail.com; ok markus@
518 - djm@cvs.openbsd.org 2008/09/06 12:24:13
520 OpenSSL 0.9.8h supplies a real EVP_sha256 so we do not need our
522 (ID sync only for portable - we still need this)
523 - markus@cvs.openbsd.org 2008/09/11 14:22:37
524 [compat.c compat.h nchan.c ssh.c]
525 only send eow and no-more-sessions requests to openssh 5 and newer;
526 fixes interop problems with broken ssh v2 implementations; ok djm@
527 - millert@cvs.openbsd.org 2008/10/02 14:39:35
529 Convert an unchecked strdup to xstrdup. OK deraadt@
530 - jmc@cvs.openbsd.org 2008/10/03 13:08:12
532 do not give an example of how to chmod files: we can presume the user
533 knows that. removes an ambiguity in the permission of authorized_keys;
535 - deraadt@cvs.openbsd.org 2008/10/03 23:56:28
537 Repair strnvis() buffersize of 4*n+1, with termination gauranteed by the
539 spotted by des@freebsd, who commited an incorrect fix to the freebsd tree
540 and (as is fairly typical) did not report the problem to us. But this fix
543 - djm@cvs.openbsd.org 2008/10/08 23:34:03
545 Add -y option to force logging via syslog rather than stderr.
546 Useful for daemonised ssh connection (ssh -f). Patch originally from
548 - djm@cvs.openbsd.org 2008/10/09 03:50:54
549 [servconf.c sshd_config.5]
550 support setting PermitEmptyPasswords in a Match block
551 requested in PR3891; ok dtucker@
552 - jmc@cvs.openbsd.org 2008/10/09 06:54:22
555 - stevesk@cvs.openbsd.org 2008/10/10 04:55:16
557 spelling in comment; ok djm@
558 - stevesk@cvs.openbsd.org 2008/10/10 05:00:12
560 typo in error message; ok djm@
561 - stevesk@cvs.openbsd.org 2008/10/10 16:43:27
563 use 'Privileged ports can be forwarded only when logging in as root on
564 the remote machine.' for RemoteForward just like ssh.1 -R.
566 - stevesk@cvs.openbsd.org 2008/10/14 18:11:33
568 use #define ROQUIET here; no binary change. ok dtucker@
569 - stevesk@cvs.openbsd.org 2008/10/17 18:36:24
571 correct and clarify VisualHostKey; ok jmc@
572 - stevesk@cvs.openbsd.org 2008/10/30 19:31:16
573 [clientloop.c sshd.c]
574 don't need to #include "monitor_fdpass.h"
575 - stevesk@cvs.openbsd.org 2008/10/31 15:05:34
577 remove unused #define DISPATCH_MIN; ok markus@
578 - djm@cvs.openbsd.org 2008/11/01 04:50:08
580 sprinkle ARGSUSED on dispatch handlers
581 nuke stale unusued prototype
582 - stevesk@cvs.openbsd.org 2008/11/01 06:43:33
584 fix some typos in log messages; ok djm@
585 - sobrado@cvs.openbsd.org 2008/11/01 11:14:36
586 [ssh-keyscan.1 ssh-keyscan.c]
587 the ellipsis is not an optional argument; while here, improve spacing.
588 - stevesk@cvs.openbsd.org 2008/11/01 17:40:33
589 [clientloop.c readconf.c readconf.h ssh.c]
590 merge dynamic forward parsing into parse_forward();
591 'i think this is OK' djm@
592 - stevesk@cvs.openbsd.org 2008/11/02 00:16:16
594 protocol 2 tty modes support is now 7.5 years old so remove these
595 debug3()s; ok deraadt@
596 - stevesk@cvs.openbsd.org 2008/11/03 01:07:02
598 remove valueless comment
599 - stevesk@cvs.openbsd.org 2008/11/03 02:44:41
602 - (djm) [contrib/caldera/ssh-host-keygen contrib/suse/rc.sshd]
603 Make example scripts generate keys with default sizes rather than fixed,
604 non-default 1024 bits; patch from imorgan AT nas.nasa.gov
605 - (djm) [contrib/sshd.pam.generic contrib/caldera/sshd.pam]
606 [contrib/redhat/sshd.pam] Move pam_nologin to account group from
607 incorrect auth group in example files;
608 patch from imorgan AT nas.nasa.gov
611 - (dtucker) [config.guess config.sub] Update to latest versions from
612 http://git.savannah.gnu.org/gitweb/ (2008-04-14 and 2008-06-16
616 - (dtucker) [openbsd-compat/bsd-poll.c] correctly check for number of FDs
617 larger than FD_SETSIZE (OpenSSH only ever uses poll with one fd). Patch
618 from Nicholas Marriott.
621 - (djm) OpenBSD CVS Sync
622 - djm@cvs.openbsd.org 2008/07/23 07:36:55
624 do not try to print options that have been compile-time disabled
625 in config test mode (sshd -T); report from nix-corp AT esperi.org.uk
627 - (djm) [servconf.c] Print UsePAM option in config test mode (when it
628 has been compiled in); report from nix-corp AT esperi.org.uk
632 - (djm) OpenBSD CVS Sync
633 - jmc@cvs.openbsd.org 2008/07/18 22:51:01
635 no need for .Pp before or after .Sh;
636 - djm@cvs.openbsd.org 2008/07/21 08:19:07
639 - (djm) [README contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
640 [contrib/suse/openssh.spec] Update version number in README and RPM specs
641 - (djm) Release OpenSSH-5.1
644 - (djm) OpenBSD CVS Sync
645 - djm@cvs.openbsd.org 2008/07/17 08:48:00
647 strnvis preauth banner; pointed out by mpf@ ok markus@
648 - djm@cvs.openbsd.org 2008/07/17 08:51:07
650 strip trailing '.' from hostname when HostbasedUsesNameFromPacketOnly=yes
651 report and patch from res AT qoxp.net (bz#1200); ok markus@
652 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Remove long-unneeded compat
653 code, replace with equivalent cygwin library call. Patch from vinschen
654 at redhat.com, ok djm@.
655 - (djm) [sshconnect2.c] vis.h isn't available everywhere
659 - djm@cvs.openbsd.org 2008/07/15 02:23:14
661 number of pipelined requests is now 64;
662 prodded by Iain.Morgan AT nasa.gov
663 - djm@cvs.openbsd.org 2008/07/16 11:51:14
665 rename variable first_gc -> last_gc (since it is actually the last
667 - djm@cvs.openbsd.org 2008/07/16 11:52:19
669 this loop index should be automatic, not static
672 - (djm) OpenBSD CVS Sync
673 - sthen@cvs.openbsd.org 2008/07/13 21:22:52
675 Change "ssh-keygen -F [host] -l" to not display random art unless
676 -v is also specified, making it consistent with the manual and other
679 - djm@cvs.openbsd.org 2008/07/13 22:13:07
681 use struct sockaddr_storage instead of struct sockaddr for accept(2)
682 address argument. from visibilis AT yahoo.com in bz#1485; ok markus@
683 - djm@cvs.openbsd.org 2008/07/13 22:16:03
685 increase number of piplelined requests so they properly fill the
686 (recently increased) channel window. prompted by rapier AT psc.edu;
688 - djm@cvs.openbsd.org 2008/07/14 01:55:56
690 mention requirement for /dev/log inside chroot when using sftp-server
692 - (djm) [openbsd-compat/bindresvport.c] Rename variables s/sin/in/ to
693 avoid clash with sin(3) function; reported by
694 cristian.ionescu-idbohrn AT axis.com
695 - (djm) [openbsd-compat/rresvport.c] Add unistd.h for missing close()
696 prototype; reported by cristian.ionescu-idbohrn AT axis.com
697 - (djm) [umac.c] Rename variable s/buffer_ptr/bufp/ to avoid clash;
698 reported by cristian.ionescu-idbohrn AT axis.com
699 - (djm) [contrib/cygwin/Makefile contrib/cygwin/ssh-host-config]
700 [contrib/cygwin/ssh-user-config contrib/cygwin/sshd-inetd]
701 Revamped and simplified Cygwin ssh-host-config script that uses
702 unified csih configuration tool. Requires recent Cygwin.
703 Patch from vinschen AT redhat.com
706 - (djm) OpenBSD CVS Sync
707 - djm@cvs.openbsd.org 2008/07/12 04:52:50
709 unbreak; move clearing of cctx struct to before first use
711 - djm@cvs.openbsd.org 2008/07/12 05:33:41
713 better description for -i flag:
714 s/RSA authentication/public key authentication/
715 - (djm) [openbsd-compat/fake-rfc2553.c openbsd-compat/fake-rfc2553.h]
716 return EAI_FAMILY when trying to lookup unsupported address family;
717 from vinschen AT redhat.com
720 - (djm) OpenBSD CVS Sync
721 - stevesk@cvs.openbsd.org 2008/07/07 00:31:41
723 we don't need arg after the debug3() was removed. from lint.
725 - stevesk@cvs.openbsd.org 2008/07/07 23:32:51
727 /*NOTREACHED*/ for lint warning:
728 warning: function key_equal falls off bottom without returning value
730 - markus@cvs.openbsd.org 2008/07/10 18:05:58
732 missing bzero; from mickey; ok djm@
733 - markus@cvs.openbsd.org 2008/07/10 18:08:11
734 [clientloop.c monitor.c monitor_wrap.c packet.c packet.h sshd.c]
735 sync v1 and v2 traffic accounting; add it to sshd, too;
739 - (djm) [Makefile.in] Print "all tests passed" when all regress tests pass
740 - (djm) [auth1.c] Fix format string vulnerability in protocol 1 PAM
741 account check failure path. The vulnerable format buffer is supplied
742 from PAM and should not contain attacker-supplied data.
743 - (djm) [auth.c] Missing unistd.h for close()
744 - (djm) [configure.ac] Add -Wformat-security to CFLAGS for gcc 3.x and 4.x
747 - (djm) [auth.c] Fixed test for locked account on HP/UX with shadowed
748 passwords disabled. bz#1083 report & patch from senthilkumar_sen AT
749 hotpop.com, w/ dtucker@
750 - (djm) [atomicio.c configure.ac] Disable poll() fallback in atomiciov for
751 Tru64. readv doesn't seem to be a comparable object there.
752 bz#1386, patch from dtucker@ ok me
753 - (djm) [Makefile.in] Pass though pass to conch for interop tests
754 - (djm) [configure.ac] unbreak: remove extra closing brace
755 - (djm) OpenBSD CVS Sync
756 - djm@cvs.openbsd.org 2008/07/04 23:08:25
758 handle EINTR in packet_write_poll()l ok dtucker@
759 - djm@cvs.openbsd.org 2008/07/04 23:30:16
761 Make protocol 1 MaxAuthTries logic match protocol 2's.
762 Do not treat the first protocol 2 authentication attempt as
763 a failure IFF it is for method "none".
764 Makes MaxAuthTries' user-visible behaviour identical for
767 - djm@cvs.openbsd.org 2008/07/05 05:16:01
772 - (dtucker) OpenBSD CVS Sync
773 - djm@cvs.openbsd.org 2008/07/02 13:30:34
775 really really remove the freebie "none" auth try for protocol 2
776 - djm@cvs.openbsd.org 2008/07/02 13:47:39
778 When forking after authentication ("ssh -f") with ExitOnForwardFailure
779 enabled, delay the fork until after replies for any -R forwards have
780 been seen. Allows for robust detection of -R forward failure when
781 using -f (similar to bz#92); ok dtucker@
782 - otto@cvs.openbsd.org 2008/07/03 21:46:58
784 avoid nasty double free; ok dtucker@ djm@
785 - djm@cvs.openbsd.org 2008/07/04 03:44:59
786 [servconf.c groupaccess.h groupaccess.c]
787 support negation of groups in "Match group" block (bz#1315); ok dtucker@
788 - dtucker@cvs.openbsd.org 2008/07/04 03:47:02
790 Make debug a little clearer. ok djm@
791 - djm@cvs.openbsd.org 2008/06/30 08:07:34
792 [regress/key-options.sh]
793 shell portability: use "=" instead of "==" in test(1) expressions,
794 double-quote string with backslash escaped /
795 - djm@cvs.openbsd.org 2008/06/30 10:31:11
796 [regress/{putty-transfer,putty-kex,putty-ciphers}.sh]
797 remove "set -e" left over from debugging
798 - djm@cvs.openbsd.org 2008/06/30 10:43:03
799 [regress/conch-ciphers.sh]
800 explicitly disable conch options that could interfere with the test
801 - (dtucker) [sftp-server.c] Bug #1447: fall back to racy rename if link
802 returns EXDEV. Patch from Mike Garrison, ok djm@
803 - (djm) [atomicio.c channels.c clientloop.c defines.h includes.h]
804 [packet.c scp.c serverloop.c sftp-client.c ssh-agent.c ssh-keyscan.c]
805 [sshd.c] Explicitly handle EWOULDBLOCK wherever we handle EAGAIN, on
806 some platforms (HP nonstop) it is a distinct errno;
807 bz#1467 reported by sconeu AT yahoo.com; ok dtucker@
810 - (dtucker) OpenBSD CVS Sync
811 - djm@cvs.openbsd.org 2008/06/30 08:05:59
813 typo: s/constraint_date/constraint_data/
814 - djm@cvs.openbsd.org 2008/06/30 12:15:39
816 only pass channel requests on session channels through to the session
817 channel handler, avoiding spurious log messages; ok! markus@
818 - djm@cvs.openbsd.org 2008/06/30 12:16:02
820 only send eow@openssh.com notifications for session channels; ok! markus@
821 - djm@cvs.openbsd.org 2008/06/30 12:18:34
823 clarify that eow@openssh.com is only sent on session channels
824 - dtucker@cvs.openbsd.org 2008/07/01 07:20:52
826 Check ExitOnForwardFailure if forwardings are disabled due to a failed
827 host key check. ok djm@
828 - dtucker@cvs.openbsd.org 2008/07/01 07:24:22
829 [sshconnect.c sshd.c]
830 Send CR LF during protocol banner exchanges, but only for Protocol 2 only,
831 in order to comply with RFC 4253. bz #1443, ok djm@
832 - stevesk@cvs.openbsd.org 2008/07/01 23:12:47
834 fix some typos; ok djm@
835 - djm@cvs.openbsd.org 2008/07/02 02:24:18
836 [sshd_config sshd_config.5 sshd.8 servconf.c]
837 increase default size of ssh protocol 1 ephemeral key from 768 to 1024
838 bits; prodded by & ok dtucker@ ok deraadt@
839 - dtucker@cvs.openbsd.org 2008/07/02 12:03:51
840 [auth-rsa.c auth.c auth2-pubkey.c auth.h]
841 Merge duplicate host key file checks, based in part on a patch from Rob
842 Holland via bz #1348 . Also checks for non-regular files during protocol
844 - djm@cvs.openbsd.org 2008/07/02 12:36:39
845 [auth2-none.c auth2.c]
846 Make protocol 2 MaxAuthTries behaviour a little more sensible:
847 Check whether client has exceeded MaxAuthTries before running
848 an authentication method and skip it if they have, previously it
849 would always allow one try (for "none" auth).
850 Preincrement failure count before post-auth test - previously this
851 checked and postincremented, also to allow one "none" try.
852 Together, these two changes always count the "none" auth method
853 which could be skipped by a malicious client (e.g. an SSH worm)
854 to get an extra attempt at a real auth method. They also make
855 MaxAuthTries=0 a useful way to block users entirely (esp. in a
856 sshd_config Match block).
857 Also, move sending of any preauth banner from "none" auth method
858 to the first call to input_userauth_request(), so worms that skip
859 the "none" method get to see it too.
862 - (djm) OpenBSD CVS Sync
863 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
864 [regress/Makefile regress/key-options.sh]
865 Add regress test for key options. ok djm@
866 - dtucker@cvs.openbsd.org 2008/06/11 23:11:40
868 Don't run cipher-speed test by default; mistakenly enabled by me
869 - djm@cvs.openbsd.org 2008/06/28 13:57:25
870 [regress/Makefile regress/test-exec.sh regress/conch-ciphers.sh]
871 very basic regress test against Twisted Conch in "make interop"
872 target (conch is available in ports/devel/py-twisted/conch);
874 - (djm) [regress/Makefile] search for conch by path, like we do putty
877 - (djm) OpenBSD CVS Sync
878 - martynas@cvs.openbsd.org 2008/06/21 07:46:46
880 use optopt to get invalid flag, instead of return value of getopt,
881 which is always '?'; ok djm@
882 - otto@cvs.openbsd.org 2008/06/25 11:13:43
884 add key length to visual fingerprint; zap magical constants;
886 - djm@cvs.openbsd.org 2008/06/26 06:10:09
887 [sftp-client.c sftp-server.c]
888 allow the sftp chmod(2)-equivalent operation to set set[ug]id/sticky
889 bits. Note that this only affects explicit setting of modes (e.g. via
890 sftp(1)'s chmod command) and not file transfers. (bz#1310)
892 - djm@cvs.openbsd.org 2008/06/26 09:19:40
894 when loading moduli from /etc/moduli in sshd(8), check that they
895 are of the expected "safe prime" structure and have had
896 appropriate primality tests performed;
897 feedback and ok dtucker@
898 - grunk@cvs.openbsd.org 2008/06/26 11:46:31
899 [readconf.c readconf.h ssh.1 ssh_config.5 sshconnect.c]
900 Move SSH Fingerprint Visualization away from sharing the config option
901 CheckHostIP to an own config option named VisualHostKey.
902 While there, fix the behaviour that ssh would draw a random art picture
903 on every newly seen host even when the option was not enabled.
904 prodded by deraadt@, discussions,
905 help and ok markus@ djm@ dtucker@
906 - jmc@cvs.openbsd.org 2008/06/26 21:11:46
908 add VisualHostKey to the list of options listed in -o;
909 - djm@cvs.openbsd.org 2008/06/28 07:25:07
912 - djm@cvs.openbsd.org 2008/06/28 13:58:23
914 refuse to add a key that has unknown constraints specified;
916 - djm@cvs.openbsd.org 2008/06/28 14:05:15
918 reset global compat flag after processing a protocol 2 signature
919 request with the legacy DSA encoding flag set; ok markus
920 - djm@cvs.openbsd.org 2008/06/28 14:08:30
921 [PROTOCOL PROTOCOL.agent]
922 document the protocol used by ssh-agent; "looks ok" markus@
925 - (djm) [RFC.nroff contrib/cygwin/Makefile contrib/suse/openssh.spec]
926 RFC.nroff lacks a license, remove it (it is long gone in OpenBSD).
929 - (djm) [Makefile.in moduli.5] Include moduli(5) manpage from OpenBSD.
931 - (djm) [ contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
932 [contrib/suse/openssh.spec] Include moduli.5 in RPM spec files.
935 - (dtucker) OpenBSD CVS Sync
936 - dtucker@cvs.openbsd.org 2008/06/16 13:22:53
937 [session.c channels.c]
938 Rename the isatty argument to is_tty so we don't shadow
939 isatty(3). ok markus@
940 - (dtucker) [channels.c] isatty -> is_tty here too.
943 - (dtucker) [configure.ac] Enable -fno-builtin-memset when using gcc.
945 - dtucker@cvs.openbsd.org 2008/06/14 15:49:48
947 wrap long line at 80 chars
948 - dtucker@cvs.openbsd.org 2008/06/14 17:07:11
950 ensure default umask disallows at least group and world write; ok djm@
951 - djm@cvs.openbsd.org 2008/06/14 18:33:43
953 suppress the warning message from chdir(homedir) failures
954 when chrooted (bz#1461); ok dtucker
955 - dtucker@cvs.openbsd.org 2008/06/14 19:42:10
957 Mention that scp follows symlinks during -r. bz #1466,
959 - dtucker@cvs.openbsd.org 2008/06/15 16:55:38
961 MaxSessions is allowed in a Match block too
962 - dtucker@cvs.openbsd.org 2008/06/15 16:58:40
963 [servconf.c sshd_config.5]
964 Allow MaxAuthTries within a Match block. ok djm@
965 - djm@cvs.openbsd.org 2008/06/15 20:06:26
966 [channels.c channels.h session.c]
967 don't call isatty() on a pty master, instead pass a flag down to
968 channel_set_fds() indicating that te fds refer to a tty. Fixes a
969 hang on exit on Solaris (bz#1463) in portable but is actually
970 a generic bug; ok dtucker deraadt markus
973 - (djm) [openbsd-compat/sigact.c] Avoid NULL derefs in ancient sigaction
974 replacement code; patch from ighighi AT gmail.com in bz#1240;
978 - (dtucker) OpenBSD CVS Sync
979 - deraadt@cvs.openbsd.org 2008/06/13 09:44:36
981 compile on older gcc; no decl after code
982 - dtucker@cvs.openbsd.org 2008/06/13 13:56:59
984 Clear key options in the monitor on failed authentication, prevents
985 applying additional restrictions to non-pubkey authentications in
986 the case where pubkey fails but another method subsequently succeeds.
987 bz #1472, found by Colin Watson, ok markus@ djm@
988 - dtucker@cvs.openbsd.org 2008/06/13 14:18:51
989 [auth2-pubkey.c auth-rhosts.c]
990 Include unistd.h for close(), prevents warnings in -portable
991 - dtucker@cvs.openbsd.org 2008/06/13 17:21:20
993 Friendlier error messages for mux fallback. ok djm@
994 - dtucker@cvs.openbsd.org 2008/06/13 18:55:22
996 Prevent -Wsign-compare warnings on LP64 systems. bz #1192, ok deraadt@
997 - grunk@cvs.openbsd.org 2008/06/13 20:13:26
999 Explain the use of SSH fpr visualization using random art, and cite the
1000 original scientific paper inspiring that technique.
1001 Much help with English and nroff by jmc@, thanks.
1002 - (dtucker) [configure.ac] Bug #1276: avoid linking against libgssapi, which
1003 despite its name doesn't seem to implement all of GSSAPI. Patch from
1004 Jan Engelhardt, sanity checked by Simon Wilkinson.
1007 - (dtucker) OpenBSD CVS Sync
1008 - jmc@cvs.openbsd.org 2008/06/11 07:30:37
1010 kill trailing whitespace;
1011 - grunk@cvs.openbsd.org 2008/06/11 21:01:35
1012 [ssh_config.5 key.h readconf.c readconf.h ssh-keygen.1 ssh-keygen.c key.c
1014 Introduce SSH Fingerprint ASCII Visualization, a technique inspired by the
1015 graphical hash visualization schemes known as "random art", and by
1016 Dan Kaminsky's musings on the subject during a BlackOp talk at the
1018 Scientific publication (original paper):
1019 "Hash Visualization: a New Technique to improve Real-World Security",
1020 Perrig A. and Song D., 1999, International Workshop on Cryptographic
1021 Techniques and E-Commerce (CrypTEC '99)
1022 http://sparrow.ece.cmu.edu/~adrian/projects/validation/validation.pdf
1023 The algorithm used here is a worm crawling over a discrete plane,
1024 leaving a trace (augmenting the field) everywhere it goes.
1025 Movement is taken from dgst_raw 2bit-wise. Bumping into walls
1026 makes the respective movement vector be ignored for this turn,
1027 thus switching to the other color of the chessboard.
1028 Graphs are not unambiguous for now, because circles in graphs can be
1029 walked in either direction.
1030 discussions with several people,
1031 help, corrections and ok markus@ djm@
1032 - grunk@cvs.openbsd.org 2008/06/11 21:38:25
1034 ssh-keygen -lv -f /etc/ssh/ssh_host_rsa_key.pub
1035 would not display you the random art as intended, spotted by canacar@
1036 - grunk@cvs.openbsd.org 2008/06/11 22:20:46
1037 [ssh-keygen.c ssh-keygen.1]
1038 ssh-keygen would write fingerprints to STDOUT, and random art to STDERR,
1039 that is not how it was envisioned.
1040 Also correct manpage saying that -v is needed along with -l for it to work.
1042 - otto@cvs.openbsd.org 2008/06/11 23:02:22
1044 simpler way of computing the augmentations; ok grunk@
1045 - grunk@cvs.openbsd.org 2008/06/11 23:03:56
1047 CheckHostIP set to ``fingerprint'' will display both hex and random art
1049 - grunk@cvs.openbsd.org 2008/06/11 23:51:57
1051 #define statements that are not atoms need braces around them, else they
1052 will cause trouble in some cases.
1053 Also do a computation of -1 once, and not in a loop several times.
1055 - dtucker@cvs.openbsd.org 2008/06/12 00:03:49
1056 [dns.c canohost.c sshconnect.c]
1057 Do not pass "0" strings as ports to getaddrinfo because the lookups
1058 can slow things down and we never use the service info anyway. bz
1059 #859, patch from YOSHIFUJI Hideaki and John Devitofranceschi. ok
1061 djm belives that the reason for the "0" strings is to ensure that
1062 it's not possible to call getaddrinfo with both host and port being
1063 NULL. In the case of canohost.c host is a local array. In the
1064 case of sshconnect.c, it's checked for null immediately before use.
1065 In dns.c it ultimately comes from ssh.c:main() and is guaranteed to
1066 be non-null but it's not obvious, so I added a warning message in
1067 case it is ever passed a null.
1068 - grunk@cvs.openbsd.org 2008/06/12 00:13:55
1070 Make ssh print the random art also when ssh'ing to a host using IP only.
1071 spotted by naddy@, ok and help djm@ dtucker@
1072 - otto@cvs.openbsd.org 2008/06/12 00:13:13
1074 use an odd number of rows and columns and a separate start marker, looks
1076 - djm@cvs.openbsd.org 2008/06/12 03:40:52
1077 [clientloop.h mux.c channels.c clientloop.c channels.h]
1078 Enable ~ escapes for multiplex slave sessions; give each channel
1079 its own escape state and hook the escape filters up to muxed
1081 Mux slaves do not currently support the ~^Z and ~& escapes.
1082 NB. this change cranks the mux protocol version, so a new ssh
1083 mux client will not be able to connect to a running old ssh
1086 - djm@cvs.openbsd.org 2008/06/12 04:06:00
1087 [clientloop.h ssh.c clientloop.c]
1088 maintain an ordered queue of outstanding global requests that we
1089 expect replies to, similar to the per-channel confirmation queue.
1090 Use this queue to verify success or failure for remote forward
1091 establishment in a race free way.
1093 - djm@cvs.openbsd.org 2008/06/12 04:17:47
1095 thall shalt not code past the eightieth column
1096 - djm@cvs.openbsd.org 2008/06/12 04:24:06
1098 thal shalt not code past the eightieth column
1099 - djm@cvs.openbsd.org 2008/06/12 05:15:41
1101 document tun@openssh.com forwarding method
1102 - djm@cvs.openbsd.org 2008/06/12 05:32:30
1104 some more TODO for me
1105 - grunk@cvs.openbsd.org 2008/06/12 05:42:46
1107 supply the key type (rsa1, rsa, dsa) as a caption in the frame of the
1108 random art. while there, stress the fact that the field base should at
1109 least be 8 characters for the pictures to make sense.
1111 - grunk@cvs.openbsd.org 2008/06/12 06:32:59
1113 We already mark the start of the worm, now also mark the end of the worm
1114 in our random art drawings.
1116 - djm@cvs.openbsd.org 2008/06/12 15:19:17
1117 [clientloop.h channels.h clientloop.c channels.c mux.c]
1118 The multiplexing escape char handler commit last night introduced a
1119 small memory leak per session; plug it.
1120 - dtucker@cvs.openbsd.org 2008/06/12 16:35:31
1121 [ssh_config.5 ssh.c]
1122 keyword expansion for localcommand. ok djm@
1123 - jmc@cvs.openbsd.org 2008/06/12 19:10:09
1124 [ssh_config.5 ssh-keygen.1]
1125 tweak the ascii art text; ok grunk
1126 - dtucker@cvs.openbsd.org 2008/06/12 20:38:28
1127 [sshd.c sshconnect.c packet.h misc.c misc.h packet.c]
1128 Make keepalive timeouts apply while waiting for a packet, particularly
1129 during key renegotiation (bz #1363). With djm and Matt Day, ok djm@
1130 - djm@cvs.openbsd.org 2008/06/12 20:47:04
1132 print extension revisions for extensions that we understand
1133 - djm@cvs.openbsd.org 2008/06/12 21:06:25
1135 I was coalescing expected global request confirmation replies at
1136 the wrong end of the queue - fix; prompted by markus@
1137 - grunk@cvs.openbsd.org 2008/06/12 21:14:46
1139 make ssh-keygen -lf show the key type just as ssh-add -l would do it
1141 - grunk@cvs.openbsd.org 2008/06/12 22:03:36
1143 add my copyright, ok djm@
1144 - ian@cvs.openbsd.org 2008/06/12 23:24:58
1146 tweak wording in message, ok deraadt@ jmc@
1147 - dtucker@cvs.openbsd.org 2008/06/13 00:12:02
1149 replace __dead with __attribute__((noreturn)), makes things
1150 a little easier to port. Also, add it to sigdie(). ok djm@
1151 - djm@cvs.openbsd.org 2008/06/13 00:16:49
1153 fall back to creating a new TCP connection on most multiplexing errors
1154 (socket connect fail, invalid version, refused permittion, corrupted
1155 messages, etc.); bz #1329 ok dtucker@
1156 - dtucker@cvs.openbsd.org 2008/06/13 00:47:53
1158 upcast size_t to u_long to match format arg; ok djm@
1159 - dtucker@cvs.openbsd.org 2008/06/13 00:51:47
1161 upcast another size_t to u_long to match format
1162 - dtucker@cvs.openbsd.org 2008/06/13 01:38:23
1164 upcast uid to long with matching %ld, prevents warnings in portable
1165 - djm@cvs.openbsd.org 2008/06/13 04:40:22
1166 [auth2-pubkey.c auth-rhosts.c]
1167 refuse to read ~/.shosts or ~/.ssh/authorized_keys that are not
1168 regular files; report from Solar Designer via Colin Watson in bz#1471
1170 - (dtucker) [clientloop.c serverloop.c] channel_register_filter now
1171 takes 2 more args. with djm@
1172 - (dtucker) [defines.h] Bug #1112: __dead is, well dead. Based on a patch
1174 - (dtucker) [auth-sia.c] Bug #1241: support password expiry on Tru64 SIA
1175 systems. Patch from R. Scott Bailey.
1176 - (dtucker) [umac.c] STORE_UINT32_REVERSED and endian_convert are never used
1177 on big endian machines, so ifdef them for little-endian only to prevent
1178 unused function warnings on big-endians.
1179 - (dtucker) [openbsd-compat/setenv.c] Make offsets size_t to prevent
1180 compiler warnings on some platforms. Based on a discussion with otto@
1183 - (djm) [channels.c configure.ac]
1184 Do not set SO_REUSEADDR on wildcard X11 listeners (X11UseLocalhost=no)
1188 - (dtucker) OpenBSD CVS Sync
1189 - djm@cvs.openbsd.org 2008/06/10 03:57:27
1190 [servconf.c match.h sshd_config.5]
1191 support CIDR address matching in sshd_config "Match address" blocks, with
1192 full support for negation and fall-back to classic wildcard matching.
1194 Match address 192.0.2.0/24,3ffe:ffff::/32,!10.*
1195 PasswordAuthentication yes
1196 addrmatch.c code mostly lifted from flowd's addr.c
1197 feedback and ok dtucker@
1198 - djm@cvs.openbsd.org 2008/06/10 04:17:46
1200 better reference for pattern-list
1201 - dtucker@cvs.openbsd.org 2008/06/10 04:50:25
1202 [sshd.c channels.h channels.c log.c servconf.c log.h servconf.h sshd.8]
1203 Add extended test mode (-T) and connection parameters for test mode (-C).
1204 -T causes sshd to write its effective configuration to stdout and exit.
1205 -C causes any relevant Match rules to be applied before output. The
1206 combination allows tesing of the parser and config files. ok deraadt djm
1207 - jmc@cvs.openbsd.org 2008/06/10 07:12:00
1210 - jmc@cvs.openbsd.org 2008/06/10 08:17:40
1213 - fix SYNOPSIS, and sort options
1214 - some minor additional fixes
1215 - dtucker@cvs.openbsd.org 2008/06/09 18:06:32
1216 [regress/test-exec.sh]
1217 Don't generate putty keys if we're not going to use them. ok djm
1218 - dtucker@cvs.openbsd.org 2008/06/10 05:23:32
1219 [regress/addrmatch.sh regress/Makefile]
1220 Regress test for Match CIDR rules. ok djm@
1221 - dtucker@cvs.openbsd.org 2008/06/10 15:21:41
1223 Use a more portable construct for checking if we're running a putty test
1224 - dtucker@cvs.openbsd.org 2008/06/10 15:28:49
1227 - dtucker@cvs.openbsd.org 2008/06/10 18:21:24
1229 clarify that Host patterns are space-separated. ok deraadt
1230 - djm@cvs.openbsd.org 2008/06/10 22:15:23
1231 [PROTOCOL ssh.c serverloop.c]
1232 Add a no-more-sessions@openssh.com global request extension that the
1233 client sends when it knows that it will never request another session
1234 (i.e. when session multiplexing is disabled). This allows a server to
1235 disallow further session requests and terminate the session.
1236 Why would a non-multiplexing client ever issue additional session
1237 requests? It could have been attacked with something like SSH'jack:
1238 http://www.storm.net.nz/projects/7
1239 feedback & ok markus
1240 - djm@cvs.openbsd.org 2008/06/10 23:06:19
1241 [auth-options.c match.c servconf.c addrmatch.c sshd.8]
1242 support CIDR address matching in .ssh/authorized_keys from="..." stanzas
1243 ok and extensive testing dtucker@
1244 - dtucker@cvs.openbsd.org 2008/06/10 23:21:34
1246 Use '\0' for a nul byte rather than unadorned 0. ok djm@
1247 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
1248 [Makefile regress/key-options.sh]
1249 Add regress test for key options. ok djm@
1250 - (dtucker) [openbsd-compat/fake-rfc2553.h] Add sin6_scope_id to sockaddr_in6
1251 since the new CIDR code in addmatch.c references it.
1252 - (dtucker) [Makefile.in configure.ac regress/addrmatch.sh] Skip IPv6
1253 specific tests on platforms that don't do IPv6.
1254 - (dtucker) [Makefile.in] Define TEST_SSH_IPV6 in make's arguments as well
1256 - (dtucker) [Makefile.in] Move addrmatch.o to libssh.a where it's needed now.
1259 - (dtucker) OpenBSD CVS Sync
1260 - dtucker@cvs.openbsd.org 2008/06/08 17:04:41
1262 Add case for ENOSYS in errno_to_portable; ok deraadt
1263 - dtucker@cvs.openbsd.org 2008/06/08 20:15:29
1264 [sftp.c sftp-client.c sftp-client.h]
1265 Have the sftp client store the statvfs replies in wire format,
1266 which prevents problems when the server's native sizes exceed the
1268 Also extends the sizes of the remaining 32bit wire format to 64bit,
1269 they're specified as unsigned long in the standard.
1270 - dtucker@cvs.openbsd.org 2008/06/09 13:02:39
1272 Extend 32bit -> 64bit values for statvfs extension missed in previous
1274 - dtucker@cvs.openbsd.org 2008/06/09 13:38:46
1276 Use a $OpenBSD tag so our scripts will sync changes.
1279 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c
1280 openbsd-compat/Makefile.in openbsd-compat/openbsd-compat.h
1281 openbsd-compat/bsd-statvfs.{c,h}] Add a null implementation of statvfs and
1282 fstatvfs and remove #defines around statvfs code. ok djm@
1283 - (dtucker) [configure.ac defines.h sftp-client.c M sftp-server.c] Add a
1284 macro to convert fsid to unsigned long for platforms where fsid is a
1288 - (dtucker) [mux.c] Include paths.h inside ifdef HAVE_PATHS_H.
1289 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c]
1290 Do not enable statvfs extensions on platforms that do not have statvfs.
1291 - (dtucker) OpenBSD CVS Sync
1292 - djm@cvs.openbsd.org 2008/05/19 06:14:02
1293 [packet.c] unbreak protocol keepalive timeouts bz#1465; ok dtucker@
1294 - djm@cvs.openbsd.org 2008/05/19 15:45:07
1295 [sshtty.c ttymodes.c sshpty.h]
1296 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1297 we would send the modes corresponding to a zeroed struct termios,
1298 whereas we should have been sending an empty list of modes.
1299 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1300 - djm@cvs.openbsd.org 2008/05/19 15:46:31
1302 support -l (print fingerprint) in combination with -F (find host) to
1303 search for a host in ~/.ssh/known_hosts and display its fingerprint;
1305 - djm@cvs.openbsd.org 2008/05/19 20:53:52
1307 unbreak tree by committing this bit that I missed from:
1308 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1309 we would send the modes corresponding to a zeroed struct termios,
1310 whereas we should have been sending an empty list of modes.
1311 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1314 - (djm) [openbsd-compat/bsd-arc4random.c] Fix math bug that caused bias
1315 in arc4random_uniform with upper_bound in (2^30,2*31). Note that
1316 OpenSSH did not make requests with upper bounds in this range.
1319 - (djm) [configure.ac mux.c sftp.c openbsd-compat/Makefile.in]
1320 [openbsd-compat/fmt_scaled.c openbsd-compat/openbsd-compat.h]
1321 Fix compilation on Linux, including pulling in fmt_scaled(3)
1322 implementation from OpenBSD's libutil.
1325 - (djm) OpenBSD CVS Sync
1326 - djm@cvs.openbsd.org 2008/04/04 05:14:38
1328 ChrootDirectory is supported in Match blocks (in fact, it is most useful
1329 there). Spotted by Minstrel AT minstrel.org.uk
1330 - djm@cvs.openbsd.org 2008/04/04 06:44:26
1332 oops, some unrelated stuff crept into that commit - backout.
1334 - djm@cvs.openbsd.org 2008/04/05 02:46:02
1336 HostbasedAuthentication is supported under Match too
1337 - (djm) [openbsd-compat/bsd-arc4random.c openbsd-compat/openbsd-compat.c]
1338 [configure.ac] Implement arc4random_buf(), import implementation of
1339 arc4random_uniform() from OpenBSD
1340 - (djm) [openbsd-compat/bsd-arc4random.c] Warning fixes
1341 - (djm) [openbsd-compat/port-tun.c] needs sys/queue.h
1342 - (djm) OpenBSD CVS Sync
1343 - djm@cvs.openbsd.org 2008/04/13 00:22:17
1345 Use arc4random_buf() when requesting more than a single word of output
1346 Use arc4random_uniform() when the desired random number upper bound
1347 is not a power of two
1348 ok deraadt@ millert@
1349 - djm@cvs.openbsd.org 2008/04/18 12:32:11
1350 [sftp-client.c sftp-client.h sftp-server.c sftp.1 sftp.c sftp.h]
1351 introduce sftp extension methods statvfs@openssh.com and
1352 fstatvfs@openssh.com that implement statvfs(2)-like operations,
1353 based on a patch from miklos AT szeredi.hu (bz#1399)
1354 also add a "df" command to the sftp client that uses the
1355 statvfs@openssh.com to produce a df(1)-like display of filesystem
1356 space and inode utilisation
1358 - jmc@cvs.openbsd.org 2008/04/18 17:15:47
1361 - djm@cvs.openbsd.org 2008/04/18 22:01:33
1363 remove unneccessary parentheses
1364 - otto@cvs.openbsd.org 2008/04/29 11:20:31
1366 garbage collect two unused fields in struct mm_master; ok markus@
1367 - djm@cvs.openbsd.org 2008/04/30 10:14:03
1368 [ssh-keyscan.1 ssh-keyscan.c]
1369 default to rsa (protocol 2) keys, instead of rsa1 keys; spotted by
1370 larsnooden AT openoffice.org
1371 - pyr@cvs.openbsd.org 2008/05/07 05:49:37
1372 [servconf.c servconf.h session.c sshd_config.5]
1373 Enable the AllowAgentForwarding option in sshd_config (global and match
1374 context), to specify if agents should be permitted on the server.
1375 As the man page states:
1376 ``Note that disabling Agent forwarding does not improve security
1377 unless users are also denied shell access, as they can always install
1378 their own forwarders.''
1379 ok djm@, ok and a mild frown markus@
1380 - pyr@cvs.openbsd.org 2008/05/07 06:43:35
1382 push the sshd_config bits in, spotted by ajacoutot@
1383 - jmc@cvs.openbsd.org 2008/05/07 08:00:14
1386 - markus@cvs.openbsd.org 2008/05/08 06:59:01
1387 [bufaux.c buffer.h channels.c packet.c packet.h]
1388 avoid extra malloc/copy/free when receiving data over the net;
1389 ~10% speedup for localhost-scp; ok djm@
1390 - djm@cvs.openbsd.org 2008/05/08 12:02:23
1391 [auth-options.c auth1.c channels.c channels.h clientloop.c gss-serv.c]
1392 [monitor.c monitor_wrap.c nchan.c servconf.c serverloop.c session.c]
1394 Implement a channel success/failure status confirmation callback
1395 mechanism. Each channel maintains a queue of callbacks, which will
1396 be drained in order (RFC4253 guarantees confirm messages are not
1397 reordered within an channel).
1398 Also includes a abandonment callback to clean up if a channel is
1399 closed without sending confirmation messages. This probably
1400 shouldn't happen in compliant implementations, but it could be
1401 abused to leak memory.
1402 ok markus@ (as part of a larger diff)
1403 - djm@cvs.openbsd.org 2008/05/08 12:21:16
1404 [monitor.c monitor_wrap.c session.h servconf.c servconf.h session.c]
1405 [sshd_config sshd_config.5]
1406 Make the maximum number of sessions run-time controllable via
1407 a sshd_config MaxSessions knob. This is useful for disabling
1408 login/shell/subsystem access while leaving port-forwarding working
1409 (MaxSessions 0), disabling connection multiplexing (MaxSessions 1) or
1410 simply increasing the number of allows multiplexed sessions.
1411 Because some bozos are sure to configure MaxSessions in excess of the
1412 number of available file descriptors in sshd (which, at peak, might be
1413 as many as 9*MaxSessions), audit sshd to ensure that it doesn't leak fds
1414 on error paths, and make it fail gracefully on out-of-fd conditions -
1415 sending channel errors instead of than exiting with fatal().
1416 bz#1090; MaxSessions config bits and manpage from junyer AT gmail.com
1418 - djm@cvs.openbsd.org 2008/05/08 13:06:11
1419 [clientloop.c clientloop.h ssh.c]
1420 Use new channel status confirmation callback system to properly deal
1421 with "important" channel requests that fail, in particular command exec,
1422 shell and subsystem requests. Previously we would optimistically assume
1423 that the requests would always succeed, which could cause hangs if they
1424 did not (e.g. when the server runs out of fds) or were unimplemented by
1425 the server (bz #1384)
1426 Also, properly report failing multiplex channel requests via the mux
1427 client stderr (subject to LogLevel in the mux master) - better than
1429 most bits ok markus@ (as part of a larger diff)
1430 - djm@cvs.openbsd.org 2008/05/09 04:55:56
1431 [channels.c channels.h clientloop.c serverloop.c]
1432 Try additional addresses when connecting to a port forward destination
1433 whose DNS name resolves to more than one address. The previous behaviour
1434 was to try the first address and give up.
1435 Reported by stig AT venaas.com in bz#343
1436 great feedback and ok markus@
1437 - djm@cvs.openbsd.org 2008/05/09 14:18:44
1438 [clientloop.c clientloop.h ssh.c mux.c]
1439 tidy up session multiplexing code, moving it into its own file and
1440 making the function names more consistent - making ssh.c and
1441 clientloop.c a fair bit more readable.
1443 - djm@cvs.openbsd.org 2008/05/09 14:26:08
1445 dingo stole my diff hunk
1446 - markus@cvs.openbsd.org 2008/05/09 16:16:06
1448 re-add the USE_PIPES code and enable it.
1449 without pipes shutdown-read from the sshd does not trigger
1450 a SIGPIPE when the forked program does a write.
1452 (Id sync only, USE_PIPES never left portable OpenSSH)
1453 - markus@cvs.openbsd.org 2008/05/09 16:17:51
1455 error-fd race: don't enable the error fd in the select bitmask
1456 for channels with both in- and output closed, since the channel
1457 will go away before we call select();
1458 report, lots of debugging help and ok djm@
1459 - markus@cvs.openbsd.org 2008/05/09 16:21:13
1460 [channels.h clientloop.c nchan.c serverloop.c]
1462 ssh -2 localhost od /bin/ls | true
1463 ignoring SIGPIPE by adding a new channel message (EOW) that signals
1464 the peer that we're not interested in any data it might send.
1465 fixes bz #85; discussion, debugging and ok djm@
1466 - pvalchev@cvs.openbsd.org 2008/05/12 20:52:20
1468 Ensure nh_result lies on a 64-bit boundary (fixes warnings observed
1469 on Itanium on Linux); from Dale Talcott (bug #1462); ok djm@
1470 - djm@cvs.openbsd.org 2008/05/15 23:52:24
1472 document eow message in ssh protocol 2 channel state machine;
1473 feedback and ok markus@
1474 - djm@cvs.openbsd.org 2008/05/18 21:29:05
1476 comment extension announcement
1477 - djm@cvs.openbsd.org 2008/05/16 08:30:42
1479 document our protocol extensions and deviations; ok markus@
1480 - djm@cvs.openbsd.org 2008/05/17 01:31:56
1482 grammar and correctness fixes from stevesk@
1485 - (djm) [openbsd-compat/bsd-poll.c] Include stdlib.h to avoid compile-
1486 time warnings on LynxOS. Patch from ops AT iki.fi
1487 - (djm) Force string arguments to replacement setproctitle() though
1488 strnvis first. Ok dtucker@
1491 - (djm) OpenBSD CVS sync:
1492 - markus@cvs.openbsd.org 2008/04/02 15:36:51
1494 avoid possible hijacking of x11-forwarded connections (back out 1.183)
1495 CVE-2008-1483; ok djm@
1496 - jmc@cvs.openbsd.org 2008/03/27 22:37:57
1498 remove trailing whitespace;
1499 - djm@cvs.openbsd.org 2008/04/03 09:50:14
1502 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
1503 [contrib/suse/openssh.spec] Crank version numbers in RPM spec files
1504 - (djm) [README] Update link to release notes
1505 - (djm) Release 5.0p1