2 - (dtucker) OpenBSD CVS Sync
3 - andreas@cvs.openbsd.org 2009/10/24 11:11:58
5 Declarations needed for upcoming changes.
7 - andreas@cvs.openbsd.org 2009/10/24 11:13:54
8 [sshconnect2.c kex.h kex.c]
9 Let the client detect if the server supports roaming by looking
10 for the resume@appgate.com kex algorithm.
12 - andreas@cvs.openbsd.org 2009/10/24 11:15:29
14 client_loop() must detect if the session has been suspended and resumed,
15 and take appropriate action in that case.
16 From Martin Forssen, maf at appgate dot com
17 - andreas@cvs.openbsd.org 2009/10/24 11:19:17
19 Define the KEX messages used when resuming a suspended connection.
21 - andreas@cvs.openbsd.org 2009/10/24 11:22:37
23 Do the actual suspend/resume in the client. This won't be useful until
24 the server side supports roaming.
25 Most code from Martin Forssen, maf at appgate dot com. Some changes by
28 - andreas@cvs.openbsd.org 2009/10/24 11:23:42
30 Request roaming to be enabled if UseRoaming is true and the server
33 - reyk@cvs.openbsd.org 2009/10/28 16:38:18
34 [ssh_config.5 sshd.c misc.h ssh-keyscan.1 readconf.h sshconnect.c
35 channels.c channels.h servconf.h servconf.c ssh.1 ssh-keyscan.c scp.1
36 sftp.1 sshd_config.5 readconf.c ssh.c misc.c]
37 Allow to set the rdomain in ssh/sftp/scp/sshd and ssh-keyscan.
39 - jmc@cvs.openbsd.org 2009/10/28 21:45:08
40 [sshd_config.5 sftp.1]
42 - djm@cvs.openbsd.org 2009/11/10 02:56:22
44 explain the constraints on LocalCommand some more so people don't
46 - djm@cvs.openbsd.org 2009/11/10 02:58:56
48 clarify that StrictModes does not apply to ChrootDirectory. Permissions
49 and ownership are always checked when chrooting. bz#1532
50 - dtucker@cvs.openbsd.org 2009/11/10 04:30:45
51 [sshconnect2.c channels.c sshconnect.c]
52 Set close-on-exec on various descriptors so they don't get leaked to
53 child processes. bz #1643, patch from jchadima at redhat, ok deraadt.
54 - markus@cvs.openbsd.org 2009/11/11 21:37:03
55 [channels.c channels.h]
56 fix race condition in x11/agent channel allocation: don't read after
57 the end of the select read/write fdset and make sure a reused FD
58 is not touched before the pre-handlers are called.
60 - djm@cvs.openbsd.org 2009/11/17 05:31:44
62 fix incorrect exit status when multiplexing and channel ID 0 is recycled
63 bz#1570 reported by peter.oliver AT eon-is.co.uk; ok dtucker
64 - djm@cvs.openbsd.org 2009/11/19 23:39:50
66 bz#1606: error when an attempt is made to connect to a server
67 with ForceCommand=internal-sftp with a shell session (i.e. not a
68 subsystem session). Avoids stuck client when attempting to ssh to such a
70 - dtucker@cvs.openbsd.org 2009/11/20 00:15:41
72 Warn but do not fail if stat()ing the subsystem binary fails. This helps
73 with chrootdirectory+forcecommand=sftp-server and restricted shells.
75 - djm@cvs.openbsd.org 2009/11/20 00:54:01
77 bz#1588 change "Connecting to host..." message to "Connected to host."
78 and delay it until after the sftp protocol connection has been established.
79 Avoids confusing sequence of messages when the underlying ssh connection
80 experiences problems. ok dtucker@
81 - dtucker@cvs.openbsd.org 2009/11/20 00:59:36
83 Use the HostKeyAlias when prompting for passwords. bz#1039, ok djm@
84 - djm@cvs.openbsd.org 2009/11/20 03:24:07
86 correct off-by-one in percent_expand(): we would fatal() when trying
87 to expand EXPAND_MAX_KEYS, allowing only EXPAND_MAX_KEYS-1 to actually
88 work. Note that nothing in OpenSSH actually uses close to this limit at
89 present. bz#1607 from Jan.Pechanec AT Sun.COM
90 - halex@cvs.openbsd.org 2009/11/22 13:18:00
92 make passing of zero-length arguments to ssh safe by
93 passing "-<switch>" "<value>" rather than "-<switch><value>"
94 ok dtucker@, guenther@, djm@
95 - dtucker@cvs.openbsd.org 2009/12/06 23:41:15
97 zap unused variable and strlen; from Steve McClellan, ok djm
98 - djm@cvs.openbsd.org 2009/12/06 23:53:45
100 use socklen_t for getsockopt optlen parameter; reported by
101 Steve.McClellan AT radisys.com, ok dtucker@
102 - dtucker@cvs.openbsd.org 2009/12/06 23:53:54
104 fix potential divide-by-zero in sftp's "df" output when talking to a server
105 that reports zero files on the filesystem (Unix filesystems always have at
106 least the root inode). From Steve McClellan at radisys, ok djm@
107 - markus@cvs.openbsd.org 2009/12/11 18:16:33
109 switch from 35 to the more common value of RSA_F4 == (2**16)+1 == 65537
110 for the RSA public exponent; discussed with provos; ok djm@
111 - guenther@cvs.openbsd.org 2009/12/20 07:28:36
113 When passing user-controlled options with arguments to other programs,
114 pass the option and option argument as separate argv entries and
115 not smashed into one (e.g., as -l foo and not -lfoo). Also, always
116 pass a "--" argument to stop option parsing, so that a positional
117 argument that starts with a '-' isn't treated as an option. This
118 fixes some error cases as well as the handling of hostnames and
119 filenames that start with a '-'.
120 Based on a diff by halex@
121 ok halex@ djm@ deraadt@
122 - djm@cvs.openbsd.org 2009/12/20 23:20:40
124 fix an incorrect magic number and typo in PROTOCOL; bz#1688
125 report and fix from ueno AT unixuser.org
126 - stevesk@cvs.openbsd.org 2009/12/25 19:40:21
127 [readconf.c servconf.c misc.h ssh-keyscan.c misc.c]
128 validate routing domain is in range 0-RT_TABLEID_MAX.
129 'Looks right' deraadt@
130 - stevesk@cvs.openbsd.org 2009/12/29 16:38:41
131 [sshd_config.5 readconf.c ssh_config.5 scp.1 servconf.c sftp.1 ssh.1]
132 Rename RDomain config option to RoutingDomain to be more clear and
133 consistent with other options.
134 NOTE: if you currently use RDomain in the ssh client or server config,
135 or ssh/sshd -o, you must update to use RoutingDomain.
139 - (tim) [contrib/cygwin/Makefile] Install ssh-copy-id and ssh-copy-id.1
140 Gzip all man pages. Patch from Corinna Vinschen.
143 - (dtucker) [auth-krb5.c platform.{c,h} openbsd-compat/port-aix.{c,h}]
144 Bug #1583: Use system's kerberos principal name on AIX if it's available.
145 Based on a patch from and tested by Miguel Sanders
148 - (dtucker) Bug #1470: Disable OOM-killing of the listening sshd on Linux,
149 based on a patch from Vaclav Ovsik and Colin Watson. ok djm.
152 - (dtucker) Bug #1160: use pkg-config for opensc config if it's available.
153 Tested by Martin Paljak.
154 - (dtucker) Bug #1677: add conditionals around the source for ssh-askpass.
157 - (tim) [opensshd.init.in] If PidFile is set in sshd_config, use it.
158 Bug 1628. OK dtucker@
161 - (djm) [ssh-rand-helper.c] Print error and usage() when passed command-
162 line arguments as none are supported. Exit when passed unrecognised
163 commandline flags. bz#1568 from gson AT araneus.fi
166 - (djm) [channels.c misc.c misc.h sshd.c] add missing setsockopt() to
167 set IPV6_V6ONLY for local forwarding with GatwayPorts=yes. Unify
168 setting IPV6_V6ONLY behind a new function misc.c:sock_set_v6only()
169 bz#1648, report and fix from jan.kratochvil AT redhat.com
170 - (djm) [contrib/gnome-ssh-askpass2.c] Make askpass dialog desktop-modal.
171 bz#1645, patch from jchadima AT redhat.com
174 - (dtucker) [authfile.c] Fall back to 3DES for the encryption of private
175 keys when built with OpenSSL versions that don't do AES.
178 - (dtucker) [authfile.c] Add OpenSSL compat header so this still builds with
179 older versions of OpenSSL.
182 - (dtucker) OpenBSD CVS Sync
183 - djm@cvs.openbsd.org 2009/10/11 23:03:15
185 mention the host name that we are looking for in check_host_in_hostfile()
186 - sobrado@cvs.openbsd.org 2009/10/17 12:10:39
189 - sobrado@cvs.openbsd.org 2009/10/22 12:35:53
190 [ssh.1 ssh-agent.1 ssh-add.1]
191 use the UNIX-related macros (.At and .Ux) where appropriate.
193 - sobrado@cvs.openbsd.org 2009/10/22 15:02:12
194 [ssh-agent.1 ssh-add.1 ssh.1]
195 write UNIX-domain in a more consistent way; while here, replace a
196 few remaining ".Tn UNIX" macros with ".Ux" ones.
197 pointed out by ratchov@, thanks!
199 - djm@cvs.openbsd.org 2009/10/22 22:26:13
201 switch from 3DES to AES-128 for encryption of passphrase-protected
202 SSH protocol 2 private keys; ok several
203 - djm@cvs.openbsd.org 2009/10/23 01:57:11
205 disallow a hostile server from checking jpake auth by sending an
206 out-of-sequence success message. (doesn't affect code enabled by default)
207 - dtucker@cvs.openbsd.org 2009/10/24 00:48:34
209 ssh-keygen now uses AES-128 for private keys
210 - (dtucker) [mdoc2man.awk] Teach it to understand the .Ux macro.
211 - (dtucker) [session.c openbsd-compat/port-linux.{c,h}] Bug #1637: if selinux
212 is enabled set the security context to "sftpd_t" before running the
213 internal sftp server Based on a patch from jchadima at redhat.
216 - (dtucker) [configure.ac sftp-client.c] Remove the gyrations required for
217 dirent d_type and DTTOIF as we've switched OpenBSD to the more portable
219 - (dtucker) OpenBSD CVS Sync
220 - markus@cvs.openbsd.org 2009/10/08 14:03:41
221 [sshd_config readconf.c ssh_config.5 servconf.c sshd_config.5]
222 disable protocol 1 by default (after a transition period of about 10 years)
224 - jmc@cvs.openbsd.org 2009/10/08 20:42:12
225 [sshd_config.5 ssh_config.5 sshd.8 ssh.1]
226 some tweaks now that protocol 1 is not offered by default; ok markus
227 - dtucker@cvs.openbsd.org 2009/10/11 10:41:26
229 d_type isn't portable so use lstat to get dirent modes. Suggested by and
230 "looks sane" deraadt@
231 - markus@cvs.openbsd.org 2009/10/08 18:04:27
232 [regress/test-exec.sh]
233 re-enable protocol v1 for the tests.
236 - (dtucker) OpenBSD CVS Sync
237 - djm@cvs.openbsd.org 2009/08/12 00:13:00
239 support most of scp(1)'s commandline arguments in sftp(1), as a first
240 step towards making sftp(1) a drop-in replacement for scp(1).
241 One conflicting option (-P) has not been changed, pending further
243 Patch from carlosvsilvapt@gmail.com as part of his work in the
244 Google Summer of Code
245 - jmc@cvs.openbsd.org 2009/08/12 06:31:42
248 - djm@cvs.openbsd.org 2009/08/13 01:11:19
250 Swizzle options: "-P sftp_server_path" moves to "-D sftp_server_path",
251 add "-P port" to match scp(1). Fortunately, the -P option is only really
252 used by our regression scripts.
253 part of larger patch from carlosvsilvapt@gmail.com for his Google Summer
254 of Code work; ok deraadt markus
255 - jmc@cvs.openbsd.org 2009/08/13 13:39:54
257 sync synopsis and usage();
258 - djm@cvs.openbsd.org 2009/08/14 18:17:49
260 make the "get_handle: ..." error messages vaguely useful by allowing
261 callers to specify their own error message strings.
262 - fgsch@cvs.openbsd.org 2009/08/15 18:56:34
264 remove unused define. markus@ ok.
265 (Id sync only, Portable still uses this.)
266 - dtucker@cvs.openbsd.org 2009/08/16 23:29:26
268 Add PubkeyAuthentication to the list allowed in a Match block (bz #1577)
269 - djm@cvs.openbsd.org 2009/08/18 18:36:21
270 [sftp-client.h sftp.1 sftp-client.c sftp.c]
271 recursive transfer support for get/put and on the commandline
272 work mostly by carlosvsilvapt@gmail.com for the Google Summer of Code
273 with some tweaks by me; "go for it" deraadt@
274 - djm@cvs.openbsd.org 2009/08/18 21:15:59
276 fix "get" command usage, spotted by jmc@
277 - jmc@cvs.openbsd.org 2009/08/19 04:56:03
280 - dtucker@cvs.openbsd.org 2009/08/20 23:54:28
282 subsystem_flag is defined in ssh.c so it's extern; ok djm
283 - djm@cvs.openbsd.org 2009/08/27 17:28:52
285 allow setting an explicit umask on the commandline to override whatever
286 default the user has. bz#1229; ok dtucker@ deraadt@ markus@
287 - djm@cvs.openbsd.org 2009/08/27 17:33:49
289 force use of correct hash function for random-art signature display
290 as it was inheriting the wrong one when bubblebabble signatures were
291 activated; bz#1611 report and patch from fwojcik+openssh AT besh.com;
293 - djm@cvs.openbsd.org 2009/08/27 17:43:00
295 allow setting an explicit umask on the commandline to override whatever
296 default the user has. bz#1229; ok dtucker@ deraadt@ markus@
297 - djm@cvs.openbsd.org 2009/08/27 17:44:52
298 [authfd.c ssh-add.c authfd.h]
299 Do not fall back to adding keys without contraints (ssh-add -c / -t ...)
300 when the agent refuses the constrained add request. This was a useful
301 migration measure back in 2002 when constraints were new, but just
303 bz #1612, report and patch from dkg AT fifthhorseman.net; ok markus@
304 - djm@cvs.openbsd.org 2009/08/31 20:56:02
306 check correct variable for error message, spotted by martynas@
307 - djm@cvs.openbsd.org 2009/08/31 21:01:29
309 document -e and -h; prodded by jmc@
310 - djm@cvs.openbsd.org 2009/09/01 14:43:17
312 fix a race condition in ssh-agent that could result in a wedged or
313 spinning agent: don't read off the end of the allocated fd_sets, and
314 don't issue blocking read/write on agent sockets - just fall back to
315 select() on retriable read/write errors. bz#1633 reported and tested
316 by "noodle10000 AT googlemail.com"; ok dtucker@ markus@
317 - grunk@cvs.openbsd.org 2009/10/01 11:37:33
321 - djm@cvs.openbsd.org 2009/10/06 04:46:40
323 bz#1596: fflush(NULL) before exec() to ensure that everying (motd
324 in particular) has made it out before the streams go away.
325 - djm@cvs.openbsd.org 2008/12/07 22:17:48
326 [regress/addrmatch.sh]
327 match string "passwordauthentication" only at start of line, not anywhere
329 - dtucker@cvs.openbsd.org 2009/05/05 07:51:36
330 [regress/multiplex.sh]
331 Always specify ssh_config for multiplex tests: prevents breakage caused
332 by options in ~/.ssh/config. From Dan Peterson.
333 - djm@cvs.openbsd.org 2009/08/13 00:57:17
335 regression test for port number parsing. written as part of the a2port
336 change that went into 5.2 but I forgot to commit it at the time...
337 - djm@cvs.openbsd.org 2009/08/13 01:11:55
338 [regress/sftp-batch.sh regress/sftp-badcmds.sh regress/sftp.sh
339 regress/sftp-cmds.sh regres/sftp-glob.sh]
340 date: 2009/08/13 01:11:19; author: djm; state: Exp; lines: +10 -7
341 Swizzle options: "-P sftp_server_path" moves to "-D sftp_server_path",
342 add "-P port" to match scp(1). Fortunately, the -P option is only really
343 used by our regression scripts.
344 part of larger patch from carlosvsilvapt@gmail.com for his Google Summer
345 of Code work; ok deraadt markus
346 - djm@cvs.openbsd.org 2009/08/20 18:43:07
347 [regress/ssh-com-sftp.sh]
348 fix one sftp -D ... => sftp -P ... conversion that I missed; from Carlos
349 Silva for Google Summer of Code
350 - dtucker@cvs.openbsd.org 2009/10/06 23:51:49
351 [regress/ssh2putty.sh]
352 Add OpenBSD tag to make syncs easier
353 - (dtucker) [regress/portnum.sh] Import new test.
354 - (dtucker) [configure.ac sftp-client.c] DTOTIF is in fs/ffs/dir.h on at
356 - (dtucker) d_type is not mandated by POSIX, so add fallback code using
357 stat(), needed on at least cygwin.
360 - (djm) [Makefile.in] Mention readconf.o in ssh-keysign's make deps.
361 spotted by des AT des.no
364 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
365 [contrib/suse/openssh.spec] Update for release
366 - (djm) [README] update relnotes URL
367 - (djm) [packet.c] Restore EWOULDBLOCK handling that got lost somewhere
368 - (djm) Release 5.3p1
371 - (dtucker) [configure.ac] Change the -lresolv check so it works on Mac OS X
372 10.6 (which doesn't have BIND8_COMPAT and thus uses res_9_query). Patch
373 from jbasney at ncsa uiuc edu.
376 - (djm) [serverloop.c] Fix test for server-assigned remote forwarding port
377 (-R 0:...); bz#1578, spotted and fix by gavin AT emf.net; ok dtucker@
380 - (dtucker) [configure.ac] Bug #1639: use AC_PATH_PROG to search the path for
381 krb5-config if it's not in the location specified by --with-kerberos5.
382 Patch from jchadima at redhat.
385 - (dtucker) [README.platform] Add text about development packages, based on
386 text from Chris Pepper in bug #1631.
389 - dtucker [auth-sia.c] Roll back the change for bug #1241 as it apparently
390 causes problems in some Tru64 configurations.
391 - (djm) [sshd_config.5] downgrade mention of login.conf to be an example
392 and mention PAM as another provider for ChallengeResponseAuthentication;
394 - (djm) [sftp-server.c] bz#1535: accept ENOSYS as a fallback error when
395 attempting atomic rename(); ok dtucker@
396 - (djm) [Makefile.in] bz#1505: Solaris make(1) doesn't accept make variables
397 in argv, so pass them in the environment; ok dtucker@
398 - (dtucker) [channels.c configure.ac] Bug #1528: skip the tcgetattr call on
399 the pty master on Solaris, since it never succeeds and can hang if large
400 amounts of data is sent to the slave (eg a copy-paste). Based on a patch
401 originally from Doke Scott, ok djm@
402 - (dtucker) [clientloop.c configure.ac defines.h] Make the client's IO buffer
403 size a compile-time option and set it to 64k on Cygwin, since Corinna
404 reports that it makes a significant difference to performance. ok djm@
405 - (dtucker) [configure.ac] Fix the syntax of the Solaris tcgetattr entry.
408 - (dtucker) [includes.h] Bug #1634: do not include system glob.h if we're not
409 using it since the type conflicts can cause problems on FreeBSD. Patch
411 - (dtucker) [session.c openbsd-compat/port-aix.h] Bugs #1249 and #1567: move
412 the setpcred call on AIX to immediately before the permanently_set_uid().
413 Ensures that we still have privileges when we call chroot and
414 pam_open_sesson. Based on a patch from David Leonard.
417 - (dtucker) [configure.ac] Check for headers before libraries for openssl an
418 zlib, which should make the errors slightly more meaningful on platforms
419 where there's separate "-devel" packages for those.
420 - (dtucker) [sshlogin.c openbsd-compat/port-aix.{c,h}] Bug #1595: make
421 PrintLastLog work on AIX. Based in part on a patch from Miguel Sanders.
424 - (tim) [contrib/cygwin/ssh-user-config] Change script to call correct error
425 function. Patch from Corinna Vinschen.
428 - (dtucker) [openbsd-compat/getrrsetbyname.c] Reduce answer buffer size so it
429 fits into 16 bits to work around a bug in glibc's resolver where it masks
430 off the buffer size at 16 bits. Patch from Hauke Lampe, ok djm jakob.
433 - (dtucker) [configure.ac] Include sys/param.h for the sys/mount.h test,
434 prevents configure complaining on older BSDs.
435 - (dtucker [contrib/cygwin/ssh-{host,user}-config] Add license text. Patch
436 from Corinna Vinschen.
437 - (dtucker) [auth-pam.c] Bug #1534: move the deletion of PAM credentials on
438 logout to after the session close. Patch from Anicka Bernathova,
439 originally from Andreas Schwab via Novelll ok djm.
442 - (dtucker) [contrib/cygwin/ssh-host-config] better support for automated
443 scripts and fix usage of eval. Patch from Corinna Vinschen.
446 - (dtucker) OpenBSD CVS Sync
447 - andreas@cvs.openbsd.org 2009/06/27 09:29:06
449 packet_bacup_state() and packet_restore_state() will be used to
450 temporarily save the current state ren resuming a suspended connection.
452 - andreas@cvs.openbsd.org 2009/06/27 09:32:43
453 [roaming_common.c roaming.h]
454 It may be necessary to retransmit some data when resuming, so add it
455 to a buffer when roaming is enabled.
456 Most of this code was written by Martin Forssen, maf at appgate dot com.
458 - andreas@cvs.openbsd.org 2009/06/27 09:35:06
459 [readconf.h readconf.c]
460 Add client option UseRoaming. It doesn't do anything yet but will
461 control whether the client tries to use roaming if enabled on the
462 server. From Martin Forssen.
464 - markus@cvs.openbsd.org 2009/06/30 14:54:40
466 crank version; ok deraadt
467 - dtucker@cvs.openbsd.org 2009/07/02 02:11:47
469 allow for long home dir paths (bz #1615). ok deraadt
470 (based in part on a patch from jchadima at redhat)
471 - stevesk@cvs.openbsd.org 2009/07/05 19:28:33
473 only send SSH2_MSG_DISCONNECT if we're in compat20; from dtucker@
477 - (dtucker) OpenBSD CVS Sync
478 - dtucker@cvs.openbsd.org 2009/06/22 05:39:28
479 [monitor_wrap.c monitor_mm.c ssh-keygen.c auth2.c gss-genr.c sftp-client.c]
480 alphabetize includes; reduces diff vs portable and style(9).
482 (Id sync only; these were already in order in -portable)
485 - (dtucker) OpenBSD CVS Sync
486 - markus@cvs.openbsd.org 2009/03/17 21:37:00
488 pass correct argv[0] to openlog(); ok djm@
489 - jmc@cvs.openbsd.org 2009/03/19 15:15:09
491 for "Ciphers", just point the reader to the keyword in ssh_config(5), just
492 as we do for "MACs": this stops us getting out of sync when the lists
494 fixes documentation/6102, submitted by Peter J. Philipp
495 alternative fix proposed by djm
497 - tobias@cvs.openbsd.org 2009/03/23 08:31:19
499 Fixed a possible out-of-bounds memory access if the environment variable
500 SHELL is shorter than 3 characters.
501 with input by and ok dtucker
502 - tobias@cvs.openbsd.org 2009/03/23 19:38:04
504 My previous commit didn't fix the problem at all, so stick at my first
505 version of the fix presented to dtucker.
506 Issue notified by Matthias Barkhoff (matthias dot barkhoff at gmx dot de).
508 - sobrado@cvs.openbsd.org 2009/03/26 08:38:39
509 [sftp-server.8 sshd.8 ssh-agent.1]
510 fix a few typographical errors found by spell(1).
512 - stevesk@cvs.openbsd.org 2009/04/13 19:07:44
514 fix possessive; ok djm@
515 - stevesk@cvs.openbsd.org 2009/04/14 16:33:42
517 remove unused option character from getopt() optstring; ok markus@
518 - jj@cvs.openbsd.org 2009/04/14 21:10:54
520 Fixed a few the-the misspellings in comments. Skipped a bunch in
521 binutils,gcc and so on. ok jmc@
522 - stevesk@cvs.openbsd.org 2009/04/17 19:23:06
524 use INTERNAL_SFTP_NAME for setproctitle() of in-process sftp-server;
526 - stevesk@cvs.openbsd.org 2009/04/17 19:40:17
528 clarify that even internal-sftp needs /dev/log for logging to work; ok
530 - jmc@cvs.openbsd.org 2009/04/18 18:39:10
532 tweak previous; ok stevesk
533 - stevesk@cvs.openbsd.org 2009/04/21 15:13:17
535 clarify we cd to user's home after chroot; ok markus@ on
536 earlier version; tweaks and ok jmc@
537 - andreas@cvs.openbsd.org 2009/05/25 06:48:01
538 [channels.c packet.c clientloop.c packet.h serverloop.c monitor_wrap.c
540 Put the globals in packet.c into a struct and don't access it directly
541 from other files. No functional changes.
543 - andreas@cvs.openbsd.org 2009/05/27 06:31:25
544 [canohost.h canohost.c]
545 Add clear_cached_addr(), needed for upcoming changes allowing the peer
548 - andreas@cvs.openbsd.org 2009/05/27 06:33:39
550 Send SSH2_MSG_DISCONNECT when the client disconnects. From a larger
551 change from Martin Forssen, maf at appgate dot com.
553 - andreas@cvs.openbsd.org 2009/05/27 06:34:36
555 Move the KEX_COOKIE_LEN define to kex.h
557 - andreas@cvs.openbsd.org 2009/05/27 06:36:07
559 Add packet_put_int64() and packet_get_int64(), part of a larger change
562 - andreas@cvs.openbsd.org 2009/05/27 06:38:16
563 [sshconnect.h sshconnect.c]
564 Un-static ssh_exchange_identification(), part of a larger change from
565 Martin Forssen and needed for upcoming changes.
567 - andreas@cvs.openbsd.org 2009/05/28 16:50:16
568 [sshd.c packet.c serverloop.c monitor_wrap.c clientloop.c sshconnect.c
569 monitor.c Added roaming.h roaming_common.c roaming_dummy.c]
570 Keep track of number of bytes read and written. Needed for upcoming
571 changes. Most code from Martin Forssen, maf at appgate dot com.
573 Also, applied appropriate changes to Makefile.in
574 - andreas@cvs.openbsd.org 2009/06/12 20:43:22
576 Fix warnings found by chl@ and djm@ and change roaming_atomicio's
577 return type to match atomicio's
578 Diff from djm@, ok markus@
579 - andreas@cvs.openbsd.org 2009/06/12 20:58:32
581 Move some more statics into session_state
583 - dtucker@cvs.openbsd.org 2009/06/21 07:37:15
585 abort if key_sign fails, preventing possible null deref. Based on report
586 from Paolo Ganci, ok markus@ djm@
587 - dtucker@cvs.openbsd.org 2009/06/21 09:04:03
588 [roaming.h roaming_common.c roaming_dummy.c]
589 Add tags for the benefit of the sync scripts
590 Also: pull in the changes for 1.1->1.2 missed in the previous sync.
591 - (dtucker) [auth2-jpake.c auth2.c canohost.h session.c] Whitespace and
592 header-order changes to reduce diff vs OpenBSD.
593 - (dtucker) [servconf.c sshd.c] More whitespace sync.
594 - (dtucker) [roaming_common.c roaming_dummy.c] Wrap #include <inttypes.h> in
598 - (dtucker) [configure.ac defines.h] Bug #1607: handle the case where fsid_t
599 is a struct with a __val member. Fixes build on, eg, Redhat 6.2.
602 - (dtucker) [sshlogin.c] Move the NO_SSH_LASTLOG #ifndef line to include
603 variable declarations. Should prevent unused warnings anywhere it's set
604 (only Crays as far as I can tell) and be a no-op everywhere else.
607 - (tim) [configure.ac] Remove setting IP_TOS_IS_BROKEN for Cygwin. The problem
608 that setsockopt(IP_TOS) doesn't work on Cygwin has been fixed since 2005.
609 Based on patch from vinschen at redhat com.
612 - (dtucker) [auth-passwd.c auth1.c auth2-kbdint.c auth2-none.c auth2-passwd.c
613 auth2-pubkey.c session.c openbsd-compat/bsd-cygwin_util.{c,h}
614 openbsd-compat/daemon.c] Remove support for Windows 95/98/ME and very old
615 version of Cygwin. Patch from vinschen at redhat com.
618 - (dtucker) [contrib/aix/buildbff.sh] Only try to rename ssh_prng_cmds if it
619 exists (it's not created if OpenSSL's PRNG is self-seeded, eg if the OS
621 - (dtucker) [schnorr.c openbsd-compat/openssl-compat.{c,h}] Add
622 EVP_DigestUpdate to the OLD_EVP compatibility functions and tell schnorr.c
623 to use them. Allows building with older OpenSSL versions.
624 - (dtucker) [configure.ac defines.h] Check for in_port_t and typedef if needed.
625 - (dtucker) [configure.ac] Missing comma in type list.
626 - (dtucker) [configure.ac openbsd-compat/openssl-compat.{c,h}]
627 EVP_DigestUpdate does not exactly match the other OLD_EVP functions (eg
628 in openssl 0.9.6) so add an explicit test for it.
631 - (djm) OpenBSD CVS Sync
632 - djm@cvs.openbsd.org 2009/03/05 07:18:19
633 [auth2-jpake.c jpake.c jpake.h monitor_wrap.c monitor_wrap.h schnorr.c]
635 refactor the (disabled) Schnorr proof code to make it a little more
637 - djm@cvs.openbsd.org 2009/03/05 11:30:50
639 document what these functions do so I don't ever have to recuse into
640 b64_pton/ntop to remember their return values
643 - (djm) OpenBSD CVS Sync
644 - djm@cvs.openbsd.org 2009/02/22 23:50:57
645 [ssh_config.5 sshd_config.5]
646 don't advertise experimental options
647 - djm@cvs.openbsd.org 2009/02/22 23:59:25
650 - djm@cvs.openbsd.org 2009/02/23 00:06:15
653 - (djm) [README] update for 5.2
654 - (djm) Release openssh-5.2p1
657 - (djm) OpenBSD CVS Sync
658 - tobias@cvs.openbsd.org 2009/02/21 19:32:04
659 [misc.c sftp-server-main.c ssh-keygen.c]
660 Added missing newlines in error messages.
664 - (djm) OpenBSD CVS Sync
665 - djm@cvs.openbsd.org 2009/02/17 01:28:32
667 sync with revised default ciphers; pointed out by dkrause@
668 - djm@cvs.openbsd.org 2009/02/18 04:31:21
670 signature should hash over the entire group, not just the generator
671 (this is still disabled code)
672 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
673 [contrib/suse/openssh.spec] Prepare for 5.2p1
676 - (djm) [regress/conch-ciphers.sh regress/putty-ciphers.sh]
677 [regress/putty-kex.sh regress/putty-transfer.sh] Downgrade disabled
678 interop tests from FATAL error to a warning. Allows some interop
679 tests to proceed if others are missing necessary prerequisites.
680 - (djm) [configure.ac] support GNU/kFreeBSD and GNU/kOpensolaris
681 systems; patch from Aurelien Jarno via rmh AT aybabtu.com
684 - (djm) OpenBSD CVS Sync
685 - dtucker@cvs.openbsd.org 2009/02/02 11:15:14
687 Initialize a few variables to prevent spurious "may be used
688 uninitialized" warnings from newer gcc's. ok djm@
689 - djm@cvs.openbsd.org 2009/02/12 03:00:56
690 [canohost.c canohost.h channels.c channels.h clientloop.c readconf.c]
691 [readconf.h serverloop.c ssh.c]
692 support remote port forwarding with a zero listen port (-R0:...) to
693 dyamically allocate a listen port at runtime (this is actually
694 specified in rfc4254); bz#1003 ok markus@
695 - djm@cvs.openbsd.org 2009/02/12 03:16:01
697 tighten check for -R0:... forwarding: only allow dynamic allocation
698 if want_reply is set in the packet
699 - djm@cvs.openbsd.org 2009/02/12 03:26:22
701 some paranoia: check that the serialised key is really KEY_RSA before
702 diddling its internals
703 - djm@cvs.openbsd.org 2009/02/12 03:42:09
705 document -R0:... usage
706 - djm@cvs.openbsd.org 2009/02/12 03:44:25
708 consistency: Dq => Ql
709 - djm@cvs.openbsd.org 2009/02/12 03:46:17
711 document RemoteForward usage with 0 listen port
712 - jmc@cvs.openbsd.org 2009/02/12 07:34:20
714 kill trailing whitespace;
715 - markus@cvs.openbsd.org 2009/02/13 11:50:21
717 check for enc !=NULL in packet_start_discard
718 - djm@cvs.openbsd.org 2009/02/14 06:35:49
720 mention that eow and no-more-sessions extensions are sent only to
724 - (djm) [sshpty.c] bz#1419: OSX uses cloning ptys that automagically
725 set ownership and modes, so avoid explicitly setting them
726 - (djm) [configure.ac loginrec.c] bz#1421: fix lastlog support for OSX.
727 OSX provides a getlastlogxbyname function that automates the reading of
728 a lastlog file. Also, the pututxline function will update lastlog so
729 there is no need for loginrec.c to do it explicitly. Collapse some
730 overly verbose code while I'm in there.
733 - (dtucker) [defines.h sshconnect.c] INET6_ADDRSTRLEN is now needed in
734 channels.c too, so move the definition for non-IP6 platforms to defines.h
735 where it can be shared.
738 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
739 If the CYGWIN environment variable is empty, the installer script
740 should not install the service with an empty CYGWIN variable, but
741 rather without setting CYGWNI entirely.
742 - (tim) [contrib/cygwin/ssh-host-config] Whitespace cleanup. No code changes.
745 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
746 Changes to work on Cygwin 1.5.x as well as on the new Cygwin 1.7.x.
747 The information given for the setting of the CYGWIN environment variable
748 is wrong for both releases so I just removed it, together with the
749 unnecessary (Cygwin 1.5.x) or wrong (Cygwin 1.7.x) default setting.
752 - (djm) OpenBSD CVS Sync
753 - stevesk@cvs.openbsd.org 2008/12/09 03:20:42
754 [channels.c servconf.c]
755 channel_print_adm_permitted_opens() should deal with all the printing
756 for that config option. suggested by markus@; ok markus@ djm@
758 - djm@cvs.openbsd.org 2008/12/09 04:32:22
760 replace by-hand string building with xasprinf(); ok deraadt@
761 - sobrado@cvs.openbsd.org 2008/12/09 15:35:00
763 update for the synopses displayed by the 'help' command, there are a
764 few missing flags; add 'bye' to the output of 'help'; sorting and spacing.
765 jmc@ suggested replacing .Oo/.Oc with a single .Op macro.
767 - stevesk@cvs.openbsd.org 2008/12/09 22:37:33
769 fix typo in error message
770 - stevesk@cvs.openbsd.org 2008/12/10 03:55:20
772 o cannot be NULL here but use xfree() to be consistent; ok djm@
773 - stevesk@cvs.openbsd.org 2008/12/29 01:12:36
775 fix example, default key type is rsa for 3+ years; from
776 frederic.perrin@resel.fr
777 - stevesk@cvs.openbsd.org 2008/12/29 02:23:26
779 no need to escape single quotes in comments
780 - okan@cvs.openbsd.org 2008/12/30 00:46:56
782 add AllowAgentForwarding to available Match keywords list
784 - djm@cvs.openbsd.org 2009/01/01 21:14:35
786 call channel destroy callbacks on receipt of open failure messages.
787 fixes client hangs when connecting to a server that has MaxSessions=0
788 set spotted by imorgan AT nas.nasa.gov; ok markus@
789 - djm@cvs.openbsd.org 2009/01/01 21:17:36
791 fix hash calculation for KEXGEX: hash over the original client-supplied
792 values and not the sanity checked versions that we acutally use;
793 bz#1540 reported by john.smith AT arrows.demon.co.uk
795 - djm@cvs.openbsd.org 2009/01/14 01:38:06
797 support SOCKS4A protocol, from dwmw2 AT infradead.org via bz#1482;
799 - stevesk@cvs.openbsd.org 2009/01/15 17:38:43
801 1) use obsolete instead of alias for consistency
802 2) oUserKnownHostsFile not obsolete but oGlobalKnownHostsFile2 is
804 3) reorder so like options are together
806 - djm@cvs.openbsd.org 2009/01/22 09:46:01
807 [channels.c channels.h session.c]
808 make Channel->path an allocated string, saving a few bytes here and
809 there and fixing bz#1380 in the process; ok markus@
810 - djm@cvs.openbsd.org 2009/01/22 09:49:57
812 oops! I committed the wrong version of the Channel->path diff,
813 it was missing some tweaks suggested by stevesk@
814 - djm@cvs.openbsd.org 2009/01/22 10:02:34
815 [clientloop.c misc.c readconf.c readconf.h servconf.c servconf.h]
816 [serverloop.c ssh-keyscan.c ssh.c sshd.c]
817 make a2port() return -1 when it encounters an invalid port number
818 rather than 0, which it will now treat as valid (needed for future work)
819 adjust current consumers of a2port() to check its return value is <= 0,
820 which in turn required some things to be converted from u_short => int
821 make use of int vs. u_short consistent in some other places too
822 feedback & ok markus@
823 - djm@cvs.openbsd.org 2009/01/22 10:09:16
825 another chunk of a2port() diff that got away. wtfdjm??
826 - djm@cvs.openbsd.org 2009/01/23 07:58:11
828 prefer CTR modes and revised arcfour (i.e w/ discard) modes to CBC
830 - naddy@cvs.openbsd.org 2009/01/24 17:10:22
831 [ssh_config.5 sshd_config.5]
832 sync list of preferred ciphers; ok djm@
833 - markus@cvs.openbsd.org 2009/01/26 09:58:15
834 [cipher.c cipher.h packet.c]
835 Work around the CPNI-957037 Plaintext Recovery Attack by always
836 reading 256K of data on packet size or HMAC errors (in CBC mode only).
837 Help, feedback and ok djm@
838 Feedback from Martin Albrecht and Paterson Kenny
841 - (djm) [uidswap.c] bz#1412: Support >16 supplemental groups in OS X.
842 Patch based on one from vgiffin AT apple.com; ok dtucker@
843 - (djm) [channels.c] bz#1419: support "on demand" X11 forwarding via
844 launchd on OS X; patch from vgiffin AT apple.com, slightly tweaked;
846 - (djm) [contrib/ssh-copy-id.1 contrib/ssh-copy-id] bz#1492: Make
847 ssh-copy-id copy id_rsa.pub by default (instead of the legacy "identity"
848 key). Patch from cjwatson AT debian.org
851 - (tim) [configure.ac defines.h openbsd-compat/port-uw.c
852 openbsd-compat/xcrypt.c] Add SECUREWARE support to OpenServer 6 SVR5 ABI.
854 - (tim) [configure.ac] Move check_for_libcrypt_later=1 in *-*-sysv5*) section.
855 OpenServer 6 doesn't need libcrypt.
858 - (djm) OpenBSD CVS Sync
859 - djm@cvs.openbsd.org 2008/12/09 02:38:18
861 The ~C escape handler does not work correctly for multiplexed sessions -
862 it opens a commandline on the master session, instead of on the slave
863 that requested it. Disable it on slave sessions until such time as it
864 is fixed; bz#1543 report from Adrian Bridgett via Colin Watson
866 - djm@cvs.openbsd.org 2008/12/09 02:39:59
868 Deal correctly with failures in remote stat() operation in sftp,
869 correcting fail-on-error behaviour in batchmode. bz#1541 report and
870 fix from anedvedicky AT gmail.com; ok markus@
871 - djm@cvs.openbsd.org 2008/12/09 02:58:16
873 don't leave junk (free'd) pointers around in Forward *fwd argument on
874 failure; avoids double-free in ~C -L handler when given an invalid
875 forwarding specification; bz#1539 report from adejong AT debian.org
876 via Colin Watson; ok markus@ dtucker@
877 - djm@cvs.openbsd.org 2008/12/09 03:02:37
879 correct sftp(1) and corresponding usage syntax;
880 bz#1518 patch from imorgan AT nas.nasa.gov; ok deraadt@ improved diff jmc@
883 - (djm) [configure.ac] bz#1538: better test for ProPolice/SSP: actually
884 use some stack in main().
885 Report and suggested fix from vapier AT gentoo.org
886 - (djm) OpenBSD CVS Sync
887 - markus@cvs.openbsd.org 2008/12/02 19:01:07
889 we have to use the recipient's channel number (RFC 4254) for
890 SSH2_MSG_CHANNEL_SUCCESS/SSH2_MSG_CHANNEL_FAILURE messages,
891 otherwise we trigger 'Non-public channel' error messages on sshd
892 systems with clientkeepalive enabled; noticed by sturm; ok djm;
893 - markus@cvs.openbsd.org 2008/12/02 19:08:59
895 backout 1.149, since it's not necessary and openssh clients send
896 broken CHANNEL_FAILURE/SUCCESS messages since about 2004; ok djm@
897 - markus@cvs.openbsd.org 2008/12/02 19:09:38
899 s/remote_id/id/ to be more consistent with other code; ok djm@
902 - (dtucker) [contrib/cygwin/{Makefile,ssh-host-config}] Add new doc files
903 and tweak the is-sshd-running check in ssh-host-config. Patch from
904 vinschen at redhat com.
905 - (dtucker) OpenBSD CVS Sync
906 - markus@cvs.openbsd.org 2008/11/21 15:47:38
908 packet_disconnect() on padding error, too. should reduce the success
909 probability for the CPNI-957037 Plaintext Recovery Attack to 2^-18
911 - dtucker@cvs.openbsd.org 2008/11/30 11:59:26
913 Retry sendmsg/recvmsg on EAGAIN and EINTR; ok djm@
916 - (dtucker) [monitor_fdpass.c] Reduce diff vs OpenBSD by moving some
917 declarations, removing an unnecessary union member and adding whitespace.
918 cmsgbuf.tmp thing spotted by des at des no, ok djm some time ago.
921 - (tim) [addrmatch.c configure.ac] Some platforms do not have sin6_scope_id
922 member of sockaddr_in6. Also reported in Bug 1491 by David Leonard. OK and
926 - (dtucker) OpenBSD CVS Sync
927 - jmc@cvs.openbsd.org 2008/11/05 11:22:54
930 fixes user/5975 from Rene Maroufi
931 - stevesk@cvs.openbsd.org 2008/11/07 00:42:12
933 spelling/typo in comment
934 - stevesk@cvs.openbsd.org 2008/11/07 18:50:18
936 add space to some log/debug messages for readability; ok djm@ markus@
937 - dtucker@cvs.openbsd.org 2008/11/07 23:34:48
939 Move JPAKE define to make life easier for portable. ok djm@
940 - tobias@cvs.openbsd.org 2008/11/09 12:34:47
942 typo fixed (overriden -> overridden)
944 - stevesk@cvs.openbsd.org 2008/11/11 02:58:09
946 USE_AFS not referenced so remove #ifdef. fixes sshd -T not printing
947 kerberosgetafstoken. ok dtucker@
948 (Id sync only, we still want the ifdef in portable)
949 - stevesk@cvs.openbsd.org 2008/11/11 03:55:11
951 for sshd -T print 'permitopen any' vs. 'permitopen' for case of no
952 permitopen's; ok and input dtucker@
953 - djm@cvs.openbsd.org 2008/11/10 02:06:35
954 [regress/putty-ciphers.sh]
955 PuTTY supports AES CTR modes, so interop test against them too
959 - djm@cvs.openbsd.org 2008/11/03 08:59:41
961 include MaxSessions in sshd -T output; patch from imorgan AT nas.nasa.gov
962 - djm@cvs.openbsd.org 2008/11/04 07:58:09
964 need unistd.h for close() prototype
966 - djm@cvs.openbsd.org 2008/11/04 08:22:13
967 [auth.h auth2.c monitor.c monitor.h monitor_wrap.c monitor_wrap.h]
968 [readconf.c readconf.h servconf.c servconf.h ssh2.h ssh_config.5]
969 [sshconnect2.c sshd_config.5 jpake.c jpake.h schnorr.c auth2-jpake.c]
971 Add support for an experimental zero-knowledge password authentication
972 method using the J-PAKE protocol described in F. Hao, P. Ryan,
973 "Password Authenticated Key Exchange by Juggling", 16th Workshop on
974 Security Protocols, Cambridge, April 2008.
976 This method allows password-based authentication without exposing
977 the password to the server. Instead, the client and server exchange
978 cryptographic proofs to demonstrate of knowledge of the password while
979 revealing nothing useful to an attacker or compromised endpoint.
981 This is experimental, work-in-progress code and is presently
982 compiled-time disabled (turn on -DJPAKE in Makefile.inc).
984 "just commit it. It isn't too intrusive." deraadt@
985 - stevesk@cvs.openbsd.org 2008/11/04 19:18:00
987 because parse_forward() is now used to parse all forward types (DLR),
988 and it malloc's space for host variables, we don't need to malloc
989 here. fixes small memory leaks.
991 previously dynamic forwards were not parsed in parse_forward() and
992 space was not malloc'd in that case.
995 - stevesk@cvs.openbsd.org 2008/11/05 03:23:09
997 add dynamic forward escape command line; ok djm@
1001 - sthen@cvs.openbsd.org 2008/07/24 23:55:30
1003 Add "ssh-keygen -F -l" to synopsis (displays fingerprint from
1004 known_hosts). ok djm@
1005 - grunk@cvs.openbsd.org 2008/07/25 06:56:35
1007 Add VisualHostKey to example file, ok djm@
1008 - grunk@cvs.openbsd.org 2008/07/25 07:05:16
1010 In random art visualization, make sure to use the end marker only at the
1011 end. Initial diff by Dirk Loss, tweaks and ok djm@
1012 - markus@cvs.openbsd.org 2008/07/31 14:48:28
1014 don't allocate space for empty banners; report t8m at centrum.cz;
1016 - krw@cvs.openbsd.org 2008/08/02 04:29:51
1018 whitepsace -> whitespace. From Matthew Clarke via bugs@.
1019 - djm@cvs.openbsd.org 2008/08/21 04:09:57
1021 allow ForceCommand internal-sftp with arguments. based on patch from
1022 michael.barabanov AT gmail.com; ok markus@
1023 - djm@cvs.openbsd.org 2008/09/06 12:24:13
1025 OpenSSL 0.9.8h supplies a real EVP_sha256 so we do not need our
1027 (ID sync only for portable - we still need this)
1028 - markus@cvs.openbsd.org 2008/09/11 14:22:37
1029 [compat.c compat.h nchan.c ssh.c]
1030 only send eow and no-more-sessions requests to openssh 5 and newer;
1031 fixes interop problems with broken ssh v2 implementations; ok djm@
1032 - millert@cvs.openbsd.org 2008/10/02 14:39:35
1034 Convert an unchecked strdup to xstrdup. OK deraadt@
1035 - jmc@cvs.openbsd.org 2008/10/03 13:08:12
1037 do not give an example of how to chmod files: we can presume the user
1038 knows that. removes an ambiguity in the permission of authorized_keys;
1040 - deraadt@cvs.openbsd.org 2008/10/03 23:56:28
1042 Repair strnvis() buffersize of 4*n+1, with termination gauranteed by the
1044 spotted by des@freebsd, who commited an incorrect fix to the freebsd tree
1045 and (as is fairly typical) did not report the problem to us. But this fix
1048 - djm@cvs.openbsd.org 2008/10/08 23:34:03
1050 Add -y option to force logging via syslog rather than stderr.
1051 Useful for daemonised ssh connection (ssh -f). Patch originally from
1053 - djm@cvs.openbsd.org 2008/10/09 03:50:54
1054 [servconf.c sshd_config.5]
1055 support setting PermitEmptyPasswords in a Match block
1056 requested in PR3891; ok dtucker@
1057 - jmc@cvs.openbsd.org 2008/10/09 06:54:22
1060 - stevesk@cvs.openbsd.org 2008/10/10 04:55:16
1062 spelling in comment; ok djm@
1063 - stevesk@cvs.openbsd.org 2008/10/10 05:00:12
1065 typo in error message; ok djm@
1066 - stevesk@cvs.openbsd.org 2008/10/10 16:43:27
1068 use 'Privileged ports can be forwarded only when logging in as root on
1069 the remote machine.' for RemoteForward just like ssh.1 -R.
1071 - stevesk@cvs.openbsd.org 2008/10/14 18:11:33
1073 use #define ROQUIET here; no binary change. ok dtucker@
1074 - stevesk@cvs.openbsd.org 2008/10/17 18:36:24
1076 correct and clarify VisualHostKey; ok jmc@
1077 - stevesk@cvs.openbsd.org 2008/10/30 19:31:16
1078 [clientloop.c sshd.c]
1079 don't need to #include "monitor_fdpass.h"
1080 - stevesk@cvs.openbsd.org 2008/10/31 15:05:34
1082 remove unused #define DISPATCH_MIN; ok markus@
1083 - djm@cvs.openbsd.org 2008/11/01 04:50:08
1085 sprinkle ARGSUSED on dispatch handlers
1086 nuke stale unusued prototype
1087 - stevesk@cvs.openbsd.org 2008/11/01 06:43:33
1089 fix some typos in log messages; ok djm@
1090 - sobrado@cvs.openbsd.org 2008/11/01 11:14:36
1091 [ssh-keyscan.1 ssh-keyscan.c]
1092 the ellipsis is not an optional argument; while here, improve spacing.
1093 - stevesk@cvs.openbsd.org 2008/11/01 17:40:33
1094 [clientloop.c readconf.c readconf.h ssh.c]
1095 merge dynamic forward parsing into parse_forward();
1096 'i think this is OK' djm@
1097 - stevesk@cvs.openbsd.org 2008/11/02 00:16:16
1099 protocol 2 tty modes support is now 7.5 years old so remove these
1100 debug3()s; ok deraadt@
1101 - stevesk@cvs.openbsd.org 2008/11/03 01:07:02
1103 remove valueless comment
1104 - stevesk@cvs.openbsd.org 2008/11/03 02:44:41
1107 - (djm) [contrib/caldera/ssh-host-keygen contrib/suse/rc.sshd]
1108 Make example scripts generate keys with default sizes rather than fixed,
1109 non-default 1024 bits; patch from imorgan AT nas.nasa.gov
1110 - (djm) [contrib/sshd.pam.generic contrib/caldera/sshd.pam]
1111 [contrib/redhat/sshd.pam] Move pam_nologin to account group from
1112 incorrect auth group in example files;
1113 patch from imorgan AT nas.nasa.gov
1116 - (dtucker) [config.guess config.sub] Update to latest versions from
1117 http://git.savannah.gnu.org/gitweb/ (2008-04-14 and 2008-06-16
1121 - (dtucker) [openbsd-compat/bsd-poll.c] correctly check for number of FDs
1122 larger than FD_SETSIZE (OpenSSH only ever uses poll with one fd). Patch
1123 from Nicholas Marriott.
1126 - (djm) OpenBSD CVS Sync
1127 - djm@cvs.openbsd.org 2008/07/23 07:36:55
1129 do not try to print options that have been compile-time disabled
1130 in config test mode (sshd -T); report from nix-corp AT esperi.org.uk
1132 - (djm) [servconf.c] Print UsePAM option in config test mode (when it
1133 has been compiled in); report from nix-corp AT esperi.org.uk
1137 - (djm) OpenBSD CVS Sync
1138 - jmc@cvs.openbsd.org 2008/07/18 22:51:01
1140 no need for .Pp before or after .Sh;
1141 - djm@cvs.openbsd.org 2008/07/21 08:19:07
1144 - (djm) [README contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
1145 [contrib/suse/openssh.spec] Update version number in README and RPM specs
1146 - (djm) Release OpenSSH-5.1
1149 - (djm) OpenBSD CVS Sync
1150 - djm@cvs.openbsd.org 2008/07/17 08:48:00
1152 strnvis preauth banner; pointed out by mpf@ ok markus@
1153 - djm@cvs.openbsd.org 2008/07/17 08:51:07
1155 strip trailing '.' from hostname when HostbasedUsesNameFromPacketOnly=yes
1156 report and patch from res AT qoxp.net (bz#1200); ok markus@
1157 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Remove long-unneeded compat
1158 code, replace with equivalent cygwin library call. Patch from vinschen
1159 at redhat.com, ok djm@.
1160 - (djm) [sshconnect2.c] vis.h isn't available everywhere
1164 - djm@cvs.openbsd.org 2008/07/15 02:23:14
1166 number of pipelined requests is now 64;
1167 prodded by Iain.Morgan AT nasa.gov
1168 - djm@cvs.openbsd.org 2008/07/16 11:51:14
1170 rename variable first_gc -> last_gc (since it is actually the last
1172 - djm@cvs.openbsd.org 2008/07/16 11:52:19
1174 this loop index should be automatic, not static
1177 - (djm) OpenBSD CVS Sync
1178 - sthen@cvs.openbsd.org 2008/07/13 21:22:52
1180 Change "ssh-keygen -F [host] -l" to not display random art unless
1181 -v is also specified, making it consistent with the manual and other
1184 - djm@cvs.openbsd.org 2008/07/13 22:13:07
1186 use struct sockaddr_storage instead of struct sockaddr for accept(2)
1187 address argument. from visibilis AT yahoo.com in bz#1485; ok markus@
1188 - djm@cvs.openbsd.org 2008/07/13 22:16:03
1190 increase number of piplelined requests so they properly fill the
1191 (recently increased) channel window. prompted by rapier AT psc.edu;
1193 - djm@cvs.openbsd.org 2008/07/14 01:55:56
1195 mention requirement for /dev/log inside chroot when using sftp-server
1196 with ChrootDirectory
1197 - (djm) [openbsd-compat/bindresvport.c] Rename variables s/sin/in/ to
1198 avoid clash with sin(3) function; reported by
1199 cristian.ionescu-idbohrn AT axis.com
1200 - (djm) [openbsd-compat/rresvport.c] Add unistd.h for missing close()
1201 prototype; reported by cristian.ionescu-idbohrn AT axis.com
1202 - (djm) [umac.c] Rename variable s/buffer_ptr/bufp/ to avoid clash;
1203 reported by cristian.ionescu-idbohrn AT axis.com
1204 - (djm) [contrib/cygwin/Makefile contrib/cygwin/ssh-host-config]
1205 [contrib/cygwin/ssh-user-config contrib/cygwin/sshd-inetd]
1206 Revamped and simplified Cygwin ssh-host-config script that uses
1207 unified csih configuration tool. Requires recent Cygwin.
1208 Patch from vinschen AT redhat.com
1211 - (djm) OpenBSD CVS Sync
1212 - djm@cvs.openbsd.org 2008/07/12 04:52:50
1214 unbreak; move clearing of cctx struct to before first use
1215 reported by dkrause@
1216 - djm@cvs.openbsd.org 2008/07/12 05:33:41
1218 better description for -i flag:
1219 s/RSA authentication/public key authentication/
1220 - (djm) [openbsd-compat/fake-rfc2553.c openbsd-compat/fake-rfc2553.h]
1221 return EAI_FAMILY when trying to lookup unsupported address family;
1222 from vinschen AT redhat.com
1225 - (djm) OpenBSD CVS Sync
1226 - stevesk@cvs.openbsd.org 2008/07/07 00:31:41
1228 we don't need arg after the debug3() was removed. from lint.
1230 - stevesk@cvs.openbsd.org 2008/07/07 23:32:51
1232 /*NOTREACHED*/ for lint warning:
1233 warning: function key_equal falls off bottom without returning value
1235 - markus@cvs.openbsd.org 2008/07/10 18:05:58
1237 missing bzero; from mickey; ok djm@
1238 - markus@cvs.openbsd.org 2008/07/10 18:08:11
1239 [clientloop.c monitor.c monitor_wrap.c packet.c packet.h sshd.c]
1240 sync v1 and v2 traffic accounting; add it to sshd, too;
1244 - (djm) [Makefile.in] Print "all tests passed" when all regress tests pass
1245 - (djm) [auth1.c] Fix format string vulnerability in protocol 1 PAM
1246 account check failure path. The vulnerable format buffer is supplied
1247 from PAM and should not contain attacker-supplied data.
1248 - (djm) [auth.c] Missing unistd.h for close()
1249 - (djm) [configure.ac] Add -Wformat-security to CFLAGS for gcc 3.x and 4.x
1252 - (djm) [auth.c] Fixed test for locked account on HP/UX with shadowed
1253 passwords disabled. bz#1083 report & patch from senthilkumar_sen AT
1254 hotpop.com, w/ dtucker@
1255 - (djm) [atomicio.c configure.ac] Disable poll() fallback in atomiciov for
1256 Tru64. readv doesn't seem to be a comparable object there.
1257 bz#1386, patch from dtucker@ ok me
1258 - (djm) [Makefile.in] Pass though pass to conch for interop tests
1259 - (djm) [configure.ac] unbreak: remove extra closing brace
1260 - (djm) OpenBSD CVS Sync
1261 - djm@cvs.openbsd.org 2008/07/04 23:08:25
1263 handle EINTR in packet_write_poll()l ok dtucker@
1264 - djm@cvs.openbsd.org 2008/07/04 23:30:16
1266 Make protocol 1 MaxAuthTries logic match protocol 2's.
1267 Do not treat the first protocol 2 authentication attempt as
1268 a failure IFF it is for method "none".
1269 Makes MaxAuthTries' user-visible behaviour identical for
1272 - djm@cvs.openbsd.org 2008/07/05 05:16:01
1277 - (dtucker) OpenBSD CVS Sync
1278 - djm@cvs.openbsd.org 2008/07/02 13:30:34
1280 really really remove the freebie "none" auth try for protocol 2
1281 - djm@cvs.openbsd.org 2008/07/02 13:47:39
1283 When forking after authentication ("ssh -f") with ExitOnForwardFailure
1284 enabled, delay the fork until after replies for any -R forwards have
1285 been seen. Allows for robust detection of -R forward failure when
1286 using -f (similar to bz#92); ok dtucker@
1287 - otto@cvs.openbsd.org 2008/07/03 21:46:58
1289 avoid nasty double free; ok dtucker@ djm@
1290 - djm@cvs.openbsd.org 2008/07/04 03:44:59
1291 [servconf.c groupaccess.h groupaccess.c]
1292 support negation of groups in "Match group" block (bz#1315); ok dtucker@
1293 - dtucker@cvs.openbsd.org 2008/07/04 03:47:02
1295 Make debug a little clearer. ok djm@
1296 - djm@cvs.openbsd.org 2008/06/30 08:07:34
1297 [regress/key-options.sh]
1298 shell portability: use "=" instead of "==" in test(1) expressions,
1299 double-quote string with backslash escaped /
1300 - djm@cvs.openbsd.org 2008/06/30 10:31:11
1301 [regress/{putty-transfer,putty-kex,putty-ciphers}.sh]
1302 remove "set -e" left over from debugging
1303 - djm@cvs.openbsd.org 2008/06/30 10:43:03
1304 [regress/conch-ciphers.sh]
1305 explicitly disable conch options that could interfere with the test
1306 - (dtucker) [sftp-server.c] Bug #1447: fall back to racy rename if link
1307 returns EXDEV. Patch from Mike Garrison, ok djm@
1308 - (djm) [atomicio.c channels.c clientloop.c defines.h includes.h]
1309 [packet.c scp.c serverloop.c sftp-client.c ssh-agent.c ssh-keyscan.c]
1310 [sshd.c] Explicitly handle EWOULDBLOCK wherever we handle EAGAIN, on
1311 some platforms (HP nonstop) it is a distinct errno;
1312 bz#1467 reported by sconeu AT yahoo.com; ok dtucker@
1315 - (dtucker) OpenBSD CVS Sync
1316 - djm@cvs.openbsd.org 2008/06/30 08:05:59
1318 typo: s/constraint_date/constraint_data/
1319 - djm@cvs.openbsd.org 2008/06/30 12:15:39
1321 only pass channel requests on session channels through to the session
1322 channel handler, avoiding spurious log messages; ok! markus@
1323 - djm@cvs.openbsd.org 2008/06/30 12:16:02
1325 only send eow@openssh.com notifications for session channels; ok! markus@
1326 - djm@cvs.openbsd.org 2008/06/30 12:18:34
1328 clarify that eow@openssh.com is only sent on session channels
1329 - dtucker@cvs.openbsd.org 2008/07/01 07:20:52
1331 Check ExitOnForwardFailure if forwardings are disabled due to a failed
1332 host key check. ok djm@
1333 - dtucker@cvs.openbsd.org 2008/07/01 07:24:22
1334 [sshconnect.c sshd.c]
1335 Send CR LF during protocol banner exchanges, but only for Protocol 2 only,
1336 in order to comply with RFC 4253. bz #1443, ok djm@
1337 - stevesk@cvs.openbsd.org 2008/07/01 23:12:47
1339 fix some typos; ok djm@
1340 - djm@cvs.openbsd.org 2008/07/02 02:24:18
1341 [sshd_config sshd_config.5 sshd.8 servconf.c]
1342 increase default size of ssh protocol 1 ephemeral key from 768 to 1024
1343 bits; prodded by & ok dtucker@ ok deraadt@
1344 - dtucker@cvs.openbsd.org 2008/07/02 12:03:51
1345 [auth-rsa.c auth.c auth2-pubkey.c auth.h]
1346 Merge duplicate host key file checks, based in part on a patch from Rob
1347 Holland via bz #1348 . Also checks for non-regular files during protocol
1349 - djm@cvs.openbsd.org 2008/07/02 12:36:39
1350 [auth2-none.c auth2.c]
1351 Make protocol 2 MaxAuthTries behaviour a little more sensible:
1352 Check whether client has exceeded MaxAuthTries before running
1353 an authentication method and skip it if they have, previously it
1354 would always allow one try (for "none" auth).
1355 Preincrement failure count before post-auth test - previously this
1356 checked and postincremented, also to allow one "none" try.
1357 Together, these two changes always count the "none" auth method
1358 which could be skipped by a malicious client (e.g. an SSH worm)
1359 to get an extra attempt at a real auth method. They also make
1360 MaxAuthTries=0 a useful way to block users entirely (esp. in a
1361 sshd_config Match block).
1362 Also, move sending of any preauth banner from "none" auth method
1363 to the first call to input_userauth_request(), so worms that skip
1364 the "none" method get to see it too.
1367 - (djm) OpenBSD CVS Sync
1368 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
1369 [regress/Makefile regress/key-options.sh]
1370 Add regress test for key options. ok djm@
1371 - dtucker@cvs.openbsd.org 2008/06/11 23:11:40
1373 Don't run cipher-speed test by default; mistakenly enabled by me
1374 - djm@cvs.openbsd.org 2008/06/28 13:57:25
1375 [regress/Makefile regress/test-exec.sh regress/conch-ciphers.sh]
1376 very basic regress test against Twisted Conch in "make interop"
1377 target (conch is available in ports/devel/py-twisted/conch);
1379 - (djm) [regress/Makefile] search for conch by path, like we do putty
1382 - (djm) OpenBSD CVS Sync
1383 - martynas@cvs.openbsd.org 2008/06/21 07:46:46
1385 use optopt to get invalid flag, instead of return value of getopt,
1386 which is always '?'; ok djm@
1387 - otto@cvs.openbsd.org 2008/06/25 11:13:43
1389 add key length to visual fingerprint; zap magical constants;
1391 - djm@cvs.openbsd.org 2008/06/26 06:10:09
1392 [sftp-client.c sftp-server.c]
1393 allow the sftp chmod(2)-equivalent operation to set set[ug]id/sticky
1394 bits. Note that this only affects explicit setting of modes (e.g. via
1395 sftp(1)'s chmod command) and not file transfers. (bz#1310)
1397 - djm@cvs.openbsd.org 2008/06/26 09:19:40
1398 [dh.c dh.h moduli.c]
1399 when loading moduli from /etc/moduli in sshd(8), check that they
1400 are of the expected "safe prime" structure and have had
1401 appropriate primality tests performed;
1402 feedback and ok dtucker@
1403 - grunk@cvs.openbsd.org 2008/06/26 11:46:31
1404 [readconf.c readconf.h ssh.1 ssh_config.5 sshconnect.c]
1405 Move SSH Fingerprint Visualization away from sharing the config option
1406 CheckHostIP to an own config option named VisualHostKey.
1407 While there, fix the behaviour that ssh would draw a random art picture
1408 on every newly seen host even when the option was not enabled.
1409 prodded by deraadt@, discussions,
1410 help and ok markus@ djm@ dtucker@
1411 - jmc@cvs.openbsd.org 2008/06/26 21:11:46
1413 add VisualHostKey to the list of options listed in -o;
1414 - djm@cvs.openbsd.org 2008/06/28 07:25:07
1417 - djm@cvs.openbsd.org 2008/06/28 13:58:23
1419 refuse to add a key that has unknown constraints specified;
1421 - djm@cvs.openbsd.org 2008/06/28 14:05:15
1423 reset global compat flag after processing a protocol 2 signature
1424 request with the legacy DSA encoding flag set; ok markus
1425 - djm@cvs.openbsd.org 2008/06/28 14:08:30
1426 [PROTOCOL PROTOCOL.agent]
1427 document the protocol used by ssh-agent; "looks ok" markus@
1430 - (djm) [RFC.nroff contrib/cygwin/Makefile contrib/suse/openssh.spec]
1431 RFC.nroff lacks a license, remove it (it is long gone in OpenBSD).
1434 - (djm) [Makefile.in moduli.5] Include moduli(5) manpage from OpenBSD.
1436 - (djm) [ contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
1437 [contrib/suse/openssh.spec] Include moduli.5 in RPM spec files.
1440 - (dtucker) OpenBSD CVS Sync
1441 - dtucker@cvs.openbsd.org 2008/06/16 13:22:53
1442 [session.c channels.c]
1443 Rename the isatty argument to is_tty so we don't shadow
1444 isatty(3). ok markus@
1445 - (dtucker) [channels.c] isatty -> is_tty here too.
1448 - (dtucker) [configure.ac] Enable -fno-builtin-memset when using gcc.
1450 - dtucker@cvs.openbsd.org 2008/06/14 15:49:48
1452 wrap long line at 80 chars
1453 - dtucker@cvs.openbsd.org 2008/06/14 17:07:11
1455 ensure default umask disallows at least group and world write; ok djm@
1456 - djm@cvs.openbsd.org 2008/06/14 18:33:43
1458 suppress the warning message from chdir(homedir) failures
1459 when chrooted (bz#1461); ok dtucker
1460 - dtucker@cvs.openbsd.org 2008/06/14 19:42:10
1462 Mention that scp follows symlinks during -r. bz #1466,
1463 from nectar at apple
1464 - dtucker@cvs.openbsd.org 2008/06/15 16:55:38
1466 MaxSessions is allowed in a Match block too
1467 - dtucker@cvs.openbsd.org 2008/06/15 16:58:40
1468 [servconf.c sshd_config.5]
1469 Allow MaxAuthTries within a Match block. ok djm@
1470 - djm@cvs.openbsd.org 2008/06/15 20:06:26
1471 [channels.c channels.h session.c]
1472 don't call isatty() on a pty master, instead pass a flag down to
1473 channel_set_fds() indicating that te fds refer to a tty. Fixes a
1474 hang on exit on Solaris (bz#1463) in portable but is actually
1475 a generic bug; ok dtucker deraadt markus
1478 - (djm) [openbsd-compat/sigact.c] Avoid NULL derefs in ancient sigaction
1479 replacement code; patch from ighighi AT gmail.com in bz#1240;
1483 - (dtucker) OpenBSD CVS Sync
1484 - deraadt@cvs.openbsd.org 2008/06/13 09:44:36
1486 compile on older gcc; no decl after code
1487 - dtucker@cvs.openbsd.org 2008/06/13 13:56:59
1489 Clear key options in the monitor on failed authentication, prevents
1490 applying additional restrictions to non-pubkey authentications in
1491 the case where pubkey fails but another method subsequently succeeds.
1492 bz #1472, found by Colin Watson, ok markus@ djm@
1493 - dtucker@cvs.openbsd.org 2008/06/13 14:18:51
1494 [auth2-pubkey.c auth-rhosts.c]
1495 Include unistd.h for close(), prevents warnings in -portable
1496 - dtucker@cvs.openbsd.org 2008/06/13 17:21:20
1498 Friendlier error messages for mux fallback. ok djm@
1499 - dtucker@cvs.openbsd.org 2008/06/13 18:55:22
1501 Prevent -Wsign-compare warnings on LP64 systems. bz #1192, ok deraadt@
1502 - grunk@cvs.openbsd.org 2008/06/13 20:13:26
1504 Explain the use of SSH fpr visualization using random art, and cite the
1505 original scientific paper inspiring that technique.
1506 Much help with English and nroff by jmc@, thanks.
1507 - (dtucker) [configure.ac] Bug #1276: avoid linking against libgssapi, which
1508 despite its name doesn't seem to implement all of GSSAPI. Patch from
1509 Jan Engelhardt, sanity checked by Simon Wilkinson.
1512 - (dtucker) OpenBSD CVS Sync
1513 - jmc@cvs.openbsd.org 2008/06/11 07:30:37
1515 kill trailing whitespace;
1516 - grunk@cvs.openbsd.org 2008/06/11 21:01:35
1517 [ssh_config.5 key.h readconf.c readconf.h ssh-keygen.1 ssh-keygen.c key.c
1519 Introduce SSH Fingerprint ASCII Visualization, a technique inspired by the
1520 graphical hash visualization schemes known as "random art", and by
1521 Dan Kaminsky's musings on the subject during a BlackOp talk at the
1523 Scientific publication (original paper):
1524 "Hash Visualization: a New Technique to improve Real-World Security",
1525 Perrig A. and Song D., 1999, International Workshop on Cryptographic
1526 Techniques and E-Commerce (CrypTEC '99)
1527 http://sparrow.ece.cmu.edu/~adrian/projects/validation/validation.pdf
1528 The algorithm used here is a worm crawling over a discrete plane,
1529 leaving a trace (augmenting the field) everywhere it goes.
1530 Movement is taken from dgst_raw 2bit-wise. Bumping into walls
1531 makes the respective movement vector be ignored for this turn,
1532 thus switching to the other color of the chessboard.
1533 Graphs are not unambiguous for now, because circles in graphs can be
1534 walked in either direction.
1535 discussions with several people,
1536 help, corrections and ok markus@ djm@
1537 - grunk@cvs.openbsd.org 2008/06/11 21:38:25
1539 ssh-keygen -lv -f /etc/ssh/ssh_host_rsa_key.pub
1540 would not display you the random art as intended, spotted by canacar@
1541 - grunk@cvs.openbsd.org 2008/06/11 22:20:46
1542 [ssh-keygen.c ssh-keygen.1]
1543 ssh-keygen would write fingerprints to STDOUT, and random art to STDERR,
1544 that is not how it was envisioned.
1545 Also correct manpage saying that -v is needed along with -l for it to work.
1547 - otto@cvs.openbsd.org 2008/06/11 23:02:22
1549 simpler way of computing the augmentations; ok grunk@
1550 - grunk@cvs.openbsd.org 2008/06/11 23:03:56
1552 CheckHostIP set to ``fingerprint'' will display both hex and random art
1554 - grunk@cvs.openbsd.org 2008/06/11 23:51:57
1556 #define statements that are not atoms need braces around them, else they
1557 will cause trouble in some cases.
1558 Also do a computation of -1 once, and not in a loop several times.
1560 - dtucker@cvs.openbsd.org 2008/06/12 00:03:49
1561 [dns.c canohost.c sshconnect.c]
1562 Do not pass "0" strings as ports to getaddrinfo because the lookups
1563 can slow things down and we never use the service info anyway. bz
1564 #859, patch from YOSHIFUJI Hideaki and John Devitofranceschi. ok
1566 djm belives that the reason for the "0" strings is to ensure that
1567 it's not possible to call getaddrinfo with both host and port being
1568 NULL. In the case of canohost.c host is a local array. In the
1569 case of sshconnect.c, it's checked for null immediately before use.
1570 In dns.c it ultimately comes from ssh.c:main() and is guaranteed to
1571 be non-null but it's not obvious, so I added a warning message in
1572 case it is ever passed a null.
1573 - grunk@cvs.openbsd.org 2008/06/12 00:13:55
1575 Make ssh print the random art also when ssh'ing to a host using IP only.
1576 spotted by naddy@, ok and help djm@ dtucker@
1577 - otto@cvs.openbsd.org 2008/06/12 00:13:13
1579 use an odd number of rows and columns and a separate start marker, looks
1581 - djm@cvs.openbsd.org 2008/06/12 03:40:52
1582 [clientloop.h mux.c channels.c clientloop.c channels.h]
1583 Enable ~ escapes for multiplex slave sessions; give each channel
1584 its own escape state and hook the escape filters up to muxed
1586 Mux slaves do not currently support the ~^Z and ~& escapes.
1587 NB. this change cranks the mux protocol version, so a new ssh
1588 mux client will not be able to connect to a running old ssh
1591 - djm@cvs.openbsd.org 2008/06/12 04:06:00
1592 [clientloop.h ssh.c clientloop.c]
1593 maintain an ordered queue of outstanding global requests that we
1594 expect replies to, similar to the per-channel confirmation queue.
1595 Use this queue to verify success or failure for remote forward
1596 establishment in a race free way.
1598 - djm@cvs.openbsd.org 2008/06/12 04:17:47
1600 thall shalt not code past the eightieth column
1601 - djm@cvs.openbsd.org 2008/06/12 04:24:06
1603 thal shalt not code past the eightieth column
1604 - djm@cvs.openbsd.org 2008/06/12 05:15:41
1606 document tun@openssh.com forwarding method
1607 - djm@cvs.openbsd.org 2008/06/12 05:32:30
1609 some more TODO for me
1610 - grunk@cvs.openbsd.org 2008/06/12 05:42:46
1612 supply the key type (rsa1, rsa, dsa) as a caption in the frame of the
1613 random art. while there, stress the fact that the field base should at
1614 least be 8 characters for the pictures to make sense.
1616 - grunk@cvs.openbsd.org 2008/06/12 06:32:59
1618 We already mark the start of the worm, now also mark the end of the worm
1619 in our random art drawings.
1621 - djm@cvs.openbsd.org 2008/06/12 15:19:17
1622 [clientloop.h channels.h clientloop.c channels.c mux.c]
1623 The multiplexing escape char handler commit last night introduced a
1624 small memory leak per session; plug it.
1625 - dtucker@cvs.openbsd.org 2008/06/12 16:35:31
1626 [ssh_config.5 ssh.c]
1627 keyword expansion for localcommand. ok djm@
1628 - jmc@cvs.openbsd.org 2008/06/12 19:10:09
1629 [ssh_config.5 ssh-keygen.1]
1630 tweak the ascii art text; ok grunk
1631 - dtucker@cvs.openbsd.org 2008/06/12 20:38:28
1632 [sshd.c sshconnect.c packet.h misc.c misc.h packet.c]
1633 Make keepalive timeouts apply while waiting for a packet, particularly
1634 during key renegotiation (bz #1363). With djm and Matt Day, ok djm@
1635 - djm@cvs.openbsd.org 2008/06/12 20:47:04
1637 print extension revisions for extensions that we understand
1638 - djm@cvs.openbsd.org 2008/06/12 21:06:25
1640 I was coalescing expected global request confirmation replies at
1641 the wrong end of the queue - fix; prompted by markus@
1642 - grunk@cvs.openbsd.org 2008/06/12 21:14:46
1644 make ssh-keygen -lf show the key type just as ssh-add -l would do it
1646 - grunk@cvs.openbsd.org 2008/06/12 22:03:36
1648 add my copyright, ok djm@
1649 - ian@cvs.openbsd.org 2008/06/12 23:24:58
1651 tweak wording in message, ok deraadt@ jmc@
1652 - dtucker@cvs.openbsd.org 2008/06/13 00:12:02
1654 replace __dead with __attribute__((noreturn)), makes things
1655 a little easier to port. Also, add it to sigdie(). ok djm@
1656 - djm@cvs.openbsd.org 2008/06/13 00:16:49
1658 fall back to creating a new TCP connection on most multiplexing errors
1659 (socket connect fail, invalid version, refused permittion, corrupted
1660 messages, etc.); bz #1329 ok dtucker@
1661 - dtucker@cvs.openbsd.org 2008/06/13 00:47:53
1663 upcast size_t to u_long to match format arg; ok djm@
1664 - dtucker@cvs.openbsd.org 2008/06/13 00:51:47
1666 upcast another size_t to u_long to match format
1667 - dtucker@cvs.openbsd.org 2008/06/13 01:38:23
1669 upcast uid to long with matching %ld, prevents warnings in portable
1670 - djm@cvs.openbsd.org 2008/06/13 04:40:22
1671 [auth2-pubkey.c auth-rhosts.c]
1672 refuse to read ~/.shosts or ~/.ssh/authorized_keys that are not
1673 regular files; report from Solar Designer via Colin Watson in bz#1471
1675 - (dtucker) [clientloop.c serverloop.c] channel_register_filter now
1676 takes 2 more args. with djm@
1677 - (dtucker) [defines.h] Bug #1112: __dead is, well dead. Based on a patch
1679 - (dtucker) [auth-sia.c] Bug #1241: support password expiry on Tru64 SIA
1680 systems. Patch from R. Scott Bailey.
1681 - (dtucker) [umac.c] STORE_UINT32_REVERSED and endian_convert are never used
1682 on big endian machines, so ifdef them for little-endian only to prevent
1683 unused function warnings on big-endians.
1684 - (dtucker) [openbsd-compat/setenv.c] Make offsets size_t to prevent
1685 compiler warnings on some platforms. Based on a discussion with otto@
1688 - (djm) [channels.c configure.ac]
1689 Do not set SO_REUSEADDR on wildcard X11 listeners (X11UseLocalhost=no)
1693 - (dtucker) OpenBSD CVS Sync
1694 - djm@cvs.openbsd.org 2008/06/10 03:57:27
1695 [servconf.c match.h sshd_config.5]
1696 support CIDR address matching in sshd_config "Match address" blocks, with
1697 full support for negation and fall-back to classic wildcard matching.
1699 Match address 192.0.2.0/24,3ffe:ffff::/32,!10.*
1700 PasswordAuthentication yes
1701 addrmatch.c code mostly lifted from flowd's addr.c
1702 feedback and ok dtucker@
1703 - djm@cvs.openbsd.org 2008/06/10 04:17:46
1705 better reference for pattern-list
1706 - dtucker@cvs.openbsd.org 2008/06/10 04:50:25
1707 [sshd.c channels.h channels.c log.c servconf.c log.h servconf.h sshd.8]
1708 Add extended test mode (-T) and connection parameters for test mode (-C).
1709 -T causes sshd to write its effective configuration to stdout and exit.
1710 -C causes any relevant Match rules to be applied before output. The
1711 combination allows tesing of the parser and config files. ok deraadt djm
1712 - jmc@cvs.openbsd.org 2008/06/10 07:12:00
1715 - jmc@cvs.openbsd.org 2008/06/10 08:17:40
1718 - fix SYNOPSIS, and sort options
1719 - some minor additional fixes
1720 - dtucker@cvs.openbsd.org 2008/06/09 18:06:32
1721 [regress/test-exec.sh]
1722 Don't generate putty keys if we're not going to use them. ok djm
1723 - dtucker@cvs.openbsd.org 2008/06/10 05:23:32
1724 [regress/addrmatch.sh regress/Makefile]
1725 Regress test for Match CIDR rules. ok djm@
1726 - dtucker@cvs.openbsd.org 2008/06/10 15:21:41
1728 Use a more portable construct for checking if we're running a putty test
1729 - dtucker@cvs.openbsd.org 2008/06/10 15:28:49
1732 - dtucker@cvs.openbsd.org 2008/06/10 18:21:24
1734 clarify that Host patterns are space-separated. ok deraadt
1735 - djm@cvs.openbsd.org 2008/06/10 22:15:23
1736 [PROTOCOL ssh.c serverloop.c]
1737 Add a no-more-sessions@openssh.com global request extension that the
1738 client sends when it knows that it will never request another session
1739 (i.e. when session multiplexing is disabled). This allows a server to
1740 disallow further session requests and terminate the session.
1741 Why would a non-multiplexing client ever issue additional session
1742 requests? It could have been attacked with something like SSH'jack:
1743 http://www.storm.net.nz/projects/7
1744 feedback & ok markus
1745 - djm@cvs.openbsd.org 2008/06/10 23:06:19
1746 [auth-options.c match.c servconf.c addrmatch.c sshd.8]
1747 support CIDR address matching in .ssh/authorized_keys from="..." stanzas
1748 ok and extensive testing dtucker@
1749 - dtucker@cvs.openbsd.org 2008/06/10 23:21:34
1751 Use '\0' for a nul byte rather than unadorned 0. ok djm@
1752 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
1753 [Makefile regress/key-options.sh]
1754 Add regress test for key options. ok djm@
1755 - (dtucker) [openbsd-compat/fake-rfc2553.h] Add sin6_scope_id to sockaddr_in6
1756 since the new CIDR code in addmatch.c references it.
1757 - (dtucker) [Makefile.in configure.ac regress/addrmatch.sh] Skip IPv6
1758 specific tests on platforms that don't do IPv6.
1759 - (dtucker) [Makefile.in] Define TEST_SSH_IPV6 in make's arguments as well
1761 - (dtucker) [Makefile.in] Move addrmatch.o to libssh.a where it's needed now.
1764 - (dtucker) OpenBSD CVS Sync
1765 - dtucker@cvs.openbsd.org 2008/06/08 17:04:41
1767 Add case for ENOSYS in errno_to_portable; ok deraadt
1768 - dtucker@cvs.openbsd.org 2008/06/08 20:15:29
1769 [sftp.c sftp-client.c sftp-client.h]
1770 Have the sftp client store the statvfs replies in wire format,
1771 which prevents problems when the server's native sizes exceed the
1773 Also extends the sizes of the remaining 32bit wire format to 64bit,
1774 they're specified as unsigned long in the standard.
1775 - dtucker@cvs.openbsd.org 2008/06/09 13:02:39
1777 Extend 32bit -> 64bit values for statvfs extension missed in previous
1779 - dtucker@cvs.openbsd.org 2008/06/09 13:38:46
1781 Use a $OpenBSD tag so our scripts will sync changes.
1784 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c
1785 openbsd-compat/Makefile.in openbsd-compat/openbsd-compat.h
1786 openbsd-compat/bsd-statvfs.{c,h}] Add a null implementation of statvfs and
1787 fstatvfs and remove #defines around statvfs code. ok djm@
1788 - (dtucker) [configure.ac defines.h sftp-client.c M sftp-server.c] Add a
1789 macro to convert fsid to unsigned long for platforms where fsid is a
1793 - (dtucker) [mux.c] Include paths.h inside ifdef HAVE_PATHS_H.
1794 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c]
1795 Do not enable statvfs extensions on platforms that do not have statvfs.
1796 - (dtucker) OpenBSD CVS Sync
1797 - djm@cvs.openbsd.org 2008/05/19 06:14:02
1798 [packet.c] unbreak protocol keepalive timeouts bz#1465; ok dtucker@
1799 - djm@cvs.openbsd.org 2008/05/19 15:45:07
1800 [sshtty.c ttymodes.c sshpty.h]
1801 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1802 we would send the modes corresponding to a zeroed struct termios,
1803 whereas we should have been sending an empty list of modes.
1804 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1805 - djm@cvs.openbsd.org 2008/05/19 15:46:31
1807 support -l (print fingerprint) in combination with -F (find host) to
1808 search for a host in ~/.ssh/known_hosts and display its fingerprint;
1810 - djm@cvs.openbsd.org 2008/05/19 20:53:52
1812 unbreak tree by committing this bit that I missed from:
1813 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1814 we would send the modes corresponding to a zeroed struct termios,
1815 whereas we should have been sending an empty list of modes.
1816 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1819 - (djm) [openbsd-compat/bsd-arc4random.c] Fix math bug that caused bias
1820 in arc4random_uniform with upper_bound in (2^30,2*31). Note that
1821 OpenSSH did not make requests with upper bounds in this range.
1824 - (djm) [configure.ac mux.c sftp.c openbsd-compat/Makefile.in]
1825 [openbsd-compat/fmt_scaled.c openbsd-compat/openbsd-compat.h]
1826 Fix compilation on Linux, including pulling in fmt_scaled(3)
1827 implementation from OpenBSD's libutil.
1830 - (djm) OpenBSD CVS Sync
1831 - djm@cvs.openbsd.org 2008/04/04 05:14:38
1833 ChrootDirectory is supported in Match blocks (in fact, it is most useful
1834 there). Spotted by Minstrel AT minstrel.org.uk
1835 - djm@cvs.openbsd.org 2008/04/04 06:44:26
1837 oops, some unrelated stuff crept into that commit - backout.
1839 - djm@cvs.openbsd.org 2008/04/05 02:46:02
1841 HostbasedAuthentication is supported under Match too
1842 - (djm) [openbsd-compat/bsd-arc4random.c openbsd-compat/openbsd-compat.c]
1843 [configure.ac] Implement arc4random_buf(), import implementation of
1844 arc4random_uniform() from OpenBSD
1845 - (djm) [openbsd-compat/bsd-arc4random.c] Warning fixes
1846 - (djm) [openbsd-compat/port-tun.c] needs sys/queue.h
1847 - (djm) OpenBSD CVS Sync
1848 - djm@cvs.openbsd.org 2008/04/13 00:22:17
1850 Use arc4random_buf() when requesting more than a single word of output
1851 Use arc4random_uniform() when the desired random number upper bound
1852 is not a power of two
1853 ok deraadt@ millert@
1854 - djm@cvs.openbsd.org 2008/04/18 12:32:11
1855 [sftp-client.c sftp-client.h sftp-server.c sftp.1 sftp.c sftp.h]
1856 introduce sftp extension methods statvfs@openssh.com and
1857 fstatvfs@openssh.com that implement statvfs(2)-like operations,
1858 based on a patch from miklos AT szeredi.hu (bz#1399)
1859 also add a "df" command to the sftp client that uses the
1860 statvfs@openssh.com to produce a df(1)-like display of filesystem
1861 space and inode utilisation
1863 - jmc@cvs.openbsd.org 2008/04/18 17:15:47
1866 - djm@cvs.openbsd.org 2008/04/18 22:01:33
1868 remove unneccessary parentheses
1869 - otto@cvs.openbsd.org 2008/04/29 11:20:31
1871 garbage collect two unused fields in struct mm_master; ok markus@
1872 - djm@cvs.openbsd.org 2008/04/30 10:14:03
1873 [ssh-keyscan.1 ssh-keyscan.c]
1874 default to rsa (protocol 2) keys, instead of rsa1 keys; spotted by
1875 larsnooden AT openoffice.org
1876 - pyr@cvs.openbsd.org 2008/05/07 05:49:37
1877 [servconf.c servconf.h session.c sshd_config.5]
1878 Enable the AllowAgentForwarding option in sshd_config (global and match
1879 context), to specify if agents should be permitted on the server.
1880 As the man page states:
1881 ``Note that disabling Agent forwarding does not improve security
1882 unless users are also denied shell access, as they can always install
1883 their own forwarders.''
1884 ok djm@, ok and a mild frown markus@
1885 - pyr@cvs.openbsd.org 2008/05/07 06:43:35
1887 push the sshd_config bits in, spotted by ajacoutot@
1888 - jmc@cvs.openbsd.org 2008/05/07 08:00:14
1891 - markus@cvs.openbsd.org 2008/05/08 06:59:01
1892 [bufaux.c buffer.h channels.c packet.c packet.h]
1893 avoid extra malloc/copy/free when receiving data over the net;
1894 ~10% speedup for localhost-scp; ok djm@
1895 - djm@cvs.openbsd.org 2008/05/08 12:02:23
1896 [auth-options.c auth1.c channels.c channels.h clientloop.c gss-serv.c]
1897 [monitor.c monitor_wrap.c nchan.c servconf.c serverloop.c session.c]
1899 Implement a channel success/failure status confirmation callback
1900 mechanism. Each channel maintains a queue of callbacks, which will
1901 be drained in order (RFC4253 guarantees confirm messages are not
1902 reordered within an channel).
1903 Also includes a abandonment callback to clean up if a channel is
1904 closed without sending confirmation messages. This probably
1905 shouldn't happen in compliant implementations, but it could be
1906 abused to leak memory.
1907 ok markus@ (as part of a larger diff)
1908 - djm@cvs.openbsd.org 2008/05/08 12:21:16
1909 [monitor.c monitor_wrap.c session.h servconf.c servconf.h session.c]
1910 [sshd_config sshd_config.5]
1911 Make the maximum number of sessions run-time controllable via
1912 a sshd_config MaxSessions knob. This is useful for disabling
1913 login/shell/subsystem access while leaving port-forwarding working
1914 (MaxSessions 0), disabling connection multiplexing (MaxSessions 1) or
1915 simply increasing the number of allows multiplexed sessions.
1916 Because some bozos are sure to configure MaxSessions in excess of the
1917 number of available file descriptors in sshd (which, at peak, might be
1918 as many as 9*MaxSessions), audit sshd to ensure that it doesn't leak fds
1919 on error paths, and make it fail gracefully on out-of-fd conditions -
1920 sending channel errors instead of than exiting with fatal().
1921 bz#1090; MaxSessions config bits and manpage from junyer AT gmail.com
1923 - djm@cvs.openbsd.org 2008/05/08 13:06:11
1924 [clientloop.c clientloop.h ssh.c]
1925 Use new channel status confirmation callback system to properly deal
1926 with "important" channel requests that fail, in particular command exec,
1927 shell and subsystem requests. Previously we would optimistically assume
1928 that the requests would always succeed, which could cause hangs if they
1929 did not (e.g. when the server runs out of fds) or were unimplemented by
1930 the server (bz #1384)
1931 Also, properly report failing multiplex channel requests via the mux
1932 client stderr (subject to LogLevel in the mux master) - better than
1934 most bits ok markus@ (as part of a larger diff)
1935 - djm@cvs.openbsd.org 2008/05/09 04:55:56
1936 [channels.c channels.h clientloop.c serverloop.c]
1937 Try additional addresses when connecting to a port forward destination
1938 whose DNS name resolves to more than one address. The previous behaviour
1939 was to try the first address and give up.
1940 Reported by stig AT venaas.com in bz#343
1941 great feedback and ok markus@
1942 - djm@cvs.openbsd.org 2008/05/09 14:18:44
1943 [clientloop.c clientloop.h ssh.c mux.c]
1944 tidy up session multiplexing code, moving it into its own file and
1945 making the function names more consistent - making ssh.c and
1946 clientloop.c a fair bit more readable.
1948 - djm@cvs.openbsd.org 2008/05/09 14:26:08
1950 dingo stole my diff hunk
1951 - markus@cvs.openbsd.org 2008/05/09 16:16:06
1953 re-add the USE_PIPES code and enable it.
1954 without pipes shutdown-read from the sshd does not trigger
1955 a SIGPIPE when the forked program does a write.
1957 (Id sync only, USE_PIPES never left portable OpenSSH)
1958 - markus@cvs.openbsd.org 2008/05/09 16:17:51
1960 error-fd race: don't enable the error fd in the select bitmask
1961 for channels with both in- and output closed, since the channel
1962 will go away before we call select();
1963 report, lots of debugging help and ok djm@
1964 - markus@cvs.openbsd.org 2008/05/09 16:21:13
1965 [channels.h clientloop.c nchan.c serverloop.c]
1967 ssh -2 localhost od /bin/ls | true
1968 ignoring SIGPIPE by adding a new channel message (EOW) that signals
1969 the peer that we're not interested in any data it might send.
1970 fixes bz #85; discussion, debugging and ok djm@
1971 - pvalchev@cvs.openbsd.org 2008/05/12 20:52:20
1973 Ensure nh_result lies on a 64-bit boundary (fixes warnings observed
1974 on Itanium on Linux); from Dale Talcott (bug #1462); ok djm@
1975 - djm@cvs.openbsd.org 2008/05/15 23:52:24
1977 document eow message in ssh protocol 2 channel state machine;
1978 feedback and ok markus@
1979 - djm@cvs.openbsd.org 2008/05/18 21:29:05
1981 comment extension announcement
1982 - djm@cvs.openbsd.org 2008/05/16 08:30:42
1984 document our protocol extensions and deviations; ok markus@
1985 - djm@cvs.openbsd.org 2008/05/17 01:31:56
1987 grammar and correctness fixes from stevesk@
1990 - (djm) [openbsd-compat/bsd-poll.c] Include stdlib.h to avoid compile-
1991 time warnings on LynxOS. Patch from ops AT iki.fi
1992 - (djm) Force string arguments to replacement setproctitle() though
1993 strnvis first. Ok dtucker@
1996 - (djm) OpenBSD CVS sync:
1997 - markus@cvs.openbsd.org 2008/04/02 15:36:51
1999 avoid possible hijacking of x11-forwarded connections (back out 1.183)
2000 CVE-2008-1483; ok djm@
2001 - jmc@cvs.openbsd.org 2008/03/27 22:37:57
2003 remove trailing whitespace;
2004 - djm@cvs.openbsd.org 2008/04/03 09:50:14
2007 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
2008 [contrib/suse/openssh.spec] Crank version numbers in RPM spec files
2009 - (djm) [README] Update link to release notes
2010 - (djm) Release 5.0p1