2 - (dtucker) OpenBSD CVS Sync
3 - markus@cvs.openbsd.org 2009/03/17 21:37:00
5 pass correct argv[0] to openlog(); ok djm@
6 - jmc@cvs.openbsd.org 2009/03/19 15:15:09
8 for "Ciphers", just point the reader to the keyword in ssh_config(5), just
9 as we do for "MACs": this stops us getting out of sync when the lists
11 fixes documentation/6102, submitted by Peter J. Philipp
12 alternative fix proposed by djm
14 - tobias@cvs.openbsd.org 2009/03/23 08:31:19
16 Fixed a possible out-of-bounds memory access if the environment variable
17 SHELL is shorter than 3 characters.
18 with input by and ok dtucker
19 - tobias@cvs.openbsd.org 2009/03/23 19:38:04
21 My previous commit didn't fix the problem at all, so stick at my first
22 version of the fix presented to dtucker.
23 Issue notified by Matthias Barkhoff (matthias dot barkhoff at gmx dot de).
25 - sobrado@cvs.openbsd.org 2009/03/26 08:38:39
26 [sftp-server.8 sshd.8 ssh-agent.1]
27 fix a few typographical errors found by spell(1).
29 - stevesk@cvs.openbsd.org 2009/04/13 19:07:44
31 fix possessive; ok djm@
32 - stevesk@cvs.openbsd.org 2009/04/14 16:33:42
34 remove unused option character from getopt() optstring; ok markus@
35 - jj@cvs.openbsd.org 2009/04/14 21:10:54
37 Fixed a few the-the misspellings in comments. Skipped a bunch in
38 binutils,gcc and so on. ok jmc@
39 - stevesk@cvs.openbsd.org 2009/04/17 19:23:06
41 use INTERNAL_SFTP_NAME for setproctitle() of in-process sftp-server;
43 - stevesk@cvs.openbsd.org 2009/04/17 19:40:17
45 clarify that even internal-sftp needs /dev/log for logging to work; ok
47 - jmc@cvs.openbsd.org 2009/04/18 18:39:10
49 tweak previous; ok stevesk
50 - stevesk@cvs.openbsd.org 2009/04/21 15:13:17
52 clarify we cd to user's home after chroot; ok markus@ on
53 earlier version; tweaks and ok jmc@
54 - andreas@cvs.openbsd.org 2009/05/25 06:48:01
55 [channels.c packet.c clientloop.c packet.h serverloop.c monitor_wrap.c
57 Put the globals in packet.c into a struct and don't access it directly
58 from other files. No functional changes.
60 - andreas@cvs.openbsd.org 2009/05/27 06:31:25
61 [canohost.h canohost.c]
62 Add clear_cached_addr(), needed for upcoming changes allowing the peer
65 - andreas@cvs.openbsd.org 2009/05/27 06:33:39
67 Send SSH2_MSG_DISCONNECT when the client disconnects. From a larger
68 change from Martin Forssen, maf at appgate dot com.
70 - andreas@cvs.openbsd.org 2009/05/27 06:34:36
72 Move the KEX_COOKIE_LEN define to kex.h
74 - andreas@cvs.openbsd.org 2009/05/27 06:36:07
76 Add packet_put_int64() and packet_get_int64(), part of a larger change
79 - andreas@cvs.openbsd.org 2009/05/27 06:38:16
80 [sshconnect.h sshconnect.c]
81 Un-static ssh_exchange_identification(), part of a larger change from
82 Martin Forssen and needed for upcoming changes.
84 - andreas@cvs.openbsd.org 2009/05/28 16:50:16
85 [sshd.c packet.c serverloop.c monitor_wrap.c clientloop.c sshconnect.c
86 monitor.c Added roaming.h roaming_common.c roaming_dummy.c]
87 Keep track of number of bytes read and written. Needed for upcoming
88 changes. Most code from Martin Forssen, maf at appgate dot com.
90 Also, applied appropriate changes to Makefile.in
91 - andreas@cvs.openbsd.org 2009/06/12 20:43:22
93 Fix warnings found by chl@ and djm@ and change roaming_atomicio's
94 return type to match atomicio's
95 Diff from djm@, ok markus@
98 - (dtucker) [configure.ac defines.h] Bug #1607: handle the case where fsid_t
99 is a struct with a __val member. Fixes build on, eg, Redhat 6.2.
102 - (dtucker) [sshlogin.c] Move the NO_SSH_LASTLOG #ifndef line to include
103 variable declarations. Should prevent unused warnings anywhere it's set
104 (only Crays as far as I can tell) and be a no-op everywhere else.
107 - (tim) [configure.ac] Remove setting IP_TOS_IS_BROKEN for Cygwin. The problem
108 that setsockopt(IP_TOS) doesn't work on Cygwin has been fixed since 2005.
109 Based on patch from vinschen at redhat com.
112 - (dtucker) [auth-passwd.c auth1.c auth2-kbdint.c auth2-none.c auth2-passwd.c
113 auth2-pubkey.c session.c openbsd-compat/bsd-cygwin_util.{c,h}
114 openbsd-compat/daemon.c] Remove support for Windows 95/98/ME and very old
115 version of Cygwin. Patch from vinschen at redhat com.
118 - (dtucker) [contrib/aix/buildbff.sh] Only try to rename ssh_prng_cmds if it
119 exists (it's not created if OpenSSL's PRNG is self-seeded, eg if the OS
121 - (dtucker) [schnorr.c openbsd-compat/openssl-compat.{c,h}] Add
122 EVP_DigestUpdate to the OLD_EVP compatibility functions and tell schnorr.c
123 to use them. Allows building with older OpenSSL versions.
124 - (dtucker) [configure.ac defines.h] Check for in_port_t and typedef if needed.
125 - (dtucker) [configure.ac] Missing comma in type list.
126 - (dtucker) [configure.ac openbsd-compat/openssl-compat.{c,h}]
127 EVP_DigestUpdate does not exactly match the other OLD_EVP functions (eg
128 in openssl 0.9.6) so add an explicit test for it.
131 - (djm) OpenBSD CVS Sync
132 - djm@cvs.openbsd.org 2009/03/05 07:18:19
133 [auth2-jpake.c jpake.c jpake.h monitor_wrap.c monitor_wrap.h schnorr.c]
135 refactor the (disabled) Schnorr proof code to make it a little more
137 - djm@cvs.openbsd.org 2009/03/05 11:30:50
139 document what these functions do so I don't ever have to recuse into
140 b64_pton/ntop to remember their return values
143 - (djm) OpenBSD CVS Sync
144 - djm@cvs.openbsd.org 2009/02/22 23:50:57
145 [ssh_config.5 sshd_config.5]
146 don't advertise experimental options
147 - djm@cvs.openbsd.org 2009/02/22 23:59:25
150 - djm@cvs.openbsd.org 2009/02/23 00:06:15
153 - (djm) [README] update for 5.2
154 - (djm) Release openssh-5.2p1
157 - (djm) OpenBSD CVS Sync
158 - tobias@cvs.openbsd.org 2009/02/21 19:32:04
159 [misc.c sftp-server-main.c ssh-keygen.c]
160 Added missing newlines in error messages.
164 - (djm) OpenBSD CVS Sync
165 - djm@cvs.openbsd.org 2009/02/17 01:28:32
167 sync with revised default ciphers; pointed out by dkrause@
168 - djm@cvs.openbsd.org 2009/02/18 04:31:21
170 signature should hash over the entire group, not just the generator
171 (this is still disabled code)
172 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
173 [contrib/suse/openssh.spec] Prepare for 5.2p1
176 - (djm) [regress/conch-ciphers.sh regress/putty-ciphers.sh]
177 [regress/putty-kex.sh regress/putty-transfer.sh] Downgrade disabled
178 interop tests from FATAL error to a warning. Allows some interop
179 tests to proceed if others are missing necessary prerequisites.
180 - (djm) [configure.ac] support GNU/kFreeBSD and GNU/kOpensolaris
181 systems; patch from Aurelien Jarno via rmh AT aybabtu.com
184 - (djm) OpenBSD CVS Sync
185 - dtucker@cvs.openbsd.org 2009/02/02 11:15:14
187 Initialize a few variables to prevent spurious "may be used
188 uninitialized" warnings from newer gcc's. ok djm@
189 - djm@cvs.openbsd.org 2009/02/12 03:00:56
190 [canohost.c canohost.h channels.c channels.h clientloop.c readconf.c]
191 [readconf.h serverloop.c ssh.c]
192 support remote port forwarding with a zero listen port (-R0:...) to
193 dyamically allocate a listen port at runtime (this is actually
194 specified in rfc4254); bz#1003 ok markus@
195 - djm@cvs.openbsd.org 2009/02/12 03:16:01
197 tighten check for -R0:... forwarding: only allow dynamic allocation
198 if want_reply is set in the packet
199 - djm@cvs.openbsd.org 2009/02/12 03:26:22
201 some paranoia: check that the serialised key is really KEY_RSA before
202 diddling its internals
203 - djm@cvs.openbsd.org 2009/02/12 03:42:09
205 document -R0:... usage
206 - djm@cvs.openbsd.org 2009/02/12 03:44:25
208 consistency: Dq => Ql
209 - djm@cvs.openbsd.org 2009/02/12 03:46:17
211 document RemoteForward usage with 0 listen port
212 - jmc@cvs.openbsd.org 2009/02/12 07:34:20
214 kill trailing whitespace;
215 - markus@cvs.openbsd.org 2009/02/13 11:50:21
217 check for enc !=NULL in packet_start_discard
218 - djm@cvs.openbsd.org 2009/02/14 06:35:49
220 mention that eow and no-more-sessions extensions are sent only to
224 - (djm) [sshpty.c] bz#1419: OSX uses cloning ptys that automagically
225 set ownership and modes, so avoid explicitly setting them
226 - (djm) [configure.ac loginrec.c] bz#1421: fix lastlog support for OSX.
227 OSX provides a getlastlogxbyname function that automates the reading of
228 a lastlog file. Also, the pututxline function will update lastlog so
229 there is no need for loginrec.c to do it explicitly. Collapse some
230 overly verbose code while I'm in there.
233 - (dtucker) [defines.h sshconnect.c] INET6_ADDRSTRLEN is now needed in
234 channels.c too, so move the definition for non-IP6 platforms to defines.h
235 where it can be shared.
238 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
239 If the CYGWIN environment variable is empty, the installer script
240 should not install the service with an empty CYGWIN variable, but
241 rather without setting CYGWNI entirely.
242 - (tim) [contrib/cygwin/ssh-host-config] Whitespace cleanup. No code changes.
245 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
246 Changes to work on Cygwin 1.5.x as well as on the new Cygwin 1.7.x.
247 The information given for the setting of the CYGWIN environment variable
248 is wrong for both releases so I just removed it, together with the
249 unnecessary (Cygwin 1.5.x) or wrong (Cygwin 1.7.x) default setting.
252 - (djm) OpenBSD CVS Sync
253 - stevesk@cvs.openbsd.org 2008/12/09 03:20:42
254 [channels.c servconf.c]
255 channel_print_adm_permitted_opens() should deal with all the printing
256 for that config option. suggested by markus@; ok markus@ djm@
258 - djm@cvs.openbsd.org 2008/12/09 04:32:22
260 replace by-hand string building with xasprinf(); ok deraadt@
261 - sobrado@cvs.openbsd.org 2008/12/09 15:35:00
263 update for the synopses displayed by the 'help' command, there are a
264 few missing flags; add 'bye' to the output of 'help'; sorting and spacing.
265 jmc@ suggested replacing .Oo/.Oc with a single .Op macro.
267 - stevesk@cvs.openbsd.org 2008/12/09 22:37:33
269 fix typo in error message
270 - stevesk@cvs.openbsd.org 2008/12/10 03:55:20
272 o cannot be NULL here but use xfree() to be consistent; ok djm@
273 - stevesk@cvs.openbsd.org 2008/12/29 01:12:36
275 fix example, default key type is rsa for 3+ years; from
276 frederic.perrin@resel.fr
277 - stevesk@cvs.openbsd.org 2008/12/29 02:23:26
279 no need to escape single quotes in comments
280 - okan@cvs.openbsd.org 2008/12/30 00:46:56
282 add AllowAgentForwarding to available Match keywords list
284 - djm@cvs.openbsd.org 2009/01/01 21:14:35
286 call channel destroy callbacks on receipt of open failure messages.
287 fixes client hangs when connecting to a server that has MaxSessions=0
288 set spotted by imorgan AT nas.nasa.gov; ok markus@
289 - djm@cvs.openbsd.org 2009/01/01 21:17:36
291 fix hash calculation for KEXGEX: hash over the original client-supplied
292 values and not the sanity checked versions that we acutally use;
293 bz#1540 reported by john.smith AT arrows.demon.co.uk
295 - djm@cvs.openbsd.org 2009/01/14 01:38:06
297 support SOCKS4A protocol, from dwmw2 AT infradead.org via bz#1482;
299 - stevesk@cvs.openbsd.org 2009/01/15 17:38:43
301 1) use obsolete instead of alias for consistency
302 2) oUserKnownHostsFile not obsolete but oGlobalKnownHostsFile2 is
304 3) reorder so like options are together
306 - djm@cvs.openbsd.org 2009/01/22 09:46:01
307 [channels.c channels.h session.c]
308 make Channel->path an allocated string, saving a few bytes here and
309 there and fixing bz#1380 in the process; ok markus@
310 - djm@cvs.openbsd.org 2009/01/22 09:49:57
312 oops! I committed the wrong version of the Channel->path diff,
313 it was missing some tweaks suggested by stevesk@
314 - djm@cvs.openbsd.org 2009/01/22 10:02:34
315 [clientloop.c misc.c readconf.c readconf.h servconf.c servconf.h]
316 [serverloop.c ssh-keyscan.c ssh.c sshd.c]
317 make a2port() return -1 when it encounters an invalid port number
318 rather than 0, which it will now treat as valid (needed for future work)
319 adjust current consumers of a2port() to check its return value is <= 0,
320 which in turn required some things to be converted from u_short => int
321 make use of int vs. u_short consistent in some other places too
322 feedback & ok markus@
323 - djm@cvs.openbsd.org 2009/01/22 10:09:16
325 another chunk of a2port() diff that got away. wtfdjm??
326 - djm@cvs.openbsd.org 2009/01/23 07:58:11
328 prefer CTR modes and revised arcfour (i.e w/ discard) modes to CBC
330 - naddy@cvs.openbsd.org 2009/01/24 17:10:22
331 [ssh_config.5 sshd_config.5]
332 sync list of preferred ciphers; ok djm@
333 - markus@cvs.openbsd.org 2009/01/26 09:58:15
334 [cipher.c cipher.h packet.c]
335 Work around the CPNI-957037 Plaintext Recovery Attack by always
336 reading 256K of data on packet size or HMAC errors (in CBC mode only).
337 Help, feedback and ok djm@
338 Feedback from Martin Albrecht and Paterson Kenny
341 - (djm) [uidswap.c] bz#1412: Support >16 supplemental groups in OS X.
342 Patch based on one from vgiffin AT apple.com; ok dtucker@
343 - (djm) [channels.c] bz#1419: support "on demand" X11 forwarding via
344 launchd on OS X; patch from vgiffin AT apple.com, slightly tweaked;
346 - (djm) [contrib/ssh-copy-id.1 contrib/ssh-copy-id] bz#1492: Make
347 ssh-copy-id copy id_rsa.pub by default (instead of the legacy "identity"
348 key). Patch from cjwatson AT debian.org
351 - (tim) [configure.ac defines.h openbsd-compat/port-uw.c
352 openbsd-compat/xcrypt.c] Add SECUREWARE support to OpenServer 6 SVR5 ABI.
354 - (tim) [configure.ac] Move check_for_libcrypt_later=1 in *-*-sysv5*) section.
355 OpenServer 6 doesn't need libcrypt.
358 - (djm) OpenBSD CVS Sync
359 - djm@cvs.openbsd.org 2008/12/09 02:38:18
361 The ~C escape handler does not work correctly for multiplexed sessions -
362 it opens a commandline on the master session, instead of on the slave
363 that requested it. Disable it on slave sessions until such time as it
364 is fixed; bz#1543 report from Adrian Bridgett via Colin Watson
366 - djm@cvs.openbsd.org 2008/12/09 02:39:59
368 Deal correctly with failures in remote stat() operation in sftp,
369 correcting fail-on-error behaviour in batchmode. bz#1541 report and
370 fix from anedvedicky AT gmail.com; ok markus@
371 - djm@cvs.openbsd.org 2008/12/09 02:58:16
373 don't leave junk (free'd) pointers around in Forward *fwd argument on
374 failure; avoids double-free in ~C -L handler when given an invalid
375 forwarding specification; bz#1539 report from adejong AT debian.org
376 via Colin Watson; ok markus@ dtucker@
377 - djm@cvs.openbsd.org 2008/12/09 03:02:37
379 correct sftp(1) and corresponding usage syntax;
380 bz#1518 patch from imorgan AT nas.nasa.gov; ok deraadt@ improved diff jmc@
383 - (djm) [configure.ac] bz#1538: better test for ProPolice/SSP: actually
384 use some stack in main().
385 Report and suggested fix from vapier AT gentoo.org
386 - (djm) OpenBSD CVS Sync
387 - markus@cvs.openbsd.org 2008/12/02 19:01:07
389 we have to use the recipient's channel number (RFC 4254) for
390 SSH2_MSG_CHANNEL_SUCCESS/SSH2_MSG_CHANNEL_FAILURE messages,
391 otherwise we trigger 'Non-public channel' error messages on sshd
392 systems with clientkeepalive enabled; noticed by sturm; ok djm;
393 - markus@cvs.openbsd.org 2008/12/02 19:08:59
395 backout 1.149, since it's not necessary and openssh clients send
396 broken CHANNEL_FAILURE/SUCCESS messages since about 2004; ok djm@
397 - markus@cvs.openbsd.org 2008/12/02 19:09:38
399 s/remote_id/id/ to be more consistent with other code; ok djm@
402 - (dtucker) [contrib/cygwin/{Makefile,ssh-host-config}] Add new doc files
403 and tweak the is-sshd-running check in ssh-host-config. Patch from
404 vinschen at redhat com.
405 - (dtucker) OpenBSD CVS Sync
406 - markus@cvs.openbsd.org 2008/11/21 15:47:38
408 packet_disconnect() on padding error, too. should reduce the success
409 probability for the CPNI-957037 Plaintext Recovery Attack to 2^-18
411 - dtucker@cvs.openbsd.org 2008/11/30 11:59:26
413 Retry sendmsg/recvmsg on EAGAIN and EINTR; ok djm@
416 - (dtucker) [monitor_fdpass.c] Reduce diff vs OpenBSD by moving some
417 declarations, removing an unnecessary union member and adding whitespace.
418 cmsgbuf.tmp thing spotted by des at des no, ok djm some time ago.
421 - (tim) [addrmatch.c configure.ac] Some platforms do not have sin6_scope_id
422 member of sockaddr_in6. Also reported in Bug 1491 by David Leonard. OK and
426 - (dtucker) OpenBSD CVS Sync
427 - jmc@cvs.openbsd.org 2008/11/05 11:22:54
430 fixes user/5975 from Rene Maroufi
431 - stevesk@cvs.openbsd.org 2008/11/07 00:42:12
433 spelling/typo in comment
434 - stevesk@cvs.openbsd.org 2008/11/07 18:50:18
436 add space to some log/debug messages for readability; ok djm@ markus@
437 - dtucker@cvs.openbsd.org 2008/11/07 23:34:48
439 Move JPAKE define to make life easier for portable. ok djm@
440 - tobias@cvs.openbsd.org 2008/11/09 12:34:47
442 typo fixed (overriden -> overridden)
444 - stevesk@cvs.openbsd.org 2008/11/11 02:58:09
446 USE_AFS not referenced so remove #ifdef. fixes sshd -T not printing
447 kerberosgetafstoken. ok dtucker@
448 (Id sync only, we still want the ifdef in portable)
449 - stevesk@cvs.openbsd.org 2008/11/11 03:55:11
451 for sshd -T print 'permitopen any' vs. 'permitopen' for case of no
452 permitopen's; ok and input dtucker@
453 - djm@cvs.openbsd.org 2008/11/10 02:06:35
454 [regress/putty-ciphers.sh]
455 PuTTY supports AES CTR modes, so interop test against them too
459 - djm@cvs.openbsd.org 2008/11/03 08:59:41
461 include MaxSessions in sshd -T output; patch from imorgan AT nas.nasa.gov
462 - djm@cvs.openbsd.org 2008/11/04 07:58:09
464 need unistd.h for close() prototype
466 - djm@cvs.openbsd.org 2008/11/04 08:22:13
467 [auth.h auth2.c monitor.c monitor.h monitor_wrap.c monitor_wrap.h]
468 [readconf.c readconf.h servconf.c servconf.h ssh2.h ssh_config.5]
469 [sshconnect2.c sshd_config.5 jpake.c jpake.h schnorr.c auth2-jpake.c]
471 Add support for an experimental zero-knowledge password authentication
472 method using the J-PAKE protocol described in F. Hao, P. Ryan,
473 "Password Authenticated Key Exchange by Juggling", 16th Workshop on
474 Security Protocols, Cambridge, April 2008.
476 This method allows password-based authentication without exposing
477 the password to the server. Instead, the client and server exchange
478 cryptographic proofs to demonstrate of knowledge of the password while
479 revealing nothing useful to an attacker or compromised endpoint.
481 This is experimental, work-in-progress code and is presently
482 compiled-time disabled (turn on -DJPAKE in Makefile.inc).
484 "just commit it. It isn't too intrusive." deraadt@
485 - stevesk@cvs.openbsd.org 2008/11/04 19:18:00
487 because parse_forward() is now used to parse all forward types (DLR),
488 and it malloc's space for host variables, we don't need to malloc
489 here. fixes small memory leaks.
491 previously dynamic forwards were not parsed in parse_forward() and
492 space was not malloc'd in that case.
495 - stevesk@cvs.openbsd.org 2008/11/05 03:23:09
497 add dynamic forward escape command line; ok djm@
501 - sthen@cvs.openbsd.org 2008/07/24 23:55:30
503 Add "ssh-keygen -F -l" to synopsis (displays fingerprint from
504 known_hosts). ok djm@
505 - grunk@cvs.openbsd.org 2008/07/25 06:56:35
507 Add VisualHostKey to example file, ok djm@
508 - grunk@cvs.openbsd.org 2008/07/25 07:05:16
510 In random art visualization, make sure to use the end marker only at the
511 end. Initial diff by Dirk Loss, tweaks and ok djm@
512 - markus@cvs.openbsd.org 2008/07/31 14:48:28
514 don't allocate space for empty banners; report t8m at centrum.cz;
516 - krw@cvs.openbsd.org 2008/08/02 04:29:51
518 whitepsace -> whitespace. From Matthew Clarke via bugs@.
519 - djm@cvs.openbsd.org 2008/08/21 04:09:57
521 allow ForceCommand internal-sftp with arguments. based on patch from
522 michael.barabanov AT gmail.com; ok markus@
523 - djm@cvs.openbsd.org 2008/09/06 12:24:13
525 OpenSSL 0.9.8h supplies a real EVP_sha256 so we do not need our
527 (ID sync only for portable - we still need this)
528 - markus@cvs.openbsd.org 2008/09/11 14:22:37
529 [compat.c compat.h nchan.c ssh.c]
530 only send eow and no-more-sessions requests to openssh 5 and newer;
531 fixes interop problems with broken ssh v2 implementations; ok djm@
532 - millert@cvs.openbsd.org 2008/10/02 14:39:35
534 Convert an unchecked strdup to xstrdup. OK deraadt@
535 - jmc@cvs.openbsd.org 2008/10/03 13:08:12
537 do not give an example of how to chmod files: we can presume the user
538 knows that. removes an ambiguity in the permission of authorized_keys;
540 - deraadt@cvs.openbsd.org 2008/10/03 23:56:28
542 Repair strnvis() buffersize of 4*n+1, with termination gauranteed by the
544 spotted by des@freebsd, who commited an incorrect fix to the freebsd tree
545 and (as is fairly typical) did not report the problem to us. But this fix
548 - djm@cvs.openbsd.org 2008/10/08 23:34:03
550 Add -y option to force logging via syslog rather than stderr.
551 Useful for daemonised ssh connection (ssh -f). Patch originally from
553 - djm@cvs.openbsd.org 2008/10/09 03:50:54
554 [servconf.c sshd_config.5]
555 support setting PermitEmptyPasswords in a Match block
556 requested in PR3891; ok dtucker@
557 - jmc@cvs.openbsd.org 2008/10/09 06:54:22
560 - stevesk@cvs.openbsd.org 2008/10/10 04:55:16
562 spelling in comment; ok djm@
563 - stevesk@cvs.openbsd.org 2008/10/10 05:00:12
565 typo in error message; ok djm@
566 - stevesk@cvs.openbsd.org 2008/10/10 16:43:27
568 use 'Privileged ports can be forwarded only when logging in as root on
569 the remote machine.' for RemoteForward just like ssh.1 -R.
571 - stevesk@cvs.openbsd.org 2008/10/14 18:11:33
573 use #define ROQUIET here; no binary change. ok dtucker@
574 - stevesk@cvs.openbsd.org 2008/10/17 18:36:24
576 correct and clarify VisualHostKey; ok jmc@
577 - stevesk@cvs.openbsd.org 2008/10/30 19:31:16
578 [clientloop.c sshd.c]
579 don't need to #include "monitor_fdpass.h"
580 - stevesk@cvs.openbsd.org 2008/10/31 15:05:34
582 remove unused #define DISPATCH_MIN; ok markus@
583 - djm@cvs.openbsd.org 2008/11/01 04:50:08
585 sprinkle ARGSUSED on dispatch handlers
586 nuke stale unusued prototype
587 - stevesk@cvs.openbsd.org 2008/11/01 06:43:33
589 fix some typos in log messages; ok djm@
590 - sobrado@cvs.openbsd.org 2008/11/01 11:14:36
591 [ssh-keyscan.1 ssh-keyscan.c]
592 the ellipsis is not an optional argument; while here, improve spacing.
593 - stevesk@cvs.openbsd.org 2008/11/01 17:40:33
594 [clientloop.c readconf.c readconf.h ssh.c]
595 merge dynamic forward parsing into parse_forward();
596 'i think this is OK' djm@
597 - stevesk@cvs.openbsd.org 2008/11/02 00:16:16
599 protocol 2 tty modes support is now 7.5 years old so remove these
600 debug3()s; ok deraadt@
601 - stevesk@cvs.openbsd.org 2008/11/03 01:07:02
603 remove valueless comment
604 - stevesk@cvs.openbsd.org 2008/11/03 02:44:41
607 - (djm) [contrib/caldera/ssh-host-keygen contrib/suse/rc.sshd]
608 Make example scripts generate keys with default sizes rather than fixed,
609 non-default 1024 bits; patch from imorgan AT nas.nasa.gov
610 - (djm) [contrib/sshd.pam.generic contrib/caldera/sshd.pam]
611 [contrib/redhat/sshd.pam] Move pam_nologin to account group from
612 incorrect auth group in example files;
613 patch from imorgan AT nas.nasa.gov
616 - (dtucker) [config.guess config.sub] Update to latest versions from
617 http://git.savannah.gnu.org/gitweb/ (2008-04-14 and 2008-06-16
621 - (dtucker) [openbsd-compat/bsd-poll.c] correctly check for number of FDs
622 larger than FD_SETSIZE (OpenSSH only ever uses poll with one fd). Patch
623 from Nicholas Marriott.
626 - (djm) OpenBSD CVS Sync
627 - djm@cvs.openbsd.org 2008/07/23 07:36:55
629 do not try to print options that have been compile-time disabled
630 in config test mode (sshd -T); report from nix-corp AT esperi.org.uk
632 - (djm) [servconf.c] Print UsePAM option in config test mode (when it
633 has been compiled in); report from nix-corp AT esperi.org.uk
637 - (djm) OpenBSD CVS Sync
638 - jmc@cvs.openbsd.org 2008/07/18 22:51:01
640 no need for .Pp before or after .Sh;
641 - djm@cvs.openbsd.org 2008/07/21 08:19:07
644 - (djm) [README contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
645 [contrib/suse/openssh.spec] Update version number in README and RPM specs
646 - (djm) Release OpenSSH-5.1
649 - (djm) OpenBSD CVS Sync
650 - djm@cvs.openbsd.org 2008/07/17 08:48:00
652 strnvis preauth banner; pointed out by mpf@ ok markus@
653 - djm@cvs.openbsd.org 2008/07/17 08:51:07
655 strip trailing '.' from hostname when HostbasedUsesNameFromPacketOnly=yes
656 report and patch from res AT qoxp.net (bz#1200); ok markus@
657 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Remove long-unneeded compat
658 code, replace with equivalent cygwin library call. Patch from vinschen
659 at redhat.com, ok djm@.
660 - (djm) [sshconnect2.c] vis.h isn't available everywhere
664 - djm@cvs.openbsd.org 2008/07/15 02:23:14
666 number of pipelined requests is now 64;
667 prodded by Iain.Morgan AT nasa.gov
668 - djm@cvs.openbsd.org 2008/07/16 11:51:14
670 rename variable first_gc -> last_gc (since it is actually the last
672 - djm@cvs.openbsd.org 2008/07/16 11:52:19
674 this loop index should be automatic, not static
677 - (djm) OpenBSD CVS Sync
678 - sthen@cvs.openbsd.org 2008/07/13 21:22:52
680 Change "ssh-keygen -F [host] -l" to not display random art unless
681 -v is also specified, making it consistent with the manual and other
684 - djm@cvs.openbsd.org 2008/07/13 22:13:07
686 use struct sockaddr_storage instead of struct sockaddr for accept(2)
687 address argument. from visibilis AT yahoo.com in bz#1485; ok markus@
688 - djm@cvs.openbsd.org 2008/07/13 22:16:03
690 increase number of piplelined requests so they properly fill the
691 (recently increased) channel window. prompted by rapier AT psc.edu;
693 - djm@cvs.openbsd.org 2008/07/14 01:55:56
695 mention requirement for /dev/log inside chroot when using sftp-server
697 - (djm) [openbsd-compat/bindresvport.c] Rename variables s/sin/in/ to
698 avoid clash with sin(3) function; reported by
699 cristian.ionescu-idbohrn AT axis.com
700 - (djm) [openbsd-compat/rresvport.c] Add unistd.h for missing close()
701 prototype; reported by cristian.ionescu-idbohrn AT axis.com
702 - (djm) [umac.c] Rename variable s/buffer_ptr/bufp/ to avoid clash;
703 reported by cristian.ionescu-idbohrn AT axis.com
704 - (djm) [contrib/cygwin/Makefile contrib/cygwin/ssh-host-config]
705 [contrib/cygwin/ssh-user-config contrib/cygwin/sshd-inetd]
706 Revamped and simplified Cygwin ssh-host-config script that uses
707 unified csih configuration tool. Requires recent Cygwin.
708 Patch from vinschen AT redhat.com
711 - (djm) OpenBSD CVS Sync
712 - djm@cvs.openbsd.org 2008/07/12 04:52:50
714 unbreak; move clearing of cctx struct to before first use
716 - djm@cvs.openbsd.org 2008/07/12 05:33:41
718 better description for -i flag:
719 s/RSA authentication/public key authentication/
720 - (djm) [openbsd-compat/fake-rfc2553.c openbsd-compat/fake-rfc2553.h]
721 return EAI_FAMILY when trying to lookup unsupported address family;
722 from vinschen AT redhat.com
725 - (djm) OpenBSD CVS Sync
726 - stevesk@cvs.openbsd.org 2008/07/07 00:31:41
728 we don't need arg after the debug3() was removed. from lint.
730 - stevesk@cvs.openbsd.org 2008/07/07 23:32:51
732 /*NOTREACHED*/ for lint warning:
733 warning: function key_equal falls off bottom without returning value
735 - markus@cvs.openbsd.org 2008/07/10 18:05:58
737 missing bzero; from mickey; ok djm@
738 - markus@cvs.openbsd.org 2008/07/10 18:08:11
739 [clientloop.c monitor.c monitor_wrap.c packet.c packet.h sshd.c]
740 sync v1 and v2 traffic accounting; add it to sshd, too;
744 - (djm) [Makefile.in] Print "all tests passed" when all regress tests pass
745 - (djm) [auth1.c] Fix format string vulnerability in protocol 1 PAM
746 account check failure path. The vulnerable format buffer is supplied
747 from PAM and should not contain attacker-supplied data.
748 - (djm) [auth.c] Missing unistd.h for close()
749 - (djm) [configure.ac] Add -Wformat-security to CFLAGS for gcc 3.x and 4.x
752 - (djm) [auth.c] Fixed test for locked account on HP/UX with shadowed
753 passwords disabled. bz#1083 report & patch from senthilkumar_sen AT
754 hotpop.com, w/ dtucker@
755 - (djm) [atomicio.c configure.ac] Disable poll() fallback in atomiciov for
756 Tru64. readv doesn't seem to be a comparable object there.
757 bz#1386, patch from dtucker@ ok me
758 - (djm) [Makefile.in] Pass though pass to conch for interop tests
759 - (djm) [configure.ac] unbreak: remove extra closing brace
760 - (djm) OpenBSD CVS Sync
761 - djm@cvs.openbsd.org 2008/07/04 23:08:25
763 handle EINTR in packet_write_poll()l ok dtucker@
764 - djm@cvs.openbsd.org 2008/07/04 23:30:16
766 Make protocol 1 MaxAuthTries logic match protocol 2's.
767 Do not treat the first protocol 2 authentication attempt as
768 a failure IFF it is for method "none".
769 Makes MaxAuthTries' user-visible behaviour identical for
772 - djm@cvs.openbsd.org 2008/07/05 05:16:01
777 - (dtucker) OpenBSD CVS Sync
778 - djm@cvs.openbsd.org 2008/07/02 13:30:34
780 really really remove the freebie "none" auth try for protocol 2
781 - djm@cvs.openbsd.org 2008/07/02 13:47:39
783 When forking after authentication ("ssh -f") with ExitOnForwardFailure
784 enabled, delay the fork until after replies for any -R forwards have
785 been seen. Allows for robust detection of -R forward failure when
786 using -f (similar to bz#92); ok dtucker@
787 - otto@cvs.openbsd.org 2008/07/03 21:46:58
789 avoid nasty double free; ok dtucker@ djm@
790 - djm@cvs.openbsd.org 2008/07/04 03:44:59
791 [servconf.c groupaccess.h groupaccess.c]
792 support negation of groups in "Match group" block (bz#1315); ok dtucker@
793 - dtucker@cvs.openbsd.org 2008/07/04 03:47:02
795 Make debug a little clearer. ok djm@
796 - djm@cvs.openbsd.org 2008/06/30 08:07:34
797 [regress/key-options.sh]
798 shell portability: use "=" instead of "==" in test(1) expressions,
799 double-quote string with backslash escaped /
800 - djm@cvs.openbsd.org 2008/06/30 10:31:11
801 [regress/{putty-transfer,putty-kex,putty-ciphers}.sh]
802 remove "set -e" left over from debugging
803 - djm@cvs.openbsd.org 2008/06/30 10:43:03
804 [regress/conch-ciphers.sh]
805 explicitly disable conch options that could interfere with the test
806 - (dtucker) [sftp-server.c] Bug #1447: fall back to racy rename if link
807 returns EXDEV. Patch from Mike Garrison, ok djm@
808 - (djm) [atomicio.c channels.c clientloop.c defines.h includes.h]
809 [packet.c scp.c serverloop.c sftp-client.c ssh-agent.c ssh-keyscan.c]
810 [sshd.c] Explicitly handle EWOULDBLOCK wherever we handle EAGAIN, on
811 some platforms (HP nonstop) it is a distinct errno;
812 bz#1467 reported by sconeu AT yahoo.com; ok dtucker@
815 - (dtucker) OpenBSD CVS Sync
816 - djm@cvs.openbsd.org 2008/06/30 08:05:59
818 typo: s/constraint_date/constraint_data/
819 - djm@cvs.openbsd.org 2008/06/30 12:15:39
821 only pass channel requests on session channels through to the session
822 channel handler, avoiding spurious log messages; ok! markus@
823 - djm@cvs.openbsd.org 2008/06/30 12:16:02
825 only send eow@openssh.com notifications for session channels; ok! markus@
826 - djm@cvs.openbsd.org 2008/06/30 12:18:34
828 clarify that eow@openssh.com is only sent on session channels
829 - dtucker@cvs.openbsd.org 2008/07/01 07:20:52
831 Check ExitOnForwardFailure if forwardings are disabled due to a failed
832 host key check. ok djm@
833 - dtucker@cvs.openbsd.org 2008/07/01 07:24:22
834 [sshconnect.c sshd.c]
835 Send CR LF during protocol banner exchanges, but only for Protocol 2 only,
836 in order to comply with RFC 4253. bz #1443, ok djm@
837 - stevesk@cvs.openbsd.org 2008/07/01 23:12:47
839 fix some typos; ok djm@
840 - djm@cvs.openbsd.org 2008/07/02 02:24:18
841 [sshd_config sshd_config.5 sshd.8 servconf.c]
842 increase default size of ssh protocol 1 ephemeral key from 768 to 1024
843 bits; prodded by & ok dtucker@ ok deraadt@
844 - dtucker@cvs.openbsd.org 2008/07/02 12:03:51
845 [auth-rsa.c auth.c auth2-pubkey.c auth.h]
846 Merge duplicate host key file checks, based in part on a patch from Rob
847 Holland via bz #1348 . Also checks for non-regular files during protocol
849 - djm@cvs.openbsd.org 2008/07/02 12:36:39
850 [auth2-none.c auth2.c]
851 Make protocol 2 MaxAuthTries behaviour a little more sensible:
852 Check whether client has exceeded MaxAuthTries before running
853 an authentication method and skip it if they have, previously it
854 would always allow one try (for "none" auth).
855 Preincrement failure count before post-auth test - previously this
856 checked and postincremented, also to allow one "none" try.
857 Together, these two changes always count the "none" auth method
858 which could be skipped by a malicious client (e.g. an SSH worm)
859 to get an extra attempt at a real auth method. They also make
860 MaxAuthTries=0 a useful way to block users entirely (esp. in a
861 sshd_config Match block).
862 Also, move sending of any preauth banner from "none" auth method
863 to the first call to input_userauth_request(), so worms that skip
864 the "none" method get to see it too.
867 - (djm) OpenBSD CVS Sync
868 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
869 [regress/Makefile regress/key-options.sh]
870 Add regress test for key options. ok djm@
871 - dtucker@cvs.openbsd.org 2008/06/11 23:11:40
873 Don't run cipher-speed test by default; mistakenly enabled by me
874 - djm@cvs.openbsd.org 2008/06/28 13:57:25
875 [regress/Makefile regress/test-exec.sh regress/conch-ciphers.sh]
876 very basic regress test against Twisted Conch in "make interop"
877 target (conch is available in ports/devel/py-twisted/conch);
879 - (djm) [regress/Makefile] search for conch by path, like we do putty
882 - (djm) OpenBSD CVS Sync
883 - martynas@cvs.openbsd.org 2008/06/21 07:46:46
885 use optopt to get invalid flag, instead of return value of getopt,
886 which is always '?'; ok djm@
887 - otto@cvs.openbsd.org 2008/06/25 11:13:43
889 add key length to visual fingerprint; zap magical constants;
891 - djm@cvs.openbsd.org 2008/06/26 06:10:09
892 [sftp-client.c sftp-server.c]
893 allow the sftp chmod(2)-equivalent operation to set set[ug]id/sticky
894 bits. Note that this only affects explicit setting of modes (e.g. via
895 sftp(1)'s chmod command) and not file transfers. (bz#1310)
897 - djm@cvs.openbsd.org 2008/06/26 09:19:40
899 when loading moduli from /etc/moduli in sshd(8), check that they
900 are of the expected "safe prime" structure and have had
901 appropriate primality tests performed;
902 feedback and ok dtucker@
903 - grunk@cvs.openbsd.org 2008/06/26 11:46:31
904 [readconf.c readconf.h ssh.1 ssh_config.5 sshconnect.c]
905 Move SSH Fingerprint Visualization away from sharing the config option
906 CheckHostIP to an own config option named VisualHostKey.
907 While there, fix the behaviour that ssh would draw a random art picture
908 on every newly seen host even when the option was not enabled.
909 prodded by deraadt@, discussions,
910 help and ok markus@ djm@ dtucker@
911 - jmc@cvs.openbsd.org 2008/06/26 21:11:46
913 add VisualHostKey to the list of options listed in -o;
914 - djm@cvs.openbsd.org 2008/06/28 07:25:07
917 - djm@cvs.openbsd.org 2008/06/28 13:58:23
919 refuse to add a key that has unknown constraints specified;
921 - djm@cvs.openbsd.org 2008/06/28 14:05:15
923 reset global compat flag after processing a protocol 2 signature
924 request with the legacy DSA encoding flag set; ok markus
925 - djm@cvs.openbsd.org 2008/06/28 14:08:30
926 [PROTOCOL PROTOCOL.agent]
927 document the protocol used by ssh-agent; "looks ok" markus@
930 - (djm) [RFC.nroff contrib/cygwin/Makefile contrib/suse/openssh.spec]
931 RFC.nroff lacks a license, remove it (it is long gone in OpenBSD).
934 - (djm) [Makefile.in moduli.5] Include moduli(5) manpage from OpenBSD.
936 - (djm) [ contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
937 [contrib/suse/openssh.spec] Include moduli.5 in RPM spec files.
940 - (dtucker) OpenBSD CVS Sync
941 - dtucker@cvs.openbsd.org 2008/06/16 13:22:53
942 [session.c channels.c]
943 Rename the isatty argument to is_tty so we don't shadow
944 isatty(3). ok markus@
945 - (dtucker) [channels.c] isatty -> is_tty here too.
948 - (dtucker) [configure.ac] Enable -fno-builtin-memset when using gcc.
950 - dtucker@cvs.openbsd.org 2008/06/14 15:49:48
952 wrap long line at 80 chars
953 - dtucker@cvs.openbsd.org 2008/06/14 17:07:11
955 ensure default umask disallows at least group and world write; ok djm@
956 - djm@cvs.openbsd.org 2008/06/14 18:33:43
958 suppress the warning message from chdir(homedir) failures
959 when chrooted (bz#1461); ok dtucker
960 - dtucker@cvs.openbsd.org 2008/06/14 19:42:10
962 Mention that scp follows symlinks during -r. bz #1466,
964 - dtucker@cvs.openbsd.org 2008/06/15 16:55:38
966 MaxSessions is allowed in a Match block too
967 - dtucker@cvs.openbsd.org 2008/06/15 16:58:40
968 [servconf.c sshd_config.5]
969 Allow MaxAuthTries within a Match block. ok djm@
970 - djm@cvs.openbsd.org 2008/06/15 20:06:26
971 [channels.c channels.h session.c]
972 don't call isatty() on a pty master, instead pass a flag down to
973 channel_set_fds() indicating that te fds refer to a tty. Fixes a
974 hang on exit on Solaris (bz#1463) in portable but is actually
975 a generic bug; ok dtucker deraadt markus
978 - (djm) [openbsd-compat/sigact.c] Avoid NULL derefs in ancient sigaction
979 replacement code; patch from ighighi AT gmail.com in bz#1240;
983 - (dtucker) OpenBSD CVS Sync
984 - deraadt@cvs.openbsd.org 2008/06/13 09:44:36
986 compile on older gcc; no decl after code
987 - dtucker@cvs.openbsd.org 2008/06/13 13:56:59
989 Clear key options in the monitor on failed authentication, prevents
990 applying additional restrictions to non-pubkey authentications in
991 the case where pubkey fails but another method subsequently succeeds.
992 bz #1472, found by Colin Watson, ok markus@ djm@
993 - dtucker@cvs.openbsd.org 2008/06/13 14:18:51
994 [auth2-pubkey.c auth-rhosts.c]
995 Include unistd.h for close(), prevents warnings in -portable
996 - dtucker@cvs.openbsd.org 2008/06/13 17:21:20
998 Friendlier error messages for mux fallback. ok djm@
999 - dtucker@cvs.openbsd.org 2008/06/13 18:55:22
1001 Prevent -Wsign-compare warnings on LP64 systems. bz #1192, ok deraadt@
1002 - grunk@cvs.openbsd.org 2008/06/13 20:13:26
1004 Explain the use of SSH fpr visualization using random art, and cite the
1005 original scientific paper inspiring that technique.
1006 Much help with English and nroff by jmc@, thanks.
1007 - (dtucker) [configure.ac] Bug #1276: avoid linking against libgssapi, which
1008 despite its name doesn't seem to implement all of GSSAPI. Patch from
1009 Jan Engelhardt, sanity checked by Simon Wilkinson.
1012 - (dtucker) OpenBSD CVS Sync
1013 - jmc@cvs.openbsd.org 2008/06/11 07:30:37
1015 kill trailing whitespace;
1016 - grunk@cvs.openbsd.org 2008/06/11 21:01:35
1017 [ssh_config.5 key.h readconf.c readconf.h ssh-keygen.1 ssh-keygen.c key.c
1019 Introduce SSH Fingerprint ASCII Visualization, a technique inspired by the
1020 graphical hash visualization schemes known as "random art", and by
1021 Dan Kaminsky's musings on the subject during a BlackOp talk at the
1023 Scientific publication (original paper):
1024 "Hash Visualization: a New Technique to improve Real-World Security",
1025 Perrig A. and Song D., 1999, International Workshop on Cryptographic
1026 Techniques and E-Commerce (CrypTEC '99)
1027 http://sparrow.ece.cmu.edu/~adrian/projects/validation/validation.pdf
1028 The algorithm used here is a worm crawling over a discrete plane,
1029 leaving a trace (augmenting the field) everywhere it goes.
1030 Movement is taken from dgst_raw 2bit-wise. Bumping into walls
1031 makes the respective movement vector be ignored for this turn,
1032 thus switching to the other color of the chessboard.
1033 Graphs are not unambiguous for now, because circles in graphs can be
1034 walked in either direction.
1035 discussions with several people,
1036 help, corrections and ok markus@ djm@
1037 - grunk@cvs.openbsd.org 2008/06/11 21:38:25
1039 ssh-keygen -lv -f /etc/ssh/ssh_host_rsa_key.pub
1040 would not display you the random art as intended, spotted by canacar@
1041 - grunk@cvs.openbsd.org 2008/06/11 22:20:46
1042 [ssh-keygen.c ssh-keygen.1]
1043 ssh-keygen would write fingerprints to STDOUT, and random art to STDERR,
1044 that is not how it was envisioned.
1045 Also correct manpage saying that -v is needed along with -l for it to work.
1047 - otto@cvs.openbsd.org 2008/06/11 23:02:22
1049 simpler way of computing the augmentations; ok grunk@
1050 - grunk@cvs.openbsd.org 2008/06/11 23:03:56
1052 CheckHostIP set to ``fingerprint'' will display both hex and random art
1054 - grunk@cvs.openbsd.org 2008/06/11 23:51:57
1056 #define statements that are not atoms need braces around them, else they
1057 will cause trouble in some cases.
1058 Also do a computation of -1 once, and not in a loop several times.
1060 - dtucker@cvs.openbsd.org 2008/06/12 00:03:49
1061 [dns.c canohost.c sshconnect.c]
1062 Do not pass "0" strings as ports to getaddrinfo because the lookups
1063 can slow things down and we never use the service info anyway. bz
1064 #859, patch from YOSHIFUJI Hideaki and John Devitofranceschi. ok
1066 djm belives that the reason for the "0" strings is to ensure that
1067 it's not possible to call getaddrinfo with both host and port being
1068 NULL. In the case of canohost.c host is a local array. In the
1069 case of sshconnect.c, it's checked for null immediately before use.
1070 In dns.c it ultimately comes from ssh.c:main() and is guaranteed to
1071 be non-null but it's not obvious, so I added a warning message in
1072 case it is ever passed a null.
1073 - grunk@cvs.openbsd.org 2008/06/12 00:13:55
1075 Make ssh print the random art also when ssh'ing to a host using IP only.
1076 spotted by naddy@, ok and help djm@ dtucker@
1077 - otto@cvs.openbsd.org 2008/06/12 00:13:13
1079 use an odd number of rows and columns and a separate start marker, looks
1081 - djm@cvs.openbsd.org 2008/06/12 03:40:52
1082 [clientloop.h mux.c channels.c clientloop.c channels.h]
1083 Enable ~ escapes for multiplex slave sessions; give each channel
1084 its own escape state and hook the escape filters up to muxed
1086 Mux slaves do not currently support the ~^Z and ~& escapes.
1087 NB. this change cranks the mux protocol version, so a new ssh
1088 mux client will not be able to connect to a running old ssh
1091 - djm@cvs.openbsd.org 2008/06/12 04:06:00
1092 [clientloop.h ssh.c clientloop.c]
1093 maintain an ordered queue of outstanding global requests that we
1094 expect replies to, similar to the per-channel confirmation queue.
1095 Use this queue to verify success or failure for remote forward
1096 establishment in a race free way.
1098 - djm@cvs.openbsd.org 2008/06/12 04:17:47
1100 thall shalt not code past the eightieth column
1101 - djm@cvs.openbsd.org 2008/06/12 04:24:06
1103 thal shalt not code past the eightieth column
1104 - djm@cvs.openbsd.org 2008/06/12 05:15:41
1106 document tun@openssh.com forwarding method
1107 - djm@cvs.openbsd.org 2008/06/12 05:32:30
1109 some more TODO for me
1110 - grunk@cvs.openbsd.org 2008/06/12 05:42:46
1112 supply the key type (rsa1, rsa, dsa) as a caption in the frame of the
1113 random art. while there, stress the fact that the field base should at
1114 least be 8 characters for the pictures to make sense.
1116 - grunk@cvs.openbsd.org 2008/06/12 06:32:59
1118 We already mark the start of the worm, now also mark the end of the worm
1119 in our random art drawings.
1121 - djm@cvs.openbsd.org 2008/06/12 15:19:17
1122 [clientloop.h channels.h clientloop.c channels.c mux.c]
1123 The multiplexing escape char handler commit last night introduced a
1124 small memory leak per session; plug it.
1125 - dtucker@cvs.openbsd.org 2008/06/12 16:35:31
1126 [ssh_config.5 ssh.c]
1127 keyword expansion for localcommand. ok djm@
1128 - jmc@cvs.openbsd.org 2008/06/12 19:10:09
1129 [ssh_config.5 ssh-keygen.1]
1130 tweak the ascii art text; ok grunk
1131 - dtucker@cvs.openbsd.org 2008/06/12 20:38:28
1132 [sshd.c sshconnect.c packet.h misc.c misc.h packet.c]
1133 Make keepalive timeouts apply while waiting for a packet, particularly
1134 during key renegotiation (bz #1363). With djm and Matt Day, ok djm@
1135 - djm@cvs.openbsd.org 2008/06/12 20:47:04
1137 print extension revisions for extensions that we understand
1138 - djm@cvs.openbsd.org 2008/06/12 21:06:25
1140 I was coalescing expected global request confirmation replies at
1141 the wrong end of the queue - fix; prompted by markus@
1142 - grunk@cvs.openbsd.org 2008/06/12 21:14:46
1144 make ssh-keygen -lf show the key type just as ssh-add -l would do it
1146 - grunk@cvs.openbsd.org 2008/06/12 22:03:36
1148 add my copyright, ok djm@
1149 - ian@cvs.openbsd.org 2008/06/12 23:24:58
1151 tweak wording in message, ok deraadt@ jmc@
1152 - dtucker@cvs.openbsd.org 2008/06/13 00:12:02
1154 replace __dead with __attribute__((noreturn)), makes things
1155 a little easier to port. Also, add it to sigdie(). ok djm@
1156 - djm@cvs.openbsd.org 2008/06/13 00:16:49
1158 fall back to creating a new TCP connection on most multiplexing errors
1159 (socket connect fail, invalid version, refused permittion, corrupted
1160 messages, etc.); bz #1329 ok dtucker@
1161 - dtucker@cvs.openbsd.org 2008/06/13 00:47:53
1163 upcast size_t to u_long to match format arg; ok djm@
1164 - dtucker@cvs.openbsd.org 2008/06/13 00:51:47
1166 upcast another size_t to u_long to match format
1167 - dtucker@cvs.openbsd.org 2008/06/13 01:38:23
1169 upcast uid to long with matching %ld, prevents warnings in portable
1170 - djm@cvs.openbsd.org 2008/06/13 04:40:22
1171 [auth2-pubkey.c auth-rhosts.c]
1172 refuse to read ~/.shosts or ~/.ssh/authorized_keys that are not
1173 regular files; report from Solar Designer via Colin Watson in bz#1471
1175 - (dtucker) [clientloop.c serverloop.c] channel_register_filter now
1176 takes 2 more args. with djm@
1177 - (dtucker) [defines.h] Bug #1112: __dead is, well dead. Based on a patch
1179 - (dtucker) [auth-sia.c] Bug #1241: support password expiry on Tru64 SIA
1180 systems. Patch from R. Scott Bailey.
1181 - (dtucker) [umac.c] STORE_UINT32_REVERSED and endian_convert are never used
1182 on big endian machines, so ifdef them for little-endian only to prevent
1183 unused function warnings on big-endians.
1184 - (dtucker) [openbsd-compat/setenv.c] Make offsets size_t to prevent
1185 compiler warnings on some platforms. Based on a discussion with otto@
1188 - (djm) [channels.c configure.ac]
1189 Do not set SO_REUSEADDR on wildcard X11 listeners (X11UseLocalhost=no)
1193 - (dtucker) OpenBSD CVS Sync
1194 - djm@cvs.openbsd.org 2008/06/10 03:57:27
1195 [servconf.c match.h sshd_config.5]
1196 support CIDR address matching in sshd_config "Match address" blocks, with
1197 full support for negation and fall-back to classic wildcard matching.
1199 Match address 192.0.2.0/24,3ffe:ffff::/32,!10.*
1200 PasswordAuthentication yes
1201 addrmatch.c code mostly lifted from flowd's addr.c
1202 feedback and ok dtucker@
1203 - djm@cvs.openbsd.org 2008/06/10 04:17:46
1205 better reference for pattern-list
1206 - dtucker@cvs.openbsd.org 2008/06/10 04:50:25
1207 [sshd.c channels.h channels.c log.c servconf.c log.h servconf.h sshd.8]
1208 Add extended test mode (-T) and connection parameters for test mode (-C).
1209 -T causes sshd to write its effective configuration to stdout and exit.
1210 -C causes any relevant Match rules to be applied before output. The
1211 combination allows tesing of the parser and config files. ok deraadt djm
1212 - jmc@cvs.openbsd.org 2008/06/10 07:12:00
1215 - jmc@cvs.openbsd.org 2008/06/10 08:17:40
1218 - fix SYNOPSIS, and sort options
1219 - some minor additional fixes
1220 - dtucker@cvs.openbsd.org 2008/06/09 18:06:32
1221 [regress/test-exec.sh]
1222 Don't generate putty keys if we're not going to use them. ok djm
1223 - dtucker@cvs.openbsd.org 2008/06/10 05:23:32
1224 [regress/addrmatch.sh regress/Makefile]
1225 Regress test for Match CIDR rules. ok djm@
1226 - dtucker@cvs.openbsd.org 2008/06/10 15:21:41
1228 Use a more portable construct for checking if we're running a putty test
1229 - dtucker@cvs.openbsd.org 2008/06/10 15:28:49
1232 - dtucker@cvs.openbsd.org 2008/06/10 18:21:24
1234 clarify that Host patterns are space-separated. ok deraadt
1235 - djm@cvs.openbsd.org 2008/06/10 22:15:23
1236 [PROTOCOL ssh.c serverloop.c]
1237 Add a no-more-sessions@openssh.com global request extension that the
1238 client sends when it knows that it will never request another session
1239 (i.e. when session multiplexing is disabled). This allows a server to
1240 disallow further session requests and terminate the session.
1241 Why would a non-multiplexing client ever issue additional session
1242 requests? It could have been attacked with something like SSH'jack:
1243 http://www.storm.net.nz/projects/7
1244 feedback & ok markus
1245 - djm@cvs.openbsd.org 2008/06/10 23:06:19
1246 [auth-options.c match.c servconf.c addrmatch.c sshd.8]
1247 support CIDR address matching in .ssh/authorized_keys from="..." stanzas
1248 ok and extensive testing dtucker@
1249 - dtucker@cvs.openbsd.org 2008/06/10 23:21:34
1251 Use '\0' for a nul byte rather than unadorned 0. ok djm@
1252 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
1253 [Makefile regress/key-options.sh]
1254 Add regress test for key options. ok djm@
1255 - (dtucker) [openbsd-compat/fake-rfc2553.h] Add sin6_scope_id to sockaddr_in6
1256 since the new CIDR code in addmatch.c references it.
1257 - (dtucker) [Makefile.in configure.ac regress/addrmatch.sh] Skip IPv6
1258 specific tests on platforms that don't do IPv6.
1259 - (dtucker) [Makefile.in] Define TEST_SSH_IPV6 in make's arguments as well
1261 - (dtucker) [Makefile.in] Move addrmatch.o to libssh.a where it's needed now.
1264 - (dtucker) OpenBSD CVS Sync
1265 - dtucker@cvs.openbsd.org 2008/06/08 17:04:41
1267 Add case for ENOSYS in errno_to_portable; ok deraadt
1268 - dtucker@cvs.openbsd.org 2008/06/08 20:15:29
1269 [sftp.c sftp-client.c sftp-client.h]
1270 Have the sftp client store the statvfs replies in wire format,
1271 which prevents problems when the server's native sizes exceed the
1273 Also extends the sizes of the remaining 32bit wire format to 64bit,
1274 they're specified as unsigned long in the standard.
1275 - dtucker@cvs.openbsd.org 2008/06/09 13:02:39
1277 Extend 32bit -> 64bit values for statvfs extension missed in previous
1279 - dtucker@cvs.openbsd.org 2008/06/09 13:38:46
1281 Use a $OpenBSD tag so our scripts will sync changes.
1284 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c
1285 openbsd-compat/Makefile.in openbsd-compat/openbsd-compat.h
1286 openbsd-compat/bsd-statvfs.{c,h}] Add a null implementation of statvfs and
1287 fstatvfs and remove #defines around statvfs code. ok djm@
1288 - (dtucker) [configure.ac defines.h sftp-client.c M sftp-server.c] Add a
1289 macro to convert fsid to unsigned long for platforms where fsid is a
1293 - (dtucker) [mux.c] Include paths.h inside ifdef HAVE_PATHS_H.
1294 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c]
1295 Do not enable statvfs extensions on platforms that do not have statvfs.
1296 - (dtucker) OpenBSD CVS Sync
1297 - djm@cvs.openbsd.org 2008/05/19 06:14:02
1298 [packet.c] unbreak protocol keepalive timeouts bz#1465; ok dtucker@
1299 - djm@cvs.openbsd.org 2008/05/19 15:45:07
1300 [sshtty.c ttymodes.c sshpty.h]
1301 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1302 we would send the modes corresponding to a zeroed struct termios,
1303 whereas we should have been sending an empty list of modes.
1304 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1305 - djm@cvs.openbsd.org 2008/05/19 15:46:31
1307 support -l (print fingerprint) in combination with -F (find host) to
1308 search for a host in ~/.ssh/known_hosts and display its fingerprint;
1310 - djm@cvs.openbsd.org 2008/05/19 20:53:52
1312 unbreak tree by committing this bit that I missed from:
1313 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1314 we would send the modes corresponding to a zeroed struct termios,
1315 whereas we should have been sending an empty list of modes.
1316 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1319 - (djm) [openbsd-compat/bsd-arc4random.c] Fix math bug that caused bias
1320 in arc4random_uniform with upper_bound in (2^30,2*31). Note that
1321 OpenSSH did not make requests with upper bounds in this range.
1324 - (djm) [configure.ac mux.c sftp.c openbsd-compat/Makefile.in]
1325 [openbsd-compat/fmt_scaled.c openbsd-compat/openbsd-compat.h]
1326 Fix compilation on Linux, including pulling in fmt_scaled(3)
1327 implementation from OpenBSD's libutil.
1330 - (djm) OpenBSD CVS Sync
1331 - djm@cvs.openbsd.org 2008/04/04 05:14:38
1333 ChrootDirectory is supported in Match blocks (in fact, it is most useful
1334 there). Spotted by Minstrel AT minstrel.org.uk
1335 - djm@cvs.openbsd.org 2008/04/04 06:44:26
1337 oops, some unrelated stuff crept into that commit - backout.
1339 - djm@cvs.openbsd.org 2008/04/05 02:46:02
1341 HostbasedAuthentication is supported under Match too
1342 - (djm) [openbsd-compat/bsd-arc4random.c openbsd-compat/openbsd-compat.c]
1343 [configure.ac] Implement arc4random_buf(), import implementation of
1344 arc4random_uniform() from OpenBSD
1345 - (djm) [openbsd-compat/bsd-arc4random.c] Warning fixes
1346 - (djm) [openbsd-compat/port-tun.c] needs sys/queue.h
1347 - (djm) OpenBSD CVS Sync
1348 - djm@cvs.openbsd.org 2008/04/13 00:22:17
1350 Use arc4random_buf() when requesting more than a single word of output
1351 Use arc4random_uniform() when the desired random number upper bound
1352 is not a power of two
1353 ok deraadt@ millert@
1354 - djm@cvs.openbsd.org 2008/04/18 12:32:11
1355 [sftp-client.c sftp-client.h sftp-server.c sftp.1 sftp.c sftp.h]
1356 introduce sftp extension methods statvfs@openssh.com and
1357 fstatvfs@openssh.com that implement statvfs(2)-like operations,
1358 based on a patch from miklos AT szeredi.hu (bz#1399)
1359 also add a "df" command to the sftp client that uses the
1360 statvfs@openssh.com to produce a df(1)-like display of filesystem
1361 space and inode utilisation
1363 - jmc@cvs.openbsd.org 2008/04/18 17:15:47
1366 - djm@cvs.openbsd.org 2008/04/18 22:01:33
1368 remove unneccessary parentheses
1369 - otto@cvs.openbsd.org 2008/04/29 11:20:31
1371 garbage collect two unused fields in struct mm_master; ok markus@
1372 - djm@cvs.openbsd.org 2008/04/30 10:14:03
1373 [ssh-keyscan.1 ssh-keyscan.c]
1374 default to rsa (protocol 2) keys, instead of rsa1 keys; spotted by
1375 larsnooden AT openoffice.org
1376 - pyr@cvs.openbsd.org 2008/05/07 05:49:37
1377 [servconf.c servconf.h session.c sshd_config.5]
1378 Enable the AllowAgentForwarding option in sshd_config (global and match
1379 context), to specify if agents should be permitted on the server.
1380 As the man page states:
1381 ``Note that disabling Agent forwarding does not improve security
1382 unless users are also denied shell access, as they can always install
1383 their own forwarders.''
1384 ok djm@, ok and a mild frown markus@
1385 - pyr@cvs.openbsd.org 2008/05/07 06:43:35
1387 push the sshd_config bits in, spotted by ajacoutot@
1388 - jmc@cvs.openbsd.org 2008/05/07 08:00:14
1391 - markus@cvs.openbsd.org 2008/05/08 06:59:01
1392 [bufaux.c buffer.h channels.c packet.c packet.h]
1393 avoid extra malloc/copy/free when receiving data over the net;
1394 ~10% speedup for localhost-scp; ok djm@
1395 - djm@cvs.openbsd.org 2008/05/08 12:02:23
1396 [auth-options.c auth1.c channels.c channels.h clientloop.c gss-serv.c]
1397 [monitor.c monitor_wrap.c nchan.c servconf.c serverloop.c session.c]
1399 Implement a channel success/failure status confirmation callback
1400 mechanism. Each channel maintains a queue of callbacks, which will
1401 be drained in order (RFC4253 guarantees confirm messages are not
1402 reordered within an channel).
1403 Also includes a abandonment callback to clean up if a channel is
1404 closed without sending confirmation messages. This probably
1405 shouldn't happen in compliant implementations, but it could be
1406 abused to leak memory.
1407 ok markus@ (as part of a larger diff)
1408 - djm@cvs.openbsd.org 2008/05/08 12:21:16
1409 [monitor.c monitor_wrap.c session.h servconf.c servconf.h session.c]
1410 [sshd_config sshd_config.5]
1411 Make the maximum number of sessions run-time controllable via
1412 a sshd_config MaxSessions knob. This is useful for disabling
1413 login/shell/subsystem access while leaving port-forwarding working
1414 (MaxSessions 0), disabling connection multiplexing (MaxSessions 1) or
1415 simply increasing the number of allows multiplexed sessions.
1416 Because some bozos are sure to configure MaxSessions in excess of the
1417 number of available file descriptors in sshd (which, at peak, might be
1418 as many as 9*MaxSessions), audit sshd to ensure that it doesn't leak fds
1419 on error paths, and make it fail gracefully on out-of-fd conditions -
1420 sending channel errors instead of than exiting with fatal().
1421 bz#1090; MaxSessions config bits and manpage from junyer AT gmail.com
1423 - djm@cvs.openbsd.org 2008/05/08 13:06:11
1424 [clientloop.c clientloop.h ssh.c]
1425 Use new channel status confirmation callback system to properly deal
1426 with "important" channel requests that fail, in particular command exec,
1427 shell and subsystem requests. Previously we would optimistically assume
1428 that the requests would always succeed, which could cause hangs if they
1429 did not (e.g. when the server runs out of fds) or were unimplemented by
1430 the server (bz #1384)
1431 Also, properly report failing multiplex channel requests via the mux
1432 client stderr (subject to LogLevel in the mux master) - better than
1434 most bits ok markus@ (as part of a larger diff)
1435 - djm@cvs.openbsd.org 2008/05/09 04:55:56
1436 [channels.c channels.h clientloop.c serverloop.c]
1437 Try additional addresses when connecting to a port forward destination
1438 whose DNS name resolves to more than one address. The previous behaviour
1439 was to try the first address and give up.
1440 Reported by stig AT venaas.com in bz#343
1441 great feedback and ok markus@
1442 - djm@cvs.openbsd.org 2008/05/09 14:18:44
1443 [clientloop.c clientloop.h ssh.c mux.c]
1444 tidy up session multiplexing code, moving it into its own file and
1445 making the function names more consistent - making ssh.c and
1446 clientloop.c a fair bit more readable.
1448 - djm@cvs.openbsd.org 2008/05/09 14:26:08
1450 dingo stole my diff hunk
1451 - markus@cvs.openbsd.org 2008/05/09 16:16:06
1453 re-add the USE_PIPES code and enable it.
1454 without pipes shutdown-read from the sshd does not trigger
1455 a SIGPIPE when the forked program does a write.
1457 (Id sync only, USE_PIPES never left portable OpenSSH)
1458 - markus@cvs.openbsd.org 2008/05/09 16:17:51
1460 error-fd race: don't enable the error fd in the select bitmask
1461 for channels with both in- and output closed, since the channel
1462 will go away before we call select();
1463 report, lots of debugging help and ok djm@
1464 - markus@cvs.openbsd.org 2008/05/09 16:21:13
1465 [channels.h clientloop.c nchan.c serverloop.c]
1467 ssh -2 localhost od /bin/ls | true
1468 ignoring SIGPIPE by adding a new channel message (EOW) that signals
1469 the peer that we're not interested in any data it might send.
1470 fixes bz #85; discussion, debugging and ok djm@
1471 - pvalchev@cvs.openbsd.org 2008/05/12 20:52:20
1473 Ensure nh_result lies on a 64-bit boundary (fixes warnings observed
1474 on Itanium on Linux); from Dale Talcott (bug #1462); ok djm@
1475 - djm@cvs.openbsd.org 2008/05/15 23:52:24
1477 document eow message in ssh protocol 2 channel state machine;
1478 feedback and ok markus@
1479 - djm@cvs.openbsd.org 2008/05/18 21:29:05
1481 comment extension announcement
1482 - djm@cvs.openbsd.org 2008/05/16 08:30:42
1484 document our protocol extensions and deviations; ok markus@
1485 - djm@cvs.openbsd.org 2008/05/17 01:31:56
1487 grammar and correctness fixes from stevesk@
1490 - (djm) [openbsd-compat/bsd-poll.c] Include stdlib.h to avoid compile-
1491 time warnings on LynxOS. Patch from ops AT iki.fi
1492 - (djm) Force string arguments to replacement setproctitle() though
1493 strnvis first. Ok dtucker@
1496 - (djm) OpenBSD CVS sync:
1497 - markus@cvs.openbsd.org 2008/04/02 15:36:51
1499 avoid possible hijacking of x11-forwarded connections (back out 1.183)
1500 CVE-2008-1483; ok djm@
1501 - jmc@cvs.openbsd.org 2008/03/27 22:37:57
1503 remove trailing whitespace;
1504 - djm@cvs.openbsd.org 2008/04/03 09:50:14
1507 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
1508 [contrib/suse/openssh.spec] Crank version numbers in RPM spec files
1509 - (djm) [README] Update link to release notes
1510 - (djm) Release 5.0p1