2 - (dtucker) OpenBSD CVS Sync
3 - markus@cvs.openbsd.org 2009/03/17 21:37:00
5 pass correct argv[0] to openlog(); ok djm@
6 - jmc@cvs.openbsd.org 2009/03/19 15:15:09
8 for "Ciphers", just point the reader to the keyword in ssh_config(5), just
9 as we do for "MACs": this stops us getting out of sync when the lists
11 fixes documentation/6102, submitted by Peter J. Philipp
12 alternative fix proposed by djm
14 - tobias@cvs.openbsd.org 2009/03/23 08:31:19
16 Fixed a possible out-of-bounds memory access if the environment variable
17 SHELL is shorter than 3 characters.
18 with input by and ok dtucker
19 - tobias@cvs.openbsd.org 2009/03/23 19:38:04
21 My previous commit didn't fix the problem at all, so stick at my first
22 version of the fix presented to dtucker.
23 Issue notified by Matthias Barkhoff (matthias dot barkhoff at gmx dot de).
25 - sobrado@cvs.openbsd.org 2009/03/26 08:38:39
26 [sftp-server.8 sshd.8 ssh-agent.1]
27 fix a few typographical errors found by spell(1).
29 - stevesk@cvs.openbsd.org 2009/04/13 19:07:44
31 fix possessive; ok djm@
32 - stevesk@cvs.openbsd.org 2009/04/14 16:33:42
34 remove unused option character from getopt() optstring; ok markus@
35 - jj@cvs.openbsd.org 2009/04/14 21:10:54
37 Fixed a few the-the misspellings in comments. Skipped a bunch in
38 binutils,gcc and so on. ok jmc@
39 - stevesk@cvs.openbsd.org 2009/04/17 19:23:06
41 use INTERNAL_SFTP_NAME for setproctitle() of in-process sftp-server;
43 - stevesk@cvs.openbsd.org 2009/04/17 19:40:17
45 clarify that even internal-sftp needs /dev/log for logging to work; ok
47 - jmc@cvs.openbsd.org 2009/04/18 18:39:10
49 tweak previous; ok stevesk
50 - stevesk@cvs.openbsd.org 2009/04/21 15:13:17
52 clarify we cd to user's home after chroot; ok markus@ on
53 earlier version; tweaks and ok jmc@
54 - andreas@cvs.openbsd.org 2009/05/25 06:48:01
55 [channels.c packet.c clientloop.c packet.h serverloop.c monitor_wrap.c
57 Put the globals in packet.c into a struct and don't access it directly
58 from other files. No functional changes.
60 - andreas@cvs.openbsd.org 2009/05/27 06:31:25
61 [canohost.h canohost.c]
62 Add clear_cached_addr(), needed for upcoming changes allowing the peer
65 - andreas@cvs.openbsd.org 2009/05/27 06:33:39
67 Send SSH2_MSG_DISCONNECT when the client disconnects. From a larger
68 change from Martin Forssen, maf at appgate dot com.
70 - andreas@cvs.openbsd.org 2009/05/27 06:34:36
72 Move the KEX_COOKIE_LEN define to kex.h
74 - andreas@cvs.openbsd.org 2009/05/27 06:36:07
76 Add packet_put_int64() and packet_get_int64(), part of a larger change
80 - (dtucker) [configure.ac defines.h] Bug #1607: handle the case where fsid_t
81 is a struct with a __val member. Fixes build on, eg, Redhat 6.2.
84 - (dtucker) [sshlogin.c] Move the NO_SSH_LASTLOG #ifndef line to include
85 variable declarations. Should prevent unused warnings anywhere it's set
86 (only Crays as far as I can tell) and be a no-op everywhere else.
89 - (tim) [configure.ac] Remove setting IP_TOS_IS_BROKEN for Cygwin. The problem
90 that setsockopt(IP_TOS) doesn't work on Cygwin has been fixed since 2005.
91 Based on patch from vinschen at redhat com.
94 - (dtucker) [auth-passwd.c auth1.c auth2-kbdint.c auth2-none.c auth2-passwd.c
95 auth2-pubkey.c session.c openbsd-compat/bsd-cygwin_util.{c,h}
96 openbsd-compat/daemon.c] Remove support for Windows 95/98/ME and very old
97 version of Cygwin. Patch from vinschen at redhat com.
100 - (dtucker) [contrib/aix/buildbff.sh] Only try to rename ssh_prng_cmds if it
101 exists (it's not created if OpenSSL's PRNG is self-seeded, eg if the OS
103 - (dtucker) [schnorr.c openbsd-compat/openssl-compat.{c,h}] Add
104 EVP_DigestUpdate to the OLD_EVP compatibility functions and tell schnorr.c
105 to use them. Allows building with older OpenSSL versions.
106 - (dtucker) [configure.ac defines.h] Check for in_port_t and typedef if needed.
107 - (dtucker) [configure.ac] Missing comma in type list.
108 - (dtucker) [configure.ac openbsd-compat/openssl-compat.{c,h}]
109 EVP_DigestUpdate does not exactly match the other OLD_EVP functions (eg
110 in openssl 0.9.6) so add an explicit test for it.
113 - (djm) OpenBSD CVS Sync
114 - djm@cvs.openbsd.org 2009/03/05 07:18:19
115 [auth2-jpake.c jpake.c jpake.h monitor_wrap.c monitor_wrap.h schnorr.c]
117 refactor the (disabled) Schnorr proof code to make it a little more
119 - djm@cvs.openbsd.org 2009/03/05 11:30:50
121 document what these functions do so I don't ever have to recuse into
122 b64_pton/ntop to remember their return values
125 - (djm) OpenBSD CVS Sync
126 - djm@cvs.openbsd.org 2009/02/22 23:50:57
127 [ssh_config.5 sshd_config.5]
128 don't advertise experimental options
129 - djm@cvs.openbsd.org 2009/02/22 23:59:25
132 - djm@cvs.openbsd.org 2009/02/23 00:06:15
135 - (djm) [README] update for 5.2
136 - (djm) Release openssh-5.2p1
139 - (djm) OpenBSD CVS Sync
140 - tobias@cvs.openbsd.org 2009/02/21 19:32:04
141 [misc.c sftp-server-main.c ssh-keygen.c]
142 Added missing newlines in error messages.
146 - (djm) OpenBSD CVS Sync
147 - djm@cvs.openbsd.org 2009/02/17 01:28:32
149 sync with revised default ciphers; pointed out by dkrause@
150 - djm@cvs.openbsd.org 2009/02/18 04:31:21
152 signature should hash over the entire group, not just the generator
153 (this is still disabled code)
154 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
155 [contrib/suse/openssh.spec] Prepare for 5.2p1
158 - (djm) [regress/conch-ciphers.sh regress/putty-ciphers.sh]
159 [regress/putty-kex.sh regress/putty-transfer.sh] Downgrade disabled
160 interop tests from FATAL error to a warning. Allows some interop
161 tests to proceed if others are missing necessary prerequisites.
162 - (djm) [configure.ac] support GNU/kFreeBSD and GNU/kOpensolaris
163 systems; patch from Aurelien Jarno via rmh AT aybabtu.com
166 - (djm) OpenBSD CVS Sync
167 - dtucker@cvs.openbsd.org 2009/02/02 11:15:14
169 Initialize a few variables to prevent spurious "may be used
170 uninitialized" warnings from newer gcc's. ok djm@
171 - djm@cvs.openbsd.org 2009/02/12 03:00:56
172 [canohost.c canohost.h channels.c channels.h clientloop.c readconf.c]
173 [readconf.h serverloop.c ssh.c]
174 support remote port forwarding with a zero listen port (-R0:...) to
175 dyamically allocate a listen port at runtime (this is actually
176 specified in rfc4254); bz#1003 ok markus@
177 - djm@cvs.openbsd.org 2009/02/12 03:16:01
179 tighten check for -R0:... forwarding: only allow dynamic allocation
180 if want_reply is set in the packet
181 - djm@cvs.openbsd.org 2009/02/12 03:26:22
183 some paranoia: check that the serialised key is really KEY_RSA before
184 diddling its internals
185 - djm@cvs.openbsd.org 2009/02/12 03:42:09
187 document -R0:... usage
188 - djm@cvs.openbsd.org 2009/02/12 03:44:25
190 consistency: Dq => Ql
191 - djm@cvs.openbsd.org 2009/02/12 03:46:17
193 document RemoteForward usage with 0 listen port
194 - jmc@cvs.openbsd.org 2009/02/12 07:34:20
196 kill trailing whitespace;
197 - markus@cvs.openbsd.org 2009/02/13 11:50:21
199 check for enc !=NULL in packet_start_discard
200 - djm@cvs.openbsd.org 2009/02/14 06:35:49
202 mention that eow and no-more-sessions extensions are sent only to
206 - (djm) [sshpty.c] bz#1419: OSX uses cloning ptys that automagically
207 set ownership and modes, so avoid explicitly setting them
208 - (djm) [configure.ac loginrec.c] bz#1421: fix lastlog support for OSX.
209 OSX provides a getlastlogxbyname function that automates the reading of
210 a lastlog file. Also, the pututxline function will update lastlog so
211 there is no need for loginrec.c to do it explicitly. Collapse some
212 overly verbose code while I'm in there.
215 - (dtucker) [defines.h sshconnect.c] INET6_ADDRSTRLEN is now needed in
216 channels.c too, so move the definition for non-IP6 platforms to defines.h
217 where it can be shared.
220 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
221 If the CYGWIN environment variable is empty, the installer script
222 should not install the service with an empty CYGWIN variable, but
223 rather without setting CYGWNI entirely.
224 - (tim) [contrib/cygwin/ssh-host-config] Whitespace cleanup. No code changes.
227 - (tim) [contrib/cygwin/ssh-host-config] Patch from Corinna Vinschen.
228 Changes to work on Cygwin 1.5.x as well as on the new Cygwin 1.7.x.
229 The information given for the setting of the CYGWIN environment variable
230 is wrong for both releases so I just removed it, together with the
231 unnecessary (Cygwin 1.5.x) or wrong (Cygwin 1.7.x) default setting.
234 - (djm) OpenBSD CVS Sync
235 - stevesk@cvs.openbsd.org 2008/12/09 03:20:42
236 [channels.c servconf.c]
237 channel_print_adm_permitted_opens() should deal with all the printing
238 for that config option. suggested by markus@; ok markus@ djm@
240 - djm@cvs.openbsd.org 2008/12/09 04:32:22
242 replace by-hand string building with xasprinf(); ok deraadt@
243 - sobrado@cvs.openbsd.org 2008/12/09 15:35:00
245 update for the synopses displayed by the 'help' command, there are a
246 few missing flags; add 'bye' to the output of 'help'; sorting and spacing.
247 jmc@ suggested replacing .Oo/.Oc with a single .Op macro.
249 - stevesk@cvs.openbsd.org 2008/12/09 22:37:33
251 fix typo in error message
252 - stevesk@cvs.openbsd.org 2008/12/10 03:55:20
254 o cannot be NULL here but use xfree() to be consistent; ok djm@
255 - stevesk@cvs.openbsd.org 2008/12/29 01:12:36
257 fix example, default key type is rsa for 3+ years; from
258 frederic.perrin@resel.fr
259 - stevesk@cvs.openbsd.org 2008/12/29 02:23:26
261 no need to escape single quotes in comments
262 - okan@cvs.openbsd.org 2008/12/30 00:46:56
264 add AllowAgentForwarding to available Match keywords list
266 - djm@cvs.openbsd.org 2009/01/01 21:14:35
268 call channel destroy callbacks on receipt of open failure messages.
269 fixes client hangs when connecting to a server that has MaxSessions=0
270 set spotted by imorgan AT nas.nasa.gov; ok markus@
271 - djm@cvs.openbsd.org 2009/01/01 21:17:36
273 fix hash calculation for KEXGEX: hash over the original client-supplied
274 values and not the sanity checked versions that we acutally use;
275 bz#1540 reported by john.smith AT arrows.demon.co.uk
277 - djm@cvs.openbsd.org 2009/01/14 01:38:06
279 support SOCKS4A protocol, from dwmw2 AT infradead.org via bz#1482;
281 - stevesk@cvs.openbsd.org 2009/01/15 17:38:43
283 1) use obsolete instead of alias for consistency
284 2) oUserKnownHostsFile not obsolete but oGlobalKnownHostsFile2 is
286 3) reorder so like options are together
288 - djm@cvs.openbsd.org 2009/01/22 09:46:01
289 [channels.c channels.h session.c]
290 make Channel->path an allocated string, saving a few bytes here and
291 there and fixing bz#1380 in the process; ok markus@
292 - djm@cvs.openbsd.org 2009/01/22 09:49:57
294 oops! I committed the wrong version of the Channel->path diff,
295 it was missing some tweaks suggested by stevesk@
296 - djm@cvs.openbsd.org 2009/01/22 10:02:34
297 [clientloop.c misc.c readconf.c readconf.h servconf.c servconf.h]
298 [serverloop.c ssh-keyscan.c ssh.c sshd.c]
299 make a2port() return -1 when it encounters an invalid port number
300 rather than 0, which it will now treat as valid (needed for future work)
301 adjust current consumers of a2port() to check its return value is <= 0,
302 which in turn required some things to be converted from u_short => int
303 make use of int vs. u_short consistent in some other places too
304 feedback & ok markus@
305 - djm@cvs.openbsd.org 2009/01/22 10:09:16
307 another chunk of a2port() diff that got away. wtfdjm??
308 - djm@cvs.openbsd.org 2009/01/23 07:58:11
310 prefer CTR modes and revised arcfour (i.e w/ discard) modes to CBC
312 - naddy@cvs.openbsd.org 2009/01/24 17:10:22
313 [ssh_config.5 sshd_config.5]
314 sync list of preferred ciphers; ok djm@
315 - markus@cvs.openbsd.org 2009/01/26 09:58:15
316 [cipher.c cipher.h packet.c]
317 Work around the CPNI-957037 Plaintext Recovery Attack by always
318 reading 256K of data on packet size or HMAC errors (in CBC mode only).
319 Help, feedback and ok djm@
320 Feedback from Martin Albrecht and Paterson Kenny
323 - (djm) [uidswap.c] bz#1412: Support >16 supplemental groups in OS X.
324 Patch based on one from vgiffin AT apple.com; ok dtucker@
325 - (djm) [channels.c] bz#1419: support "on demand" X11 forwarding via
326 launchd on OS X; patch from vgiffin AT apple.com, slightly tweaked;
328 - (djm) [contrib/ssh-copy-id.1 contrib/ssh-copy-id] bz#1492: Make
329 ssh-copy-id copy id_rsa.pub by default (instead of the legacy "identity"
330 key). Patch from cjwatson AT debian.org
333 - (tim) [configure.ac defines.h openbsd-compat/port-uw.c
334 openbsd-compat/xcrypt.c] Add SECUREWARE support to OpenServer 6 SVR5 ABI.
336 - (tim) [configure.ac] Move check_for_libcrypt_later=1 in *-*-sysv5*) section.
337 OpenServer 6 doesn't need libcrypt.
340 - (djm) OpenBSD CVS Sync
341 - djm@cvs.openbsd.org 2008/12/09 02:38:18
343 The ~C escape handler does not work correctly for multiplexed sessions -
344 it opens a commandline on the master session, instead of on the slave
345 that requested it. Disable it on slave sessions until such time as it
346 is fixed; bz#1543 report from Adrian Bridgett via Colin Watson
348 - djm@cvs.openbsd.org 2008/12/09 02:39:59
350 Deal correctly with failures in remote stat() operation in sftp,
351 correcting fail-on-error behaviour in batchmode. bz#1541 report and
352 fix from anedvedicky AT gmail.com; ok markus@
353 - djm@cvs.openbsd.org 2008/12/09 02:58:16
355 don't leave junk (free'd) pointers around in Forward *fwd argument on
356 failure; avoids double-free in ~C -L handler when given an invalid
357 forwarding specification; bz#1539 report from adejong AT debian.org
358 via Colin Watson; ok markus@ dtucker@
359 - djm@cvs.openbsd.org 2008/12/09 03:02:37
361 correct sftp(1) and corresponding usage syntax;
362 bz#1518 patch from imorgan AT nas.nasa.gov; ok deraadt@ improved diff jmc@
365 - (djm) [configure.ac] bz#1538: better test for ProPolice/SSP: actually
366 use some stack in main().
367 Report and suggested fix from vapier AT gentoo.org
368 - (djm) OpenBSD CVS Sync
369 - markus@cvs.openbsd.org 2008/12/02 19:01:07
371 we have to use the recipient's channel number (RFC 4254) for
372 SSH2_MSG_CHANNEL_SUCCESS/SSH2_MSG_CHANNEL_FAILURE messages,
373 otherwise we trigger 'Non-public channel' error messages on sshd
374 systems with clientkeepalive enabled; noticed by sturm; ok djm;
375 - markus@cvs.openbsd.org 2008/12/02 19:08:59
377 backout 1.149, since it's not necessary and openssh clients send
378 broken CHANNEL_FAILURE/SUCCESS messages since about 2004; ok djm@
379 - markus@cvs.openbsd.org 2008/12/02 19:09:38
381 s/remote_id/id/ to be more consistent with other code; ok djm@
384 - (dtucker) [contrib/cygwin/{Makefile,ssh-host-config}] Add new doc files
385 and tweak the is-sshd-running check in ssh-host-config. Patch from
386 vinschen at redhat com.
387 - (dtucker) OpenBSD CVS Sync
388 - markus@cvs.openbsd.org 2008/11/21 15:47:38
390 packet_disconnect() on padding error, too. should reduce the success
391 probability for the CPNI-957037 Plaintext Recovery Attack to 2^-18
393 - dtucker@cvs.openbsd.org 2008/11/30 11:59:26
395 Retry sendmsg/recvmsg on EAGAIN and EINTR; ok djm@
398 - (dtucker) [monitor_fdpass.c] Reduce diff vs OpenBSD by moving some
399 declarations, removing an unnecessary union member and adding whitespace.
400 cmsgbuf.tmp thing spotted by des at des no, ok djm some time ago.
403 - (tim) [addrmatch.c configure.ac] Some platforms do not have sin6_scope_id
404 member of sockaddr_in6. Also reported in Bug 1491 by David Leonard. OK and
408 - (dtucker) OpenBSD CVS Sync
409 - jmc@cvs.openbsd.org 2008/11/05 11:22:54
412 fixes user/5975 from Rene Maroufi
413 - stevesk@cvs.openbsd.org 2008/11/07 00:42:12
415 spelling/typo in comment
416 - stevesk@cvs.openbsd.org 2008/11/07 18:50:18
418 add space to some log/debug messages for readability; ok djm@ markus@
419 - dtucker@cvs.openbsd.org 2008/11/07 23:34:48
421 Move JPAKE define to make life easier for portable. ok djm@
422 - tobias@cvs.openbsd.org 2008/11/09 12:34:47
424 typo fixed (overriden -> overridden)
426 - stevesk@cvs.openbsd.org 2008/11/11 02:58:09
428 USE_AFS not referenced so remove #ifdef. fixes sshd -T not printing
429 kerberosgetafstoken. ok dtucker@
430 (Id sync only, we still want the ifdef in portable)
431 - stevesk@cvs.openbsd.org 2008/11/11 03:55:11
433 for sshd -T print 'permitopen any' vs. 'permitopen' for case of no
434 permitopen's; ok and input dtucker@
435 - djm@cvs.openbsd.org 2008/11/10 02:06:35
436 [regress/putty-ciphers.sh]
437 PuTTY supports AES CTR modes, so interop test against them too
441 - djm@cvs.openbsd.org 2008/11/03 08:59:41
443 include MaxSessions in sshd -T output; patch from imorgan AT nas.nasa.gov
444 - djm@cvs.openbsd.org 2008/11/04 07:58:09
446 need unistd.h for close() prototype
448 - djm@cvs.openbsd.org 2008/11/04 08:22:13
449 [auth.h auth2.c monitor.c monitor.h monitor_wrap.c monitor_wrap.h]
450 [readconf.c readconf.h servconf.c servconf.h ssh2.h ssh_config.5]
451 [sshconnect2.c sshd_config.5 jpake.c jpake.h schnorr.c auth2-jpake.c]
453 Add support for an experimental zero-knowledge password authentication
454 method using the J-PAKE protocol described in F. Hao, P. Ryan,
455 "Password Authenticated Key Exchange by Juggling", 16th Workshop on
456 Security Protocols, Cambridge, April 2008.
458 This method allows password-based authentication without exposing
459 the password to the server. Instead, the client and server exchange
460 cryptographic proofs to demonstrate of knowledge of the password while
461 revealing nothing useful to an attacker or compromised endpoint.
463 This is experimental, work-in-progress code and is presently
464 compiled-time disabled (turn on -DJPAKE in Makefile.inc).
466 "just commit it. It isn't too intrusive." deraadt@
467 - stevesk@cvs.openbsd.org 2008/11/04 19:18:00
469 because parse_forward() is now used to parse all forward types (DLR),
470 and it malloc's space for host variables, we don't need to malloc
471 here. fixes small memory leaks.
473 previously dynamic forwards were not parsed in parse_forward() and
474 space was not malloc'd in that case.
477 - stevesk@cvs.openbsd.org 2008/11/05 03:23:09
479 add dynamic forward escape command line; ok djm@
483 - sthen@cvs.openbsd.org 2008/07/24 23:55:30
485 Add "ssh-keygen -F -l" to synopsis (displays fingerprint from
486 known_hosts). ok djm@
487 - grunk@cvs.openbsd.org 2008/07/25 06:56:35
489 Add VisualHostKey to example file, ok djm@
490 - grunk@cvs.openbsd.org 2008/07/25 07:05:16
492 In random art visualization, make sure to use the end marker only at the
493 end. Initial diff by Dirk Loss, tweaks and ok djm@
494 - markus@cvs.openbsd.org 2008/07/31 14:48:28
496 don't allocate space for empty banners; report t8m at centrum.cz;
498 - krw@cvs.openbsd.org 2008/08/02 04:29:51
500 whitepsace -> whitespace. From Matthew Clarke via bugs@.
501 - djm@cvs.openbsd.org 2008/08/21 04:09:57
503 allow ForceCommand internal-sftp with arguments. based on patch from
504 michael.barabanov AT gmail.com; ok markus@
505 - djm@cvs.openbsd.org 2008/09/06 12:24:13
507 OpenSSL 0.9.8h supplies a real EVP_sha256 so we do not need our
509 (ID sync only for portable - we still need this)
510 - markus@cvs.openbsd.org 2008/09/11 14:22:37
511 [compat.c compat.h nchan.c ssh.c]
512 only send eow and no-more-sessions requests to openssh 5 and newer;
513 fixes interop problems with broken ssh v2 implementations; ok djm@
514 - millert@cvs.openbsd.org 2008/10/02 14:39:35
516 Convert an unchecked strdup to xstrdup. OK deraadt@
517 - jmc@cvs.openbsd.org 2008/10/03 13:08:12
519 do not give an example of how to chmod files: we can presume the user
520 knows that. removes an ambiguity in the permission of authorized_keys;
522 - deraadt@cvs.openbsd.org 2008/10/03 23:56:28
524 Repair strnvis() buffersize of 4*n+1, with termination gauranteed by the
526 spotted by des@freebsd, who commited an incorrect fix to the freebsd tree
527 and (as is fairly typical) did not report the problem to us. But this fix
530 - djm@cvs.openbsd.org 2008/10/08 23:34:03
532 Add -y option to force logging via syslog rather than stderr.
533 Useful for daemonised ssh connection (ssh -f). Patch originally from
535 - djm@cvs.openbsd.org 2008/10/09 03:50:54
536 [servconf.c sshd_config.5]
537 support setting PermitEmptyPasswords in a Match block
538 requested in PR3891; ok dtucker@
539 - jmc@cvs.openbsd.org 2008/10/09 06:54:22
542 - stevesk@cvs.openbsd.org 2008/10/10 04:55:16
544 spelling in comment; ok djm@
545 - stevesk@cvs.openbsd.org 2008/10/10 05:00:12
547 typo in error message; ok djm@
548 - stevesk@cvs.openbsd.org 2008/10/10 16:43:27
550 use 'Privileged ports can be forwarded only when logging in as root on
551 the remote machine.' for RemoteForward just like ssh.1 -R.
553 - stevesk@cvs.openbsd.org 2008/10/14 18:11:33
555 use #define ROQUIET here; no binary change. ok dtucker@
556 - stevesk@cvs.openbsd.org 2008/10/17 18:36:24
558 correct and clarify VisualHostKey; ok jmc@
559 - stevesk@cvs.openbsd.org 2008/10/30 19:31:16
560 [clientloop.c sshd.c]
561 don't need to #include "monitor_fdpass.h"
562 - stevesk@cvs.openbsd.org 2008/10/31 15:05:34
564 remove unused #define DISPATCH_MIN; ok markus@
565 - djm@cvs.openbsd.org 2008/11/01 04:50:08
567 sprinkle ARGSUSED on dispatch handlers
568 nuke stale unusued prototype
569 - stevesk@cvs.openbsd.org 2008/11/01 06:43:33
571 fix some typos in log messages; ok djm@
572 - sobrado@cvs.openbsd.org 2008/11/01 11:14:36
573 [ssh-keyscan.1 ssh-keyscan.c]
574 the ellipsis is not an optional argument; while here, improve spacing.
575 - stevesk@cvs.openbsd.org 2008/11/01 17:40:33
576 [clientloop.c readconf.c readconf.h ssh.c]
577 merge dynamic forward parsing into parse_forward();
578 'i think this is OK' djm@
579 - stevesk@cvs.openbsd.org 2008/11/02 00:16:16
581 protocol 2 tty modes support is now 7.5 years old so remove these
582 debug3()s; ok deraadt@
583 - stevesk@cvs.openbsd.org 2008/11/03 01:07:02
585 remove valueless comment
586 - stevesk@cvs.openbsd.org 2008/11/03 02:44:41
589 - (djm) [contrib/caldera/ssh-host-keygen contrib/suse/rc.sshd]
590 Make example scripts generate keys with default sizes rather than fixed,
591 non-default 1024 bits; patch from imorgan AT nas.nasa.gov
592 - (djm) [contrib/sshd.pam.generic contrib/caldera/sshd.pam]
593 [contrib/redhat/sshd.pam] Move pam_nologin to account group from
594 incorrect auth group in example files;
595 patch from imorgan AT nas.nasa.gov
598 - (dtucker) [config.guess config.sub] Update to latest versions from
599 http://git.savannah.gnu.org/gitweb/ (2008-04-14 and 2008-06-16
603 - (dtucker) [openbsd-compat/bsd-poll.c] correctly check for number of FDs
604 larger than FD_SETSIZE (OpenSSH only ever uses poll with one fd). Patch
605 from Nicholas Marriott.
608 - (djm) OpenBSD CVS Sync
609 - djm@cvs.openbsd.org 2008/07/23 07:36:55
611 do not try to print options that have been compile-time disabled
612 in config test mode (sshd -T); report from nix-corp AT esperi.org.uk
614 - (djm) [servconf.c] Print UsePAM option in config test mode (when it
615 has been compiled in); report from nix-corp AT esperi.org.uk
619 - (djm) OpenBSD CVS Sync
620 - jmc@cvs.openbsd.org 2008/07/18 22:51:01
622 no need for .Pp before or after .Sh;
623 - djm@cvs.openbsd.org 2008/07/21 08:19:07
626 - (djm) [README contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
627 [contrib/suse/openssh.spec] Update version number in README and RPM specs
628 - (djm) Release OpenSSH-5.1
631 - (djm) OpenBSD CVS Sync
632 - djm@cvs.openbsd.org 2008/07/17 08:48:00
634 strnvis preauth banner; pointed out by mpf@ ok markus@
635 - djm@cvs.openbsd.org 2008/07/17 08:51:07
637 strip trailing '.' from hostname when HostbasedUsesNameFromPacketOnly=yes
638 report and patch from res AT qoxp.net (bz#1200); ok markus@
639 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Remove long-unneeded compat
640 code, replace with equivalent cygwin library call. Patch from vinschen
641 at redhat.com, ok djm@.
642 - (djm) [sshconnect2.c] vis.h isn't available everywhere
646 - djm@cvs.openbsd.org 2008/07/15 02:23:14
648 number of pipelined requests is now 64;
649 prodded by Iain.Morgan AT nasa.gov
650 - djm@cvs.openbsd.org 2008/07/16 11:51:14
652 rename variable first_gc -> last_gc (since it is actually the last
654 - djm@cvs.openbsd.org 2008/07/16 11:52:19
656 this loop index should be automatic, not static
659 - (djm) OpenBSD CVS Sync
660 - sthen@cvs.openbsd.org 2008/07/13 21:22:52
662 Change "ssh-keygen -F [host] -l" to not display random art unless
663 -v is also specified, making it consistent with the manual and other
666 - djm@cvs.openbsd.org 2008/07/13 22:13:07
668 use struct sockaddr_storage instead of struct sockaddr for accept(2)
669 address argument. from visibilis AT yahoo.com in bz#1485; ok markus@
670 - djm@cvs.openbsd.org 2008/07/13 22:16:03
672 increase number of piplelined requests so they properly fill the
673 (recently increased) channel window. prompted by rapier AT psc.edu;
675 - djm@cvs.openbsd.org 2008/07/14 01:55:56
677 mention requirement for /dev/log inside chroot when using sftp-server
679 - (djm) [openbsd-compat/bindresvport.c] Rename variables s/sin/in/ to
680 avoid clash with sin(3) function; reported by
681 cristian.ionescu-idbohrn AT axis.com
682 - (djm) [openbsd-compat/rresvport.c] Add unistd.h for missing close()
683 prototype; reported by cristian.ionescu-idbohrn AT axis.com
684 - (djm) [umac.c] Rename variable s/buffer_ptr/bufp/ to avoid clash;
685 reported by cristian.ionescu-idbohrn AT axis.com
686 - (djm) [contrib/cygwin/Makefile contrib/cygwin/ssh-host-config]
687 [contrib/cygwin/ssh-user-config contrib/cygwin/sshd-inetd]
688 Revamped and simplified Cygwin ssh-host-config script that uses
689 unified csih configuration tool. Requires recent Cygwin.
690 Patch from vinschen AT redhat.com
693 - (djm) OpenBSD CVS Sync
694 - djm@cvs.openbsd.org 2008/07/12 04:52:50
696 unbreak; move clearing of cctx struct to before first use
698 - djm@cvs.openbsd.org 2008/07/12 05:33:41
700 better description for -i flag:
701 s/RSA authentication/public key authentication/
702 - (djm) [openbsd-compat/fake-rfc2553.c openbsd-compat/fake-rfc2553.h]
703 return EAI_FAMILY when trying to lookup unsupported address family;
704 from vinschen AT redhat.com
707 - (djm) OpenBSD CVS Sync
708 - stevesk@cvs.openbsd.org 2008/07/07 00:31:41
710 we don't need arg after the debug3() was removed. from lint.
712 - stevesk@cvs.openbsd.org 2008/07/07 23:32:51
714 /*NOTREACHED*/ for lint warning:
715 warning: function key_equal falls off bottom without returning value
717 - markus@cvs.openbsd.org 2008/07/10 18:05:58
719 missing bzero; from mickey; ok djm@
720 - markus@cvs.openbsd.org 2008/07/10 18:08:11
721 [clientloop.c monitor.c monitor_wrap.c packet.c packet.h sshd.c]
722 sync v1 and v2 traffic accounting; add it to sshd, too;
726 - (djm) [Makefile.in] Print "all tests passed" when all regress tests pass
727 - (djm) [auth1.c] Fix format string vulnerability in protocol 1 PAM
728 account check failure path. The vulnerable format buffer is supplied
729 from PAM and should not contain attacker-supplied data.
730 - (djm) [auth.c] Missing unistd.h for close()
731 - (djm) [configure.ac] Add -Wformat-security to CFLAGS for gcc 3.x and 4.x
734 - (djm) [auth.c] Fixed test for locked account on HP/UX with shadowed
735 passwords disabled. bz#1083 report & patch from senthilkumar_sen AT
736 hotpop.com, w/ dtucker@
737 - (djm) [atomicio.c configure.ac] Disable poll() fallback in atomiciov for
738 Tru64. readv doesn't seem to be a comparable object there.
739 bz#1386, patch from dtucker@ ok me
740 - (djm) [Makefile.in] Pass though pass to conch for interop tests
741 - (djm) [configure.ac] unbreak: remove extra closing brace
742 - (djm) OpenBSD CVS Sync
743 - djm@cvs.openbsd.org 2008/07/04 23:08:25
745 handle EINTR in packet_write_poll()l ok dtucker@
746 - djm@cvs.openbsd.org 2008/07/04 23:30:16
748 Make protocol 1 MaxAuthTries logic match protocol 2's.
749 Do not treat the first protocol 2 authentication attempt as
750 a failure IFF it is for method "none".
751 Makes MaxAuthTries' user-visible behaviour identical for
754 - djm@cvs.openbsd.org 2008/07/05 05:16:01
759 - (dtucker) OpenBSD CVS Sync
760 - djm@cvs.openbsd.org 2008/07/02 13:30:34
762 really really remove the freebie "none" auth try for protocol 2
763 - djm@cvs.openbsd.org 2008/07/02 13:47:39
765 When forking after authentication ("ssh -f") with ExitOnForwardFailure
766 enabled, delay the fork until after replies for any -R forwards have
767 been seen. Allows for robust detection of -R forward failure when
768 using -f (similar to bz#92); ok dtucker@
769 - otto@cvs.openbsd.org 2008/07/03 21:46:58
771 avoid nasty double free; ok dtucker@ djm@
772 - djm@cvs.openbsd.org 2008/07/04 03:44:59
773 [servconf.c groupaccess.h groupaccess.c]
774 support negation of groups in "Match group" block (bz#1315); ok dtucker@
775 - dtucker@cvs.openbsd.org 2008/07/04 03:47:02
777 Make debug a little clearer. ok djm@
778 - djm@cvs.openbsd.org 2008/06/30 08:07:34
779 [regress/key-options.sh]
780 shell portability: use "=" instead of "==" in test(1) expressions,
781 double-quote string with backslash escaped /
782 - djm@cvs.openbsd.org 2008/06/30 10:31:11
783 [regress/{putty-transfer,putty-kex,putty-ciphers}.sh]
784 remove "set -e" left over from debugging
785 - djm@cvs.openbsd.org 2008/06/30 10:43:03
786 [regress/conch-ciphers.sh]
787 explicitly disable conch options that could interfere with the test
788 - (dtucker) [sftp-server.c] Bug #1447: fall back to racy rename if link
789 returns EXDEV. Patch from Mike Garrison, ok djm@
790 - (djm) [atomicio.c channels.c clientloop.c defines.h includes.h]
791 [packet.c scp.c serverloop.c sftp-client.c ssh-agent.c ssh-keyscan.c]
792 [sshd.c] Explicitly handle EWOULDBLOCK wherever we handle EAGAIN, on
793 some platforms (HP nonstop) it is a distinct errno;
794 bz#1467 reported by sconeu AT yahoo.com; ok dtucker@
797 - (dtucker) OpenBSD CVS Sync
798 - djm@cvs.openbsd.org 2008/06/30 08:05:59
800 typo: s/constraint_date/constraint_data/
801 - djm@cvs.openbsd.org 2008/06/30 12:15:39
803 only pass channel requests on session channels through to the session
804 channel handler, avoiding spurious log messages; ok! markus@
805 - djm@cvs.openbsd.org 2008/06/30 12:16:02
807 only send eow@openssh.com notifications for session channels; ok! markus@
808 - djm@cvs.openbsd.org 2008/06/30 12:18:34
810 clarify that eow@openssh.com is only sent on session channels
811 - dtucker@cvs.openbsd.org 2008/07/01 07:20:52
813 Check ExitOnForwardFailure if forwardings are disabled due to a failed
814 host key check. ok djm@
815 - dtucker@cvs.openbsd.org 2008/07/01 07:24:22
816 [sshconnect.c sshd.c]
817 Send CR LF during protocol banner exchanges, but only for Protocol 2 only,
818 in order to comply with RFC 4253. bz #1443, ok djm@
819 - stevesk@cvs.openbsd.org 2008/07/01 23:12:47
821 fix some typos; ok djm@
822 - djm@cvs.openbsd.org 2008/07/02 02:24:18
823 [sshd_config sshd_config.5 sshd.8 servconf.c]
824 increase default size of ssh protocol 1 ephemeral key from 768 to 1024
825 bits; prodded by & ok dtucker@ ok deraadt@
826 - dtucker@cvs.openbsd.org 2008/07/02 12:03:51
827 [auth-rsa.c auth.c auth2-pubkey.c auth.h]
828 Merge duplicate host key file checks, based in part on a patch from Rob
829 Holland via bz #1348 . Also checks for non-regular files during protocol
831 - djm@cvs.openbsd.org 2008/07/02 12:36:39
832 [auth2-none.c auth2.c]
833 Make protocol 2 MaxAuthTries behaviour a little more sensible:
834 Check whether client has exceeded MaxAuthTries before running
835 an authentication method and skip it if they have, previously it
836 would always allow one try (for "none" auth).
837 Preincrement failure count before post-auth test - previously this
838 checked and postincremented, also to allow one "none" try.
839 Together, these two changes always count the "none" auth method
840 which could be skipped by a malicious client (e.g. an SSH worm)
841 to get an extra attempt at a real auth method. They also make
842 MaxAuthTries=0 a useful way to block users entirely (esp. in a
843 sshd_config Match block).
844 Also, move sending of any preauth banner from "none" auth method
845 to the first call to input_userauth_request(), so worms that skip
846 the "none" method get to see it too.
849 - (djm) OpenBSD CVS Sync
850 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
851 [regress/Makefile regress/key-options.sh]
852 Add regress test for key options. ok djm@
853 - dtucker@cvs.openbsd.org 2008/06/11 23:11:40
855 Don't run cipher-speed test by default; mistakenly enabled by me
856 - djm@cvs.openbsd.org 2008/06/28 13:57:25
857 [regress/Makefile regress/test-exec.sh regress/conch-ciphers.sh]
858 very basic regress test against Twisted Conch in "make interop"
859 target (conch is available in ports/devel/py-twisted/conch);
861 - (djm) [regress/Makefile] search for conch by path, like we do putty
864 - (djm) OpenBSD CVS Sync
865 - martynas@cvs.openbsd.org 2008/06/21 07:46:46
867 use optopt to get invalid flag, instead of return value of getopt,
868 which is always '?'; ok djm@
869 - otto@cvs.openbsd.org 2008/06/25 11:13:43
871 add key length to visual fingerprint; zap magical constants;
873 - djm@cvs.openbsd.org 2008/06/26 06:10:09
874 [sftp-client.c sftp-server.c]
875 allow the sftp chmod(2)-equivalent operation to set set[ug]id/sticky
876 bits. Note that this only affects explicit setting of modes (e.g. via
877 sftp(1)'s chmod command) and not file transfers. (bz#1310)
879 - djm@cvs.openbsd.org 2008/06/26 09:19:40
881 when loading moduli from /etc/moduli in sshd(8), check that they
882 are of the expected "safe prime" structure and have had
883 appropriate primality tests performed;
884 feedback and ok dtucker@
885 - grunk@cvs.openbsd.org 2008/06/26 11:46:31
886 [readconf.c readconf.h ssh.1 ssh_config.5 sshconnect.c]
887 Move SSH Fingerprint Visualization away from sharing the config option
888 CheckHostIP to an own config option named VisualHostKey.
889 While there, fix the behaviour that ssh would draw a random art picture
890 on every newly seen host even when the option was not enabled.
891 prodded by deraadt@, discussions,
892 help and ok markus@ djm@ dtucker@
893 - jmc@cvs.openbsd.org 2008/06/26 21:11:46
895 add VisualHostKey to the list of options listed in -o;
896 - djm@cvs.openbsd.org 2008/06/28 07:25:07
899 - djm@cvs.openbsd.org 2008/06/28 13:58:23
901 refuse to add a key that has unknown constraints specified;
903 - djm@cvs.openbsd.org 2008/06/28 14:05:15
905 reset global compat flag after processing a protocol 2 signature
906 request with the legacy DSA encoding flag set; ok markus
907 - djm@cvs.openbsd.org 2008/06/28 14:08:30
908 [PROTOCOL PROTOCOL.agent]
909 document the protocol used by ssh-agent; "looks ok" markus@
912 - (djm) [RFC.nroff contrib/cygwin/Makefile contrib/suse/openssh.spec]
913 RFC.nroff lacks a license, remove it (it is long gone in OpenBSD).
916 - (djm) [Makefile.in moduli.5] Include moduli(5) manpage from OpenBSD.
918 - (djm) [ contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
919 [contrib/suse/openssh.spec] Include moduli.5 in RPM spec files.
922 - (dtucker) OpenBSD CVS Sync
923 - dtucker@cvs.openbsd.org 2008/06/16 13:22:53
924 [session.c channels.c]
925 Rename the isatty argument to is_tty so we don't shadow
926 isatty(3). ok markus@
927 - (dtucker) [channels.c] isatty -> is_tty here too.
930 - (dtucker) [configure.ac] Enable -fno-builtin-memset when using gcc.
932 - dtucker@cvs.openbsd.org 2008/06/14 15:49:48
934 wrap long line at 80 chars
935 - dtucker@cvs.openbsd.org 2008/06/14 17:07:11
937 ensure default umask disallows at least group and world write; ok djm@
938 - djm@cvs.openbsd.org 2008/06/14 18:33:43
940 suppress the warning message from chdir(homedir) failures
941 when chrooted (bz#1461); ok dtucker
942 - dtucker@cvs.openbsd.org 2008/06/14 19:42:10
944 Mention that scp follows symlinks during -r. bz #1466,
946 - dtucker@cvs.openbsd.org 2008/06/15 16:55:38
948 MaxSessions is allowed in a Match block too
949 - dtucker@cvs.openbsd.org 2008/06/15 16:58:40
950 [servconf.c sshd_config.5]
951 Allow MaxAuthTries within a Match block. ok djm@
952 - djm@cvs.openbsd.org 2008/06/15 20:06:26
953 [channels.c channels.h session.c]
954 don't call isatty() on a pty master, instead pass a flag down to
955 channel_set_fds() indicating that te fds refer to a tty. Fixes a
956 hang on exit on Solaris (bz#1463) in portable but is actually
957 a generic bug; ok dtucker deraadt markus
960 - (djm) [openbsd-compat/sigact.c] Avoid NULL derefs in ancient sigaction
961 replacement code; patch from ighighi AT gmail.com in bz#1240;
965 - (dtucker) OpenBSD CVS Sync
966 - deraadt@cvs.openbsd.org 2008/06/13 09:44:36
968 compile on older gcc; no decl after code
969 - dtucker@cvs.openbsd.org 2008/06/13 13:56:59
971 Clear key options in the monitor on failed authentication, prevents
972 applying additional restrictions to non-pubkey authentications in
973 the case where pubkey fails but another method subsequently succeeds.
974 bz #1472, found by Colin Watson, ok markus@ djm@
975 - dtucker@cvs.openbsd.org 2008/06/13 14:18:51
976 [auth2-pubkey.c auth-rhosts.c]
977 Include unistd.h for close(), prevents warnings in -portable
978 - dtucker@cvs.openbsd.org 2008/06/13 17:21:20
980 Friendlier error messages for mux fallback. ok djm@
981 - dtucker@cvs.openbsd.org 2008/06/13 18:55:22
983 Prevent -Wsign-compare warnings on LP64 systems. bz #1192, ok deraadt@
984 - grunk@cvs.openbsd.org 2008/06/13 20:13:26
986 Explain the use of SSH fpr visualization using random art, and cite the
987 original scientific paper inspiring that technique.
988 Much help with English and nroff by jmc@, thanks.
989 - (dtucker) [configure.ac] Bug #1276: avoid linking against libgssapi, which
990 despite its name doesn't seem to implement all of GSSAPI. Patch from
991 Jan Engelhardt, sanity checked by Simon Wilkinson.
994 - (dtucker) OpenBSD CVS Sync
995 - jmc@cvs.openbsd.org 2008/06/11 07:30:37
997 kill trailing whitespace;
998 - grunk@cvs.openbsd.org 2008/06/11 21:01:35
999 [ssh_config.5 key.h readconf.c readconf.h ssh-keygen.1 ssh-keygen.c key.c
1001 Introduce SSH Fingerprint ASCII Visualization, a technique inspired by the
1002 graphical hash visualization schemes known as "random art", and by
1003 Dan Kaminsky's musings on the subject during a BlackOp talk at the
1005 Scientific publication (original paper):
1006 "Hash Visualization: a New Technique to improve Real-World Security",
1007 Perrig A. and Song D., 1999, International Workshop on Cryptographic
1008 Techniques and E-Commerce (CrypTEC '99)
1009 http://sparrow.ece.cmu.edu/~adrian/projects/validation/validation.pdf
1010 The algorithm used here is a worm crawling over a discrete plane,
1011 leaving a trace (augmenting the field) everywhere it goes.
1012 Movement is taken from dgst_raw 2bit-wise. Bumping into walls
1013 makes the respective movement vector be ignored for this turn,
1014 thus switching to the other color of the chessboard.
1015 Graphs are not unambiguous for now, because circles in graphs can be
1016 walked in either direction.
1017 discussions with several people,
1018 help, corrections and ok markus@ djm@
1019 - grunk@cvs.openbsd.org 2008/06/11 21:38:25
1021 ssh-keygen -lv -f /etc/ssh/ssh_host_rsa_key.pub
1022 would not display you the random art as intended, spotted by canacar@
1023 - grunk@cvs.openbsd.org 2008/06/11 22:20:46
1024 [ssh-keygen.c ssh-keygen.1]
1025 ssh-keygen would write fingerprints to STDOUT, and random art to STDERR,
1026 that is not how it was envisioned.
1027 Also correct manpage saying that -v is needed along with -l for it to work.
1029 - otto@cvs.openbsd.org 2008/06/11 23:02:22
1031 simpler way of computing the augmentations; ok grunk@
1032 - grunk@cvs.openbsd.org 2008/06/11 23:03:56
1034 CheckHostIP set to ``fingerprint'' will display both hex and random art
1036 - grunk@cvs.openbsd.org 2008/06/11 23:51:57
1038 #define statements that are not atoms need braces around them, else they
1039 will cause trouble in some cases.
1040 Also do a computation of -1 once, and not in a loop several times.
1042 - dtucker@cvs.openbsd.org 2008/06/12 00:03:49
1043 [dns.c canohost.c sshconnect.c]
1044 Do not pass "0" strings as ports to getaddrinfo because the lookups
1045 can slow things down and we never use the service info anyway. bz
1046 #859, patch from YOSHIFUJI Hideaki and John Devitofranceschi. ok
1048 djm belives that the reason for the "0" strings is to ensure that
1049 it's not possible to call getaddrinfo with both host and port being
1050 NULL. In the case of canohost.c host is a local array. In the
1051 case of sshconnect.c, it's checked for null immediately before use.
1052 In dns.c it ultimately comes from ssh.c:main() and is guaranteed to
1053 be non-null but it's not obvious, so I added a warning message in
1054 case it is ever passed a null.
1055 - grunk@cvs.openbsd.org 2008/06/12 00:13:55
1057 Make ssh print the random art also when ssh'ing to a host using IP only.
1058 spotted by naddy@, ok and help djm@ dtucker@
1059 - otto@cvs.openbsd.org 2008/06/12 00:13:13
1061 use an odd number of rows and columns and a separate start marker, looks
1063 - djm@cvs.openbsd.org 2008/06/12 03:40:52
1064 [clientloop.h mux.c channels.c clientloop.c channels.h]
1065 Enable ~ escapes for multiplex slave sessions; give each channel
1066 its own escape state and hook the escape filters up to muxed
1068 Mux slaves do not currently support the ~^Z and ~& escapes.
1069 NB. this change cranks the mux protocol version, so a new ssh
1070 mux client will not be able to connect to a running old ssh
1073 - djm@cvs.openbsd.org 2008/06/12 04:06:00
1074 [clientloop.h ssh.c clientloop.c]
1075 maintain an ordered queue of outstanding global requests that we
1076 expect replies to, similar to the per-channel confirmation queue.
1077 Use this queue to verify success or failure for remote forward
1078 establishment in a race free way.
1080 - djm@cvs.openbsd.org 2008/06/12 04:17:47
1082 thall shalt not code past the eightieth column
1083 - djm@cvs.openbsd.org 2008/06/12 04:24:06
1085 thal shalt not code past the eightieth column
1086 - djm@cvs.openbsd.org 2008/06/12 05:15:41
1088 document tun@openssh.com forwarding method
1089 - djm@cvs.openbsd.org 2008/06/12 05:32:30
1091 some more TODO for me
1092 - grunk@cvs.openbsd.org 2008/06/12 05:42:46
1094 supply the key type (rsa1, rsa, dsa) as a caption in the frame of the
1095 random art. while there, stress the fact that the field base should at
1096 least be 8 characters for the pictures to make sense.
1098 - grunk@cvs.openbsd.org 2008/06/12 06:32:59
1100 We already mark the start of the worm, now also mark the end of the worm
1101 in our random art drawings.
1103 - djm@cvs.openbsd.org 2008/06/12 15:19:17
1104 [clientloop.h channels.h clientloop.c channels.c mux.c]
1105 The multiplexing escape char handler commit last night introduced a
1106 small memory leak per session; plug it.
1107 - dtucker@cvs.openbsd.org 2008/06/12 16:35:31
1108 [ssh_config.5 ssh.c]
1109 keyword expansion for localcommand. ok djm@
1110 - jmc@cvs.openbsd.org 2008/06/12 19:10:09
1111 [ssh_config.5 ssh-keygen.1]
1112 tweak the ascii art text; ok grunk
1113 - dtucker@cvs.openbsd.org 2008/06/12 20:38:28
1114 [sshd.c sshconnect.c packet.h misc.c misc.h packet.c]
1115 Make keepalive timeouts apply while waiting for a packet, particularly
1116 during key renegotiation (bz #1363). With djm and Matt Day, ok djm@
1117 - djm@cvs.openbsd.org 2008/06/12 20:47:04
1119 print extension revisions for extensions that we understand
1120 - djm@cvs.openbsd.org 2008/06/12 21:06:25
1122 I was coalescing expected global request confirmation replies at
1123 the wrong end of the queue - fix; prompted by markus@
1124 - grunk@cvs.openbsd.org 2008/06/12 21:14:46
1126 make ssh-keygen -lf show the key type just as ssh-add -l would do it
1128 - grunk@cvs.openbsd.org 2008/06/12 22:03:36
1130 add my copyright, ok djm@
1131 - ian@cvs.openbsd.org 2008/06/12 23:24:58
1133 tweak wording in message, ok deraadt@ jmc@
1134 - dtucker@cvs.openbsd.org 2008/06/13 00:12:02
1136 replace __dead with __attribute__((noreturn)), makes things
1137 a little easier to port. Also, add it to sigdie(). ok djm@
1138 - djm@cvs.openbsd.org 2008/06/13 00:16:49
1140 fall back to creating a new TCP connection on most multiplexing errors
1141 (socket connect fail, invalid version, refused permittion, corrupted
1142 messages, etc.); bz #1329 ok dtucker@
1143 - dtucker@cvs.openbsd.org 2008/06/13 00:47:53
1145 upcast size_t to u_long to match format arg; ok djm@
1146 - dtucker@cvs.openbsd.org 2008/06/13 00:51:47
1148 upcast another size_t to u_long to match format
1149 - dtucker@cvs.openbsd.org 2008/06/13 01:38:23
1151 upcast uid to long with matching %ld, prevents warnings in portable
1152 - djm@cvs.openbsd.org 2008/06/13 04:40:22
1153 [auth2-pubkey.c auth-rhosts.c]
1154 refuse to read ~/.shosts or ~/.ssh/authorized_keys that are not
1155 regular files; report from Solar Designer via Colin Watson in bz#1471
1157 - (dtucker) [clientloop.c serverloop.c] channel_register_filter now
1158 takes 2 more args. with djm@
1159 - (dtucker) [defines.h] Bug #1112: __dead is, well dead. Based on a patch
1161 - (dtucker) [auth-sia.c] Bug #1241: support password expiry on Tru64 SIA
1162 systems. Patch from R. Scott Bailey.
1163 - (dtucker) [umac.c] STORE_UINT32_REVERSED and endian_convert are never used
1164 on big endian machines, so ifdef them for little-endian only to prevent
1165 unused function warnings on big-endians.
1166 - (dtucker) [openbsd-compat/setenv.c] Make offsets size_t to prevent
1167 compiler warnings on some platforms. Based on a discussion with otto@
1170 - (djm) [channels.c configure.ac]
1171 Do not set SO_REUSEADDR on wildcard X11 listeners (X11UseLocalhost=no)
1175 - (dtucker) OpenBSD CVS Sync
1176 - djm@cvs.openbsd.org 2008/06/10 03:57:27
1177 [servconf.c match.h sshd_config.5]
1178 support CIDR address matching in sshd_config "Match address" blocks, with
1179 full support for negation and fall-back to classic wildcard matching.
1181 Match address 192.0.2.0/24,3ffe:ffff::/32,!10.*
1182 PasswordAuthentication yes
1183 addrmatch.c code mostly lifted from flowd's addr.c
1184 feedback and ok dtucker@
1185 - djm@cvs.openbsd.org 2008/06/10 04:17:46
1187 better reference for pattern-list
1188 - dtucker@cvs.openbsd.org 2008/06/10 04:50:25
1189 [sshd.c channels.h channels.c log.c servconf.c log.h servconf.h sshd.8]
1190 Add extended test mode (-T) and connection parameters for test mode (-C).
1191 -T causes sshd to write its effective configuration to stdout and exit.
1192 -C causes any relevant Match rules to be applied before output. The
1193 combination allows tesing of the parser and config files. ok deraadt djm
1194 - jmc@cvs.openbsd.org 2008/06/10 07:12:00
1197 - jmc@cvs.openbsd.org 2008/06/10 08:17:40
1200 - fix SYNOPSIS, and sort options
1201 - some minor additional fixes
1202 - dtucker@cvs.openbsd.org 2008/06/09 18:06:32
1203 [regress/test-exec.sh]
1204 Don't generate putty keys if we're not going to use them. ok djm
1205 - dtucker@cvs.openbsd.org 2008/06/10 05:23:32
1206 [regress/addrmatch.sh regress/Makefile]
1207 Regress test for Match CIDR rules. ok djm@
1208 - dtucker@cvs.openbsd.org 2008/06/10 15:21:41
1210 Use a more portable construct for checking if we're running a putty test
1211 - dtucker@cvs.openbsd.org 2008/06/10 15:28:49
1214 - dtucker@cvs.openbsd.org 2008/06/10 18:21:24
1216 clarify that Host patterns are space-separated. ok deraadt
1217 - djm@cvs.openbsd.org 2008/06/10 22:15:23
1218 [PROTOCOL ssh.c serverloop.c]
1219 Add a no-more-sessions@openssh.com global request extension that the
1220 client sends when it knows that it will never request another session
1221 (i.e. when session multiplexing is disabled). This allows a server to
1222 disallow further session requests and terminate the session.
1223 Why would a non-multiplexing client ever issue additional session
1224 requests? It could have been attacked with something like SSH'jack:
1225 http://www.storm.net.nz/projects/7
1226 feedback & ok markus
1227 - djm@cvs.openbsd.org 2008/06/10 23:06:19
1228 [auth-options.c match.c servconf.c addrmatch.c sshd.8]
1229 support CIDR address matching in .ssh/authorized_keys from="..." stanzas
1230 ok and extensive testing dtucker@
1231 - dtucker@cvs.openbsd.org 2008/06/10 23:21:34
1233 Use '\0' for a nul byte rather than unadorned 0. ok djm@
1234 - dtucker@cvs.openbsd.org 2008/06/10 23:13:43
1235 [Makefile regress/key-options.sh]
1236 Add regress test for key options. ok djm@
1237 - (dtucker) [openbsd-compat/fake-rfc2553.h] Add sin6_scope_id to sockaddr_in6
1238 since the new CIDR code in addmatch.c references it.
1239 - (dtucker) [Makefile.in configure.ac regress/addrmatch.sh] Skip IPv6
1240 specific tests on platforms that don't do IPv6.
1241 - (dtucker) [Makefile.in] Define TEST_SSH_IPV6 in make's arguments as well
1243 - (dtucker) [Makefile.in] Move addrmatch.o to libssh.a where it's needed now.
1246 - (dtucker) OpenBSD CVS Sync
1247 - dtucker@cvs.openbsd.org 2008/06/08 17:04:41
1249 Add case for ENOSYS in errno_to_portable; ok deraadt
1250 - dtucker@cvs.openbsd.org 2008/06/08 20:15:29
1251 [sftp.c sftp-client.c sftp-client.h]
1252 Have the sftp client store the statvfs replies in wire format,
1253 which prevents problems when the server's native sizes exceed the
1255 Also extends the sizes of the remaining 32bit wire format to 64bit,
1256 they're specified as unsigned long in the standard.
1257 - dtucker@cvs.openbsd.org 2008/06/09 13:02:39
1259 Extend 32bit -> 64bit values for statvfs extension missed in previous
1261 - dtucker@cvs.openbsd.org 2008/06/09 13:38:46
1263 Use a $OpenBSD tag so our scripts will sync changes.
1266 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c
1267 openbsd-compat/Makefile.in openbsd-compat/openbsd-compat.h
1268 openbsd-compat/bsd-statvfs.{c,h}] Add a null implementation of statvfs and
1269 fstatvfs and remove #defines around statvfs code. ok djm@
1270 - (dtucker) [configure.ac defines.h sftp-client.c M sftp-server.c] Add a
1271 macro to convert fsid to unsigned long for platforms where fsid is a
1275 - (dtucker) [mux.c] Include paths.h inside ifdef HAVE_PATHS_H.
1276 - (dtucker) [configure.ac defines.h sftp-client.c sftp-server.c sftp.c]
1277 Do not enable statvfs extensions on platforms that do not have statvfs.
1278 - (dtucker) OpenBSD CVS Sync
1279 - djm@cvs.openbsd.org 2008/05/19 06:14:02
1280 [packet.c] unbreak protocol keepalive timeouts bz#1465; ok dtucker@
1281 - djm@cvs.openbsd.org 2008/05/19 15:45:07
1282 [sshtty.c ttymodes.c sshpty.h]
1283 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1284 we would send the modes corresponding to a zeroed struct termios,
1285 whereas we should have been sending an empty list of modes.
1286 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1287 - djm@cvs.openbsd.org 2008/05/19 15:46:31
1289 support -l (print fingerprint) in combination with -F (find host) to
1290 search for a host in ~/.ssh/known_hosts and display its fingerprint;
1292 - djm@cvs.openbsd.org 2008/05/19 20:53:52
1294 unbreak tree by committing this bit that I missed from:
1295 Fix sending tty modes when stdin is not a tty (bz#1199). Previously
1296 we would send the modes corresponding to a zeroed struct termios,
1297 whereas we should have been sending an empty list of modes.
1298 Based on patch from daniel.ritz AT alcatel.ch; ok dtucker@ markus@
1301 - (djm) [openbsd-compat/bsd-arc4random.c] Fix math bug that caused bias
1302 in arc4random_uniform with upper_bound in (2^30,2*31). Note that
1303 OpenSSH did not make requests with upper bounds in this range.
1306 - (djm) [configure.ac mux.c sftp.c openbsd-compat/Makefile.in]
1307 [openbsd-compat/fmt_scaled.c openbsd-compat/openbsd-compat.h]
1308 Fix compilation on Linux, including pulling in fmt_scaled(3)
1309 implementation from OpenBSD's libutil.
1312 - (djm) OpenBSD CVS Sync
1313 - djm@cvs.openbsd.org 2008/04/04 05:14:38
1315 ChrootDirectory is supported in Match blocks (in fact, it is most useful
1316 there). Spotted by Minstrel AT minstrel.org.uk
1317 - djm@cvs.openbsd.org 2008/04/04 06:44:26
1319 oops, some unrelated stuff crept into that commit - backout.
1321 - djm@cvs.openbsd.org 2008/04/05 02:46:02
1323 HostbasedAuthentication is supported under Match too
1324 - (djm) [openbsd-compat/bsd-arc4random.c openbsd-compat/openbsd-compat.c]
1325 [configure.ac] Implement arc4random_buf(), import implementation of
1326 arc4random_uniform() from OpenBSD
1327 - (djm) [openbsd-compat/bsd-arc4random.c] Warning fixes
1328 - (djm) [openbsd-compat/port-tun.c] needs sys/queue.h
1329 - (djm) OpenBSD CVS Sync
1330 - djm@cvs.openbsd.org 2008/04/13 00:22:17
1332 Use arc4random_buf() when requesting more than a single word of output
1333 Use arc4random_uniform() when the desired random number upper bound
1334 is not a power of two
1335 ok deraadt@ millert@
1336 - djm@cvs.openbsd.org 2008/04/18 12:32:11
1337 [sftp-client.c sftp-client.h sftp-server.c sftp.1 sftp.c sftp.h]
1338 introduce sftp extension methods statvfs@openssh.com and
1339 fstatvfs@openssh.com that implement statvfs(2)-like operations,
1340 based on a patch from miklos AT szeredi.hu (bz#1399)
1341 also add a "df" command to the sftp client that uses the
1342 statvfs@openssh.com to produce a df(1)-like display of filesystem
1343 space and inode utilisation
1345 - jmc@cvs.openbsd.org 2008/04/18 17:15:47
1348 - djm@cvs.openbsd.org 2008/04/18 22:01:33
1350 remove unneccessary parentheses
1351 - otto@cvs.openbsd.org 2008/04/29 11:20:31
1353 garbage collect two unused fields in struct mm_master; ok markus@
1354 - djm@cvs.openbsd.org 2008/04/30 10:14:03
1355 [ssh-keyscan.1 ssh-keyscan.c]
1356 default to rsa (protocol 2) keys, instead of rsa1 keys; spotted by
1357 larsnooden AT openoffice.org
1358 - pyr@cvs.openbsd.org 2008/05/07 05:49:37
1359 [servconf.c servconf.h session.c sshd_config.5]
1360 Enable the AllowAgentForwarding option in sshd_config (global and match
1361 context), to specify if agents should be permitted on the server.
1362 As the man page states:
1363 ``Note that disabling Agent forwarding does not improve security
1364 unless users are also denied shell access, as they can always install
1365 their own forwarders.''
1366 ok djm@, ok and a mild frown markus@
1367 - pyr@cvs.openbsd.org 2008/05/07 06:43:35
1369 push the sshd_config bits in, spotted by ajacoutot@
1370 - jmc@cvs.openbsd.org 2008/05/07 08:00:14
1373 - markus@cvs.openbsd.org 2008/05/08 06:59:01
1374 [bufaux.c buffer.h channels.c packet.c packet.h]
1375 avoid extra malloc/copy/free when receiving data over the net;
1376 ~10% speedup for localhost-scp; ok djm@
1377 - djm@cvs.openbsd.org 2008/05/08 12:02:23
1378 [auth-options.c auth1.c channels.c channels.h clientloop.c gss-serv.c]
1379 [monitor.c monitor_wrap.c nchan.c servconf.c serverloop.c session.c]
1381 Implement a channel success/failure status confirmation callback
1382 mechanism. Each channel maintains a queue of callbacks, which will
1383 be drained in order (RFC4253 guarantees confirm messages are not
1384 reordered within an channel).
1385 Also includes a abandonment callback to clean up if a channel is
1386 closed without sending confirmation messages. This probably
1387 shouldn't happen in compliant implementations, but it could be
1388 abused to leak memory.
1389 ok markus@ (as part of a larger diff)
1390 - djm@cvs.openbsd.org 2008/05/08 12:21:16
1391 [monitor.c monitor_wrap.c session.h servconf.c servconf.h session.c]
1392 [sshd_config sshd_config.5]
1393 Make the maximum number of sessions run-time controllable via
1394 a sshd_config MaxSessions knob. This is useful for disabling
1395 login/shell/subsystem access while leaving port-forwarding working
1396 (MaxSessions 0), disabling connection multiplexing (MaxSessions 1) or
1397 simply increasing the number of allows multiplexed sessions.
1398 Because some bozos are sure to configure MaxSessions in excess of the
1399 number of available file descriptors in sshd (which, at peak, might be
1400 as many as 9*MaxSessions), audit sshd to ensure that it doesn't leak fds
1401 on error paths, and make it fail gracefully on out-of-fd conditions -
1402 sending channel errors instead of than exiting with fatal().
1403 bz#1090; MaxSessions config bits and manpage from junyer AT gmail.com
1405 - djm@cvs.openbsd.org 2008/05/08 13:06:11
1406 [clientloop.c clientloop.h ssh.c]
1407 Use new channel status confirmation callback system to properly deal
1408 with "important" channel requests that fail, in particular command exec,
1409 shell and subsystem requests. Previously we would optimistically assume
1410 that the requests would always succeed, which could cause hangs if they
1411 did not (e.g. when the server runs out of fds) or were unimplemented by
1412 the server (bz #1384)
1413 Also, properly report failing multiplex channel requests via the mux
1414 client stderr (subject to LogLevel in the mux master) - better than
1416 most bits ok markus@ (as part of a larger diff)
1417 - djm@cvs.openbsd.org 2008/05/09 04:55:56
1418 [channels.c channels.h clientloop.c serverloop.c]
1419 Try additional addresses when connecting to a port forward destination
1420 whose DNS name resolves to more than one address. The previous behaviour
1421 was to try the first address and give up.
1422 Reported by stig AT venaas.com in bz#343
1423 great feedback and ok markus@
1424 - djm@cvs.openbsd.org 2008/05/09 14:18:44
1425 [clientloop.c clientloop.h ssh.c mux.c]
1426 tidy up session multiplexing code, moving it into its own file and
1427 making the function names more consistent - making ssh.c and
1428 clientloop.c a fair bit more readable.
1430 - djm@cvs.openbsd.org 2008/05/09 14:26:08
1432 dingo stole my diff hunk
1433 - markus@cvs.openbsd.org 2008/05/09 16:16:06
1435 re-add the USE_PIPES code and enable it.
1436 without pipes shutdown-read from the sshd does not trigger
1437 a SIGPIPE when the forked program does a write.
1439 (Id sync only, USE_PIPES never left portable OpenSSH)
1440 - markus@cvs.openbsd.org 2008/05/09 16:17:51
1442 error-fd race: don't enable the error fd in the select bitmask
1443 for channels with both in- and output closed, since the channel
1444 will go away before we call select();
1445 report, lots of debugging help and ok djm@
1446 - markus@cvs.openbsd.org 2008/05/09 16:21:13
1447 [channels.h clientloop.c nchan.c serverloop.c]
1449 ssh -2 localhost od /bin/ls | true
1450 ignoring SIGPIPE by adding a new channel message (EOW) that signals
1451 the peer that we're not interested in any data it might send.
1452 fixes bz #85; discussion, debugging and ok djm@
1453 - pvalchev@cvs.openbsd.org 2008/05/12 20:52:20
1455 Ensure nh_result lies on a 64-bit boundary (fixes warnings observed
1456 on Itanium on Linux); from Dale Talcott (bug #1462); ok djm@
1457 - djm@cvs.openbsd.org 2008/05/15 23:52:24
1459 document eow message in ssh protocol 2 channel state machine;
1460 feedback and ok markus@
1461 - djm@cvs.openbsd.org 2008/05/18 21:29:05
1463 comment extension announcement
1464 - djm@cvs.openbsd.org 2008/05/16 08:30:42
1466 document our protocol extensions and deviations; ok markus@
1467 - djm@cvs.openbsd.org 2008/05/17 01:31:56
1469 grammar and correctness fixes from stevesk@
1472 - (djm) [openbsd-compat/bsd-poll.c] Include stdlib.h to avoid compile-
1473 time warnings on LynxOS. Patch from ops AT iki.fi
1474 - (djm) Force string arguments to replacement setproctitle() though
1475 strnvis first. Ok dtucker@
1478 - (djm) OpenBSD CVS sync:
1479 - markus@cvs.openbsd.org 2008/04/02 15:36:51
1481 avoid possible hijacking of x11-forwarded connections (back out 1.183)
1482 CVE-2008-1483; ok djm@
1483 - jmc@cvs.openbsd.org 2008/03/27 22:37:57
1485 remove trailing whitespace;
1486 - djm@cvs.openbsd.org 2008/04/03 09:50:14
1489 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
1490 [contrib/suse/openssh.spec] Crank version numbers in RPM spec files
1491 - (djm) [README] Update link to release notes
1492 - (djm) Release 5.0p1