]> andersk Git - openssh.git/blame - ChangeLog
- (djm) [configure.ac] add a --without-openssl-header-check option to
[openssh.git] / ChangeLog
CommitLineData
1d42bcce 120070304
2 - (djm) [configure.ac] add a --without-openssl-header-check option to
3 configure, as some platforms (OS X) ship OpenSSL headers whose version
4 does not match that of the shipping library. ok dtucker@
5
f0bbbd78 620070303
7 - (dtucker) [regress/agent-ptrace.sh] Make ttrace gdb error a little more
8 general to cover newer gdb versions on HP-UX.
9
04765d02 1020070302
11 - (dtucker) [configure.ac] For Cygwin, read files in textmode (which allows
12 CRLF as well as LF lineendings) and write in binary mode. Patch from
13 vinschen at redhat.com.
2769e5d0 14 - (dtucker) [INSTALL] Update to autoconf-2.61.
04765d02 15
121c4a34 1620070301
17 - (dtucker) OpenBSD CVS Sync
18 - dtucker@cvs.openbsd.org 2007/03/01 10:28:02
19 [auth2.c sshd_config.5 servconf.c]
20 Remove ChallengeResponseAuthentication support inside a Match
21 block as its interaction with KbdInteractive makes it difficult to
22 support. Also, relocate the CR/kbdint option special-case code into
23 servconf. "please commit" djm@, ok markus@ for the relocation.
840bd607 24 - (tim) [buildpkg.sh.in openssh.xml.in] Clean up Solaris 10 smf(5) bits.
25 "Looks sane" dtucker@
121c4a34 26
f10f9102 2720070228
28 - (dtucker) OpenBSD CVS Sync
29 - dtucker@cvs.openbsd.org 2007/02/28 00:55:30
30 [ssh-agent.c]
31 Remove expired keys periodically so they don't remain in memory when
32 the agent is entirely idle, as noted by David R. Piegdon. This is the
33 simple fix, a more efficient one will be done later. With markus,
34 deraadt, with & ok djm.
35
88ea6a3c 3620070225
37 - (dtucker) OpenBSD CVS Sync
38 - djm@cvs.openbsd.org 2007/02/20 10:25:14
39 [clientloop.c]
40 set maximum packet and window sizes the same for multiplexed clients
41 as normal connections; ok markus@
1e823acf 42 - dtucker@cvs.openbsd.org 2007/02/21 11:00:05
43 [sshd.c]
44 Clear alarm() before restarting sshd on SIGHUP. Without this, if there's
45 a SIGALRM pending (for SSH1 key regeneration) when sshd is SIGHUP'ed, the
46 newly exec'ed sshd will get the SIGALRM and not have a handler for it,
47 and the default action will terminate the listening sshd. Analysis and
48 patch from andrew at gaul.org.
f3e3d6ce 49 - dtucker@cvs.openbsd.org 2007/02/22 12:58:40
50 [servconf.c]
51 Check activep so Match and GatewayPorts work together; ok markus@
8c1cb72e 52 - ray@cvs.openbsd.org 2007/02/24 03:30:11
53 [moduli.c]
54 - strlen returns size_t, not int.
55 - Pass full buffer size to fgets.
56 OK djm@, millert@, and moritz@.
88ea6a3c 57
5792fbb7 5820070219
59 - (dtucker) OpenBSD CVS Sync
60 - jmc@cvs.openbsd.org 2007/01/10 13:23:22
61 [ssh_config.5]
62 do not use a list for SYNOPSIS;
63 this is actually part of a larger report sent by eric s. raymond
64 and forwarded by brad, but i only read half of it. spotted by brad.
e91a8c3f 65 - jmc@cvs.openbsd.org 2007/01/12 20:20:41
66 [ssh-keygen.1 ssh-keygen.c]
67 more secsh -> rfc 4716 updates;
68 spotted by wiz@netbsd
69 ok markus
70b5e752 70 - dtucker@cvs.openbsd.org 2007/01/17 23:22:52
71 [readconf.c]
72 Honour activep for times (eg ServerAliveInterval) while parsing
73 ssh_config and ~/.ssh/config so they work properly with Host directives.
74 From mario.lorenz@wincor-nixdorf.com via bz #1275. ok markus@
75 - stevesk@cvs.openbsd.org 2007/01/21 01:41:54
76 [auth-skey.c kex.c ssh-keygen.c session.c clientloop.c]
77 spaces
0cf6a024 78 - stevesk@cvs.openbsd.org 2007/01/21 01:45:35
79 [readconf.c]
80 spaces
e4d5ca17 81 - djm@cvs.openbsd.org 2007/01/22 11:32:50
82 [sftp-client.c]
83 return error from do_upload() when a write fails. fixes bz#1252: zero
84 exit status from sftp when uploading to a full device. report from
85 jirkat AT atlas.cz; ok dtucker@
7df0afaf 86 - djm@cvs.openbsd.org 2007/01/22 13:06:21
87 [scp.c]
88 fix detection of whether we should show progress meter or not: scp
89 tested isatty(stderr) but wrote the progress meter to stdout. This patch
90 makes it test stdout. bz#1265 reported by junkmail AT bitsculpture.com;
91 of dtucker@
1b313731 92 - stevesk@cvs.openbsd.org 2007/02/14 14:32:00
93 [bufbn.c]
94 typos in comments; ok jmc@
03bcbf84 95 - dtucker@cvs.openbsd.org 2007/02/19 10:45:58
96 [monitor_wrap.c servconf.c servconf.h monitor.c sshd_config.5]
97 Teach Match how handle config directives that are used before
98 authentication. This allows configurations such as permitting password
99 authentication from the local net only while requiring pubkey from
100 offsite. ok djm@, man page bits ok jmc@
99d804ce 101 - (dtucker) [contrib/findssl.sh] Add "which" as a shell function since some
102 platforms don't have it. Patch from dleonard at vintela.com.
56a6f96f 103 - (dtucker) [openbsd-compat/getrrsetbyname.c] Don't attempt to calloc
104 an array for signatures when there are none since "calloc(0, n) returns
105 NULL on some platforms (eg Tru64), which is explicitly permitted by
106 POSIX. Diagnosis and patch by svallet genoscope.cns.fr.
5792fbb7 107
34640ce6 10820070128
109 - (djm) [channels.c serverloop.c] Fix so-called "hang on exit" (bz #52)
110 when closing a tty session when a background process still holds tty
111 fds open. Great detective work and patch by Marc Aurele La France,
112 slightly tweaked by me; ok dtucker@
113
4b478cc5 11420070123
115 - (dtucker) [openbsd-compat/bsd-snprintf.c] Static declarations for public
116 library interfaces aren't very helpful. Fix up the DOPR_OUTCH macro
117 so it works properly and modify its callers so that they don't pre or
118 post decrement arguments that are conditionally evaluated. While there,
119 put SNPRINTF_CONST back as it prevents build failures in some
120 configurations. ok djm@ (for most of it)
121
ed9b5e5f 12220070122
123 - (djm) [ssh-rand-helper.8] manpage nits;
124 from dleonard AT vintela.com (bz#1529)
125
25bd7a2a 12620070117
127 - (dtucker) [packet.c] Re-remove in_systm.h since it's already in includes.h
128 and multiple including it causes problems on old IRIXes. (It snuck back
129 in during a sync.) Found (again) by Georg Schwarz.
130
b05ff3f5 13120070114
7ac507d4 132 - (dtucker) [ssh-keygen.c] av -> argv to match earlier sync.
0d00c5cb 133 - (djm) [openbsd-compat/bsd-snprintf.c] Fix integer overflow in return
134 value of snprintf replacement, similar to bugs in various libc
135 implementations. This overflow is not exploitable in OpenSSH.
136 While I'm fiddling with it, make it a fair bit faster by inlining the
137 append-char routine; ok dtucker@
b05ff3f5 138
4b4810d4 13920070105
140 - (djm) OpenBSD CVS Sync
141 - deraadt@cvs.openbsd.org 2006/11/14 19:41:04
142 [ssh-keygen.c]
143 use argc and argv not some made up short form
ce4cf693 144 - ray@cvs.openbsd.org 2006/11/23 01:35:11
145 [misc.c sftp.c]
146 Don't access buf[strlen(buf) - 1] for zero-length strings.
147 ``ok by me'' djm@.
4e3c0053 148 - markus@cvs.openbsd.org 2006/12/11 21:25:46
149 [ssh-keygen.1 ssh.1]
150 add rfc 4716 (public key format); ok jmc
04efe9b0 151 - djm@cvs.openbsd.org 2006/12/12 03:58:42
152 [channels.c compat.c compat.h]
153 bz #1019: some ssh.com versions apparently can't cope with the
154 remote port forwarding bind_address being a hostname, so send
155 them an address for cases where they are not explicitly
156 specified (wildcard or localhost bind). reported by daveroth AT
157 acm.org; ok dtucker@ deraadt@
75b6d52c 158 - dtucker@cvs.openbsd.org 2006/12/13 08:34:39
159 [servconf.c]
160 Make PermitOpen work with multiple values like the man pages says.
161 bz #1267 with details from peter at dmtz.com, with & ok djm@
38757197 162 - dtucker@cvs.openbsd.org 2006/12/14 10:01:14
163 [servconf.c]
164 Make "PermitOpen all" first-match within a block to match the way other
165 options work. ok markus@ djm@
5d9a4204 166 - jmc@cvs.openbsd.org 2007/01/02 09:57:25
167 [sshd_config.5]
168 do not use lists for SYNOPSIS;
169 from eric s. raymond via brad
cbaa43c0 170 - stevesk@cvs.openbsd.org 2007/01/03 00:53:38
171 [ssh-keygen.c]
172 remove small dead code; arnaud.lacombe.1@ulaval.ca via Coverity scan
4f6e2ba9 173 - stevesk@cvs.openbsd.org 2007/01/03 03:01:40
174 [auth2-chall.c channels.c dns.c sftp.c ssh-keygen.c ssh.c]
175 spaces
c9625a42 176 - stevesk@cvs.openbsd.org 2007/01/03 04:09:15
177 [sftp.c]
178 ARGSUSED for lint
9a24ac07 179 - stevesk@cvs.openbsd.org 2007/01/03 07:22:36
180 [sftp-server.c]
181 spaces
4b4810d4 182
2b563deb 18320061205
184 - (djm) [auth.c] Fix NULL pointer dereference in fakepw(). Crash would
185 occur if the server did not have the privsep user and an invalid user
186 tried to login and both privsep and krb5 auth are disabled; ok dtucker@
096393b8 187 - (djm) [bsd-asprintf.c] Better test for bad vsnprintf lengths; ok dtucker@
2b563deb 188
d4d9db8d 18920061108
190 - (dtucker) OpenBSD CVS Sync
191 - markus@cvs.openbsd.org 2006/11/07 13:02:07
192 [dh.c]
193 BN_hex2bn returns int; from dtucker@
194
4d02b823 19520061107
196 - (dtucker) [sshd.c] Use privsep_pw if we have it, but only require it
197 if we absolutely need it. Pointed out by Corinna, ok djm@
e516451d 198 - (dtucker) OpenBSD CVS Sync
199 - markus@cvs.openbsd.org 2006/11/06 21:25:28
200 [auth-rsa.c kexgexc.c kexdhs.c key.c ssh-dss.c sshd.c kexgexs.c
201 ssh-keygen.c bufbn.c moduli.c scard.c kexdhc.c sshconnect1.c dh.c rsa.c]
202 add missing checks for openssl return codes; with & ok djm@
89916e8c 203 - markus@cvs.openbsd.org 2006/11/07 10:31:31
204 [monitor.c version.h]
205 correctly check for bad signatures in the monitor, otherwise the monitor
206 and the unpriv process can get out of sync. with dtucker@, ok djm@,
207 dtucker@
5b296f76 208 - (dtucker) [README contrib/{caldera,redhat,contrib}/openssh.spec] Bump
209 versions.
4354f73b 210 - (dtucker) Release 4.5p1.
4d02b823 211
b8e51e81 21220061105
213 - (djm) OpenBSD CVS Sync
214 - otto@cvs.openbsd.org 2006/10/28 18:08:10
215 [ssh.1]
216 correct/expand example of usage of -w; ok jmc@ stevesk@
8e8b473c 217 - markus@cvs.openbsd.org 2006/10/31 16:33:12
218 [kexdhc.c kexdhs.c kexgexc.c kexgexs.c]
219 check DH_compute_key() for -1 even if it should not happen because of
220 earlier calls to dh_pub_is_valid(); report krahmer at suse.de; ok djm
b8e51e81 221
8852e1d4 22220061101
223 - (dtucker) [openbsd-compat/port-solaris.c] Bug #1255: Make only hwerr
224 events fatal in Solaris process contract support and tell it to signal
225 only processes in the same process group when something happens.
226 Based on information from andrew.benham at thus.net and similar to
227 a patch from Chad Mynhier. ok djm@
228
1acc8e56 22920061027
230- (djm) [auth.c] gc some dead code
231
b3c338b7 23220061023
233 - (djm) OpenBSD CVS Sync
234 - ray@cvs.openbsd.org 2006/09/30 17:48:22
235 [sftp.c]
236 Clear errno before calling the strtol functions.
237 From Paul Stoeber <x0001 at x dot de1 dot cc>.
238 OK deraadt@.
fceb95fa 239 - djm@cvs.openbsd.org 2006/10/06 02:29:19
240 [ssh-agent.c ssh-keyscan.c ssh.c]
241 sys/resource.h needs sys/time.h; prompted by brad@
242 (NB. Id sync only for portable)
db6fcd65 243 - djm@cvs.openbsd.org 2006/10/09 23:36:11
244 [session.c]
245 xmalloc -> xcalloc that was missed previously, from portable
246 (NB. Id sync only for portable, obviously)
77903f77 247 - markus@cvs.openbsd.org 2006/10/10 10:12:45
248 [sshconnect.c]
249 sleep before retrying (not after) since sleep changes errno; fixes
250 pr 5250; rad@twig.com; ok dtucker djm
bd3b2cb2 251 - markus@cvs.openbsd.org 2006/10/11 12:38:03
252 [clientloop.c serverloop.c]
253 exit instead of doing a blocking tcp send if we detect a client/server
254 timeout, since the tcp sendqueue might be already full (of alive
255 requests); ok dtucker, report mpf
cdfbded8 256 - djm@cvs.openbsd.org 2006/10/22 02:25:50
257 [sftp-client.c]
258 cancel progress meter when upload write fails; ok deraadt@
0f74133a 259 - (tim) [Makefile.in scard/Makefile.in] Add datarootdir= lines to keep
260 autoconf 2.60 from complaining.
b3c338b7 261
525251b0 26220061018
263 - (dtucker) OpenBSD CVS Sync
264 - ray@cvs.openbsd.org 2006/09/25 04:55:38
265 [ssh-keyscan.1 ssh.1]
266 Change "a SSH" to "an SSH". Hurray, I'm not the only one who
267 pronounces "SSH" as "ess-ess-aich".
268 OK jmc@ and stevesk@.
d1f7ec98 269 - (dtucker) [sshd.c] Reshuffle storing of pw struct; prevents warnings
270 on older versions of OS X. ok djm@
525251b0 271
8153fef1 27220061016
273 - (dtucker) [monitor_fdpass.c] Include sys/in.h, required for cmsg macros
274 on older (2.0) Linuxes. Based on patch from thmo-13 at gmx de.
275
1f231631 27620061006
277 - (tim) [buildpkg.sh.in] Use uname -r instead of -v in OS_VER for Solaris.
278 Differentiate between OpenServer 5 and OpenServer 6
5ba277eb 279 - (dtucker) [configure.ac] Set put -lselinux into $LIBS while testing for
280 SELinux functions so they're detected correctly. Patch from pebenito at
281 gentoo.org.
b18359f6 282 - (tim) [buildpkg.sh.in] Some systems have really limited nawk (OpenServer).
283 Allow setting alternate awk in openssh-config.local.
1f231631 284
aa56f760 28520061003
286 - (tim) [configure.ac] Move CHECK_HEADERS test before platform specific
287 section so additional platform specific CHECK_HEADER tests will work
288 correctly. Fixes "<net/if_tap.h> on FreeBSD" problem report by des AT des.no
289 Feedback and "seems like a good idea" dtucker@
290
00dea73e 29120061001
292 - (dtucker) [audit-bsm.c] Include errno.h. Pointed out by des at des.no.
293
24b2647b 29420060929
295 - (dtucker) [configure.ac] Bug #1239: Fix configure test for OpenSSH engine
296 support. Patch from andrew.benham at thus net.
297
243a64f1 29820060928
299 - (dtucker) [entropy.c] Bug #1238: include signal.h to fix compilation error
300 on Solaris 8 w/out /dev/random or prngd. Patch from rl at
301 math.technion.ac.il.
302
f0a2e834 30320060926
304 - (dtucker) [bufaux.h] nuke bufaux.h; it's already gone from OpenBSD and not
305 referenced any more. ok djm@
5ed1a353 306 - (dtucker) [sftp-server.8] Resync; spotted by djm@
0eb97cdf 307 - (dtucker) Release 4.4p1.
f0a2e834 308
d6336595 30920060924
310 - (tim) [configure.ac] Remove CFLAGS hack for UnixWare 1.x/2.x (added
311 to rev 1.308) to work around broken gcc 2.x header file.
312
530456f4 31320060923
314 - (dtucker) [configure.ac] Bug #1234: Put opensc libs into $LIBS rather than
315 $LDFLAGS. Patch from vapier at gentoo org.
316
c5bca5d4 31720060922
318 - (dtucker) [packet.c canohost.c] Include arpa/inet.h for htonl macros on
319 some platforms (eg HP-UX 11.00). From santhi.amirta at gmail com.
320
d3fc2aa3 32120060921
322 - (dtucker) OpenBSD CVS Sync
323 - otto@cvs.openbsd.org 2006/09/19 05:52:23
324 [sftp.c]
325 Use S_IS* macros insted of masking with S_IF* flags. The latter may
326 have multiple bits set, which lead to surprising results. Spotted by
327 Paul Stoeber, more to come. ok millert@ pedro@ jaredy@ djm@
a29c9898 328 - markus@cvs.openbsd.org 2006/09/19 21:14:08
329 [packet.c]
330 client NULL deref on protocol error; Tavis Ormandy, Google Security Team
ffbfca72 331 - (dtucker) [defines.h] Include unistd.h before defining getpgrp; fixes
332 build error on Ultrix. From Bernhard Simon.
d3fc2aa3 333
25a2779b 33420060918
335 - (dtucker) [configure.ac] On AIX, check to see if the compiler will allow
336 macro redefinitions, and if not, remove "-qlanglvl=ansi" from the flags.
337 Allows build out of the box with older VAC and XLC compilers. Found by
338 David Bronder and Bernhard Simon.
d9ed544b 339 - (dtucker) [openbsd-compat/port-aix.{c,h}] Reduce scope of includes.
340 Prevents macro redefinition warnings of "RDONLY".
25a2779b 341
f0d0e025 34220060916
343 - OpenBSD CVS Sync
344 - djm@cvs.openbsd.org 2006/09/16 19:53:37
345 [deattack.c deattack.h packet.c]
346 limit maximum work performed by the CRC compensation attack detector,
347 problem reported by Tavis Ormandy, Google Security Team;
348 ok markus@ deraadt@
95954124 349 - (djm) Add openssh.xml to .cvsignore and sort it
3fd7b98a 350 - (dtucker) [auth-pam.c] Propogate TZ environment variable to PAM auth
351 process so that any logging it does is with the right timezone. From
352 Scott Strickler, ok djm@.
bb09a477 353 - (dtucker) [monitor.c] Correctly handle auditing of single commands when
354 using Protocol 1. From jhb at freebsd.
cd3e77c4 355 - (djm) [sshd.c] Fix warning/API abuse; ok dtucker@
8e700494 356 - (dtucker) [INSTALL] Add info about audit support.
f0d0e025 357
29eadd7c 35820060912
359 - (djm) [Makefile.in buildpkg.sh.in configure.ac openssh.xml.in]
360 Support SMF in Solaris Packages if enabled by configure. Patch from
361 Chad Mynhier, tested by dtucker@
362
7238aaad 36320060911
364 - (dtucker) [cipher-aes.c] Include string.h for memcpy and friends. Noted
365 by Pekka Savola.
366
d23046e2 36720060910
368 - (dtucker) [contrib/aix/buildbff.sh] Ensure that perl is available.
36f36ba3 369 - (dtucker) [configure.ac] Add -lcrypt to let DragonFly build OOTB.
d23046e2 370
fa6edaf0 37120060909
372 - (dtucker) [openbsd-compat/bsd-snprintf.c] Add stdarg.h.
d2f401fe 373 - (dtucker) [contrib/aix/buildbff.sh] Always create privsep user.
16082eaa 374 - (dtucker) [buildpkg.sh.in] Always create privsep user. ok djm@
fa6edaf0 375
368a00c2 37620060908
377 - (dtucker) [auth-sia.c] Add includes required for build on Tru64. Patch
378 from Chris Adams.
a01f637d 379 - (dtucker) [configure.ac] The BSM header test needs time.h in some cases.
368a00c2 380
a078cbee 38120060907
382 - (djm) [sshd.c auth.c] Set up fakepw() with privsep uid/gid, so it can
383 be used to drop privilege to; fixes Solaris GSSAPI crash reported by
384 Magnus Abrante; suggestion and feedback dtucker@
385 NB. this change will require that the privilege separation user must
386 exist on all the time, not just when UsePrivilegeSeparation=yes
5cc6ddad 387 - (tim) [configure.ac] s/BROKEN_UPDWTMP/BROKEN_UPDWTMPX/ on SCO OSR6
4130b6f1 388 - (dtucker) [loginrec.c] Wrap paths.h in HAVE_PATHS_H.
15367d95 389 - (dtucker) [regress/cfgmatch.sh] stop_client is racy, so give us a better
390 chance of winning.
a078cbee 391
9286ecf2 39220060905
393 - (dtucker) [configure.ac] s/AC_DEFINES/AC_DEFINE/ spotted by Roumen Petrov.
e0f3adac 394 - (dtucker) [loginrec.c] Include paths.h for _PATH_BTMP.
9286ecf2 395
62143a41 39620060904
397 - (dtucker) [configure.ac] Define BROKEN_UPDWTMP on SCO OSR6 as the native
398 updwdtmp seems to generate invalid wtmp entries. From Roger Cornelius,
399 ok djm@
400
752994dd 40120060903
402 - (dtucker) [configure.ac openbsd-compat/openbsd-compat.h] Check for
403 declaration of writev(2) and declare it ourselves if necessary. Makes
404 the atomiciov() calls build on really old systems. ok djm@
405
b823d0b9 40620060902
407 - (dtucker) [openbsd-compat/port-irix.c] Add errno.h, found by Iain Morgan.
5e837c7b 408 - (dtucker) [ssh-keyscan.c ssh-rand-helper.c ssh.c sshconnect.c
409 openbsd-compat/bindresvport.c openbsd-compat/getrrsetbyname.c
410 openbsd-compat/port-tun.c openbsd-compat/rresvport.c] Include <arpa/inet.h>
411 for hton* and ntoh* macros. Required on (at least) HP-UX since we define
412 _XOPEN_SOURCE_EXTENDED. Found by santhi.amirta at gmail com.
b823d0b9 413
24436b92 41420060901
415 - (djm) [audit-bsm.c audit.c auth-bsdauth.c auth-chall.c auth-pam.c]
416 [auth-rsa.c auth-shadow.c auth-sia.c auth1.c auth2-chall.c]
417 [auth2-gss.c auth2-kbdint.c auth2-none.c authfd.c authfile.c]
418 [cipher-3des1.c cipher-aes.c cipher-bf1.c cipher-ctr.c clientloop.c]
419 [dh.c dns.c entropy.c gss-serv-krb5.c gss-serv.c hostfile.c kex.c]
420 [kexdhc.c kexdhs.c kexgexc.c kexgexs.c key.c loginrec.c mac.c]
421 [md5crypt.c monitor.c monitor_wrap.c readconf.c rsa.c]
422 [scard-opensc.c scard.c session.c ssh-add.c ssh-agent.c ssh-dss.c]
423 [ssh-keygen.c ssh-keysign.c ssh-rsa.c ssh.c sshconnect.c]
aa751414 424 [sshconnect1.c sshconnect2.c sshd.c]
24436b92 425 [openbsd-compat/bsd-cray.c openbsd-compat/port-aix.c]
426 [openbsd-compat/port-linux.c openbsd-compat/port-solaris.c]
427 [openbsd-compat/port-uw.c]
428 Lots of headers for SCO OSR6, mainly adding stdarg.h for log.h;
429 compile problems reported by rac AT tenzing.org
aa751414 430 - (djm) [includes.h monitor.c openbsd-compat/bindresvport.c]
431 [openbsd-compat/rresvport.c] Some more headers: netinet/in.h
432 sys/socket.h and unistd.h in various places
dd41ba6f 433 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Fix implict declaration
434 warnings for binary_open and binary_close. Patch from Corinna Vinschen.
78888bab 435 - (dtucker) [configure.ac includes.h openbsd-compat/glob.{c,h}] Explicitly
436 test for GLOB_NOMATCH and use our glob functions if it's not found.
437 Stops sftp from segfaulting when attempting to get a nonexistent file on
438 Cygwin (previous versions of OpenSSH didn't use the native glob). Partly
439 from and tested by Corinna Vinschen.
cdc9d1fc 440 - (dtucker) [README contrib/{caldera,redhat,suse}/openssh.spec] Crank
441 versions.
24436b92 442
5b84789f 44320060831
444 - (djm) [CREDITS LICENCE Makefile.in auth.c configure.ac includes.h ]
445 [platform.c platform.h sshd.c openbsd-compat/Makefile.in]
446 [openbsd-compat/openbsd-compat.h openbsd-compat/port-solaris.c]
447 [openbsd-compat/port-solaris.h] Add support for Solaris process
448 contracts, enabled with --use-solaris-contracts. Patch from Chad
449 Mynhier, tweaked by dtucker@ and myself; ok dtucker@
77f7d474 450 - (dtucker) [contrib/cygwin/ssh-host-config] Add SeTcbPrivilege privilege
451 while setting up the ssh service account. Patch from Corinna Vinschen.
5b84789f 452
e9f2e744 45320060830
454 - (djm) OpenBSD CVS Sync
455 - dtucker@cvs.openbsd.org 2006/08/21 08:14:01
456 [sshd_config.5]
457 Document HostbasedUsesNameFromPacketOnly. Corrections from jmc@,
458 ok jmc@ djm@
5f047fbc 459 - dtucker@cvs.openbsd.org 2006/08/21 08:15:57
460 [sshd.8]
461 Add more detail about what permissions are and aren't accepted for
462 authorized_keys files. Corrections jmc@, ok djm@, "looks good" jmc@
0875ae22 463 - djm@cvs.openbsd.org 2006/08/29 10:40:19
464 [channels.c session.c]
465 normalise some inconsistent (but harmless) NULL pointer checks
466 spotted by the Stanford SATURN tool, via Isil Dillig;
467 ok markus@ deraadt@
b4f8e1cb 468 - dtucker@cvs.openbsd.org 2006/08/29 12:02:30
469 [gss-genr.c]
470 Work around a problem in Heimdal that occurs when KRB5CCNAME file is
471 missing, by checking whether or not kerberos allocated us a context
472 before attempting to free it. Patch from Simon Wilkinson, tested by
473 biorn@, ok djm@
3223b72f 474 - dtucker@cvs.openbsd.org 2006/08/30 00:06:51
475 [sshconnect2.c]
476 Fix regression where SSH2 banner is printed at loglevels ERROR and FATAL
477 where previously it weren't. bz #1221, found by Dean Kopesky, ok djm@
76970201 478 - djm@cvs.openbsd.org 2006/08/30 00:14:37
479 [version.h]
480 crank to 4.4
9d68c41d 481 - (djm) [openbsd-compat/xcrypt.c] needs unistd.h
6545dd0b 482 - (dtucker) [auth.c openbsd-compat/port-aix.c] Bug #1207: always call
483 loginsuccess on AIX immediately after authentication to clear the failed
484 login count. Previously this would only happen when an interactive
485 session starts (ie when a pty is allocated) but this means that accounts
486 that have primarily non-interactive sessions (eg scp's) may gradually
487 accumulate enough failures to lock out an account. This change may have
488 a side effect of creating two audit records, one with a tty of "ssh"
489 corresponding to the authentication and one with the allocated pty per
490 interactive session.
e9f2e744 491
48a7de26 49220060824
493 - (dtucker) [openbsd-compat/basename.c] Include errno.h.
8151aaa5 494 - (dtucker) [openbsd-compat/bsd-misc.c] Add includes needed for select(2) on
495 older systems.
ab26f490 496 - (dtucker) [openbsd-compat/bsd-misc.c] Include <sys/select.h> for select(2)
497 on POSIX systems.
6beea87c 498 - (dtucker) [openbsd-compat/bsd-openpty.c] Include for ioctl(2).
e429fba8 499 - (dtucker) [openbsd-compat/rresvport.c] Include <stdlib.h> for malloc.
f07855f7 500 - (dtucker) [openbsd-compat/xmmap.c] Move #define HAVE_MMAP to prevent
501 unused variable warning when we have a broken or missing mmap(2).
48a7de26 502
c1a1c295 50320060822
504 - (dtucker) [Makefile.in] Bug #1177: fix incorrect path for sshrc in
505 Makefile. Patch from santhi.amirta at gmail, ok djm.
506
9895d518 50720060820
508 - (dtucker) [log.c] Move ifdef to prevent unused variable warning.
08fb8ce9 509 - (dtucker) [configure.ac] Save $LIBS during PAM library tests and restore
510 afterward. Removes the need to mangle $LIBS later to remove -lpam and -ldl.
a086f73b 511 - (dtucker) [configure.ac] Relocate --with-pam parts in preparation for
512 fixing bug #1181. No changes yet.
282d6408 513 - (dtucker) [configure.ac] Bug #1181: Explicitly test to see if OpenSSL
514 (0.9.8a and presumably newer) requires -ldl to successfully link.
08164407 515 - (dtucker) [configure.ac] Remove errant "-".
9895d518 516
94d458e8 51720060819
518 - (djm) OpenBSD CVS Sync
519 - djm@cvs.openbsd.org 2006/08/18 22:41:29
520 [gss-genr.c]
521 GSSAPI error code should be 0 and not -1; from simon@sxw.org.uk
ea83a498 522 - (dtucker) [openbsd-compat/regress/Makefile.in] Add $(EXEEXT) and add a
523 single rule for the test progs.
94d458e8 524
795e7517 52520060818
526 - (dtucker) [configure.ac openbsd-compat/bsd-closefrom.c] Resync with
527 closefrom.c from sudo.
5a1d6300 528 - (dtucker) [openbsd-compat/bsd-closefrom.c] Comment out rcsid.
fed313fd 529 - (dtucker) [openbsd-compat/regress/snprintftest.c] Newline on error.
d5498c58 530 - (dtucker) [openbsd-compat/regress/Makefile.in] Use implicit rules for the
531 test progs instead; they work better than what we have.
78372b6e 532 - (djm) OpenBSD CVS Sync
533 - stevesk@cvs.openbsd.org 2006/08/06 01:13:32
534 [compress.c monitor.c monitor_wrap.c]
535 "zlib.h" can be <zlib.h>; ok djm@ markus@
ba52fb56 536 - miod@cvs.openbsd.org 2006/08/12 20:46:46
537 [monitor.c monitor_wrap.c]
538 Revert previous include file ordering change, for ssh to compile under
539 gcc2 (or until openssl include files are cleaned of parameter names
540 in function prototypes)
fa47fe3c 541 - dtucker@cvs.openbsd.org 2006/08/14 12:40:25
542 [servconf.c servconf.h sshd_config.5]
543 Add ability to match groups to Match keyword in sshd_config. Feedback
544 djm@, stevesk@, ok stevesk@.
e07335e2 545 - djm@cvs.openbsd.org 2006/08/16 11:47:15
546 [sshd.c]
547 factor inetd connection, TCP listen and main TCP accept loop out of
548 main() into separate functions to improve readability; ok markus@
28463427 549 - deraadt@cvs.openbsd.org 2006/08/18 09:13:26
550 [log.c log.h sshd.c]
551 make signal handler termination path shorter; risky code pointed out by
552 mark dowd; ok djm markus
184cb418 553 - markus@cvs.openbsd.org 2006/08/18 09:15:20
554 [auth.h session.c sshd.c]
555 delay authentication related cleanups until we're authenticated and
556 all alarms have been cancelled; ok deraadt
b2af4ca8 557 - djm@cvs.openbsd.org 2006/08/18 10:27:16
558 [misc.h]
559 reorder so prototypes are sorted by the files they refer to; no
560 binary change
592de384 561 - djm@cvs.openbsd.org 2006/08/18 13:54:54
562 [gss-genr.c ssh-gss.h sshconnect2.c]
563 bz #1218 - disable SPNEGO as per RFC4462; diff from simon AT sxw.org.uk
564 ok markus@
abb47f1e 565 - djm@cvs.openbsd.org 2006/08/18 14:40:34
566 [gss-genr.c ssh-gss.h]
567 constify host argument to match the rest of the GSSAPI functions and
568 unbreak compilation with -Werror
c79c4814 569 - (djm) Disable sigdie() for platforms that cannot safely syslog inside
570 a signal handler (basically all of them, excepting OpenBSD);
571 ok dtucker@
795e7517 572
f8688ddd 57320060817
574 - (dtucker) [openbsd-compat/fake-rfc2553.c openbsd-compat/setproctitle.c]
575 Include stdlib.h for malloc and friends.
53c337ed 576 - (dtucker) [configure.ac openbsd-compat/bsd-closefrom.c] Use F_CLOSEM fcntl
577 for closefrom() on AIX. Pointed out by William Ahern.
98cc66aa 578 - (dtucker) [openbsd-compat/regress/{Makefile.in,closefromtest.c}] Regress
579 test for closefrom() in compat code.
f8688ddd 580
5388904a 58120060816
582 - (djm) [audit-bsm.c] Sprinkle in some headers
583
4a86d8eb 58420060815
585 - (dtucker) [LICENCE] Add Reyk to the list for the compat dir.
586
3a5b6088 58720060806
588 - (djm) [openbsd-compat/bsd-getpeereid.c] Add some headers to quiet warnings
589 on Solaris 10
590
59120060806
149abacb 592 - (dtucker) [defines.h] With the includes.h changes we no longer get the
593 name clash on "YES" so we can remove the workaround for it.
442a6515 594 - (dtucker) [openbsd-compat/{bsd-asprintf.c,bsd-openpty.c,bsd-snprintf.c,
595 glob.c}] Include stdlib.h for malloc and friends in compat code.
149abacb 596
fee76795 59720060805
598 - (djm) OpenBSD CVS Sync
599 - stevesk@cvs.openbsd.org 2006/07/24 13:58:22
600 [sshconnect.c]
601 disable tunnel forwarding when no strict host key checking
602 and key changed; ok djm@ markus@ dtucker@
912da635 603 - stevesk@cvs.openbsd.org 2006/07/25 02:01:34
604 [scard.c]
605 need #include <string.h>
e264ac72 606 - stevesk@cvs.openbsd.org 2006/07/25 02:59:21
607 [channels.c clientloop.c packet.c scp.c serverloop.c sftp-client.c]
608 [sftp-server.c ssh-agent.c ssh-keyscan.c sshconnect.c sshd.c]
609 move #include <sys/time.h> out of includes.h
536c14e8 610 - stevesk@cvs.openbsd.org 2006/07/26 02:35:17
611 [atomicio.c auth.c dh.c authfile.c buffer.c clientloop.c kex.c]
612 [groupaccess.c gss-genr.c kexgexs.c misc.c monitor.c monitor_mm.c]
613 [packet.c scp.c serverloop.c session.c sftp-client.c sftp-common.c]
614 [sftp-server.c sftp.c ssh-add.c ssh-agent.c ssh-keygen.c sshlogin.c]
615 [uidswap.c xmalloc.c]
616 move #include <sys/param.h> out of includes.h
ffa517a8 617 - stevesk@cvs.openbsd.org 2006/07/26 13:57:17
618 [authfd.c authfile.c dh.c canohost.c channels.c clientloop.c compat.c]
619 [hostfile.c kex.c log.c misc.c moduli.c monitor.c packet.c readpass.c]
620 [scp.c servconf.c session.c sftp-server.c sftp.c ssh-add.c ssh-agent.c]
621 [ssh-keygen.c ssh-keyscan.c ssh-keysign.c ssh.c sshconnect.c]
622 [sshconnect1.c sshd.c xmalloc.c]
623 move #include <stdlib.h> out of includes.h
f0817fbb 624 - jmc@cvs.openbsd.org 2006/07/27 08:00:50
625 [ssh_config.5]
626 avoid confusing wording in HashKnownHosts:
627 originally spotted by alan amesbury;
628 ok deraadt
38b37661 629 - jmc@cvs.openbsd.org 2006/07/27 08:00:50
630 [ssh_config.5]
631 avoid confusing wording in HashKnownHosts:
632 originally spotted by alan amesbury;
633 ok deraadt
331c3884 634 - dtucker@cvs.openbsd.org 2006/08/01 11:34:36
635 [sshconnect.c]
636 Allow fallback to known_hosts entries without port qualifiers for
637 non-standard ports too, so that all existing known_hosts entries will be
638 recognised. Requested by, feedback and ok markus@
cf851879 639 - stevesk@cvs.openbsd.org 2006/08/01 23:22:48
640 [auth-passwd.c auth-rhosts.c auth-rsa.c auth.c auth.h auth1.c]
641 [auth2-chall.c auth2-pubkey.c authfile.c buffer.c canohost.c]
642 [channels.c clientloop.c dh.c dns.c dns.h hostfile.c kex.c kexdhc.c]
643 [kexgexc.c kexgexs.c key.c key.h log.c misc.c misc.h moduli.c]
644 [monitor_wrap.c packet.c progressmeter.c readconf.c readpass.c scp.c]
645 [servconf.c session.c sftp-client.c sftp-common.c sftp-server.c sftp.c]
646 [ssh-add.c ssh-agent.c ssh-keygen.c ssh-keyscan.c ssh.c sshconnect.c]
647 [sshconnect1.c sshconnect2.c sshd.c sshlogin.c sshtty.c uuencode.c]
648 [uuencode.h xmalloc.c]
649 move #include <stdio.h> out of includes.h
d4f40d92 650 - stevesk@cvs.openbsd.org 2006/08/01 23:36:12
651 [authfile.c channels.c progressmeter.c scard.c servconf.c ssh.c]
652 clean extra spaces
31652869 653 - deraadt@cvs.openbsd.org 2006/08/03 03:34:42
654 [OVERVIEW atomicio.c atomicio.h auth-bsdauth.c auth-chall.c auth-krb5.c]
655 [auth-options.c auth-options.h auth-passwd.c auth-rh-rsa.c auth-rhosts.c]
656 [auth-rsa.c auth-skey.c auth.c auth.h auth1.c auth2-chall.c auth2-gss.c]
657 [auth2-hostbased.c auth2-kbdint.c auth2-none.c auth2-passwd.c ]
658 [auth2-pubkey.c auth2.c authfd.c authfd.h authfile.c bufaux.c bufbn.c]
659 [buffer.c buffer.h canohost.c channels.c channels.h cipher-3des1.c]
660 [cipher-bf1.c cipher-ctr.c cipher.c cleanup.c clientloop.c compat.c]
661 [compress.c deattack.c dh.c dispatch.c dns.c dns.h fatal.c groupaccess.c]
662 [groupaccess.h gss-genr.c gss-serv-krb5.c gss-serv.c hostfile.c kex.c]
663 [kex.h kexdh.c kexdhc.c kexdhs.c kexgex.c kexgexc.c kexgexs.c key.c]
664 [key.h log.c log.h mac.c match.c md-sha256.c misc.c misc.h moduli.c]
665 [monitor.c monitor_fdpass.c monitor_mm.c monitor_mm.h monitor_wrap.c]
666 [monitor_wrap.h msg.c nchan.c packet.c progressmeter.c readconf.c]
667 [readconf.h readpass.c rsa.c scard.c scard.h scp.c servconf.c servconf.h]
668 [serverloop.c session.c session.h sftp-client.c sftp-common.c]
669 [sftp-common.h sftp-glob.c sftp-server.c sftp.c ssh-add.c ssh-agent.c]
670 [ssh-dss.c ssh-gss.h ssh-keygen.c ssh-keyscan.c ssh-keysign.c ssh-rsa.c]
671 [ssh.c ssh.h sshconnect.c sshconnect.h sshconnect1.c sshconnect2.c]
672 [sshd.c sshlogin.c sshlogin.h sshpty.c sshpty.h sshtty.c ttymodes.c]
673 [uidswap.c uidswap.h uuencode.c uuencode.h xmalloc.c xmalloc.h]
674 [loginrec.c loginrec.h openbsd-compat/port-aix.c openbsd-compat/port-tun.h]
675 almost entirely get rid of the culture of ".h files that include .h files"
676 ok djm, sort of ok stevesk
677 makes the pain stop in one easy step
678 NB. portable commit contains everything *except* removing includes.h, as
679 that will take a fair bit more work as we move headers that are required
680 for portability workarounds to defines.h. (also, this step wasn't "easy")
c56969f9 681 - stevesk@cvs.openbsd.org 2006/08/04 20:46:05
682 [monitor.c session.c ssh-agent.c]
683 spaces
8bdc7aa0 684 - (djm) [auth-pam.c defines.h] Move PAM related bits to auth-pam.c
693a35d3 685 - (djm) [auth-pam.c auth.c bufaux.h entropy.c openbsd-compat/port-tun.c]
686 remove last traces of bufaux.h - it was merged into buffer.h in the big
687 includes.h commit
8ad2db2a 688 - (djm) [auth.c loginrec.c] Missing netinet/in.h for loginrec
8d3106fd 689 - (djm) [openbsd-compat/regress/snprintftest.c]
690 [openbsd-compat/regress/strduptest.c] Add missing includes so they pass
691 compilation with "-Wall -Werror"
00a017bd 692 - (djm) [auth-pam.c auth-shadow.c auth2-none.c cleanup.c sshd.c]
693 [openbsd-compat/port-tun.c openbsd-compat/port-tun.h] Sprinkle more
694 includes for Linux in
ccc09f5c 695 - (dtucker) [cleanup.c] Need defines.h for __dead.
9ae6b834 696 - (dtucker) [auth2-gss.c] We still need the #ifdef GSSAPI in -portable.
f2265d5d 697 - (dtucker) [openbsd-compat/{bsd-arc4random.c,port-tun.c,xmmap.c}] Lots of
698 #include stdarg.h, needed for log.h.
5be9f803 699 - (dtucker) [entropy.c] Needs unistd.h too.
35d1c2de 700 - (dtucker) [ssh-rand-helper.c] Needs stdarg.h for log.h.
76e03684 701 - (dtucker) [openbsd-compat/getrrsetbyname.c] Nees stdlib.h for malloc.
5946a69f 702 - (dtucker) [openbsd-compat/strtonum.c] Include stdlib.h for strtoll,
703 otherwise it is implicitly declared as returning an int.
428f6258 704 - (dtucker) OpenBSD CVS Sync
705 - dtucker@cvs.openbsd.org 2006/08/05 07:52:52
706 [auth2-none.c sshd.c monitor_wrap.c]
707 Add headers required to build with KERBEROS5=no. ok djm@
453cb7e7 708 - dtucker@cvs.openbsd.org 2006/08/05 08:00:33
709 [auth-skey.c]
710 Add headers required to build with -DSKEY. ok djm@
cecc422f 711 - dtucker@cvs.openbsd.org 2006/08/05 08:28:24
712 [monitor_wrap.c auth-skey.c auth2-chall.c]
713 Zap unused variables in -DSKEY code. ok djm@
0e13ec0f 714 - dtucker@cvs.openbsd.org 2006/08/05 08:34:04
715 [packet.c]
716 Typo in comment
97ea266c 717 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Add headers required to compile
718 on Cygwin.
e3220bb2 719 - (dtucker) [openbsd-compat/fake-rfc2553.c] Add headers needed for inet_ntoa.
f3296bc4 720 - (dtucker) [auth-skey.c] monitor_wrap.h needs ssh-gss.h.
0e23dc86 721 - (dtucker) [audit.c audit.h] Repair headers.
6f54ce27 722 - (dtucker) [audit-bsm.c] Add additional headers now required.
fee76795 723
3e05aa50 72420060804
725 - (dtucker) [configure.ac] The "crippled AES" test does not work on recent
726 versions of Solaris, so use AC_LINK_IFELSE to actually link the test program
727 rather than just compiling it. Spotted by dlg@.
728
53d4ae20 72920060802
730 - (dtucker) [openbsd-compat/daemon.c] Add unistd.h for fork() prototype.
731
be350da6 73220060725
733 - (dtucker) [openbsd-compat/xmmap.c] Need fcntl.h for O_RDRW.
734
14e980ef 73520060724
736 - (djm) OpenBSD CVS Sync
737 - jmc@cvs.openbsd.org 2006/07/12 13:39:55
738 [sshd_config.5]
739 - new sentence, new line
740 - s/The the/The/
741 - kill a bad comma
c8dfff33 742 - stevesk@cvs.openbsd.org 2006/07/12 22:28:52
742bee8c 743 [auth-options.c canohost.c channels.c includes.h readconf.c]
744 [servconf.c ssh-keyscan.c ssh.c sshconnect.c sshd.c]
c8dfff33 745 move #include <netdb.h> out of includes.h; ok djm@
bcaab305 746 - stevesk@cvs.openbsd.org 2006/07/12 22:42:32
747 [includes.h ssh.c ssh-rand-helper.c]
748 move #include <stddef.h> out of includes.h
d2a69816 749 - stevesk@cvs.openbsd.org 2006/07/14 01:15:28
750 [monitor_wrap.h]
751 don't need incompletely-typed 'struct passwd' now with
752 #include <pwd.h>; ok markus@
5188ba17 753 - stevesk@cvs.openbsd.org 2006/07/17 01:31:10
754 [authfd.c authfile.c channels.c cleanup.c clientloop.c groupaccess.c]
755 [includes.h log.c misc.c msg.c packet.c progressmeter.c readconf.c]
756 [readpass.c scp.c servconf.c sftp-client.c sftp-server.c sftp.c]
757 [ssh-add.c ssh-agent.c ssh-keygen.c ssh-keyscan.c ssh-keysign.c ssh.c]
758 [sshconnect.c sshlogin.c sshpty.c uidswap.c]
759 move #include <unistd.h> out of includes.h
774de098 760 - dtucker@cvs.openbsd.org 2006/07/17 12:02:24
761 [auth-options.c]
762 Use '\0' rather than 0 to terminates strings; ok djm@
2fefbadf 763 - dtucker@cvs.openbsd.org 2006/07/17 12:06:00
764 [channels.c channels.h servconf.c sshd_config.5]
765 Add PermitOpen directive to sshd_config which is equivalent to the
766 "permitopen" key option. Allows server admin to allow TCP port
767 forwarding only two specific host/port pairs. Useful when combined
768 with Match.
769 If permitopen is used in both sshd_config and a key option, both
770 must allow a given connection before it will be permitted.
771 Note that users can still use external forwarders such as netcat,
772 so to be those must be controlled too for the limits to be effective.
773 Feedback & ok djm@, man page corrections & ok jmc@.
f22506ff 774 - jmc@cvs.openbsd.org 2006/07/18 07:50:40
775 [sshd_config.5]
776 tweak; ok dtucker
578d2b99 777 - jmc@cvs.openbsd.org 2006/07/18 07:56:28
778 [scp.1]
779 replace DIAGNOSTICS with .Ex;
874d319b 780 - jmc@cvs.openbsd.org 2006/07/18 08:03:09
781 [ssh-agent.1 sshd_config.5]
782 mark up angle brackets;
4895f836 783 - dtucker@cvs.openbsd.org 2006/07/18 08:22:23
784 [sshd_config.5]
785 Clarify description of Match, with minor correction from jmc@
62e12ffe 786 - stevesk@cvs.openbsd.org 2006/07/18 22:27:55
787 [dh.c]
788 remove unneeded includes; ok djm@
691712e0 789 - dtucker@cvs.openbsd.org 2006/07/19 08:56:41
790 [servconf.c sshd_config.5]
791 Add support for X11Forwaring, X11DisplayOffset and X11UseLocalhost to
792 Match. ok djm@
e7259e8d 793 - dtucker@cvs.openbsd.org 2006/07/19 13:07:10
794 [servconf.c servconf.h session.c sshd.8 sshd_config sshd_config.5]
795 Add ForceCommand keyword to sshd_config, equivalent to the "command="
796 key option, man page entry and example in sshd_config.
797 Feedback & ok djm@, man page corrections & ok jmc@
67514848 798 - stevesk@cvs.openbsd.org 2006/07/20 15:26:15
799 [auth1.c serverloop.c session.c sshconnect2.c]
800 missed some needed #include <unistd.h> when KERBEROS5=no; issue from
801 massimo@cedoc.mo.it
ea46e550 802 - dtucker@cvs.openbsd.org 2006/07/21 12:43:36
803 [channels.c channels.h servconf.c servconf.h sshd_config.5]
804 Make PermitOpen take a list of permitted ports and act more like most
805 other keywords (ie the first match is the effective setting). This
806 also makes it easier to override a previously set PermitOpen. ok djm@
ebb90778 807 - stevesk@cvs.openbsd.org 2006/07/21 21:13:30
808 [channels.c]
809 more ARGSUSED (lint) for dispatch table-driven functions; ok djm@
c88c3fb9 810 - stevesk@cvs.openbsd.org 2006/07/21 21:26:55
811 [progressmeter.c]
812 ARGSUSED for signal handler
b0f6943a 813 - stevesk@cvs.openbsd.org 2006/07/22 19:08:54
814 [includes.h moduli.c progressmeter.c scp.c sftp-common.c]
815 [sftp-server.c ssh-agent.c sshlogin.c]
816 move #include <time.h> out of includes.h
00146caa 817 - stevesk@cvs.openbsd.org 2006/07/22 20:48:23
818 [atomicio.c auth-options.c auth-passwd.c auth-rhosts.c auth-rsa.c]
819 [auth.c auth1.c auth2-chall.c auth2-hostbased.c auth2-passwd.c auth2.c]
820 [authfd.c authfile.c bufaux.c bufbn.c buffer.c canohost.c channels.c]
821 [cipher-3des1.c cipher-bf1.c cipher-ctr.c cipher.c clientloop.c]
822 [compat.c deattack.c dh.c dns.c gss-genr.c gss-serv.c hostfile.c]
823 [includes.h kex.c kexdhc.c kexdhs.c kexgexc.c kexgexs.c key.c log.c]
824 [mac.c match.c md-sha256.c misc.c moduli.c monitor.c monitor_fdpass.c]
825 [monitor_mm.c monitor_wrap.c msg.c nchan.c packet.c rsa.c]
826 [progressmeter.c readconf.c readpass.c scp.c servconf.c serverloop.c]
827 [session.c sftp-client.c sftp-common.c sftp-glob.c sftp-server.c sftp.c]
828 [ssh-add.c ssh-agent.c ssh-dss.c ssh-keygen.c ssh-keyscan.c]
829 [ssh-keysign.c ssh-rsa.c ssh.c sshconnect.c sshconnect1.c sshconnect2.c]
830 [sshd.c sshlogin.c sshpty.c ttymodes.c uidswap.c xmalloc.c]
831 move #include <string.h> out of includes.h
519fc2b7 832 - stevesk@cvs.openbsd.org 2006/07/23 01:11:05
833 [auth.h dispatch.c kex.h sftp-client.c]
834 #include <signal.h> for sig_atomic_t; need this prior to <sys/param.h>
835 move
28cb0a43 836 - (djm) [acss.c auth-krb5.c auth-options.c auth-pam.c auth-shadow.c]
837 [canohost.c channels.c cipher-acss.c defines.h dns.c gss-genr.c]
838 [gss-serv-krb5.c gss-serv.c log.h loginrec.c logintest.c readconf.c]
839 [servconf.c ssh-keygen.c ssh-keyscan.c ssh-keysign.c ssh-rand-helper.c]
840 [ssh.c sshconnect.c sshd.c openbsd-compat/bindresvport.c]
841 [openbsd-compat/bsd-arc4random.c openbsd-compat/bsd-misc.c]
842 [openbsd-compat/getrrsetbyname.c openbsd-compat/glob.c]
843 [openbsd-compat/mktemp.c openbsd-compat/port-linux.c]
844 [openbsd-compat/port-tun.c openbsd-compat/readpassphrase.c]
845 [openbsd-compat/setproctitle.c openbsd-compat/xmmap.c]
846 make the portable tree compile again - sprinkle unistd.h and string.h
847 back in. Don't redefine __unused, as it turned out to be used in
848 headers on Linux, and replace its use in auth-pam.c with ARGSUSED
ba1e6121 849 - (djm) [openbsd-compat/glob.c]
850 Move get_arg_max() into the ifdef HAVE_GLOB block so that it compiles
851 on OpenBSD (or other platforms with a decent glob implementation) with
852 -Werror
25523747 853 - (djm) [uuencode.c]
854 Add resolv.h, is it contains the prototypes for __b64_ntop/__b64_pton on
855 some platforms
9b09381d 856 - (djm) [session.c]
857 fix compile error with -Werror -Wall: 'path' is only used in
858 do_setup_env() if HAVE_LOGIN_CAP is not defined
e204f3ee 859 - (djm) [openbsd-compat/basename.c openbsd-compat/bsd-closefrom.c]
860 [openbsd-compat/bsd-cray.c openbsd-compat/bsd-openpty.c]
861 [openbsd-compat/bsd-snprintf.c openbsd-compat/fake-rfc2553.c]
862 [openbsd-compat/port-aix.c openbsd-compat/port-irix.c]
863 [openbsd-compat/rresvport.c]
864 These look to need string.h and/or unistd.h (based on a grep for function
865 names)
f40c8634 866 - (djm) [Makefile.in]
867 Remove generated openbsd-compat/regress/Makefile in distclean target
e7c5b206 868 - (djm) [regress/Makefile regress/agent-getpeereid.sh regress/cfgmatch.sh]
869 [regress/cipher-speed.sh regress/forcecommand.sh regress/forwarding.sh]
870 Sync regress tests to -current; include dtucker@'s new cfgmatch and
871 forcecommand tests. Add cipher-speed.sh test (not linked in yet)
30872a12 872 - (dtucker) [cleanup.c] Since config.h defines _LARGE_FILES on AIX, including
873 system headers before defines.h will cause conflicting definitions.
b64d983b 874 - (dtucker) [regress/forcecommand.sh] Portablize.
e204f3ee 875
4352744e 87620060713
877 - (dtucker) [auth-krb5.c auth-pam.c] Still more errno.h
878
956d6743 87920060712
294d3ca5 880 - (dtucker) [configure.ac defines.h] Only define SHUT_RD (and friends) and
881 O_NONBLOCK if they're really needed. Fixes build errors on HP-UX, old
882 Linuxes and probably more.
71f4c727 883 - (dtucker) [configure.ac] OpenBSD needs <sys/types.h> before <sys/socket.h>
884 for SHUT_RD.
f9d5c000 885 - (dtucker) [openbsd-compat/port-tun.c] OpenBSD needs <netinet/in.h> before
886 <netinet/ip.h>.
a773acf7 887 - (dtucker) OpenBSD CVS Sync
888 - stevesk@cvs.openbsd.org 2006/07/10 16:01:57
889 [sftp-glob.c sftp-common.h sftp.c]
890 buffer.h only needed in sftp-common.h and remove some unneeded
891 user includes; ok djm@
a0bca6ed 892 - jmc@cvs.openbsd.org 2006/07/10 16:04:21
893 [sshd.8]
894 s/and and/and/
4c72fcfd 895 - stevesk@cvs.openbsd.org 2006/07/10 16:37:36
896 [readpass.c log.h scp.c fatal.c xmalloc.c includes.h ssh-keyscan.c misc.c
897 auth.c packet.c log.c]
898 move #include <stdarg.h> out of includes.h; ok markus@
0ad62016 899 - dtucker@cvs.openbsd.org 2006/07/11 10:12:07
900 [ssh.c]
901 Only copy the part of environment variable that we actually use. Prevents
902 ssh bailing when SendEnv is used and an environment variable with a really
903 long value exists. ok djm@
42ea6f5e 904 - markus@cvs.openbsd.org 2006/07/11 18:50:48
905 [clientloop.c ssh.1 ssh.c channels.c ssh_config.5 readconf.h session.c
906 channels.h readconf.c]
907 add ExitOnForwardFailure: terminate the connection if ssh(1)
908 cannot set up all requested dynamic, local, and remote port
909 forwardings. ok djm, dtucker, stevesk, jmc
028094f4 910 - stevesk@cvs.openbsd.org 2006/07/11 20:07:25
911 [scp.c auth.c monitor.c serverloop.c sftp-server.c sshpty.c readpass.c
912 sshd.c monitor_wrap.c monitor_fdpass.c ssh-agent.c ttymodes.c atomicio.c
913 includes.h session.c sshlogin.c monitor_mm.c packet.c sshconnect2.c
914 sftp-client.c nchan.c clientloop.c sftp.c misc.c canohost.c channels.c
915 ssh-keygen.c progressmeter.c uidswap.c msg.c readconf.c sshconnect.c]
916 move #include <errno.h> out of includes.h; ok markus@
00c8971b 917 - stevesk@cvs.openbsd.org 2006/07/11 20:16:43
918 [ssh.c]
919 cast asterisk field precision argument to int to remove warning;
920 ok markus@
dd984467 921 - stevesk@cvs.openbsd.org 2006/07/11 20:27:56
922 [authfile.c ssh.c]
923 need <errno.h> here also (it's also included in <openssl/err.h>)
d231781a 924 - dtucker@cvs.openbsd.org 2006/07/12 11:34:58
925 [sshd.c servconf.h servconf.c sshd_config.5 auth.c]
926 Add support for conditional directives to sshd_config via a "Match"
927 keyword, which works similarly to the "Host" directive in ssh_config.
928 Lines after a Match line override the default set in the main section
929 if the condition on the Match line is true, eg
930 AllowTcpForwarding yes
931 Match User anoncvs
932 AllowTcpForwarding no
933 will allow port forwarding by all users except "anoncvs".
934 Currently only a very small subset of directives are supported.
935 ok djm@
fec71b2f 936 - (dtucker) [loginrec.c openbsd-compat/xmmap.c openbsd-compat/bindresvport.c
937 openbsd-compat/glob.c openbsd-compat/mktemp.c openbsd-compat/port-tun.c
938 openbsd-compat/readpassphrase.c openbsd-compat/strtonum.c] Include <errno.h>.
baede55a 939 - (dtucker) [openbsd-compat/setproctitle.c] Include stdarg.h.
403a29ac 940 - (dtucker) [ssh-keyscan.c ssh-rand-helper.c] More errno.h here too.
5f8747dc 941 - (dtucker) [openbsd-compat/openbsd-compat.h] v*printf needs stdarg.h.
4f4b7d4d 942 - (dtucker) [openbsd-compat/bsd-asprintf.c openbsd-compat/port-aix.c
943 openbsd-compat/rresvport.c] More errno.h.
944
37259a8e 94520060711
946 - (dtucker) [configure.ac ssh-keygen.c openbsd-compat/bsd-openpty.c
947 openbsd-compat/daemon.c] Add includes needed by open(2). Conditionally
948 include paths.h. Fixes build error on Solaris.
2edd133e 949 - (dtucker) [entropy.c] More fcntl.h, this time on AIX (and probably
950 others).
37259a8e 951
44064ac4 95220060710
953 - (dtucker) [INSTALL] New autoconf version: 2.60.
e5c76324 954 - OpenBSD CVS Sync
955 - djm@cvs.openbsd.org 2006/06/14 10:50:42
956 [sshconnect.c]
957 limit the number of pre-banner characters we will accept; ok markus@
9f1090be 958 - djm@cvs.openbsd.org 2006/06/26 10:36:15
959 [clientloop.c]
960 mention optional bind_address in runtime port forwarding setup
961 command-line help. patch from santhi.amirta AT gmail.com
06fa4ac1 962 - stevesk@cvs.openbsd.org 2006/07/02 17:12:58
963 [ssh.1 ssh.c ssh_config.5 sshd_config.5]
964 more details and clarity for tun(4) device forwarding; ok and help
965 jmc@
6955279c 966 - stevesk@cvs.openbsd.org 2006/07/02 18:36:47
967 [gss-serv-krb5.c gss-serv.c]
968 no "servconf.h" needed here
969 (gss-serv-krb5.c change not applied, portable needs the server options)
16fbe330 970 - stevesk@cvs.openbsd.org 2006/07/02 22:45:59
971 [groupaccess.c groupaccess.h includes.h session.c sftp-common.c sshpty.c]
972 move #include <grp.h> out of includes.h
973 (portable needed uidswap.c too)
33f13fa5 974 - stevesk@cvs.openbsd.org 2006/07/02 23:01:55
975 [clientloop.c ssh.1]
976 use -KR[bind_address:]port here; ok djm@
28015df4 977 - stevesk@cvs.openbsd.org 2006/07/03 08:54:20
978 [includes.h ssh.c sshconnect.c sshd.c]
979 move #include "version.h" out of includes.h; ok markus@
319d6b41 980 - stevesk@cvs.openbsd.org 2006/07/03 17:59:32
981 [channels.c includes.h]
982 move #include <arpa/inet.h> out of includes.h; old ok djm@
983 (portable needed session.c too)
9794d008 984 - stevesk@cvs.openbsd.org 2006/07/05 02:42:09
985 [canohost.c hostfile.c includes.h misc.c packet.c readconf.c]
986 [serverloop.c sshconnect.c uuencode.c]
987 move #include <netinet/in.h> out of includes.h; ok deraadt@
988 (also ssh-rand-helper.c logintest.c loginrec.c)
d66ce1a1 989 - djm@cvs.openbsd.org 2006/07/06 10:47:05
990 [servconf.c servconf.h session.c sshd_config.5]
991 support arguments to Subsystem commands; ok markus@
a13880bb 992 - djm@cvs.openbsd.org 2006/07/06 10:47:57
993 [sftp-server.8 sftp-server.c]
994 add commandline options to enable logging of transactions; ok markus@
b1842393 995 - stevesk@cvs.openbsd.org 2006/07/06 16:03:53
996 [auth-options.c auth-options.h auth-passwd.c auth-rh-rsa.c]
997 [auth-rhosts.c auth-rsa.c auth.c auth.h auth2-hostbased.c]
998 [auth2-pubkey.c auth2.c includes.h misc.c misc.h monitor.c]
999 [monitor_wrap.c monitor_wrap.h scp.c serverloop.c session.c]
1000 [session.h sftp-common.c ssh-add.c ssh-keygen.c ssh-keysign.c]
1001 [ssh.c sshconnect.c sshconnect.h sshd.c sshpty.c sshpty.h uidswap.c]
1002 [uidswap.h]
1003 move #include <pwd.h> out of includes.h; ok markus@
0cbe25f0 1004 - stevesk@cvs.openbsd.org 2006/07/06 16:22:39
1005 [ssh-keygen.c]
1006 move #include "dns.h" up
76275092 1007 - stevesk@cvs.openbsd.org 2006/07/06 17:36:37
1008 [monitor_wrap.h]
1009 typo in comment
5b04a8bf 1010 - stevesk@cvs.openbsd.org 2006/07/08 21:47:12
1011 [authfd.c canohost.c clientloop.c dns.c dns.h includes.h]
1012 [monitor_fdpass.c nchan.c packet.c servconf.c sftp.c ssh-agent.c]
1013 [ssh-keyscan.c ssh.c sshconnect.h sshd.c sshlogin.h]
1014 move #include <sys/socket.h> out of includes.h
9305512d 1015 - stevesk@cvs.openbsd.org 2006/07/08 21:48:53
1016 [monitor.c session.c]
1017 missed these from last commit:
1018 move #include <sys/socket.h> out of includes.h
ca1df159 1019 - stevesk@cvs.openbsd.org 2006/07/08 23:30:06
1020 [log.c]
1021 move user includes after /usr/include files
d3221cca 1022 - stevesk@cvs.openbsd.org 2006/07/09 15:15:11
1023 [auth2-none.c authfd.c authfile.c includes.h misc.c monitor.c]
1024 [readpass.c scp.c serverloop.c sftp-client.c sftp-server.c]
1025 [ssh-add.c ssh-agent.c ssh-keygen.c ssh-keysign.c ssh.c sshd.c]
1026 [sshlogin.c sshpty.c]
1027 move #include <fcntl.h> out of includes.h
657939aa 1028 - stevesk@cvs.openbsd.org 2006/07/09 15:27:59
1029 [ssh-add.c]
1030 use O_RDONLY vs. 0 in open(); no binary change
43bc2dc9 1031 - djm@cvs.openbsd.org 2006/07/10 11:24:54
1032 [sftp-server.c]
1033 remove optind - it isn't used here
26ddd377 1034 - djm@cvs.openbsd.org 2006/07/10 11:25:53
1035 [sftp-server.c]
1036 don't log variables that aren't yet set
22bbb3e6 1037 - (djm) [loginrec.c ssh-rand-helper.c sshd.c openbsd-compat/glob.c]
1038 [openbsd-compat/mktemp.c openbsd-compat/openbsd-compat.h]
1039 [openbsd-compat/port-tun.c openbsd-compat/readpassphrase.c]
1040 [openbsd-compat/xcrypt.c] Fix includes.h fallout, mainly fcntl.h
1879b184 1041 - OpenBSD CVS Sync
1042 - djm@cvs.openbsd.org 2006/07/10 12:03:20
1043 [scp.c]
1044 duplicate argv at the start of main() because it gets modified later;
1045 pointed out by deraadt@ ok markus@
a217e418 1046 - djm@cvs.openbsd.org 2006/07/10 12:08:08
1047 [channels.c]
1048 fix misparsing of SOCKS 5 packets that could result in a crash;
1049 reported by mk@ ok markus@
d4530052 1050 - dtucker@cvs.openbsd.org 2006/07/10 12:46:51
1051 [misc.c misc.h sshd.8 sshconnect.c]
1052 Add port identifier to known_hosts for non-default ports, based originally
1053 on a patch from Devin Nate in bz#910.
1054 For any connection using the default port or using a HostKeyAlias the
1055 format is unchanged, otherwise the host name or address is enclosed
1056 within square brackets in the same format as sshd's ListenAddress.
1057 Tested by many, ok markus@.
9b6edf98 1058 - (dtucker) [openbsd-compat/openbsd-compat.h] Need to include <sys/socket.h>
1059 for struct sockaddr on platforms that use the fake-rfc stuff.
44064ac4 1060
e7479666 106120060706
1062 - (dtucker) [configure.ac] Try AIX blibpath test in different order when
1063 compiling with gcc. gcc 4.1.x will accept (but ignore) -b flags so
1064 configure would not select the correct libpath linker flags.
90f321a4 1065 - (dtucker) [INSTALL] A bit more info on autoconf.
e7479666 1066
e5c27607 106720060705
1068 - (dtucker) [ssh-rand-helper.c] Don't exit if mkdir fails because the
1069 target already exists.
1070
202c6095 107120060630
1072 - (dtucker) [openbsd-compat/openbsd-compat.h] SNPRINTF_CONST for snprintf
1073 declaration too. Patch from russ at sludge.net.
0bbb4f75 1074 - (dtucker) [openbsd-compat/getrrsetbyname.c] Undef _res before defining it,
1075 prevents warnings on platforms where _res is in the system headers.
10f1064f 1076 - (dtucker) [INSTALL] Bug #1202: Note when autoconf is required and which
1077 version.
202c6095 1078
ecd9ec09 107920060627
1080 - (dtucker) [configure.ac] Bug #1203: Add missing '[', which causes problems
1081 with autoconf 2.60. Patch from vapier at gentoo.org.
1082
9c04d67d 108320060625
1084 - (dtucker) [channels.c serverloop.c] Apply the bug #1102 workaround to ptys
1085 only, otherwise sshd can hang exiting non-interactive sessions.
1086
795aa5f5 108720060624
1088 - (dtucker) [configure.ac] Bug #1193: Define PASSWD_NEEDS_USERNAME on Solaris.
1089 Works around limitation in Solaris' passwd program for changing passwords
1090 where the username is longer than 8 characters. ok djm@
24a87055 1091 - (dtucker) [serverloop.c] Get ifdef/ifndef the right way around for the bug
1092 #1102 workaround.
795aa5f5 1093
e02505e2 109420060623
1095 - (dtucker) [README.platform configure.ac openbsd-compat/port-tun.c] Add
1096 tunnel support for Mac OS X/Darwin via a third-party tun driver. Patch
1097 from reyk@, tested by anil@
ea8c44d9 1098 - (dtucker) [channels.c configure.ac serverloop.c] Bug #1102: Around AIX
1099 4.3.3 ML3 or so, the AIX pty layer starting passing zero-length writes
1100 on the pty slave as zero-length reads on the pty master, which sshd
1101 interprets as the descriptor closing. Since most things don't do zero
1102 length writes this rarely matters, but occasionally it happens, and when
1103 it does the SSH pty session appears to hang, so we add a special case for
1104 this condition. ok djm@
e02505e2 1105
6cba36fd 110620060613
ae410a09 1107 - (djm) [getput.h] This file has been replaced by functions in misc.c
6cba36fd 1108 - OpenBSD CVS Sync
1109 - djm@cvs.openbsd.org 2006/05/08 10:49:48
1110 [sshconnect2.c]
1111 uint32_t -> u_int32_t (which we use everywhere else)
1112 (Id sync only - portable already had this)
3173dd0d 1113 - markus@cvs.openbsd.org 2006/05/16 09:00:00
1114 [clientloop.c]
1115 missing free; from Kylene Hall
2b8dc5e3 1116 - markus@cvs.openbsd.org 2006/05/17 12:43:34
1117 [scp.c sftp.c ssh-agent.c ssh-keygen.c sshconnect.c]
1118 fix leak; coverity via Kylene Jo Hall
18c60a0b 1119 - miod@cvs.openbsd.org 2006/05/18 21:27:25
1120 [kexdhc.c kexgexc.c]
1121 paramter -> parameter
07a80cea 1122 - dtucker@cvs.openbsd.org 2006/05/29 12:54:08
1123 [ssh_config.5]
1124 Add gssapi-with-mic to PreferredAuthentications default list; ok jmc
aa195106 1125 - dtucker@cvs.openbsd.org 2006/05/29 12:56:33
1126 [ssh_config]
f127d8a4 1127 Add GSSAPIAuthentication and GSSAPIDelegateCredentials to examples in
1128 sample ssh_config. ok markus@
1129 - jmc@cvs.openbsd.org 2006/05/29 16:10:03
1130 [ssh_config.5]
1131 oops - previous was too long; split the list of auths up
ed277f5e 1132 - mk@cvs.openbsd.org 2006/05/30 11:46:38
1133 [ssh-add.c]
1134 Sync usage() with man page and reality.
1135 ok deraadt dtucker
1136 - jmc@cvs.openbsd.org 2006/05/29 16:13:23
1137 [ssh.1]
1138 add GSSAPI to the list of authentication methods supported;
f9579ee9 1139 - mk@cvs.openbsd.org 2006/05/30 11:46:38
1140 [ssh-add.c]
1141 Sync usage() with man page and reality.
1142 ok deraadt dtucker
211f229e 1143 - markus@cvs.openbsd.org 2006/06/01 09:21:48
1144 [sshd.c]
1145 call get_remote_ipaddr() early; fixes logging after client disconnects;
1146 report mpf@; ok dtucker@
82aeee5d 1147 - markus@cvs.openbsd.org 2006/06/06 10:20:20
1148 [readpass.c sshconnect.c sshconnect.h sshconnect2.c uidswap.c]
1149 replace remaining setuid() calls with permanently_set_uid() and
1150 check seteuid() return values; report Marcus Meissner; ok dtucker djm
3c33c1b6 1151 - markus@cvs.openbsd.org 2006/06/08 14:45:49
1152 [readpass.c sshconnect.c sshconnect2.c uidswap.c uidswap.h]
1153 do not set the gid, noted by solar; ok djm
e1ff5445 1154 - djm@cvs.openbsd.org 2006/06/13 01:18:36
1155 [ssh-agent.c]
1156 always use a format string, even when printing a constant
1157 - djm@cvs.openbsd.org 2006/06/13 02:17:07
1158 [ssh-agent.c]
1159 revert; i am on drugs. spotted by alexander AT beard.se
6cba36fd 1160
2ae7f715 116120060521
1162 - (dtucker) [auth.c monitor.c] Now that we don't log from both the monitor
1163 and slave, we can remove the special-case handling in the audit hook in
1164 auth_log.
1165
116620060517
aee28e67 1167 - (dtucker) [ssh-rand-helper.c] Check return code of mkdir and fix file
1168 pointer leak. From kjhall at us.ibm.com, found by coverity.
1169
2ae7f715 117020060515
a048aeba 1171 - (dtucker) [openbsd-compat/getrrsetbyname.c] Use _compat_res instead of
1172 _res, prevents problems on some platforms that have _res as a global but
1173 don't have getrrsetbyname(), eg IRIX 5.3. Found and tested by
1174 georg.schwarz at freenet.de, ok djm@.
143a79db 1175 - (dtucker) [defines.h] Find a value for IOV_MAX or use a conservative
1176 default. Patch originally from tim@, ok djm
5aa56df0 1177 - (dtucker) [auth-pam.c] Bug #1188: pass result of do_pam_account back and
1178 do not allow kbdint again after the PAM account check fails. ok djm@
a048aeba 1179
2ae7f715 118020060506
689d3f77 1181 - (dtucker) OpenBSD CVS Sync
fc231518 1182 - dtucker@cvs.openbsd.org 2006/04/25 08:02:27
1183 [authfile.c authfile.h sshconnect2.c ssh.c sshconnect1.c]
1184 Prevent ssh from trying to open private keys with bad permissions more than
1185 once or prompting for their passphrases (which it subsequently ignores
1186 anyway), similar to a previous change in ssh-add. bz #1186, ok djm@
397d64d2 1187 - djm@cvs.openbsd.org 2006/05/04 14:55:23
1188 [dh.c]
1189 tighter DH exponent checks here too; feedback and ok markus@
a1361c4b 1190 - djm@cvs.openbsd.org 2006/04/01 05:37:46
1191 [OVERVIEW]
1192 $OpenBSD$ in here too
9188927d 1193 - dtucker@cvs.openbsd.org 2006/05/06 08:35:40
1194 [auth-krb5.c]
1195 Add $OpenBSD$ in comment here too
fc231518 1196
01d35895 119720060504
1198 - (dtucker) [auth-pam.c groupaccess.c monitor.c monitor_wrap.c scard-opensc.c
1199 session.c ssh-rand-helper.c sshd.c openbsd-compat/bsd-cygwin_util.c
1200 openbsd-compat/setproctitle.c] Convert malloc(foo*bar) -> calloc(foo,bar)
1201 in Portable-only code; since calloc zeros, remove now-redundant memsets.
1202 Also add a couple of sanity checks. With & ok djm@
1203
7ca4010c 120420060503
1205 - (dtucker) [packet.c] Remove in_systm.h since it's also in includes.h
1206 and double including it on IRIX 5.3 causes problems. From Georg Schwarz,
1207 "no objections" tim@
1208
ac93e676 120920060423
1210 - (djm) OpenBSD CVS Sync
1211 - deraadt@cvs.openbsd.org 2006/04/01 05:42:20
1212 [scp.c]
1213 minimal lint cleanup (unused crud, and some size_t); ok djm
c0a8e7bb 1214 - djm@cvs.openbsd.org 2006/04/01 05:50:29
1215 [scp.c]
1216 xasprintification; ok deraadt@
5fe9ca7d 1217 - djm@cvs.openbsd.org 2006/04/01 05:51:34
1218 [atomicio.c]
1219 ANSIfy; requested deraadt@
1220 - dtucker@cvs.openbsd.org 2006/04/02 08:34:52
1221 [ssh-keysign.c]
1222 sessionid can be 32 bytes now too when sha256 kex is used; ok djm@
9c3c8eb1 1223 - djm@cvs.openbsd.org 2006/04/03 07:10:38
1224 [gss-genr.c]
1225 GSSAPI buffers shouldn't be nul-terminated, spotted in bugzilla #1066
1226 by dleonard AT vintela.com. use xasprintf() to simplify code while in
1227 there; "looks right" deraadt@
69d9d413 1228 - djm@cvs.openbsd.org 2006/04/16 00:48:52
1229 [buffer.c buffer.h channels.c]
1230 Fix condition where we could exit with a fatal error when an input
1231 buffer became too large and the remote end had advertised a big window.
1232 The problem was a mismatch in the backoff math between the channels code
1233 and the buffer code, so make a buffer_check_alloc() function that the
1234 channels code can use to propsectivly check whether an incremental
1235 allocation will succeed. bz #1131, debugged with the assistance of
1236 cove AT wildpackets.com; ok dtucker@ deraadt@
68d86b37 1237 - djm@cvs.openbsd.org 2006/04/16 00:52:55
1238 [atomicio.c atomicio.h]
1239 introduce atomiciov() function that wraps readv/writev to retry
1240 interrupted transfers like atomicio() does for read/write;
1241 feedback deraadt@ dtucker@ stevesk@ ok deraadt@
2c4369de 1242 - djm@cvs.openbsd.org 2006/04/16 00:54:10
1243 [sftp-client.c]
1244 avoid making a tiny 4-byte write to send the packet length of sftp
1245 commands, which would result in a separate tiny packet on the wire by
1246 using atomiciov(writev, ...) to write the length and the command in one
1247 pass; ok deraadt@
7bccebd0 1248 - djm@cvs.openbsd.org 2006/04/16 07:59:00
1249 [atomicio.c]
1250 reorder sanity test so that it cannot dereference past the end of the
1251 iov array; well spotted canacar@!
b0a892b2 1252 - dtucker@cvs.openbsd.org 2006/04/18 10:44:28
71544c3d 1253 [bufaux.c bufbn.c Makefile.in]
b0a892b2 1254 Move Buffer bignum functions into their own file, bufbn.c. This means
1255 that sftp and sftp-server (which use the Buffer functions in bufaux.c
1256 but not the bignum ones) no longer need to be linked with libcrypto.
1257 ok markus@
50394f26 1258 - djm@cvs.openbsd.org 2006/04/20 09:27:09
1259 [auth.h clientloop.c dispatch.c dispatch.h kex.h]
1260 replace the last non-sig_atomic_t flag used in a signal handler with a
1261 sig_atomic_t, unfortunately with some knock-on effects in other (non-
1262 signal) contexts in which it is used; ok markus@
4439dde1 1263 - markus@cvs.openbsd.org 2006/04/20 09:47:59
1264 [sshconnect.c]
1265 simplify; ok djm@
6e97fe1d 1266 - djm@cvs.openbsd.org 2006/04/20 21:53:44
1267 [includes.h session.c sftp.c]
1268 Switch from using pipes to socketpairs for communication between
1269 sftp/scp and ssh, and between sshd and its subprocesses. This saves
1270 a file descriptor per session and apparently makes userland ppp over
1271 ssh work; ok markus@ deraadt@ (ID Sync only - portable makes this
1272 decision on a per-platform basis)
40402a68 1273 - djm@cvs.openbsd.org 2006/04/22 04:06:51
1274 [uidswap.c]
1275 use setres[ug]id() to permanently revoke privileges; ok deraadt@
1276 (ID Sync only - portable already uses setres[ug]id() whenever possible)
ae3afe05 1277 - stevesk@cvs.openbsd.org 2006/04/22 18:29:33
1278 [crc32.c]
1279 remove extra spaces
0ca1dcaf 1280 - (djm) [auth.h dispatch.h kex.h] sprinkle in signal.h to get
1281 sig_atomic_t
ac93e676 1282
ef4d1846 128320060421
1284 - (djm) [Makefile.in configure.ac session.c sshpty.c]
1285 [contrib/redhat/sshd.init openbsd-compat/Makefile.in]
1286 [openbsd-compat/openbsd-compat.h openbsd-compat/port-linux.c]
1287 [openbsd-compat/port-linux.h] Add support for SELinux, setting
1288 the execution and TTY contexts. based on patch from Daniel Walsh,
1289 bz #880; ok dtucker@
1290
88680c8b 129120060418
ef4d1846 1292 - (djm) [canohost.c] Reorder IP options check so that it isn't broken
1293 by mapped addresses; bz #1179 reported by markw wtech-llc.com;
88680c8b 1294 ok dtucker@
1295
6a0984b4 129620060331
1297 - OpenBSD CVS Sync
1298 - deraadt@cvs.openbsd.org 2006/03/27 01:21:18
1299 [xmalloc.c]
1300 we can do the size & nmemb check before the integer overflow check;
1301 evol
fd06fbe0 1302 - deraadt@cvs.openbsd.org 2006/03/27 13:03:54
1303 [dh.c]
1304 use strtonum() instead of atoi(), limit dhg size to 64k; ok djm
e56b07ea 1305 - djm@cvs.openbsd.org 2006/03/27 23:15:46
1306 [sftp.c]
1307 always use a format string for addargs; spotted by mouring@
19e79961 1308 - deraadt@cvs.openbsd.org 2006/03/28 00:12:31
1309 [README.tun ssh.c]
1310 spacing
4f16046f 1311 - deraadt@cvs.openbsd.org 2006/03/28 01:52:28
1312 [channels.c]
1313 do not accept unreasonable X ports numbers; ok djm
cfaa5405 1314 - deraadt@cvs.openbsd.org 2006/03/28 01:53:43
1315 [ssh-agent.c]
1316 use strtonum() to parse the pid from the file, and range check it
1317 better; ok djm
04aa9e67 1318 - djm@cvs.openbsd.org 2006/03/30 09:41:25
1319 [channels.c]
1320 ARGSUSED for dispatch table-driven functions
51e7a012 1321 - djm@cvs.openbsd.org 2006/03/30 09:58:16
1322 [authfd.c bufaux.c deattack.c gss-serv.c mac.c misc.c misc.h]
1323 [monitor_wrap.c msg.c packet.c sftp-client.c sftp-server.c ssh-agent.c]
1324 replace {GET,PUT}_XXBIT macros with functionally similar functions,
1325 silencing a heap of lint warnings. also allows them to use
1326 __bounded__ checking which can't be applied to macros; requested
1327 by and feedback from deraadt@
8cffe22a 1328 - djm@cvs.openbsd.org 2006/03/30 10:41:25
1329 [ssh.c ssh_config.5]
1330 add percent escape chars to the IdentityFile option, bz #1159 based
1331 on a patch by imaging AT math.ualberta.ca; feedback and ok dtucker@
2ccf5424 1332 - dtucker@cvs.openbsd.org 2006/03/30 11:05:17
1333 [ssh-keygen.c]
1334 Correctly handle truncated files while converting keys; ok djm@
c023a130 1335 - dtucker@cvs.openbsd.org 2006/03/30 11:40:21
1336 [auth.c monitor.c]
1337 Prevent duplicate log messages when privsep=yes; ok djm@
99d18e3e 1338 - jmc@cvs.openbsd.org 2006/03/31 09:09:30
1339 [ssh_config.5]
1340 kill trailing whitespace;
b4d7dedd 1341 - djm@cvs.openbsd.org 2006/03/31 09:13:56
1342 [ssh_config.5]
1343 remote user escape is %r not %h; spotted by jmc@
6a0984b4 1344
3eff92ec 134520060326
1346 - OpenBSD CVS Sync
1347 - jakob@cvs.openbsd.org 2006/03/15 08:46:44
1348 [ssh-keygen.c]
1349 if no key file are given when printing the DNS host record, use the
1350 host key file(s) as default. ok djm@
d6157b67 1351 - biorn@cvs.openbsd.org 2006/03/16 10:31:45
1352 [scp.c]
1353 Try to display errormessage even if remout == -1
1354 ok djm@, markus@
9dfca510 1355 - djm@cvs.openbsd.org 2006/03/17 22:31:50
1356 [authfd.c]
1357 another unreachable found by lint
60ffd527 1358 - djm@cvs.openbsd.org 2006/03/17 22:31:11
1359 [authfd.c]
1360 unreachanble statement, found by lint
4113a1d7 1361 - djm@cvs.openbsd.org 2006/03/19 02:22:32
1362 [serverloop.c]
1363 memory leaks detected by Coverity via elad AT netbsd.org;
1364 ok deraadt@ dtucker@
e6a3cfb5 1365 - djm@cvs.openbsd.org 2006/03/19 02:22:56
1366 [sftp.c]
1367 more memory leaks detected by Coverity via elad AT netbsd.org;
1368 deraadt@ ok
f8f9ef4d 1369 - djm@cvs.openbsd.org 2006/03/19 02:23:26
1370 [hostfile.c]
1371 FILE* leak detected by Coverity via elad AT netbsd.org;
1372 ok deraadt@
88299971 1373 - djm@cvs.openbsd.org 2006/03/19 02:24:05
1374 [dh.c readconf.c servconf.c]
1375 potential NULL pointer dereferences detected by Coverity
1376 via elad AT netbsd.org; ok deraadt@
18fc231c 1377 - djm@cvs.openbsd.org 2006/03/19 07:41:30
1378 [sshconnect2.c]
1379 memory leaks detected by Coverity via elad AT netbsd.org;
1380 deraadt@ ok
0f8cd5a6 1381 - dtucker@cvs.openbsd.org 2006/03/19 11:51:52
1382 [servconf.c]
1383 Correct strdelim null test; ok djm@
c8e9c167 1384 - deraadt@cvs.openbsd.org 2006/03/19 18:52:11
1385 [auth1.c authfd.c channels.c]
1386 spacing
b4bbf172 1387 - deraadt@cvs.openbsd.org 2006/03/19 18:53:12
1388 [kex.c kex.h monitor.c myproposal.h session.c]
1389 spacing
3efa8ea9 1390 - deraadt@cvs.openbsd.org 2006/03/19 18:56:41
1391 [clientloop.c progressmeter.c serverloop.c sshd.c]
1392 ARGSUSED for signal handlers
6e56dc92 1393 - deraadt@cvs.openbsd.org 2006/03/19 18:59:49
1394 [ssh-keyscan.c]
1395 please lint
7de98c39 1396 - deraadt@cvs.openbsd.org 2006/03/19 18:59:30
1397 [ssh.c]
1398 spacing
c84ac6a4 1399 - deraadt@cvs.openbsd.org 2006/03/19 18:59:09
1400 [authfile.c]
1401 whoever thought that break after return was a good idea needs to
1402 get their head examimed
98d40a74 1403 - djm@cvs.openbsd.org 2006/03/20 04:09:44
1404 [monitor.c]
1405 memory leaks detected by Coverity via elad AT netbsd.org;
1406 deraadt@ ok
1407 that should be all of them now
7016f7cf 1408 - djm@cvs.openbsd.org 2006/03/20 11:38:46
1409 [key.c]
1410 (really) last of the Coverity diffs: avoid possible NULL deref in
1411 key_free. via elad AT netbsd.org; markus@ ok
5ef36928 1412 - deraadt@cvs.openbsd.org 2006/03/20 17:10:19
1413 [auth.c key.c misc.c packet.c ssh-add.c]
1414 in a switch (), break after return or goto is stupid
353d48db 1415 - deraadt@cvs.openbsd.org 2006/03/20 17:13:16
1416 [key.c]
1417 djm did a typo
952fce1b 1418 - deraadt@cvs.openbsd.org 2006/03/20 17:17:23
1419 [ssh-rsa.c]
1420 in a switch (), break after return or goto is stupid
148de80c 1421 - deraadt@cvs.openbsd.org 2006/03/20 18:14:02
b3b6f53d 1422 [channels.c clientloop.c monitor_wrap.c monitor_wrap.h serverloop.c]
1423 [ssh.c sshpty.c sshpty.h]
148de80c 1424 sprinkle u_int throughout pty subsystem, ok markus
fe8c3af1 1425 - deraadt@cvs.openbsd.org 2006/03/20 18:17:20
1426 [auth1.c auth2.c sshd.c]
1427 sprinkle some ARGSUSED for table driven functions (which sometimes
1428 must ignore their args)
32596c7b 1429 - deraadt@cvs.openbsd.org 2006/03/20 18:26:55
1430 [channels.c monitor.c session.c session.h ssh-agent.c ssh-keygen.c]
1431 [ssh-rsa.c ssh.c sshlogin.c]
1432 annoying spacing fixes getting in the way of real diffs
b248a875 1433 - deraadt@cvs.openbsd.org 2006/03/20 18:27:50
1434 [monitor.c]
1435 spacing
338eb2ab 1436 - deraadt@cvs.openbsd.org 2006/03/20 18:35:12
1437 [channels.c]
1438 x11_fake_data is only ever used as u_char *
0bcc3e35 1439 - deraadt@cvs.openbsd.org 2006/03/20 18:41:43
1440 [dns.c]
1441 cast xstrdup to propert u_char *
9555d258 1442 - deraadt@cvs.openbsd.org 2006/03/20 18:42:27
1443 [canohost.c match.c ssh.c sshconnect.c]
1444 be strict with tolower() casting
a7137f6b 1445 - deraadt@cvs.openbsd.org 2006/03/20 18:48:34
1446 [channels.c fatal.c kex.c packet.c serverloop.c]
1447 spacing
1cec12db 1448 - deraadt@cvs.openbsd.org 2006/03/20 21:11:53
1449 [ttymodes.c]
1450 spacing
52e3daed 1451 - djm@cvs.openbsd.org 2006/03/25 00:05:41
1452 [auth-bsdauth.c auth-skey.c auth.c auth2-chall.c channels.c]
1453 [clientloop.c deattack.c gss-genr.c kex.c key.c misc.c moduli.c]
1454 [monitor.c monitor_wrap.c packet.c scard.c sftp-server.c ssh-agent.c]
1455 [ssh-keyscan.c ssh.c sshconnect.c sshconnect2.c sshd.c uuencode.c]
1456 [xmalloc.c xmalloc.h]
1457 introduce xcalloc() and xasprintf() failure-checked allocations
1458 functions and use them throughout openssh
1459
1460 xcalloc is particularly important because malloc(nmemb * size) is a
1461 dangerous idiom (subject to integer overflow) and it is time for it
1462 to die
1463
1464 feedback and ok deraadt@
c5d10563 1465 - djm@cvs.openbsd.org 2006/03/25 01:13:23
1466 [buffer.c channels.c deattack.c misc.c scp.c session.c sftp-client.c]
1467 [sftp-server.c ssh-agent.c ssh-rsa.c xmalloc.c xmalloc.h auth-pam.c]
1468 [uidswap.c]
1469 change OpenSSH's xrealloc() function from being xrealloc(p, new_size)
1470 to xrealloc(p, new_nmemb, new_itemsize).
1471
1472 realloc is particularly prone to integer overflows because it is
1473 almost always allocating "n * size" bytes, so this is a far safer
1474 API; ok deraadt@
522327f5 1475 - djm@cvs.openbsd.org 2006/03/25 01:30:23
1476 [sftp.c]
1477 "abormally" is a perfectly cromulent word, but "abnormally" is better
c1cb7bae 1478 - djm@cvs.openbsd.org 2006/03/25 13:17:03
6ba5f28f 1479 [atomicio.c auth-bsdauth.c auth-chall.c auth-options.c auth-passwd.c]
1480 [auth-rh-rsa.c auth-rhosts.c auth-rsa.c auth-skey.c auth.c auth1.c]
1481 [auth2-chall.c auth2-hostbased.c auth2-kbdint.c auth2-none.c]
1482 [auth2-passwd.c auth2-pubkey.c auth2.c authfd.c authfile.c bufaux.c]
1483 [buffer.c canohost.c channels.c cipher-3des1.c cipher-bf1.c]
1484 [cipher-ctr.c cipher.c cleanup.c clientloop.c compat.c compress.c]
1485 [deattack.c dh.c dispatch.c fatal.c groupaccess.c hostfile.c kex.c]
1486 [kexdh.c kexdhc.c kexdhs.c kexgex.c kexgexc.c kexgexs.c key.c log.c]
1487 [mac.c match.c md-sha256.c misc.c monitor.c monitor_fdpass.c]
1488 [monitor_mm.c monitor_wrap.c msg.c nchan.c packet.c progressmeter.c]
1489 [readconf.c readpass.c rsa.c scard.c scp.c servconf.c serverloop.c]
1490 [session.c sftp-client.c sftp-common.c sftp-glob.c sftp-server.c]
1491 [sftp.c ssh-add.c ssh-agent.c ssh-dss.c ssh-keygen.c ssh-keyscan.c]
1492 [ssh-keysign.c ssh-rsa.c ssh.c sshconnect.c sshconnect1.c]
1493 [sshconnect2.c sshd.c sshlogin.c sshpty.c sshtty.c ttymodes.c]
1494 [uidswap.c uuencode.c xmalloc.c]
c1cb7bae 1495 Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
1496 Theo nuked - our scripts to sync -portable need them in the files
febd6f21 1497 - deraadt@cvs.openbsd.org 2006/03/25 18:29:35
1498 [auth-rsa.c authfd.c packet.c]
1499 needed casts (always will be needed)
b476adfa 1500 - deraadt@cvs.openbsd.org 2006/03/25 18:30:55
1501 [clientloop.c serverloop.c]
1502 spacing
306f24ca 1503 - deraadt@cvs.openbsd.org 2006/03/25 18:36:15
1504 [sshlogin.c sshlogin.h]
1505 nicer size_t and time_t types
0fe9892f 1506 - deraadt@cvs.openbsd.org 2006/03/25 18:40:14
1507 [ssh-keygen.c]
1508 cast strtonum() result to right type
8d0b0353 1509 - deraadt@cvs.openbsd.org 2006/03/25 18:41:45
1510 [ssh-agent.c]
1511 mark two more signal handlers ARGSUSED
d6d4897e 1512 - deraadt@cvs.openbsd.org 2006/03/25 18:43:30
1513 [channels.c]
1514 use strtonum() instead of atoi() [limit X screens to 400, sorry]
15dd2c4f 1515 - deraadt@cvs.openbsd.org 2006/03/25 18:56:55
1516 [bufaux.c channels.c packet.c]
1517 remove (char *) casts to a function that accepts void * for the arg
5b5f6af7 1518 - deraadt@cvs.openbsd.org 2006/03/25 18:58:10
1519 [channels.c]
1520 delete cast not required
56f824f3 1521 - djm@cvs.openbsd.org 2006/03/25 22:22:43
1522 [atomicio.h auth-options.h auth.h auth2-gss.c authfd.h authfile.h]
1523 [bufaux.h buffer.h canohost.h channels.h cipher.h clientloop.h]
1524 [compat.h compress.h crc32.c crc32.h deattack.h dh.h dispatch.h]
1525 [dns.c dns.h getput.h groupaccess.h gss-genr.c gss-serv-krb5.c]
1526 [gss-serv.c hostfile.h includes.h kex.h key.h log.h mac.h match.h]
1527 [misc.h monitor.h monitor_fdpass.h monitor_mm.h monitor_wrap.h msg.h]
1528 [myproposal.h packet.h pathnames.h progressmeter.h readconf.h rsa.h]
1529 [scard.h servconf.h serverloop.h session.h sftp-common.h sftp.h]
1530 [ssh-gss.h ssh.h ssh1.h ssh2.h sshconnect.h sshlogin.h sshpty.h]
1531 [ttymodes.h uidswap.h uuencode.h xmalloc.h]
1532 standardise spacing in $OpenBSD$ tags; requested by deraadt@
9594740b 1533 - deraadt@cvs.openbsd.org 2006/03/26 01:31:48
1534 [uuencode.c]
1535 typo
3eff92ec 1536
df938409 153720060325
1538 - OpenBSD CVS Sync
1539 - djm@cvs.openbsd.org 2006/03/16 04:24:42
1540 [ssh.1]
1541 Add RFC4419 (Diffie-Hellman group exchange KEX) to the list of SSH RFCs
1542 that OpenSSH supports
a92a0909 1543 - deraadt@cvs.openbsd.org 2006/03/19 18:51:18
1544 [atomicio.c auth-bsdauth.c auth-chall.c auth-krb5.c auth-options.c]
1545 [auth-pam.c auth-passwd.c auth-rh-rsa.c auth-rhosts.c auth-rsa.c]
1546 [auth-shadow.c auth-skey.c auth.c auth1.c auth2-chall.c]
1547 [auth2-hostbased.c auth2-kbdint.c auth2-none.c auth2-passwd.c]
1548 [auth2-pubkey.c auth2.c authfd.c authfile.c bufaux.c buffer.c]
1549 [canohost.c channels.c cipher-3des1.c cipher-acss.c cipher-aes.c]
1550 [cipher-bf1.c cipher-ctr.c cipher.c cleanup.c clientloop.c compat.c]
1551 [compress.c deattack.c dh.c dispatch.c dns.c entropy.c fatal.c]
1552 [groupaccess.c hostfile.c includes.h kex.c kexdh.c kexdhc.c]
1553 [kexdhs.c kexgex.c kexgexc.c kexgexs.c key.c log.c loginrec.c]
1554 [loginrec.h logintest.c mac.c match.c md-sha256.c md5crypt.c misc.c]
1555 [monitor.c monitor_fdpass.c monitor_mm.c monitor_wrap.c msg.c]
1556 [nchan.c packet.c progressmeter.c readconf.c readpass.c rsa.c]
1557 [scard.c scp.c servconf.c serverloop.c session.c sftp-client.c]
1558 [sftp-common.c sftp-glob.c sftp-server.c sftp.c ssh-add.c]
1559 [ssh-agent.c ssh-dss.c ssh-keygen.c ssh-keyscan.c ssh-keysign.c]
1560 [ssh-rand-helper.c ssh-rsa.c ssh.c sshconnect.c sshconnect1.c]
1561 [sshconnect2.c sshd.c sshlogin.c sshpty.c sshtty.c ttymodes.c]
1562 [uidswap.c uuencode.c xmalloc.c openbsd-compat/bsd-arc4random.c]
1563 [openbsd-compat/bsd-closefrom.c openbsd-compat/bsd-cygwin_util.c]
1564 [openbsd-compat/bsd-getpeereid.c openbsd-compat/bsd-misc.c]
1565 [openbsd-compat/bsd-nextstep.c openbsd-compat/bsd-snprintf.c]
1566 [openbsd-compat/bsd-waitpid.c openbsd-compat/fake-rfc2553.c]
1567 RCSID() can die
0e03e3d0 1568 - deraadt@cvs.openbsd.org 2006/03/19 18:53:12
1569 [kex.h myproposal.h]
1570 spacing
0fa53840 1571 - djm@cvs.openbsd.org 2006/03/20 04:07:22
1572 [auth2-gss.c]
1573 GSSAPI related leaks detected by Coverity via elad AT netbsd.org;
1574 reviewed by simon AT sxw.org.uk; deraadt@ ok
0926fd19 1575 - djm@cvs.openbsd.org 2006/03/20 04:07:49
1576 [gss-genr.c]
1577 more GSSAPI related leaks detected by Coverity via elad AT netbsd.org;
1578 reviewed by simon AT sxw.org.uk; deraadt@ ok
7cd30d48 1579 - djm@cvs.openbsd.org 2006/03/20 04:08:18
1580 [gss-serv.c]
1581 last lot of GSSAPI related leaks detected by Coverity via
1582 elad AT netbsd.org; reviewed by simon AT sxw.org.uk; deraadt@ ok
97f67e9a 1583 - deraadt@cvs.openbsd.org 2006/03/20 18:14:02
1584 [monitor_wrap.h sshpty.h]
1585 sprinkle u_int throughout pty subsystem, ok markus
fd6eaa8c 1586 - deraadt@cvs.openbsd.org 2006/03/20 18:26:55
1587 [session.h]
1588 annoying spacing fixes getting in the way of real diffs
6cfe93ec 1589 - deraadt@cvs.openbsd.org 2006/03/20 18:41:43
1590 [dns.c]
1591 cast xstrdup to propert u_char *
f0eea41f 1592 - jakob@cvs.openbsd.org 2006/03/22 21:16:24
1593 [ssh.1]
1594 simplify SSHFP example; ok jmc@
69753336 1595 - djm@cvs.openbsd.org 2006/03/22 21:27:15
1596 [deattack.c deattack.h]
1597 remove IV support from the CRC attack detector, OpenSSH has never used
1598 it - it only applied to IDEA-CFB, which we don't support.
1599 prompted by NetBSD Coverity report via elad AT netbsd.org;
1600 feedback markus@ "nuke it" deraadt@
df938409 1601
08a3f952 160220060318
7f38714e 1603 - (djm) [auth-pam.c] Fix memleak in error path, from Coverity via
1604 elad AT NetBSD.org
1605 - (dtucker) [openbsd-compat/bsd-snprintf.c] Bug #1173: make fmtint() take
1606 a LLONG rather than a long. Fixes scp'ing of large files on platforms
1607 with missing/broken snprintfs. Patch from e.borovac at bom.gov.au.
08a3f952 1608
32b0131a 160920060316
1610 - (dtucker) [entropy.c] Add headers for WIFEXITED and friends.
2f360c89 1611 - (dtucker) [configure.ac md-sha256.c] NetBSD has sha2.h in
1612 /usr/include/crypto. Hint from djm@.
b1f0c612 1613 - (tim) [kex.c myproposal.h md-sha256.c openbsd-compat/sha2.c,h]
1614 Disable sha256 when openssl < 0.9.7. Patch from djm@.
30baf904 1615 - (djm) [kex.c] Slightly more clean deactivation of dhgex-sha256 on old
1616 OpenSSL; ok tim
32b0131a 1617
0ac58ab4 161820060315
1619 - (djm) OpenBSD CVS Sync:
1620 - msf@cvs.openbsd.org 2006/02/06 15:54:07
1621 [ssh.1]
1622 - typo fix
1623 ok jmc@
260c414c 1624 - jmc@cvs.openbsd.org 2006/02/06 21:44:47
1625 [ssh.1]
1626 make this a little less ambiguous...
c38f5d19 1627 - stevesk@cvs.openbsd.org 2006/02/07 01:08:04
1628 [auth-rhosts.c includes.h]
1629 move #include <netgroup.h> out of includes.h; ok markus@
c3ff311a 1630 - stevesk@cvs.openbsd.org 2006/02/07 01:18:09
1631 [includes.h ssh-agent.c ssh-keyscan.c sshconnect2.c]
1632 move #include <sys/queue.h> out of includes.h; ok markus@
1d3e026f 1633 - stevesk@cvs.openbsd.org 2006/02/07 01:42:00
1634 [channels.c clientloop.c clientloop.h includes.h packet.h]
1635 [serverloop.c sshpty.c sshpty.h sshtty.c ttymodes.c]
1636 move #include <termios.h> out of includes.h; ok markus@
99f28949 1637 - stevesk@cvs.openbsd.org 2006/02/07 01:52:50
1638 [sshtty.c]
1639 "log.h" not needed
cc63c340 1640 - stevesk@cvs.openbsd.org 2006/02/07 03:47:05
1641 [hostfile.c]
1642 "packet.h" not needed
db5a9db9 1643 - stevesk@cvs.openbsd.org 2006/02/07 03:59:20
1644 [deattack.c]
1645 duplicate #include
a75f5360 1646 - stevesk@cvs.openbsd.org 2006/02/08 12:15:27
1647 [auth.c clientloop.c includes.h misc.c monitor.c readpass.c]
1648 [session.c sftp.c ssh-agent.c ssh-keysign.c ssh.c sshconnect.c]
1649 [sshd.c sshpty.c]
1650 move #include <paths.h> out of includes.h; ok markus@
6425cf65 1651 - stevesk@cvs.openbsd.org 2006/02/08 12:32:49
1652 [includes.h misc.c]
1653 move #include <netinet/tcp.h> out of includes.h; ok markus@
1720c23b 1654 - stevesk@cvs.openbsd.org 2006/02/08 13:15:44
1655 [gss-serv.c monitor.c]
1656 small KNF
5b984d1d 1657 - stevesk@cvs.openbsd.org 2006/02/08 14:16:59
1658 [sshconnect.c]
1659 <openssl/bn.h> not needed
876faccd 1660 - stevesk@cvs.openbsd.org 2006/02/08 14:31:30
1661 [includes.h ssh-agent.c ssh-keyscan.c ssh.c]
1662 move #include <sys/resource.h> out of includes.h; ok markus@
a3dcf543 1663 - stevesk@cvs.openbsd.org 2006/02/08 14:38:18
1664 [includes.h packet.c]
1665 move #include <netinet/in_systm.h> and <netinet/ip.h> out of
1666 includes.h; ok markus@
68e39d38 1667 - stevesk@cvs.openbsd.org 2006/02/08 23:51:24
1668 [includes.h scp.c sftp-glob.c sftp-server.c]
1669 move #include <dirent.h> out of includes.h; ok markus@
bbb1501d 1670 - stevesk@cvs.openbsd.org 2006/02/09 00:32:07
1671 [includes.h]
1672 #include <sys/endian.h> not needed; ok djm@
1673 NB. ID Sync only - we still need this (but it may move later)
4eb67845 1674 - jmc@cvs.openbsd.org 2006/02/09 10:10:47
1675 [sshd.8]
1676 - move some text into a CAVEATS section
1677 - merge the COMMAND EXECUTION... section into AUTHENTICATION
bd7c69ea 1678 - stevesk@cvs.openbsd.org 2006/02/10 00:27:13
1679 [channels.c clientloop.c includes.h misc.c progressmeter.c sftp.c]
1680 [ssh.c sshd.c sshpty.c]
1681 move #include <sys/ioctl.h> out of includes.h; ok markus@
aa2eae64 1682 - stevesk@cvs.openbsd.org 2006/02/10 01:44:27
1683 [includes.h monitor.c readpass.c scp.c serverloop.c session.c\7f]
1684 [sftp.c sshconnect.c sshconnect2.c sshd.c]
1685 move #include <sys/wait.h> out of includes.h; ok markus@
cfb9181c 1686 - otto@cvs.openbsd.org 2006/02/11 19:31:18
1687 [atomicio.c]
1688 type correctness; from Ray Lai in PR 5011; ok millert@
f7b8224d 1689 - djm@cvs.openbsd.org 2006/02/12 06:45:34
1690 [ssh.c ssh_config.5]
1691 add a %l expansion code to the ControlPath, which is filled in with the
1692 local hostname at runtime. Requested by henning@ to avoid some problems
1693 with /home on NFS; ok dtucker@
129d5252 1694 - djm@cvs.openbsd.org 2006/02/12 10:44:18
1695 [readconf.c]
1696 raise error when the user specifies a RekeyLimit that is smaller than 16
1697 (the smallest of our cipher's blocksize) or big enough to cause integer
1698 wraparound; ok & feedback dtucker@
5e7007ea 1699 - jmc@cvs.openbsd.org 2006/02/12 10:49:44
1700 [ssh_config.5]
1701 slight rewording; ok djm
010c04e5 1702 - jmc@cvs.openbsd.org 2006/02/12 10:52:41
1703 [sshd.8]
1704 rework the description of authorized_keys a little;
9ed4bd80 1705 - jmc@cvs.openbsd.org 2006/02/12 17:57:19
1706 [sshd.8]
1707 sort the list of options permissable w/ authorized_keys;
1708 ok djm dtucker
1e0fcfc6 1709 - jmc@cvs.openbsd.org 2006/02/13 10:16:39
1710 [sshd.8]
1711 no need to subsection the authorized_keys examples - instead, convert
1712 this to look like an actual file. also use proto 2 keys, and use IETF
1713 example addresses;
2881e0e9 1714 - jmc@cvs.openbsd.org 2006/02/13 10:21:25
1715 [sshd.8]
1716 small tweaks for the ssh_known_hosts section;
9d4b0313 1717 - jmc@cvs.openbsd.org 2006/02/13 11:02:26
1718 [sshd.8]
1719 turn this into an example ssh_known_hosts file; ok djm
481e991f 1720 - jmc@cvs.openbsd.org 2006/02/13 11:08:43
1721 [sshd.8]
1722 - avoid nasty line split
1723 - `*' does not need to be escaped
10fa86ae 1724 - jmc@cvs.openbsd.org 2006/02/13 11:27:25
1725 [sshd.8]
1726 sort FILES and use a -compact list;
2db34ac9 1727 - david@cvs.openbsd.org 2006/02/15 05:08:24
1728 [sftp-client.c]
1729 typo in comment; ok djm@
0e505e42 1730 - jmc@cvs.openbsd.org 2006/02/15 16:53:20
1731 [ssh.1]
1732 remove the IETF draft references and replace them with some updated RFCs;
2866aceb 1733 - jmc@cvs.openbsd.org 2006/02/15 16:55:33
1734 [sshd.8]
1735 remove ietf draft references; RFC list now maintained in ssh.1;
00e7c607 1736 - jmc@cvs.openbsd.org 2006/02/16 09:05:34
1737 [sshd.8]
1738 sync some of the FILES entries w/ ssh.1;
f3d2d92e 1739 - jmc@cvs.openbsd.org 2006/02/19 19:52:10
1740 [sshd.8]
1741 move the sshrc stuff out of FILES, and into its own section:
1742 FILES is not a good place to document how stuff works;
e56bbe08 1743 - jmc@cvs.openbsd.org 2006/02/19 20:02:17
1744 [sshd.8]
1745 sync the (s)hosts.equiv FILES entries w/ those from ssh.1;
3783659a 1746 - jmc@cvs.openbsd.org 2006/02/19 20:05:00
1747 [sshd.8]
1748 grammar;
922f8f17 1749 - jmc@cvs.openbsd.org 2006/02/19 20:12:25
1750 [ssh_config.5]
1751 add some vertical space;
cebb4c24 1752 - stevesk@cvs.openbsd.org 2006/02/20 16:36:15
1753 [authfd.c channels.c includes.h session.c ssh-agent.c ssh.c]
1754 move #include <sys/un.h> out of includes.h; ok djm@
4095f623 1755 - stevesk@cvs.openbsd.org 2006/02/20 17:02:44
1756 [clientloop.c includes.h monitor.c progressmeter.c scp.c]
1757 [serverloop.c session.c sftp.c ssh-agent.c ssh.c sshd.c]
1758 move #include <signal.h> out of includes.h; ok markus@
ada68823 1759 - stevesk@cvs.openbsd.org 2006/02/20 17:19:54
1760 [auth-rhosts.c auth-rsa.c auth.c auth2-none.c auth2-pubkey.c]
1761 [authfile.c clientloop.c includes.h readconf.c scp.c session.c]
1762 [sftp-client.c sftp-common.c sftp-common.h sftp-glob.c]
1763 [sftp-server.c sftp.c ssh-add.c ssh-keygen.c ssh.c sshconnect.c]
1764 [sshconnect2.c sshd.c sshpty.c]
1765 move #include <sys/stat.h> out of includes.h; ok markus@
b6438382 1766 - stevesk@cvs.openbsd.org 2006/02/22 00:04:45
1767 [canohost.c clientloop.c includes.h match.c readconf.c scp.c ssh.c]
1768 [sshconnect.c]
1769 move #include <ctype.h> out of includes.h; ok djm@
95d46d8f 1770 - jmc@cvs.openbsd.org 2006/02/24 10:25:14
1771 [ssh_config.5]
1772 add section on patterns;
1773 from dtucker + myself
ac1ec4d8 1774 - jmc@cvs.openbsd.org 2006/02/24 10:33:54
1775 [sshd_config.5]
1776 signpost to PATTERNS;
436a5ff9 1777 - jmc@cvs.openbsd.org 2006/02/24 10:37:07
1778 [ssh_config.5]
1779 tidy up the refs to PATTERNS;
4cb23985 1780 - jmc@cvs.openbsd.org 2006/02/24 10:39:52
1781 [sshd.8]
1782 signpost to PATTERNS section;
340a4caf 1783 - jmc@cvs.openbsd.org 2006/02/24 20:22:16
1784 [ssh-keysign.8 ssh_config.5 sshd_config.5]
1785 some consistency fixes;
f09ffbdb 1786 - jmc@cvs.openbsd.org 2006/02/24 20:31:31
1787 [ssh.1 ssh_config.5 sshd.8 sshd_config.5]
1788 more consistency fixes;
c5786b30 1789 - jmc@cvs.openbsd.org 2006/02/24 23:20:07
1790 [ssh_config.5]
1791 some grammar/wording fixes;
b74c3b8c 1792 - jmc@cvs.openbsd.org 2006/02/24 23:43:57
1793 [sshd_config.5]
1794 some grammar/wording fixes;
32cfd177 1795 - jmc@cvs.openbsd.org 2006/02/24 23:51:17
1796 [sshd_config.5]
1797 oops - bits i missed;
2963b207 1798 - jmc@cvs.openbsd.org 2006/02/25 12:26:17
1799 [ssh_config.5]
1800 document the possible values for KbdInteractiveDevices;
84c1b530 1801 help/ok dtucker
1802 - jmc@cvs.openbsd.org 2006/02/25 12:28:34
1803 [sshd_config.5]
1804 document the order in which allow/deny directives are processed;
a269663f 1805 help/ok dtucker
de4f5093 1806 - jmc@cvs.openbsd.org 2006/02/26 17:17:18
1807 [ssh_config.5]
1808 move PATTERNS to the end of the main body; requested by dtucker
ef1c6497 1809 - jmc@cvs.openbsd.org 2006/02/26 18:01:13
1810 [sshd_config.5]
1811 subsection is pointless here;
c04ba6a6 1812 - jmc@cvs.openbsd.org 2006/02/26 18:03:10
1813 [ssh_config.5]
1814 comma;
8b6bf4d5 1815 - djm@cvs.openbsd.org 2006/02/28 01:10:21
1816 [session.c]
1817 fix logout recording when privilege separation is disabled, analysis and
1818 patch from vinschen at redhat.com; tested by dtucker@ ok deraadt@
1819 NB. ID sync only - patch already in portable
140000b4 1820 - djm@cvs.openbsd.org 2006/03/04 04:12:58
1821 [serverloop.c]
1822 move a debug() outside of a signal handler; ok markus@ a little while back
16a5525d 1823 - djm@cvs.openbsd.org 2006/03/12 04:23:07
1824 [ssh.c]
1825 knf nit
9f513268 1826 - djm@cvs.openbsd.org 2006/03/13 08:16:00
1827 [sshd.c]
1828 don't log that we are listening on a socket before the listen() call
1829 actually succeeds, bz #1162 reported by Senthil Kumar; ok dtucker@
71f0de56 1830 - dtucker@cvs.openbsd.org 2006/03/13 08:33:00
1831 [packet.c]
1832 Set TCP_NODELAY for all connections not just "interactive" ones. Fixes
1833 poor performance and protocol stalls under some network conditions (mindrot
1834 bugs #556 and #981). Patch originally from markus@, ok djm@
15b81af3 1835 - dtucker@cvs.openbsd.org 2006/03/13 08:43:16
1836 [ssh-keygen.c]
1837 Make ssh-keygen handle CR and CRLF line termination when converting IETF
1838 format keys, in adition to vanilla LF. mindrot #1157, tested by Chris
1839 Pepper, ok djm@
533b9133 1840 - dtucker@cvs.openbsd.org 2006/03/13 10:14:29
1841 [misc.c ssh_config.5 sshd_config.5]
1842 Allow config directives to contain whitespace by surrounding them by double
1843 quotes. mindrot #482, man page help from jmc@, ok djm@
45660a22 1844 - dtucker@cvs.openbsd.org 2006/03/13 10:26:52
1845 [authfile.c authfile.h ssh-add.c]
1846 Make ssh-add check file permissions before attempting to load private
1847 key files multiple times; it will fail anyway and this prevents confusing
1848 multiple prompts and warnings. mindrot #1138, ok djm@
22aa23f8 1849 - djm@cvs.openbsd.org 2006/03/14 00:15:39
1850 [canohost.c]
1851 log the originating address and not just the name when a reverse
1852 mapping check fails, requested by linux AT linuon.com
2d762582 1853 - markus@cvs.openbsd.org 2006/03/14 16:32:48
1854 [ssh_config.5 sshd_config.5]
1855 *AliveCountMax applies to protcol v2 only; ok dtucker, djm
2ff8003a 1856 - djm@cvs.openbsd.org 2006/03/07 09:07:40
1857 [kex.c kex.h monitor.c myproposal.h ssh-keyscan.c sshconnect2.c sshd.c]
1858 Implement the diffie-hellman-group-exchange-sha256 key exchange method
1859 using the SHA256 code in libc (and wrapper to make it into an OpenSSL
1860 EVP), interop tested against CVS PuTTY
1861 NB. no portability bits committed yet
13ff27b7 1862 - (djm) [configure.ac defines.h kex.c md-sha256.c]
1863 [openbsd-compat/sha2.h openbsd-compat/openbsd-compat.h]
1864 [openbsd-compat/sha2.c] First stab at portability glue for SHA256
1865 KEX support, should work with libc SHA256 support or OpenSSL
1866 EVP_sha256 if present
1a6e2ed1 1867 - (djm) [includes.h] Restore accidentally dropped netinet/in.h
d3c45531 1868 - (djm) [Makefile.in openbsd-compat/Makefile.in] Add added files
f73e2ad7 1869 - (djm) [md-sha256.c configure.ac] md-sha256.c needs sha2.h if present
53a9f480 1870 - (djm) [regress/.cvsignore] Ignore Makefile here
81e73e57 1871 - (djm) [loginrec.c] Need stat.h
6c3a432e 1872 - (djm) [openbsd-compat/sha2.h] Avoid include macro clash with
1873 system sha2.h
cb2c6179 1874 - (djm) [ssh-rand-helper.c] Needs a bunch of headers
3e598f1a 1875 - (djm) [ssh-agent.c] Restore dropped stat.h
3070c7e1 1876 - (djm) [openbsd-compat/sha2.h openbsd-compat/sha2.c] Comment out
1877 SHA384, which we don't need and doesn't compile without tweaks
b5b88c19 1878 - (djm) [auth-pam.c clientloop.c includes.h monitor.c session.c]
1879 [sftp-client.c ssh-keysign.c ssh.c sshconnect.c sshconnect2.c]
1880 [sshd.c openbsd-compat/bsd-misc.c openbsd-compat/bsd-openpty.c]
1881 [openbsd-compat/glob.c openbsd-compat/mktemp.c]
1882 [openbsd-compat/readpassphrase.c] Lots of include fixes for
1883 OpenSolaris
b481f63d 1884 - (tim) [includes.h] put sys/stat.h back in to quiet some "macro redefined:"
3e9b2b1b 1885 - (tim) [openssh/sshpty.c openssh/openbsd-compat/port-tun.c] put in some
1886 includes removed from includes.h
d90b9f9a 1887 - (dtucker) [configure.ac] Fix glob test conversion to AC_TRY_COMPILE
b02dadfc 1888 - (djm) [includes.h] Put back paths.h, it is needed in defines.h
d4bf5977 1889 - (dtucker) [openbsd-compat/openbsd-compat.h] AIX (at least) needs
1890 sys/ioctl.h for struct winsize.
3919d576 1891 - (dtucker) [configure.ac] login_cap.h requires sys/types.h on NetBSD.
0ac58ab4 1892
055252ed 189320060313
1894 - (dtucker) [configure.ac] Bug #1171: Don't use printf("%lld", longlong)
1895 since not all platforms support it. Instead, use internal equivalent while
1896 computing LLONG_MIN and LLONG_MAX. Remove special case for alpha-dec-osf*
1897 as it's no longer required. Tested by Bernhard Simon, ok djm@
1898
f9b93ff8 189920060304
1900 - (dtucker) [contrib/cygwin/ssh-host-config] Require use of lastlog as a
1901 file rather than directory, required as Cygwin will be importing lastlog(1).
1902 Also tightens up permissions on the file. Patch from vinschen@redhat.com.
a8d3dd47 1903 - (dtucker) [gss-serv-krb5.c] Bug #1166: Correct #ifdefs for gssapi_krb5.h
1904 includes. Patch from gentoo.riverrat at gmail.com.
f9b93ff8 1905
49c64dd6 190620060226
1907 - (dtucker) [configure.ac] Bug #1156: QNX apparently needs SSHD_ACQUIRES_CTTY
1908 patch from kraai at ftbfs.org.
1909
191020060223
05059810 1911 - (dtucker) [sshd_config sshd_config.5] Update UsePAM to reflect current
1912 reality. Pointed out by tryponraj at gmail.com.
1913
49c64dd6 191420060222
0244ad55 1915 - (dtucker) [openbsd-compat/openssl-compat.{c,h}] Minor tidy up: only
1916 compile in compat code if required.
1917
15101d77 191820060221
1919 - (dtucker) [openbsd-compat/openssl-compat.h] Prevent warning about
1920 redefinition of SSLeay_add_all_algorithms.
1921
c7ad0d99 192220060220
1923 - (dtucker) [INSTALL configure.ac openbsd-compat/openssl-compat.{c,h}]
1924 Add optional enabling of OpenSSL's (hardware) Engine support, via
1925 configure --with-ssl-engine. Based in part on a diff by michal at
1926 logix.cz.
1927
46096a5b 192820060219
1929 - (dtucker) [Makefile.in configure.ac, added openbsd-compat/regress/]
1930 Add first attempt at regress tests for compat library. ok djm@
1931
103ff395 193220060214
1933 - (tim) [buildpkg.sh.in] Make the names consistent.
1934 s/pkg_post_make_install_fixes.sh/pkg-post-make-install-fixes.sh/ OK dtucker@
1935
06a517d4 193620060212
1937 - (dtucker) [openbsd-compat/bsd-cygwin_util.c] Make loop counter unsigned
1938 to silence compiler warning, from vinschen at redhat.com.
0c7e8877 1939 - (tim) [configure.ac] Bug #1149. Disable /etc/default/login check for QNX.
9603096f 1940 - (dtucker) [README version.h contrib/caldera/openssh.spec
1941 contrib/redhat/openssh.spec contrib/suse/openssh.spec] Bump version
1942 strings to match 4.3p2 release.
06a517d4 1943
4c721c3d 194420060208
1945 - (tim) [session.c] Logout records were not updated on systems with
1946 post auth privsep disabled due to bug 1086 changes. Analysis and patch
1947 by vinschen at redhat.com. OK tim@, dtucker@.
4b2cf3f1 1948 - (dtucker) [configure.ac] Typo in Ultrix and NewsOS sections (NEED_SETPRGP
8753ef06 1949 -> NEED_SETPGRP), reported by Bernhard Simon. ok tim@
4c721c3d 1950
5679f14d 195120060206
1952 - (tim) [configure.ac] Remove unnecessary tests for net/if.h and
1953 netinet/in_systm.h. OK dtucker@.
1954
823221b2 195520060205
1956 - (tim) [configure.ac] Add AC_REVISION. Add sys/time.h to lastlog.h test
1957 for Solaris. OK dtucker@.
9c54c067 1958 - (tim) [configure.ac] Bug #1149. Changes in QNX section only. Patch by
1959 kraai at ftbfs.org.
823221b2 1960
c9ecc3c7 196120060203
1962 - (tim) [configure.ac] test for egrep (AC_PROG_EGREP) before first
1963 AC_CHECK_HEADERS test. Without it, if AC_CHECK_HEADERS is first run
1964 by a platform specific check, builtin standard includes tests will be
1965 skipped on the other platforms.
1966 Analysis and suggestion by vinschen at redhat.com, patch by dtucker@.
1967 OK tim@, djm@.
1968
300ea548 196920060202
1970 - (dtucker) [configure.ac] Bug #1148: Fix "crippled AES" test so that it
1971 works with picky compilers. Patch from alex.kiernan at thus.net.
1972
0ceedd4e 197320060201
1974 - (djm) [regress/test-exec.sh] Try 'logname' as well as 'whoami' to
1975 determine the user's login name - needed for regress tests on Solaris
1976 10 and OpenSolaris
f3906047 1977 - (djm) OpenBSD CVS Sync
1978 - jmc@cvs.openbsd.org 2006/02/01 09:06:50
1979 [sshd.8]
1980 - merge sections on protocols 1 and 2 into a single section
1981 - remove configuration file section
1982 ok markus
170c69ba 1983 - jmc@cvs.openbsd.org 2006/02/01 09:11:41
1984 [sshd.8]
1985 small tweak;
026be201 1986 - (djm) [contrib/caldera/openssh.spec contrib/redhat/openssh.spec]
1987 [contrib/suse/openssh.spec] Update versions ahead of release
ac07067e 1988 - markus@cvs.openbsd.org 2006/02/01 11:27:22
1989 [version.h]
1990 openssh 4.3
2ac31303 1991 - (djm) Release OpenSSH 4.3p1
0ceedd4e 1992
0ce89457 199320060131
1994 - (djm) OpenBSD CVS Sync
1995 - jmc@cvs.openbsd.org 2006/01/20 11:21:45
1996 [ssh_config.5]
1997 - word change, agreed w/ markus
1998 - consistency fixes
ec63d7ce 1999 - jmc@cvs.openbsd.org 2006/01/25 09:04:34
2000 [sshd.8]
2001 move the options description up the page, and a few additional tweaks
2002 whilst in here;
2003 ok markus
f464b2f1 2004 - jmc@cvs.openbsd.org 2006/01/25 09:07:22
2005 [sshd.8]
2006 move subsections to full sections;
b661b7fb 2007 - jmc@cvs.openbsd.org 2006/01/26 08:47:56
2008 [ssh.1]
2009 add a section on verifying host keys in dns;
2010 written with a lot of help from jakob;
2011 feedback dtucker/markus;
2012 ok markus
d7b37427 2013 - reyk@cvs.openbsd.org 2006/01/30 12:22:22
2014 [channels.c]
2015 mark channel as write failed or dead instead of read failed on error
2016 of the channel output filter.
2017 ok markus@
062d2977 2018 - jmc@cvs.openbsd.org 2006/01/30 13:37:49
2019 [ssh.1]
2020 remove an incorrect sentence;
2021 reported by roumen petrov;
2022 ok djm markus
4116f5c0 2023 - djm@cvs.openbsd.org 2006/01/31 10:19:02
2024 [misc.c misc.h scp.c sftp.c]
2025 fix local arbitrary command execution vulnerability on local/local and
2026 remote/remote copies (CVE-2006-0225, bz #1094), patch by
2027 t8m AT centrum.cz, polished by dtucker@ and myself; ok markus@
16e8ab10 2028 - djm@cvs.openbsd.org 2006/01/31 10:35:43
2029 [scp.c]
2030 "scp a b c" shouldn't clobber "c" when it is not a directory, report and
2031 fix from biorn@; ok markus@
b645ff66 2032 - (djm) Sync regress tests to OpenBSD:
2033 - dtucker@cvs.openbsd.org 2005/03/10 10:20:39
2034 [regress/forwarding.sh]
2035 Regress test for ClearAllForwardings (bz #994); ok markus@
9b347e5f 2036 - dtucker@cvs.openbsd.org 2005/04/25 09:54:09
2037 [regress/multiplex.sh]
2038 Don't call cleanup in multiplex as test-exec will cleanup anyway
2039 found by tim@, ok djm@
2040 NB. ID sync only, we already had this
2041 - djm@cvs.openbsd.org 2005/05/20 23:14:15
2042 [regress/test-exec.sh]
2043 force addressfamily=inet for tests, unbreaking dynamic-forward regress for
2044 recently committed nc SOCKS5 changes
9f22d634 2045 - djm@cvs.openbsd.org 2005/05/24 04:10:54
89deb4c2 2046 [regress/try-ciphers.sh]
9f22d634 2047 oops, new arcfour modes here too
89deb4c2 2048 - markus@cvs.openbsd.org 2005/06/30 11:02:37
2049 [regress/scp.sh]
2050 allow SUDO=sudo; from Alexander Bluhm
41f70006 2051 - grunk@cvs.openbsd.org 2005/11/14 21:25:56
2052 [regress/agent-getpeereid.sh]
2053 all other scripts in this dir use $SUDO, not 'sudo', so pull this even
2054 ok markus@
71133d5b 2055 - dtucker@cvs.openbsd.org 2005/12/14 04:36:39
2056 [regress/scp-ssh-wrapper.sh]
2057 Fix assumption about how many args scp will pass; ok djm@
2058 NB. ID sync only, we already had this
452613c1 2059 - djm@cvs.openbsd.org 2006/01/27 06:49:21
2060 [scp.sh]
2061 regress test for local to local scp copies; ok dtucker@
3ca1f5b0 2062 - djm@cvs.openbsd.org 2006/01/31 10:23:23
2063 [scp.sh]
2064 regression test for CVE-2006-0225 written by dtucker@
d5b44cf1 2065 - djm@cvs.openbsd.org 2006/01/31 10:36:33
2066 [scp.sh]
2067 regress test for "scp a b c" where "c" is not a directory
0ce89457 2068
eeb27c78 206920060129
2070 - (dtucker) [configure.ac opensshd.init.in] Bug #1144: Use /bin/sh for the
2071 opensshd.init script interpretter if /sbin/sh does not exist. ok tim@
2072
16ad260d 207320060120
2074 - (dtucker) OpenBSD CVS Sync
2075 - jmc@cvs.openbsd.org 2006/01/15 17:37:05
2076 [ssh.1]
2077 correction from deraadt
43a7d9e7 2078 - jmc@cvs.openbsd.org 2006/01/18 10:53:29
2079 [ssh.1]
2080 add a section on ssh-based vpn, based on reyk's README.tun;
db175906 2081 - dtucker@cvs.openbsd.org 2006/01/20 00:14:55
2082 [scp.1 ssh.1 ssh_config.5 sftp.1]
2083 Document RekeyLimit. Based on patch from jan.iven at cern.ch from mindrot
2084 #1056 with feedback from jmc, djm and markus; ok jmc@ djm@
16ad260d 2085
aaa18db9 208620060114
2087 - (djm) OpenBSD CVS Sync
2088 - jmc@cvs.openbsd.org 2006/01/06 13:27:32
2089 [ssh.1]
2090 weed out some duplicate info in the known_hosts FILES entries;
2091 ok djm
5d7b356f 2092 - jmc@cvs.openbsd.org 2006/01/06 13:29:10
2093 [ssh.1]
2094 final round of whacking FILES for duplicate info, and some consistency
2095 fixes;
2096 ok djm
dbb3bf96 2097 - jmc@cvs.openbsd.org 2006/01/12 14:44:12
2098 [ssh.1]
2099 split sections on tcp and x11 forwarding into two sections.
2100 add an example in the tcp section, based on sth i wrote for ssh faq;
2101 help + ok: djm markus dtucker
5d4e571c 2102 - jmc@cvs.openbsd.org 2006/01/12 18:48:48
2103 [ssh.1]
2104 refer to `TCP' rather than `TCP/IP' in the context of connection
2105 forwarding;
2106 ok markus
e5d4cfad 2107 - jmc@cvs.openbsd.org 2006/01/12 22:20:00
2108 [sshd.8]
2109 refer to TCP forwarding, rather than TCP/IP forwarding;
0b3950af 2110 - jmc@cvs.openbsd.org 2006/01/12 22:26:02
2111 [ssh_config.5]
2112 refer to TCP forwarding, rather than TCP/IP forwarding;
c2da64a1 2113 - jmc@cvs.openbsd.org 2006/01/12 22:34:12
2114 [ssh.1]
2115 back out a sentence - AUTHENTICATION already documents this;
aaa18db9 2116
794febd2 211720060109
2118 - (dtucker) [contrib/cygwin/ssh-host-config] Make sshd service depend on
2119 tcpip service so it's always started after IP is up. Patch from
2120 vinschen at redhat.com.
2121
0624a70b 212220060106
2123 - (djm) OpenBSD CVS Sync
2124 - jmc@cvs.openbsd.org 2006/01/03 16:31:10
2125 [ssh.1]
2126 move FILES to a -compact list, and make each files an item in that list.
2127 this avoids nastly line wrap when we have long pathnames, and treats
2128 each file as a separate item;
2129 remove the .Pa too, since it is useless.
0502727e 2130 - jmc@cvs.openbsd.org 2006/01/03 16:35:30
2131 [ssh.1]
2132 use a larger width for the ENVIRONMENT list;
f403d7b5 2133 - jmc@cvs.openbsd.org 2006/01/03 16:52:36
2134 [ssh.1]
2135 put FILES in some sort of order: sort by pathname
c0907b37 2136 - jmc@cvs.openbsd.org 2006/01/03 16:55:18
2137 [ssh.1]
2138 tweak the description of ~/.ssh/environment
f3119772 2139 - jmc@cvs.openbsd.org 2006/01/04 18:42:46
2140 [ssh.1]
2141 chop out some duplication in the .{r,s}hosts/{h,sh}osts.equiv FILES
2142 entries;
2143 ok markus
6c276bb9 2144 - jmc@cvs.openbsd.org 2006/01/04 18:45:01
2145 [ssh.1]
2146 remove .Xr's to rsh(1) and telnet(1): they are hardly needed;
926f6a7a 2147 - jmc@cvs.openbsd.org 2006/01/04 19:40:24
2148 [ssh.1]
2149 +.Xr ssh-keyscan 1 ,
ccce91ef 2150 - jmc@cvs.openbsd.org 2006/01/04 19:50:09
2151 [ssh.1]
2152 -.Xr gzip 1 ,
db382686 2153 - djm@cvs.openbsd.org 2006/01/05 23:43:53
2154 [misc.c]
2155 check that stdio file descriptors are actually closed before clobbering
2156 them in sanitise_stdfd(). problems occurred when a lower numbered fd was
2157 closed, but higher ones weren't. spotted by, and patch tested by
2158 Frédéric Olivié
0624a70b 2159
d3506f6d 216020060103
2161 - (djm) [channels.c] clean up harmless merge error, from reyk@
2162
79e46360 216320060103
2164 - (djm) OpenBSD CVS Sync
2165 - jmc@cvs.openbsd.org 2006/01/02 17:09:49
2166 [ssh_config.5 sshd_config.5]
2167 some corrections from michael knudsen;
2168
6f6cd507 216920060102
2170 - (djm) [README.tun] Add README.tun, missed during sync of tun(4) support
4b5e6c81 2171 - (djm) OpenBSD CVS Sync
2172 - jmc@cvs.openbsd.org 2005/12/31 10:46:17
2173 [ssh.1]
2174 merge the "LOGIN SESSION AND REMOTE EXECUTION" and "SERVER
2175 AUTHENTICATION" sections into "AUTHENTICATION";
2176 some rewording done to make the text read better, plus some
2177 improvements from djm;
2178 ok djm
b92605e1 2179 - jmc@cvs.openbsd.org 2005/12/31 13:44:04
2180 [ssh.1]
2181 clean up ENVIRONMENT a little;
20892533 2182 - jmc@cvs.openbsd.org 2005/12/31 13:45:19
2183 [ssh.1]
2184 .Nm does not require an argument;
1f1fbbd8 2185 - stevesk@cvs.openbsd.org 2006/01/01 08:59:27
2186 [includes.h misc.c]
2187 move <net/if.h>; ok djm@
81c042a3 2188 - stevesk@cvs.openbsd.org 2006/01/01 10:08:48
2189 [misc.c]
2190 no trailing "\n" for debug()
3eee3b86 2191 - djm@cvs.openbsd.org 2006/01/02 01:20:31
2192 [sftp-client.c sftp-common.h sftp-server.c]
2193 use a common max. packet length, no binary change
b1b65311 2194 - reyk@cvs.openbsd.org 2006/01/02 07:53:44
2195 [misc.c]
2196 clarify tun(4) opening - set the mode and bring the interface up. also
2197 (re)sets the tun(4) layer 2 LINK0 flag for existing tunnel interfaces.
2198 suggested and ok by djm@
d141c93d 2199 - jmc@cvs.openbsd.org 2006/01/02 12:31:06
2200 [ssh.1]
2201 start to cut some duplicate info from FILES;
2202 help/ok djm
6f6cd507 2203
0f6cb079 220420060101
2205 - (djm) [Makefile.in configure.ac includes.h misc.c]
2206 [openbsd-compat/port-tun.c openbsd-compat/port-tun.h] Add support
2207 for tunnel forwarding for FreeBSD and NetBSD. NetBSD's support is
2208 limited to IPv4 tunnels only, and most versions don't support the
2209 tap(4) device at all.
b5081213 2210 - (djm) [configure.ac] Fix linux/if_tun.h test
3aef38da 2211 - (djm) [openbsd-compat/port-tun.c] Linux needs linux/if.h too
0f6cb079 2212
1908529f 221320051229
2214 - (djm) OpenBSD CVS Sync
2215 - stevesk@cvs.openbsd.org 2005/12/28 22:46:06
2216 [canohost.c channels.c clientloop.c]
2217 use 'break-in' for consistency; ok deraadt@ ok and input jmc@
c1c6a032 2218 - reyk@cvs.openbsd.org 2005/12/30 15:56:37
2219 [channels.c channels.h clientloop.c]
2220 add channel output filter interface.
2221 ok djm@, suggested by markus@
3da242db 2222 - jmc@cvs.openbsd.org 2005/12/30 16:59:00
2223 [sftp.1]
2224 do not suggest that interactive authentication will work
2225 with the -b flag;
2226 based on a diff from john l. scarfone;
2227 ok djm
f470cf48 2228 - stevesk@cvs.openbsd.org 2005/12/31 01:38:45
2229 [ssh.1]
2230 document -MM; ok djm@
e914f53a 2231 - (djm) [openbsd-compat/port-tun.c openbsd-compat/port-tun.h configure.ac]
2232 [serverloop.c ssh.c openbsd-compat/Makefile.in]
2233 [openbsd-compat/openbsd-compat.h] Implement tun(4) forwarding
2234 compatability support for Linux, diff from reyk@
c40f09ca 2235 - (djm) [configure.ac] Disable Linux tun(4) compat code if linux/tun.h does
2236 not exist
d91775e1 2237 - (djm) [configure.ac] oops, make that linux/if_tun.h
1908529f 2238
b5c428f0 223920051229
2240 - (tim) [buildpkg.sh.in] grep for $SSHDUID instead of $SSHDGID on /etc/passwd
2241
6b0117fd 224220051224
2243 - (djm) OpenBSD CVS Sync
2244 - jmc@cvs.openbsd.org 2005/12/20 21:59:43
2245 [ssh.1]
2246 merge the sections on protocols 1 and 2 into one section on
2247 authentication;
2248 feedback djm dtucker
2249 ok deraadt markus dtucker
5c5546be 2250 - jmc@cvs.openbsd.org 2005/12/20 22:02:50
2251 [ssh.1]
2252 .Ss -> .Sh: subsections have not made this page more readable
e6c7c03e 2253 - jmc@cvs.openbsd.org 2005/12/20 22:09:41
2254 [ssh.1]
2255 move info on ssh return values and config files up into the main
2256 description;
e49f7abd 2257 - jmc@cvs.openbsd.org 2005/12/21 11:48:16
2258 [ssh.1]
2259 -L and -R descriptions are now above, not below, ~C description;
8770ef76 2260 - jmc@cvs.openbsd.org 2005/12/21 11:57:25
2261 [ssh.1]
2262 options now described `above', rather than `later';
6e1e9c73 2263 - jmc@cvs.openbsd.org 2005/12/21 12:53:31
2264 [ssh.1]
2265 -Y does X11 forwarding too;
2266 ok markus
6cd6c442 2267 - stevesk@cvs.openbsd.org 2005/12/21 22:44:26
2268 [sshd.8]
2269 clarify precedence of -p, Port, ListenAddress; ok and help jmc@
0c9851b1 2270 - jmc@cvs.openbsd.org 2005/12/22 10:31:40
2271 [ssh_config.5]
2272 put the description of "UsePrivilegedPort" in the correct place;
9bf41db3 2273 - jmc@cvs.openbsd.org 2005/12/22 11:23:42
2274 [ssh.1]
2275 expand the description of -w somewhat;
2276 help/ok reyk
86131206 2277 - jmc@cvs.openbsd.org 2005/12/23 14:55:53
2278 [ssh.1]
2279 - sync the description of -e w/ synopsis
2280 - simplify the description of -I
2281 - note that -I is only available if support compiled in, and that it
2282 isn't by default
2283 feedback/ok djm@
025fc42e 2284 - jmc@cvs.openbsd.org 2005/12/23 23:46:23
2285 [ssh.1]
2286 less mark up for -c;
678143bd 2287 - djm@cvs.openbsd.org 2005/12/24 02:27:41
2288 [session.c sshd.c]
2289 eliminate some code duplicated in privsep and non-privsep paths, and
2290 explicitly clear SIGALRM handler; "groovy" deraadt@
6b0117fd 2291
a2b1748a 229220051220
2293 - (dtucker) OpenBSD CVS Sync
2294 - reyk@cvs.openbsd.org 2005/12/13 15:03:02
2295 [serverloop.c]
2296 if forced_tun_device is not set, it is -1 and not SSH_TUNID_ANY
442c8b33 2297 - jmc@cvs.openbsd.org 2005/12/16 18:07:08
2298 [ssh.1]
2299 move the option descriptions up the page: start of a restructure;
2300 ok markus deraadt
e426efa9 2301 - jmc@cvs.openbsd.org 2005/12/16 18:08:53
2302 [ssh.1]
2303 simplify a sentence;
28ca205d 2304 - jmc@cvs.openbsd.org 2005/12/16 18:12:22
2305 [ssh.1]
2306 make the description of -c a little nicer;
a55c1733 2307 - jmc@cvs.openbsd.org 2005/12/16 18:14:40
2308 [ssh.1]
2309 signpost the protocol sections;
8918b906 2310 - stevesk@cvs.openbsd.org 2005/12/17 21:13:05
2311 [ssh_config.5 session.c]
2312 spelling: fowarding, fowarded
551ed07c 2313 - stevesk@cvs.openbsd.org 2005/12/17 21:36:42
2314 [ssh_config.5]
2315 spelling: intented -> intended
3aa43b24 2316 - dtucker@cvs.openbsd.org 2005/12/20 04:41:07
2317 [ssh.c]
2318 exit(255) on error to match description in ssh(1); bz #1137; ok deraadt@
a2b1748a 2319
e5146707 232020051219
2321 - (dtucker) [cipher-aes.c cipher-ctr.c cipher.c configure.ac
2322 openbsd-compat/openssl-compat.h] Check for and work around broken AES
2323 ciphers >128bit on (some) Solaris 10 systems. ok djm@
2324
2f89281c 232520051217
2326 - (dtucker) [defines.h] HP-UX system headers define "YES" and "NO" which
2327 scp.c also uses, so undef them here.
31b0732a 2328 - (dtucker) [configure.ac openbsd-compat/bsd-snprintf.c] Bug #1133: Our
2329 snprintf replacement can have a conflicting declaration in HP-UX's system
2330 headers (const vs. no const) so we now check for and work around it. Patch
2331 from the dynamic duo of David Leonard and Ted Percival.
2f89281c 2332
9fed02d8 233320051214
2334 - (dtucker) OpenBSD CVS Sync (regress/)
2335 - dtucker@cvs.openbsd.org 2005/12/30 04:36:39
2336 [regress/scp-ssh-wrapper.sh]
2337 Fix assumption about how many args scp will pass; ok djm@
2338
d7cf99ff 233920051213
2340 - (djm) OpenBSD CVS Sync
2341 - jmc@cvs.openbsd.org 2005/11/30 11:18:27
2342 [ssh.1]
2343 timezone -> time zone
04ac3e62 2344 - jmc@cvs.openbsd.org 2005/11/30 11:45:20
2345 [ssh.1]
2346 avoid ambiguities in describing TZ;
2347 ok djm@
d20f3c9e 2348 - reyk@cvs.openbsd.org 2005/12/06 22:38:28
2349 [auth-options.c auth-options.h channels.c channels.h clientloop.c]
2350 [misc.c misc.h readconf.c readconf.h scp.c servconf.c servconf.h]
2351 [serverloop.c sftp.c ssh.1 ssh.c ssh_config ssh_config.5 sshconnect.c]
2352 [sshconnect.h sshd.8 sshd_config sshd_config.5]
2353 Add support for tun(4) forwarding over OpenSSH, based on an idea and
2354 initial channel code bits by markus@. This is a simple and easy way to
2355 use OpenSSH for ad hoc virtual private network connections, e.g.
2356 administrative tunnels or secure wireless access. It's based on a new
2357 ssh channel and works similar to the existing TCP forwarding support,
2358 except that it depends on the tun(4) network interface on both ends of
2359 the connection for layer 2 or layer 3 tunneling. This diff also adds
2360 support for LocalCommand in the ssh(1) client.
d20f3c9e 2361 ok djm@, markus@, jmc@ (manpages), tested and discussed with others
ceec33f3 2362 - djm@cvs.openbsd.org 2005/12/07 03:52:22
2363 [clientloop.c]
2364 reyk forgot to compile with -Werror (missing header)
985bb789 2365 - jmc@cvs.openbsd.org 2005/12/07 10:52:13
2366 [ssh.1]
2367 - avoid line split in SYNOPSIS
2368 - add args to -w
2369 - kill trailing whitespace
64925c6d 2370 - jmc@cvs.openbsd.org 2005/12/08 14:59:44
2371 [ssh.1 ssh_config.5]
2372 make `!command' a little clearer;
2373 ok reyk
030723f9 2374 - jmc@cvs.openbsd.org 2005/12/08 15:06:29
2375 [ssh_config.5]
2376 keep options in order;
a4f24bf8 2377 - reyk@cvs.openbsd.org 2005/12/08 18:34:11
2378 [auth-options.c includes.h misc.c misc.h readconf.c servconf.c]
2379 [serverloop.c ssh.c ssh_config.5 sshd_config.5 configure.ac]
2380 two changes to the new ssh tunnel support. this breaks compatibility
2381 with the initial commit but is required for a portable approach.
2382 - make the tunnel id u_int and platform friendly, use predefined types.
2383 - support configuration of layer 2 (ethernet) or layer 3
2384 (point-to-point, default) modes. configuration is done using the
2385 Tunnel (yes|point-to-point|ethernet|no) option is ssh_config(5) and
2386 restricted by the PermitTunnel (yes|point-to-point|ethernet|no) option
2387 in sshd_config(5).
2388 ok djm@, man page bits by jmc@
a274ba38 2389 - jmc@cvs.openbsd.org 2005/12/08 21:37:50
2390 [ssh_config.5]
2391 new sentence, new line;
b872f7f0 2392 - markus@cvs.openbsd.org 2005/12/12 13:46:18
2393 [channels.c channels.h session.c]
2394 make sure protocol messages for internal channels are ignored.
2395 allow adjust messages for non-open channels; with and ok djm@
6306853a 2396 - (djm) [misc.c] Disable tunnel code for non-OpenBSD (for now), enable
2397 again by providing a sys_tun_open() function for your platform and
2398 setting the CUSTOM_SYS_TUN_OPEN define. More work is required to match
2399 OpenBSD's tunnel protocol, which prepends the address family to the
2400 packet
d7cf99ff 2401
fbc06315 240220051201
2403 - (djm) [envpass.sh] Remove regress script that was accidentally committed
2404 in top level directory and not noticed for over a year :)
2405
6e94bd72 240620051129
2407 - (tim) [ssh-keygen.c] Move DSA length test after setting default when
2408 bits == 0.
60dc0294 2409 - (dtucker) OpenBSD CVS Sync
2410 - dtucker@cvs.openbsd.org 2005/11/29 02:04:55
2411 [ssh-keygen.c]
2412 Populate default key sizes before checking them; from & ok tim@
e45da4d6 2413 - (tim) [configure.ac sshd.8] Enable locked account check (a "*LK*" string)
2414 for UnixWare.
6e94bd72 2415
b7bb251f 241620051128
2417 - (dtucker) [regress/yes-head.sh] Work around breakage caused by some
2418 versions of GNU head. Based on patch from zappaman at buraphalinux.org
8b396721 2419 - (dtucker) [includes.h] Bug #1122: __USE_GNU is a glibc internal macro, use
2420 _GNU_SOURCE instead. Patch from t8m at centrum.cz.
c6d7b211 2421 - (dtucker) OpenBSD CVS Sync
2422 - dtucker@cvs.openbsd.org 2005/11/28 05:16:53
2423 [ssh-keygen.1 ssh-keygen.c]
2424 Enforce DSA key length of exactly 1024 bits to comply with FIPS-186-2,
2425 increase minumum RSA key size to 768 bits and update man page to reflect
2426 these. Patch originally bz#1119 (senthilkumar_sen at hotpop.com),
2427 ok djm@, grudging ok deraadt@.
98e93fbc 2428 - dtucker@cvs.openbsd.org 2005/11/28 06:02:56
2429 [ssh-agent.1]
2430 Update agent socket path templates to reflect reality, correct xref for
2431 time formats. bz#1121, patch from openssh at roumenpetrov.info, ok djm@
b7bb251f 2432
961c2997 243320051126
2434 - (dtucker) [configure.ac] Bug #1126: AIX 5.2 and 5.3 (and presumably newer,
2435 when they're available) need the real UID set otherwise pam_chauthtok will
2436 set ADMCHG after changing the password, forcing the user to change it
2437 again immediately.
2438
ccc45ee0 243920051125
2440 - (dtucker) [configure.ac] Apply tim's fix for older systems where the
2441 resolver state in resolv.h is "state" not "__res_state". With slight
2442 modification by me to also work on old AIXes. ok djm@
419094c6 2443 - (dtucker) [progressmeter.c scp.c sftp-server.c] Use correct casts for
2444 snprintf formats, fixes warnings on some 64 bit platforms. Patch from
2445 shaw at vranix.com, ok djm@
ccc45ee0 2446
244720051124
9a406e1e 2448 - (djm) [configure.ac openbsd-compat/Makefile.in openbsd-compat/bsd-asprintf.c
2449 openbsd-compat/bsd-snprintf.c openbsd-compat/openbsd-compat.h] Add an
2450 asprintf() implementation, after syncing our {v,}snprintf() implementation
2451 with some extra fixes from Samba's version. With help and debugging from
2452 dtucker and tim; ok dtucker@
d08db6d1 2453 - (dtucker) [configure.ac] Fix typos in comments and AC_SEARCH_LIB argument
2454 order in Reliant Unix block. Patch from johane at lysator.liu.se.
d77c7dff 2455 - (dtucker) [regress/test-exec.sh] Use 1024 bit keys since we generate so
2456 many and use them only once. Speeds up testing on older/slower hardware.
9a406e1e 2457
932ab351 245820051122
2459 - (dtucker) OpenBSD CVS Sync
2460 - deraadt@cvs.openbsd.org 2005/11/12 18:37:59
2461 [ssh-add.c]
2462 space
29accf74 2463 - deraadt@cvs.openbsd.org 2005/11/12 18:38:15
2464 [scp.c]
2465 avoid close(-1), as in rcp; ok cloder
a001f9d7 2466 - millert@cvs.openbsd.org 2005/11/15 11:59:54
2467 [includes.h]
2468 Include sys/queue.h explicitly instead of assuming some other header
2469 will pull it in. At the moment it gets pulled in by sys/select.h
2470 (which ssh has no business including) via event.h. OK markus@
2471 (ID sync only in -portable)
426cef74 2472 - dtucker@cvs.openbsd.org 2005/11/21 09:42:10
2473 [auth-krb5.c]
2474 Perform Kerberos calls even for invalid users to prevent leaking
2475 information about account validity. bz #975, patch originally from
2476 Senthil Kumar, sanity checked by Simon Wilkinson, tested by djm@, biorn@,
2477 ok markus@
18f8ef7a 2478 - dtucker@cvs.openbsd.org 2005/11/22 03:36:03
2479 [hostfile.c]
2480 Correct format/arguments to debug call; spotted by shaw at vranix.com
2481 ok djm@
dfde7f6e 2482 - (dtucker) [loginrec.c] Add casts to prevent compiler warnings, patch
2483 from shaw at vranix.com.
932ab351 2484
60e10887 248520051120
2486 - (dtucker) [openbsd-compat/openssl-compat.h] Add comment explaining what
2487 is going on.
2488
4162eae5 248920051112
2490 - (dtucker) [openbsd-compat/getrrsetbyname.c] Restore Portable-specific
2491 ifdef lost during sync. Spotted by tim@.
f97dc218 2492 - (dtucker) [openbsd-compat/{realpath.c,stroll.c,rresvport.c}] $OpenBSD tag.
eeee8237 2493 - (dtucker) [configure.ac] Use "$AWK" instead of "awk" in gcc version test.
23361281 2494 - (dtucker) [configure.ac] Remove duplicate utimes() check. ok djm@
29aaf112 2495 - (dtucker) [regress/reconfigure.sh] Fix potential race in the reconfigure
2496 test: if sshd takes too long to reconfigure the subsequent connection will
2497 fail. Zap pidfile before HUPing sshd which will rewrite it when it's ready.
4162eae5 2498
e1658b5c 249920051110
b69585d9 2500 - (dtucker) [openbsd-compat/setenv.c] Merge changes for __findenv from
e1658b5c 2501 OpenBSD getenv.c revs 1.4 - 1.8 (ANSIfication of arguments, removal of
2502 "register").
b69585d9 2503 - (dtucker) [openbsd-compat/setenv.c] Make __findenv static, remove
7b2dcf21 2504 unnecessary prototype.
b69585d9 2505 - (dtucker) [openbsd-compat/setenv.c] Sync changes from OpenBSD setenv.c
2506 revs 1.7 - 1.9.
c080bed1 2507 - (dtucker) [auth-krb5.c] Fix -Wsign-compare warning in non-Heimdal path.
2508 Patch from djm@.
dbf07ba2 2509 - (dtucker) [configure.ac] Disable pointer-sign warnings on gcc 4.0+
2510 since they're not useful right now. Patch from djm@.
242652fe 2511 - (dtucker) [openbsd-compat/getgrouplist.c] Sync OpenBSD revs 1.10 - 1.2 (ANSI
2512 prototypes, removal of "register").
432e59f9 2513 - (dtucker) [openbsd-compat/strlcat.c] Sync OpenBSD revs 1.11 - 1.12 (removal
2514 of "register").
f6d4fb87 2515 - (dtucker) [openbsd-compat/{LOTS}] Move the "OPENBSD ORIGINAL" markers to
2516 after the copyright notices. Having them at the top next to the CVSIDs
2517 guarantees a conflict for each and every sync.
e4f65477 2518 - (dtucker) [openbsd-compat/strlcpy.c] Update from OpenBSD 1.8 -> 1.10.
bfd4a832 2519 - (dtucker) [openbsd-compat/sigact.h] Add "OPENBSD ORIGINAL" marker.
bc16ca63 2520 - (dtucker) [openbsd-compat/strmode.c] Update from OpenBSD 1.5 -> 1.7.
2521 Removal of rcsid, "whiteout" inode type.
7dfb4a82 2522 - (dtucker) [openbsd-compat/basename.c] Update from OpenBSD 1.11 -> 1.14.
2523 Removal of rcsid, will no longer strlcpy parts of the string.
d8922805 2524 - (dtucker) [openbsd-compat/strtoll.c] Update from OpenBSD 1.4 -> 1.5.
4ff445f1 2525 - (dtucker) [openbsd-compat/strtoul.c] Update from OpenBSD 1.5 -> 1.7.
e1829842 2526 - (dtucker) [openbsd-compat/readpassphrase.c] Update from OpenBSD 1.16 -> 1.18.
625552b8 2527 - (dtucker) [openbsd-compat/readpassphrase.h] Update from OpenBSD 1.3 -> 1.5.
a65ea33b 2528 - (dtucker) [openbsd-compat/glob.c] Update from OpenBSD 1.22 -> 1.25.
b84a707a 2529 - (dtucker) [openbsd-compat/glob.h] Update from OpenBSD 1.8 -> 1.9.
281bbb02 2530 - (dtucker) [openbsd-compat/getcwd.c] Update from OpenBSD 1.9 -> 1.14.
16d51c41 2531 - (dtucker) [openbsd-compat/getcwd.c] Replace lstat with fstat to match up
2532 with OpenBSD code since we don't support platforms without fstat any more.
b53df919 2533 - (dtucker) [openbsd-compat/inet_aton.c] Update from OpenBSD 1.7 -> 1.9.
68b36828 2534 - (dtucker) [openbsd-compat/inet_ntoa.c] Update from OpenBSD 1.4 -> 1.6.
2535 - (dtucker) [openbsd-compat/inet_ntop.c] Update from OpenBSD 1.5 -> 1.7.
fc1c42f3 2536 - (dtucker) [openbsd-compat/daemon.c] Update from OpenBSD 1.5 -> 1.6.
0695e921 2537 - (dtucker) [openbsd-compat/strsep.c] Update from OpenBSD 1.5 -> 1.6.
3c8f7a26 2538 - (dtucker) [openbsd-compat/daemon.c] Update from OpenBSD 1.10 -> 1.13.
5bf337a5 2539 - (dtucker) [openbsd-compat/mktemp.c] Update from OpenBSD 1.17 -> 1.19.
8c603515 2540 - (dtucker) [openbsd-compat/rresvport.c] Update from OpenBSD 1.6 -> 1.8.
c9d7b187 2541 - (dtucker) [openbsd-compat/bindresvport.c] Add "OPENBSD ORIGINAL" marker.
295034ce 2542 - (dtucker) [openbsd-compat/bindresvport.c] Update from OpenBSD 1.16 -> 1.17.
3e6325a6 2543 - (dtucker) [openbsd-compat/sigact.c] Update from OpenBSD 1.3 -> 1.4.
2544 Id and copyright sync only, there were no substantial changes we need.
8d767ef2 2545 - (dtucker) [openbsd-compat/bsd-closefrom.c openbsd-compat/base64.c]
6bd2d8e5 2546 -Wsign-compare fixes from djm.
e1b4416e 2547 - (dtucker) [openbsd-compat/sigact.h] Update from OpenBSD 1.2 -> 1.3.
2548 Id and copyright sync only, there were no substantial changes we need.
cd595991 2549 - (dtucker) [configure.ac] Try to get the gcc version number in a way that
2550 doesn't change between versions, and use a safer default.
e1658b5c 2551
255d3e00 255220051105
2553 - (djm) OpenBSD CVS Sync
2554 - markus@cvs.openbsd.org 2005/10/07 11:13:57
2555 [ssh-keygen.c]
2556 change DSA default back to 1024, as it's defined for 1024 bits only
2557 and this causes interop problems with other clients. moreover,
2558 in order to improve the security of DSA you need to change more
2559 components of DSA key generation (e.g. the internal SHA1 hash);
2560 ok deraadt
8cd0437d 2561 - djm@cvs.openbsd.org 2005/10/10 10:23:08
2562 [channels.c channels.h clientloop.c serverloop.c session.c]
2563 fix regression I introduced in 4.2: X11 forwardings initiated after
2564 a session has exited (e.g. "(sleep 5; xterm) &") would not start.
2565 bz #1086 reported by t8m AT centrum.cz; ok markus@ dtucker@
442aee3a 2566 - djm@cvs.openbsd.org 2005/10/11 23:37:37
2567 [channels.c]
2568 bz #1076 set SO_REUSEADDR on X11 forwarding listner sockets, preventing
2569 bind() failure when a previous connection's listeners are in TIME_WAIT,
2570 reported by plattner AT inf.ethz.ch; ok dtucker@
b96eade6 2571 - stevesk@cvs.openbsd.org 2005/10/13 14:03:01
2572 [auth2-gss.c gss-genr.c gss-serv.c]
2573 remove unneeded #includes; ok markus@
6e902aec 2574 - stevesk@cvs.openbsd.org 2005/10/13 14:20:37
2575 [gss-serv.c]
2576 spelling in comments
6472fefc 2577 - stevesk@cvs.openbsd.org 2005/10/13 19:08:08
2578 [gss-serv-krb5.c gss-serv.c]
2579 unused declarations; ok deraadt@
2580 (id sync only for gss-serv-krb5.c)
adf8c40b 2581 - stevesk@cvs.openbsd.org 2005/10/13 19:13:41
2582 [dns.c]
2583 unneeded #include, unused declaration, little knf; ok deraadt@
8442cc66 2584 - stevesk@cvs.openbsd.org 2005/10/13 22:24:31
2585 [auth2-gss.c gss-genr.c gss-serv.c monitor.c]
2586 KNF; ok djm@
17318dd6 2587 - stevesk@cvs.openbsd.org 2005/10/14 02:17:59
2588 [ssh-keygen.c ssh.c sshconnect2.c]
2589 no trailing "\n" for log functions; ok djm@
8c4bd764 2590 - stevesk@cvs.openbsd.org 2005/10/14 02:29:37
2591 [channels.c clientloop.c]
2592 free()->xfree(); ok djm@
ed82a2a9 2593 - stevesk@cvs.openbsd.org 2005/10/15 15:28:12
2594 [sshconnect.c]
2595 make external definition static; ok deraadt@
7238b6e4 2596 - stevesk@cvs.openbsd.org 2005/10/17 13:45:05
2597 [dns.c]
2598 fix memory leaks from 2 sources:
2599 1) key_fingerprint_raw()
2600 2) malloc in dns_read_rdata()
2601 ok jakob@
2602 - stevesk@cvs.openbsd.org 2005/10/17 14:01:28
2603 [dns.c]
2604 remove #ifdef LWRES; ok jakob@
8374cf6f 2605 - stevesk@cvs.openbsd.org 2005/10/17 14:13:35
2606 [dns.c dns.h]
2607 more cleanups; ok jakob@
6b0b0d65 2608 - djm@cvs.openbsd.org 2005/10/30 01:23:19
2609 [ssh_config.5]
2610 mention control socket fallback behaviour, reported by
2611 tryponraj AT gmail.com
2995db03 2612 - djm@cvs.openbsd.org 2005/10/30 04:01:03
2613 [ssh-keyscan.c]
2614 make ssh-keygen discard junk from server before SSH- ident, spotted by
2615 dave AT cirt.net; ok dtucker@
aa9bc1de 2616 - djm@cvs.openbsd.org 2005/10/30 04:03:24
2617 [ssh.c]
2618 fix misleading debug message; ok dtucker@
3a85986d 2619 - dtucker@cvs.openbsd.org 2005/10/30 08:29:29
2620 [canohost.c sshd.c]
2621 Check for connections with IP options earlier and drop silently. ok djm@
db98627d 2622 - jmc@cvs.openbsd.org 2005/10/30 08:43:47
2623 [ssh_config.5]
2624 remove trailing whitespace;
7b9b0103 2625 - djm@cvs.openbsd.org 2005/10/30 08:52:18
2626 [clientloop.c packet.c serverloop.c session.c ssh-agent.c ssh-keygen.c]
2627 [ssh.c sshconnect.c sshconnect1.c sshd.c]
2628 no need to escape single quotes in comments, no binary change
bdd3b323 2629 - dtucker@cvs.openbsd.org 2005/10/31 06:15:04
2630 [sftp.c]
2631 Fix sorting with "ls -1" command. From Robert Tsai, "looks right" deraadt@
882c9d5a 2632 - djm@cvs.openbsd.org 2005/10/31 11:12:49
2633 [ssh-keygen.1 ssh-keygen.c]
2634 generate a protocol 2 RSA key by default
6af12d46 2635 - djm@cvs.openbsd.org 2005/10/31 11:48:29
2636 [serverloop.c]
2637 make sure we clean up wtmp, etc. file when we receive a SIGTERM,
2638 SIGINT or SIGQUIT when running without privilege separation (the
2639 normal privsep case is already OK). Patch mainly by dtucker@ and
2640 senthilkumar_sen AT hotpop.com; ok dtucker@
3543c5e1 2641 - jmc@cvs.openbsd.org 2005/10/31 19:55:25
2642 [ssh-keygen.1]
2643 grammar;
0bbbf2a4 2644 - dtucker@cvs.openbsd.org 2005/11/03 13:38:29
2645 [canohost.c]
2646 Cache reverse lookups with and without DNS separately; ok markus@
47e5dc72 2647 - djm@cvs.openbsd.org 2005/11/04 05:15:59
2648 [kex.c kex.h kexdh.c kexdhc.c kexdhs.c kexgex.c kexgexc.c kexgexs.c]
2649 remove hardcoded hash lengths in key exchange code, allowing
2650 implementation of KEX methods with different hashes (e.g. SHA-256);
2651 ok markus@ dtucker@ stevesk@
27e3ef36 2652 - djm@cvs.openbsd.org 2005/11/05 05:01:15
2653 [bufaux.c]
2654 Fix leaks in error paths, bz #1109 and #1110 reported by kremenek AT
2655 cs.stanford.edu; ok dtucker@
e557f3b5 2656 - (dtucker) [README.platform] Add PAM section.
ebb049f1 2657 - (djm) [openbsd-compat/getrrsetbyname.c] Sync to latest OpenBSD version,
2658 resolving memory leak bz#1111 reported by kremenek AT cs.stanford.edu;
2659 ok dtucker@
255d3e00 2660
bd2a0801 266120051102
2662 - (dtucker) [openbsd-compat/bsd-misc.c] Bug #1108: fix broken strdup().
2663 Reported by olavi at ipunplugged.com and antoine.brodin at laposte.net
2664 via FreeBSD.
2665
5097eaa9 266620051030
2667 - (djm) [contrib/suse/openssh.spec contrib/suse/rc.
2668 sshd contrib/suse/sysconfig.ssh] Bug #1106: Updated SuSE spec and init
2669 files from imorgan AT nas.nasa.gov
0a61a240 2670 - (dtucker) [session.c] Bug #1045do not check /etc/nologin when PAM is
2671 enabled, instead allow PAM to handle it. Note that on platforms using PAM,
2672 the pam_nologin module should be added to sshd's session stack in order to
2673 maintain exising behaviour. Based on patch and discussion from t8m at
2674 centrum.cz, ok djm@
5097eaa9 2675
90f15776 267620051025
2677 - (dtucker) [configure.ac] Relocate LLONG_MAX calculation to after the
2678 sizeof(long long) checks, to make fixing bug #1104 easier (no changes
2679 yet).
d75dfaa6 2680 - (dtucker) [configure.ac] Bug #1104: Tru64's printf family doesn't
2681 understand "%lld", even though the compiler has "long long", so handle
2682 it as a special case. Patch tested by mcaskill.scott at epa.gov.
b8bc9d84 2683 - (dtucker) [contrib/cygwin/ssh-user-config] Remove duplicate yes/no
2684 prompt. Patch from vinschen at redhat.com.
90f15776 2685
b0e7249f 268620051017
2687 - (dtucker) [configure.ac] Bug #1097: Fix configure for cross-compiling.
2688 /etc/default/login report and testing from aabaker at iee.org, corrections
2689 from tim@.
2690
8034a348 269120051009
2692 - (dtucker) [configure.ac defines.h openbsd-compat/vis.{c,h}] Sync current
2693 versions from OpenBSD. ok djm@
2694
83f987c3 269520051008
2696 - (dtucker) [configure.ac] Bug #1098: define $MAIL for HP-UX; report from
2697 brian.smith at agilent com.
1012885d 2698 - (djm) [configure.ac] missing 'test' call for -with-Werror test
83f987c3 2699
278f9900 270020051005
2701 - (dtucker) [configure.ac sshd.8] Enable locked account check (a prepended
2702 "*LOCKED*" string) for FreeBSD. Patch jeremie at le-hen.org and
2703 senthilkumar_sen at hotpop.com.
2704
59e5aff5 270520051003
2706 - (dtucker) OpenBSD CVS Sync
2707 - markus@cvs.openbsd.org 2005/09/07 08:53:53
2708 [channels.c]
2709 enforce chanid != NULL; ok djm
b5443199 2710 - markus@cvs.openbsd.org 2005/09/09 19:18:05
2711 [clientloop.c]
2712 typo; from mark at mcs.vuw.ac.nz, bug #1082
fd6168c1 2713 - djm@cvs.openbsd.org 2005/09/13 23:40:07
2714 [sshd.c ssh.c misc.h sftp.c ssh-keygen.c ssh-keysign.c sftp-server.c
2715 scp.c misc.c ssh-keyscan.c ssh-add.c ssh-agent.c]
2716 ensure that stdio fds are attached; ok deraadt@
5ddc5eb4 2717 - djm@cvs.openbsd.org 2005/09/19 11:37:34
2718 [ssh_config.5 ssh.1]
2719 mention ability to specify bind_address for DynamicForward and -D options;
2720 bz#1077 spotted by Haruyama Seigo
d77dd4d7 2721 - djm@cvs.openbsd.org 2005/09/19 11:47:09
2722 [sshd.c]
2723 stop connection abort on rekey with delayed compression enabled when
2724 post-auth privsep is disabled (e.g. when root is logged in); ok dtucker@
67003554 2725 - djm@cvs.openbsd.org 2005/09/19 11:48:10
2726 [gss-serv.c]
2727 typo
37c406a8 2728 - jmc@cvs.openbsd.org 2005/09/19 15:38:27
2729 [ssh.1]
2730 some more .Bk/.Ek to avoid ugly line split;
80e29ee6 2731 - jmc@cvs.openbsd.org 2005/09/19 15:42:44
2732 [ssh.c]
2733 update -D usage here too;
2915e42b 2734 - djm@cvs.openbsd.org 2005/09/19 23:31:31
2735 [ssh.1]
2736 spelling nit from stevesk@
0d3d1077 2737 - djm@cvs.openbsd.org 2005/09/21 23:36:54
2738 [sshd_config.5]
2739 aquire -> acquire, from stevesk@
ae25711b 2740 - djm@cvs.openbsd.org 2005/09/21 23:37:11
2741 [sshd.c]
2742 change label at markus@'s request
8f921a4a 2743 - jaredy@cvs.openbsd.org 2005/09/30 20:34:26
2744 [ssh-keyscan.1]
2745 deploy .An -nosplit; ok jmc
d2130e1f 2746 - dtucker@cvs.openbsd.org 2005/10/03 07:44:42
2747 [canohost.c]
2748 Relocate check_ip_options call to prevent logging of garbage for
2749 connections with IP options set. bz#1092 from David Leonard,
2750 "looks good" deraadt@
1172d361 2751 - (dtucker) [regress/README.regress] Bug #989: Document limitation that scp
2752 is required in the system path for the multiplex test to work.
59e5aff5 2753
bfd17430 275420050930
2755 - (dtucker) [openbsd-compat/openbsd-compat.h] Bug #1096: Add prototype
2756 for strtoll. Patch from o.flebbe at science-computing.de.
cfb60d3a 2757 - (dtucker) [monitor.c] Bug #1087: Send loginmsg to preauth privsep
2758 child during PAM account check without clearing it. This restores the
2759 post-login warnings such as LDAP password expiry. Patch from Tomas Mraz
2760 with help from several others.
bfd17430 2761
140da888 276220050929
2763 - (dtucker) [monitor_wrap.c] Remove duplicate definition of loginmsg
2764 introduced during sync.
2765
4ebacf50 276620050928
2767 - (dtucker) [entropy.c] Use u_char for receiving RNG seed for consistency.
cafa6a80 2768 - (dtucker) [auth-pam.c] Bug #1028: send final non-query messages from
2769 PAM via keyboard-interactive. Patch tested by the folks at Vintela.
4ebacf50 2770
759ab0d9 277120050927
2772 - (dtucker) [entropy.c] Remove unnecessary tests for getuid and geteuid
2773 calls, since they can't possibly fail. ok djm@
72f02ae7 2774 - (dtucker) [entropy.c entropy.h sshd.c] Pass RNG seed to the reexec'ed
2775 process when sshd relies on ssh-random-helper. Should result in faster
2776 logins on systems without a real random device or prngd. ok djm@
759ab0d9 2777
b6c37221 277820050924
2779 - (dtucker) [auth2.c] Move start_pam() calls out of if-else block to remove
2780 duplicate call. ok djm@
2781
bb116c8e 278220050922
2783 - (dtucker) [configure.ac] Use -R linker flag for libedit too; patch from
2784 skeleten at shillest.net.
e47fb473 2785 - (dtucker) [configure.ac] Fix help for --with-opensc; patch from skeleten at
2786 shillest.net.
bb116c8e 2787
3466e002 278820050919
2789 - (tim) [aclocal.m4 configure.ac] Delete acconfig.h and add templates to
2790 AC_DEFINE and AC_DEFINE_UNQUOTED to quiet autoconf 2.59 warning messages.
f666dcfa 2791 ok dtucker@
3466e002 2792
f5555364 279320050912
2794 - (tim) [configure.ac] Bug 1078. Fix --without-kerberos5. Reported by
2795 Mike Frysinger.
2796
d2a3abef 279720050908
2798 - (tim) [defines.h openbsd-compat/port-uw.c] Add long password support to
2799 OpenServer 6 and add osr5bigcrypt support so when someone migrates
2800 passwords between UnixWare and OpenServer they will still work. OK dtucker@
2801
0b202697 2802$Id$
This page took 0.904979 seconds and 5 git commands to generate.