Make sq routines check the result of malloc. (Mostly for dbck.)

sq_save_data, etc now return 1 on success and 0 on failure. (This is a
backwards-compatible change: they were implicitly returning int values
already, but those values weren't being checked anywhere).

diff --git a/lib/sq.c b/lib/sq.c
index 952f5c876ec3bb2e1d9ab7c32544b2ff0f47fb61..a9e98856066537b74a3b2f6575ac8705b560132a 100644 (file)
--- a/lib/sq.c
+++ b/lib/sq.c
@@ -19,12 +19,14 @@ sq_create()
     register struct save_queue *sq;
 
     sq = (struct save_queue *)malloc(sizeof (struct save_queue));
+    if (!sq) return sq;
     sq->q_next = sq;
     sq->q_prev = sq;
     sq->q_lastget = 0;
     return(sq);
 }
 
+int
 sq_save_data(sq, data)
     register struct save_queue *sq;
     char *data;
@@ -32,13 +34,16 @@ sq_save_data(sq, data)
     register struct save_queue *q;
 
     q = (struct save_queue *)malloc(sizeof (struct save_queue));
+    if (!q) return 0;
     q->q_next = sq;
     q->q_prev = sq->q_prev;
     sq->q_prev->q_next = q;
     sq->q_prev = q;
     q->q_data = data;
+    return 1;
 }
 
+int
 sq_save_args(argc, argv, sq)
     register struct save_queue *sq;
     register int argc;
@@ -49,15 +54,22 @@ sq_save_args(argc, argv, sq)
     register int n;
 
     argv_copy = (char **)malloc(argc * sizeof (char *));
+    if (!argv_copy) return 0;
     for (i = 0; i < argc; i++) {
        n = strlen(argv[i]) + 1;
        argv_copy[i] = (char *)malloc(n);
+       if (!argv_copy[i]) {
+         for(i--; i>=0; i--) free(argv_copy[i]);
+         free((char **)argv_copy);
+         return 0;
+       }
        memcpy(argv_copy[i], argv[i], n);
     }
 
-    sq_save_data(sq, (char *)argv_copy);
+    return sq_save_data(sq, (char *)argv_copy);
 }
 
+int
 sq_save_unique_data(sq, data)
     register struct save_queue *sq;
     char *data;
@@ -67,9 +79,10 @@ sq_save_unique_data(sq, data)
     for (q = sq->q_next; q != sq; q = q->q_next)
        if (q->q_data == data) return;
 
-    sq_save_data(sq, data);
+    return sq_save_data(sq, data);
 }
 
+int
 sq_save_unique_string(sq, data)
     register struct save_queue *sq;
     char *data;
@@ -79,9 +92,10 @@ sq_save_unique_string(sq, data)
     for (q = sq->q_next; q != sq; q = q->q_next)
        if (!strcmp(q->q_data, data)) return;
 
-    sq_save_data(sq, data);
+    return sq_save_data(sq, data);
 }
 
+int
 sq_get_data(sq, data)
     register struct save_queue *sq;
     register char **data;
@@ -97,6 +111,7 @@ sq_get_data(sq, data)
     return(1);
 }
 
+int
 sq_remove_data(sq, data)
     register struct save_queue *sq;
     register char **data;