Found possible reason why full membership edits weren't happening;

moira_disconnect might be doing the final edit_groups and in turn call
moira_disconnect again, thus possibly freeing the same memory twice.

diff --git a/incremental/afs.c b/incremental/afs.c
index 7654288b5a4133ccf008fa77e73f208a1d62b4b6..6621637d66e8da6b1869fcefdea2ba789680a9dc 100644 (file)
--- a/incremental/afs.c
+++ b/incremental/afs.c
@@ -556,7 +556,13 @@ edit_group(op, group, type, member)
                               "Error contacting Moira server to lookup user %s: %s",
                               member, error_message(code));
            }
-           moira_disconnect();
+
+           /* We don't use moira_disconnect()
+            * because we may already be in the routine.
+            */
+           mr_disconnect();
+           mr_connections--;
+
            if (!code && ustate!=1 && ustate!=2) return; /* inactive user */
            code = PRNOENT;
        }