From: Anders Kaseorg <andersk@mit.edu>
Date: Tue, 30 Mar 2010 01:47:34 +0000 (-0400)
Subject: Unicode support.
X-Git-Url: http://andersk.mit.edu/gitweb/zcommit.git/commitdiff_plain/81dced7b3b173803b696ff58ce49efb38f60ef35

Unicode support.

The previous code would blow up on all non-ASCII authors, commit
messages, or arguments.  We can eliminate character set discrimination
in our lifetimes, if we all just come together.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
---

diff --git a/zcommit.py b/zcommit.py
index 6c66b50..1f37853 100755
--- a/zcommit.py
+++ b/zcommit.py
@@ -35,7 +35,7 @@ msg: %(msg)s""" % {'sender' : sender,
                    'msg' : msg})
     cmd = [ZWRITE, '-S', sender, '-c', klass, '-i', instance,
            '-s', zsig, '-d', '-m', msg]
-    subprocess.check_call([str(p) for p in cmd])
+    subprocess.check_call([p.encode('utf-8') for p in cmd])
 
 class Application(object):
     @cherrypy.expose
@@ -91,7 +91,7 @@ any of the following optional key/value parameters:
                 raise cherrypy.HTTPError(400, 'Invalid submission URL')
             logger.debug('Passed validation')
             for i in xrange(0, len(args), 2):
-                opts[args[i]] = args[i + 1]
+                opts[args[i]] = unicode(args[i + 1], 'utf-8', 'replace')
             logger.debug('Set opts')
             if 'class' not in opts:
                 raise cherrypy.HTTPError(400, 'Must specify a zephyr class name')