X-Git-Url: http://andersk.mit.edu/gitweb/zcommit.git/blobdiff_plain/2a04f5aef731fea2f368374ff3a0db318bc58a9b..HEAD:/zcommit.py
diff --git a/zcommit.py b/zcommit.py
index 6756e3e..ed11afb 100755
--- a/zcommit.py
+++ b/zcommit.py
@@ -8,6 +8,7 @@ import os
import subprocess
import sys
import traceback
+import dateutil.parser
HERE = os.path.abspath(os.path.dirname(__file__))
ZWRITE = os.path.join(HERE, 'bin', 'zsend')
@@ -35,7 +36,7 @@ msg: %(msg)s""" % {'sender' : sender,
'msg' : msg})
cmd = [ZWRITE, '-S', sender, '-c', klass, '-i', instance,
'-s', zsig, '-d', '-m', msg]
- subprocess.check_call(cmd)
+ subprocess.check_call([p.encode('utf-8') for p in cmd])
class Application(object):
@cherrypy.expose
@@ -59,7 +60,9 @@ is parsed as having type github, class zcommit, and
instance commit. Using this information, zcommit figures out
how to form a useful message which is then sends as a zephyr.
-
Github
+ Types
+
+ Github
Set your POST-back URL to
http://zcommit.mit.edu/github/class/$classname, followed by
@@ -67,7 +70,7 @@ any of the following optional key/value parameters:
- /instance/$instance
-- /zsig/$zsig
+- /zsig/$zsig (sets the prefix of the zsig; the postfix is always the branch name)
- /sender/$sender
"""
@@ -89,7 +92,7 @@ any of the following optional key/value parameters:
raise cherrypy.HTTPError(400, 'Invalid submission URL')
logger.debug('Passed validation')
for i in xrange(0, len(args), 2):
- opts[args[i]] = args[i + 1]
+ opts[args[i]] = unicode(args[i + 1], 'utf-8', 'replace')
logger.debug('Set opts')
if 'class' not in opts:
raise cherrypy.HTTPError(400, 'Must specify a zephyr class name')
@@ -103,26 +106,30 @@ any of the following optional key/value parameters:
zsig = '%s: %s' % (opts['zsig'], zsig)
sender = opts.get('sender', 'daemon.zcommit')
logger.debug('Set zsig')
- for c in reversed(payload['commits']):
+ for c in payload['commits']:
inst = opts.get('instance', c['id'][:8])
actions = []
if c.get('added'):
- actions.append('Added: %s\n' % '\n '.join(c['added']))
+ actions.extend(' A %s\n' % f for f in c['added'])
if c.get('removed'):
- actions.append('Removed: %s\n' % '\n '.join(c['removed']))
+ actions.extend(' D %s\n' % f for f in c['removed'])
if c.get('modified'):
- actions.append('Modified: %s\n' % '\n '.join(c['modified']))
+ actions.extend(' M %s\n' % f for f in c['modified'])
if not actions:
- actions.append('Something weird happened... could not figure out what action to take')
+ actions.append('Did not add/remove/modify any nonempty files.')
info = {'name' : c['author']['name'],
'email' : c['author']['email'],
'message' : c['message'],
- 'timestamp' : c['timestamp'],
- 'actions' : '--\n'.join(actions)}
+ 'timestamp' : dateutil.parser.parse(c['timestamp']).strftime('%F %T %z'),
+ 'actions' : ''.join(actions),
+ 'url' : c['url']}
- msg = """%(name)s <%(email)s> (%(timestamp)s)
-> %(message)s
---
+ msg = """%(url)s
+Author: %(name)s <%(email)s>
+Date: %(timestamp)s
+
+%(message)s
+---
%(actions)s""" % info
zephyr(sender, opts['class'], inst, zsig, msg)
msg = 'Thanks for posting!'