X-Git-Url: http://andersk.mit.edu/gitweb/splint.git/blobdiff_plain/d30bc0c7e3640d3e4f5dc3214b3668b8e4341f1a..0f9b7373240aec911db59be859ad5484b0e6a6a7:/src/constraintExpr.c diff --git a/src/constraintExpr.c b/src/constraintExpr.c index ec17896..c40a31f 100644 --- a/src/constraintExpr.c +++ b/src/constraintExpr.c @@ -1,10 +1,34 @@ +/* +** Splint - annotation-assisted static program checker +** Copyright (C) 1994-2002 University of Virginia, +** Massachusetts Institute of Technology +** +** This program is free software; you can redistribute it and/or modify it +** under the terms of the GNU General Public License as published by the +** Free Software Foundation; either version 2 of the License, or (at your +** option) any later version. +** +** This program is distributed in the hope that it will be useful, but +** WITHOUT ANY WARRANTY; without even the implied warranty of +** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +** General Public License for more details. +** +** The GNU General Public License is available from http://www.gnu.org/ or +** the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, +** MA 02111-1307, USA. +** +** For information on splint: info@splint.org +** To report a bug: splint-bug@splint.org +** For more information: http://www.splint.org +*/ + /* ** constraintExpr.c */ -//#define DEBUGPRINT 1 +/* #define DEBUGPRINT 1 */ -# include "lclintMacros.nf" +# include "splintMacros.nf" # include "basic.h" # include "cgrammar.h" # include "cgrammar_tokens.h" @@ -12,19 +36,24 @@ # include "exprChecks.h" # include "exprNodeSList.h" -//# include "constraintExpr.h" - - /*@-czechfcns@*/ +/*@access exprNode@*/ /* !!! NO! Don't do this recklessly! */ +/*@-nullderef@*/ /* !!! DRL needs to fix this code! */ +/*@-nullstate@*/ /* !!! DRL needs to fix this code! */ +/*@-temptrans@*/ /* !!! DRL needs to fix this code! */ -/*@access exprNode constraintExpr@*/ - +static ctype constraintExpr_getOrigType (constraintExpr p_e); +static bool constraintExpr_hasTypeChange(constraintExpr p_e) /*@*/; static /*@only@*/ constraintExpr constraintExpr_makeBinaryOpConstraintExprIntLiteral (/*@only@*/constraintExpr p_expr, int p_literal); +/*@only@*/ static constraintExpr +doSRefFixInvarConstraintTerm (/*@only@*/ constraintExpr p_e, + sRef p_s, ctype p_ct); + /*@only@*/ static constraintExpr doSRefFixConstraintParamTerm (/*@only@*/ constraintExpr p_e, /*@temp@*/ /*@observer@*/ exprNodeList p_arglist) /*@modifies p_e@*/; @@ -32,10 +61,14 @@ static /*@only@*/ constraintExpr doFixResultTerm (/*@only@*/ constraintExpr p_e, /*@exposed@*/ exprNode p_fcnCall) /*@modifies p_e@*/; +static bool constraintExpr_canGetCType (constraintExpr p_e) /*@*/; + +static ctype constraintExpr_getCType (constraintExpr p_e); - /*@special@*/ static constraintExpr constraintExpr_makeBinaryOp (void) ; /// @allocates result->data @ @sets result->kind @; +static /*@only@*/ constraintExpr constraintExpr_adjustMaxSetForCast(/*@only@*/ constraintExpr p_e, ctype p_ct); -//constraintExpr constraintExpr_makeMaxSetConstraintExpr (constraintExpr c); +/*@special@*/ static constraintExpr constraintExpr_makeBinaryOp (void) + /* @allocates result->data @ @sets result->kind @ */ ; void constraintExpr_free (/*@only@*/ constraintExpr expr) { @@ -145,22 +178,20 @@ static bool isZeroBinaryOp (constraintExpr expr) tempOp = constraintExprData_binaryExprGetOp (expr2->data); - if (op == PLUS) + if (op == BINARYOP_PLUS) op = tempOp; - else if (op == MINUS) + else if (op == BINARYOP_MINUS) { - if (tempOp == PLUS) - op = MINUS; - else if (tempOp == MINUS) - op = PLUS; + if (tempOp == BINARYOP_PLUS) + op = BINARYOP_MINUS; + else if (tempOp == BINARYOP_MINUS) + op = BINARYOP_PLUS; else BADEXIT; } else BADEXIT; - /*@i834@*/ constraintExpr_free(expr2); - expr->data = constraintExprData_binaryExprSetExpr2(expr->data, temp); expr->data = constraintExprData_binaryExprSetOp(expr->data, op); @@ -187,15 +218,16 @@ static bool isZeroBinaryOp (constraintExpr expr) *propagate = FALSE; *literal = 0; + llassert (expr != NULL); - // we simplify unaryExpr else where + /* we simplify unaryExpr elsewhere */ if (expr->kind != binaryexpr) return expr; op = constraintExprData_binaryExprGetOp (expr->data); - DPRINTF( (message("constraintExpr_propagateConstants: binaryexpr: %s", constraintExpr_unparse(expr) ) ) ); + DPRINTF((message("constraintExpr_propagateConstants: binaryexpr: %s", constraintExpr_unparse(expr) ) ) ); expr = removeZero(expr); @@ -208,11 +240,15 @@ static bool isZeroBinaryOp (constraintExpr expr) expr1 = constraintExpr_propagateConstants (expr1, &propagate1, &literal1); expr2 = constraintExpr_propagateConstants (expr2, &propagate2, &literal2); + expr1 = removeZero(expr1); + expr2 = removeZero(expr2); + + *propagate = propagate1 || propagate2; - if (op == PLUS) + if (op == BINARYOP_PLUS) *literal = literal1 + literal2; - else if (op == MINUS) + else if (op == BINARYOP_MINUS) *literal = literal1 - literal2; else BADEXIT; @@ -229,10 +265,10 @@ static bool isZeroBinaryOp (constraintExpr expr) constraintExpr_free (expr1); constraintExpr_free (expr2); - if (op == PLUS ) - return (constraintExpr_makeIntLiteral ( (t1+t2) )); - else if (op == MINUS) - return (constraintExpr_makeIntLiteral ( (t1-t2) )); + if (op == BINARYOP_PLUS ) + return (constraintExpr_makeIntLiteral ((t1+t2) )); + else if (op == BINARYOP_MINUS) + return (constraintExpr_makeIntLiteral ((t1-t2) )); else BADEXIT; } @@ -244,19 +280,20 @@ static bool isZeroBinaryOp (constraintExpr expr) *literal += constraintExpr_getValue (expr1); - if (op == PLUS) + if (op == BINARYOP_PLUS) { constraintExpr_free(expr1); constraintExpr_free(expr); return expr2; } - else if (op == MINUS) + else if (op == BINARYOP_MINUS) { + constraintExpr temp; /* this is an ugly kludge to deal with not having a unary minus operation...*/ - + temp = constraintExpr_makeIntLiteral (0); temp = constraintExpr_makeSubtractExpr (temp, expr2); @@ -275,9 +312,9 @@ static bool isZeroBinaryOp (constraintExpr expr) { *propagate = TRUE; - if ( op == PLUS ) + if ( op == BINARYOP_PLUS ) *literal += constraintExpr_getValue (expr2); - else if (op == MINUS) + else if (op == BINARYOP_MINUS) *literal -= constraintExpr_getValue (expr2); else BADEXIT; @@ -288,7 +325,7 @@ static bool isZeroBinaryOp (constraintExpr expr) return expr1; } - DPRINTF( (message("constraintExpr_propagateConstants returning: %s", constraintExpr_unparse(expr) ) ) ); + DPRINTF((message("constraintExpr_propagateConstants returning: %s", constraintExpr_unparse(expr) ) ) ); expr->data = constraintExprData_binaryExprSetExpr1 (expr->data, expr1); expr->data = constraintExprData_binaryExprSetExpr2 (expr->data, expr2); @@ -302,7 +339,7 @@ static bool isZeroBinaryOp (constraintExpr expr) bool propagate; int literal; - DPRINTF ( (message ("Before combine %s", constraintExpr_unparse(expr) ) ) ); + DPRINTF ((message ("Before combine %s", constraintExpr_unparse(expr) ) ) ); expr = constraintExpr_propagateConstants (expr, &propagate, &literal); @@ -316,17 +353,19 @@ static bool isZeroBinaryOp (constraintExpr expr) expr = ret; } } - DPRINTF ( (message ("After combine %s", constraintExpr_unparse(expr) ) ) ); + DPRINTF ((message ("After combine %s", constraintExpr_unparse(expr) ) ) ); return expr; } /*@special@*/ -static constraintExpr constraintExpr_alloc (void) /*@post:isnull result->data@*/ +static /*@notnull@*/ constraintExpr constraintExpr_alloc (void) /*@post:isnull result->data@*/ { constraintExpr ret; ret = dmalloc (sizeof (*ret) ); ret->kind = term; ret->data = NULL; + ret->ct = FALSE; + ret->origType = ctype_undefined; return ret; } @@ -355,10 +394,12 @@ static constraintExpr constraintExpr_alloc (void) /*@post:isnull result->data@*/ constraintExpr constraintExpr_copy (constraintExpr expr) { constraintExpr ret; - ret = constraintExpr_alloc(); + ret = constraintExpr_alloc (); ret->kind = expr->kind; ret->data = copyExprData (expr->data, expr->kind); + ret->ct = expr->ct; + ret->origType = expr->origType; return ret; } @@ -372,6 +413,9 @@ constraintExpr constraintExpr_copy (constraintExpr expr) ret->data = dmalloc (sizeof *(ret->data) ); t = constraintTerm_makeExprNode (e); ret->data = constraintExprData_termSetTerm (ret->data, t); + ret->ct = FALSE; + ret->origType = ctype_undefined; + return ret; } @@ -383,7 +427,6 @@ constraintExpr constraintExpr_makeExprNode (exprNode e) exprNode t, t1, t2; lltok tok; - llassert (e != NULL); data = e->edata; @@ -419,10 +462,43 @@ constraintExpr constraintExpr_makeExprNode (exprNode e) ce2 = constraintExpr_makeExprNode (t2); ret = constraintExpr_parseMakeBinaryOp (ce1, tok, ce2); } - else + + + /*@i333*/ + /* uncomment this block to activate the cheesy heuristic + for handling sizeof expressions + + / * + drl 8-11-001 + + We handle expressions containing sizeof with the rule + (sizeof type ) * Expr = Expr + + This is the total wronge way to do this but... + it may be better than nothing + * / + + + + else if (lltok_isMult(tok) ) { - ret = oldconstraintExpr_makeTermExprNode (e); + if ((t1->kind == XPR_SIZEOF) || (t1->kind == XPR_SIZEOFT) ) + { + ret = constraintExpr_makeExprNode(t2); + } + else if ((t2->kind == XPR_SIZEOF) || (t2->kind == XPR_SIZEOFT) ) + { + ret = constraintExpr_makeExprNode(t1); + } + else + { + ret = oldconstraintExpr_makeTermExprNode (e); + } } + */ + else + ret = oldconstraintExpr_makeTermExprNode (e); + break; case XPR_PARENS: t = exprData_getUopNode (data); @@ -459,7 +535,7 @@ constraintExpr constraintExpr_makeExprNode (exprNode e) case XPR_COMMA: t = exprData_getPairA(data); ret = constraintExpr_makeExprNode(t); - /*@i3434*/ /*I'm not sure if this is right. I'm adding a break to quite LCLint*/ + /*@i3434*/ /* drl: I'm not sure if this is right. I'm adding a break to quiet Splint */ break; default: ret = oldconstraintExpr_makeTermExprNode (e); @@ -468,9 +544,9 @@ constraintExpr constraintExpr_makeExprNode (exprNode e) return ret; } -/*@only@*/ constraintExpr constraintExpr_makeTermExprNode (/*@exposed@*/ exprNode e) +/*@only@*/ constraintExpr constraintExpr_makeTermExprNode (/*@exposed@*/ exprNode e) { - return oldconstraintExpr_makeTermExprNode(e); //constraintExpr_makeExprNode (e); + return oldconstraintExpr_makeTermExprNode(e); } static constraintExpr constraintExpr_makeTerm (/*@only@*/ constraintTerm t) @@ -480,7 +556,10 @@ static constraintExpr constraintExpr_makeTerm (/*@only@*/ constraintTerm t) ret = constraintExpr_alloc(); ret->kind = term; ret->data = dmalloc (sizeof *(ret->data) ); + ret->data->term = NULL; ret->data = constraintExprData_termSetTerm (ret->data, t); + ret->ct = FALSE; + ret->origType = ctype_undefined; return ret; } @@ -494,6 +573,10 @@ constraintExpr constraintExpr_makeTermsRef (/*@temp@*/ sRef s) ret->data = dmalloc (sizeof *(ret->data) ); t = constraintTerm_makesRef (s); ret->data = constraintExprData_termSetTerm (ret->data, t); + + ret->ct = FALSE; + ret->origType = ctype_undefined; + return ret; } @@ -503,6 +586,7 @@ constraintExpr constraintExpr_makeTermsRef (/*@temp@*/ sRef s) ret = constraintExpr_alloc(); ret->kind = unaryExpr; ret->data = dmalloc ( sizeof *(ret->data) ); + ret->data->unaryOp.expr = constraintExpr_undefined; return ret; } @@ -513,11 +597,11 @@ constraintExpr constraintExpr_makeTermsRef (/*@temp@*/ sRef s) /*@-uniondef@*/ /*@-compdef@*/ - ret->data = constraintExprData_unaryExprSetExpr (ret->data, cexpr); - ret->data = constraintExprData_unaryExprSetOp (ret->data, UNARYOP_UNDEFINED); - + ret->data = constraintExprData_unaryExprSetExpr (ret->data, cexpr); + ret->data = constraintExprData_unaryExprSetOp (ret->data, UNARYOP_UNDEFINED); + return ret; - + /*@=compdef@*/ /*@=uniondef@*/ } @@ -531,6 +615,9 @@ constraintExpr constraintExpr_makeTermsRef (/*@temp@*/ sRef s) ret->data = constraintExprData_unaryExprSetExpr (ret->data, cexpr); ret->data = constraintExprData_unaryExprSetOp (ret->data, Op); + ret->ct = FALSE; + ret->origType = ctype_undefined; + return ret; } @@ -586,7 +673,7 @@ constraintExpr constraintExpr_parseMakeUnaryOp (lltok op, constraintExpr cexpr) constraintExpr ret; ret = constraintExpr_makeUnaryOpConstraintExpr ( cexpr); - switch (op.tok) + switch (lltok_getTok (op)) { case QMAXSET: ret->data = constraintExprData_unaryExprSetOp (ret->data, MAXSET); @@ -621,6 +708,7 @@ constraintExpr constraintExpr_makeMaxReadExpr (exprNode expr) return ret; } +# if 0 /*@only@*/ /*@unused@*/ static constraintExpr constraintExpr_makeMinSetExpr (/*@exposed@*/ exprNode expr) { @@ -638,7 +726,7 @@ constraintExpr constraintExpr_makeMaxReadExpr (exprNode expr) ret->data = constraintExprData_unaryExprSetOp (ret->data, MINREAD); return ret; } - +# endif /*@only@*/ constraintExpr constraintExpr_makeValueExpr (/*@exposed@*/ exprNode expr) @@ -658,6 +746,10 @@ constraintExpr constraintExpr_makeIntLiteral (long i) ret->data = dmalloc (sizeof *(ret->data) ); t = constraintTerm_makeIntLiteral (i); ret->data = constraintExprData_termSetTerm (ret->data, t); + + ret->ct = FALSE; + ret->origType = ctype_undefined; + return ret; } @@ -676,7 +768,10 @@ constraintExpr constraintExpr_makeValueInt (int i) ret = constraintExpr_alloc(); ret->kind = binaryexpr; ret->data = dmalloc ( sizeof *(ret->data) ); - // ret->data = constraintExprData_binaryExprSetOp (ret->data, BINARYOP_UNDEFINED); + + ret->data->binaryOp.expr1 = constraintExpr_undefined; + ret->data->binaryOp.expr2 = constraintExpr_undefined; + return ret; } @@ -690,6 +785,10 @@ static /*@only@*/ constraintExpr constraintExpr_makeBinaryOpConstraintExpr (/*@o ret->data = constraintExprData_binaryExprSetExpr1 (ret->data, expr1); ret->data = constraintExprData_binaryExprSetExpr2 (ret->data, expr2); ret->data = constraintExprData_binaryExprSetOp (ret->data, BINARYOP_UNDEFINED); + + ret->ct = FALSE; + ret->origType = ctype_undefined; + return ret; } @@ -698,17 +797,24 @@ constraintExpr constraintExpr_parseMakeBinaryOp (/*@only@*/ constraintExpr expr1 { constraintExpr ret; ret = constraintExpr_makeBinaryOpConstraintExpr (expr1, expr2); - if (op.tok == TPLUS) - ret->data = constraintExprData_binaryExprSetOp(ret->data, PLUS); - else if (op.tok == TMINUS) - ret->data = constraintExprData_binaryExprSetOp(ret->data, MINUS); - else - { - llassert(FALSE); - } + + if (lltok_getTok (op) == TPLUS) + { + ret->data = constraintExprData_binaryExprSetOp(ret->data, BINARYOP_PLUS); + } + else if (lltok_getTok (op) == TMINUS) + { + ret->data = constraintExprData_binaryExprSetOp(ret->data, BINARYOP_MINUS); + } + else + { + llassert (FALSE); + } + return ret; } +# if 0 /*@only@*/ /*@unused@*/ static constraintExpr constraintExpr_makeBinaryOpExprNode (/*@exposed@*/ exprNode expr1, /*@exposed@*/ exprNode expr2) { @@ -719,6 +825,7 @@ constraintExpr constraintExpr_parseMakeBinaryOp (/*@only@*/ constraintExpr expr1 ret = constraintExpr_makeBinaryOpConstraintExpr(sub1, sub2); return ret; } +# endif static /*@only@*/ constraintExpr constraintExpr_makeBinaryOpConstraintExprIntLiteral (/*@only@*/ constraintExpr expr, int literal) @@ -728,7 +835,7 @@ constraintExpr constraintExpr_makeBinaryOpConstraintExprIntLiteral (/*@only@*/ c constExpr = constraintExpr_makeIntLiteral (literal); ret = constraintExpr_makeBinaryOpConstraintExpr (expr, constExpr); - ret->data = constraintExprData_binaryExprSetOp(ret->data, PLUS); + ret->data = constraintExprData_binaryExprSetOp(ret->data, BINARYOP_PLUS); return ret; } @@ -740,7 +847,7 @@ constraintExpr constraintExpr_makeDecConstraintExpr (/*@only@*/constraintExpr ex inc = constraintExpr_makeIntLiteral (1); ret = constraintExpr_makeBinaryOpConstraintExpr (expr, inc); - ret->data = constraintExprData_binaryExprSetOp(ret->data, MINUS); + ret->data = constraintExprData_binaryExprSetOp(ret->data, BINARYOP_MINUS); return ret; } @@ -749,10 +856,10 @@ constraintExpr constraintExpr_makeDecConstraintExpr (/*@only@*/constraintExpr ex { constraintExpr ret; - DPRINTF ( (message ("Making subtract expression") ) ); + DPRINTF ((message ("Making subtract expression") ) ); ret = constraintExpr_makeBinaryOpConstraintExpr (expr, addent); - ret->data = constraintExprData_binaryExprSetOp (ret->data, MINUS); + ret->data = constraintExprData_binaryExprSetOp (ret->data, BINARYOP_MINUS); return ret; } @@ -763,10 +870,10 @@ constraintExpr addent) { constraintExpr ret; - DPRINTF ( (message ("Doing addTerm simplification") ) ); + DPRINTF ((message ("Doing addTerm simplification") ) ); ret = constraintExpr_makeBinaryOpConstraintExpr (expr, addent); - ret->data = constraintExprData_binaryExprSetOp (ret->data, PLUS); + ret->data = constraintExprData_binaryExprSetOp (ret->data, BINARYOP_PLUS); return ret; } @@ -779,7 +886,7 @@ constraintExpr constraintExpr_makeIncConstraintExpr (/*@only@*/ constraintExpr e inc = constraintExpr_makeIntLiteral (1); ret = constraintExpr_makeBinaryOpConstraintExpr (expr, inc); - ret->data = constraintExprData_binaryExprSetOp(ret->data, PLUS); + ret->data = constraintExprData_binaryExprSetOp(ret->data, BINARYOP_PLUS); return ret; } @@ -809,9 +916,9 @@ static cstring constraintExprBinaryOpKind_print (constraintExprBinaryOpKind op) switch (op) { - case PLUS: + case BINARYOP_PLUS: return message("+"); - case MINUS: + case BINARYOP_MINUS: return message("-"); default: @@ -967,15 +1074,55 @@ bool constraintExpr_search (/*@observer@*/ constraintExpr c, /*@observer@*/ cons { constraintExprKind kind; constraintExpr temp; + constraintExpr ret; if ( constraintExpr_similar (c, old) ) { + + ctype newType, cType; + + + ret = constraintExpr_copy (newExpr); DPRINTF((message ("Replacing %s with %s", constraintExpr_unparse(old), constraintExpr_unparse(newExpr) ))); + + if (constraintExpr_canGetCType(c) && constraintExpr_canGetCType(newExpr) ) + { + cType = constraintExpr_getCType(c); + newType = constraintExpr_getCType(newExpr); + + if (ctype_match(cType,newType) ) + { + DPRINTF(( message("constraintExpr_searchandreplace: replacing " + " %s with type %s with %s with type %s", + constraintExpr_print(c), ctype_unparse(cType), + constraintExpr_print(newExpr), ctype_unparse(newType) + ) + )); + + ret->ct = TRUE; + ret->origType = cType; + } + } + + if (constraintExpr_hasMaxSet(c) ) + { + if (constraintExpr_hasTypeChange(c)) + { + DPRINTF(( message("constraintExpr_searchandreplace: encountered " + "MaxSet with changed type %s ", + constraintExpr_print(c) ) + )); + + /*fix this with a conversation */ + ret = constraintExpr_adjustMaxSetForCast(ret, constraintExpr_getOrigType(c)); + } + } constraintExpr_free(c); - return constraintExpr_copy (newExpr); + + return ret; } kind = c->kind; @@ -1006,7 +1153,6 @@ bool constraintExpr_search (/*@observer@*/ constraintExpr c, /*@observer@*/ cons llassert(FALSE); } return c; - } static constraintExpr constraintExpr_simplifyChildren (/*@returned@*/ constraintExpr c) @@ -1104,7 +1250,7 @@ static /*@only@*/ constraintExpr constraintExpr_simplifybinaryExpr (/*@only@*/co else { op = constraintExprData_binaryExprGetOp (c->data); - if (op == MINUS) + if (op == BINARYOP_MINUS) if (constraintExpr_similar(e1, e2) ) { constraintExpr_free(c); @@ -1140,23 +1286,23 @@ static /*@only@*/ constraintExpr constraintExpr_simplifybinaryExpr (/*@only@*/co expr1 = constraintExpr_copy(expr1); expr2 = constraintExpr_copy(expr2); -//drl possible problem : warning make sure this works - - lexpr->kind = expr1->kind; - free (lexpr->data); - - lexpr->data = copyExprData (expr1->data, expr1->kind); - constraintExpr_free(expr1); - - if (op == PLUS) - expr = constraintExpr_makeSubtractExpr (expr, expr2); - else if (op == MINUS) - expr = constraintExpr_makeAddExpr (expr, expr2); - else - BADEXIT; - - - return expr; + /* drl possible problem : warning make sure this works */ + + lexpr->kind = expr1->kind; + sfree (lexpr->data); + + lexpr->data = copyExprData (expr1->data, expr1->kind); + constraintExpr_free(expr1); + + if (op == BINARYOP_PLUS) + expr = constraintExpr_makeSubtractExpr (expr, expr2); + else if (op == BINARYOP_MINUS) + expr = constraintExpr_makeAddExpr (expr, expr2); + else + BADEXIT; + + + return expr; /* #warning this needs to be checked @@ -1175,15 +1321,15 @@ static /*@only@*/ constraintExpr constraintExpr_simplifyunaryExpr (/*@only@*/ co DPRINTF ((message ("Doing constraintExpr_simplifyunaryExpr:%s", constraintExpr_unparse (c) ) ) ); - if ( (constraintExprData_unaryExprGetOp (c->data) != MAXSET) && + if ((constraintExprData_unaryExprGetOp (c->data) != MAXSET) && (constraintExprData_unaryExprGetOp (c->data) != MAXREAD) ) { return c; } - // pattern mxr ( var + const) = mxr(var) - const exp = constraintExprData_unaryExprGetExpr (c->data); - + exp = constraintExpr_copy(exp); + if (exp->kind == term) { constraintTerm cterm; @@ -1201,7 +1347,10 @@ static /*@only@*/ constraintExpr constraintExpr_simplifyunaryExpr (/*@only@*/ co temp = constraintExpr_makeIntLiteral ((int)strlen (cstring_toCharsSafe(val) ) ); cstring_free(val); constraintExpr_free(c); + constraintExpr_free(exp); + return temp; + } if (constraintExprData_unaryExprGetOp (c->data) == MAXREAD) { @@ -1210,15 +1359,18 @@ static /*@only@*/ constraintExpr constraintExpr_simplifyunaryExpr (/*@only@*/ co temp = constraintExpr_makeIntLiteral ((int)strlen (cstring_toCharsSafe(val) ) ); cstring_free(val); constraintExpr_free(c); + constraintExpr_free(exp); + return temp; } BADEXIT; } - // slight Kludge to hanlde var [] = { , , }; - // type syntax I don't think this is sounds but it should be good - // enough. The C stanrad is very confusing about initialization - // -- DRL 7/25/01 + /* slight Kludge to hanlde var [] = { , , }; + ** type syntax I don't think this is sounds but it should be good + ** enough. The C stanrad is very confusing about initialization + ** -- DRL 7/25/01 + */ if (constraintTerm_isInitBlock(cterm) ) { @@ -1232,24 +1384,29 @@ static /*@only@*/ constraintExpr constraintExpr_simplifyunaryExpr (/*@only@*/ co constraintExpr_free(c); DPRINTF(( message("Changed too %q", constraintExpr_print(temp) ) )); + constraintExpr_free(exp); return temp; } + constraintExpr_free(exp); return c; } if (exp->kind != binaryexpr) - return c; - - if (constraintExprData_binaryExprGetOp (exp->data) == PLUS ) + { + constraintExpr_free(exp); + return c; + } + + if (constraintExprData_binaryExprGetOp (exp->data) == BINARYOP_PLUS ) { - // if (constraintExpr_canGetValue (constraintExprData_binaryExprGetExpr2 (exp->data) ) ) + /* if (constraintExpr_canGetValue (constraintExprData_binaryExprGetExpr2 (exp->data) ) ) */ { constraintExpr temp, temp2; - DPRINTF ( (message ("Doing fancy simplification") ) ); + DPRINTF ((message ("Doing fancy simplification") ) ); temp = constraintExprData_binaryExprGetExpr2 (exp->data); @@ -1263,11 +1420,13 @@ static /*@only@*/ constraintExpr constraintExpr_simplifyunaryExpr (/*@only@*/ co c = constraintExpr_makeSubtractExpr (c, temp); - DPRINTF ( (message ("Done fancy simplification:%s", constraintExpr_unparse (c) ) ) ); + DPRINTF ((message ("Done fancy simplification:%s", constraintExpr_unparse (c) ) ) ); } } - DPRINTF ( (message ("Done simplification:%s", constraintExpr_unparse (c) ) ) ); + DPRINTF ((message ("constraintExpr_simplifyUnaryExpr: Done simplification:%s", constraintExpr_unparse (c) ) ) ); + + constraintExpr_free(exp); return c; } @@ -1278,12 +1437,12 @@ static /*@only@*/ constraintExpr constraintExpr_simplifyunaryExpr (/*@only@*/ co constraintExpr ret; constraintTerm t; - DPRINTF ( (message ("Doing constraintExpr_simplify:%s", constraintExpr_unparse (c) ) ) ); + DPRINTF ((message ("Doing constraintExpr_simplify:%s", constraintExpr_unparse (c) ) ) ); /*@i22*/ - /*I think this is an LCLint bug */ + /* drl: I think this is an Splint bug */ ret = constraintExpr_copy(c); @@ -1316,7 +1475,7 @@ static /*@only@*/ constraintExpr constraintExpr_simplifyunaryExpr (/*@only@*/ co llassert(FALSE); } - DPRINTF ( (message ("constraintExpr_simplify returning :%s", constraintExpr_unparse (ret) ) ) ); + DPRINTF ((message ("constraintExpr_simplify returning :%s", constraintExpr_unparse (ret) ) ) ); return ret; } @@ -1334,22 +1493,42 @@ cstring constraintExpr_unparse (/*@temp@*/ /*@observer@*/ constraintExpr ex) /*@ switch (kind) { case term: - st = message ("(%q) ", constraintTerm_print (constraintExprData_termGetTerm (ex->data))); + + if (context_getFlag (FLG_PARENCONSTRAINT) ) + { + st = message ("(%q) ", constraintTerm_print (constraintExprData_termGetTerm (ex->data))); + } + else + { + st = message ("%q", constraintTerm_print (constraintExprData_termGetTerm (ex->data))); + } break; case unaryExpr: - st = message ("%q (%q)", - constraintExprUnaryOpKind_print (constraintExprData_unaryExprGetOp (ex->data) - ), + st = message ("%q(%q)", + constraintExprUnaryOpKind_print (constraintExprData_unaryExprGetOp (ex->data) ), constraintExpr_unparse (constraintExprData_unaryExprGetExpr (ex->data) ) ); break; case binaryexpr: - st = message ("(%q) %q (%q)", + if (context_getFlag (FLG_PARENCONSTRAINT) ) + { + st = message ("(%q) %q (%q)", constraintExpr_unparse (constraintExprData_binaryExprGetExpr1 (ex->data) ), constraintExprBinaryOpKind_print (constraintExprData_binaryExprGetOp (ex->data) ), constraintExpr_unparse (constraintExprData_binaryExprGetExpr2 (ex->data) ) ); + } + else + { + st = message ("%q %q %q", + constraintExpr_unparse (constraintExprData_binaryExprGetExpr1 (ex->data) ), + constraintExprBinaryOpKind_print (constraintExprData_binaryExprGetOp (ex->data) + ), + constraintExpr_unparse (constraintExprData_binaryExprGetExpr2 (ex->data) ) + ); + } + break; default: llassert(FALSE); @@ -1409,6 +1588,50 @@ constraintExpr constraintExpr_doSRefFixBaseParam (/*@returned@*/ constraintExpr return expr; } +/* +/ *@only@* / constraintExpr constraintExpr_doSRefFixInvarConstraint (/ *@only@* / constraintExpr expr, sRef s, ctype ct) +{ + constraintExprKind kind; + constraintExpr expr1, expr2; + constraintExprData data; + llassert (expr != NULL); + + data = expr->data; + + kind = expr->kind; + + switch (kind) + { + case term: + expr = doSRefFixInvarConstraintTerm (expr, s, ct); + break; + case unaryExpr: + expr1 = constraintExprData_unaryExprGetExpr (data); + expr1 = constraintExpr_copy(expr1); + expr1 = constraintExpr_doSRefFixInvarConstraint (expr1, s, ct); + data = constraintExprData_unaryExprSetExpr (data, expr1); + break; + case binaryexpr: + expr1 = constraintExprData_binaryExprGetExpr1 (data); + expr2 = constraintExprData_binaryExprGetExpr2 (data); + + expr1 = constraintExpr_copy(expr1); + expr2 = constraintExpr_copy(expr2); + + expr1 = constraintExpr_doSRefFixInvarConstraint (expr1, s, ct); + data = constraintExprData_binaryExprSetExpr1 (data, expr1); + expr2 = constraintExpr_doSRefFixInvarConstraint (expr2, s, ct); + data = constraintExprData_binaryExprSetExpr2 (data, expr2); + + break; + default: + llassert(FALSE); + data = NULL; + } + return expr; +} +*/ + /*@only@*/ constraintExpr constraintExpr_doSRefFixConstraintParam (/*@only@*/ constraintExpr expr, exprNodeList arglist) /*@modifies expr@*/ { constraintExprKind kind; @@ -1604,9 +1827,10 @@ doFixResultTerm (/*@only@*/ constraintExpr e, /*@exposed@*/ exprNode fcnCall) constraintTerm t; sRef s; /*maybe this should move to cosntraintExpr.c -drl7x 5/18/01*/ - /*@i22*/ constraintExprData data = e->data; - - /*@i22*/constraintExprKind kind = e->kind; + /*@i22*/ + + constraintExprData data = e->data; + constraintExprKind kind = e->kind; constraintExpr ret; @@ -1643,7 +1867,67 @@ doFixResultTerm (/*@only@*/ constraintExpr e, /*@exposed@*/ exprNode fcnCall) return ret; } +/* +/ *@only@* / static constraintExpr +doSRefFixInvarConstraintTerm (/ *@only@* / constraintExpr e, + sRef s, ctype ct) +{ + constraintTerm t; + + constraintExprData data = e->data; + + constraintExprKind kind = e->kind; + + constraintExpr ret; + + llassert(kind == term); + + t = constraintExprData_termGetTerm (data); + llassert (constraintTerm_isDefined(t) ); + + ret = e; + + DPRINTF (("Fixing: %s", constraintExpr_print (e))); + + switch (constraintTerm_getKind(t)) + { + case EXPRNODE: + DPRINTF((message ("%q @ %q ", constraintTerm_print(t), + fileloc_unparse (constraintTerm_getFileloc(t) ) ) )); + break; + case INTLITERAL: + DPRINTF((message (" %q ", constraintTerm_print (t)) )); + break; + + case SREF: + / * evans 2001-07-24: constants should use the original term * / + if (!constraintTerm_canGetValue (t)) + { + sRef snew; + DPRINTF ((message("Doing sRef_fixInvarConstraint for %q ", + constraintTerm_print (t) ) )); + + snew = fixSref (ct, s, constraintTerm_getSRef(t)); + ret = constraintExpr_makeTermsRef(snew); + + constraintExpr_free (e); + + DPRINTF (( message("After Doing sRef_fixConstraintParam constraintExpr is %q ", + constraintExpr_print (ret) ) )); + / *@-branchstate@* / + } / *@=branchstate@* / + + break; + default: + BADEXIT; + } + + return ret; + +} +*/ + /*drl moved from constriantTerm.c 5/20/001*/ /*@only@*/ static constraintExpr doSRefFixConstraintParamTerm (/*@only@*/ constraintExpr e, /*@observer@*/ /*@temp@*/ exprNodeList arglist) @@ -1705,7 +1989,7 @@ doSRefFixConstraintParamTerm (/*@only@*/ constraintExpr e, /*@observer@*/ /*@tem /* if (constraintTerm_hasTerm (expr->term, term) ) */ /* return TRUE; */ -/* if ( (expr->expr) != NULL) */ +/* if ((expr->expr) != NULL) */ /* { */ /* return ( constraintExpr_includesTerm (expr->expr, term) ); */ /* } */ @@ -1723,6 +2007,27 @@ bool constraintExpr_isBinaryExpr (/*@observer@*/ constraintExpr c) return FALSE; } +/*drl added 8/08/001 */ +bool constraintExpr_isTerm (/*@observer@*/ constraintExpr c) /*@*/ +{ + if (c->kind == term) + return TRUE; + + else + return FALSE; +} + +/*@observer@*/ /*@temp@*/ constraintTerm constraintExpr_getTerm ( /*@temp@*/ /*@observer@*/ constraintExpr c) /*@*/ +{ + constraintTerm term; + + llassert(constraintExpr_isTerm(c) ); + + term = constraintExprData_termGetTerm(c->data); + + return term; +} + static void binaryExpr_dump (/*@observer@*/ constraintExprData data, FILE *f) { constraintExpr expr1; @@ -1759,8 +2064,8 @@ static constraintExpr binaryExpr_undump (FILE *f) char * str; char * os; - str = mstring_create (MAX_DUMP_LINE_LENGTH); - os = str; + os = mstring_create (MAX_DUMP_LINE_LENGTH); + str = fgets(os, MAX_DUMP_LINE_LENGTH, f); @@ -1834,6 +2139,10 @@ void constraintExpr_dump (/*@observer@*/ constraintExpr expr, FILE *f) constraintExprKind kind; constraintTerm t; + + DPRINTF((message("constraintExpr_dump:: dumping constraintExpr %s", + constraintExpr_unparse(expr) + ) )); kind = expr->kind; @@ -1890,3 +2199,295 @@ void constraintExpr_dump (/*@observer@*/ constraintExpr expr, FILE *f) return ret; } + +int constraintExpr_getDepth (constraintExpr ex) +{ + int ret; + + constraintExprKind kind; + + llassert (ex != NULL); + + kind = ex->kind; + + switch (kind) + { + case term: + ret = 1; + break; + case unaryExpr: + ret = constraintExpr_getDepth (constraintExprData_unaryExprGetExpr (ex->data) ); + ret++; + + break; + case binaryexpr: + ret = 0; + ret = constraintExpr_getDepth (constraintExprData_binaryExprGetExpr1 (ex->data) ); + + ret++; + + ret += constraintExpr_getDepth (constraintExprData_binaryExprGetExpr2 (ex->data) ); + + break; + default: + BADEXIT; + } + + return ret; +} + + +bool constraintExpr_canGetCType (constraintExpr e) /*@*/ +{ + if (e->kind == term) + { + return TRUE; + } + else + { + DPRINTF(( message("constraintExpr_canGetCType: can't get type for %s ", + constraintExpr_print(e) ) )); + return FALSE; + } +} + +ctype constraintExpr_getCType (constraintExpr e) /*@*/ +{ + constraintTerm t; + + llassert(constraintExpr_canGetCType(e) ); + + switch (e->kind) + { + case term: + t = constraintExprData_termGetTerm (e->data); + return (constraintTerm_getCType(t) ); + /* assume that a unary expression will be an int ... */ + case unaryExpr: + return ctype_signedintegral; + + /* drl for just return type of first operand */ + case binaryexpr: + return ( + constraintExpr_getCType + (constraintExprData_binaryExprGetExpr1 (e->data) ) + ); + default: + BADEXIT; + } + BADEXIT; +} + +/* drl add 10-5-001 */ + +static bool constraintExpr_hasTypeChange(constraintExpr e) +{ + if (constraintExpr_isDefined((e)) && (e->ct == TRUE) ) + { + return TRUE; + } + + if (e->kind == unaryExpr) + { + if (constraintExprData_unaryExprGetOp (e->data) == MAXSET) + { + constraintExpr ce; + + ce = constraintExprData_unaryExprGetExpr(e->data); + + return (constraintExpr_hasTypeChange(ce) ); + } + + } + return FALSE; +} + +/* drl add 10-5-001 */ + +static ctype constraintExpr_getOrigType (constraintExpr e) +{ + + llassert(constraintExpr_hasTypeChange(e) ); + + + if (e->ct == TRUE) + { + return e->origType; + } + + if (e->kind == unaryExpr) + { + if (constraintExprData_unaryExprGetOp (e->data) == MAXSET) + { + constraintExpr ce; + + ce = constraintExprData_unaryExprGetExpr(e->data); + + return (constraintExpr_getOrigType(ce) ); + } + + } + + BADEXIT; +} + +/*drl added these around 10/18/001*/ + +static /*@only@*/ constraintExpr constraintExpr_div (/*@only@*/ constraintExpr e, /*@unused@*/ ctype ct) +{ + return e; +} + +static /*@only@*/ constraintExpr constraintTerm_simpleDivTypeExprNode(/*@only@*/ constraintExpr e, ctype ct) +{ + exprData data; + exprNode t1, t2, expr; + lltok tok; + constraintTerm t; + + DPRINTF(( + message("constraintTerm_simpleDivTypeExprNode e=%s, ct=%s", + constraintExpr_print(e), ctype_unparse(ct) + ) + )); + + t = constraintExprData_termGetTerm(e->data); + + expr = constraintTerm_getExprNode(t); + + if (expr->kind == XPR_OP) + { + data = expr->edata; + + t1 = exprData_getOpA (data); + t2 = exprData_getOpB (data); + tok = exprData_getOpTok (data); + if (lltok_isMult(tok) ) + { + + if ((t1->kind == XPR_SIZEOF) || (t1->kind == XPR_SIZEOFT) ) + { + ctype ct2; + + if (t1->kind == XPR_SIZEOFT) + { + ct2 = qtype_getType (exprData_getType (t1->edata)); + } + else + { + ct2 = qtype_getType (exprData_getType(exprData_getSingle (t1->edata)->edata ) ); + } + if (ctype_match (ctype_makePointer(ct2), ct) ) + { + /* this is a bit sloopy but ... */ + constraintExpr_free(e); + return constraintExpr_makeExprNode(t2); + } + } + + + else if ((t2->kind == XPR_SIZEOF) || (t2->kind == XPR_SIZEOFT) ) + { + ctype ct2; + + if (t2->kind == XPR_SIZEOFT) + { + ct2 = qtype_getType (exprData_getType (t2->edata)); + } + else + { + ct2 = qtype_getType (exprData_getType(exprData_getSingle (t2->edata)->edata ) ); + } + if (ctype_match (ctype_makePointer(ct2),ct) ) + { + /* sloopy way to do this... */ /*@i22*/ + constraintExpr_free(e); + return constraintExpr_makeExprNode(t1); + } + } + else + { + /*empty*/ + } + + } + } + return (constraintExpr_div (e, ct) ); +} + +static /*@only@*/ constraintExpr simpleDivType (/*@only@*/ constraintExpr e, ctype ct) +{ + /*@i333*/ + DPRINTF(( (message("simpleDiv got %s ", constraintExpr_unparse(e) ) ) + )); + + switch (e->kind) + { + case term: + + { + constraintTerm t; + + t = constraintExprData_termGetTerm(e->data); + + + if (constraintTerm_isExprNode (t) ) + { + return constraintTerm_simpleDivTypeExprNode(e, ct); + + /* search for * size of ct and remove */ + } + return constraintExpr_div (e, ct); + } + + case binaryexpr: + { + constraintExpr temp; + + temp = constraintExprData_binaryExprGetExpr1 (e->data); + temp = constraintExpr_copy(temp); + temp = simpleDivType (temp, ct); + + e->data = constraintExprData_binaryExprSetExpr1 (e->data, temp); + + temp = constraintExprData_binaryExprGetExpr2 (e->data); + temp = constraintExpr_copy(temp); + temp = simpleDivType (temp, ct); + e->data = constraintExprData_binaryExprSetExpr2 (e->data, temp); + + DPRINTF(( (message("simpleDiv binaryexpr returning %s ", constraintExpr_unparse(e) ) ) + )); + + return e; + } + case unaryExpr: + return constraintExpr_div (e, ct); + + default: + BADEXIT; + } +} + +static /*@only@*/ constraintExpr constraintExpr_adjustMaxSetForCast(/*@only@*/ constraintExpr e, ctype ct) +{ + + DPRINTF(( (message("constraintExpr_adjustMaxSetForCast got %s ", constraintExpr_unparse(e) ) ) + )); + + e = constraintExpr_makeIncConstraintExpr(e); + + e = constraintExpr_simplify(e); + + + e = simpleDivType (e, ct); + + e = constraintExpr_makeDecConstraintExpr(e); + + e = constraintExpr_simplify(e); + + DPRINTF(( (message("constraintExpr_adjustMaxSetForCast returning %s ", constraintExpr_unparse(e) ) ) + )); + + return e; +} +