/*
** Splint - annotation-assisted static program checker
-** Copyright (C) 1994-2002 University of Virginia,
+** Copyright (C) 1994-2003 University of Virginia,
** Massachusetts Institute of Technology
**
** This program is free software; you can redistribute it and/or modify it
** the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
** MA 02111-1307, USA.
**
-** For information on splint: splint@cs.virginia.edu
-** To report a bug: splint-bug@cs.virginia.edu
+** For information on splint: info@splint.org
+** To report a bug: splint-bug@splint.org
** For more information: http://www.splint.org
*/
# include "exprChecks.h"
# include "exprNodeSList.h"
-# include "exprDataQuite.i"
-
-/*@access constraint, exprNode @*/
-
-/*@access constraintExpr @*/
-
-static bool isInc (/*@observer@*/ constraintExpr c) /*@*/
-{
-
- llassert (constraintExpr_isDefined (c) );
- if (c->kind == binaryexpr )
- {
- constraintExprBinaryOpKind binOP;
- constraintExpr t1, t2;
- t1 = constraintExprData_binaryExprGetExpr1 (c->data);
- t2 = constraintExprData_binaryExprGetExpr2 (c->data);
-
- binOP = constraintExprData_binaryExprGetOp (c->data);
- if (binOP == BINARYOP_PLUS)
- if (constraintExpr_isLit (t2) && constraintExpr_getValue (t2) == 1 )
- {
- return TRUE;
- }
- }
-
- return FALSE;
-}
-
-/* look for constraints like cexrp = cexrp + 1 */
-static bool incVar (/*@notnull@*/ constraint c) /*@*/
-{
- constraintExpr t1;
- if (c->ar != EQ)
- {
- return FALSE;
- }
- if (! isInc (c->expr ) )
- return FALSE;
-
- llassert (constraintExpr_isDefined (c->expr) );
- llassert (c->expr->kind == binaryexpr);
+/* this file was created to split the loop heuristics functionality out of constraintGeneration.c and constraint.c*/
+/*We need to access the internal representation of constraint
+ see above for an explanation.
+*/
- t1 = constraintExprData_binaryExprGetExpr1 (c->expr->data);
- if (constraintExpr_similar (c->lexpr, t1) )
- return TRUE;
+/*@access constraint @*/
- return FALSE;
-}
-/*@noaccess constraintExpr @*/
+static bool isInc (/*@observer@*/ constraintExpr p_c) /*@*/;
+static bool incVar (/*@notnull@*/ constraint p_c) /*@*/;
static bool increments (/*@observer@*/ constraint c,
return FALSE;
}
+static /*@only@*/ constraintList getLessThanConstraints (/*@observer@*/ constraintList c)
+{
+ constraintList ret;
+
+ ret = constraintList_makeNew ();
+ constraintList_elements (c, el)
+ {
+ llassert (constraint_isDefined (el));
+ if ( constraint_isUndefined (el) )
+ continue;
+
+ if (el->ar == LT || el->ar == LTE)
+ {
+ constraint temp;
+ temp = constraint_copy (el);
+
+ ret = constraintList_add (ret, temp);
+ }
+ }
+ end_constraintList_elements;
+
+ return ret;
+}
+
+static /*@only@*/ constraintList getIncConstraints (/*@observer@*/ constraintList c)
+{
+ constraintList ret;
+
+ ret = constraintList_makeNew ();
+ constraintList_elements (c, el)
+ {
+ llassert (constraint_isDefined (el));
+
+ if (incVar (el) )
+ {
+ constraint temp;
+ temp = constraint_copy (el);
+ ret = constraintList_add (ret, temp);
+ }
+ }
+ end_constraintList_elements;
+
+ return ret;
+}
+
+/*@access exprNode@*/
static bool canGetForTimes (/*@notnull@*/ exprNode forPred, /*@notnull@*/ exprNode forBody)
{
}
tok = (exprData_getUopTok (inc->edata));
- if (lltok_isInc_Op (tok) )
+ if (lltok_isIncOp (tok) )
{
t1 = exprData_getUopNode (test->edata);
t2 = exprData_getUopNode (inc->edata);
}
return FALSE;
}
+/*@noaccess exprNode@*/
-static /*@only@*/ constraintList getLessThanConstraints (/*@observer@*/ constraintList c)
-{
- constraintList ret;
-
- ret = constraintList_makeNew ();
- constraintList_elements (c, el)
- {
- llassert (constraint_isDefined (el));
- if ( constraint_isUndefined (el) )
- continue;
-
- if (el->ar == LT || el->ar == LTE)
- {
- constraint temp;
- temp = constraint_copy (el);
-
- ret = constraintList_add (ret, temp);
- }
- }
- end_constraintList_elements;
-
- return ret;
-}
-
-static /*@only@*/ constraintList getIncConstraints (/*@observer@*/ constraintList c)
-{
- constraintList ret;
-
- ret = constraintList_makeNew ();
- constraintList_elements (c, el)
- {
- llassert (constraint_isDefined (el));
-
- if (incVar (el) )
- {
- constraint temp;
- temp = constraint_copy (el);
- ret = constraintList_add (ret, temp);
- }
- }
- end_constraintList_elements;
-
- return ret;
-}
+/*@access exprNode@*/
static /*@only@*/ constraintExpr getForTimes (/*@notnull@*/ exprNode forPred, /*@notnull@*/ exprNode forBody)
{
ltCon = getLessThanConstraints (test->trueEnsuresConstraints);
incCon = getIncConstraints (inc->ensuresConstraints);
- DPRINTF (( message ("getForTimes: ltCon: %s from %s", constraintList_print (ltCon), constraintList_print (test->trueEnsuresConstraints) ) ));
+ DPRINTF (( message ("getForTimes: ltCon: %s from %s", constraintList_unparse (ltCon), constraintList_unparse (test->trueEnsuresConstraints) ) ));
- DPRINTF (( message ("getForTimes: incCon: %s from %s", constraintList_print (incCon), constraintList_print (inc->ensuresConstraints) ) ));
+ DPRINTF (( message ("getForTimes: incCon: %s from %s", constraintList_unparse (incCon), constraintList_unparse (inc->ensuresConstraints) ) ));
constraintList_elements (ltCon, el)
{
constraintList_elements (incCon, el2)
{
- if ( increments (el2, el->lexpr) )
+ llassert(constraint_isDefined (el ) );
+
+ if ( (constraint_isDefined (el ) ) && ( increments (el2, el->lexpr) ) )
{
- DPRINTF (( message ("getForTimes: %s increments %s", constraint_print (el2), constraint_print (el) ) ));
+ DPRINTF (( message ("getForTimes: %s increments %s", constraint_printLocation (el2), constraint_printLocation (el) ) ));
ret = constraintExpr_copy (el->expr);
constraintList_free (ltCon);
constraintList_free (incCon);
}
else
- DPRINTF (( message ("getForTimes: %s doesn't increment %s", constraint_print (el2), constraint_print (el) ) ));
+ {
+ ;
+ DPRINTF (( message ("getForTimes: %s doesn't increment %s", constraint_printLocation (el2), constraint_printLocation (el) ) ));
+ }
}
end_constraintList_elements;
}
}
tok = (exprData_getUopTok (inc->edata));
- if (lltok_isInc_Op (tok) )
+ if (lltok_isIncOp (tok) )
{
t1 = exprData_getUopNode (test->edata);
t2 = exprData_getUopNode (inc->edata);
+
+ llassert(exprNode_isDefined(t1) && exprNode_isDefined(t2) );
if (sRef_sameName (t1->sref, t2->sref) )
{
return (constraintExpr_makeMaxSetExpr (t1) );
llassert ( FALSE);
BADEXIT;
}
+/*@noaccess exprNode@*/
/*@access constraintExpr @*/
constraintExprKind kind;
constraintExpr temp;
+
+ llassert (constraintExpr_isDefined (c) );
+
DPRINTF (( message ("Doing constraintExpr_searchAndAdd %s %s %s ",
constraintExpr_unparse (c), constraintExpr_unparse (find), constraintExpr_unparse (add) ) ) );
static constraint constraint_searchAndAdd (/*@returned@*/ constraint c, /*@observer@*/ constraintExpr find, /*@observer@*/ constraintExpr add)
{
-
+
+
+ llassert (constraint_isDefined (c) );
+
llassert (constraint_search (c, find) );
DPRINTF (( message ("Doing constraint_searchAndAdd %s %s %s ",
- constraint_print (c), constraintExpr_unparse (find), constraintExpr_unparse (add) ) ) );
+ constraint_printLocation (c), constraintExpr_unparse (find), constraintExpr_unparse (add) ) ) );
c->lexpr = constraintExpr_searchAndAdd (c->lexpr, find, add);
c->expr = constraintExpr_searchAndAdd (c->expr, find, add);
newExpr = constraint_copy (el);
newExpr = constraint_searchAndAdd (newExpr, find, add);
- DPRINTF (( (message ("Adding constraint %s ", constraint_print (newExpr)) ) ));
+ DPRINTF (( (message ("Adding constraint %s ", constraint_printLocation (newExpr)) ) ));
newConstraints = constraintList_add (newConstraints, newExpr);
}
return ret;
}
+/*@access exprNode@*/
static void doAdjust (/*@unused@*/ exprNode e, /*@unused@*/ exprNode forPred, /*@observer@*/ exprNode forBody, /*@observer@*/ constraintExpr iterations)
{
-
+
+ llassert (exprNode_isDefined (forBody) );
+
constraintList_elements (forBody->ensuresConstraints, el)
{
/* look for var = var + 1 */
- if (incVar (el) )
+ if (constraint_isDefined (el) && incVar (el) )
{
- DPRINTF ((message ("Found inc variable constraint : %s", constraint_print (el) ) ));
+ DPRINTF ((message ("Found inc variable constraint : %s", constraint_printLocation (el) ) ));
forBody->requiresConstraints = constraintList_searchAndAdd (forBody->requiresConstraints, el->lexpr, iterations);
}
}
end_constraintList_elements;
}
-void exprNode_forLoopHeuristics ( exprNode e, exprNode forPred, exprNode forBody)
+
+/*@access exprNode@*/
+
+
+static void forLoopHeuristicsImpl ( exprNode e, exprNode forPred, /*@observer@*/ exprNode forBody)
{
exprNode init, test, inc;
constraintExpr iterations;
-
+
+ llassert (exprNode_isDefined(forPred) );
+ llassert (exprNode_isDefined(forBody) );
+
init = exprData_getTripleInit (forPred->edata);
test = exprData_getTripleTest (forPred->edata);
inc = exprData_getTripleInc (forPred->edata);
constraintExpr_free (iterations);
}
}
+/*@noaccess exprNode@*/
+
+void exprNode_forLoopHeuristics ( exprNode e, exprNode forPred, exprNode forBody)
+{
+ forLoopHeuristicsImpl (e, forPred, forBody);
+}
+
+ /*@access constraintExpr @*/
+
+static bool isInc (/*@observer@*/ constraintExpr c) /*@*/
+{
+
+ llassert (constraintExpr_isDefined (c) );
+ if (c->kind == binaryexpr )
+ {
+ constraintExprBinaryOpKind binOP;
+ constraintExpr t1, t2;
+ t1 = constraintExprData_binaryExprGetExpr1 (c->data);
+ t2 = constraintExprData_binaryExprGetExpr2 (c->data);
+
+ binOP = constraintExprData_binaryExprGetOp (c->data);
+ if (binOP == BINARYOP_PLUS)
+ if (constraintExpr_isLit (t2) && constraintExpr_getValue (t2) == 1 )
+ {
+ return TRUE;
+ }
+ }
+
+ return FALSE;
+}
+ /*@noaccess constraintExpr @*/
+
+ /*@access constraintExpr @*/
+/* look for constraints like cexrp = cexrp + 1 */
+static bool incVar (/*@notnull@*/ constraint c) /*@*/
+{
+ constraintExpr t1;
+ if (c->ar != EQ)
+ {
+ return FALSE;
+ }
+ if (! isInc (c->expr ) )
+ return FALSE;
+
+ llassert (constraintExpr_isDefined (c->expr) );
+ llassert (c->expr->kind == binaryexpr);
+
+ t1 = constraintExprData_binaryExprGetExpr1 (c->expr->data);
+ if (constraintExpr_similar (c->lexpr, t1) )
+ return TRUE;
+
+ return FALSE;
+}
+/*@noaccess constraintExpr @*/
+
+
/* else */