/*
** Splint - annotation-assisted static program checker
-** Copyright (C) 1994-2001 University of Virginia,
+** Copyright (C) 1994-2003 University of Virginia,
** Massachusetts Institute of Technology
**
** This program is free software; you can redistribute it and/or modify it
** the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
** MA 02111-1307, USA.
**
-** For information on lclint: lclint-request@cs.virginia.edu
-** To report a bug: lclint-bug@cs.virginia.edu
+** For information on splint: info@splint.org
+** To report a bug: splint-bug@splint.org
** For more information: http://www.splint.org
*/
/* #define DEBUGPRINT 1 */
# include <ctype.h> /* for isdigit */
-# include "lclintMacros.nf"
+# include "splintMacros.nf"
# include "basic.h"
# include "cgrammar.h"
# include "cgrammar_tokens.h"
# include "exprNodeSList.h"
-/*@access constraint, exprNode @*/
-
+/*@access constraint, exprNode @*/ /*!!! NO! Don't do this so recklessly - design your code more carefully so you don't need to! */
static constraint inequalitySubstitute (/*@returned@*/ constraint p_c, constraintList p_p);
static /*@only@*/ constraintList reflectChangesEnsuresFree1 (/*@only@*/ constraintList p_pre2, constraintList p_post1);
-/*********************************************/
-
-
-
/*@only@*/ constraintList constraintList_mergeEnsuresFreeFirst (constraintList list1, constraintList list2)
{
DPRINTF((message ("constraintList_mergeRequires: merging %s and %s ", constraintList_print (list1), constraintList_print(list2) ) ) );
+ if (context_getFlag (FLG_REDUNDANTCONSTRAINTS) )
+ {
+ ret = constraintList_copy(list1);
+ ret = constraintList_addList(ret, list2);
+ return ret;
+ }
+
/* get constraints in list1 not satified by list2 */
temp = constraintList_reflectChanges(list1, list2);
DPRINTF((message ("constraintList_mergeRequires: temp = %s", constraintList_print(temp) ) ) );
{
constraintList temp, temp2;
- DPRINTF( (message ("magically merging constraint into parent:%s for", exprNode_unparse (parent) )) );
+ DPRINTF((message ("magically merging constraint into parent:%s for", exprNode_unparse (parent) )) );
- DPRINTF( (message (" children: %s and %s", exprNode_unparse (child1), exprNode_unparse(child2) ) ) );
+ DPRINTF((message (" children: %s and %s", exprNode_unparse (child1), exprNode_unparse(child2) ) ) );
+
+ if (exprNode_isUndefined(parent) )
+ {
+ llassert (exprNode_isDefined(parent) );
+ return;
+ }
+
+
if (exprNode_isError (child1) || exprNode_isError(child2) )
{
if (exprNode_isError (child1) && !exprNode_isError(child2) )
llassert(!exprNode_isError (child1) && ! exprNode_isError(child2) );
- DPRINTF( (message ("Child constraints are %s %s and %s %s",
+ DPRINTF((message ("Child constraints are %s %s and %s %s",
constraintList_print (child1->requiresConstraints),
constraintList_print (child1->ensuresConstraints),
constraintList_print (child2->requiresConstraints),
parent->requiresConstraints = temp2;
- DPRINTF( (message ("Parent requires constraints are %s ",
+ DPRINTF((message ("Parent requires constraints are %s ",
constraintList_print (parent->requiresConstraints)
) ) );
child2->ensuresConstraints);
- DPRINTF( (message ("Parent constraints are %s and %s ",
+ DPRINTF((message ("Parent constraints are %s and %s ",
constraintList_print (parent->requiresConstraints),
constraintList_print (parent->ensuresConstraints)
) ) );
}
else
{
- DPRINTF ( (message ("Subsuming %s", constraint_print (el) ) ) );
+ DPRINTF ((message ("Subsuming %s", constraint_print (el) ) ) );
}
} end_constraintList_elements;
static constraint constraint_addOr (/*@returned@*/ constraint orig, /*@observer@*/ constraint orConstr)
{
constraint c;
+
+ llassert(constraint_isDefined(orig) );
+
c = orig;
DPRINTF((message("constraint_addor: oring %s onto %s", constraint_printOr(orConstr), constraint_printOr(orig) ) ));
int numberOr;
numberOr = 0;
+
+ llassert(constraint_isDefined(c) );
+
DPRINTF(( message("resolveOr: constraint %s and list %s", constraint_printOr(c), constraintList_print(list) ) ));
+
temp = c;
do
{
constraint temp;
- llassert(constraint_isUndefined (c->or ) );
+ llassert(constraint_isDefined (c ) );
+
+ DPRINTF((message("doResolve:: call on constraint c = : %q and constraintList %q",
+ constraint_printOr(c), constraintList_print(post1)
+ )
+ ));
if (!resolveOr (c, post1) )
{
temp = constraint_substitute (c, post1);
+ DPRINTF((message("doResolve:: after substitute temp is %q",
+ constraint_printOr(temp)
+ )
+ ));
+
if (!resolveOr (temp, post1) )
{
/* try inequality substitution */
if (!resolveOr (temp2, post1) )
{
if (!constraint_same (temp, temp2) )
- temp = constraint_addOr (temp, temp2);
-
+ {
+ /* drl added 8/28/2002*/
+ /*make sure that the information from
+ a post condition like i = i + 1 is transfered
+ */
+ constraint tempSub;
+ tempSub = constraint_substitute (temp2, post1);
+
+ DPRINTF((
+ message("doResolve: adding %s ",
+ constraint_printOr(tempSub)
+ )
+ ));
+
+ DPRINTF((
+ message("doResolve: not adding %s ",
+ constraint_printOr(temp2)
+ )
+ ));
+
+ temp = constraint_addOr (temp, tempSub);
+ constraint_free(tempSub);
+
+ }
if (!constraint_same (temp, temp3) && !constraint_same (temp3, temp2) )
- temp = constraint_addOr (temp, temp3);
-
+ {
+ /* drl added 8/28/2002*/
+ /*make sure that the information from
+ a post condition like i = i + 1 is transfered
+ */
+ constraint tempSub;
+
+ tempSub = constraint_substitute (temp3, post1);
+
+ DPRINTF((
+ message("doResolve: adding %s ",
+ constraint_printOr(tempSub)
+ )
+ ));
+
+
+ DPRINTF((
+ message("doResolve: not adding %s ",
+ constraint_printOr(temp3)
+ )
+ ));
+
+ temp = constraint_addOr (temp, tempSub);
+
+ constraint_free(tempSub);
+ }
*resolved = FALSE;
constraint_free(temp2);
- *resolved = FALSE;
+ *resolved = FALSE;
+ llassert(constraint_isDefined(c) );
ret = constraint_copy(c);
+ llassert(constraint_isDefined(ret) );
+
if (constraintList_isEmpty(post1) )
{
return ret;
curr = doResolve (curr, post1, resolved);
- if (*resolved)
+ if (*resolved)
{
/* curr is null so we don't try to free it*/
llassert(curr == NULL);
}
else
{
- DPRINTF ( (message ("Resolved away %s ", constraint_print(el) ) ) );
+ DPRINTF ((message ("Resolved away %s ", constraint_print(el) ) ) );
}
} end_constraintList_elements;
static bool constraint_conflict (constraint c1, constraint c2)
{
-
+
+ llassert(constraint_isDefined(c1) );
+ llassert(constraint_isDefined(c2) );
+
if (constraintExpr_similar(c1->lexpr, c2->lexpr) )
{
if (c1->ar == EQ)
if (c1->ar == c2->ar)
{
- DPRINTF ( (message ("%s conflicts with %s ", constraint_print (c1), constraint_print(c2) ) ) );
+ DPRINTF ((message ("%s conflicts with %s ", constraint_print (c1), constraint_print(c2) ) ) );
return TRUE;
}
}
strlen(str) == maxRead(s) + strlen(str);
*/
- /*@i324234*/ /* clean this up */
+ /*@i324234*/ /*this code is functional but it may be worth cleaning up at some point. */
if (c1->ar == EQ)
if (c1->ar == c2->ar)
if (constraintTerm_isExprNode(term) )
{
- DPRINTF ( (message ("%s conflicts with %s ", constraint_print (c1), constraint_print(c2) ) ) );
+ DPRINTF ((message ("%s conflicts with %s ", constraint_print (c1), constraint_print(c2) ) ) );
return TRUE;
}
}
if (constraint_tooDeep(c1) || constraint_tooDeep(c2) )
{
- DPRINTF ( (message ("%s conflicts with %s (constraint is too deep", constraint_print (c1), constraint_print(c2) ) ) );
+ DPRINTF ((message ("%s conflicts with %s (constraint is too deep", constraint_print (c1), constraint_print(c2) ) ) );
return TRUE;
}
- DPRINTF ( (message ("%s doesn't conflict with %s ", constraint_print (c1), constraint_print(c2) ) ) );
+ DPRINTF ((message ("%s doesn't conflict with %s ", constraint_print (c1), constraint_print(c2) ) ) );
return FALSE;
static void constraint_fixConflict (/*@temp@*/ constraint good, /*@temp@*/ /*@observer@*/ constraint conflicting) /*@modifies good@*/
{
+ llassert(constraint_isDefined(conflicting) );
+
if (conflicting->ar ==EQ )
{
+ llassert(constraint_isDefined(good) );
good->expr = constraintExpr_searchandreplace (good->expr, conflicting->lexpr, conflicting->expr);
good = constraint_simplify (good);
}
/*returns true if constraint post satifies cosntriant pre */
static bool satifies (constraint pre, constraint post)
{
+ llassert(constraint_isDefined(pre) );
+ llassert(constraint_isDefined(post) );
+
if (constraint_isAlwaysTrue (pre) )
return TRUE;
{
if ( satifies (c, el) )
{
- DPRINTF ( (message ("\n%s Satifies %s\n ", constraint_print(el), constraint_print(c) ) ) );
+ DPRINTF ((message ("\n%s Satifies %s\n ", constraint_print(el), constraint_print(c) ) ) );
return TRUE;
}
- DPRINTF ( (message ("\n%s does not satify %s\n ", constraint_print(el), constraint_print(c) ) ) );
+ DPRINTF ((message ("\n%s does not satify %s\n ", constraint_print(el), constraint_print(c) ) ) );
}
end_constraintList_elements;
- DPRINTF ( (message ("no constraints satify %s", constraint_print(c) ) ));
+ DPRINTF ((message ("no constraints satify %s", constraint_print(c) ) ));
return FALSE;
}
{
case GTE:
case GT:
- if ( (ar2 == GT) || (ar2 == GTE) || (ar2 == EQ) )
+ if ((ar2 == GT) || (ar2 == GTE) || (ar2 == EQ) )
{
return TRUE;
}
case LT:
case LTE:
- if ( (ar2 == LT) || (ar2 == LTE) || (ar2 == EQ) )
+ if ((ar2 == LT) || (ar2 == LTE) || (ar2 == EQ) )
return TRUE;
break;
default:
constraintTerm ct;
exprNode e, t;
sRef s1, s2;
+
+ llassert(constraintExpr_isDefined(buf1) && constraintExpr_isDefined(expr2) );
+
/*@access constraintExpr@*/
- if ( (expr2->kind != term) && (buf1->kind != term) )
+ if ((expr2->kind != term) && (buf1->kind != term) )
return FALSE;
e = constraintTerm_getExprNode(ct);
+ llassert(exprNode_isDefined(e) );
+
+ if (! (exprNode_isDefined(e) ) )
+ return FALSE;
+
if (e->kind != XPR_SIZEOF)
return FALSE;
*/
/*@i223@*/ /*need to add some type checking */
+
static bool sizeOfMaxSet( /*@observer@*/ /*@temp@*/ constraint c)
{
constraintExpr l, r, buf1, buf2, con;
DPRINTF(( message("sizeOfMaxSet: checking %s ", constraint_print(c) )
));
-
+
+ llassert (constraint_isDefined(c) );
+
l = c->lexpr;
r = c->expr;
- if (!( (c->ar == EQ) || (c->ar == GTE) || (c->ar == LTE) ) )
+ if (!((c->ar == EQ) || (c->ar == GTE) || (c->ar == LTE) ) )
return FALSE;
+ llassert (constraintExpr_isDefined(l) );
+ llassert (constraintExpr_isDefined(r) );
+
/*check if the constraintExpr is MaxSet(buf) */
if (l->kind == unaryExpr)
{
constraintExpr l, r;
bool rHasConstant;
int rConstant;
+
+
+ llassert (constraint_isDefined(c) );
l = c->lexpr;
r = c->expr;
return TRUE;
}
}
- DPRINTF( ("Can't Get value"));
+ DPRINTF(("Can't Get value"));
constraintExpr_free(e1);
constraintExpr_free(e2);
constraintExpr_free(e1);
constraintExpr_free(e2);
- DPRINTF( ("Can't Get value"));
+ DPRINTF(("Can't Get value"));
return FALSE;
}
static constraint constraint_searchandreplace (/*@returned@*/ constraint c, constraintExpr old, constraintExpr newExpr)
{
+ llassert (constraint_isDefined(c) );
+
DPRINTF (("Doing replace for lexpr") );
+
c->lexpr = constraintExpr_searchandreplace (c->lexpr, old, newExpr);
DPRINTF (("Doing replace for expr") );
c->expr = constraintExpr_searchandreplace (c->expr, old, newExpr);
{
bool ret;
ret = FALSE;
-
+
+ llassert (constraint_isDefined(c) );
+
ret = constraintExpr_search (c->lexpr, old);
ret = ret || constraintExpr_search (c->expr, old);
return ret;
{
fileloc loc1, loc2, loc3;
- DPRINTF ( (message("Start adjust on %s and %s", constraint_print(substitute),
+ DPRINTF ((message("Start adjust on %s and %s", constraint_print(substitute),
constraint_print(old))
));
+ llassert(constraint_isDefined(substitute));
+ llassert(constraint_isDefined(old));
+
loc1 = constraint_getFileloc (old);
loc2 = constraintExpr_getFileloc (substitute->lexpr);
loc3 = constraintExpr_getFileloc (substitute->expr);
if (fileloc_closer (loc1, loc3, loc2))
{
constraintExpr temp;
- DPRINTF ( (message("Doing adjust on %s", constraint_print(substitute) )
+ DPRINTF ((message("Doing adjust on %s", constraint_print(substitute) )
));
temp = substitute->lexpr;
substitute->lexpr = substitute->expr;
constraint inequalitySubstitute (/*@returned@*/ constraint c, constraintList p)
{
+ llassert(constraint_isDefined(c) );
+
if (c->ar != GTE)
return c;
constraintList_elements (p, el)
{
- if ( (el->ar == LT ) )
+
+ llassert(constraint_isDefined(el) );
+
+ if ((el->ar == LT ) )
/* if (!constraint_conflict (c, el) ) */ /*@i523 explain this! */
{
constraintExpr temp2;
{
DPRINTF (( message ("inequalitySubstituteStrong examining substituting for %q", constraint_print(c) ) ));
+ llassert(constraint_isDefined(c) );
+
+ if (! (constraint_isDefined(c) ) )
+ {
+ return c;
+ }
+
if (c->ar != GTE)
return c;
constraint_print(c), constraintList_print(p) ) ));
constraintList_elements (p, el)
{
+
DPRINTF (( message ("inequalitySubstituteStrong examining substituting %s on %s", constraint_print(el), constraint_print(c) ) ));
- if ( (el->ar == LT ) || (el->ar == LTE ) )
+ llassert(constraint_isDefined(el) );
+ if ((el->ar == LT ) || (el->ar == LTE ) )
/* if (!constraint_conflict (c, el) ) */ /*@i523@*/
{
constraintExpr temp2;
));
temp2 = constraintExpr_copy (el->expr);
constraintExpr_free(c->expr);
- if ( (el->ar == LTE ) )
+ if ((el->ar == LTE ) )
{
c->expr = temp2;
}
static constraint inequalitySubstituteUnsound (/*@returned@*/ constraint c, constraintList p)
{
DPRINTF (( message ("Doing inequalitySubstituteUnsound " ) ));
+
+ llassert(constraint_isDefined(c) );
if (c->ar != GTE)
return c;
constraintList_elements (p, el)
{
- DPRINTF (( message ("inequalitySubstituteUnsound examining substituting %s on %s", constraint_print(el), constraint_print(c) ) ));
- if ( ( el->ar == LTE) || (el->ar == LT) )
+
+ llassert(constraint_isDefined(el) );
+
+ DPRINTF (( message ("inequalitySubstituteUnsound examining substituting %s on %s", constraint_print(el), constraint_print(c) ) ));
+ if (( el->ar == LTE) || (el->ar == LT) )
/* if (!constraint_conflict (c, el) ) */ /*@i532@*/
{
constraintExpr temp2;
ret = constraint_copy(c);
constraintList_elements (p, el)
{
+ llassert(constraint_isDefined(el) );
if ( el->ar == EQ)
if (!constraint_conflict (ret, el) )
temp = constraint_adjust(temp, ret);
- DPRINTF((message ("Substituting %s in the constraint %s",
- constraint_print (temp), constraint_print (ret)
+ llassert(constraint_isDefined(temp) );
+
+
+ DPRINTF((message ("constraint_substitute :: Substituting in %s using %s",
+ constraint_print (ret), constraint_print (temp)
) ) );
ret = constraint_searchandreplace (ret, temp->lexpr, temp->expr);
- DPRINTF(( message ("The new constraint is %s", constraint_print (ret) ) ));
+ DPRINTF(( message (" constraint_substitute :: The new constraint is %s", constraint_print (ret) ) ));
constraint_free(temp);
}
}
end_constraintList_elements;
- DPRINTF(( message ("The finial new constraint is %s", constraint_print (ret) ) ));
ret = constraint_simplify(ret);
+
+ DPRINTF(( message (" constraint_substitute :: The final new constraint is %s", constraint_print (ret) ) ));
+
return ret;
}
static constraint constraint_solve (/*@returned@*/ constraint c)
{
- DPRINTF( (message ("Solving %s\n", constraint_print(c) ) ) );
+
+ llassert(constraint_isDefined(c) );
+
+ DPRINTF((message ("Solving %s\n", constraint_print(c) ) ) );
c->expr = constraintExpr_solveBinaryExpr (c->lexpr, c->expr);
- DPRINTF( (message ("Solved and got %s\n", constraint_print(c) ) ) );
+ DPRINTF((message ("Solved and got %s\n", constraint_print(c) ) ) );
return c;
}
static constraint constraint_swapLeftRight (/*@returned@*/ constraint c)
{
constraintExpr temp;
+
+ llassert(constraint_isDefined(c) );
+
c->ar = flipAr (c->ar);
temp = c->lexpr;
c->lexpr = c->expr;
constraint constraint_simplify ( /*@returned@*/ constraint c)
{
-
+
+ llassert(constraint_isDefined(c) );
+
DPRINTF(( message("constraint_simplify on %q ", constraint_print(c) ) ));
if (constraint_tooDeep(c))
andersk / splint.git / blobdiff