From e24bb7d58562431b64000af025c6da811941c3f3 Mon Sep 17 00:00:00 2001 From: dtucker Date: Sun, 29 Feb 2004 09:15:08 +0000 Subject: [PATCH] - dtucker@cvs.openbsd.org 2004/02/27 22:49:27 [dh.c] Reset bit counter at the right time, fixes debug output in the case where the DH group is rejected. ok markus@ --- ChangeLog | 4 ++++ dh.c | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 26eed3e8..ea98bbbb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,6 +11,10 @@ [dh.c] Make /etc/moduli line buffer big enough for 8kbit primes, in case anyone ever uses one. ok markus@ + - dtucker@cvs.openbsd.org 2004/02/27 22:49:27 + [dh.c] + Reset bit counter at the right time, fixes debug output in the case where + the DH group is rejected. ok markus@ 20040226 - (bal) KNF our sshlogin.c even if the code looks nothing like upstream diff --git a/dh.c b/dh.c index 0790aff7..afd1e05d 100644 --- a/dh.c +++ b/dh.c @@ -23,7 +23,7 @@ */ #include "includes.h" -RCSID("$OpenBSD: dh.c,v 1.28 2004/02/27 22:44:56 dtucker Exp $"); +RCSID("$OpenBSD: dh.c,v 1.29 2004/02/27 22:49:27 dtucker Exp $"); #include "xmalloc.h" @@ -197,7 +197,7 @@ dh_pub_is_valid(DH *dh, BIGNUM *dh_pub) void dh_gen_key(DH *dh, int need) { - int i, bits_set = 0, tries = 0; + int i, bits_set, tries = 0; if (dh->p == NULL) fatal("dh_gen_key: dh->p == NULL"); @@ -214,7 +214,7 @@ dh_gen_key(DH *dh, int need) fatal("dh_gen_key: BN_rand failed"); if (DH_generate_key(dh) == 0) fatal("DH_generate_key"); - for (i = 0; i <= BN_num_bits(dh->priv_key); i++) + for (i = 0, bits_set = 0; i <= BN_num_bits(dh->priv_key); i++) if (BN_is_bit_set(dh->priv_key, i)) bits_set++; debug2("dh_gen_key: priv key bits set: %d/%d", -- 2.45.2