From: tim <tim>
Date: Fri, 14 Mar 2008 01:21:06 +0000 (+0000)
Subject:  - (tim) [regress/sftp-cmds.sh regress/ssh2putty.sh] Shell portability fixes
X-Git-Tag: V_4_9_P1~24
X-Git-Url: http://andersk.mit.edu/gitweb/openssh.git/commitdiff_plain/575a5eced126099bed926a05ff174b7a8c9f1612

 - (tim) [regress/sftp-cmds.sh regress/ssh2putty.sh] Shell portability fixes
   from imorgan at nas.nasa.gov
---

diff --git a/ChangeLog b/ChangeLog
index c45329cf..37391cc5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,8 @@
    puttygen(1) by $PATH
  - (tim) [scp.c] Use poll.h if available, fall back to sys/poll.h if not. Patch
    by vinschen at redhat.com.
+ - (tim) [regress/sftp-cmds.sh regress/ssh2putty.sh] Shell portability fixes
+   from imorgan at nas.nasa.gov
 
 20080312
  - (djm) OpenBSD CVS Sync
diff --git a/regress/sftp-cmds.sh b/regress/sftp-cmds.sh
index a9bf5047..3cd7e6b4 100644
--- a/regress/sftp-cmds.sh
+++ b/regress/sftp-cmds.sh
@@ -44,12 +44,12 @@ rm -rf ${COPY} ${COPY}.1 ${COPY}.2 ${COPY}.dd ${COPY}.dd2
 mkdir ${COPY}.dd
 
 verbose "$tid: lls"
-echo "cd ${OBJ}\nlls" | ${SFTP} -P ${SFTPSERVER} 2>&1 | \
-	grep -q copy.dd || fail "lls failed"
+echo "cd ${OBJ}" ; echo "lls" | ${SFTP} -P ${SFTPSERVER} 2>&1 | \
+	grep copy.dd >/dev/null 2>&1 || fail "lls failed"
 
 verbose "$tid: lls w/path"
 echo "lls ${OBJ}" | ${SFTP} -P ${SFTPSERVER} 2>&1 | \
-	grep -q copy.dd || fail "lls w/path failed"
+	grep copy.dd >/dev/null 2>&1 || fail "lls w/path failed"
 
 verbose "$tid: ls"
 echo "ls ${OBJ}" | ${SFTP} -P ${SFTPSERVER} >/dev/null 2>&1 \
diff --git a/regress/ssh2putty.sh b/regress/ssh2putty.sh
index 82dd4478..dfdeeff4 100755
--- a/regress/ssh2putty.sh
+++ b/regress/ssh2putty.sh
@@ -10,7 +10,9 @@ PORT=$2
 KEYFILE=$3
 
 # XXX - support DSA keys too
-if ! grep -q "BEGIN RSA PRIVATE KEY" $KEYFILE ; then
+if grep "BEGIN RSA PRIVATE KEY" $KEYFILE >/dev/null 2>&1 ; then
+	:
+else
 	echo "Unsupported private key format"
 	exit 1
 fi