]> andersk Git - openssh.git/blobdiff - clientloop.c
- markus@cvs.openbsd.org 2001/06/04 23:07:21
[openssh.git] / clientloop.c
index d761897385c7e77c9ccd7f3238ac73411a02c32e..3a1b43dda3d898bf8447e3a9d2aff43d4556cb6e 100644 (file)
@@ -59,7 +59,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: clientloop.c,v 1.66 2001/04/29 19:16:52 markus Exp $");
+RCSID("$OpenBSD: clientloop.c,v 1.75 2001/06/04 23:07:20 markus Exp $");
 
 #include "ssh.h"
 #include "ssh1.h"
@@ -102,6 +102,7 @@ extern char *host;
  * because this is updated in a signal handler.
  */
 static volatile int received_window_change_signal = 0;
+static volatile int received_signal = 0;
 
 /* Flag indicating whether the user\'s terminal is in non-blocking mode. */
 static int in_non_blocking_mode = 0;
@@ -171,13 +172,8 @@ window_change_handler(int sig)
 void
 signal_handler(int sig)
 {
-       if (in_raw_mode())
-               leave_raw_mode();
-       if (in_non_blocking_mode)
-               leave_non_blocking();
-       channel_stop_listening();
-       packet_close();
-       fatal("Killed by signal %d.", sig);
+       received_signal = sig;
+       quit_pending = 1;
 }
 
 /*
@@ -346,7 +342,13 @@ client_wait_until_can_do_something(fd_set **readsetp, fd_set **writesetp,
                if (buffer_len(&stderr_buffer) > 0)
                        FD_SET(fileno(stderr), *writesetp);
        } else {
-               FD_SET(connection_in, *readsetp);
+               /* channel_prepare_select could have closed the last channel */
+               if (session_closed && !channel_still_open()) {
+                       if (!packet_have_data_to_write())
+                               return;
+               } else {
+                       FD_SET(connection_in, *readsetp);
+               }
        }
 
        /* Select server connection if have data to write to the server. */
@@ -566,7 +568,7 @@ process_escapes(Buffer *bin, Buffer *bout, Buffer *berr, char *buf, int len)
 "%c?\r\n\
 Supported escape sequences:\r\n\
 ~.  - terminate connection\r\n\
-~R - Request rekey (SSH protocol 2 only)\r\n\
+~R  - Request rekey (SSH protocol 2 only)\r\n\
 ~^Z - suspend ssh\r\n\
 ~#  - list forwarded connections\r\n\
 ~&  - background ssh (when waiting for connections to terminate)\r\n\
@@ -651,7 +653,7 @@ client_process_input(fd_set * readset)
                                packet_start(SSH_CMSG_EOF);
                                packet_send();
                        }
-               } else if (escape_char == -1) {
+               } else if (escape_char == SSH_ESCAPECHAR_NONE) {
                        /*
                         * Normal successful read, and no escape character.
                         * Just append the data to buffer.
@@ -759,8 +761,8 @@ client_channel_closed(int id, void *arg)
 /*
  * Implements the interactive session with the server.  This is called after
  * the user has been authenticated, and a command has been started on the
- * remote host.  If escape_char != -1, it is the character used as an escape
- * character for terminating or suspending the session.
+ * remote host.  If escape_char != SSH_ESCAPECHAR_NONE, it is the character
+ * used as an escape character for terminating or suspending the session.
  */
 
 int
@@ -823,7 +825,7 @@ client_loop(int have_pty, int escape_char_arg, int ssh2_chan_id)
 
        if (compat20) {
                session_ident = ssh2_chan_id;
-               if (escape_char != -1)
+               if (escape_char != SSH_ESCAPECHAR_NONE)
                        channel_register_filter(session_ident,
                            simple_escape_filter);
                if (session_ident != -1)
@@ -927,6 +929,23 @@ client_loop(int have_pty, int escape_char_arg, int ssh2_chan_id)
        /* Stop listening for connections. */
        channel_stop_listening();
 
+       if (have_pty)
+               leave_raw_mode();
+
+       /* restore blocking io */
+       if (!isatty(fileno(stdin)))
+               unset_nonblock(fileno(stdin));
+       if (!isatty(fileno(stdout)))
+               unset_nonblock(fileno(stdout));
+       if (!isatty(fileno(stderr)))
+               unset_nonblock(fileno(stderr));
+
+       if (received_signal) {
+               if (in_non_blocking_mode)       /* XXX */
+                       leave_non_blocking();
+               fatal("Killed by signal %d.", received_signal);
+       }
+
        /*
         * In interactive mode (with pseudo tty) display a message indicating
         * that the connection has been closed.
@@ -935,6 +954,7 @@ client_loop(int have_pty, int escape_char_arg, int ssh2_chan_id)
                snprintf(buf, sizeof buf, "Connection to %.64s closed.\r\n", host);
                buffer_append(&stderr_buffer, buf, strlen(buf));
        }
+
        /* Output any buffered data for stdout. */
        while (buffer_len(&stdout_buffer) > 0) {
                len = write(fileno(stdout), buffer_ptr(&stdout_buffer),
@@ -959,9 +979,6 @@ client_loop(int have_pty, int escape_char_arg, int ssh2_chan_id)
                stderr_bytes += len;
        }
 
-       if (have_pty)
-               leave_raw_mode();
-
        /* Clear and free any buffers. */
        memset(buf, 0, sizeof(buf));
        buffer_free(&stdin_buffer);
@@ -1027,7 +1044,7 @@ client_request_forwarded_tcpip(const char *request_type, int rchan)
        Channel* c = NULL;
        char *listen_address, *originator_address;
        int listen_port, originator_port;
-       int sock, newch;
+       int sock;
 
        /* Get rest of the packet */
        listen_address = packet_get_string(NULL);
@@ -1040,12 +1057,18 @@ client_request_forwarded_tcpip(const char *request_type, int rchan)
            listen_address, listen_port, originator_address, originator_port);
 
        sock = channel_connect_by_listen_adress(listen_port);
-       if (sock >= 0) {
-               newch = channel_new("forwarded-tcpip",
-                   SSH_CHANNEL_CONNECTING, sock, sock, -1,
-                   CHAN_TCP_WINDOW_DEFAULT, CHAN_TCP_WINDOW_DEFAULT, 0,
-                   xstrdup(originator_address), 1);
-               c = channel_lookup(newch);
+       if (sock < 0) {
+               xfree(originator_address);
+               xfree(listen_address);
+               return NULL;
+       }
+       c = channel_new("forwarded-tcpip",
+           SSH_CHANNEL_CONNECTING, sock, sock, -1,
+           CHAN_TCP_WINDOW_DEFAULT, CHAN_TCP_WINDOW_DEFAULT, 0,
+           xstrdup(originator_address), 1);
+       if (c == NULL) {
+               error("client_request_forwarded_tcpip: channel_new failed");
+               close(sock);
        }
        xfree(originator_address);
        xfree(listen_address);
@@ -1058,7 +1081,7 @@ client_request_x11(const char *request_type, int rchan)
        Channel *c = NULL;
        char *originator;
        int originator_port;
-       int sock, newch;
+       int sock;
 
        if (!options.forward_x11) {
                error("Warning: ssh server tried X11 forwarding.");
@@ -1076,15 +1099,18 @@ client_request_x11(const char *request_type, int rchan)
        /* XXX check permission */
        debug("client_request_x11: request from %s %d", originator,
            originator_port);
+       xfree(originator);
        sock = x11_connect_display();
-       if (sock >= 0) {
-               newch = channel_new("x11",
-                   SSH_CHANNEL_X11_OPEN, sock, sock, -1,
-                   CHAN_TCP_WINDOW_DEFAULT, CHAN_X11_PACKET_DEFAULT, 0,
-                   xstrdup("x11"), 1);
-               c = channel_lookup(newch);
+       if (sock < 0)
+               return NULL;
+       c = channel_new("x11",
+           SSH_CHANNEL_X11_OPEN, sock, sock, -1,
+           CHAN_TCP_WINDOW_DEFAULT, CHAN_X11_PACKET_DEFAULT, 0,
+           xstrdup("x11"), 1);
+       if (c == NULL) {
+               error("client_request_x11: channel_new failed");
+               close(sock);
        }
-       xfree(originator);
        return c;
 }
 
@@ -1092,7 +1118,7 @@ Channel*
 client_request_agent(const char *request_type, int rchan)
 {
        Channel *c = NULL;
-       int sock, newch;
+       int sock;
 
        if (!options.forward_agent) {
                error("Warning: ssh server tried agent forwarding.");
@@ -1100,12 +1126,15 @@ client_request_agent(const char *request_type, int rchan)
                return NULL;
        }
        sock =  ssh_get_authentication_socket();
-       if (sock >= 0) {
-               newch = channel_new("authentication agent connection",
-                   SSH_CHANNEL_OPEN, sock, sock, -1,
-                   CHAN_X11_WINDOW_DEFAULT, CHAN_TCP_WINDOW_DEFAULT, 0,
-                   xstrdup("authentication agent connection"), 1);
-               c = channel_lookup(newch);
+       if (sock < 0)
+               return NULL;
+       c = channel_new("authentication agent connection",
+           SSH_CHANNEL_OPEN, sock, sock, -1,
+           CHAN_X11_WINDOW_DEFAULT, CHAN_TCP_WINDOW_DEFAULT, 0,
+           xstrdup("authentication agent connection"), 1);
+       if (c == NULL) {
+               error("client_request_agent: channel_new failed");
+               close(sock);
        }
        return c;
 }
@@ -1142,20 +1171,21 @@ client_input_channel_open(int type, int plen, void *ctxt)
                c->remote_id = rchan;
                c->remote_window = rwindow;
                c->remote_maxpacket = rmaxpack;
-
-               packet_start(SSH2_MSG_CHANNEL_OPEN_CONFIRMATION);
-               packet_put_int(c->remote_id);
-               packet_put_int(c->self);
-               packet_put_int(c->local_window);
-               packet_put_int(c->local_maxpacket);
-               packet_send();
+               if (c->type != SSH_CHANNEL_CONNECTING) {
+                       packet_start(SSH2_MSG_CHANNEL_OPEN_CONFIRMATION);
+                       packet_put_int(c->remote_id);
+                       packet_put_int(c->self);
+                       packet_put_int(c->local_window);
+                       packet_put_int(c->local_maxpacket);
+                       packet_send();
+               }
        } else {
                debug("failure %s", ctype);
                packet_start(SSH2_MSG_CHANNEL_OPEN_FAILURE);
                packet_put_int(rchan);
                packet_put_int(SSH2_OPEN_ADMINISTRATIVELY_PROHIBITED);
                if (!(datafellows & SSH_BUG_OPENFAILURE)) {
-                       packet_put_cstring("bla bla");
+                       packet_put_cstring("open failed");
                        packet_put_cstring("");
                }
                packet_send();
This page took 0.549124 seconds and 4 git commands to generate.