]> andersk Git - openssh.git/blobdiff - sftp-int.c
[configure.ac] Make sure -lcrypto is before -lsocket for sco3. ok mouring@
[openssh.git] / sftp-int.c
index f77e2ebd91bb5b8607d78fb24df18c5721cbc791..3ee57515dcba371ce0da3bc63b29622ed3bbfe23 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2001 Damien Miller.  All rights reserved.
+ * Copyright (c) 2001,2002 Damien Miller.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-/* XXX: globbed ls */
 /* XXX: recursive operations */
 
 #include "includes.h"
-RCSID("$OpenBSD: sftp-int.c,v 1.30 2001/03/16 09:55:53 markus Exp $");
+RCSID("$OpenBSD: sftp-int.c,v 1.67 2004/01/23 17:57:48 mouring Exp $");
 
 #include "buffer.h"
 #include "xmalloc.h"
@@ -42,12 +41,25 @@ RCSID("$OpenBSD: sftp-int.c,v 1.30 2001/03/16 09:55:53 markus Exp $");
 /* File to read commands from */
 extern FILE *infile;
 
-/* Version of server we are speaking to */
-int version;
+/* Are we in batchfile mode? */
+extern int batchmode;
 
-/* Seperators for interactive commands */
+/* Size of buffer used when copying files */
+extern size_t copy_buffer_len;
+
+/* Number of concurrent outstanding requests */
+extern int num_requests;
+
+/* This is set to 0 if the progressmeter is not desired. */
+int showprogress = 1;
+
+/* Separators for interactive commands */
 #define WHITESPACE " \t\r\n"
 
+/* Define what type of ls view (0 - multi-column) */
+#define LONG_VIEW 1            /* Full view ala ls -l */
+#define SHORT_VIEW 2           /* Single row view ala ls -1 */
+
 /* Commands for interactive mode */
 #define I_CHDIR                1
 #define I_CHGRP                2
@@ -71,13 +83,15 @@ int version;
 #define I_SHELL                20
 #define I_SYMLINK      21
 #define I_VERSION      22
+#define I_PROGRESS     23
 
 struct CMD {
        const char *c;
        const int n;
 };
 
-const struct CMD cmds[] = {
+static const struct CMD cmds[] = {
+       { "bye",        I_QUIT },
        { "cd",         I_CHDIR },
        { "chdir",      I_CHDIR },
        { "chgrp",      I_CHGRP },
@@ -86,6 +100,7 @@ const struct CMD cmds[] = {
        { "dir",        I_LS },
        { "exit",       I_QUIT },
        { "get",        I_GET },
+       { "mget",       I_GET },
        { "help",       I_HELP },
        { "lcd",        I_LCHDIR },
        { "lchdir",     I_LCHDIR },
@@ -96,7 +111,9 @@ const struct CMD cmds[] = {
        { "ls",         I_LS },
        { "lumask",     I_LUMASK },
        { "mkdir",      I_MKDIR },
+       { "progress",   I_PROGRESS },
        { "put",        I_PUT },
+       { "mput",       I_PUT },
        { "pwd",        I_PWD },
        { "quit",       I_QUIT },
        { "rename",     I_RENAME },
@@ -109,7 +126,7 @@ const struct CMD cmds[] = {
        { NULL,                 -1}
 };
 
-void
+static void
 help(void)
 {
        printf("Available commands:\n");
@@ -127,6 +144,7 @@ help(void)
        printf("ls [path]                     Display remote directory listing\n");
        printf("lumask umask                  Set local umask to 'umask'\n");
        printf("mkdir path                    Create remote directory\n");
+       printf("progress                      Toggle display of progress meter\n");
        printf("put local-path [remote-path]  Upload file\n");
        printf("pwd                           Display remote working directory\n");
        printf("exit                          Quit sftp\n");
@@ -141,10 +159,10 @@ help(void)
        printf("?                             Synonym for help\n");
 }
 
-void
+static void
 local_do_shell(const char *args)
 {
-       int ret, status;
+       int status;
        char *shell;
        pid_t pid;
 
@@ -161,24 +179,25 @@ local_do_shell(const char *args)
                /* XXX: child has pipe fds to ssh subproc open - issue? */
                if (args) {
                        debug3("Executing %s -c \"%s\"", shell, args);
-                       ret = execl(shell, shell, "-c", args, NULL);
+                       execl(shell, shell, "-c", args, (char *)NULL);
                } else {
                        debug3("Executing %s", shell);
-                       ret = execl(shell, shell, NULL);
+                       execl(shell, shell, (char *)NULL);
                }
                fprintf(stderr, "Couldn't execute \"%s\": %s\n", shell,
                    strerror(errno));
                _exit(1);
        }
-       if (waitpid(pid, &status, 0) == -1)
-               fatal("Couldn't wait for child: %s", strerror(errno));
+       while (waitpid(pid, &status, 0) == -1)
+               if (errno != EINTR)
+                       fatal("Couldn't wait for child: %s", strerror(errno));
        if (!WIFEXITED(status))
                error("Shell exited abormally");
        else if (WEXITSTATUS(status))
                error("Shell exited with status %d", WEXITSTATUS(status));
 }
 
-void
+static void
 local_do_ls(const char *args)
 {
        if (!args || !*args)
@@ -194,20 +213,41 @@ local_do_ls(const char *args)
        }
 }
 
-char *
+/* Strip one path (usually the pwd) from the start of another */
+static char *
+path_strip(char *path, char *strip)
+{
+       size_t len;
+
+       if (strip == NULL)
+               return (xstrdup(path));
+
+       len = strlen(strip);
+       if (strip != NULL && strncmp(path, strip, len) == 0) {
+               if (strip[len - 1] != '/' && path[len] == '/')
+                       len++;
+               return (xstrdup(path + len));
+       }
+
+       return (xstrdup(path));
+}
+
+static char *
 path_append(char *p1, char *p2)
 {
        char *ret;
+       int len = strlen(p1) + strlen(p2) + 2;
 
-       ret = xmalloc(strlen(p1) + strlen(p2) + 2);
-       strcpy(ret, p1);
-       strcat(ret, "/");
-       strcat(ret, p2);
+       ret = xmalloc(len);
+       strlcpy(ret, p1, len);
+       if (p1[strlen(p1) - 1] != '/')
+               strlcat(ret, "/", len);
+       strlcat(ret, p2, len);
 
        return(ret);
 }
 
-char *
+static char *
 make_absolute(char *p, char *pwd)
 {
        char *abs;
@@ -221,7 +261,7 @@ make_absolute(char *p, char *pwd)
                return(p);
 }
 
-int
+static int
 infer_path(const char *p, char **ifp)
 {
        char *cp;
@@ -241,7 +281,7 @@ infer_path(const char *p, char **ifp)
        return(0);
 }
 
-int
+static int
 parse_getput_flags(const char **cpp, int *pflag)
 {
        const char *cp = *cpp;
@@ -264,12 +304,38 @@ parse_getput_flags(const char **cpp, int *pflag)
        return(0);
 }
 
-int
+static int
+parse_ls_flags(const char **cpp, int *lflag)
+{
+       const char *cp = *cpp;
+
+       /* Check for flags */
+       if (cp++[0] == '-') {
+               for(; strchr(WHITESPACE, *cp) == NULL; cp++) {
+                       switch (*cp) {
+                       case 'l':
+                               *lflag = LONG_VIEW;
+                               break;
+                       case '1':
+                               *lflag = SHORT_VIEW;
+                               break;
+                       default:
+                               error("Invalid flag -%c", *cp);
+                               return(-1);
+                       }
+               }
+               *cpp = cp + strspn(cp, WHITESPACE);
+       }
+
+       return(0);
+}
+
+static int
 get_pathname(const char **cpp, char **path)
 {
        const char *cp = *cpp, *end;
        char quot;
-       int i;
+       int i, j;
 
        cp += strspn(cp, WHITESPACE);
        if (!*cp) {
@@ -278,41 +344,59 @@ get_pathname(const char **cpp, char **path)
                return (0);
        }
 
+       *path = xmalloc(strlen(cp) + 1);
+
        /* Check for quoted filenames */
        if (*cp == '\"' || *cp == '\'') {
                quot = *cp++;
 
-               end = strchr(cp, quot);
-               if (end == NULL) {
-                       error("Unterminated quote");
-                       goto fail;
+               /* Search for terminating quote, unescape some chars */
+               for (i = j = 0; i <= strlen(cp); i++) {
+                       if (cp[i] == quot) {    /* Found quote */
+                               i++;
+                               (*path)[j] = '\0';
+                               break;
+                       }
+                       if (cp[i] == '\0') {    /* End of string */
+                               error("Unterminated quote");
+                               goto fail;
+                       }
+                       if (cp[i] == '\\') {    /* Escaped characters */
+                               i++;
+                               if (cp[i] != '\'' && cp[i] != '\"' &&
+                                   cp[i] != '\\') {
+                                       error("Bad escaped character '\%c'",
+                                           cp[i]);
+                                       goto fail;
+                               }
+                       }
+                       (*path)[j++] = cp[i];
                }
-               if (cp == end) {
+
+               if (j == 0) {
                        error("Empty quotes");
                        goto fail;
                }
-               *cpp = end + 1 + strspn(end + 1, WHITESPACE);
+               *cpp = cp + i + strspn(cp + i, WHITESPACE);
        } else {
                /* Read to end of filename */
                end = strpbrk(cp, WHITESPACE);
                if (end == NULL)
                        end = strchr(cp, '\0');
                *cpp = end + strspn(end, WHITESPACE);
-       }
-
-       i = end - cp;
 
-       *path = xmalloc(i + 1);
-       memcpy(*path, cp, i);
-       (*path)[i] = '\0';
-       return(0);
+               memcpy(*path, cp, end - cp);
+               (*path)[end - cp] = '\0';
+       }
+       return (0);
 
  fail:
+       xfree(*path);
        *path = NULL;
        return (-1);
 }
 
-int
+static int
 is_dir(char *path)
 {
        struct stat sb;
@@ -324,21 +408,32 @@ is_dir(char *path)
        return(sb.st_mode & S_IFDIR);
 }
 
-int
-remote_is_dir(int in, int out, char *path)
+static int
+is_reg(char *path)
+{
+       struct stat sb;
+
+       if (stat(path, &sb) == -1)
+               fatal("stat %s: %s", path, strerror(errno));
+
+       return(S_ISREG(sb.st_mode));
+}
+
+static int
+remote_is_dir(struct sftp_conn *conn, char *path)
 {
        Attrib *a;
 
        /* XXX: report errors? */
-       if ((a = do_stat(in, out, path, 1)) == NULL)
+       if ((a = do_stat(conn, path, 1)) == NULL)
                return(0);
        if (!(a->flags & SSH2_FILEXFER_ATTR_PERMISSIONS))
                return(0);
        return(a->perm & S_IFDIR);
 }
 
-int
-process_get(int in, int out, char *src, char *dst, char *pwd, int pflag)
+static int
+process_get(struct sftp_conn *conn, char *src, char *dst, char *pwd, int pflag)
 {
        char *abs_src = NULL;
        char *abs_dst = NULL;
@@ -352,55 +447,45 @@ process_get(int in, int out, char *src, char *dst, char *pwd, int pflag)
 
        memset(&g, 0, sizeof(g));
        debug3("Looking up %s", abs_src);
-       if (remote_glob(in, out, abs_src, 0, NULL, &g)) {
+       if (remote_glob(conn, abs_src, 0, NULL, &g)) {
                error("File \"%s\" not found.", abs_src);
                err = -1;
                goto out;
        }
 
-       /* Only one match, dst may be file, directory or unspecified */
-       if (g.gl_pathv[0] && g.gl_matchc == 1) {
-               if (dst) {
-                       /* If directory specified, append filename */
-                       if (is_dir(dst)) {
-                               if (infer_path(g.gl_pathv[0], &tmp)) {
-                                       err = 1;
-                                       goto out;
-                               }
-                               abs_dst = path_append(dst, tmp);
-                               xfree(tmp);
-                       } else
-                               abs_dst = xstrdup(dst);
-               } else if (infer_path(g.gl_pathv[0], &abs_dst)) {
-                       err = -1;
-                       goto out;
-               }
-               printf("Fetching %s to %s\n", g.gl_pathv[0], abs_dst);
-               err = do_download(in, out, g.gl_pathv[0], abs_dst, pflag);
-               goto out;
-       }
-
-       /* Multiple matches, dst may be directory or unspecified */
-       if (dst && !is_dir(dst)) {
+       /* If multiple matches, dst must be a directory or unspecified */
+       if (g.gl_matchc > 1 && dst && !is_dir(dst)) {
                error("Multiple files match, but \"%s\" is not a directory",
                    dst);
                err = -1;
                goto out;
        }
 
-       for(i = 0; g.gl_pathv[i]; i++) {
+       for (i = 0; g.gl_pathv[i]; i++) {
                if (infer_path(g.gl_pathv[i], &tmp)) {
                        err = -1;
                        goto out;
                }
-               if (dst) {
+
+               if (g.gl_matchc == 1 && dst) {
+                       /* If directory specified, append filename */
+                       if (is_dir(dst)) {
+                               if (infer_path(g.gl_pathv[0], &tmp)) {
+                                       err = 1;
+                                       goto out;
+                               }
+                               abs_dst = path_append(dst, tmp);
+                               xfree(tmp);
+                       } else
+                               abs_dst = xstrdup(dst);
+               } else if (dst) {
                        abs_dst = path_append(dst, tmp);
                        xfree(tmp);
                } else
                        abs_dst = tmp;
 
                printf("Fetching %s to %s\n", g.gl_pathv[i], abs_dst);
-               if (do_download(in, out, g.gl_pathv[i], abs_dst, pflag) == -1)
+               if (do_download(conn, g.gl_pathv[i], abs_dst, pflag) == -1)
                        err = -1;
                xfree(abs_dst);
                abs_dst = NULL;
@@ -414,8 +499,8 @@ out:
        return(err);
 }
 
-int
-process_put(int in, int out, char *src, char *dst, char *pwd, int pflag)
+static int
+process_put(struct sftp_conn *conn, char *src, char *dst, char *pwd, int pflag)
 {
        char *tmp_dst = NULL;
        char *abs_dst = NULL;
@@ -437,49 +522,45 @@ process_put(int in, int out, char *src, char *dst, char *pwd, int pflag)
                goto out;
        }
 
-       /* Only one match, dst may be file, directory or unspecified */
-       if (g.gl_pathv[0] && g.gl_matchc == 1) {
-               if (tmp_dst) {
-                       /* If directory specified, append filename */
-                       if (remote_is_dir(in, out, tmp_dst)) {
-                               if (infer_path(g.gl_pathv[0], &tmp)) {
-                                       err = 1;
-                                       goto out;
-                               }
-                               abs_dst = path_append(tmp_dst, tmp);
-                               xfree(tmp);
-                       } else
-                               abs_dst = xstrdup(tmp_dst);
-               } else if (infer_path(g.gl_pathv[0], &abs_dst)) {
-                       err = -1;
-                       goto out;
-               }
-               printf("Uploading %s to %s\n", g.gl_pathv[0], abs_dst);
-               err = do_upload(in, out, g.gl_pathv[0], abs_dst, pflag);
-               goto out;
-       }
-
-       /* Multiple matches, dst may be directory or unspecified */
-       if (tmp_dst && !remote_is_dir(in, out, tmp_dst)) {
+       /* If multiple matches, dst may be directory or unspecified */
+       if (g.gl_matchc > 1 && tmp_dst && !remote_is_dir(conn, tmp_dst)) {
                error("Multiple files match, but \"%s\" is not a directory",
                    tmp_dst);
                err = -1;
                goto out;
        }
 
-       for(i = 0; g.gl_pathv[i]; i++) {
+       for (i = 0; g.gl_pathv[i]; i++) {
+               if (!is_reg(g.gl_pathv[i])) {
+                       error("skipping non-regular file %s",
+                           g.gl_pathv[i]);
+                       continue;
+               }
                if (infer_path(g.gl_pathv[i], &tmp)) {
                        err = -1;
                        goto out;
                }
-               if (tmp_dst) {
+
+               if (g.gl_matchc == 1 && tmp_dst) {
+                       /* If directory specified, append filename */
+                       if (remote_is_dir(conn, tmp_dst)) {
+                               if (infer_path(g.gl_pathv[0], &tmp)) {
+                                       err = 1;
+                                       goto out;
+                               }
+                               abs_dst = path_append(tmp_dst, tmp);
+                               xfree(tmp);
+                       } else
+                               abs_dst = xstrdup(tmp_dst);
+
+               } else if (tmp_dst) {
                        abs_dst = path_append(tmp_dst, tmp);
                        xfree(tmp);
                } else
                        abs_dst = make_absolute(tmp, pwd);
 
                printf("Uploading %s to %s\n", g.gl_pathv[i], abs_dst);
-               if (do_upload(in, out, g.gl_pathv[i], abs_dst, pflag) == -1)
+               if (do_upload(conn, g.gl_pathv[i], abs_dst, pflag) == -1)
                        err = -1;
        }
 
@@ -488,12 +569,185 @@ out:
                xfree(abs_dst);
        if (tmp_dst)
                xfree(tmp_dst);
+       globfree(&g);
        return(err);
 }
 
-int
-parse_args(const char **cpp, int *pflag, unsigned long *n_arg,
-    char **path1, char **path2)
+static int
+sdirent_comp(const void *aa, const void *bb)
+{
+       SFTP_DIRENT *a = *(SFTP_DIRENT **)aa;
+       SFTP_DIRENT *b = *(SFTP_DIRENT **)bb;
+
+       return (strcmp(a->filename, b->filename));
+}
+
+/* sftp ls.1 replacement for directories */
+static int
+do_ls_dir(struct sftp_conn *conn, char *path, char *strip_path, int lflag)
+{
+       int n, c = 1, colspace = 0, columns = 1;
+       SFTP_DIRENT **d;
+
+       if ((n = do_readdir(conn, path, &d)) != 0)
+               return (n);
+
+       if (!(lflag & SHORT_VIEW)) {
+               int m = 0, width = 80;
+               struct winsize ws;
+               char *tmp;
+
+               /* Count entries for sort and find longest filename */
+               for (n = 0; d[n] != NULL; n++)
+                       m = MAX(m, strlen(d[n]->filename));
+
+               /* Add any subpath that also needs to be counted */
+               tmp = path_strip(path, strip_path);
+               m += strlen(tmp);
+               xfree(tmp);
+
+               if (ioctl(fileno(stdin), TIOCGWINSZ, &ws) != -1)
+                       width = ws.ws_col;
+
+               columns = width / (m + 2);
+               columns = MAX(columns, 1);
+               colspace = width / columns;
+               colspace = MIN(colspace, width);
+       }
+
+       qsort(d, n, sizeof(*d), sdirent_comp);
+
+       for (n = 0; d[n] != NULL; n++) {
+               char *tmp, *fname;
+
+               tmp = path_append(path, d[n]->filename);
+               fname = path_strip(tmp, strip_path);
+               xfree(tmp);
+
+               if (lflag & LONG_VIEW) {
+                       char *lname;
+                       struct stat sb;
+
+                       memset(&sb, 0, sizeof(sb));
+                       attrib_to_stat(&d[n]->a, &sb);
+                       lname = ls_file(fname, &sb, 1);
+                       printf("%s\n", lname);
+                       xfree(lname);
+               } else {
+                       printf("%-*s", colspace, fname);
+                       if (c >= columns) {
+                               printf("\n");
+                               c = 1;
+                       } else
+                               c++;
+               }
+
+               xfree(fname);
+       }
+
+       if (!(lflag & LONG_VIEW) && (c != 1))
+               printf("\n");
+
+       free_sftp_dirents(d);
+       return (0);
+}
+
+/* sftp ls.1 replacement which handles path globs */
+static int
+do_globbed_ls(struct sftp_conn *conn, char *path, char *strip_path,
+    int lflag)
+{
+       glob_t g;
+       int i, c = 1, colspace = 0, columns = 1;
+       Attrib *a;
+
+       memset(&g, 0, sizeof(g));
+
+       if (remote_glob(conn, path, GLOB_MARK|GLOB_NOCHECK|GLOB_BRACE,
+           NULL, &g)) {
+               error("Can't ls: \"%s\" not found", path);
+               return (-1);
+       }
+
+       /*
+        * If the glob returns a single match, which is the same as the
+        * input glob, and it is a directory, then just list its contents
+        */
+       if (g.gl_pathc == 1 &&
+           strncmp(path, g.gl_pathv[0], strlen(g.gl_pathv[0]) - 1) == 0) {
+               if ((a = do_lstat(conn, path, 1)) == NULL) {
+                       globfree(&g);
+                       return (-1);
+               }
+               if ((a->flags & SSH2_FILEXFER_ATTR_PERMISSIONS) &&
+                   S_ISDIR(a->perm)) {
+                       globfree(&g);
+                       return (do_ls_dir(conn, path, strip_path, lflag));
+               }
+       }
+
+       if (!(lflag & SHORT_VIEW)) {
+               int m = 0, width = 80;
+               struct winsize ws;
+
+               /* Count entries for sort and find longest filename */
+               for (i = 0; g.gl_pathv[i]; i++)
+                       m = MAX(m, strlen(g.gl_pathv[i]));
+
+               if (ioctl(fileno(stdin), TIOCGWINSZ, &ws) != -1)
+                       width = ws.ws_col;
+
+               columns = width / (m + 2);
+               columns = MAX(columns, 1);
+               colspace = width / columns;
+       }
+
+       for (i = 0; g.gl_pathv[i]; i++) {
+               char *fname;
+
+               fname = path_strip(g.gl_pathv[i], strip_path);
+
+               if (lflag & LONG_VIEW) {
+                       char *lname;
+                       struct stat sb;
+
+                       /*
+                        * XXX: this is slow - 1 roundtrip per path
+                        * A solution to this is to fork glob() and
+                        * build a sftp specific version which keeps the
+                        * attribs (which currently get thrown away)
+                        * that the server returns as well as the filenames.
+                        */
+                       memset(&sb, 0, sizeof(sb));
+                       a = do_lstat(conn, g.gl_pathv[i], 1);
+                       if (a != NULL)
+                               attrib_to_stat(a, &sb);
+                       lname = ls_file(fname, &sb, 1);
+                       printf("%s\n", lname);
+                       xfree(lname);
+               } else {
+                       printf("%-*s", colspace, fname);
+                       if (c >= columns) {
+                               printf("\n");
+                               c = 1;
+                       } else
+                               c++;
+               }
+               xfree(fname);
+       }
+
+       if (!(lflag & LONG_VIEW) && (c != 1))
+               printf("\n");
+
+       if (g.gl_pathc)
+               globfree(&g);
+
+       return (0);
+}
+
+static int
+parse_args(const char **cpp, int *pflag, int *lflag, int *iflag,
+    unsigned long *n_arg, char **path1, char **path2)
 {
        const char *cmd, *cp = *cpp;
        char *cp2;
@@ -504,12 +758,19 @@ parse_args(const char **cpp, int *pflag, unsigned long *n_arg,
        /* Skip leading whitespace */
        cp = cp + strspn(cp, WHITESPACE);
 
-       /* Ignore blank lines */
-       if (!*cp)
-               return(-1);
+       /* Ignore blank lines and lines which begin with comment '#' char */
+       if (*cp == '\0' || *cp == '#')
+               return (0);
+
+       /* Check for leading '-' (disable error processing) */
+       *iflag = 0;
+       if (*cp == '-') {
+               *iflag = 1;
+               cp++;
+       }
 
        /* Figure out which command we have */
-       for(i = 0; cmds[i].c; i++) {
+       for (i = 0; cmds[i].c; i++) {
                int cmdlen = strlen(cmds[i].c);
 
                /* Check for command followed by whitespace */
@@ -529,11 +790,11 @@ parse_args(const char **cpp, int *pflag, unsigned long *n_arg,
                cmdnum = I_SHELL;
        } else if (cmdnum == -1) {
                error("Invalid command.");
-               return(-1);
+               return (-1);
        }
 
        /* Get arguments and parse flags */
-       *pflag = *n_arg = 0;
+       *lflag = *pflag = *n_arg = 0;
        *path1 = *path2 = NULL;
        switch (cmdnum) {
        case I_GET:
@@ -580,6 +841,8 @@ parse_args(const char **cpp, int *pflag, unsigned long *n_arg,
                }
                break;
        case I_LS:
+               if (parse_ls_flags(&cp, lflag))
+                       return(-1);
                /* Path is optional */
                if (get_pathname(&cp, path1))
                        return(-1);
@@ -627,6 +890,7 @@ parse_args(const char **cpp, int *pflag, unsigned long *n_arg,
        case I_LPWD:
        case I_HELP:
        case I_VERSION:
+       case I_PROGRESS:
                break;
        default:
                fatal("Command not implemented");
@@ -636,11 +900,12 @@ parse_args(const char **cpp, int *pflag, unsigned long *n_arg,
        return(cmdnum);
 }
 
-int
-parse_dispatch_command(int in, int out, const char *cmd, char **pwd)
+static int
+parse_dispatch_command(struct sftp_conn *conn, const char *cmd, char **pwd,
+    int err_abort)
 {
        char *path1, *path2, *tmp;
-       int pflag, cmdnum, i;
+       int pflag, lflag, iflag, cmdnum, i;
        unsigned long n_arg;
        Attrib a, *aa;
        char path_buf[MAXPATHLEN];
@@ -648,42 +913,46 @@ parse_dispatch_command(int in, int out, const char *cmd, char **pwd)
        glob_t g;
 
        path1 = path2 = NULL;
-       cmdnum = parse_args(&cmd, &pflag, &n_arg, &path1, &path2);
+       cmdnum = parse_args(&cmd, &pflag, &lflag, &iflag, &n_arg,
+           &path1, &path2);
+
+       if (iflag != 0)
+               err_abort = 0;
 
        memset(&g, 0, sizeof(g));
 
        /* Perform command */
        switch (cmdnum) {
+       case 0:
+               /* Blank line */
+               break;
        case -1:
+               /* Unrecognized command */
+               err = -1;
                break;
        case I_GET:
-               err = process_get(in, out, path1, path2, *pwd, pflag);
+               err = process_get(conn, path1, path2, *pwd, pflag);
                break;
        case I_PUT:
-               err = process_put(in, out, path1, path2, *pwd, pflag);
-               break;
-       case I_RENAME:
+               err = process_put(conn, path1, path2, *pwd, pflag);
+               break;
+       case I_RENAME:
                path1 = make_absolute(path1, *pwd);
                path2 = make_absolute(path2, *pwd);
-               err = do_rename(in, out, path1, path2);
+               err = do_rename(conn, path1, path2);
                break;
        case I_SYMLINK:
-               if (version < 3) {
-                       error("The server (version %d) does not support "
-                           "this operation", version);
-                       err = -1;
-               } else {
-                       path2 = make_absolute(path2, *pwd);
-                       err = do_symlink(in, out, path1, path2);
-               }
+               path2 = make_absolute(path2, *pwd);
+               err = do_symlink(conn, path1, path2);
                break;
        case I_RM:
                path1 = make_absolute(path1, *pwd);
-               remote_glob(in, out, path1, GLOB_NOCHECK, NULL, &g);
-               for(i = 0; g.gl_pathv[i]; i++) {
+               remote_glob(conn, path1, GLOB_NOCHECK, NULL, &g);
+               for (i = 0; g.gl_pathv[i]; i++) {
                        printf("Removing %s\n", g.gl_pathv[i]);
-                       if (do_rm(in, out, g.gl_pathv[i]) == -1)
-                               err = -1;
+                       err = do_rm(conn, g.gl_pathv[i]);
+                       if (err != 0 && err_abort)
+                               break;
                }
                break;
        case I_MKDIR:
@@ -691,19 +960,19 @@ parse_dispatch_command(int in, int out, const char *cmd, char **pwd)
                attrib_clear(&a);
                a.flags |= SSH2_FILEXFER_ATTR_PERMISSIONS;
                a.perm = 0777;
-               err = do_mkdir(in, out, path1, &a);
+               err = do_mkdir(conn, path1, &a);
                break;
        case I_RMDIR:
                path1 = make_absolute(path1, *pwd);
-               err = do_rmdir(in, out, path1);
+               err = do_rmdir(conn, path1);
                break;
        case I_CHDIR:
                path1 = make_absolute(path1, *pwd);
-               if ((tmp = do_realpath(in, out, path1)) == NULL) {
+               if ((tmp = do_realpath(conn, path1)) == NULL) {
                        err = 1;
                        break;
                }
-               if ((aa = do_stat(in, out, tmp, 0)) == NULL) {
+               if ((aa = do_stat(conn, tmp, 0)) == NULL) {
                        xfree(tmp);
                        err = 1;
                        break;
@@ -726,22 +995,17 @@ parse_dispatch_command(int in, int out, const char *cmd, char **pwd)
                break;
        case I_LS:
                if (!path1) {
-                       do_ls(in, out, *pwd);
+                       do_globbed_ls(conn, *pwd, *pwd, lflag);
                        break;
                }
+
+               /* Strip pwd off beginning of non-absolute paths */
+               tmp = NULL;
+               if (*path1 != '/')
+                       tmp = *pwd;
+
                path1 = make_absolute(path1, *pwd);
-               if ((tmp = do_realpath(in, out, path1)) == NULL)
-                       break;
-               xfree(path1);
-               path1 = tmp;
-               if ((aa = do_stat(in, out, path1, 0)) == NULL)
-                       break;
-               if ((aa->flags & SSH2_FILEXFER_ATTR_PERMISSIONS) &&
-                   !S_ISDIR(aa->perm)) {
-                       error("Can't ls: \"%s\" is not a directory", path1);
-                       break;
-               }
-               do_ls(in, out, path1);
+               err = do_globbed_ls(conn, path1, tmp, lflag);
                break;
        case I_LCHDIR:
                if (chdir(path1) == -1) {
@@ -772,64 +1036,72 @@ parse_dispatch_command(int in, int out, const char *cmd, char **pwd)
                attrib_clear(&a);
                a.flags |= SSH2_FILEXFER_ATTR_PERMISSIONS;
                a.perm = n_arg;
-               remote_glob(in, out, path1, GLOB_NOCHECK, NULL, &g);
-               for(i = 0; g.gl_pathv[i]; i++) {
+               remote_glob(conn, path1, GLOB_NOCHECK, NULL, &g);
+               for (i = 0; g.gl_pathv[i]; i++) {
                        printf("Changing mode on %s\n", g.gl_pathv[i]);
-                       do_setstat(in, out, g.gl_pathv[i], &a);
+                       err = do_setstat(conn, g.gl_pathv[i], &a);
+                       if (err != 0 && err_abort)
+                               break;
                }
                break;
        case I_CHOWN:
-               path1 = make_absolute(path1, *pwd);
-               remote_glob(in, out, path1, GLOB_NOCHECK, NULL, &g);
-               for(i = 0; g.gl_pathv[i]; i++) {
-                       if (!(aa = do_stat(in, out, g.gl_pathv[i], 0)))
-                               continue;
-                       if (!(aa->flags & SSH2_FILEXFER_ATTR_UIDGID)) {
-                               error("Can't get current ownership of "
-                                   "remote file \"%s\"", g.gl_pathv[i]);
-                               continue;
-                       }
-                       printf("Changing owner on %s\n", g.gl_pathv[i]);
-                       aa->flags &= SSH2_FILEXFER_ATTR_UIDGID;
-                       aa->uid = n_arg;
-                       do_setstat(in, out, g.gl_pathv[i], aa);
-               }
-               break;
        case I_CHGRP:
                path1 = make_absolute(path1, *pwd);
-               remote_glob(in, out, path1, GLOB_NOCHECK, NULL, &g);
-               for(i = 0; g.gl_pathv[i]; i++) {
-                       if (!(aa = do_stat(in, out, g.gl_pathv[i], 0)))
-                               continue;
+               remote_glob(conn, path1, GLOB_NOCHECK, NULL, &g);
+               for (i = 0; g.gl_pathv[i]; i++) {
+                       if (!(aa = do_stat(conn, g.gl_pathv[i], 0))) {
+                               if (err != 0 && err_abort)
+                                       break;
+                               else
+                                       continue;
+                       }
                        if (!(aa->flags & SSH2_FILEXFER_ATTR_UIDGID)) {
                                error("Can't get current ownership of "
                                    "remote file \"%s\"", g.gl_pathv[i]);
-                               continue;
+                               if (err != 0 && err_abort)
+                                       break;
+                               else
+                                       continue;
                        }
-                       printf("Changing group on %s\n", g.gl_pathv[i]);
                        aa->flags &= SSH2_FILEXFER_ATTR_UIDGID;
-                       aa->gid = n_arg;
-                       do_setstat(in, out, g.gl_pathv[i], aa);
+                       if (cmdnum == I_CHOWN) {
+                               printf("Changing owner on %s\n", g.gl_pathv[i]);
+                               aa->uid = n_arg;
+                       } else {
+                               printf("Changing group on %s\n", g.gl_pathv[i]);
+                               aa->gid = n_arg;
+                       }
+                       err = do_setstat(conn, g.gl_pathv[i], aa);
+                       if (err != 0 && err_abort)
+                               break;
                }
                break;
        case I_PWD:
                printf("Remote working directory: %s\n", *pwd);
                break;
        case I_LPWD:
-               if (!getcwd(path_buf, sizeof(path_buf)))
-                       error("Couldn't get local cwd: %s",
-                           strerror(errno));
-               else
-                       printf("Local working directory: %s\n",
-                           path_buf);
+               if (!getcwd(path_buf, sizeof(path_buf))) {
+                       error("Couldn't get local cwd: %s", strerror(errno));
+                       err = -1;
+                       break;
+               }
+               printf("Local working directory: %s\n", path_buf);
                break;
        case I_QUIT:
-               return(-1);
+               /* Processed below */
+               break;
        case I_HELP:
                help();
                break;
        case I_VERSION:
-               printf("SFTP protocol version %d\n", version);
+               printf("SFTP protocol version %u\n", sftp_proto_version(conn));
+               break;
+       case I_PROGRESS:
+               showprogress = !showprogress;
+               if (showprogress)
+                       printf("Progress meter enabled\n");
+               else
+                       printf("Progress meter disabled\n");
                break;
        default:
                fatal("%d is not implemented", cmdnum);
@@ -842,31 +1114,66 @@ parse_dispatch_command(int in, int out, const char *cmd, char **pwd)
        if (path2)
                xfree(path2);
 
-       /* If an error occurs in batch mode we should abort. */
-       if (infile != stdin && err > 0)
-               return -1;
+       /* If an unignored error occurs in batch mode we should abort. */
+       if (err_abort && err != 0)
+               return (-1);
+       else if (cmdnum == I_QUIT)
+               return (1);
 
-       return(0);
+       return (0);
 }
 
-void
-interactive_loop(int fd_in, int fd_out)
+int
+interactive_loop(int fd_in, int fd_out, char *file1, char *file2)
 {
        char *pwd;
+       char *dir = NULL;
        char cmd[2048];
+       struct sftp_conn *conn;
+       int err;
 
-       version = do_init(fd_in, fd_out);
-       if (version == -1)
+       conn = do_init(fd_in, fd_out, copy_buffer_len, num_requests);
+       if (conn == NULL)
                fatal("Couldn't initialise connection to server");
 
-       pwd = do_realpath(fd_in, fd_out, ".");
+       pwd = do_realpath(conn, ".");
        if (pwd == NULL)
                fatal("Need cwd");
 
+       if (file1 != NULL) {
+               dir = xstrdup(file1);
+               dir = make_absolute(dir, pwd);
+
+               if (remote_is_dir(conn, dir) && file2 == NULL) {
+                       printf("Changing to: %s\n", dir);
+                       snprintf(cmd, sizeof cmd, "cd \"%s\"", dir);
+                       if (parse_dispatch_command(conn, cmd, &pwd, 1) != 0)
+                               return (-1);
+               } else {
+                       if (file2 == NULL)
+                               snprintf(cmd, sizeof cmd, "get %s", dir);
+                       else
+                               snprintf(cmd, sizeof cmd, "get %s %s", dir,
+                                   file2);
+
+                       err = parse_dispatch_command(conn, cmd, &pwd, 1);
+                       xfree(dir);
+                       xfree(pwd);
+                       return (err);
+               }
+               xfree(dir);
+       }
+
+#if HAVE_SETVBUF
        setvbuf(stdout, NULL, _IOLBF, 0);
        setvbuf(infile, NULL, _IOLBF, 0);
+#else
+       setlinebuf(stdout);
+       setlinebuf(infile);
+#endif
 
-       for(;;) {
+       err = 0;
+       for (;;) {
                char *cp;
 
                printf("sftp> ");
@@ -875,15 +1182,22 @@ interactive_loop(int fd_in, int fd_out)
                if (fgets(cmd, sizeof(cmd), infile) == NULL) {
                        printf("\n");
                        break;
-               } else if (infile != stdin) /* Bluff typing */
+               }
+
+               if (batchmode) /* Echo command */
                        printf("%s", cmd);
 
                cp = strrchr(cmd, '\n');
                if (cp)
                        *cp = '\0';
 
-               if (parse_dispatch_command(fd_in, fd_out, cmd, &pwd))
+               err = parse_dispatch_command(conn, cmd, &pwd, batchmode);
+               if (err != 0)
                        break;
        }
        xfree(pwd);
+
+       /* err == 1 signifies normal "quit" exit */
+       return (err >= 0 ? 0 : -1);
 }
+
This page took 0.083092 seconds and 4 git commands to generate.