]> andersk Git - openssh.git/blobdiff - packet.c
- (djm) Bug #461: ssh-copy-id fails with no arguments. Patch from
[openssh.git] / packet.c
index 441f87ac011205e6023470b6d655a78cd8d39502..3e2d1249d22b1e618c51fe91e9743bebbf91fcfd 100644 (file)
--- a/packet.c
+++ b/packet.c
@@ -37,7 +37,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: packet.c,v 1.73 2001/12/05 03:56:39 itojun Exp $");
+RCSID("$OpenBSD: packet.c,v 1.102 2002/12/10 19:47:14 markus Exp $");
 
 #include "xmalloc.h"
 #include "buffer.h"
@@ -59,6 +59,8 @@ RCSID("$OpenBSD: packet.c,v 1.73 2001/12/05 03:56:39 itojun Exp $");
 #include "mac.h"
 #include "log.h"
 #include "canohost.h"
+#include "misc.h"
+#include "ssh.h"
 
 #ifdef PACKET_DEBUG
 #define DBG(x) x
@@ -85,10 +87,10 @@ static CipherContext receive_context;
 static CipherContext send_context;
 
 /* Buffer for raw input data from the socket. */
-static Buffer input;
+Buffer input;
 
 /* Buffer for raw output data going to the socket. */
-static Buffer output;
+Buffer output;
 
 /* Buffer for the partial outgoing packet being constructed. */
 static Buffer outgoing_packet;
@@ -114,6 +116,12 @@ static int interactive_mode = 0;
 
 /* Session key information for Encryption and MAC */
 Newkeys *newkeys[MODE_MAX];
+static u_int32_t read_seqnr = 0;
+static u_int32_t send_seqnr = 0;
+
+/* Session key for protocol v1 */
+static u_char ssh1_key[SSH_SESSION_KEY_LENGTH];
+static u_int ssh1_keylen;
 
 /* roundup current message to extra_pad bytes */
 static u_char extra_pad = 0;
@@ -126,12 +134,13 @@ void
 packet_set_connection(int fd_in, int fd_out)
 {
        Cipher *none = cipher_by_name("none");
+
        if (none == NULL)
                fatal("packet_set_connection: cannot load cipher 'none'");
        connection_in = fd_in;
        connection_out = fd_out;
-       cipher_init(&send_context, none, (u_char *) "", 0, NULL, 0);
-       cipher_init(&receive_context, none, (u_char *) "", 0, NULL, 0);
+       cipher_init(&send_context, none, "", 0, NULL, 0, CIPHER_ENCRYPT);
+       cipher_init(&receive_context, none, "", 0, NULL, 0, CIPHER_DECRYPT);
        newkeys[MODE_IN] = newkeys[MODE_OUT] = NULL;
        if (!initialized) {
                initialized = 1;
@@ -170,6 +179,99 @@ packet_connection_is_on_socket(void)
        return 1;
 }
 
+/*
+ * Exports an IV from the CipherContext required to export the key
+ * state back from the unprivileged child to the privileged parent
+ * process.
+ */
+
+void
+packet_get_keyiv(int mode, u_char *iv, u_int len)
+{
+       CipherContext *cc;
+
+       if (mode == MODE_OUT)
+               cc = &send_context;
+       else
+               cc = &receive_context;
+
+       cipher_get_keyiv(cc, iv, len);
+}
+
+int
+packet_get_keycontext(int mode, u_char *dat)
+{
+       CipherContext *cc;
+
+       if (mode == MODE_OUT)
+               cc = &send_context;
+       else
+               cc = &receive_context;
+
+       return (cipher_get_keycontext(cc, dat));
+}
+
+void
+packet_set_keycontext(int mode, u_char *dat)
+{
+       CipherContext *cc;
+
+       if (mode == MODE_OUT)
+               cc = &send_context;
+       else
+               cc = &receive_context;
+
+       cipher_set_keycontext(cc, dat);
+}
+
+int
+packet_get_keyiv_len(int mode)
+{
+       CipherContext *cc;
+
+       if (mode == MODE_OUT)
+               cc = &send_context;
+       else
+               cc = &receive_context;
+
+       return (cipher_get_keyiv_len(cc));
+}
+void
+packet_set_iv(int mode, u_char *dat)
+{
+       CipherContext *cc;
+
+       if (mode == MODE_OUT)
+               cc = &send_context;
+       else
+               cc = &receive_context;
+
+       cipher_set_keyiv(cc, dat);
+}
+int
+packet_get_ssh1_cipher()
+{
+       return (cipher_get_number(receive_context.cipher));
+}
+
+
+u_int32_t
+packet_get_seqnr(int mode)
+{
+       return (mode == MODE_IN ? read_seqnr : send_seqnr);
+}
+
+void
+packet_set_seqnr(int mode, u_int32_t seqnr)
+{
+       if (mode == MODE_IN)
+               read_seqnr = seqnr;
+       else if (mode == MODE_OUT)
+               send_seqnr = seqnr;
+       else
+               fatal("packet_set_seqnr: bad mode %d", mode);
+}
+
 /* returns 1 if connection is via ipv4 */
 
 int
@@ -181,9 +283,14 @@ packet_connection_is_ipv4(void)
        memset(&to, 0, sizeof(to));
        if (getsockname(connection_out, (struct sockaddr *)&to, &tolen) < 0)
                return 0;
-       if (to.ss_family != AF_INET)
-               return 0;
-       return 1;
+       if (to.ss_family == AF_INET)
+               return 1;
+#ifdef IPV4_IN_IPV6
+       if (to.ss_family == AF_INET6 && 
+           IN6_IS_ADDR_V4MAPPED(&((struct sockaddr_in6 *)&to)->sin6_addr))
+               return 1;
+#endif
+       return 0;
 }
 
 /* Sets the connection into non-blocking mode. */
@@ -240,6 +347,8 @@ packet_close(void)
                buffer_free(&compression_buffer);
                buffer_compress_uninit();
        }
+       cipher_cleanup(&send_context);
+       cipher_cleanup(&receive_context);
 }
 
 /* Sets remote side protocol flags. */
@@ -288,17 +397,32 @@ packet_start_compression(int level)
  * key is used for both sending and reception.  However, both directions are
  * encrypted independently of each other.
  */
+
 void
 packet_set_encryption_key(const u_char *key, u_int keylen,
     int number)
 {
        Cipher *cipher = cipher_by_number(number);
+
        if (cipher == NULL)
                fatal("packet_set_encryption_key: unknown cipher number %d", number);
        if (keylen < 20)
                fatal("packet_set_encryption_key: keylen too small: %d", keylen);
-       cipher_init(&receive_context, cipher, key, keylen, NULL, 0);
-       cipher_init(&send_context, cipher, key, keylen, NULL, 0);
+       if (keylen > SSH_SESSION_KEY_LENGTH)
+               fatal("packet_set_encryption_key: keylen too big: %d", keylen);
+       memcpy(ssh1_key, key, keylen);
+       ssh1_keylen = keylen;
+       cipher_init(&send_context, cipher, key, keylen, NULL, 0, CIPHER_ENCRYPT);
+       cipher_init(&receive_context, cipher, key, keylen, NULL, 0, CIPHER_DECRYPT);
+}
+
+u_int
+packet_get_encryption_key(u_char *key)
+{
+       if (key == NULL)
+               return (ssh1_keylen);
+       memcpy(key, ssh1_key, ssh1_keylen);
+       return (ssh1_keylen);
 }
 
 /* Start constructing a packet to send. */
@@ -321,6 +445,7 @@ void
 packet_put_char(int value)
 {
        char ch = value;
+
        buffer_append(&outgoing_packet, &ch, 1);
 }
 void
@@ -329,7 +454,7 @@ packet_put_int(u_int value)
        buffer_put_int(&outgoing_packet, value);
 }
 void
-packet_put_string(const char *buf, u_int len)
+packet_put_string(const void *buf, u_int len)
 {
        buffer_put_string(&outgoing_packet, buf, len);
 }
@@ -339,7 +464,7 @@ packet_put_cstring(const char *str)
        buffer_put_cstring(&outgoing_packet, str);
 }
 void
-packet_put_raw(const char *buf, u_int len)
+packet_put_raw(const void *buf, u_int len)
 {
        buffer_append(&outgoing_packet, buf, len);
 }
@@ -362,7 +487,7 @@ packet_put_bignum2(BIGNUM * value)
 static void
 packet_send1(void)
 {
-       char buf[8], *cp;
+       u_char buf[8], *cp;
        int i, padding, len;
        u_int checksum;
        u_int32_t rand = 0;
@@ -380,14 +505,14 @@ packet_send1(void)
                buffer_compress(&outgoing_packet, &compression_buffer);
                buffer_clear(&outgoing_packet);
                buffer_append(&outgoing_packet, buffer_ptr(&compression_buffer),
-                             buffer_len(&compression_buffer));
+                   buffer_len(&compression_buffer));
        }
        /* Compute packet length without padding (add checksum, remove padding). */
        len = buffer_len(&outgoing_packet) + 4 - 8;
 
        /* Insert padding. Initialized to zero in packet_start1() */
        padding = 8 - len % 8;
-       if (send_context.cipher->number != SSH_CIPHER_NONE) {
+       if (!send_context.plaintext) {
                cp = buffer_ptr(&outgoing_packet);
                for (i = 0; i < padding; i++) {
                        if (i % 4 == 0)
@@ -399,7 +524,7 @@ packet_send1(void)
        buffer_consume(&outgoing_packet, 8 - padding);
 
        /* Add check bytes. */
-       checksum = ssh_crc32((u_char *) buffer_ptr(&outgoing_packet),
+       checksum = ssh_crc32(buffer_ptr(&outgoing_packet),
            buffer_len(&outgoing_packet));
        PUT_32BIT(buf, checksum);
        buffer_append(&outgoing_packet, buf, 4);
@@ -412,9 +537,9 @@ packet_send1(void)
        /* Append to output. */
        PUT_32BIT(buf, len);
        buffer_append(&output, buf, 4);
-       buffer_append_space(&output, &cp, buffer_len(&outgoing_packet));
-       cipher_encrypt(&send_context, cp, buffer_ptr(&outgoing_packet),
-                      buffer_len(&outgoing_packet));
+       cp = buffer_append_space(&output, buffer_len(&outgoing_packet));
+       cipher_crypt(&send_context, cp, buffer_ptr(&outgoing_packet),
+           buffer_len(&outgoing_packet));
 
 #ifdef PACKET_DEBUG
        fprintf(stderr, "encrypted: ");
@@ -430,21 +555,27 @@ packet_send1(void)
         */
 }
 
-static void
+void
 set_newkeys(int mode)
 {
        Enc *enc;
        Mac *mac;
        Comp *comp;
        CipherContext *cc;
+       int encrypt;
 
-       debug("newkeys: mode %d", mode);
+       debug2("set_newkeys: mode %d", mode);
 
-       cc = (mode == MODE_OUT) ? &send_context : &receive_context;
+       if (mode == MODE_OUT) {
+               cc = &send_context;
+               encrypt = CIPHER_ENCRYPT;
+       } else {
+               cc = &receive_context;
+               encrypt = CIPHER_DECRYPT;
+       }
        if (newkeys[mode] != NULL) {
-               debug("newkeys: rekeying");
-               /* todo: free old keys, reset compression/cipher-ctxt; */
-               memset(cc, 0, sizeof(*cc));
+               debug("set_newkeys: rekeying");
+               cipher_cleanup(cc);
                enc  = &newkeys[mode]->enc;
                mac  = &newkeys[mode]->mac;
                comp = &newkeys[mode]->comp;
@@ -466,10 +597,11 @@ set_newkeys(int mode)
        if (mac->md != NULL)
                mac->enabled = 1;
        DBG(debug("cipher_init_context: %d", mode));
-       cipher_init(cc, enc->cipher, enc->key, enc->cipher->key_len,
-           enc->iv, enc->cipher->block_size);
-       memset(enc->iv,  0, enc->cipher->block_size);
-       memset(enc->key, 0, enc->cipher->key_len);
+       cipher_init(cc, enc->cipher, enc->key, enc->key_len,
+           enc->iv, enc->block_size, encrypt);
+       /* Deleting the keys does not gain extra security */
+       /* memset(enc->iv,  0, enc->block_size);
+          memset(enc->key, 0, enc->key_len); */
        if (comp->type != 0 && comp->enabled == 0) {
                packet_init_compression();
                if (mode == MODE_OUT)
@@ -486,10 +618,8 @@ set_newkeys(int mode)
 static void
 packet_send2(void)
 {
-       static u_int32_t seqnr = 0;
-       u_char type, *ucp, *macbuf = NULL;
+       u_char type, *cp, *macbuf = NULL;
        u_char padlen, pad;
-       char *cp;
        u_int packet_length = 0;
        u_int i, len;
        u_int32_t rand = 0;
@@ -503,10 +633,10 @@ packet_send2(void)
                mac  = &newkeys[MODE_OUT]->mac;
                comp = &newkeys[MODE_OUT]->comp;
        }
-       block_size = enc ? enc->cipher->block_size : 8;
+       block_size = enc ? enc->block_size : 8;
 
-       ucp = (u_char *) buffer_ptr(&outgoing_packet);
-       type = ucp[5];
+       cp = buffer_ptr(&outgoing_packet);
+       type = cp[5];
 
 #ifdef PACKET_DEBUG
        fprintf(stderr, "plain:     ");
@@ -541,13 +671,13 @@ packet_send2(void)
                /* will wrap if extra_pad+padlen > 255 */
                extra_pad  = roundup(extra_pad, block_size);
                pad = extra_pad - ((len + padlen) % extra_pad);
-               debug("packet_send2: adding %d (len %d padlen %d extra_pad %d)",
+               debug3("packet_send2: adding %d (len %d padlen %d extra_pad %d)",
                    pad, len, padlen, extra_pad);
                padlen += pad;
                extra_pad = 0;
        }
-       buffer_append_space(&outgoing_packet, &cp, padlen);
-       if (enc && enc->cipher->number != SSH_CIPHER_NONE) {
+       cp = buffer_append_space(&outgoing_packet, padlen);
+       if (enc && !send_context.plaintext) {
                /* random padding */
                for (i = 0; i < padlen; i++) {
                        if (i % 4 == 0)
@@ -561,21 +691,21 @@ packet_send2(void)
        }
        /* packet_length includes payload, padding and padding length field */
        packet_length = buffer_len(&outgoing_packet) - 4;
-       ucp = (u_char *)buffer_ptr(&outgoing_packet);
-       PUT_32BIT(ucp, packet_length);
-       ucp[4] = padlen;
+       cp = buffer_ptr(&outgoing_packet);
+       PUT_32BIT(cp, packet_length);
+       cp[4] = padlen;
        DBG(debug("send: len %d (includes padlen %d)", packet_length+4, padlen));
 
        /* compute MAC over seqnr and packet(length fields, payload, padding) */
        if (mac && mac->enabled) {
-               macbuf = mac_compute(mac, seqnr,
-                   (u_char *) buffer_ptr(&outgoing_packet),
+               macbuf = mac_compute(mac, send_seqnr,
+                   buffer_ptr(&outgoing_packet),
                    buffer_len(&outgoing_packet));
-               DBG(debug("done calc MAC out #%d", seqnr));
+               DBG(debug("done calc MAC out #%d", send_seqnr));
        }
        /* encrypt packet and append to output buffer. */
-       buffer_append_space(&output, &cp, buffer_len(&outgoing_packet));
-       cipher_encrypt(&send_context, cp, buffer_ptr(&outgoing_packet),
+       cp = buffer_append_space(&output, buffer_len(&outgoing_packet));
+       cipher_crypt(&send_context, cp, buffer_ptr(&outgoing_packet),
            buffer_len(&outgoing_packet));
        /* append unencrypted MAC */
        if (mac && mac->enabled)
@@ -585,7 +715,7 @@ packet_send2(void)
        buffer_dump(&output);
 #endif
        /* increment sequence number for outgoing packets */
-       if (++seqnr == 0)
+       if (++send_seqnr == 0)
                log("outgoing seqnr wraps around");
        buffer_clear(&outgoing_packet);
 
@@ -610,7 +740,7 @@ packet_send(void)
  */
 
 int
-packet_read(int *payload_len_ptr)
+packet_read_seqnr(u_int32_t *seqnr_p)
 {
        int type, len;
        fd_set *setp;
@@ -626,13 +756,13 @@ packet_read(int *payload_len_ptr)
        /* Stay in the loop until we have received a complete packet. */
        for (;;) {
                /* Try to read a packet from the buffer. */
-               type = packet_read_poll(payload_len_ptr);
+               type = packet_read_poll_seqnr(seqnr_p);
                if (!compat20 && (
                    type == SSH_SMSG_SUCCESS
                    || type == SSH_SMSG_FAILURE
                    || type == SSH_CMSG_EOF
                    || type == SSH_CMSG_EXIT_CONFIRMATION))
-                       packet_integrity_check(*payload_len_ptr, 0, type);
+                       packet_check_eom();
                /* If we got a packet, return it. */
                if (type != SSH_MSG_NONE) {
                        xfree(setp);
@@ -665,17 +795,23 @@ packet_read(int *payload_len_ptr)
        /* NOTREACHED */
 }
 
+int
+packet_read(void)
+{
+       return packet_read_seqnr(NULL);
+}
+
 /*
  * Waits until a packet has been received, verifies that its type matches
  * that given, and gives a fatal error and exits if there is a mismatch.
  */
 
 void
-packet_read_expect(int *payload_len_ptr, int expected_type)
+packet_read_expect(int expected_type)
 {
        int type;
 
-       type = packet_read(payload_len_ptr);
+       type = packet_read();
        if (type != expected_type)
                packet_disconnect("Protocol error: expected packet type %d, got %d",
                    expected_type, type);
@@ -688,30 +824,23 @@ packet_read_expect(int *payload_len_ptr, int expected_type)
  * SSH_MSG_DISCONNECT is handled specially here.  Also,
  * SSH_MSG_IGNORE messages are skipped by this function and are never returned
  * to higher levels.
- *
- * The returned payload_len does include space consumed by:
- *     Packet length
- *     Padding
- *     Packet type
- *     Check bytes
  */
 
 static int
-packet_read_poll1(int *payload_len_ptr)
+packet_read_poll1(void)
 {
        u_int len, padded_len;
-       u_char *ucp, type;
-       char *cp;
+       u_char *cp, type;
        u_int checksum, stored_checksum;
 
        /* Check if input size is less than minimum packet size. */
        if (buffer_len(&input) < 4 + 8)
                return SSH_MSG_NONE;
        /* Get length of incoming packet. */
-       ucp = (u_char *) buffer_ptr(&input);
-       len = GET_32BIT(ucp);
+       cp = buffer_ptr(&input);
+       len = GET_32BIT(cp);
        if (len < 1 + 2 + 2 || len > 256 * 1024)
-               packet_disconnect("Bad packet length %d.", len);
+               packet_disconnect("Bad packet length %u.", len);
        padded_len = (len + 8) & ~7;
 
        /* Check if the packet has been entirely received. */
@@ -728,14 +857,14 @@ packet_read_poll1(int *payload_len_ptr)
         * (C)1998 CORE-SDI, Buenos Aires Argentina
         * Ariel Futoransky(futo@core-sdi.com)
         */
-       if (receive_context.cipher->number != SSH_CIPHER_NONE &&
+       if (!receive_context.plaintext &&
            detect_attack(buffer_ptr(&input), padded_len, NULL) == DEATTACK_DETECTED)
                packet_disconnect("crc32 compensation attack: network attack detected");
 
        /* Decrypt data to incoming_packet. */
        buffer_clear(&incoming_packet);
-       buffer_append_space(&incoming_packet, &cp, padded_len);
-       cipher_decrypt(&receive_context, cp, buffer_ptr(&input), padded_len);
+       cp = buffer_append_space(&incoming_packet, padded_len);
+       cipher_crypt(&receive_context, cp, buffer_ptr(&input), padded_len);
 
        buffer_consume(&input, padded_len);
 
@@ -745,7 +874,7 @@ packet_read_poll1(int *payload_len_ptr)
 #endif
 
        /* Compute packet checksum. */
-       checksum = ssh_crc32((u_char *) buffer_ptr(&incoming_packet),
+       checksum = ssh_crc32(buffer_ptr(&incoming_packet),
            buffer_len(&incoming_packet) - 4);
 
        /* Skip padding. */
@@ -753,11 +882,11 @@ packet_read_poll1(int *payload_len_ptr)
 
        /* Test check bytes. */
        if (len != buffer_len(&incoming_packet))
-               packet_disconnect("packet_read_poll: len %d != buffer_len %d.",
+               packet_disconnect("packet_read_poll1: len %d != buffer_len %d.",
                    len, buffer_len(&incoming_packet));
 
-       ucp = (u_char *) buffer_ptr(&incoming_packet) + len - 4;
-       stored_checksum = GET_32BIT(ucp);
+       cp = (u_char *)buffer_ptr(&incoming_packet) + len - 4;
+       stored_checksum = GET_32BIT(cp);
        if (checksum != stored_checksum)
                packet_disconnect("Corrupted check bytes on input.");
        buffer_consume_end(&incoming_packet, 4);
@@ -770,18 +899,15 @@ packet_read_poll1(int *payload_len_ptr)
                    buffer_len(&compression_buffer));
        }
        type = buffer_get_char(&incoming_packet);
-       *payload_len_ptr = buffer_len(&incoming_packet);
        return type;
 }
 
 static int
-packet_read_poll2(int *payload_len_ptr)
+packet_read_poll2(u_int32_t *seqnr_p)
 {
-       static u_int32_t seqnr = 0;
        static u_int packet_length = 0;
        u_int padlen, need;
-       u_char *macbuf, *ucp, type;
-       char *cp;
+       u_char *macbuf, *cp, type;
        int maclen, block_size;
        Enc *enc   = NULL;
        Mac *mac   = NULL;
@@ -793,7 +919,7 @@ packet_read_poll2(int *payload_len_ptr)
                comp = &newkeys[MODE_IN]->comp;
        }
        maclen = mac && mac->enabled ? mac->mac_len : 0;
-       block_size = enc ? enc->cipher->block_size : 8;
+       block_size = enc ? enc->block_size : 8;
 
        if (packet_length == 0) {
                /*
@@ -803,16 +929,16 @@ packet_read_poll2(int *payload_len_ptr)
                if (buffer_len(&input) < block_size)
                        return SSH_MSG_NONE;
                buffer_clear(&incoming_packet);
-               buffer_append_space(&incoming_packet, &cp, block_size);
-               cipher_decrypt(&receive_context, cp, buffer_ptr(&input),
+               cp = buffer_append_space(&incoming_packet, block_size);
+               cipher_crypt(&receive_context, cp, buffer_ptr(&input),
                    block_size);
-               ucp = (u_char *) buffer_ptr(&incoming_packet);
-               packet_length = GET_32BIT(ucp);
+               cp = buffer_ptr(&incoming_packet);
+               packet_length = GET_32BIT(cp);
                if (packet_length < 1 + 4 || packet_length > 256 * 1024) {
                        buffer_dump(&incoming_packet);
-                       packet_disconnect("Bad packet length %d.", packet_length);
+                       packet_disconnect("Bad packet length %u.", packet_length);
                }
-               DBG(debug("input: packet len %d", packet_length+4));
+               DBG(debug("input: packet len %u", packet_length+4));
                buffer_consume(&input, block_size);
        }
        /* we have a partial packet of block_size bytes */
@@ -832,28 +958,30 @@ packet_read_poll2(int *payload_len_ptr)
        fprintf(stderr, "read_poll enc/full: ");
        buffer_dump(&input);
 #endif
-       buffer_append_space(&incoming_packet, &cp, need);
-       cipher_decrypt(&receive_context, cp, buffer_ptr(&input), need);
+       cp = buffer_append_space(&incoming_packet, need);
+       cipher_crypt(&receive_context, cp, buffer_ptr(&input), need);
        buffer_consume(&input, need);
        /*
         * compute MAC over seqnr and packet,
         * increment sequence number for incoming packet
         */
        if (mac && mac->enabled) {
-               macbuf = mac_compute(mac, seqnr,
-                   (u_char *) buffer_ptr(&incoming_packet),
+               macbuf = mac_compute(mac, read_seqnr,
+                   buffer_ptr(&incoming_packet),
                    buffer_len(&incoming_packet));
                if (memcmp(macbuf, buffer_ptr(&input), mac->mac_len) != 0)
                        packet_disconnect("Corrupted MAC on input.");
-               DBG(debug("MAC #%d ok", seqnr));
+               DBG(debug("MAC #%d ok", read_seqnr));
                buffer_consume(&input, mac->mac_len);
        }
-       if (++seqnr == 0)
+       if (seqnr_p != NULL)
+               *seqnr_p = read_seqnr;
+       if (++read_seqnr == 0)
                log("incoming seqnr wraps around");
 
        /* get padlen */
-       cp = buffer_ptr(&incoming_packet) + 4;
-       padlen = (u_char) *cp;
+       cp = buffer_ptr(&incoming_packet);
+       padlen = cp[4];
        DBG(debug("input: padlen %d", padlen));
        if (padlen < 4)
                packet_disconnect("Corrupted padlen %d on input.", padlen);
@@ -869,7 +997,8 @@ packet_read_poll2(int *payload_len_ptr)
                buffer_clear(&incoming_packet);
                buffer_append(&incoming_packet, buffer_ptr(&compression_buffer),
                    buffer_len(&compression_buffer));
-               DBG(debug("input: len after de-compress %d", buffer_len(&incoming_packet)));
+               DBG(debug("input: len after de-compress %d",
+                   buffer_len(&incoming_packet)));
        }
        /*
         * get packet type, implies consume.
@@ -878,7 +1007,6 @@ packet_read_poll2(int *payload_len_ptr)
        type = buffer_get_char(&incoming_packet);
        if (type == SSH2_MSG_NEWKEYS)
                set_newkeys(MODE_IN);
-       *payload_len_ptr = buffer_len(&incoming_packet);
 #ifdef PACKET_DEBUG
        fprintf(stderr, "read/plain[%d]:\r\n", type);
        buffer_dump(&incoming_packet);
@@ -889,18 +1017,18 @@ packet_read_poll2(int *payload_len_ptr)
 }
 
 int
-packet_read_poll(int *payload_len_ptr)
+packet_read_poll_seqnr(u_int32_t *seqnr_p)
 {
-       int reason;
+       u_int reason, seqnr;
        u_char type;
        char *msg;
 
        for (;;) {
                if (compat20) {
-                       type = packet_read_poll2(payload_len_ptr);
+                       type = packet_read_poll2(seqnr_p);
                        if (type)
                                DBG(debug("received packet type %d", type));
-                       switch(type) {
+                       switch (type) {
                        case SSH2_MSG_IGNORE:
                                break;
                        case SSH2_MSG_DEBUG:
@@ -914,18 +1042,23 @@ packet_read_poll(int *payload_len_ptr)
                        case SSH2_MSG_DISCONNECT:
                                reason = packet_get_int();
                                msg = packet_get_string(NULL);
-                               log("Received disconnect from %s: %d: %.400s", get_remote_ipaddr(),
-                                       reason, msg);
+                               log("Received disconnect from %s: %u: %.400s",
+                                   get_remote_ipaddr(), reason, msg);
                                xfree(msg);
                                fatal_cleanup();
                                break;
+                       case SSH2_MSG_UNIMPLEMENTED:
+                               seqnr = packet_get_int();
+                               debug("Received SSH2_MSG_UNIMPLEMENTED for %u",
+                                   seqnr);
+                               break;
                        default:
                                return type;
                                break;
                        }
                } else {
-                       type = packet_read_poll1(payload_len_ptr);
-                       switch(type) {
+                       type = packet_read_poll1();
+                       switch (type) {
                        case SSH_MSG_IGNORE:
                                break;
                        case SSH_MSG_DEBUG:
@@ -935,8 +1068,8 @@ packet_read_poll(int *payload_len_ptr)
                                break;
                        case SSH_MSG_DISCONNECT:
                                msg = packet_get_string(NULL);
-                               log("Received disconnect from %s: %.400s", get_remote_ipaddr(),
-                                       msg);
+                               log("Received disconnect from %s: %.400s",
+                                   get_remote_ipaddr(), msg);
                                fatal_cleanup();
                                xfree(msg);
                                break;
@@ -950,6 +1083,12 @@ packet_read_poll(int *payload_len_ptr)
        }
 }
 
+int
+packet_read_poll(void)
+{
+       return packet_read_poll_seqnr(NULL);
+}
+
 /*
  * Buffers the given amount of input characters.  This is intended to be used
  * together with packet_read_poll.
@@ -967,6 +1106,7 @@ u_int
 packet_get_char(void)
 {
        char ch;
+
        buffer_get(&incoming_packet, &ch, 1);
        return (u_char) ch;
 }
@@ -985,21 +1125,22 @@ packet_get_int(void)
  */
 
 void
-packet_get_bignum(BIGNUM * value, int *length_ptr)
+packet_get_bignum(BIGNUM * value)
 {
-       *length_ptr = buffer_get_bignum(&incoming_packet, value);
+       buffer_get_bignum(&incoming_packet, value);
 }
 
 void
-packet_get_bignum2(BIGNUM * value, int *length_ptr)
+packet_get_bignum2(BIGNUM * value)
 {
-       *length_ptr = buffer_get_bignum2(&incoming_packet, value);
+       buffer_get_bignum2(&incoming_packet, value);
 }
 
-char *
+void *
 packet_get_raw(int *length_ptr)
 {
        int bytes = buffer_len(&incoming_packet);
+
        if (length_ptr != NULL)
                *length_ptr = bytes;
        return buffer_ptr(&incoming_packet);
@@ -1018,7 +1159,7 @@ packet_remaining(void)
  * integer into which the length of the string is stored.
  */
 
-char *
+void *
 packet_get_string(u_int *length_ptr)
 {
        return buffer_get_string(&incoming_packet, length_ptr);
@@ -1072,6 +1213,7 @@ packet_disconnect(const char *fmt,...)
        char buf[1024];
        va_list args;
        static int disconnecting = 0;
+
        if (disconnecting)      /* Guard against recursive invocations. */
                fatal("packet_disconnect called recursively.");
        disconnecting = 1;
@@ -1084,6 +1226,9 @@ packet_disconnect(const char *fmt,...)
        vsnprintf(buf, sizeof(buf), fmt, args);
        va_end(args);
 
+       /* Display the error locally */
+       log("Disconnecting: %.100s", buf);
+
        /* Send the disconnect message to the other side, and wait for it to get sent. */
        if (compat20) {
                packet_start(SSH2_MSG_DISCONNECT);
@@ -1103,8 +1248,6 @@ packet_disconnect(const char *fmt,...)
        /* Close the connection. */
        packet_close();
 
-       /* Display the error locally and exit. */
-       log("Disconnecting: %.100s", buf);
        fatal_cleanup();
 }
 
@@ -1114,6 +1257,7 @@ void
 packet_write_poll(void)
 {
        int len = buffer_len(&output);
+
        if (len > 0) {
                len = write(connection_out, buffer_ptr(&output), len);
                if (len <= 0) {
@@ -1170,17 +1314,26 @@ packet_not_very_much_data_to_write(void)
                return buffer_len(&output) < 128 * 1024;
 }
 
+static void
+packet_set_tos(int interactive)
+{
+       int tos = interactive ? IPTOS_LOWDELAY : IPTOS_THROUGHPUT;
+
+       if (!packet_connection_is_on_socket() ||
+           !packet_connection_is_ipv4())
+               return;
+       if (setsockopt(connection_in, IPPROTO_IP, IP_TOS, &tos,
+           sizeof(tos)) < 0)
+               error("setsockopt IP_TOS %d: %.100s:",
+                   tos, strerror(errno));
+}
+
 /* Informs that the current session is interactive.  Sets IP flags for that. */
 
 void
 packet_set_interactive(int interactive)
 {
        static int called = 0;
-#if defined(IP_TOS) && !defined(IP_TOS_IS_BROKEN)
-       int lowdelay = IPTOS_LOWDELAY;
-       int throughput = IPTOS_THROUGHPUT;
-#endif
-       int on = 1;
 
        if (called)
                return;
@@ -1191,37 +1344,12 @@ packet_set_interactive(int interactive)
 
        /* Only set socket options if using a socket.  */
        if (!packet_connection_is_on_socket())
-               return;
-       /*
-        * IPTOS_LOWDELAY and IPTOS_THROUGHPUT are IPv4 only
-        */
-       if (interactive) {
-               /*
-                * Set IP options for an interactive connection.  Use
-                * IPTOS_LOWDELAY and TCP_NODELAY.
-                */
-#if defined(IP_TOS) && !defined(IP_TOS_IS_BROKEN)
-               if (packet_connection_is_ipv4()) {
-                       if (setsockopt(connection_in, IPPROTO_IP, IP_TOS,
-                           (void *) &lowdelay, sizeof(lowdelay)) < 0)
-                               error("setsockopt IPTOS_LOWDELAY: %.100s",
-                                   strerror(errno));
-               }
-#endif
-               if (setsockopt(connection_in, IPPROTO_TCP, TCP_NODELAY, (void *) &on,
-                   sizeof(on)) < 0)
-                       error("setsockopt TCP_NODELAY: %.100s", strerror(errno));
-       } else if (packet_connection_is_ipv4()) {
-               /*
-                * Set IP options for a non-interactive connection.  Use
-                * IPTOS_THROUGHPUT.
-                */
+       if (interactive)
+               set_nodelay(connection_in);
 #if defined(IP_TOS) && !defined(IP_TOS_IS_BROKEN)
-               if (setsockopt(connection_in, IPPROTO_IP, IP_TOS, (void *) &throughput,
-                   sizeof(throughput)) < 0)
-                       error("setsockopt IPTOS_THROUGHPUT: %.100s", strerror(errno));
+       packet_set_tos(interactive);
 #endif
-       }
+
 }
 
 /* Returns true if the current connection is interactive. */
@@ -1236,6 +1364,7 @@ int
 packet_set_maxsize(int s)
 {
        static int called = 0;
+
        if (called) {
                log("packet_set_maxsize: called twice: old %d new %d",
                    max_packet_size, s);
@@ -1277,7 +1406,7 @@ packet_send_ignore(int nbytes)
 
        packet_start(compat20 ? SSH2_MSG_IGNORE : SSH_MSG_IGNORE);
        packet_put_int(nbytes);
-       for(i = 0; i < nbytes; i++) {
+       for (i = 0; i < nbytes; i++) {
                if (i % 4 == 0)
                        rand = arc4random();
                packet_put_char(rand & 0xff);
This page took 0.393913 seconds and 4 git commands to generate.