- (bal) Slight auth2-pam.c clean up.

[openssh.git] / compat.c

diff --git a/compat.c b/compat.c
index 0862de2072be24eadf0cc8b72655524e7631630f..6e0ed65af46b5013b3cf373a30c980d7bc27ccfa 100644 (file)
--- a/compat.c
+++ b/compat.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1999 Markus Friedl.  All rights reserved.
+ * Copyright (c) 1999,2000 Markus Friedl.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -9,11 +9,6 @@
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
- * 3. All advertising materials mentioning features or use of this software
- *    must display the following acknowledgement:
- *      This product includes software developed by Markus Friedl.
- * 4. The name of the author may not be used to endorse or promote products
- *    derived from this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
@@ -28,12 +23,25 @@
  */
 
 #include "includes.h"
-RCSID("$Id$");
+RCSID("$OpenBSD: compat.c,v 1.33 2001/01/08 22:29:05 markus Exp $");
 
 #include "ssh.h"
 #include "packet.h"
 #include "xmalloc.h"
 #include "compat.h"
+#ifdef HAVE_LIBPCRE
+#  include <pcreposix.h>
+#else /* Use native regex libraries */
+#  ifdef HAVE_REGEX_H
+#    include <regex.h>
+#  else
+#    ifdef HAVE_REGCOMP
+#      include "fake-regex.h"
+#    else
+#      error "No regular libraries detected.  See INSTALL file."
+#    endif
+#  endif
+#endif /* HAVE_LIBPCRE */
 
 int compat13 = 0;
 int compat20 = 0;
@@ -55,36 +63,65 @@ enable_compat13(void)
 void
 compat_datafellows(const char *version)
 {
-       int i;
-       size_t len;
-       struct {
-               char    *version;
+       int i, ret;
+       char ebuf[1024];
+       regex_t reg;
+       static struct {
+               char    *pat;
                int     bugs;
        } check[] = {
-               {"2.1.0",       SSH_BUG_SIGBLOB|SSH_BUG_HMAC},
-               {"2.0.1",       SSH_BUG_SIGBLOB|SSH_BUG_HMAC|SSH_BUG_PUBKEYAUTH|SSH_BUG_X11FWD},
-               {NULL,          0}
+               { "^OpenSSH[-_]2\\.[012]",
+                                       SSH_OLD_SESSIONID|SSH_BUG_BANNER },
+               { "^OpenSSH_2\\.3\\.0", SSH_BUG_BANNER },
+               { "^OpenSSH",           0 },
+               { "MindTerm",           0 },
+               { "^2\\.1\\.0",         SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
+                                       SSH_OLD_SESSIONID|SSH_BUG_DEBUG },
+               { "^2\\.0\\.1[3-9]",    SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
+                                       SSH_OLD_SESSIONID|SSH_BUG_DEBUG|
+                                       SSH_BUG_PKSERVICE|SSH_BUG_X11FWD },
+               { "^2\\.0\\.",          SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
+                                       SSH_OLD_SESSIONID|SSH_BUG_DEBUG|
+                                       SSH_BUG_PKSERVICE|SSH_BUG_X11FWD|
+                                       SSH_BUG_PKAUTH },
+               { "^2\\.[23]\\.0",      SSH_BUG_HMAC},
+               { "^2\\.[2-9]\\.",      0 },
+               { "^2\\.4$",            SSH_OLD_SESSIONID}, /* Van Dyke */
+               { "^3\\.0 SecureCRT",   SSH_OLD_SESSIONID},
+               { "^1\\.7 SecureFX",    SSH_OLD_SESSIONID},
+               { NULL,                 0 }
        };
-       for (i = 0; check[i].version; i++) {
-               len = strlen(check[i].version);
-               if (strlen(version) >= len &&
-                  (strncmp(version, check[i].version, len) == 0)) {
-                       verbose("datafellows: %.200s", version);
+       /* process table, return first match */
+       for (i = 0; check[i].pat; i++) {
+               ret = regcomp(&reg, check[i].pat, REG_EXTENDED|REG_NOSUB);
+               if (ret != 0) {
+                       regerror(ret, &reg, ebuf, sizeof(ebuf));
+                       ebuf[sizeof(ebuf)-1] = '\0';
+                       error("regerror: %s", ebuf);
+                       continue;
+               }
+               ret = regexec(&reg, version, 0, NULL, 0);
+               regfree(&reg);
+               if (ret == 0) {
+                       debug("match: %s pat %s", version, check[i].pat);
                        datafellows = check[i].bugs;
                        return;
                }
        }
+       debug("no match: %s", version);
 }
 
 #define        SEP     ","
 int
 proto_spec(const char *spec)
 {
-       char *s = xstrdup(spec);
-       char *p;
+       char *s, *p, *q;
        int ret = SSH_PROTO_UNKNOWN;
 
-       for ((p = strtok(s, SEP)); p; (p = strtok(NULL, SEP))) {
+       if (spec == NULL)
+               return ret;
+       q = s = xstrdup(spec);
+       for ((p = strsep(&q, SEP)); p && *p != '\0'; (p = strsep(&q, SEP))) {
                switch(atoi(p)) {
                case 1:
                        if (ret == SSH_PROTO_UNKNOWN)