]> andersk Git - openssh.git/blobdiff - readconf.c
- (djm) Avoid bad and unportable sprintf usage in compat code
[openssh.git] / readconf.c
index 4a109468556d8da9f80375f2c42b461ccd497764..83069d3ad0001de02664df20770178ce37290461 100644 (file)
@@ -12,7 +12,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: readconf.c,v 1.82 2001/06/26 16:15:23 dugsong Exp $");
+RCSID("$OpenBSD: readconf.c,v 1.90 2001/09/19 19:24:18 stevesk Exp $");
 
 #include "ssh.h"
 #include "xmalloc.h"
@@ -114,7 +114,8 @@ typedef enum {
        oGlobalKnownHostsFile2, oUserKnownHostsFile2, oPubkeyAuthentication,
        oKbdInteractiveAuthentication, oKbdInteractiveDevices, oHostKeyAlias,
        oDynamicForward, oPreferredAuthentications, oHostbasedAuthentication,
-       oHostKeyAlgorithms, oBindAddress
+       oHostKeyAlgorithms, oBindAddress, oSmartcardDevice,
+       oClearAllForwardings
 } OpCodes;
 
 /* Textual representations of the tokens. */
@@ -183,6 +184,8 @@ static struct {
        { "preferredauthentications", oPreferredAuthentications },
        { "hostkeyalgorithms", oHostKeyAlgorithms },
        { "bindaddress", oBindAddress },
+       { "smartcarddevice", oSmartcardDevice },
+       { "clearallforwardings", oClearAllForwardings }, 
        { NULL, 0 }
 };
 
@@ -228,6 +231,19 @@ add_remote_forward(Options *options, u_short port, const char *host,
        fwd->host_port = host_port;
 }
 
+static void
+clear_forwardings(Options *options)
+{
+       int i;
+
+       for (i = 0; i < options->num_local_forwards; i++)
+               xfree(options->local_forwards[i].host);
+       options->num_local_forwards = 0;
+       for (i = 0; i < options->num_remote_forwards; i++)
+               xfree(options->remote_forwards[i].host);
+       options->num_remote_forwards = 0;
+}
+
 /*
  * Returns the number of the token pointed to by cp or oBadOption.
  */
@@ -259,6 +275,7 @@ process_config_line(Options *options, const char *host,
        char buf[256], *s, *string, **charptr, *endofnumber, *keyword, *arg;
        int opcode, *intptr, value;
        u_short fwd_port, fwd_host_port;
+       char sfwd_host_port[6];
 
        s = line;
        /* Get the keyword. (Each line is supposed to begin with a keyword). */
@@ -467,6 +484,10 @@ parse_string:
                charptr = &options->bind_address;
                goto parse_string;
 
+       case oSmartcardDevice:
+               charptr = &options->smartcard_device;
+               goto parse_string;
+
        case oProxyCommand:
                charptr = &options->proxy_command;
                string = xstrdup("");
@@ -572,42 +593,34 @@ parse_int:
                        *intptr = (LogLevel) value;
                break;
 
-       case oRemoteForward:
-               arg = strdelim(&s);
-               if (!arg || *arg == '\0')
-                       fatal("%.200s line %d: Missing argument.", filename, linenum);
-               fwd_port = a2port(arg);
-               if (fwd_port == 0)
-                       fatal("%.200s line %d: Badly formatted port number.",
-                             filename, linenum);
-               arg = strdelim(&s);
-               if (!arg || *arg == '\0')
-                       fatal("%.200s line %d: Missing second argument.",
-                             filename, linenum);
-               if (sscanf(arg, "%255[^:]:%hu", buf, &fwd_host_port) != 2)
-                       fatal("%.200s line %d: Badly formatted host:port.",
-                             filename, linenum);
-               if (*activep)
-                       add_remote_forward(options, fwd_port, buf, fwd_host_port);
-               break;
-
        case oLocalForward:
+       case oRemoteForward:
                arg = strdelim(&s);
                if (!arg || *arg == '\0')
-                       fatal("%.200s line %d: Missing argument.", filename, linenum);
-               fwd_port = a2port(arg);
-               if (fwd_port == 0)
-                       fatal("%.200s line %d: Badly formatted port number.",
-                             filename, linenum);
+                       fatal("%.200s line %d: Missing port argument.",
+                           filename, linenum);
+               if ((fwd_port = a2port(arg)) == 0)
+                       fatal("%.200s line %d: Bad listen port.",
+                           filename, linenum);
                arg = strdelim(&s);
                if (!arg || *arg == '\0')
                        fatal("%.200s line %d: Missing second argument.",
-                             filename, linenum);
-               if (sscanf(arg, "%255[^:]:%hu", buf, &fwd_host_port) != 2)
-                       fatal("%.200s line %d: Badly formatted host:port.",
-                             filename, linenum);
-               if (*activep)
-                       add_local_forward(options, fwd_port, buf, fwd_host_port);
+                           filename, linenum);
+               if (sscanf(arg, "%255[^:]:%5[0-9]", buf, sfwd_host_port) != 2 &&
+                   sscanf(arg, "%255[^/]/%5[0-9]", buf, sfwd_host_port) != 2)
+                       fatal("%.200s line %d: Bad forwarding specification.",
+                           filename, linenum);
+               if ((fwd_host_port = a2port(sfwd_host_port)) == 0)
+                       fatal("%.200s line %d: Bad forwarding port.",
+                           filename, linenum);
+               if (*activep) {
+                       if (opcode == oLocalForward)
+                               add_local_forward(options, fwd_port, buf,
+                                   fwd_host_port);
+                       else if (opcode == oRemoteForward)
+                               add_remote_forward(options, fwd_port, buf,
+                                   fwd_host_port);
+               }
                break;
 
        case oDynamicForward:
@@ -619,9 +632,14 @@ parse_int:
                if (fwd_port == 0)
                        fatal("%.200s line %d: Badly formatted port number.",
                            filename, linenum);
-               add_local_forward(options, fwd_port, "socks4", 0);
+               if (*activep)
+                       add_local_forward(options, fwd_port, "socks4", 0);
                break;
 
+       case oClearAllForwardings:
+               intptr = &options->clear_forwardings;
+               goto parse_flag;
+
        case oHost:
                *activep = 0;
                while ((arg = strdelim(&s)) != NULL && *arg != '\0')
@@ -671,10 +689,10 @@ parse_int:
 /*
  * Reads the config file and modifies the options accordingly.  Options
  * should already be initialized before this call.  This never returns if
- * there is an error.  If the file does not exist, this returns immediately.
+ * there is an error.  If the file does not exist, this returns 0.
  */
 
-void
+int
 read_config_file(const char *filename, const char *host, Options *options)
 {
        FILE *f;
@@ -685,7 +703,7 @@ read_config_file(const char *filename, const char *host, Options *options)
        /* Open the file. */
        f = fopen(filename, "r");
        if (!f)
-               return;
+               return 0;
 
        debug("Reading configuration data %.200s", filename);
 
@@ -705,6 +723,7 @@ read_config_file(const char *filename, const char *host, Options *options)
        if (bad_options > 0)
                fatal("%s: terminating, %d bad configuration options",
                      filename, bad_options);
+       return 1;
 }
 
 /*
@@ -769,9 +788,11 @@ initialize_options(Options * options)
        options->user_hostfile2 = NULL;
        options->num_local_forwards = 0;
        options->num_remote_forwards = 0;
+       options->clear_forwardings = -1;
        options->log_level = (LogLevel) - 1;
        options->preferred_authentications = NULL;
        options->bind_address = NULL;
+       options->smartcard_device = NULL;
 }
 
 /*
@@ -803,7 +824,7 @@ fill_default_options(Options * options)
        if (options->pubkey_authentication == -1)
                options->pubkey_authentication = 1;
        if (options->challenge_response_authentication == -1)
-               options->challenge_response_authentication = 0;
+               options->challenge_response_authentication = 1;
 #if defined(KRB4) || defined(KRB5)
        if (options->kerberos_authentication == -1)
                options->kerberos_authentication = 1;
@@ -843,7 +864,7 @@ fill_default_options(Options * options)
        if (options->port == -1)
                options->port = 0;      /* Filled in ssh_connect. */
        if (options->connection_attempts == -1)
-               options->connection_attempts = 4;
+               options->connection_attempts = 1;
        if (options->number_of_password_prompts == -1)
                options->number_of_password_prompts = 3;
        /* Selected in ssh_login(). */
@@ -888,6 +909,8 @@ fill_default_options(Options * options)
                options->user_hostfile2 = _PATH_SSH_USER_HOSTFILE2;
        if (options->log_level == (LogLevel) - 1)
                options->log_level = SYSLOG_LEVEL_INFO;
+       if (options->clear_forwardings == 1)
+               clear_forwardings(options);
        /* options->proxy_command should not be set by default */
        /* options->user will be set in the main program if appropriate */
        /* options->hostname will be set in the main program if appropriate */
This page took 0.127269 seconds and 4 git commands to generate.