]> andersk Git - openssh.git/blobdiff - scp.c
- deraadt@cvs.openbsd.org 2001/03/02 18:54:31
[openssh.git] / scp.c
diff --git a/scp.c b/scp.c
index d353b5ead5bc7a5990569d8aa9ca4c6351082eb9..c8bb2d3331e4de1debc5b337cdd3e9eb4e337918 100644 (file)
--- a/scp.c
+++ b/scp.c
@@ -14,8 +14,8 @@
  * called by a name other than "ssh" or "Secure Shell".
  */
 /*
- * Copyright (c) 1999 Theo de Raadt. All rights reserved.
- * Copyright (c) 1999 Aaron Campbell. All rights reserved.
+ * Copyright (c) 1999 Theo de Raadt.  All rights reserved.
+ * Copyright (c) 1999 Aaron Campbell.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: scp.c,v 1.49 2001/01/13 18:03:07 markus Exp $");
+RCSID("$OpenBSD: scp.c,v 1.60 2001/03/02 18:54:31 deraadt Exp $");
 
-#include "ssh.h"
 #include "xmalloc.h"
-
-#ifndef _PATH_CP
-#define _PATH_CP "cp"
-#endif
+#include "atomicio.h"
+#include "pathnames.h"
+#include "log.h"
+#include "misc.h"
 
 #ifdef HAVE___PROGNAME
 extern char *__progname;
@@ -130,7 +129,7 @@ int verbose_mode = 0;
 int showprogress = 1;
 
 /* This is the program to execute for the secured connection. ("ssh" or -S) */
-char *ssh_program = SSH_PROGRAM;
+char *ssh_program = _PATH_SSH_PROGRAM;
 
 /* This is the list of arguments that scp passes to ssh */
 struct {
@@ -221,11 +220,13 @@ int pflag, iamremote, iamrecursive, targetshouldbedirectory;
 #define        CMDNEEDS        64
 char cmd[CMDNEEDS];            /* must hold "rcp -r -p -d\0" */
 
+int main(int, char *[]);
 int response(void);
 void rsource(char *, struct stat *);
 void sink(int, char *[]);
 void source(int, char *[]);
 void tolocal(int, char *[]);
+char *cleanhostname(char *);
 void toremote(char *, int, char *[]);
 void usage(void);
 
@@ -310,7 +311,7 @@ main(argc, argv)
        remin = STDIN_FILENO;
        remout = STDOUT_FILENO;
 
-       if (fflag) {    
+       if (fflag) {
                /* Follow "protocol", send data. */
                (void) response();
                source(argc, argv);
@@ -328,7 +329,8 @@ main(argc, argv)
 
        remin = remout = -1;
        /* Command to be executed on remote system using "ssh". */
-       (void) sprintf(cmd, "scp%s%s%s%s", verbose_mode ? " -v" : "",
+       (void) snprintf(cmd, sizeof cmd, "scp%s%s%s%s",
+           verbose_mode ? " -v" : "",
            iamrecursive ? " -r" : "", pflag ? " -p" : "",
            targetshouldbedirectory ? " -d" : "");
 
@@ -399,16 +401,18 @@ toremote(targ, argc, argv)
                                        suser = pwd->pw_name;
                                else if (!okname(suser))
                                        continue;
-                               sprintf(bp,
-                                   "%s%s -x -o'FallBackToRsh no' -n -l %s %s %s %s '%s%s%s:%s'",
+                               snprintf(bp, len,
+                                   "%s%s -x -o'FallBackToRsh no' -n "
+                                   "-l %s %s %s %s '%s%s%s:%s'",
                                    ssh_program, verbose_mode ? " -v" : "",
                                    suser, host, cmd, src,
                                    tuser ? tuser : "", tuser ? "@" : "",
                                    thost, targ);
                        } else {
                                host = cleanhostname(argv[i]);
-                               sprintf(bp,
-                                   "exec %s%s -x -o'FallBackToRsh no' -n %s %s %s '%s%s%s:%s'",
+                               snprintf(bp, len,
+                                   "exec %s%s -x -o'FallBackToRsh no' -n %s "
+                                   "%s %s '%s%s%s:%s'",
                                    ssh_program, verbose_mode ? " -v" : "",
                                    host, cmd, src,
                                    tuser ? tuser : "", tuser ? "@" : "",
@@ -422,7 +426,7 @@ toremote(targ, argc, argv)
                        if (remin == -1) {
                                len = strlen(targ) + CMDNEEDS + 20;
                                bp = xmalloc(len);
-                               (void) sprintf(bp, "%s -t %s", cmd, targ);
+                               (void) snprintf(bp, len, "%s -t %s", cmd, targ);
                                host = cleanhostname(thost);
                                if (do_cmd(host, tuser, bp, &remin,
                                    &remout, argc) < 0)
@@ -449,7 +453,7 @@ tolocal(argc, argv)
                        len = strlen(_PATH_CP) + strlen(argv[i]) +
                            strlen(argv[argc - 1]) + 20;
                        bp = xmalloc(len);
-                       (void) sprintf(bp, "exec %s%s%s %s %s", _PATH_CP,
+                       (void) snprintf(bp, len, "exec %s%s%s %s %s", _PATH_CP,
                            iamrecursive ? " -r" : "", pflag ? " -p" : "",
                            argv[i], argv[argc - 1]);
                        if (verbose_mode)
@@ -476,7 +480,7 @@ tolocal(argc, argv)
                host = cleanhostname(host);
                len = strlen(src) + CMDNEEDS + 20;
                bp = xmalloc(len);
-               (void) sprintf(bp, "%s -f %s", cmd, src);
+               (void) snprintf(bp, len, "%s -f %s", cmd, src);
                if (do_cmd(host, suser, bp, &remin, &remout, argc) < 0) {
                        (void) xfree(bp);
                        ++errs;
@@ -533,7 +537,7 @@ syserr:                     run_err("%s: %s", name, strerror(errno));
                         * Make it compatible with possible future
                         * versions expecting microseconds.
                         */
-                       (void) sprintf(buf, "T%lu 0 %lu 0\n",
+                       (void) snprintf(buf, sizeof buf, "T%lu 0 %lu 0\n",
                            (u_long) stb.st_mtime,
                            (u_long) stb.st_atime);
                        (void) atomicio(write, remout, buf, strlen(buf));
@@ -541,7 +545,7 @@ syserr:                     run_err("%s: %s", name, strerror(errno));
                                goto next;
                }
 #define        FILEMODEMASK    (S_ISUID|S_ISGID|S_IRWXU|S_IRWXG|S_IRWXO)
-               sprintf(buf, "C%04o %lu %s\n",
+               snprintf(buf, sizeof buf, "C%04o %lu %s\n",
                    (u_int) (stb.st_mode & FILEMODEMASK),
                    (u_long) stb.st_size, last);
                if (verbose_mode) {
@@ -610,7 +614,7 @@ rsource(name, statp)
        else
                last++;
        if (pflag) {
-               (void) sprintf(path, "T%lu 0 %lu 0\n",
+               (void) snprintf(path, sizeof(path), "T%lu 0 %lu 0\n",
                    (u_long) statp->st_mtime,
                    (u_long) statp->st_atime);
                (void) atomicio(write, remout, path, strlen(path));
@@ -619,7 +623,7 @@ rsource(name, statp)
                        return;
                }
        }
-       (void) sprintf(path, "D%04o %d %.1024s\n",
+       (void) snprintf(path, sizeof path, "D%04o %d %.1024s\n",
            (u_int) (statp->st_mode & FILEMODEMASK), 0, last);
        if (verbose_mode)
                fprintf(stderr, "Entering directory: %s", path);
@@ -637,7 +641,7 @@ rsource(name, statp)
                        run_err("%s/%s: name too long", name, dp->d_name);
                        continue;
                }
-               (void) sprintf(path, "%s/%s", name, dp->d_name);
+               (void) snprintf(path, sizeof path, "%s/%s", name, dp->d_name);
                vect[0] = path;
                source(1, vect);
        }
@@ -767,9 +771,13 @@ sink(argc, argv)
                        size_t need;
 
                        need = strlen(targ) + strlen(cp) + 250;
-                       if (need > cursize)
+                       if (need > cursize) {
+                               if (namebuf)
+                                       xfree(namebuf);
                                namebuf = xmalloc(need);
-                       (void) sprintf(namebuf, "%s%s%s", targ,
+                               cursize = need;
+                       }
+                       (void) snprintf(namebuf, need, "%s%s%s", targ,
                            *targ ? "/" : "", cp);
                        np = namebuf;
                } else
@@ -792,16 +800,18 @@ sink(argc, argv)
                                if (mkdir(np, mode | S_IRWXU) < 0)
                                        goto bad;
                        }
-                       vect[0] = np;
+                       vect[0] = xstrdup(np);
                        sink(1, vect);
                        if (setimes) {
                                setimes = 0;
-                               if (utimes(np, tv) < 0)
+                               if (utimes(vect[0], tv) < 0)
                                        run_err("%s: set times: %s",
-                                               np, strerror(errno));
+                                           vect[0], strerror(errno));
                        }
                        if (mod_flag)
-                               (void) chmod(np, mode);
+                               (void) chmod(vect[0], mode);
+                       if (vect[0])
+                               xfree(vect[0]);
                        continue;
                }
                omode = mode;
@@ -1062,7 +1072,7 @@ allocbuf(bp, fd, blksize)
                size = blksize + (stb.st_blksize - blksize % stb.st_blksize) %
                    stb.st_blksize;
 #else /* HAVE_ST_BLKSIZE */
-        size = blksize;
+       size = blksize;
 #endif /* HAVE_ST_BLKSIZE */
        if (bp->cnt >= size)
                return (bp);
@@ -1105,7 +1115,7 @@ updateprogressmeter(int ignore)
 }
 
 int
-foregroundproc()
+foregroundproc(void)
 {
        static pid_t pgrp = -1;
        int ctty_pgrp;
@@ -1113,11 +1123,7 @@ foregroundproc()
        if (pgrp == -1)
                pgrp = getpgrp();
 
-#ifdef HAVE_CYGWIN
-       /*
-        * Cygwin only supports tcgetpgrp() for getting the controlling tty
-         * currently.
-        */
+#ifdef HAVE_TCGETPGRP
        return ((ctty_pgrp = tcgetpgrp(STDOUT_FILENO)) != -1 &&
                ctty_pgrp == pgrp);
 #else
@@ -1170,8 +1176,9 @@ progressmeter(int flag)
                i++;
                abbrevsize >>= 10;
        }
-       snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), " %5d %c%c ",
-           (int) abbrevsize, prefixes[i], prefixes[i] == ' ' ? ' ' : 'B');
+       snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), " %5lu %c%c ",
+           (unsigned long) abbrevsize, prefixes[i],
+           prefixes[i] == ' ' ? ' ' : 'B');
 
        timersub(&now, &lastupdate, &wait);
        if (cursize > lastsize) {
@@ -1215,13 +1222,7 @@ progressmeter(int flag)
        atomicio(write, fileno(stdout), buf, strlen(buf));
 
        if (flag == -1) {
-               struct sigaction sa;
-               sa.sa_handler = updateprogressmeter;
-               sigemptyset((sigset_t *)&sa.sa_mask);
-#ifdef SA_RESTART
-               sa.sa_flags = SA_RESTART;
-#endif
-               sigaction(SIGALRM, &sa, NULL);
+               mysignal(SIGALRM, updateprogressmeter);
                alarmtimer(1);
        } else if (flag == 1) {
                alarmtimer(0);
This page took 0.066114 seconds and 4 git commands to generate.