]> andersk Git - openssh.git/blobdiff - channels.c
- jakob@cvs.openbsd.org 2001/08/02 16:14:05
[openssh.git] / channels.c
index 9397d48e5aeb964e5bddf9b0df1358144a29055d..7bf127d91571c59bae4da3e6f5e9068e208c5c58 100644 (file)
@@ -12,9 +12,8 @@
  * incompatible with the protocol description in the RFC file, it must be
  * called by a name other than "ssh" or "Secure Shell".
  *
- *
  * SSH2 support added by Markus Friedl.
- * Copyright (c) 1999,2000 Markus Friedl.  All rights reserved.
+ * Copyright (c) 1999, 2000, 2001 Markus Friedl.  All rights reserved.
  * Copyright (c) 1999 Dug Song.  All rights reserved.
  * Copyright (c) 1999 Theo de Raadt.  All rights reserved.
  *
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: channels.c,v 1.115 2001/05/09 22:51:57 markus Exp $");
-
-#include <openssl/rsa.h>
-#include <openssl/dsa.h>
+RCSID("$OpenBSD: channels.c,v 1.132 2001/07/17 21:04:56 markus Exp $");
 
 #include "ssh.h"
 #include "ssh1.h"
 #include "ssh2.h"
 #include "packet.h"
 #include "xmalloc.h"
-#include "buffer.h"
-#include "bufaux.h"
 #include "uidswap.h"
 #include "log.h"
 #include "misc.h"
 #include "channels.h"
-#include "nchan.h"
 #include "compat.h"
 #include "canohost.h"
 #include "key.h"
 #include "authfd.h"
 
-/* Maximum number of fake X11 displays to try. */
-#define MAX_DISPLAYS  1000
 
-/* Max len of agent socket */
-#define MAX_SOCKET_NAME 100
+/* -- channel core */
 
 /*
  * Pointer to an array containing all allocated channels.  The array is
@@ -86,23 +76,8 @@ static int channels_alloc = 0;
  */
 static int channel_max_fd = 0;
 
-/* Name and directory of socket for authentication agent forwarding. */
-static char *channel_forwarded_auth_socket_name = NULL;
-static char *channel_forwarded_auth_socket_dir = NULL;
-
-/* Saved X11 authentication protocol name. */
-char *x11_saved_proto = NULL;
-
-/* Saved X11 authentication data.  This is the real data. */
-char *x11_saved_data = NULL;
-u_int x11_saved_data_len = 0;
 
-/*
- * Fake X11 authentication data.  This is what the server will be sending us;
- * we should replace any occurrences of this by the real data.
- */
-char *x11_fake_data = NULL;
-u_int x11_fake_data_len;
+/* -- tcp forwarding */
 
 /*
  * Data structure for storing which hosts are permitted for forward requests.
@@ -118,6 +93,7 @@ typedef struct {
 
 /* List of all permitted host/port pairs to connect. */
 static ForwardPermission permitted_opens[SSH_MAX_FORWARDS_PER_DIRECTION];
+
 /* Number of permitted host/port pairs in the array. */
 static int num_permitted_opens = 0;
 /*
@@ -127,23 +103,42 @@ static int num_permitted_opens = 0;
  */
 static int all_opens_permitted = 0;
 
-/* This is set to true if both sides support SSH_PROTOFLAG_HOST_IN_FWD_OPEN. */
-static int have_hostname_in_open = 0;
 
-/* AF_UNSPEC or AF_INET or AF_INET6 */
-extern int IPv4or6;
+/* -- X11 forwarding */
+
+/* Maximum number of fake X11 displays to try. */
+#define MAX_DISPLAYS  1000
 
-void    port_open_helper(Channel *c, char *rtype);
+/* Saved X11 authentication protocol name. */
+static char *x11_saved_proto = NULL;
 
-/* Sets specific protocol options. */
+/* Saved X11 authentication data.  This is the real data. */
+static char *x11_saved_data = NULL;
+static u_int x11_saved_data_len = 0;
 
-void
-channel_set_options(int hostname_in_open)
-{
-       have_hostname_in_open = hostname_in_open;
-}
+/*
+ * Fake X11 authentication data.  This is what the server will be sending us;
+ * we should replace any occurrences of this by the real data.
+ */
+static char *x11_fake_data = NULL;
+static u_int x11_fake_data_len;
+
+
+/* -- agent forwarding */
+
+#define        NUM_SOCKS       10
+
+/* Name and directory of socket for authentication agent forwarding. */
+static char *auth_sock_name = NULL;
+static char *auth_sock_dir = NULL;
+
+/* AF_UNSPEC or AF_INET or AF_INET6 */
+extern int IPv4or6;
+
+/* helper */
+static void port_open_helper(Channel *c, char *rtype);
 
-/* lookup channel by id */
+/* -- channel core */
 
 Channel *
 channel_lookup(int id)
@@ -167,7 +162,7 @@ channel_lookup(int id)
  * when the channel consumer/producer is ready, e.g. shell exec'd
  */
 
-void
+static void
 channel_register_fds(Channel *c, int rfd, int wfd, int efd,
     int extusage, int nonblock)
 {
@@ -226,11 +221,7 @@ channel_new(char *ctype, int type, int rfd, int wfd, int efd,
                channels = xmalloc(channels_alloc * sizeof(Channel *));
                for (i = 0; i < channels_alloc; i++)
                        channels[i] = NULL;
-               /*
-                * Kludge: arrange a call to channel_stop_listening if we
-                * terminate with fatal().
-                */
-               fatal_add_cleanup((void (*) (void *)) channel_stop_listening, NULL);
+               fatal_add_cleanup((void (*) (void *)) channel_free_all, NULL);
        }
        /* Try to find a free slot where to put the new channel. */
        for (found = -1, i = 0; i < channels_alloc; i++)
@@ -269,62 +260,424 @@ channel_new(char *ctype, int type, int rfd, int wfd, int efd,
        c->cb_fn = NULL;
        c->cb_arg = NULL;
        c->cb_event = 0;
-       c->dettach_user = NULL;
+       c->detach_user = NULL;
        c->input_filter = NULL;
        debug("channel %d: new [%s]", found, remote_name);
        return c;
 }
 
+static int
+channel_find_maxfd(void)
+{
+       int i, max = 0;
+       Channel *c;
+
+       for (i = 0; i < channels_alloc; i++) {
+               c = channels[i];
+               if (c != NULL) {
+                       max = MAX(max, c->rfd);
+                       max = MAX(max, c->wfd);
+                       max = MAX(max, c->efd);
+               }
+       }
+       return max;
+}
+
+int
+channel_close_fd(int *fdp)
+{
+       int ret = 0, fd = *fdp;
+
+       if (fd != -1) {
+               ret = close(fd);
+               *fdp = -1;
+               if (fd == channel_max_fd)
+                       channel_max_fd = channel_find_maxfd();
+       }
+       return ret;
+}
+
 /* Close all channel fd/socket. */
 
-void
+static void
 channel_close_fds(Channel *c)
 {
-       if (c->sock != -1) {
-               close(c->sock);
-               c->sock = -1;
+       debug3("channel_close_fds: channel %d: r %d w %d e %d",
+           c->self, c->rfd, c->wfd, c->efd);
+
+       channel_close_fd(&c->sock);
+       channel_close_fd(&c->rfd);
+       channel_close_fd(&c->wfd);
+       channel_close_fd(&c->efd);
+}
+
+/* Free the channel and close its fd/socket. */
+
+void
+channel_free(Channel *c)
+{
+       char *s;
+       int i, n;
+
+       for (n = 0, i = 0; i < channels_alloc; i++)
+               if (channels[i])
+                       n++;
+       debug("channel_free: channel %d: %s, nchannels %d", c->self,
+           c->remote_name ? c->remote_name : "???", n);
+
+       s = channel_open_message();
+       debug3("channel_free: status: %s", s);
+       xfree(s);
+
+       if (c->detach_user != NULL) {
+               debug("channel_free: channel %d: detaching channel user", c->self);
+               c->detach_user(c->self, NULL);
        }
-       if (c->rfd != -1) {
-               close(c->rfd);
-               c->rfd = -1;
+       if (c->sock != -1)
+               shutdown(c->sock, SHUT_RDWR);
+       channel_close_fds(c);
+       buffer_free(&c->input);
+       buffer_free(&c->output);
+       buffer_free(&c->extended);
+       if (c->remote_name) {
+               xfree(c->remote_name);
+               c->remote_name = NULL;
        }
-       if (c->wfd != -1) {
-               close(c->wfd);
-               c->wfd = -1;
+       channels[c->self] = NULL;
+       xfree(c);
+}
+
+void
+channel_free_all(void)
+{
+       int i;
+
+       for (i = 0; i < channels_alloc; i++)
+               if (channels[i] != NULL)
+                       channel_free(channels[i]);
+}
+
+void
+channel_detach_all(void)
+{
+       int i;
+       Channel *c;
+
+       for (i = 0; i < channels_alloc; i++) {
+               c = channels[i];
+               if (c != NULL && c->detach_user != NULL) {
+                       debug("channel_detach_all: channel %d", c->self);
+                       c->detach_user(c->self, NULL);
+                       c->detach_user = NULL;
+               }
        }
-       if (c->efd != -1) {
-               close(c->efd);
-               c->efd = -1;
+}
+
+/*
+ * Closes the sockets/fds of all channels.  This is used to close extra file
+ * descriptors after a fork.
+ */
+
+void
+channel_close_all()
+{
+       int i;
+
+       for (i = 0; i < channels_alloc; i++)
+               if (channels[i] != NULL)
+                       channel_close_fds(channels[i]);
+}
+
+/*
+ * Stop listening to channels.
+ */
+
+void
+channel_stop_listening(void)
+{
+       int i;
+       Channel *c;
+
+       for (i = 0; i < channels_alloc; i++) {
+               c = channels[i];
+               if (c != NULL) {
+                       switch (c->type) {
+                       case SSH_CHANNEL_AUTH_SOCKET:
+                       case SSH_CHANNEL_PORT_LISTENER:
+                       case SSH_CHANNEL_RPORT_LISTENER:
+                       case SSH_CHANNEL_X11_LISTENER:
+                               channel_close_fd(&c->sock);
+                               channel_free(c);
+                               break;
+                       }
+               }
+       }
+}
+
+/*
+ * Returns true if no channel has too much buffered data, and false if one or
+ * more channel is overfull.
+ */
+
+int
+channel_not_very_much_buffered_data()
+{
+       u_int i;
+       Channel *c;
+
+       for (i = 0; i < channels_alloc; i++) {
+               c = channels[i];
+               if (c != NULL && c->type == SSH_CHANNEL_OPEN) {
+                       if (!compat20 && buffer_len(&c->input) > packet_get_maxsize()) {
+                               debug("channel %d: big input buffer %d",
+                                   c->self, buffer_len(&c->input));
+                               return 0;
+                       }
+                       if (buffer_len(&c->output) > packet_get_maxsize()) {
+                               debug("channel %d: big output buffer %d",
+                                   c->self, buffer_len(&c->output));
+                               return 0;
+                       }
+               }
+       }
+       return 1;
+}
+
+/* Returns true if any channel is still open. */
+
+int
+channel_still_open()
+{
+       int i;
+       Channel *c;
+
+       for (i = 0; i < channels_alloc; i++) {
+               c = channels[i];
+               if (c == NULL)
+                       continue;
+               switch (c->type) {
+               case SSH_CHANNEL_X11_LISTENER:
+               case SSH_CHANNEL_PORT_LISTENER:
+               case SSH_CHANNEL_RPORT_LISTENER:
+               case SSH_CHANNEL_CLOSED:
+               case SSH_CHANNEL_AUTH_SOCKET:
+               case SSH_CHANNEL_DYNAMIC:
+               case SSH_CHANNEL_CONNECTING:
+               case SSH_CHANNEL_ZOMBIE:
+                       continue;
+               case SSH_CHANNEL_LARVAL:
+                       if (!compat20)
+                               fatal("cannot happen: SSH_CHANNEL_LARVAL");
+                       continue;
+               case SSH_CHANNEL_OPENING:
+               case SSH_CHANNEL_OPEN:
+               case SSH_CHANNEL_X11_OPEN:
+                       return 1;
+               case SSH_CHANNEL_INPUT_DRAINING:
+               case SSH_CHANNEL_OUTPUT_DRAINING:
+                       if (!compat13)
+                               fatal("cannot happen: OUT_DRAIN");
+                       return 1;
+               default:
+                       fatal("channel_still_open: bad channel type %d", c->type);
+                       /* NOTREACHED */
+               }
+       }
+       return 0;
+}
+
+/* Returns the id of an open channel suitable for keepaliving */
+
+int
+channel_find_open()
+{
+       int i;
+       Channel *c;
+
+       for (i = 0; i < channels_alloc; i++) {
+               c = channels[i];
+               if (c == NULL)
+                       continue;
+               switch (c->type) {
+               case SSH_CHANNEL_CLOSED:
+               case SSH_CHANNEL_DYNAMIC:
+               case SSH_CHANNEL_X11_LISTENER:
+               case SSH_CHANNEL_PORT_LISTENER:
+               case SSH_CHANNEL_RPORT_LISTENER:
+               case SSH_CHANNEL_OPENING:
+               case SSH_CHANNEL_CONNECTING:
+               case SSH_CHANNEL_ZOMBIE:
+                       continue;
+               case SSH_CHANNEL_LARVAL:
+               case SSH_CHANNEL_AUTH_SOCKET:
+               case SSH_CHANNEL_OPEN:
+               case SSH_CHANNEL_X11_OPEN:
+                       return i;
+               case SSH_CHANNEL_INPUT_DRAINING:
+               case SSH_CHANNEL_OUTPUT_DRAINING:
+                       if (!compat13)
+                               fatal("cannot happen: OUT_DRAIN");
+                       return i;
+               default:
+                       fatal("channel_find_open: bad channel type %d", c->type);
+                       /* NOTREACHED */
+               }
+       }
+       return -1;
+}
+
+
+/*
+ * Returns a message describing the currently open forwarded connections,
+ * suitable for sending to the client.  The message contains crlf pairs for
+ * newlines.
+ */
+
+char *
+channel_open_message()
+{
+       Buffer buffer;
+       Channel *c;
+       char buf[1024], *cp;
+       int i;
+
+       buffer_init(&buffer);
+       snprintf(buf, sizeof buf, "The following connections are open:\r\n");
+       buffer_append(&buffer, buf, strlen(buf));
+       for (i = 0; i < channels_alloc; i++) {
+               c = channels[i];
+               if (c == NULL)
+                       continue;
+               switch (c->type) {
+               case SSH_CHANNEL_X11_LISTENER:
+               case SSH_CHANNEL_PORT_LISTENER:
+               case SSH_CHANNEL_RPORT_LISTENER:
+               case SSH_CHANNEL_CLOSED:
+               case SSH_CHANNEL_AUTH_SOCKET:
+               case SSH_CHANNEL_ZOMBIE:
+                       continue;
+               case SSH_CHANNEL_LARVAL:
+               case SSH_CHANNEL_OPENING:
+               case SSH_CHANNEL_CONNECTING:
+               case SSH_CHANNEL_DYNAMIC:
+               case SSH_CHANNEL_OPEN:
+               case SSH_CHANNEL_X11_OPEN:
+               case SSH_CHANNEL_INPUT_DRAINING:
+               case SSH_CHANNEL_OUTPUT_DRAINING:
+                       snprintf(buf, sizeof buf, "  #%d %.300s (t%d r%d i%d/%d o%d/%d fd %d/%d)\r\n",
+                           c->self, c->remote_name,
+                           c->type, c->remote_id,
+                           c->istate, buffer_len(&c->input),
+                           c->ostate, buffer_len(&c->output),
+                           c->rfd, c->wfd);
+                       buffer_append(&buffer, buf, strlen(buf));
+                       continue;
+               default:
+                       fatal("channel_open_message: bad channel type %d", c->type);
+                       /* NOTREACHED */
+               }
+       }
+       buffer_append(&buffer, "\0", 1);
+       cp = xstrdup(buffer_ptr(&buffer));
+       buffer_free(&buffer);
+       return cp;
+}
+
+void
+channel_send_open(int id)
+{
+       Channel *c = channel_lookup(id);
+       if (c == NULL) {
+               log("channel_send_open: %d: bad id", id);
+               return;
+       }
+       debug("send channel open %d", id);
+       packet_start(SSH2_MSG_CHANNEL_OPEN);
+       packet_put_cstring(c->ctype);
+       packet_put_int(c->self);
+       packet_put_int(c->local_window);
+       packet_put_int(c->local_maxpacket);
+       packet_send();
+}
+
+void
+channel_request(int id, char *service, int wantconfirm)
+{
+       channel_request_start(id, service, wantconfirm);
+       packet_send();
+       debug("channel request %d: %s", id, service) ;
+}
+void
+channel_request_start(int id, char *service, int wantconfirm)
+{
+       Channel *c = channel_lookup(id);
+       if (c == NULL) {
+               log("channel_request: %d: bad id", id);
+               return;
+       }
+       packet_start(SSH2_MSG_CHANNEL_REQUEST);
+       packet_put_int(c->remote_id);
+       packet_put_cstring(service);
+       packet_put_char(wantconfirm);
+}
+void
+channel_register_callback(int id, int mtype, channel_callback_fn *fn, void *arg)
+{
+       Channel *c = channel_lookup(id);
+       if (c == NULL) {
+               log("channel_register_callback: %d: bad id", id);
+               return;
+       }
+       c->cb_event = mtype;
+       c->cb_fn = fn;
+       c->cb_arg = arg;
+}
+void
+channel_register_cleanup(int id, channel_callback_fn *fn)
+{
+       Channel *c = channel_lookup(id);
+       if (c == NULL) {
+               log("channel_register_cleanup: %d: bad id", id);
+               return;
+       }
+       c->detach_user = fn;
+}
+void
+channel_cancel_cleanup(int id)
+{
+       Channel *c = channel_lookup(id);
+       if (c == NULL) {
+               log("channel_cancel_cleanup: %d: bad id", id);
+               return;
+       }
+       c->detach_user = NULL;
+}
+void
+channel_register_filter(int id, channel_filter_fn *fn)
+{
+       Channel *c = channel_lookup(id);
+       if (c == NULL) {
+               log("channel_register_filter: %d: bad id", id);
+               return;
        }
+       c->input_filter = fn;
 }
 
-/* Free the channel and close its fd/socket. */
-
 void
-channel_free(Channel *c)
+channel_set_fds(int id, int rfd, int wfd, int efd,
+    int extusage, int nonblock)
 {
-       char *s;
-
-       s = channel_open_message();
-       debug("channel_free: channel %d: status: %s", c->self, s);
-       xfree(s);
-
-       if (c->dettach_user != NULL) {
-               debug("channel_free: channel %d: dettaching channel user", c->self);
-               c->dettach_user(c->self, NULL);
-       }
-       if (c->sock != -1)
-               shutdown(c->sock, SHUT_RDWR);
-       channel_close_fds(c);
-       buffer_free(&c->input);
-       buffer_free(&c->output);
-       buffer_free(&c->extended);
-       if (c->remote_name) {
-               xfree(c->remote_name);
-               c->remote_name = NULL;
-       }
-       channels[c->self] = NULL;
-       xfree(c);
+       Channel *c = channel_lookup(id);
+       if (c == NULL || c->type != SSH_CHANNEL_LARVAL)
+               fatal("channel_activate for non-larval channel %d.", id);
+       channel_register_fds(c, rfd, wfd, efd, extusage, nonblock);
+       c->type = SSH_CHANNEL_OPEN;
+       /* XXX window size? */
+       c->local_window = c->local_window_max = c->local_maxpacket * 2;
+       packet_start(SSH2_MSG_CHANNEL_WINDOW_ADJUST);
+       packet_put_int(c->remote_id);
+       packet_put_int(c->local_window);
+       packet_send();
 }
 
 /*
@@ -339,20 +692,20 @@ typedef void chan_fn(Channel *c, fd_set * readset, fd_set * writeset);
 chan_fn *channel_pre[SSH_CHANNEL_MAX_TYPE];
 chan_fn *channel_post[SSH_CHANNEL_MAX_TYPE];
 
-void
+static void
 channel_pre_listener(Channel *c, fd_set * readset, fd_set * writeset)
 {
        FD_SET(c->sock, readset);
 }
 
-void
+static void
 channel_pre_connecting(Channel *c, fd_set * readset, fd_set * writeset)
 {
        debug3("channel %d: waiting for connection", c->self);
        FD_SET(c->sock, writeset);
 }
 
-void
+static void
 channel_pre_open_13(Channel *c, fd_set * readset, fd_set * writeset)
 {
        if (buffer_len(&c->input) < packet_get_maxsize())
@@ -361,7 +714,7 @@ channel_pre_open_13(Channel *c, fd_set * readset, fd_set * writeset)
                FD_SET(c->sock, writeset);
 }
 
-void
+static void
 channel_pre_open_15(Channel *c, fd_set * readset, fd_set * writeset)
 {
        /* test whether sockets are 'alive' for read/write */
@@ -378,7 +731,7 @@ channel_pre_open_15(Channel *c, fd_set * readset, fd_set * writeset)
        }
 }
 
-void
+static void
 channel_pre_open_20(Channel *c, fd_set * readset, fd_set * writeset)
 {
        if (c->istate == CHAN_INPUT_OPEN &&
@@ -404,7 +757,7 @@ channel_pre_open_20(Channel *c, fd_set * readset, fd_set * writeset)
        }
 }
 
-void
+static void
 channel_pre_input_draining(Channel *c, fd_set * readset, fd_set * writeset)
 {
        if (buffer_len(&c->input) == 0) {
@@ -416,7 +769,7 @@ channel_pre_input_draining(Channel *c, fd_set * readset, fd_set * writeset)
        }
 }
 
-void
+static void
 channel_pre_output_draining(Channel *c, fd_set * readset, fd_set * writeset)
 {
        if (buffer_len(&c->output) == 0)
@@ -432,19 +785,20 @@ channel_pre_output_draining(Channel *c, fd_set * readset, fd_set * writeset)
  * data in that packet is then substituted by the real data if it matches the
  * fake data, and the channel is put into normal mode.
  * XXX All this happens at the client side.
+ * Returns: 0 = need more data, -1 = wrong cookie, 1 = ok
  */
-int
-x11_open_helper(Channel *c)
+static int
+x11_open_helper(Buffer *b)
 {
        u_char *ucp;
        u_int proto_len, data_len;
 
        /* Check if the fixed size part of the packet is in buffer. */
-       if (buffer_len(&c->output) < 12)
+       if (buffer_len(b) < 12)
                return 0;
 
        /* Parse the lengths of variable-length fields. */
-       ucp = (u_char *) buffer_ptr(&c->output);
+       ucp = (u_char *) buffer_ptr(b);
        if (ucp[0] == 0x42) {   /* Byte order MSB first. */
                proto_len = 256 * ucp[6] + ucp[7];
                data_len = 256 * ucp[8] + ucp[9];
@@ -458,7 +812,7 @@ x11_open_helper(Channel *c)
        }
 
        /* Check if the whole packet is in buffer. */
-       if (buffer_len(&c->output) <
+       if (buffer_len(b) <
            12 + ((proto_len + 3) & ~3) + ((data_len + 3) & ~3))
                return 0;
 
@@ -491,10 +845,10 @@ x11_open_helper(Channel *c)
        return 1;
 }
 
-void
+static void
 channel_pre_x11_open_13(Channel *c, fd_set * readset, fd_set * writeset)
 {
-       int ret = x11_open_helper(c);
+       int ret = x11_open_helper(&c->output);
        if (ret == 1) {
                /* Start normal processing for the channel. */
                c->type = SSH_CHANNEL_OPEN;
@@ -507,7 +861,7 @@ channel_pre_x11_open_13(Channel *c, fd_set * readset, fd_set * writeset)
                log("X11 connection rejected because of wrong authentication.");
                buffer_clear(&c->input);
                buffer_clear(&c->output);
-               close(c->sock);
+               channel_close_fd(&c->sock);
                c->sock = -1;
                c->type = SSH_CHANNEL_CLOSED;
                packet_start(SSH_MSG_CHANNEL_CLOSE);
@@ -516,10 +870,10 @@ channel_pre_x11_open_13(Channel *c, fd_set * readset, fd_set * writeset)
        }
 }
 
-void
+static void
 channel_pre_x11_open(Channel *c, fd_set * readset, fd_set * writeset)
 {
-       int ret = x11_open_helper(c);
+       int ret = x11_open_helper(&c->output);
        if (ret == 1) {
                c->type = SSH_CHANNEL_OPEN;
                if (compat20)
@@ -535,7 +889,7 @@ channel_pre_x11_open(Channel *c, fd_set * readset, fd_set * writeset)
 }
 
 /* try to decode a socks4 header */
-int
+static int
 channel_decode_socks4(Channel *c, fd_set * readset, fd_set * writeset)
 {
        u_char *p, *host;
@@ -605,7 +959,7 @@ channel_decode_socks4(Channel *c, fd_set * readset, fd_set * writeset)
 }
 
 /* dynamic port forwarding */
-void
+static void
 channel_pre_dynamic(Channel *c, fd_set * readset, fd_set * writeset)
 {
        u_char *p;
@@ -645,7 +999,7 @@ channel_pre_dynamic(Channel *c, fd_set * readset, fd_set * writeset)
 }
 
 /* This is our fake X11 server socket. */
-void
+static void
 channel_post_x11_listener(Channel *c, fd_set * readset, fd_set * writeset)
 {
        Channel *nc;
@@ -694,15 +1048,16 @@ channel_post_x11_listener(Channel *c, fd_set * readset, fd_set * writeset)
                } else {
                        packet_start(SSH_SMSG_X11_OPEN);
                        packet_put_int(nc->self);
-                       if (have_hostname_in_open)
-                               packet_put_string(buf, strlen(buf));
+                       if (packet_get_protocol_flags() &
+                           SSH_PROTOFLAG_HOST_IN_FWD_OPEN)
+                               packet_put_cstring(buf);
                        packet_send();
                }
                xfree(remote_ipaddr);
        }
 }
 
-void
+static void
 port_open_helper(Channel *c, char *rtype)
 {
        int direct;
@@ -745,7 +1100,8 @@ port_open_helper(Channel *c, char *rtype)
                packet_put_int(c->self);
                packet_put_cstring(c->path);
                packet_put_int(c->host_port);
-               if (have_hostname_in_open)
+               if (packet_get_protocol_flags() &
+                   SSH_PROTOFLAG_HOST_IN_FWD_OPEN)
                        packet_put_cstring(c->remote_name);
                packet_send();
        }
@@ -755,7 +1111,7 @@ port_open_helper(Channel *c, char *rtype)
 /*
  * This socket is listening for connections to a forwarded TCP/IP port.
  */
-void
+static void
 channel_post_port_listener(Channel *c, fd_set * readset, fd_set * writeset)
 {
        Channel *nc;
@@ -803,10 +1159,11 @@ channel_post_port_listener(Channel *c, fd_set * readset, fd_set * writeset)
  * This is the authentication agent socket listening for connections from
  * clients.
  */
-void
+static void
 channel_post_auth_listener(Channel *c, fd_set * readset, fd_set * writeset)
 {
        Channel *nc;
+       char *name;
        int newsock;
        struct sockaddr addr;
        socklen_t addrlen;
@@ -818,12 +1175,14 @@ channel_post_auth_listener(Channel *c, fd_set * readset, fd_set * writeset)
                        error("accept from auth socket: %.100s", strerror(errno));
                        return;
                }
+               name = xstrdup("accepted auth socket");
                nc = channel_new("accepted auth socket",
                    SSH_CHANNEL_OPENING, newsock, newsock, -1,
                    c->local_window_max, c->local_maxpacket,
-                   0, xstrdup("accepted auth socket"), 1);
+                   0, name, 1);
                if (nc == NULL) {
                        error("channel_post_auth_listener: channel_new failed");
+                       xfree(name);
                        close(newsock);
                }
                if (compat20) {
@@ -840,11 +1199,11 @@ channel_post_auth_listener(Channel *c, fd_set * readset, fd_set * writeset)
        }
 }
 
-void
+static void
 channel_post_connecting(Channel *c, fd_set * readset, fd_set * writeset)
 {
        int err = 0;
-       int sz = sizeof(err);
+       socklen_t sz = sizeof(err);
 
        if (FD_ISSET(c->sock, writeset)) {
                if (getsockopt(c->sock, SOL_SOCKET, SO_ERROR, (char *)&err,
@@ -887,7 +1246,7 @@ channel_post_connecting(Channel *c, fd_set * readset, fd_set * writeset)
        }
 }
 
-int
+static int
 channel_handle_rfd(Channel *c, fd_set * readset, fd_set * writeset)
 {
        char buf[16*1024];
@@ -908,7 +1267,7 @@ channel_handle_rfd(Channel *c, fd_set * readset, fd_set * writeset)
                        } else if (compat13) {
                                buffer_consume(&c->output, buffer_len(&c->output));
                                c->type = SSH_CHANNEL_INPUT_DRAINING;
-                               debug("channel %d: status set to input draining.", c->self);
+                               debug("channel %d: input draining.", c->self);
                        } else {
                                chan_read_failed(c);
                        }
@@ -925,7 +1284,7 @@ channel_handle_rfd(Channel *c, fd_set * readset, fd_set * writeset)
        }
        return 1;
 }
-int
+static int
 channel_handle_wfd(Channel *c, fd_set * readset, fd_set * writeset)
 {
        struct termios tio;
@@ -946,7 +1305,7 @@ channel_handle_wfd(Channel *c, fd_set * readset, fd_set * writeset)
                                return -1;
                        } else if (compat13) {
                                buffer_consume(&c->output, buffer_len(&c->output));
-                               debug("channel %d: status set to input draining.", c->self);
+                               debug("channel %d: input draining.", c->self);
                                c->type = SSH_CHANNEL_INPUT_DRAINING;
                        } else {
                                chan_write_failed(c);
@@ -973,7 +1332,7 @@ channel_handle_wfd(Channel *c, fd_set * readset, fd_set * writeset)
        }
        return 1;
 }
-int
+static int
 channel_handle_efd(Channel *c, fd_set * readset, fd_set * writeset)
 {
        char buf[16*1024];
@@ -993,8 +1352,7 @@ channel_handle_efd(Channel *c, fd_set * readset, fd_set * writeset)
                        if (len <= 0) {
                                debug2("channel %d: closing write-efd %d",
                                    c->self, c->efd);
-                               close(c->efd);
-                               c->efd = -1;
+                               channel_close_fd(&c->efd);
                        } else {
                                buffer_consume(&c->extended, len);
                                c->local_consumed += len;
@@ -1009,8 +1367,7 @@ channel_handle_efd(Channel *c, fd_set * readset, fd_set * writeset)
                        if (len <= 0) {
                                debug2("channel %d: closing read-efd %d",
                                    c->self, c->efd);
-                               close(c->efd);
-                               c->efd = -1;
+                               channel_close_fd(&c->efd);
                        } else {
                                buffer_append(&c->extended, buf, len);
                        }
@@ -1018,7 +1375,7 @@ channel_handle_efd(Channel *c, fd_set * readset, fd_set * writeset)
        }
        return 1;
 }
-int
+static int
 channel_check_window(Channel *c)
 {
        if (c->type == SSH_CHANNEL_OPEN &&
@@ -1038,14 +1395,14 @@ channel_check_window(Channel *c)
        return 1;
 }
 
-void
+static void
 channel_post_open_1(Channel *c, fd_set * readset, fd_set * writeset)
 {
        channel_handle_rfd(c, readset, writeset);
        channel_handle_wfd(c, readset, writeset);
 }
 
-void
+static void
 channel_post_open_2(Channel *c, fd_set * readset, fd_set * writeset)
 {
        channel_handle_rfd(c, readset, writeset);
@@ -1055,7 +1412,7 @@ channel_post_open_2(Channel *c, fd_set * readset, fd_set * writeset)
        channel_check_window(c);
 }
 
-void
+static void
 channel_post_output_drain_13(Channel *c, fd_set * readset, fd_set * writeset)
 {
        int len;
@@ -1070,7 +1427,7 @@ channel_post_output_drain_13(Channel *c, fd_set * readset, fd_set * writeset)
        }
 }
 
-void
+static void
 channel_handler_init_20(void)
 {
        channel_pre[SSH_CHANNEL_OPEN] =                 &channel_pre_open_20;
@@ -1091,7 +1448,7 @@ channel_handler_init_20(void)
        channel_post[SSH_CHANNEL_DYNAMIC] =             &channel_post_open_2;
 }
 
-void
+static void
 channel_handler_init_13(void)
 {
        channel_pre[SSH_CHANNEL_OPEN] =                 &channel_pre_open_13;
@@ -1113,7 +1470,7 @@ channel_handler_init_13(void)
        channel_post[SSH_CHANNEL_DYNAMIC] =             &channel_post_open_1;
 }
 
-void
+static void
 channel_handler_init_15(void)
 {
        channel_pre[SSH_CHANNEL_OPEN] =                 &channel_pre_open_15;
@@ -1132,7 +1489,7 @@ channel_handler_init_15(void)
        channel_post[SSH_CHANNEL_DYNAMIC] =             &channel_post_open_1;
 }
 
-void
+static void
 channel_handler_init(void)
 {
        int i;
@@ -1148,7 +1505,7 @@ channel_handler_init(void)
                channel_handler_init_15();
 }
 
-void
+static void
 channel_handler(chan_fn *ftab[], fd_set * readset, fd_set * writeset)
 {
        static int did_init = 0;
@@ -1163,9 +1520,8 @@ channel_handler(chan_fn *ftab[], fd_set * readset, fd_set * writeset)
                c = channels[i];
                if (c == NULL)
                        continue;
-               if (ftab[c->type] == NULL)
-                       continue;
-               (*ftab[c->type])(c, readset, writeset);
+               if (ftab[c->type] != NULL)
+                       (*ftab[c->type])(c, readset, writeset);
                if (chan_is_dead(c)) {
                        /*
                         * we have to remove the fd's from the select mask
@@ -1187,9 +1543,13 @@ channel_handler(chan_fn *ftab[], fd_set * readset, fd_set * writeset)
        }
 }
 
+/*
+ * Allocate/update select bitmasks and add any bits relevant to channels in
+ * select bitmasks.
+ */
 void
 channel_prepare_select(fd_set **readsetp, fd_set **writesetp, int *maxfdp,
-    int rekeying)
+    int *nallocp, int rekeying)
 {
        int n;
        u_int sz;
@@ -1197,15 +1557,13 @@ channel_prepare_select(fd_set **readsetp, fd_set **writesetp, int *maxfdp,
        n = MAX(*maxfdp, channel_max_fd);
 
        sz = howmany(n+1, NFDBITS) * sizeof(fd_mask);
-       if (*readsetp == NULL || n > *maxfdp) {
-               if (*readsetp)
-                       xfree(*readsetp);
-               if (*writesetp)
-                       xfree(*writesetp);
-               *readsetp = xmalloc(sz);
-               *writesetp = xmalloc(sz);
-               *maxfdp = n;
+       /* perhaps check sz < nalloc/2 and shrink? */
+       if (*readsetp == NULL || sz > *nallocp) {
+               *readsetp = xrealloc(*readsetp, sz);
+               *writesetp = xrealloc(*writesetp, sz);
+               *nallocp = sz;
        }
+       *maxfdp = n;
        memset(*readsetp, 0, sz);
        memset(*writesetp, 0, sz);
 
@@ -1213,12 +1571,17 @@ channel_prepare_select(fd_set **readsetp, fd_set **writesetp, int *maxfdp,
                channel_handler(channel_pre, *readsetp, *writesetp);
 }
 
+/*
+ * After select, perform any appropriate operations for channels which have
+ * events pending.
+ */
 void
 channel_after_select(fd_set * readset, fd_set * writeset)
 {
        channel_handler(channel_post, readset, writeset);
 }
 
+
 /* If there is data to send to the connection, enqueue some of it now. */
 
 void
@@ -1228,12 +1591,14 @@ channel_output_poll()
        Channel *c;
 
        for (i = 0; i < channels_alloc; i++) {
-
                c = channels[i];
                if (c == NULL)
                        continue;
 
-               /* We are only interested in channels that can have buffered incoming data. */
+               /*
+                * We are only interested in channels that can have buffered
+                * incoming data.
+                */
                if (compat13) {
                        if (c->type != SSH_CHANNEL_OPEN &&
                            c->type != SSH_CHANNEL_INPUT_DRAINING)
@@ -1253,7 +1618,10 @@ channel_output_poll()
                if ((c->istate == CHAN_INPUT_OPEN ||
                    c->istate == CHAN_INPUT_WAIT_DRAIN) &&
                    (len = buffer_len(&c->input)) > 0) {
-                       /* Send some data for the other side over the secure connection. */
+                       /*
+                        * Send some data for the other side over the secure
+                        * connection.
+                        */
                        if (compat20) {
                                if (len > c->remote_window)
                                        len = c->remote_window;
@@ -1311,11 +1679,8 @@ channel_output_poll()
        }
 }
 
-/*
- * This is called when a packet of type CHANNEL_DATA has just been received.
- * The message type has already been consumed, but channel number and data is
- * still there.
- */
+
+/* -- protocol input */
 
 void
 channel_input_data(int type, int plen, void *ctxt)
@@ -1362,6 +1727,7 @@ channel_input_data(int type, int plen, void *ctxt)
        buffer_append(&c->output, data, data_len);
        xfree(data);
 }
+
 void
 channel_input_extended_data(int type, int plen, void *ctxt)
 {
@@ -1402,36 +1768,6 @@ channel_input_extended_data(int type, int plen, void *ctxt)
        xfree(data);
 }
 
-
-/*
- * Returns true if no channel has too much buffered data, and false if one or
- * more channel is overfull.
- */
-
-int
-channel_not_very_much_buffered_data()
-{
-       u_int i;
-       Channel *c;
-
-       for (i = 0; i < channels_alloc; i++) {
-               c = channels[i];
-               if (c != NULL && c->type == SSH_CHANNEL_OPEN) {
-                       if (!compat20 && buffer_len(&c->input) > packet_get_maxsize()) {
-                               debug("channel %d: big input buffer %d",
-                                   c->self, buffer_len(&c->input));
-                               return 0;
-                       }
-                       if (buffer_len(&c->output) > packet_get_maxsize()) {
-                               debug("channel %d: big output buffer %d",
-                                   c->self, buffer_len(&c->output));
-                               return 0;
-                       }
-               }
-       }
-       return 1;
-}
-
 void
 channel_input_ieof(int type, int plen, void *ctxt)
 {
@@ -1547,7 +1883,7 @@ channel_input_open_confirmation(int type, int plen, void *ctxt)
        }
 }
 
-char *
+static char *
 reason2txt(int reason)
 {
        switch(reason) {
@@ -1560,7 +1896,7 @@ reason2txt(int reason)
        case SSH2_OPEN_RESOURCE_SHORTAGE:
                return "resource shortage";
        }
-       return "unkown reason";
+       return "unknown reason";
 }
 
 void
@@ -1618,219 +1954,75 @@ channel_input_channel_request(int type, int plen, void *ctxt)
                char *service = packet_get_string(NULL);
                debug("channel %d: rcvd request for %s", c->self, service);
                debug("cb_fn %p cb_event %d", c->cb_fn , c->cb_event);
-               xfree(service);
-       }
-}
-
-void
-channel_input_window_adjust(int type, int plen, void *ctxt)
-{
-       Channel *c;
-       int id, adjust;
-
-       if (!compat20)
-               return;
-
-       /* Get the channel number and verify it. */
-       id = packet_get_int();
-       c = channel_lookup(id);
-
-       if (c == NULL || c->type != SSH_CHANNEL_OPEN) {
-               log("Received window adjust for "
-                   "non-open channel %d.", id);
-               return;
-       }
-       adjust = packet_get_int();
-       packet_done();
-       debug2("channel %d: rcvd adjust %d", id, adjust);
-       c->remote_window += adjust;
-}
-
-/*
- * Stops listening for channels, and removes any unix domain sockets that we
- * might have.
- */
-
-void
-channel_stop_listening()
-{
-       int i;
-       Channel *c;
-
-       for (i = 0; i < channels_alloc; i++) {
-               c = channels[i];
-               if (c != NULL) {
-                       switch (c->type) {
-                       case SSH_CHANNEL_AUTH_SOCKET:
-                               close(c->sock);
-                               unlink(c->path);
-                               channel_free(c);
-                               break;
-                       case SSH_CHANNEL_PORT_LISTENER:
-                       case SSH_CHANNEL_RPORT_LISTENER:
-                       case SSH_CHANNEL_X11_LISTENER:
-                               close(c->sock);
-                               channel_free(c);
-                               break;
-                       default:
-                               break;
-                       }
-               }
-       }
-}
-
-/*
- * Closes the sockets/fds of all channels.  This is used to close extra file
- * descriptors after a fork.
- */
-
-void
-channel_close_all()
-{
-       int i;
-
-       for (i = 0; i < channels_alloc; i++)
-               if (channels[i] != NULL)
-                       channel_close_fds(channels[i]);
-}
-
-/* Returns true if any channel is still open. */
-
-int
-channel_still_open()
-{
-       int i;
-       Channel *c;
-
-       for (i = 0; i < channels_alloc; i++) {
-               c = channels[i];
-               if (c == NULL)
-                       continue;
-               switch (c->type) {
-               case SSH_CHANNEL_X11_LISTENER:
-               case SSH_CHANNEL_PORT_LISTENER:
-               case SSH_CHANNEL_RPORT_LISTENER:
-               case SSH_CHANNEL_CLOSED:
-               case SSH_CHANNEL_AUTH_SOCKET:
-               case SSH_CHANNEL_DYNAMIC:
-               case SSH_CHANNEL_CONNECTING:
-                       continue;
-               case SSH_CHANNEL_LARVAL:
-                       if (!compat20)
-                               fatal("cannot happen: SSH_CHANNEL_LARVAL");
-                       continue;
-               case SSH_CHANNEL_OPENING:
-               case SSH_CHANNEL_OPEN:
-               case SSH_CHANNEL_X11_OPEN:
-                       return 1;
-               case SSH_CHANNEL_INPUT_DRAINING:
-               case SSH_CHANNEL_OUTPUT_DRAINING:
-                       if (!compat13)
-                               fatal("cannot happen: OUT_DRAIN");
-                       return 1;
-               default:
-                       fatal("channel_still_open: bad channel type %d", c->type);
-                       /* NOTREACHED */
-               }
-       }
-       return 0;
-}
-
-/* Returns the id of an open channel suitable for keepaliving */
-
-int
-channel_find_open()
-{
-       int i;
-       Channel *c;
-
-       for (i = 0; i < channels_alloc; i++) {
-               c = channels[i];
-               if (c == NULL)
-                       continue;
-               switch (c->type) {
-               case SSH_CHANNEL_CLOSED:
-               case SSH_CHANNEL_DYNAMIC:
-               case SSH_CHANNEL_X11_LISTENER:
-               case SSH_CHANNEL_PORT_LISTENER:
-               case SSH_CHANNEL_RPORT_LISTENER:
-               case SSH_CHANNEL_OPENING:
-               case SSH_CHANNEL_CONNECTING:
-                       continue;
-               case SSH_CHANNEL_LARVAL:
-               case SSH_CHANNEL_AUTH_SOCKET:
-               case SSH_CHANNEL_OPEN:
-               case SSH_CHANNEL_X11_OPEN:
-                       return i;
-               case SSH_CHANNEL_INPUT_DRAINING:
-               case SSH_CHANNEL_OUTPUT_DRAINING:
-                       if (!compat13)
-                               fatal("cannot happen: OUT_DRAIN");
-                       return i;
-               default:
-                       fatal("channel_find_open: bad channel type %d", c->type);
-                       /* NOTREACHED */
-               }
+               xfree(service);
        }
-       return -1;
 }
 
+void
+channel_input_window_adjust(int type, int plen, void *ctxt)
+{
+       Channel *c;
+       int id, adjust;
 
-/*
- * Returns a message describing the currently open forwarded connections,
- * suitable for sending to the client.  The message contains crlf pairs for
- * newlines.
- */
+       if (!compat20)
+               return;
 
-char *
-channel_open_message()
+       /* Get the channel number and verify it. */
+       id = packet_get_int();
+       c = channel_lookup(id);
+
+       if (c == NULL || c->type != SSH_CHANNEL_OPEN) {
+               log("Received window adjust for "
+                   "non-open channel %d.", id);
+               return;
+       }
+       adjust = packet_get_int();
+       packet_done();
+       debug2("channel %d: rcvd adjust %d", id, adjust);
+       c->remote_window += adjust;
+}
+
+void
+channel_input_port_open(int type, int plen, void *ctxt)
 {
-       Buffer buffer;
-       Channel *c;
-       char buf[1024], *cp;
-       int i;
+       Channel *c = NULL;
+       u_short host_port;
+       char *host, *originator_string;
+       int remote_id, sock = -1;
 
-       buffer_init(&buffer);
-       snprintf(buf, sizeof buf, "The following connections are open:\r\n");
-       buffer_append(&buffer, buf, strlen(buf));
-       for (i = 0; i < channels_alloc; i++) {
-               c = channels[i];
-               if (c == NULL)
-                       continue;
-               switch (c->type) {
-               case SSH_CHANNEL_X11_LISTENER:
-               case SSH_CHANNEL_PORT_LISTENER:
-               case SSH_CHANNEL_RPORT_LISTENER:
-               case SSH_CHANNEL_CLOSED:
-               case SSH_CHANNEL_AUTH_SOCKET:
-                       continue;
-               case SSH_CHANNEL_LARVAL:
-               case SSH_CHANNEL_OPENING:
-               case SSH_CHANNEL_CONNECTING:
-               case SSH_CHANNEL_DYNAMIC:
-               case SSH_CHANNEL_OPEN:
-               case SSH_CHANNEL_X11_OPEN:
-               case SSH_CHANNEL_INPUT_DRAINING:
-               case SSH_CHANNEL_OUTPUT_DRAINING:
-                       snprintf(buf, sizeof buf, "  #%d %.300s (t%d r%d i%d/%d o%d/%d fd %d/%d)\r\n",
-                           c->self, c->remote_name,
-                           c->type, c->remote_id,
-                           c->istate, buffer_len(&c->input),
-                           c->ostate, buffer_len(&c->output),
-                           c->rfd, c->wfd);
-                       buffer_append(&buffer, buf, strlen(buf));
-                       continue;
-               default:
-                       fatal("channel_open_message: bad channel type %d", c->type);
-                       /* NOTREACHED */
+       remote_id = packet_get_int();
+       host = packet_get_string(NULL);
+       host_port = packet_get_int();
+
+       if (packet_get_protocol_flags() & SSH_PROTOFLAG_HOST_IN_FWD_OPEN) {
+               originator_string = packet_get_string(NULL);
+       } else {
+               originator_string = xstrdup("unknown (remote did not supply name)");
+       }
+       packet_done();
+       sock = channel_connect_to(host, host_port);
+       if (sock != -1) {
+               c = channel_new("connected socket",
+                   SSH_CHANNEL_CONNECTING, sock, sock, -1, 0, 0, 0,
+                   originator_string, 1);
+               if (c == NULL) {
+                       error("channel_input_port_open: channel_new failed");
+                       close(sock);
+               } else {
+                       c->remote_id = remote_id;
                }
        }
-       buffer_append(&buffer, "\0", 1);
-       cp = xstrdup(buffer_ptr(&buffer));
-       buffer_free(&buffer);
-       return cp;
+       if (c == NULL) {
+               packet_start(SSH_MSG_CHANNEL_OPEN_FAILURE);
+               packet_put_int(remote_id);
+               packet_send();
+       }
+       xfree(host);
 }
 
+
+/* -- tcp forwarding */
+
 /*
  * Initiate forwarding of connections to local port "port" through the secure
  * channel to host:port from remote side.
@@ -1856,7 +2048,7 @@ channel_request_forwarding(
     int gateway_ports, int remote_fwd)
 {
        Channel *c;
-       int success, sock, on = 1, ctype;
+       int success, sock, on = 1, type;
        struct addrinfo hints, *ai, *aitop;
        char ntop[NI_MAXHOST], strport[NI_MAXSERV];
        const char *host;
@@ -1866,10 +2058,10 @@ channel_request_forwarding(
 
        if (remote_fwd) {
                host = listen_address;
-               ctype = SSH_CHANNEL_RPORT_LISTENER;
+               type = SSH_CHANNEL_RPORT_LISTENER;
        } else {
                host = host_to_connect;
-               ctype  =SSH_CHANNEL_PORT_LISTENER;
+               type = SSH_CHANNEL_PORT_LISTENER;
        }
 
        if (strlen(host) > SSH_CHANNEL_PATH_LEN - 1) {
@@ -1933,7 +2125,7 @@ channel_request_forwarding(
                        continue;
                }
                /* Allocate a channel number for the socket. */
-               c = channel_new("port listener", ctype, sock, sock, -1,
+               c = channel_new("port listener", type, sock, sock, -1,
                    CHAN_TCP_WINDOW_DEFAULT, CHAN_TCP_PACKET_DEFAULT,
                    0, xstrdup("port listener"), 1);
                if (c == NULL) {
@@ -2083,7 +2275,7 @@ channel_clear_permitted_opens(void)
 
 
 /* return socket to remote host, port */
-int
+static int
 connect_to(const char *host, u_short port)
 {
        struct addrinfo hints, *ai, *aitop;
@@ -2135,7 +2327,7 @@ connect_to(const char *host, u_short port)
 }
 
 int
-channel_connect_by_listen_adress(u_short listen_port)
+channel_connect_by_listen_address(u_short listen_port)
 {
        int i;
 
@@ -2171,58 +2363,13 @@ channel_connect_to(const char *host, u_short port)
        return connect_to(host, port);
 }
 
-/*
- * This is called after receiving PORT_OPEN message.  This attempts to
- * connect to the given host:port, and sends back CHANNEL_OPEN_CONFIRMATION
- * or CHANNEL_OPEN_FAILURE.
- */
-
-void
-channel_input_port_open(int type, int plen, void *ctxt)
-{
-       Channel *c = NULL;
-       u_short host_port;
-       char *host, *originator_string;
-       int remote_id, sock = -1;
-
-       remote_id = packet_get_int();
-       host = packet_get_string(NULL);
-       host_port = packet_get_int();
-
-       if (have_hostname_in_open) {
-               originator_string = packet_get_string(NULL);
-       } else {
-               originator_string = xstrdup("unknown (remote did not supply name)");
-       }
-       packet_done();
-       sock = channel_connect_to(host, host_port);
-       if (sock != -1) {
-               c = channel_new("connected socket",
-                   SSH_CHANNEL_CONNECTING, sock, sock, -1, 0, 0, 0,
-                   originator_string, 1);
-               if (c == NULL) {
-                       error("channel_input_port_open: channel_new failed");
-                       close(sock);
-               } else {
-                       c->remote_id = remote_id;
-               }
-       }
-       if (c == NULL) {
-               packet_start(SSH_MSG_CHANNEL_OPEN_FAILURE);
-               packet_put_int(remote_id);
-               packet_send();
-       }
-       xfree(host);
-}
+/* -- X11 forwarding */
 
 /*
  * Creates an internet domain socket for listening for X11 connections.
  * Returns a suitable value for the DISPLAY variable, or NULL if an error
  * occurs.
  */
-
-#define        NUM_SOCKS       10
-
 char *
 x11_create_display_inet(int screen_number, int x11_display_offset)
 {
@@ -2363,8 +2510,7 @@ x11_create_display_inet(int screen_number, int x11_display_offset)
 #define X_UNIX_PATH "/tmp/.X11-unix/X"
 #endif
 
-static
-int
+static int
 connect_local_xsocket(u_int dnr)
 {
        static const char *const x_sockets[] = {
@@ -2503,7 +2649,8 @@ x11_input_open(int type, int plen, void *ctxt)
        debug("Received X11 open request.");
 
        remote_id = packet_get_int();
-       if (have_hostname_in_open) {
+
+       if (packet_get_protocol_flags() & SSH_PROTOFLAG_HOST_IN_FWD_OPEN) {
                remote_host = packet_get_string(NULL);
        } else {
                remote_host = xstrdup("unknown (remote did not supply name)");
@@ -2562,8 +2709,8 @@ deny_input_open(int type, int plen, void *ctxt)
 /*
  * Requests forwarding of X11 connections, generates fake authentication
  * data, and enables authentication spoofing.
+ * This should be called in the client only.
  */
-
 void
 x11_request_forwarding_with_spoofing(int client_session_id,
     const char *proto, const char *data)
@@ -2628,6 +2775,9 @@ x11_request_forwarding_with_spoofing(int client_session_id,
        xfree(new_data);
 }
 
+
+/* -- agent forwarding */
+
 /* Sends a message to the server to request authentication fd forwarding. */
 
 void
@@ -2647,16 +2797,23 @@ auth_request_forwarding()
 char *
 auth_get_socket_name()
 {
-       return channel_forwarded_auth_socket_name;
+       return auth_sock_name;
 }
 
 /* removes the agent forwarding socket */
 
 void
-cleanup_socket(void)
+auth_sock_cleanup_proc(void *_pw)
 {
-       unlink(channel_forwarded_auth_socket_name);
-       rmdir(channel_forwarded_auth_socket_dir);
+       struct passwd *pw = _pw;
+
+       if (auth_sock_name) {
+               temporarily_use_uid(pw);
+               unlink(auth_sock_name);
+               rmdir(auth_sock_dir);
+               auth_sock_name = NULL;
+               restore_uid();
+       }
 }
 
 /*
@@ -2671,36 +2828,36 @@ auth_input_request_forwarding(struct passwd * pw)
        int sock;
        struct sockaddr_un sunaddr;
 
-       if (auth_get_socket_name() != NULL)
-               fatal("Protocol error: authentication forwarding requested twice.");
+       if (auth_get_socket_name() != NULL) {
+               error("authentication forwarding requested twice.");
+               return 0;
+       }
 
        /* Temporarily drop privileged uid for mkdir/bind. */
        temporarily_use_uid(pw);
 
        /* Allocate a buffer for the socket name, and format the name. */
-       channel_forwarded_auth_socket_name = xmalloc(MAX_SOCKET_NAME);
-       channel_forwarded_auth_socket_dir = xmalloc(MAX_SOCKET_NAME);
-       strlcpy(channel_forwarded_auth_socket_dir, "/tmp/ssh-XXXXXXXX", MAX_SOCKET_NAME);
+       auth_sock_name = xmalloc(MAXPATHLEN);
+       auth_sock_dir = xmalloc(MAXPATHLEN);
+       strlcpy(auth_sock_dir, "/tmp/ssh-XXXXXXXX", MAXPATHLEN);
 
        /* Create private directory for socket */
-       if (mkdtemp(channel_forwarded_auth_socket_dir) == NULL) {
-               packet_send_debug("Agent forwarding disabled: mkdtemp() failed: %.100s",
-                   strerror(errno));
+       if (mkdtemp(auth_sock_dir) == NULL) {
+               packet_send_debug("Agent forwarding disabled: "
+                   "mkdtemp() failed: %.100s", strerror(errno));
                restore_uid();
-               xfree(channel_forwarded_auth_socket_name);
-               xfree(channel_forwarded_auth_socket_dir);
-               channel_forwarded_auth_socket_name = NULL;
-               channel_forwarded_auth_socket_dir = NULL;
+               xfree(auth_sock_name);
+               xfree(auth_sock_dir);
+               auth_sock_name = NULL;
+               auth_sock_dir = NULL;
                return 0;
        }
-       snprintf(channel_forwarded_auth_socket_name, MAX_SOCKET_NAME, "%s/agent.%d",
-                channel_forwarded_auth_socket_dir, (int) getpid());
+       snprintf(auth_sock_name, MAXPATHLEN, "%s/agent.%d",
+                auth_sock_dir, (int) getpid());
+
+       /* delete agent socket on fatal() */
+       fatal_add_cleanup(auth_sock_cleanup_proc, pw);
 
-       if (atexit(cleanup_socket) < 0) {
-               int saved = errno;
-               cleanup_socket();
-               packet_disconnect("socket: %.100s", strerror(saved));
-       }
        /* Create the socket. */
        sock = socket(AF_UNIX, SOCK_STREAM, 0);
        if (sock < 0)
@@ -2709,7 +2866,7 @@ auth_input_request_forwarding(struct passwd * pw)
        /* Bind it to the name. */
        memset(&sunaddr, 0, sizeof(sunaddr));
        sunaddr.sun_family = AF_UNIX;
-       strncpy(sunaddr.sun_path, channel_forwarded_auth_socket_name,
+       strncpy(sunaddr.sun_path, auth_sock_name,
                sizeof(sunaddr.sun_path));
 
        if (bind(sock, (struct sockaddr *) & sunaddr, sizeof(sunaddr)) < 0)
@@ -2729,10 +2886,12 @@ auth_input_request_forwarding(struct passwd * pw)
            0, xstrdup("auth socket"), 1);
        if (nc == NULL) {
                error("auth_input_request_forwarding: channel_new failed");
+               auth_sock_cleanup_proc(pw);
+               fatal_remove_cleanup(auth_sock_cleanup_proc, pw);
                close(sock);
                return 0;
        }
-       strlcpy(nc->path, channel_forwarded_auth_socket_name, sizeof(nc->path));
+       strlcpy(nc->path, auth_sock_name, sizeof(nc->path));
        return 1;
 }
 
@@ -2743,7 +2902,7 @@ auth_input_open_request(int type, int plen, void *ctxt)
 {
        Channel *c = NULL;
        int remote_id, sock;
-       char *dummyname;
+       char *name;
 
        packet_integrity_check(plen, 4, type);
 
@@ -2763,10 +2922,12 @@ auth_input_open_request(int type, int plen, void *ctxt)
         * agent.
         */
        if (sock >= 0) {
-               dummyname = xstrdup("authentication agent connection");
-               c = channel_new("", SSH_CHANNEL_OPEN, sock, sock, -1, 0, 0, 0, dummyname, 1);
+               name = xstrdup("authentication agent connection");
+               c = channel_new("", SSH_CHANNEL_OPEN, sock, sock,
+                   -1, 0, 0, 0, name, 1);
                if (c == NULL) {
                        error("auth_input_open_request: channel_new failed");
+                       xfree(name);
                        close(sock);
                } else {
                        c->remote_id = remote_id;
@@ -2784,105 +2945,3 @@ auth_input_open_request(int type, int plen, void *ctxt)
        }
        packet_send();
 }
-
-void
-channel_start_open(int id)
-{
-       Channel *c = channel_lookup(id);
-       if (c == NULL) {
-               log("channel_open: %d: bad id", id);
-               return;
-       }
-       debug("send channel open %d", id);
-       packet_start(SSH2_MSG_CHANNEL_OPEN);
-       packet_put_cstring(c->ctype);
-       packet_put_int(c->self);
-       packet_put_int(c->local_window);
-       packet_put_int(c->local_maxpacket);
-}
-void
-channel_open(int id)
-{
-       /* XXX REMOVE ME */
-       channel_start_open(id);
-       packet_send();
-}
-void
-channel_request(int id, char *service, int wantconfirm)
-{
-       channel_request_start(id, service, wantconfirm);
-       packet_send();
-       debug("channel request %d: %s", id, service) ;
-}
-void
-channel_request_start(int id, char *service, int wantconfirm)
-{
-       Channel *c = channel_lookup(id);
-       if (c == NULL) {
-               log("channel_request: %d: bad id", id);
-               return;
-       }
-       packet_start(SSH2_MSG_CHANNEL_REQUEST);
-       packet_put_int(c->remote_id);
-       packet_put_cstring(service);
-       packet_put_char(wantconfirm);
-}
-void
-channel_register_callback(int id, int mtype, channel_callback_fn *fn, void *arg)
-{
-       Channel *c = channel_lookup(id);
-       if (c == NULL) {
-               log("channel_register_callback: %d: bad id", id);
-               return;
-       }
-       c->cb_event = mtype;
-       c->cb_fn = fn;
-       c->cb_arg = arg;
-}
-void
-channel_register_cleanup(int id, channel_callback_fn *fn)
-{
-       Channel *c = channel_lookup(id);
-       if (c == NULL) {
-               log("channel_register_cleanup: %d: bad id", id);
-               return;
-       }
-       c->dettach_user = fn;
-}
-void
-channel_cancel_cleanup(int id)
-{
-       Channel *c = channel_lookup(id);
-       if (c == NULL) {
-               log("channel_cancel_cleanup: %d: bad id", id);
-               return;
-       }
-       c->dettach_user = NULL;
-}
-void
-channel_register_filter(int id, channel_filter_fn *fn)
-{
-       Channel *c = channel_lookup(id);
-       if (c == NULL) {
-               log("channel_register_filter: %d: bad id", id);
-               return;
-       }
-       c->input_filter = fn;
-}
-
-void
-channel_set_fds(int id, int rfd, int wfd, int efd,
-    int extusage, int nonblock)
-{
-       Channel *c = channel_lookup(id);
-       if (c == NULL || c->type != SSH_CHANNEL_LARVAL)
-               fatal("channel_activate for non-larval channel %d.", id);
-       channel_register_fds(c, rfd, wfd, efd, extusage, nonblock);
-       c->type = SSH_CHANNEL_OPEN;
-       /* XXX window size? */
-       c->local_window = c->local_window_max = c->local_maxpacket * 2;
-       packet_start(SSH2_MSG_CHANNEL_WINDOW_ADJUST);
-       packet_put_int(c->remote_id);
-       packet_put_int(c->local_window);
-       packet_send();
-}
This page took 0.121131 seconds and 4 git commands to generate.