- deraadt@cvs.openbsd.org 2002/05/22 23:18:25

[openssh.git] / auth2-chall.c

diff --git a/auth2-chall.c b/auth2-chall.c
index 92d0020e032ec91af528d8c79d887ad29756e6d5..38f955a022cf562b4df26c8c12f02b01c2e701c9 100644 (file)
--- a/auth2-chall.c
+++ b/auth2-chall.c
@@ -23,10 +23,11 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #include "includes.h"
-RCSID("$OpenBSD: auth2-chall.c,v 1.14 2002/01/11 20:14:11 markus Exp $");
+RCSID("$OpenBSD: auth2-chall.c,v 1.17 2002/03/18 17:50:31 provos Exp $");
 
 #include "ssh2.h"
 #include "auth.h"
+#include "buffer.h"
 #include "packet.h"
 #include "xmalloc.h"
 #include "dispatch.h"
@@ -68,22 +69,25 @@ static KbdintAuthctxt *
 kbdint_alloc(const char *devs)
 {
        KbdintAuthctxt *kbdintctxt;
+       Buffer b;
        int i;
-       char buf[1024];
 
        kbdintctxt = xmalloc(sizeof(KbdintAuthctxt));
        if (strcmp(devs, "") == 0) {
-               buf[0] = '\0';
+               buffer_init(&b);
                for (i = 0; devices[i]; i++) {
-                       if (i != 0)
-                               strlcat(buf, ",", sizeof(buf));
-                       strlcat(buf, devices[i]->name, sizeof(buf));
+                       if (buffer_len(&b) > 0)
+                               buffer_append(&b, ",", 1);
+                       buffer_append(&b, devices[i]->name,
+                           strlen(devices[i]->name));
                }
-               debug("kbdint_alloc: devices '%s'", buf);
-               kbdintctxt->devices = xstrdup(buf);
+               buffer_append(&b, "\0", 1);
+               kbdintctxt->devices = xstrdup(buffer_ptr(&b));
+               buffer_free(&b);
        } else {
                kbdintctxt->devices = xstrdup(devs);
        }
+       debug("kbdint_alloc: devices '%s'", kbdintctxt->devices);
        kbdintctxt->ctxt = NULL;
        kbdintctxt->device = NULL;
 
@@ -291,9 +295,8 @@ input_userauth_info_response(int type, u_int32_t seq, void *ctxt)
        len = strlen("keyboard-interactive") + 2 +
                strlen(kbdintctxt->device->name);
        method = xmalloc(len);
-       strlcpy(method, "keyboard-interactive", len);
-       strlcat(method, "/", len);
-       strlcat(method, kbdintctxt->device->name, len);
+       snprintf(method, len, "keyboard-interactive/%s",
+           kbdintctxt->device->name);
 
        if (!authctxt->postponed) {
                if (authenticated) {
@@ -307,3 +310,22 @@ input_userauth_info_response(int type, u_int32_t seq, void *ctxt)
        userauth_finish(authctxt, authenticated, method);
        xfree(method);
 }
+
+void
+privsep_challenge_enable(void)
+{
+#ifdef BSD_AUTH
+       extern KbdintDevice mm_bsdauth_device;
+#endif
+#ifdef SKEY
+       extern KbdintDevice mm_skey_device;
+#endif
+       /* As long as SSHv1 has devices[0] hard coded this is fine */
+#ifdef BSD_AUTH
+       devices[0] = &mm_bsdauth_device;
+#else
+#ifdef SKEY
+       devices[0] = &mm_skey_device;
+#endif
+#endif
+}