]> andersk Git - openssh.git/blobdiff - session.c
- markus@cvs.openbsd.org 2002/02/07 09:35:39
[openssh.git] / session.c
index 4873e4d74b3387afa46e5854f5cc51ba65268fe2..431936ac65aacafff86ee7f913816525ac0733f4 100644 (file)
--- a/session.c
+++ b/session.c
@@ -33,7 +33,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: session.c,v 1.102 2001/09/16 14:46:54 markus Exp $");
+RCSID("$OpenBSD: session.c,v 1.124 2002/02/06 14:37:22 markus Exp $");
 
 #include "ssh.h"
 #include "ssh1.h"
@@ -108,8 +108,10 @@ struct Session {
        int     row, col, xpixel, ypixel;
        char    tty[TTYSZ];
        /* X11 */
+       int     display_number;
        char    *display;
        int     screen;
+       char    *auth_display;
        char    *auth_proto;
        char    *auth_data;
        int     single_connection;
@@ -129,6 +131,9 @@ void        do_exec_pty(Session *, const char *);
 void   do_exec_no_pty(Session *, const char *);
 void   do_exec(Session *, const char *);
 void   do_login(Session *, const char *);
+#ifdef LOGIN_NEEDS_UTMPX
+static void    do_pre_login(Session *s);
+#endif
 void   do_child(Session *, const char *);
 void   do_motd(void);
 int    check_quietlogin(Session *, const char *);
@@ -156,7 +161,6 @@ const char *original_command = NULL;
 Session        sessions[MAX_SESSIONS];
 
 #ifdef WITH_AIXAUTHENTICATE
-/* AIX's lastlogin message, set in auth1.c */
 char *aixloginmsg;
 #endif /* WITH_AIXAUTHENTICATE */
 
@@ -188,6 +192,14 @@ do_authenticated(Authctxt *authctxt)
        }
 #endif
 #endif
+#ifdef WITH_AIXAUTHENTICATE
+       /* We don't have a pty yet, so just label the line as "ssh" */
+       if (loginsuccess(authctxt->user,
+           get_canonical_hostname(options.verify_reverse_mapping),
+           "ssh", &aixloginmsg) < 0)
+               aixloginmsg = NULL;
+#endif /* WITH_AIXAUTHENTICATE */
+
        /* setup the channel layer */
        if (!no_port_forwarding_flag && options.allow_tcp_forwarding)
                channel_permit_all_opens();
@@ -221,7 +233,7 @@ do_authenticated1(Authctxt *authctxt)
 {
        Session *s;
        char *command;
-       int success, type, plen, screen_flag;
+       int success, type, screen_flag;
        int compression_level = 0, enable_compression_after_reply = 0;
        u_int proto_len, data_len, dlen;
 
@@ -237,16 +249,16 @@ do_authenticated1(Authctxt *authctxt)
                success = 0;
 
                /* Get a packet from the client. */
-               type = packet_read(&plen);
+               type = packet_read();
 
                /* Process the packet. */
                switch (type) {
                case SSH_CMSG_REQUEST_COMPRESSION:
-                       packet_integrity_check(plen, 4, type);
                        compression_level = packet_get_int();
+                       packet_check_eom();
                        if (compression_level < 1 || compression_level > 9) {
                                packet_send_debug("Received illegal compression level %d.",
-                                    compression_level);
+                                   compression_level);
                                break;
                        }
                        /* Enable compression after we have responded with SUCCESS. */
@@ -274,7 +286,7 @@ do_authenticated1(Authctxt *authctxt)
                        } else {
                                s->screen = 0;
                        }
-                       packet_done();
+                       packet_check_eom();
                        success = session_setup_x11fwd(s);
                        if (!success) {
                                xfree(s->auth_proto);
@@ -311,22 +323,22 @@ do_authenticated1(Authctxt *authctxt)
                        if (packet_set_maxsize(packet_get_int()) > 0)
                                success = 1;
                        break;
-                       
+
 #if defined(AFS) || defined(KRB5)
                case SSH_CMSG_HAVE_KERBEROS_TGT:
                        if (!options.kerberos_tgt_passing) {
                                verbose("Kerberos TGT passing disabled.");
                        } else {
                                char *kdata = packet_get_string(&dlen);
-                               packet_integrity_check(plen, 4 + dlen, type);
-                               
+                               packet_check_eom();
+
                                /* XXX - 0x41, see creds_to_radix version */
                                if (kdata[0] != 0x41) {
 #ifdef KRB5
                                        krb5_data tgt;
                                        tgt.data = kdata;
                                        tgt.length = dlen;
-                                       
+
                                        if (auth_krb5_tgt(s->authctxt, &tgt))
                                                success = 1;
                                        else
@@ -344,7 +356,7 @@ do_authenticated1(Authctxt *authctxt)
                        }
                        break;
 #endif /* AFS || KRB5 */
-                       
+
 #ifdef AFS
                case SSH_CMSG_HAVE_AFS_TOKEN:
                        if (!options.afs_token_passing || !k_hasafs()) {
@@ -352,8 +364,8 @@ do_authenticated1(Authctxt *authctxt)
                        } else {
                                /* Accept AFS token. */
                                char *token = packet_get_string(&dlen);
-                               packet_integrity_check(plen, 4 + dlen, type);
-                               
+                               packet_check_eom();
+
                                if (auth_afs_token(s->authctxt, token))
                                        success = 1;
                                else
@@ -374,7 +386,7 @@ do_authenticated1(Authctxt *authctxt)
                        } else {
                                do_exec(s, NULL);
                        }
-                       packet_done();
+                       packet_check_eom();
                        session_close(s);
                        return;
 
@@ -429,6 +441,9 @@ do_exec_no_pty(Session *s, const char *command)
 #if defined(USE_PAM)
        do_pam_session(s->pw->pw_name, NULL);
        do_pam_setcred(1);
+       if (is_pam_password_change_required())
+               packet_disconnect("Password change required but no "
+                   "TTY available");
 #endif /* USE_PAM */
 
        /* Fork the child. */
@@ -557,17 +572,13 @@ do_exec_pty(Session *s, const char *command)
                /* Make the pseudo tty our controlling tty. */
                pty_make_controlling_tty(&ttyfd, s->tty);
 
-               /* Redirect stdin from the pseudo tty. */
-               if (dup2(ttyfd, fileno(stdin)) < 0)
-                       error("dup2 stdin failed: %.100s", strerror(errno));
-
-               /* Redirect stdout to the pseudo tty. */
-               if (dup2(ttyfd, fileno(stdout)) < 0)
-                       error("dup2 stdin failed: %.100s", strerror(errno));
-
-               /* Redirect stderr to the pseudo tty. */
-               if (dup2(ttyfd, fileno(stderr)) < 0)
-                       error("dup2 stdin failed: %.100s", strerror(errno));
+               /* Redirect stdin/stdout/stderr from the pseudo tty. */
+               if (dup2(ttyfd, 0) < 0)
+                       error("dup2 stdin: %s", strerror(errno));
+               if (dup2(ttyfd, 1) < 0)
+                       error("dup2 stdout: %s", strerror(errno));
+               if (dup2(ttyfd, 2) < 0)
+                       error("dup2 stderr: %s", strerror(errno));
 
                /* Close the extra descriptor for the pseudo tty. */
                close(ttyfd);
@@ -638,14 +649,14 @@ do_pre_login(Session *s)
        if (packet_connection_is_on_socket()) {
                fromlen = sizeof(from);
                if (getpeername(packet_get_connection_in(),
-                    (struct sockaddr *) & from, &fromlen) < 0) {
+                   (struct sockaddr *) & from, &fromlen) < 0) {
                        debug("getpeername: %.100s", strerror(errno));
                        fatal_cleanup();
                }
        }
 
        record_utmp_only(pid, s->tty, s->pw->pw_name,
-           get_remote_name_or_ip(utmp_len, options.reverse_mapping_check),
+           get_remote_name_or_ip(utmp_len, options.verify_reverse_mapping),
            (struct sockaddr *)&from);
 }
 #endif
@@ -706,7 +717,7 @@ do_login(Session *s, const char *command)
 
        /* Record that there was a login on that tty from the remote host. */
        record_login(pid, s->tty, pw->pw_name, pw->pw_uid,
-           get_remote_name_or_ip(utmp_len, options.reverse_mapping_check),
+           get_remote_name_or_ip(utmp_len, options.verify_reverse_mapping),
            (struct sockaddr *)&from);
 
 #ifdef USE_PAM
@@ -800,7 +811,7 @@ check_quietlogin(Session *s, const char *command)
  */
 static void
 child_set_env(char ***envp, u_int *envsizep, const char *name,
-             const char *value)
+       const char *value)
 {
        u_int i, namelen;
        char **env;
@@ -841,7 +852,7 @@ child_set_env(char ***envp, u_int *envsizep, const char *name,
  */
 static void
 read_environment_file(char ***env, u_int *envsize,
-                     const char *filename)
+       const char *filename)
 {
        FILE *f;
        char buf[4096];
@@ -874,62 +885,28 @@ read_environment_file(char ***env, u_int *envsize,
        fclose(f);
 }
 
-#ifdef USE_PAM
-/*
- * Sets any environment variables which have been specified by PAM
- */
-void do_pam_environment(char ***env, u_int *envsize)
+void copy_environment(char **source, char ***env, u_int *envsize)
 {
-       char *equals, var_name[512], var_val[512];
-       char **pam_env;
+       char *var_name, *var_val;
        int i;
 
-       if ((pam_env = fetch_pam_environment()) == NULL)
+       if (source == NULL)
                return;
 
-       for(i = 0; pam_env[i] != NULL; i++) {
-               if ((equals = strstr(pam_env[i], "=")) == NULL)
+       for(i = 0; source[i] != NULL; i++) {
+               var_name = xstrdup(source[i]);
+               if ((var_val = strstr(var_name, "=")) == NULL) {
+                       xfree(var_name);
                        continue;
-
-               if (strlen(pam_env[i]) < (sizeof(var_name) - 1)) {
-                       memset(var_name, '\0', sizeof(var_name));
-                       memset(var_val, '\0', sizeof(var_val));
-
-                       strncpy(var_name, pam_env[i], equals - pam_env[i]);
-                       strcpy(var_val, equals + 1);
-
-                       debug3("PAM environment: %s=%s", var_name, var_val);
-
-                       child_set_env(env, envsize, var_name, var_val);
                }
-       }
-}
-#endif /* USE_PAM */
-
-#ifdef HAVE_CYGWIN
-void copy_environment(char ***env, u_int *envsize)
-{
-       char *equals, var_name[512], var_val[512];
-       int i;
-
-       for(i = 0; environ[i] != NULL; i++) {
-               if ((equals = strstr(environ[i], "=")) == NULL)
-                       continue;
-
-               if (strlen(environ[i]) < (sizeof(var_name) - 1)) {
-                       memset(var_name, '\0', sizeof(var_name));
-                       memset(var_val, '\0', sizeof(var_val));
+               *var_val++ = '\0';
 
-                       strncpy(var_name, environ[i], equals - environ[i]);
-                       strcpy(var_val, equals + 1);
-
-                       debug3("Copy environment: %s=%s", var_name, var_val);
-
-                       child_set_env(env, envsize, var_name, var_val);
-               }
+               debug3("Copy environment: %s=%s", var_name, var_val);
+               child_set_env(env, envsize, var_name, var_val);
+               
+               xfree(var_name);
        }
 }
-#endif
 
 #if defined(HAVE_GETUSERATTR)
 /*
@@ -1204,7 +1181,7 @@ do_child(Session *s, const char *command)
         * The Windows environment contains some setting which are
         * important for a running system. They must not be dropped.
         */
-       copy_environment(&env, &envsize);
+       copy_environment(environ, &env, &envsize);
 #endif
 
        if (!options.use_login) {
@@ -1238,18 +1215,21 @@ do_child(Session *s, const char *command)
                child_set_env(&env, &envsize, "TZ", getenv("TZ"));
 
        /* Set custom environment options from RSA authentication. */
-       while (custom_environment) {
-               struct envstring *ce = custom_environment;
-               char *s = ce->s;
-               int i;
-               for (i = 0; s[i] != '=' && s[i]; i++);
-               if (s[i] == '=') {
-                       s[i] = 0;
-                       child_set_env(&env, &envsize, s, s + i + 1);
+       if (!options.use_login) {
+               while (custom_environment) {
+                       struct envstring *ce = custom_environment;
+                       char *s = ce->s;
+                       int i;
+                       for (i = 0; s[i] != '=' && s[i]; i++)
+                               ;
+                       if (s[i] == '=') {
+                               s[i] = 0;
+                               child_set_env(&env, &envsize, s, s + i + 1);
+                       }
+                       custom_environment = ce->next;
+                       xfree(ce->s);
+                       xfree(ce);
                }
-               custom_environment = ce->next;
-               xfree(ce->s);
-               xfree(ce);
        }
 
        snprintf(buf, sizeof buf, "%.50s %d %d",
@@ -1285,12 +1265,12 @@ do_child(Session *s, const char *command)
 #endif
 #ifdef USE_PAM
        /* Pull in any environment variables that may have been set by PAM. */
-       do_pam_environment(&env, &envsize);
+       copy_environment(fetch_pam_environment(), &env, &envsize);
 #endif /* USE_PAM */
 
        if (auth_get_socket_name() != NULL)
                child_set_env(&env, &envsize, SSH_AUTHSOCKET_ENV_NAME,
-                             auth_get_socket_name());
+                   auth_get_socket_name());
 
        /* read $HOME/.ssh/environment. */
        if (!options.use_login) {
@@ -1307,7 +1287,7 @@ do_child(Session *s, const char *command)
        /* we have to stash the hostname before we close our socket. */
        if (options.use_login)
                hostname = get_remote_name_or_ip(utmp_len,
-                   options.reverse_mapping_check);
+                   options.verify_reverse_mapping);
        /*
         * Close the connection descriptors; note that this is the child, and
         * the server will still have the socket open, and it is important
@@ -1343,16 +1323,6 @@ do_child(Session *s, const char *command)
        for (i = 3; i < 64; i++)
                close(i);
 
-       /* Change current directory to the user\'s home directory. */
-       if (chdir(pw->pw_dir) < 0) {
-               fprintf(stderr, "Could not chdir to home directory %s: %s\n",
-                       pw->pw_dir, strerror(errno));
-#ifdef HAVE_LOGIN_CAP
-               if (login_getcapbool(lc, "requirehome", 0))
-                       exit(1);
-#endif
-       }
-
        /*
         * Must take new environment into use so that .ssh/rc, /etc/sshrc and
         * xauth are run in the proper environment.
@@ -1363,14 +1333,24 @@ do_child(Session *s, const char *command)
        /* Try to get AFS tokens for the local cell. */
        if (k_hasafs()) {
                char cell[64];
-               
+
                if (k_afs_cell_of_file(pw->pw_dir, cell, sizeof(cell)) == 0)
                        krb_afslog(cell, 0);
-               
+
                krb_afslog(0, 0);
        }
 #endif /* AFS */
 
+       /* Change current directory to the user\'s home directory. */
+       if (chdir(pw->pw_dir) < 0) {
+               fprintf(stderr, "Could not chdir to home directory %s: %s\n",
+                   pw->pw_dir, strerror(errno));
+#ifdef HAVE_LOGIN_CAP
+               if (login_getcapbool(lc, "requirehome", 0))
+                       exit(1);
+#endif
+       }
+
        /*
         * Run $HOME/.ssh/rc, /etc/sshrc, or xauth (whichever is found first
         * in this order).
@@ -1406,33 +1386,20 @@ do_child(Session *s, const char *command)
                                    _PATH_SSH_SYSTEM_RC);
                } else if (do_xauth && options.xauth_location != NULL) {
                        /* Add authority data to .Xauthority if appropriate. */
-                       char *screen = strchr(s->display, ':');
-
                        if (debug_flag) {
                                fprintf(stderr,
                                    "Running %.100s add "
                                    "%.100s %.100s %.100s\n",
-                                   options.xauth_location, s->display,
+                                   options.xauth_location, s->auth_display,
                                    s->auth_proto, s->auth_data);
-                               if (screen != NULL)
-                                       fprintf(stderr,
-                                           "Adding %.*s/unix%s %s %s\n",
-                                           (int)(screen - s->display),
-                                           s->display, screen,
-                                           s->auth_proto, s->auth_data);
                        }
                        snprintf(cmd, sizeof cmd, "%s -q -",
                            options.xauth_location);
                        f = popen(cmd, "w");
                        if (f) {
-                               fprintf(f, "add %s %s %s\n", s->display,
-                                   s->auth_proto, s->auth_data);
-                               if (screen != NULL)
-                                       fprintf(f, "add %.*s/unix%s %s %s\n",
-                                           (int)(screen - s->display),
-                                           s->display, screen,
-                                           s->auth_proto,
-                                           s->auth_data);
+                               fprintf(f, "add %s %s %s\n",
+                                   s->auth_display, s->auth_proto,
+                                   s->auth_data);
                                pclose(f);
                        } else {
                                fprintf(stderr, "Could not run %s\n",
@@ -1461,8 +1428,7 @@ do_child(Session *s, const char *command)
 
                        /* Start the shell.  Set initial character to '-'. */
                        buf[0] = '-';
-                       strncpy(buf + 1, cp, sizeof(buf) - 1);
-                       buf[sizeof(buf) - 1] = 0;
+                       strlcpy(buf + 1, cp, sizeof(buf) - 1);
 
                        /* Execute the shell. */
                        argv[0] = buf;
@@ -1478,9 +1444,9 @@ do_child(Session *s, const char *command)
 
                        execl(LOGIN_PROGRAM, "login", "-h", hostname,
 #ifdef LOGIN_NEEDS_TERM
-                            s->term? s->term : "unknown",
+                           s->term? s->term : "unknown",
 #endif
-                            "-p", "-f", "--", pw->pw_name, (char *)NULL);
+                           "-p", "-f", "--", pw->pw_name, (char *)NULL);
 
                        /* Login couldn't be executed, die. */
 
@@ -1508,12 +1474,12 @@ session_new(void)
        static int did_init = 0;
        if (!did_init) {
                debug("session_new: init");
-               for(i = 0; i < MAX_SESSIONS; i++) {
+               for (i = 0; i < MAX_SESSIONS; i++) {
                        sessions[i].used = 0;
                }
                did_init = 1;
        }
-       for(i = 0; i < MAX_SESSIONS; i++) {
+       for (i = 0; i < MAX_SESSIONS; i++) {
                Session *s = &sessions[i];
                if (! s->used) {
                        memset(s, 0, sizeof(*s));
@@ -1533,7 +1499,7 @@ static void
 session_dump(void)
 {
        int i;
-       for(i = 0; i < MAX_SESSIONS; i++) {
+       for (i = 0; i < MAX_SESSIONS; i++) {
                Session *s = &sessions[i];
                debug("dump: used %d session %d %p channel %d pid %d",
                    s->used,
@@ -1566,7 +1532,7 @@ static Session *
 session_by_channel(int id)
 {
        int i;
-       for(i = 0; i < MAX_SESSIONS; i++) {
+       for (i = 0; i < MAX_SESSIONS; i++) {
                Session *s = &sessions[i];
                if (s->used && s->chanid == id) {
                        debug("session_by_channel: session %d channel %d", i, id);
@@ -1583,7 +1549,7 @@ session_by_pid(pid_t pid)
 {
        int i;
        debug("session_by_pid: pid %d", pid);
-       for(i = 0; i < MAX_SESSIONS; i++) {
+       for (i = 0; i < MAX_SESSIONS; i++) {
                Session *s = &sessions[i];
                if (s->used && s->pid == pid)
                        return s;
@@ -1600,7 +1566,7 @@ session_window_change_req(Session *s)
        s->row = packet_get_int();
        s->xpixel = packet_get_int();
        s->ypixel = packet_get_int();
-       packet_done();
+       packet_check_eom();
        pty_change_window_size(s->ptyfd, s->row, s->col, s->xpixel, s->ypixel);
        return 1;
 }
@@ -1665,7 +1631,7 @@ session_pty_req(Session *s)
        /* Set window size from the packet. */
        pty_change_window_size(s->ptyfd, s->row, s->col, s->xpixel, s->ypixel);
 
-       packet_done();
+       packet_check_eom();
        session_proctitle(s);
        return 1;
 }
@@ -1673,25 +1639,34 @@ session_pty_req(Session *s)
 static int
 session_subsystem_req(Session *s)
 {
+       struct stat st;
        u_int len;
        int success = 0;
-       char *subsys = packet_get_string(&len);
+       char *cmd, *subsys = packet_get_string(&len);
        int i;
 
-       packet_done();
-       log("subsystem request for %s", subsys);
+       packet_check_eom();
+       log("subsystem request for %.100s", subsys);
 
        for (i = 0; i < options.num_subsystems; i++) {
-               if(strcmp(subsys, options.subsystem_name[i]) == 0) {
-                       debug("subsystem: exec() %s", options.subsystem_command[i]);
+               if (strcmp(subsys, options.subsystem_name[i]) == 0) {
+                       cmd = options.subsystem_command[i];
+                       if (stat(cmd, &st) < 0) {
+                               error("subsystem: cannot stat %s: %s", cmd,
+                                   strerror(errno));
+                               break;
+                       }
+                       debug("subsystem: exec() %s", cmd);
                        s->is_subsystem = 1;
-                       do_exec(s, options.subsystem_command[i]);
+                       do_exec(s, cmd);
                        success = 1;
+                       break;
                }
        }
 
        if (!success)
-               log("subsystem request for %s failed, subsystem not found", subsys);
+               log("subsystem request for %.100s failed, subsystem not found",
+                   subsys);
 
        xfree(subsys);
        return success;
@@ -1706,7 +1681,7 @@ session_x11_req(Session *s)
        s->auth_proto = packet_get_string(NULL);
        s->auth_data = packet_get_string(NULL);
        s->screen = packet_get_int();
-       packet_done();
+       packet_check_eom();
 
        success = session_setup_x11fwd(s);
        if (!success) {
@@ -1721,7 +1696,7 @@ session_x11_req(Session *s)
 static int
 session_shell_req(Session *s)
 {
-       packet_done();
+       packet_check_eom();
        do_exec(s, NULL);
        return 1;
 }
@@ -1731,7 +1706,7 @@ session_exec_req(Session *s)
 {
        u_int len;
        char *command = packet_get_string(&len);
-       packet_done();
+       packet_check_eom();
        do_exec(s, command);
        xfree(command);
        return 1;
@@ -1741,7 +1716,7 @@ static int
 session_auth_agent_req(Session *s)
 {
        static int called = 0;
-       packet_done();
+       packet_check_eom();
        if (no_agent_forwarding_flag) {
                debug("session_auth_agent_req: no_agent_forwarding_flag");
                return 0;
@@ -1754,28 +1729,18 @@ session_auth_agent_req(Session *s)
        }
 }
 
-void
-session_input_channel_req(int id, void *arg)
+int
+session_input_channel_req(Channel *c, const char *rtype)
 {
-       u_int len;
-       int reply;
        int success = 0;
-       char *rtype;
        Session *s;
-       Channel *c;
-
-       rtype = packet_get_string(&len);
-       reply = packet_get_char();
-
-       s = session_by_channel(id);
-       if (s == NULL)
-               fatal("session_input_channel_req: channel %d: no session", id);
-       c = channel_lookup(id);
-       if (c == NULL)
-               fatal("session_input_channel_req: channel %d: bad channel", id);
 
-       debug("session_input_channel_req: session %d channel %d request %s reply %d",
-           s->self, id, rtype, reply);
+       if ((s = session_by_channel(c->self)) == NULL) {
+               log("session_input_channel_req: no session %d req %.100s",
+                   c->self, rtype);
+               return 0;
+       }
+       debug("session_input_channel_req: session %d req %s", s->self, rtype);
 
        /*
         * a session is in LARVAL state until a shell, a command
@@ -1799,14 +1764,7 @@ session_input_channel_req(int id, void *arg)
        if (strcmp(rtype, "window-change") == 0) {
                success = session_window_change_req(s);
        }
-
-       if (reply) {
-               packet_start(success ?
-                   SSH2_MSG_CHANNEL_SUCCESS : SSH2_MSG_CHANNEL_FAILURE);
-               packet_put_int(c->remote_id);
-               packet_send();
-       }
-       xfree(rtype);
+       return success;
 }
 
 void
@@ -1858,29 +1816,28 @@ session_pty_cleanup(void *session)
         */
        if (close(s->ptymaster) < 0)
                error("close(s->ptymaster): %s", strerror(errno));
+
+       /* unlink pty from session */
+       s->ttyfd = -1;
 }
 
 static void
 session_exit_message(Session *s, int status)
 {
        Channel *c;
-       if (s == NULL)
-               fatal("session_close: no session");
-       c = channel_lookup(s->chanid);
-       if (c == NULL)
+
+       if ((c = channel_lookup(s->chanid)) == NULL)
                fatal("session_exit_message: session %d: no channel %d",
                    s->self, s->chanid);
        debug("session_exit_message: session %d channel %d pid %d",
            s->self, s->chanid, s->pid);
 
        if (WIFEXITED(status)) {
-               channel_request_start(s->chanid,
-                   "exit-status", 0);
+               channel_request_start(s->chanid, "exit-status", 0);
                packet_put_int(WEXITSTATUS(status));
                packet_send();
        } else if (WIFSIGNALED(status)) {
-               channel_request_start(s->chanid,
-                   "exit-signal", 0);
+               channel_request_start(s->chanid, "exit-signal", 0);
                packet_put_int(WTERMSIG(status));
 #ifdef WCOREDUMP
                packet_put_char(WCOREDUMP(status));
@@ -1921,6 +1878,8 @@ session_close(Session *s)
                xfree(s->term);
        if (s->display)
                xfree(s->display);
+       if (s->auth_display)
+               xfree(s->auth_display);
        if (s->auth_data)
                xfree(s->auth_data);
        if (s->auth_proto)
@@ -1942,22 +1901,6 @@ session_close_by_pid(pid_t pid, int status)
        session_close(s);
 }
 
-int
-session_have_children(void)
-{
-       int i;
-
-       for(i = 0; i < MAX_SESSIONS; i++) {
-               Session *s = &sessions[i];
-               if (s->used && s->pid != -1) {
-                       debug("session_have_children: id %d pid %d", i, s->pid);
-                       return 1;
-               }
-       }
-       debug("session_have_children: no more children");
-       return 0;
-}
-
 /*
  * this is called when a channel dies before
  * the session 'child' itself dies
@@ -1967,22 +1910,36 @@ session_close_by_channel(int id, void *arg)
 {
        Session *s = session_by_channel(id);
        if (s == NULL) {
-               debug("session_close_by_channel: no session for channel %d", id);
+               debug("session_close_by_channel: no session for id %d", id);
                return;
        }
-       /* disconnect channel */
+       debug("session_close_by_channel: channel %d child %d", id, s->pid);
+       if (s->pid != 0) {
+               debug("session_close_by_channel: channel %d: has child", id);
+               /*
+                * delay detach of session, but release pty, since
+                * the fd's to the child are already closed
+                */
+               if (s->ttyfd != -1) {
+                       fatal_remove_cleanup(session_pty_cleanup, (void *)s);
+                       session_pty_cleanup(s);
+               }
+               return;
+       }
+       /* detach by removing callback */
        channel_cancel_cleanup(s->chanid);
        s->chanid = -1;
+       session_close(s);
+}
 
-       debug("session_close_by_channel: channel %d kill %d", id, s->pid);
-       if (s->pid == 0) {
-               /* close session immediately */
-               session_close(s);
-       } else {
-               /* notify child, delay session cleanup */
-               if (kill(s->pid, (s->ttyfd == -1) ? SIGTERM : SIGHUP) < 0)
-                       error("session_close_by_channel: kill %d: %s",
-                           s->pid, strerror(errno));
+void
+session_destroy_all(void)
+{
+       int i;
+       for (i = 0; i < MAX_SESSIONS; i++) {
+               Session *s = &sessions[i];
+               if (s->used)
+                       session_close(s);
        }
 }
 
@@ -1992,7 +1949,7 @@ session_tty_list(void)
        static char buf[1024];
        int i;
        buf[0] = '\0';
-       for(i = 0; i < MAX_SESSIONS; i++) {
+       for (i = 0; i < MAX_SESSIONS; i++) {
                Session *s = &sessions[i];
                if (s->used && s->ttyfd != -1) {
                        if (buf[0] != '\0')
@@ -2018,6 +1975,8 @@ int
 session_setup_x11fwd(Session *s)
 {
        struct stat st;
+       char display[512], auth_display[512];
+       char hostname[MAXHOSTNAMELEN];
 
        if (no_x11_forwarding_flag) {
                packet_send_debug("X11 forwarding disabled in user configuration file.");
@@ -2041,11 +2000,50 @@ session_setup_x11fwd(Session *s)
                debug("X11 display already set.");
                return 0;
        }
-       s->display = x11_create_display_inet(s->screen, options.x11_display_offset);
-       if (s->display == NULL) {
+       s->display_number = x11_create_display_inet(options.x11_display_offset,
+           options.x11_use_localhost, s->single_connection);
+       if (s->display_number == -1) {
                debug("x11_create_display_inet failed.");
                return 0;
        }
+
+       /* Set up a suitable value for the DISPLAY variable. */
+       if (gethostname(hostname, sizeof(hostname)) < 0)
+               fatal("gethostname: %.100s", strerror(errno));
+       /*
+        * auth_display must be used as the displayname when the
+        * authorization entry is added with xauth(1).  This will be
+        * different than the DISPLAY string for localhost displays.
+        */
+       if (options.x11_use_localhost) {
+               snprintf(display, sizeof display, "localhost:%d.%d",
+                   s->display_number, s->screen);
+               snprintf(auth_display, sizeof auth_display, "unix:%d.%d",
+                   s->display_number, s->screen);
+               s->display = xstrdup(display);
+               s->auth_display = xstrdup(auth_display);
+       } else {
+#ifdef IPADDR_IN_DISPLAY
+               struct hostent *he;
+               struct in_addr my_addr;
+
+               he = gethostbyname(hostname);
+               if (he == NULL) {
+                       error("Can't get IP address for X11 DISPLAY.");
+                       packet_send_debug("Can't get IP address for X11 DISPLAY.");
+                       return 0;
+               }
+               memcpy(&my_addr, he->h_addr_list[0], sizeof(struct in_addr));
+               snprintf(display, sizeof display, "%.50s:%d.%d", inet_ntoa(my_addr),
+                   s->display_number, s->screen);
+#else
+               snprintf(display, sizeof display, "%.400s:%d.%d", hostname,
+                   s->display_number, s->screen);
+#endif
+               s->display = xstrdup(display);
+               s->auth_display = xstrdup(display);
+       }
+
        return 1;
 }
 
This page took 0.073015 seconds and 4 git commands to generate.