]> andersk Git - openssh.git/blobdiff - scp.c
- djm@cvs.openbsd.org 2001/12/21 10:06:43
[openssh.git] / scp.c
diff --git a/scp.c b/scp.c
index 3ca110b167f7222503e1182fa94885c65d539758..d285f9f55ff1f0e3ee2fbd355e57b77ab9d015ac 100644 (file)
--- a/scp.c
+++ b/scp.c
@@ -14,8 +14,8 @@
  * called by a name other than "ssh" or "Secure Shell".
  */
 /*
- * Copyright (c) 1999 Theo de Raadt. All rights reserved.
- * Copyright (c) 1999 Aaron Campbell. All rights reserved.
+ * Copyright (c) 1999 Theo de Raadt.  All rights reserved.
+ * Copyright (c) 1999 Aaron Campbell.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -75,7 +75,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: scp.c,v 1.58 2001/02/10 15:14:11 danh Exp $");
+RCSID("$OpenBSD: scp.c,v 1.86 2001/12/05 03:56:39 itojun Exp $");
 
 #include "xmalloc.h"
 #include "atomicio.h"
@@ -91,6 +91,8 @@ char *__progname;
 
 /* For progressmeter() -- number of seconds before xfer considered "stalled" */
 #define STALLTIME      5
+/* alarm() interval for updating progress meter */
+#define PROGRESSTIME   1
 
 /* Progress meter bar */
 #define BAR \
@@ -107,14 +109,14 @@ void progressmeter(int);
 int getttywidth(void);
 int do_cmd(char *host, char *remuser, char *cmd, int *fdin, int *fdout, int argc);
 
-/* setup arguments for the call to ssh */
-void addargs(char *fmt, ...) __attribute__((format(printf, 1, 2)));
+/* Struct for addargs */
+arglist args;
 
 /* Time a transfer started. */
 static struct timeval start;
 
 /* Number of bytes of current file transferred so far. */
-volatile u_long statbytes;
+volatile off_t statbytes;
 
 /* Total size of current file. */
 off_t totalbytes = 0;
@@ -131,13 +133,6 @@ int showprogress = 1;
 /* This is the program to execute for the secured connection. ("ssh" or -S) */
 char *ssh_program = _PATH_SSH_PROGRAM;
 
-/* This is the list of arguments that scp passes to ssh */
-struct {
-       char    **list;
-       int     num;
-       int     nalloc;
-} args;
-
 /*
  * This function executes the given command as the specified user on the
  * given host.  This returns < 0 if execution fails, and >= 0 otherwise. This
@@ -150,8 +145,10 @@ do_cmd(char *host, char *remuser, char *cmd, int *fdin, int *fdout, int argc)
        int pin[2], pout[2], reserved[2];
 
        if (verbose_mode)
-               fprintf(stderr, "Executing: program %s host %s, user %s, command %s\n",
-                   ssh_program, host, remuser ? remuser : "(unspecified)", cmd);
+               fprintf(stderr,
+                   "Executing: program %s host %s, user %s, command %s\n",
+                   ssh_program, host,
+                   remuser ? remuser : "(unspecified)", cmd);
 
        /*
         * Reserve two descriptors so that the real pipes won't get
@@ -181,9 +178,9 @@ do_cmd(char *host, char *remuser, char *cmd, int *fdin, int *fdout, int argc)
 
                args.list[0] = ssh_program;
                if (remuser != NULL)
-                       addargs("-l%s", remuser);
-               addargs("%s", host);
-               addargs("%s", cmd);
+                       addargs(&args, "-l%s", remuser);
+               addargs(&args, "%s", host);
+               addargs(&args, "%s", cmd);
 
                execvp(ssh_program, args.list);
                perror(ssh_program);
@@ -202,10 +199,7 @@ typedef struct {
        char *buf;
 } BUF;
 
-extern int iamremote;
-
 BUF *allocbuf(BUF *, int, int);
-char *colon(char *);
 void lostconn(int);
 void nospace(void);
 int okname(char *);
@@ -220,13 +214,11 @@ int pflag, iamremote, iamrecursive, targetshouldbedirectory;
 #define        CMDNEEDS        64
 char cmd[CMDNEEDS];            /* must hold "rcp -r -p -d\0" */
 
-int main(int, char *[]);
 int response(void);
 void rsource(char *, struct stat *);
 void sink(int, char *[]);
 void source(int, char *[]);
 void tolocal(int, char *[]);
-char *cleanhostname(char *);
 void toremote(char *, int, char *[]);
 void usage(void);
 
@@ -243,29 +235,32 @@ main(argc, argv)
        __progname = get_progname(argv[0]);
 
        args.list = NULL;
-       addargs("ssh");         /* overwritten with ssh_program */
-       addargs("-x");
-       addargs("-oFallBackToRsh no");
+       addargs(&args, "ssh");          /* overwritten with ssh_program */
+       addargs(&args, "-x");
+       addargs(&args, "-oForwardAgent no");
+       addargs(&args, "-oFallBackToRsh no");
+       addargs(&args, "-oClearAllForwardings yes");
 
        fflag = tflag = 0;
-       while ((ch = getopt(argc, argv, "dfprtvBCc:i:P:q46S:o:")) != -1)
+       while ((ch = getopt(argc, argv, "dfprtvBCc:i:P:q46S:o:F:")) != -1)
                switch (ch) {
                /* User-visible flags. */
                case '4':
                case '6':
                case 'C':
-                       addargs("-%c", ch);
+                       addargs(&args, "-%c", ch);
                        break;
                case 'o':
                case 'c':
                case 'i':
-                       addargs("-%c%s", ch, optarg);
+               case 'F':
+                       addargs(&args, "-%c%s", ch, optarg);
                        break;
                case 'P':
-                       addargs("-p%s", optarg);
+                       addargs(&args, "-p%s", optarg);
                        break;
                case 'B':
-                       addargs("-oBatchmode yes");
+                       addargs(&args, "-oBatchmode yes");
                        break;
                case 'p':
                        pflag = 1;
@@ -277,6 +272,7 @@ main(argc, argv)
                        ssh_program = xstrdup(optarg);
                        break;
                case 'v':
+                       addargs(&args, "-v");
                        verbose_mode = 1;
                        break;
                case 'q':
@@ -294,8 +290,10 @@ main(argc, argv)
                case 't':       /* "to" */
                        iamremote = 1;
                        tflag = 1;
+#ifdef HAVE_CYGWIN
+                       setmode(0, O_BINARY);
+#endif
                        break;
-               case '?':
                default:
                        usage();
                }
@@ -346,17 +344,6 @@ main(argc, argv)
        exit(errs != 0);
 }
 
-char *
-cleanhostname(host)
-       char *host;
-{
-       if (*host == '[' && host[strlen(host) - 1] == ']') {
-               host[strlen(host) - 1] = '\0';
-               return (host + 1);
-       } else
-               return host;
-}
-
 void
 toremote(targ, argc, argv)
        char *targ, *argv[];
@@ -385,13 +372,17 @@ toremote(targ, argc, argv)
        for (i = 0; i < argc - 1; i++) {
                src = colon(argv[i]);
                if (src) {      /* remote to remote */
+                       static char *ssh_options =
+                           "-x -o'FallBackToRsh no' "
+                           "-o'ClearAllForwardings yes'";
                        *src++ = 0;
                        if (*src == 0)
                                src = ".";
                        host = strchr(argv[i], '@');
                        len = strlen(ssh_program) + strlen(argv[i]) +
                            strlen(src) + (tuser ? strlen(tuser) : 0) +
-                           strlen(thost) + strlen(targ) + CMDNEEDS + 32;
+                           strlen(thost) + strlen(targ) +
+                           strlen(ssh_options) + CMDNEEDS + 20;
                        bp = xmalloc(len);
                        if (host) {
                                *host++ = 0;
@@ -402,19 +393,19 @@ toremote(targ, argc, argv)
                                else if (!okname(suser))
                                        continue;
                                snprintf(bp, len,
-                                   "%s%s -x -o'FallBackToRsh no' -n "
+                                   "%s%s %s -n "
                                    "-l %s %s %s %s '%s%s%s:%s'",
                                    ssh_program, verbose_mode ? " -v" : "",
-                                   suser, host, cmd, src,
+                                   ssh_options, suser, host, cmd, src,
                                    tuser ? tuser : "", tuser ? "@" : "",
                                    thost, targ);
                        } else {
                                host = cleanhostname(argv[i]);
                                snprintf(bp, len,
-                                   "exec %s%s -x -o'FallBackToRsh no' -n %s "
+                                   "exec %s%s %s -n %s "
                                    "%s %s '%s%s%s:%s'",
                                    ssh_program, verbose_mode ? " -v" : "",
-                                   host, cmd, src,
+                                   ssh_options, host, cmd, src,
                                    tuser ? tuser : "", tuser ? "@" : "",
                                    thost, targ);
                        }
@@ -501,13 +492,22 @@ source(argc, argv)
        struct stat stb;
        static BUF buffer;
        BUF *bp;
-       off_t i;
-       int amt, fd, haderr, indx, result;
+       off_t i, amt, result;
+       int fd, haderr, indx;
        char *last, *name, buf[2048];
+       int len;
 
        for (indx = 0; indx < argc; ++indx) {
                name = argv[indx];
                statbytes = 0;
+               len = strlen(name);
+               while (len > 1 && name[len-1] == '/')
+                       name[--len] = '\0';
+               if (strchr(name, '\n') != NULL) {
+                       run_err("%s: skipping, filename contains a newline",
+                           name);
+                       goto next;
+               }
                if ((fd = open(name, O_RDONLY, 0)) < 0)
                        goto syserr;
                if (fstat(fd, &stb) < 0) {
@@ -545,9 +545,17 @@ syserr:                    run_err("%s: %s", name, strerror(errno));
                                goto next;
                }
 #define        FILEMODEMASK    (S_ISUID|S_ISGID|S_IRWXU|S_IRWXG|S_IRWXO)
+#ifdef HAVE_LONG_LONG_INT
+               snprintf(buf, sizeof buf, "C%04o %lld %s\n",
+                   (u_int) (stb.st_mode & FILEMODEMASK),
+                   (long long) stb.st_size, last);
+#else
+               /* XXX: Handle integer overflow? */
                snprintf(buf, sizeof buf, "C%04o %lu %s\n",
                    (u_int) (stb.st_mode & FILEMODEMASK),
                    (u_long) stb.st_size, last);
+#endif
+
                if (verbose_mode) {
                        fprintf(stderr, "Sending file modes: %s", buf);
                        fflush(stderr);
@@ -632,7 +640,7 @@ rsource(name, statp)
                closedir(dirp);
                return;
        }
-       while ((dp = readdir(dirp))) {
+       while ((dp = readdir(dirp)) != NULL) {
                if (dp->d_ino == 0)
                        continue;
                if (!strcmp(dp->d_name, ".") || !strcmp(dp->d_name, ".."))
@@ -666,10 +674,11 @@ sink(argc, argv)
        off_t size;
        int setimes, targisdir, wrerrno = 0;
        char ch, *cp, *np, *targ, *why, *vect[1], buf[2048];
-       int dummy_usec;
        struct timeval tv[2];
 
-#define        SCREWUP(str)    { why = str; goto screwup; }
+#define        atime   tv[0]
+#define        mtime   tv[1]
+#define        SCREWUP(str)    do { why = str; goto screwup; } while (0)
 
        setimes = targisdir = 0;
        mask = umask(0);
@@ -715,25 +724,21 @@ sink(argc, argv)
                if (ch == '\n')
                        *--cp = 0;
 
-#define getnum(t) (t) = 0; \
-  while (*cp >= '0' && *cp <= '9') (t) = (t) * 10 + (*cp++ - '0');
                cp = buf;
                if (*cp == 'T') {
                        setimes++;
                        cp++;
-                       getnum(tv[1].tv_sec);
-                       if (*cp++ != ' ')
+                       mtime.tv_sec = strtol(cp, &cp, 10);
+                       if (!cp || *cp++ != ' ')
                                SCREWUP("mtime.sec not delimited");
-                       getnum(dummy_usec);
-                       tv[1].tv_usec = 0;
-                       if (*cp++ != ' ')
+                       mtime.tv_usec = strtol(cp, &cp, 10);
+                       if (!cp || *cp++ != ' ')
                                SCREWUP("mtime.usec not delimited");
-                       getnum(tv[0].tv_sec);
-                       if (*cp++ != ' ')
+                       atime.tv_sec = strtol(cp, &cp, 10);
+                       if (!cp || *cp++ != ' ')
                                SCREWUP("atime.sec not delimited");
-                       getnum(dummy_usec);
-                       tv[0].tv_usec = 0;
-                       if (*cp++ != '\0')
+                       atime.tv_usec = strtol(cp, &cp, 10);
+                       if (!cp || *cp++ != '\0')
                                SCREWUP("atime.usec not delimited");
                        (void) atomicio(write, remout, "", 1);
                        continue;
@@ -761,7 +766,7 @@ sink(argc, argv)
                if (*cp++ != ' ')
                        SCREWUP("mode not delimited");
 
-               for (size = 0; *cp >= '0' && *cp <= '9';)
+               for (size = 0; isdigit(*cp);)
                        size = size * 10 + (*cp++ - '0');
                if (*cp++ != ' ')
                        SCREWUP("size not delimited");
@@ -802,21 +807,21 @@ sink(argc, argv)
                        }
                        vect[0] = xstrdup(np);
                        sink(1, vect);
-                       if (vect[0])
-                               xfree(vect[0]);
                        if (setimes) {
                                setimes = 0;
-                               if (utimes(np, tv) < 0)
+                               if (utimes(vect[0], tv) < 0)
                                        run_err("%s: set times: %s",
-                                               np, strerror(errno));
+                                           vect[0], strerror(errno));
                        }
                        if (mod_flag)
-                               (void) chmod(np, mode);
+                               (void) chmod(vect[0], mode);
+                       if (vect[0])
+                               xfree(vect[0]);
                        continue;
                }
                omode = mode;
                mode |= S_IWRITE;
-               if ((ofd = open(np, O_WRONLY | O_CREAT | O_TRUNC, mode)) < 0) {
+               if ((ofd = open(np, O_WRONLY|O_CREAT, mode)) < 0) {
 bad:                   run_err("%s: %s", np, strerror(errno));
                        continue;
                }
@@ -840,11 +845,12 @@ bad:                      run_err("%s: %s", np, strerror(errno));
                        count += amt;
                        do {
                                j = read(remin, cp, amt);
-                               if (j == -1 && (errno == EINTR || errno == EAGAIN)) {
+                               if (j == -1 && (errno == EINTR ||
+                                   errno == EAGAIN)) {
                                        continue;
                                } else if (j <= 0) {
                                        run_err("%s", j ? strerror(errno) :
-                                               "dropped connection");
+                                           "dropped connection");
                                        exit(1);
                                }
                                amt -= j;
@@ -871,12 +877,10 @@ bad:                      run_err("%s: %s", np, strerror(errno));
                        wrerr = YES;
                        wrerrno = j >= 0 ? EIO : errno;
                }
-#if 0
                if (ftruncate(ofd, size)) {
                        run_err("%s: truncate: %s", np, strerror(errno));
                        wrerr = DISPLAYED;
                }
-#endif
                if (pflag) {
                        if (exists || omode != mode)
 #ifdef HAVE_FCHMOD
@@ -885,7 +889,7 @@ bad:                        run_err("%s: %s", np, strerror(errno));
                                if (chmod(np, omode))
 #endif /* HAVE_FCHMOD */
                                        run_err("%s: set mode: %s",
-                                               np, strerror(errno));
+                                           np, strerror(errno));
                } else {
                        if (!exists && omode != mode)
 #ifdef HAVE_FCHMOD
@@ -894,7 +898,7 @@ bad:                        run_err("%s: %s", np, strerror(errno));
                                if (chmod(np, omode & ~mask))
 #endif /* HAVE_FCHMOD */
                                        run_err("%s: set mode: %s",
-                                               np, strerror(errno));
+                                           np, strerror(errno));
                }
                if (close(ofd) == -1) {
                        wrerr = YES;
@@ -905,7 +909,7 @@ bad:                        run_err("%s: %s", np, strerror(errno));
                        setimes = 0;
                        if (utimes(np, tv) < 0) {
                                run_err("%s: set times: %s",
-                                       np, strerror(errno));
+                                   np, strerror(errno));
                                wrerr = DISPLAYED;
                        }
                }
@@ -926,7 +930,7 @@ screwup:
 }
 
 int
-response()
+response(void)
 {
        char ch, *cp, resp, rbuf[2048];
 
@@ -959,11 +963,12 @@ response()
 }
 
 void
-usage()
+usage(void)
 {
-       (void) fprintf(stderr, "usage: scp "
-           "[-pqrvC46] [-S ssh] [-P port] [-c cipher] [-i identity] f1 f2; or:\n"
-           "       scp [options] f1 ... fn directory\n");
+       (void) fprintf(stderr,
+           "usage: scp [-pqrvBC46] [-F config] [-S ssh] [-P port] [-c cipher] [-i identity]\n"
+           "           [-o option] f1 f2\n"
+           "   or: scp [options] f1 ... fn directory\n");
        exit(1);
 }
 
@@ -992,30 +997,6 @@ run_err(const char *fmt,...)
        }
 }
 
-char *
-colon(cp)
-       char *cp;
-{
-       int flag = 0;
-
-       if (*cp == ':')         /* Leading colon is part of file name. */
-               return (0);
-       if (*cp == '[')
-               flag = 1;
-
-       for (; *cp; ++cp) {
-               if (*cp == '@' && *(cp+1) == '[')
-                       flag = 1;
-               if (*cp == ']' && *(cp+1) == ':' && flag)
-                       return (cp+1);
-               if (*cp == ':' && !flag)
-                       return (cp);
-               if (*cp == '/')
-                       return (0);
-       }
-       return (0);
-}
-
 void
 verifydir(cp)
        char *cp;
@@ -1040,7 +1021,7 @@ okname(cp0)
 
        cp = cp0;
        do {
-               c = *cp;
+               c = (int)*cp;
                if (c & 0200)
                        goto bad;
                if (!isalpha(c) && !isdigit(c) &&
@@ -1059,7 +1040,7 @@ allocbuf(bp, fd, blksize)
        int fd, blksize;
 {
        size_t size;
-#ifdef HAVE_ST_BLKSIZE
+#ifdef HAVE_STRUCT_STAT_ST_BLKSIZE
        struct stat stb;
 
        if (fstat(fd, &stb) < 0) {
@@ -1071,15 +1052,16 @@ allocbuf(bp, fd, blksize)
        else
                size = blksize + (stb.st_blksize - blksize % stb.st_blksize) %
                    stb.st_blksize;
-#else /* HAVE_ST_BLKSIZE */
+#else /* HAVE_STRUCT_STAT_ST_BLKSIZE */
        size = blksize;
-#endif /* HAVE_ST_BLKSIZE */
+#endif /* HAVE_STRUCT_STAT_ST_BLKSIZE */
        if (bp->cnt >= size)
                return (bp);
        if (bp->buf == NULL)
                bp->buf = xmalloc(size);
        else
                bp->buf = xrealloc(bp->buf, size);
+       memset(bp->buf, 0, size);
        bp->cnt = size;
        return (bp);
 }
@@ -1089,32 +1071,25 @@ lostconn(signo)
        int signo;
 {
        if (!iamremote)
-               fprintf(stderr, "lost connection\n");
-       exit(1);
-}
-
-
-void
-alarmtimer(int wait)
-{
-       struct itimerval itv;
-
-       itv.it_value.tv_sec = wait;
-       itv.it_value.tv_usec = 0;
-       itv.it_interval = itv.it_value;
-       setitimer(ITIMER_REAL, &itv, NULL);
+               write(STDERR_FILENO, "lost connection\n", 16);
+       if (signo)
+               _exit(1);
+       else
+               exit(1);
 }
 
-void
+static void
 updateprogressmeter(int ignore)
 {
        int save_errno = errno;
 
        progressmeter(0);
+       signal(SIGALRM, updateprogressmeter);
+       alarm(PROGRESSTIME);
        errno = save_errno;
 }
 
-int
+static int
 foregroundproc(void)
 {
        static pid_t pgrp = -1;
@@ -1223,9 +1198,9 @@ progressmeter(int flag)
 
        if (flag == -1) {
                mysignal(SIGALRM, updateprogressmeter);
-               alarmtimer(1);
+               alarm(PROGRESSTIME);
        } else if (flag == 1) {
-               alarmtimer(0);
+               alarm(0);
                atomicio(write, fileno(stdout), "\n", 1);
                statbytes = 0;
        }
@@ -1241,25 +1216,3 @@ getttywidth(void)
        else
                return (80);
 }
-
-void
-addargs(char *fmt, ...)
-{
-       va_list ap;
-       char buf[1024];
-
-       va_start(ap, fmt);
-       vsnprintf(buf, sizeof(buf), fmt, ap);
-       va_end(ap);
-
-       if (args.list == NULL) {
-               args.nalloc = 32;
-               args.num = 0;
-               args.list = xmalloc(args.nalloc * sizeof(char *));
-       } else if (args.num+2 >= args.nalloc) {
-               args.nalloc *= 2;
-               args.list = xrealloc(args.list, args.nalloc * sizeof(char *));
-       }
-       args.list[args.num++] = xstrdup(buf);
-       args.list[args.num] = NULL;
-}
This page took 0.513297 seconds and 4 git commands to generate.