]> andersk Git - openssh.git/blobdiff - sftp.c
- halex@cvs.openbsd.org 2009/11/22 13:18:00
[openssh.git] / sftp.c
diff --git a/sftp.c b/sftp.c
index 50ac03798a7164a1cfe6ec3f717a2ab9c1398865..2ce7cc1e1ef8099d9213fee88c0926a3be6229bf 100644 (file)
--- a/sftp.c
+++ b/sftp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp.c,v 1.100 2008/04/18 12:32:11 djm Exp $ */
+/* $OpenBSD: sftp.c,v 1.113 2009/11/22 13:18:00 halex Exp $ */
 /*
  * Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
  *
@@ -35,6 +35,9 @@
 #ifdef HAVE_PATHS_H
 # include <paths.h>
 #endif
+#ifdef HAVE_LIBGEN_H
+#include <libgen.h>
+#endif
 #ifdef USE_LIBEDIT
 #include <histedit.h>
 #else
@@ -65,24 +68,27 @@ typedef void EditLine;
 #include "sftp-common.h"
 #include "sftp-client.h"
 
+#define DEFAULT_COPY_BUFLEN    32768   /* Size of buffer for up/download */
+#define DEFAULT_NUM_REQUESTS   64      /* # concurrent outstanding requests */
+
 /* File to read commands from */
 FILE* infile;
 
 /* Are we in batchfile mode? */
 int batchmode = 0;
 
-/* Size of buffer used when copying files */
-size_t copy_buffer_len = 32768;
-
-/* Number of concurrent outstanding requests */
-size_t num_requests = 16;
-
 /* PID of ssh transport process */
 static pid_t sshpid = -1;
 
 /* This is set to 0 if the progressmeter is not desired. */
 int showprogress = 1;
 
+/* When this option is set, we always recursively download/upload directories */
+int global_rflag = 0;
+
+/* When this option is set, the file transfers will always preserve times */
+int global_pflag = 0;
+
 /* SIGINT received during command processing */
 volatile sig_atomic_t interrupted = 0;
 
@@ -178,7 +184,7 @@ static const struct CMD cmds[] = {
        { NULL,                 -1}
 };
 
-int interactive_loop(int fd_in, int fd_out, char *file1, char *file2);
+int interactive_loop(struct sftp_conn *, char *file1, char *file2);
 
 /* ARGSUSED */
 static void
@@ -207,36 +213,37 @@ cmd_interrupt(int signo)
 static void
 help(void)
 {
-       printf("Available commands:\n");
-       printf("cd path                       Change remote directory to 'path'\n");
-       printf("lcd path                      Change local directory to 'path'\n");
-       printf("chgrp grp path                Change group of file 'path' to 'grp'\n");
-       printf("chmod mode path               Change permissions of file 'path' to 'mode'\n");
-       printf("chown own path                Change owner of file 'path' to 'own'\n");
-       printf("df [path]                     Display statistics for current directory or\n");
-       printf("                              filesystem containing 'path'\n");
-       printf("help                          Display this help text\n");
-       printf("get remote-path [local-path]  Download file\n");
-       printf("lls [ls-options [path]]       Display local directory listing\n");
-       printf("ln oldpath newpath            Symlink remote file\n");
-       printf("lmkdir path                   Create local directory\n");
-       printf("lpwd                          Print local working directory\n");
-       printf("ls [path]                     Display remote directory listing\n");
-       printf("lumask umask                  Set local umask to 'umask'\n");
-       printf("mkdir path                    Create remote directory\n");
-       printf("progress                      Toggle display of progress meter\n");
-       printf("put local-path [remote-path]  Upload file\n");
-       printf("pwd                           Display remote working directory\n");
-       printf("exit                          Quit sftp\n");
-       printf("quit                          Quit sftp\n");
-       printf("rename oldpath newpath        Rename remote file\n");
-       printf("rmdir path                    Remove remote directory\n");
-       printf("rm path                       Delete remote file\n");
-       printf("symlink oldpath newpath       Symlink remote file\n");
-       printf("version                       Show SFTP version\n");
-       printf("!command                      Execute 'command' in local shell\n");
-       printf("!                             Escape to local shell\n");
-       printf("?                             Synonym for help\n");
+       printf("Available commands:\n"
+           "bye                                Quit sftp\n"
+           "cd path                            Change remote directory to 'path'\n"
+           "chgrp grp path                     Change group of file 'path' to 'grp'\n"
+           "chmod mode path                    Change permissions of file 'path' to 'mode'\n"
+           "chown own path                     Change owner of file 'path' to 'own'\n"
+           "df [-hi] [path]                    Display statistics for current directory or\n"
+           "                                   filesystem containing 'path'\n"
+           "exit                               Quit sftp\n"
+           "get [-Pr] remote-path [local-path] Download file\n"
+           "help                               Display this help text\n"
+           "lcd path                           Change local directory to 'path'\n"
+           "lls [ls-options [path]]            Display local directory listing\n"
+           "lmkdir path                        Create local directory\n"
+           "ln oldpath newpath                 Symlink remote file\n"
+           "lpwd                               Print local working directory\n"
+           "ls [-1aflnrSt] [path]              Display remote directory listing\n"
+           "lumask umask                       Set local umask to 'umask'\n"
+           "mkdir path                         Create remote directory\n"
+           "progress                           Toggle display of progress meter\n"
+           "put [-Pr] local-path [remote-path] Upload file\n"
+           "pwd                                Display remote working directory\n"
+           "quit                               Quit sftp\n"
+           "rename oldpath newpath             Rename remote file\n"
+           "rm path                            Delete remote file\n"
+           "rmdir path                         Remove remote directory\n"
+           "symlink oldpath newpath            Symlink remote file\n"
+           "version                            Show SFTP version\n"
+           "!command                           Execute 'command' in local shell\n"
+           "!                                  Escape to local shell\n"
+           "?                                  Synonym for help\n");
 }
 
 static void
@@ -312,21 +319,6 @@ path_strip(char *path, char *strip)
        return (xstrdup(path));
 }
 
-static char *
-path_append(char *p1, char *p2)
-{
-       char *ret;
-       size_t len = strlen(p1) + strlen(p2) + 2;
-
-       ret = xmalloc(len);
-       strlcpy(ret, p1, len);
-       if (p1[0] != '\0' && p1[strlen(p1) - 1] != '/')
-               strlcat(ret, "/", len);
-       strlcat(ret, p2, len);
-
-       return(ret);
-}
-
 static char *
 make_absolute(char *p, char *pwd)
 {
@@ -342,43 +334,28 @@ make_absolute(char *p, char *pwd)
 }
 
 static int
-infer_path(const char *p, char **ifp)
-{
-       char *cp;
-
-       cp = strrchr(p, '/');
-       if (cp == NULL) {
-               *ifp = xstrdup(p);
-               return(0);
-       }
-
-       if (!cp[1]) {
-               error("Invalid path");
-               return(-1);
-       }
-
-       *ifp = xstrdup(cp + 1);
-       return(0);
-}
-
-static int
-parse_getput_flags(const char *cmd, char **argv, int argc, int *pflag)
+parse_getput_flags(const char *cmd, char **argv, int argc, int *pflag,
+    int *rflag)
 {
-       extern int optind, optreset, opterr;
+       extern int opterr, optind, optopt, optreset;
        int ch;
 
        optind = optreset = 1;
        opterr = 0;
 
-       *pflag = 0;
-       while ((ch = getopt(argc, argv, "Pp")) != -1) {
+       *rflag = *pflag = 0;
+       while ((ch = getopt(argc, argv, "PpRr")) != -1) {
                switch (ch) {
                case 'p':
                case 'P':
                        *pflag = 1;
                        break;
+               case 'r':
+               case 'R':
+                       *rflag = 1;
+                       break;
                default:
-                       error("%s: Invalid flag -%c", cmd, ch);
+                       error("%s: Invalid flag -%c", cmd, optopt);
                        return -1;
                }
        }
@@ -389,7 +366,7 @@ parse_getput_flags(const char *cmd, char **argv, int argc, int *pflag)
 static int
 parse_ls_flags(char **argv, int argc, int *lflag)
 {
-       extern int optind, optreset, opterr;
+       extern int opterr, optind, optopt, optreset;
        int ch;
 
        optind = optreset = 1;
@@ -428,7 +405,7 @@ parse_ls_flags(char **argv, int argc, int *lflag)
                        *lflag |= LS_TIME_SORT;
                        break;
                default:
-                       error("ls: Invalid flag -%c", ch);
+                       error("ls: Invalid flag -%c", optopt);
                        return -1;
                }
        }
@@ -439,7 +416,7 @@ parse_ls_flags(char **argv, int argc, int *lflag)
 static int
 parse_df_flags(const char *cmd, char **argv, int argc, int *hflag, int *iflag)
 {
-       extern int optind, optreset, opterr;
+       extern int opterr, optind, optopt, optreset;
        int ch;
 
        optind = optreset = 1;
@@ -455,7 +432,7 @@ parse_df_flags(const char *cmd, char **argv, int argc, int *hflag, int *iflag)
                        *iflag = 1;
                        break;
                default:
-                       error("%s: Invalid flag -%c", cmd, ch);
+                       error("%s: Invalid flag -%c", cmd, optopt);
                        return -1;
                }
        }
@@ -488,62 +465,79 @@ remote_is_dir(struct sftp_conn *conn, char *path)
        return(S_ISDIR(a->perm));
 }
 
+/* Check whether path returned from glob(..., GLOB_MARK, ...) is a directory */
+static int
+pathname_is_dir(char *pathname)
+{
+       size_t l = strlen(pathname);
+
+       return l > 0 && pathname[l - 1] == '/';
+}
+
 static int
-process_get(struct sftp_conn *conn, char *src, char *dst, char *pwd, int pflag)
+process_get(struct sftp_conn *conn, char *src, char *dst, char *pwd,
+    int pflag, int rflag)
 {
        char *abs_src = NULL;
        char *abs_dst = NULL;
-       char *tmp;
        glob_t g;
-       int err = 0;
-       int i;
+       char *filename, *tmp=NULL;
+       int i, err = 0;
 
        abs_src = xstrdup(src);
        abs_src = make_absolute(abs_src, pwd);
-
        memset(&g, 0, sizeof(g));
+
        debug3("Looking up %s", abs_src);
-       if (remote_glob(conn, abs_src, 0, NULL, &g)) {
+       if (remote_glob(conn, abs_src, GLOB_MARK, NULL, &g)) {
                error("File \"%s\" not found.", abs_src);
                err = -1;
                goto out;
        }
 
-       /* If multiple matches, dst must be a directory or unspecified */
-       if (g.gl_matchc > 1 && dst && !is_dir(dst)) {
-               error("Multiple files match, but \"%s\" is not a directory",
-                   dst);
+       /*
+        * If multiple matches then dst must be a directory or
+        * unspecified.
+        */
+       if (g.gl_matchc > 1 && dst != NULL && !is_dir(dst)) {
+               error("Multiple source paths, but destination "
+                   "\"%s\" is not a directory", dst);
                err = -1;
                goto out;
        }
 
        for (i = 0; g.gl_pathv[i] && !interrupted; i++) {
-               if (infer_path(g.gl_pathv[i], &tmp)) {
+               tmp = xstrdup(g.gl_pathv[i]);
+               if ((filename = basename(tmp)) == NULL) {
+                       error("basename %s: %s", tmp, strerror(errno));
+                       xfree(tmp);
                        err = -1;
                        goto out;
                }
 
                if (g.gl_matchc == 1 && dst) {
-                       /* If directory specified, append filename */
-                       xfree(tmp);
                        if (is_dir(dst)) {
-                               if (infer_path(g.gl_pathv[0], &tmp)) {
-                                       err = 1;
-                                       goto out;
-                               }
-                               abs_dst = path_append(dst, tmp);
-                               xfree(tmp);
-                       } else
+                               abs_dst = path_append(dst, filename);
+                       } else {
                                abs_dst = xstrdup(dst);
+                       }
                } else if (dst) {
-                       abs_dst = path_append(dst, tmp);
-                       xfree(tmp);
-               } else
-                       abs_dst = tmp;
+                       abs_dst = path_append(dst, filename);
+               } else {
+                       abs_dst = xstrdup(filename);
+               }
+               xfree(tmp);
 
                printf("Fetching %s to %s\n", g.gl_pathv[i], abs_dst);
-               if (do_download(conn, g.gl_pathv[i], abs_dst, pflag) == -1)
-                       err = -1;
+               if (pathname_is_dir(g.gl_pathv[i]) && (rflag || global_rflag)) {
+                       if (download_dir(conn, g.gl_pathv[i], abs_dst, NULL, 
+                           pflag || global_pflag, 1) == -1)
+                               err = -1;
+               } else {
+                       if (do_download(conn, g.gl_pathv[i], abs_dst, NULL,
+                           pflag || global_pflag) == -1)
+                               err = -1;
+               }
                xfree(abs_dst);
                abs_dst = NULL;
        }
@@ -555,14 +549,15 @@ out:
 }
 
 static int
-process_put(struct sftp_conn *conn, char *src, char *dst, char *pwd, int pflag)
+process_put(struct sftp_conn *conn, char *src, char *dst, char *pwd,
+    int pflag, int rflag)
 {
        char *tmp_dst = NULL;
        char *abs_dst = NULL;
-       char *tmp;
+       char *tmp = NULL, *filename = NULL;
        glob_t g;
        int err = 0;
-       int i;
+       int i, dst_is_dir = 1;
        struct stat sb;
 
        if (dst) {
@@ -572,16 +567,20 @@ process_put(struct sftp_conn *conn, char *src, char *dst, char *pwd, int pflag)
 
        memset(&g, 0, sizeof(g));
        debug3("Looking up %s", src);
-       if (glob(src, GLOB_NOCHECK, NULL, &g)) {
+       if (glob(src, GLOB_NOCHECK | GLOB_MARK, NULL, &g)) {
                error("File \"%s\" not found.", src);
                err = -1;
                goto out;
        }
 
+       /* If we aren't fetching to pwd then stash this status for later */
+       if (tmp_dst != NULL)
+               dst_is_dir = remote_is_dir(conn, tmp_dst);
+
        /* If multiple matches, dst may be directory or unspecified */
-       if (g.gl_matchc > 1 && tmp_dst && !remote_is_dir(conn, tmp_dst)) {
-               error("Multiple files match, but \"%s\" is not a directory",
-                   tmp_dst);
+       if (g.gl_matchc > 1 && tmp_dst && !dst_is_dir) {
+               error("Multiple paths match, but destination "
+                   "\"%s\" is not a directory", tmp_dst);
                err = -1;
                goto out;
        }
@@ -592,38 +591,38 @@ process_put(struct sftp_conn *conn, char *src, char *dst, char *pwd, int pflag)
                        error("stat %s: %s", g.gl_pathv[i], strerror(errno));
                        continue;
                }
-
-               if (!S_ISREG(sb.st_mode)) {
-                       error("skipping non-regular file %s",
-                           g.gl_pathv[i]);
-                       continue;
-               }
-               if (infer_path(g.gl_pathv[i], &tmp)) {
+               
+               tmp = xstrdup(g.gl_pathv[i]);
+               if ((filename = basename(tmp)) == NULL) {
+                       error("basename %s: %s", tmp, strerror(errno));
+                       xfree(tmp);
                        err = -1;
                        goto out;
                }
 
                if (g.gl_matchc == 1 && tmp_dst) {
                        /* If directory specified, append filename */
-                       if (remote_is_dir(conn, tmp_dst)) {
-                               if (infer_path(g.gl_pathv[0], &tmp)) {
-                                       err = 1;
-                                       goto out;
-                               }
-                               abs_dst = path_append(tmp_dst, tmp);
-                               xfree(tmp);
-                       } else
+                       if (dst_is_dir)
+                               abs_dst = path_append(tmp_dst, filename);
+                       else
                                abs_dst = xstrdup(tmp_dst);
-
                } else if (tmp_dst) {
-                       abs_dst = path_append(tmp_dst, tmp);
-                       xfree(tmp);
-               } else
-                       abs_dst = make_absolute(tmp, pwd);
+                       abs_dst = path_append(tmp_dst, filename);
+               } else {
+                       abs_dst = make_absolute(xstrdup(filename), pwd);
+               }
+               xfree(tmp);
 
                printf("Uploading %s to %s\n", g.gl_pathv[i], abs_dst);
-               if (do_upload(conn, g.gl_pathv[i], abs_dst, pflag) == -1)
-                       err = -1;
+               if (pathname_is_dir(g.gl_pathv[i]) && (rflag || global_rflag)) {
+                       if (upload_dir(conn, g.gl_pathv[i], abs_dst,
+                           pflag || global_pflag, 1) == -1)
+                               err = -1;
+               } else {
+                       if (do_upload(conn, g.gl_pathv[i], abs_dst,
+                           pflag || global_pflag) == -1)
+                               err = -1;
+               }
        }
 
 out:
@@ -842,7 +841,7 @@ do_globbed_ls(struct sftp_conn *conn, char *path, char *strip_path,
 static int
 do_df(struct sftp_conn *conn, char *path, int hflag, int iflag)
 {
-       struct statvfs st;
+       struct sftp_statvfs st;
        char s_used[FMT_SCALED_STRSIZE];
        char s_avail[FMT_SCALED_STRSIZE];
        char s_root[FMT_SCALED_STRSIZE];
@@ -1064,7 +1063,7 @@ makeargv(const char *arg, int *argcp)
 }
 
 static int
-parse_args(const char **cpp, int *pflag, int *lflag, int *iflag, int *hflag,
+parse_args(const char **cpp, int *pflag, int *rflag, int *lflag, int *iflag, int *hflag,
     unsigned long *n_arg, char **path1, char **path2)
 {
        const char *cmd, *cp = *cpp;
@@ -1108,13 +1107,13 @@ parse_args(const char **cpp, int *pflag, int *lflag, int *iflag, int *hflag,
        }
 
        /* Get arguments and parse flags */
-       *lflag = *pflag = *hflag = *n_arg = 0;
+       *lflag = *pflag = *rflag = *hflag = *n_arg = 0;
        *path1 = *path2 = NULL;
        optidx = 1;
        switch (cmdnum) {
        case I_GET:
        case I_PUT:
-               if ((optidx = parse_getput_flags(cmd, argv, argc, pflag)) == -1)
+               if ((optidx = parse_getput_flags(cmd, argv, argc, pflag, rflag)) == -1)
                        return -1;
                /* Get first pathname (mandatory) */
                if (argc - optidx < 1) {
@@ -1234,15 +1233,15 @@ parse_dispatch_command(struct sftp_conn *conn, const char *cmd, char **pwd,
     int err_abort)
 {
        char *path1, *path2, *tmp;
-       int pflag, lflag, iflag, hflag, cmdnum, i;
-       unsigned long n_arg;
+       int pflag = 0, rflag = 0, lflag = 0, iflag = 0, hflag = 0, cmdnum, i;
+       unsigned long n_arg = 0;
        Attrib a, *aa;
        char path_buf[MAXPATHLEN];
        int err = 0;
        glob_t g;
 
        path1 = path2 = NULL;
-       cmdnum = parse_args(&cmd, &pflag, &lflag, &iflag, &hflag, &n_arg,
+       cmdnum = parse_args(&cmd, &pflag, &rflag, &lflag, &iflag, &hflag, &n_arg,
            &path1, &path2);
 
        if (iflag != 0)
@@ -1260,10 +1259,10 @@ parse_dispatch_command(struct sftp_conn *conn, const char *cmd, char **pwd,
                err = -1;
                break;
        case I_GET:
-               err = process_get(conn, path1, path2, *pwd, pflag);
+               err = process_get(conn, path1, path2, *pwd, pflag, rflag);
                break;
        case I_PUT:
-               err = process_put(conn, path1, path2, *pwd, pflag);
+               err = process_put(conn, path1, path2, *pwd, pflag, rflag);
                break;
        case I_RENAME:
                path1 = make_absolute(path1, *pwd);
@@ -1289,7 +1288,7 @@ parse_dispatch_command(struct sftp_conn *conn, const char *cmd, char **pwd,
                attrib_clear(&a);
                a.flags |= SSH2_FILEXFER_ATTR_PERMISSIONS;
                a.perm = 0777;
-               err = do_mkdir(conn, path1, &a);
+               err = do_mkdir(conn, path1, &a, 1);
                break;
        case I_RMDIR:
                path1 = make_absolute(path1, *pwd);
@@ -1386,17 +1385,19 @@ parse_dispatch_command(struct sftp_conn *conn, const char *cmd, char **pwd,
                remote_glob(conn, path1, GLOB_NOCHECK, NULL, &g);
                for (i = 0; g.gl_pathv[i] && !interrupted; i++) {
                        if (!(aa = do_stat(conn, g.gl_pathv[i], 0))) {
-                               if (err != 0 && err_abort)
+                               if (err_abort) {
+                                       err = -1;
                                        break;
-                               else
+                               else
                                        continue;
                        }
                        if (!(aa->flags & SSH2_FILEXFER_ATTR_UIDGID)) {
                                error("Can't get current ownership of "
                                    "remote file \"%s\"", g.gl_pathv[i]);
-                               if (err != 0 && err_abort)
+                               if (err_abort) {
+                                       err = -1;
                                        break;
-                               else
+                               else
                                        continue;
                        }
                        aa->flags &= SSH2_FILEXFER_ATTR_UIDGID;
@@ -1468,12 +1469,11 @@ prompt(EditLine *el)
 #endif
 
 int
-interactive_loop(int fd_in, int fd_out, char *file1, char *file2)
+interactive_loop(struct sftp_conn *conn, char *file1, char *file2)
 {
        char *pwd;
        char *dir = NULL;
        char cmd[2048];
-       struct sftp_conn *conn;
        int err, interactive;
        EditLine *el = NULL;
 #ifdef USE_LIBEDIT
@@ -1497,10 +1497,6 @@ interactive_loop(int fd_in, int fd_out, char *file1, char *file2)
        }
 #endif /* USE_LIBEDIT */
 
-       conn = do_init(fd_in, fd_out, copy_buffer_len, num_requests);
-       if (conn == NULL)
-               fatal("Couldn't initialise connection to server");
-
        pwd = do_realpath(conn, ".");
        if (pwd == NULL)
                fatal("Need cwd");
@@ -1665,12 +1661,16 @@ usage(void)
        extern char *__progname;
 
        fprintf(stderr,
-           "usage: %s [-1Cv] [-B buffer_size] [-b batchfile] [-F ssh_config]\n"
-           "            [-o ssh_option] [-P sftp_server_path] [-R num_requests]\n"
-           "            [-S program] [-s subsystem | sftp_server] host\n"
-           "       %s [[user@]host[:file [file]]]\n"
-           "       %s [[user@]host[:dir[/]]]\n"
-           "       %s -b batchfile [user@]host\n", __progname, __progname, __progname, __progname);
+           "usage: %s [-1246Cpqrv] [-B buffer_size] [-b batchfile] [-c cipher]\n"
+           "          [-D sftp_server_path] [-F ssh_config] "
+           "[-i identity_file]\n"
+           "          [-o ssh_option] [-P port] [-R num_requests] "
+           "[-S program]\n"
+           "          [-s subsystem | sftp_server] host\n"
+           "       %s [user@]host[:file ...]\n"
+           "       %s [user@]host[:dir[/]]\n"
+           "       %s -b batchfile [user@]host\n",
+           __progname, __progname, __progname, __progname);
        exit(1);
 }
 
@@ -1686,6 +1686,9 @@ main(int argc, char **argv)
        arglist args;
        extern int optind;
        extern char *optarg;
+       struct sftp_conn *conn;
+       size_t copy_buffer_len = DEFAULT_COPY_BUFLEN;
+       size_t num_requests = DEFAULT_NUM_REQUESTS;
 
        /* Ensure that fds 0, 1 and 2 are open or directed to /dev/null */
        sanitise_stdfd();
@@ -1702,10 +1705,29 @@ main(int argc, char **argv)
        ll = SYSLOG_LEVEL_INFO;
        infile = stdin;
 
-       while ((ch = getopt(argc, argv, "1hvCo:s:S:b:B:F:P:R:")) != -1) {
+       while ((ch = getopt(argc, argv,
+           "1246hqrvCc:D:i:o:s:S:b:B:F:P:R:")) != -1) {
                switch (ch) {
+               /* Passed through to ssh(1) */
+               case '4':
+               case '6':
                case 'C':
-                       addargs(&args, "-C");
+                       addargs(&args, "-%c", ch);
+                       break;
+               /* Passed through to ssh(1) with argument */
+               case 'F':
+               case 'c':
+               case 'i':
+               case 'o':
+                       addargs(&args, "-%c", ch);
+                       addargs(&args, "%s", optarg);
+                       break;
+               case 'q':
+                       showprogress = 0;
+                       addargs(&args, "-%c", ch);
+                       break;
+               case 'P':
+                       addargs(&args, "-oPort %s", optarg);
                        break;
                case 'v':
                        if (debug_level < 3) {
@@ -1714,21 +1736,18 @@ main(int argc, char **argv)
                        }
                        debug_level++;
                        break;
-               case 'F':
-               case 'o':
-                       addargs(&args, "-%c%s", ch, optarg);
-                       break;
                case '1':
                        sshver = 1;
                        if (sftp_server == NULL)
                                sftp_server = _PATH_SFTP_SERVER;
                        break;
-               case 's':
-                       sftp_server = optarg;
+               case '2':
+                       sshver = 2;
                        break;
-               case 'S':
-                       ssh_program = optarg;
-                       replacearg(&args, 0, "%s", ssh_program);
+               case 'B':
+                       copy_buffer_len = strtol(optarg, &cp, 10);
+                       if (copy_buffer_len == 0 || *cp != '\0')
+                               fatal("Invalid buffer size \"%s\"", optarg);
                        break;
                case 'b':
                        if (batchmode)
@@ -1742,13 +1761,14 @@ main(int argc, char **argv)
                        batchmode = 1;
                        addargs(&args, "-obatchmode yes");
                        break;
-               case 'P':
+               case 'p':
+                       global_pflag = 1;
+                       break;
+               case 'D':
                        sftp_direct = optarg;
                        break;
-               case 'B':
-                       copy_buffer_len = strtol(optarg, &cp, 10);
-                       if (copy_buffer_len == 0 || *cp != '\0')
-                               fatal("Invalid buffer size \"%s\"", optarg);
+               case 'r':
+                       global_rflag = 1;
                        break;
                case 'R':
                        num_requests = strtol(optarg, &cp, 10);
@@ -1756,6 +1776,13 @@ main(int argc, char **argv)
                                fatal("Invalid number of requests \"%s\"",
                                    optarg);
                        break;
+               case 's':
+                       sftp_server = optarg;
+                       break;
+               case 'S':
+                       ssh_program = optarg;
+                       replacearg(&args, 0, "%s", ssh_program);
+                       break;
                case 'h':
                default:
                        usage();
@@ -1806,20 +1833,27 @@ main(int argc, char **argv)
                addargs(&args, "%s", (sftp_server != NULL ?
                    sftp_server : "sftp"));
 
-               if (!batchmode)
-                       fprintf(stderr, "Connecting to %s...\n", host);
                connect_to_server(ssh_program, args.list, &in, &out);
        } else {
                args.list = NULL;
                addargs(&args, "sftp-server");
 
-               if (!batchmode)
-                       fprintf(stderr, "Attaching to %s...\n", sftp_direct);
                connect_to_server(sftp_direct, args.list, &in, &out);
        }
        freeargs(&args);
 
-       err = interactive_loop(in, out, file1, file2);
+       conn = do_init(in, out, copy_buffer_len, num_requests);
+       if (conn == NULL)
+               fatal("Couldn't initialise connection to server");
+
+       if (!batchmode) {
+               if (sftp_direct == NULL)
+                       fprintf(stderr, "Connected to %s.\n", host);
+               else
+                       fprintf(stderr, "Attached to %s.\n", sftp_direct);
+       }
+
+       err = interactive_loop(conn, file1, file2);
 
 #if !defined(USE_PIPES)
        shutdown(in, SHUT_RDWR);
This page took 0.073339 seconds and 4 git commands to generate.