- (tim) [configure.ac auth.c defines.h session.c openbsd-compat/port-uw.c

[openssh.git] / monitor_mm.c

diff --git a/monitor_mm.c b/monitor_mm.c
index 30c9825e342c1660894893aab1a93808cc8c04c9..b0ec37cff93aca9fd014aeb6ab8a44cc04a39b9a 100644 (file)
--- a/monitor_mm.c
+++ b/monitor_mm.c
@@ -24,7 +24,7 @@
  */
 
 #include "includes.h"
-RCSID("$OpenBSD: monitor_mm.c,v 1.6 2002/06/04 23:05:49 markus Exp $");
+RCSID("$OpenBSD: monitor_mm.c,v 1.9 2004/05/11 19:01:43 deraadt Exp $");
 
 #ifdef HAVE_SYS_MMAN_H
 #include <sys/mman.h>
@@ -38,7 +38,14 @@ RCSID("$OpenBSD: monitor_mm.c,v 1.6 2002/06/04 23:05:49 markus Exp $");
 static int
 mm_compare(struct mm_share *a, struct mm_share *b)
 {
-       return ((char *)a->address - (char *)b->address);
+       long diff = (char *)a->address - (char *)b->address;
+
+       if (diff == 0)
+               return (0);
+       else if (diff < 0)
+               return (-1);
+       else
+               return (1);
 }
 
 RB_GENERATE(mmtree, mm_share, next, mm_compare)
@@ -84,15 +91,9 @@ mm_create(struct mm_master *mmalloc, size_t size)
         */
        mm->mmalloc = mmalloc;
 
-#if  defined(HAVE_MMAP) && defined(MAP_ANON)
-       address = mmap(NULL, size, PROT_WRITE|PROT_READ, MAP_ANON|MAP_SHARED,
-           -1, 0);
-       if (address == MAP_FAILED)
-               fatal("mmap(%lu): %s", (u_long)size, strerror(errnor));
-#else
-       fatal("%s: UsePrivilegeSeparation=yes not supported",
-           __func__);
-#endif
+       address = xmmap(size);
+       if (address == (void *)MAP_FAILED)
+               fatal("mmap(%lu): %s", (u_long)size, strerror(errno));
 
        mm->address = address;
        mm->size = size;
@@ -132,10 +133,10 @@ mm_destroy(struct mm_master *mm)
 
 #ifdef HAVE_MMAP
        if (munmap(mm->address, mm->size) == -1)
-               fatal("munmap(%p, %lu): %s", mm->address, (u_long)mm->size
+               fatal("munmap(%p, %lu): %s", mm->address, (u_long)mm->size,
                    strerror(errno));
 #else
-       fatal("%s: UsePrivilegeSeparation=yes not supported",
+       fatal("%s: UsePrivilegeSeparation=yes and Compression=yes not supported",
            __func__);
 #endif
        if (mm->mmalloc == NULL)
@@ -165,8 +166,10 @@ mm_malloc(struct mm_master *mm, size_t size)
 
        if (size == 0)
                fatal("mm_malloc: try to allocate 0 space");
+       if (size > SIZE_T_MAX - MM_MINSIZE + 1)
+               fatal("mm_malloc: size too big");
 
-       size = ((size + MM_MINSIZE - 1) / MM_MINSIZE) * MM_MINSIZE;
+       size = ((size + (MM_MINSIZE - 1)) / MM_MINSIZE) * MM_MINSIZE;
 
        RB_FOREACH(mms, mmtree, &mm->rb_free) {
                if (mms->size >= size)