From: zacheiss <zacheiss>
Date: Mon, 16 Nov 2009 21:55:31 +0000 (+0000)
Subject: stop cups earlier in this process.
X-Git-Url: http://andersk.mit.edu/gitweb/moira.git/commitdiff_plain/2dea9cdba7913d6c5d10d3c9f47cd2f62f06abdd

stop cups earlier in this process.
---

diff --git a/gen/cups-print.sh b/gen/cups-print.sh
index 1e3c42f4..3c33e950 100755
--- a/gen/cups-print.sh
+++ b/gen/cups-print.sh
@@ -21,6 +21,10 @@ CUPSLOCAL=/etc/cups
 test -r $TARFILE || exit $MR_MISSINGFILE
 test -d $CUPSLOCAL || exit $MR_MISSINGFILE
 
+# We need to kill off CUPS to prevent it from overwriting
+# state data whilst updating
+/etc/init.d/cups stop
+
 /etc/cups/bin/check-disabled.pl 2>/dev/null
 
 # Unpack the tar file, getting only files that are newer than the
@@ -33,12 +37,12 @@ if [ -s /etc/cups/printers.conf.tmp ]; then
     mv /etc/cups/printers.conf.tmp /etc/cups/printers.conf
 fi
 
-# Now, make a stab at the PPD file.
-/etc/cups/bin/gen-ppd.pl
-
-/etc/init.d/cups stop
 /etc/init.d/cups start
 
+# Now, make a stab at the PPD file.  This is okay to run after
+# because CUPS will pick up the new PPDs later
+/etc/cups/bin/gen-ppd.pl
+
 if [ $? != 0 ]; then
     exit $MR_MKCRED
 fi