Add queries for creating, deleting, and modifying containers, as well as

[moira.git] / server / qaccess.pc

diff --git a/server/qaccess.pc b/server/qaccess.pc
index 06c72ba7be9de7c3f27b178d143fbde176c37bd5..2f6a4934bffad55755cf202b6252f34ceb83e8bd 100644 (file)
--- a/server/qaccess.pc
+++ b/server/qaccess.pc
@@ -198,7 +198,7 @@ int access_list(struct query *q, char *argv[], client *cl)
 
   /* If not amtl, atml, or dmfl, we lose. */
   if (strcmp(q->shortname, "amtl") && strcmp(q->shortname, "atml") &&
-      strcmp(q->shortname, "dmfl"))
+      strcmp(q->shortname, "dmfl") && strcmp(q->shortname, "tmol"))
     return MR_PERM;
 
   if (find_member(memacl_type, memacl_id, cl))
@@ -486,7 +486,7 @@ int access_host(struct query *q, char *argv[], client *cl)
            {
              /* host owner also cannot change contact, status, address,
                 owner, or acomment */
-             if (strcmp(argv[6 + idx], strtrim(contact)) ||
+             if (strcmp(argv[6], strtrim(contact)) ||
                  (status != atoi(argv[8 + idx])) ||
                  strcmp(argv[10 + idx], strtrim(address)) ||
                  strcmp(argv[11 + idx], strtrim(mtype)) ||
@@ -495,7 +495,7 @@ int access_host(struct query *q, char *argv[], client *cl)
                return MR_PERM;
              /* Billing contact field didn't appear until version 6 */
              if (q->version >= 6)
-               if (strcmp(argv[8], strtrim(billing_contact)))
+               if (strcmp(argv[7], strtrim(billing_contact)))
                    return MR_PERM;
            }
          else
@@ -619,3 +619,66 @@ int access_zephyr(struct query *q, char *argv[], client *cl)
     return MR_PERM;
 }
 
+/* access_container - check access for most container operations
+ *
+ * Inputs: argv[0] - cnt_id
+ *         q - query name        
+ *          cl - client name
+ *
+ * - check if that client is a member of the access control list
+ * - OR, if the query is add_machine_to_container or delete_machine_from_container
+ *     check if the client is a memeber of the mem_acl list
+ * - if the query is update_container and the container is to be renamed and
+ *   it is a top-level container, only priviledged users can do it
+ */
+
+int access_container(struct query *q, char *argv[], client *cl)
+{
+  EXEC SQL BEGIN DECLARE SECTION;
+  int cnt_id, acl_id, memacl_id;
+  char acl_type[CONTAINERS_ACL_TYPE_SIZE], memacl_type[CONTAINERS_ACL_TYPE_SIZE];
+  char name[CONTAINERS_NAME_SIZE], *newname;
+  EXEC SQL END DECLARE SECTION;
+  int status;
+
+  cnt_id = *(int *)argv[0];
+  
+  /* if amcn or dmcn, container id is the second argument */
+  if (strcmp(q->shortname, "amcn") == 0 || strcmp(q->shortname, "dmcn") == 0)
+       cnt_id = *(int *)argv[1];
+
+  EXEC SQL SELECT acl_id, acl_type, memacl_id, memacl_type, name
+    INTO :acl_id, :acl_type, :memacl_id, :memacl_type, :name
+    FROM containers
+    WHERE cnt_id = :cnt_id;
+
+  if (sqlca.sqlerrd[2] != 1)
+    return MR_INTERNAL;
+
+   /* trim off the trailing spaces */
+   strcpy(name, strtrim(name));
+
+  /* if the query is update_container and the containers is to be renamed
+   * and it is a top-level container, only dbadmin can do it */
+  if (!strcmp(q->shortname, "ucon"))
+  {
+    newname = argv[1];
+    if (strcmp(name, newname) && strchr(name, '/') == NULL)
+      return MR_PERM;
+  }
+
+  /* check for client in access control list and return success right 
+   * away if it's there. */
+  if (find_member(acl_type, acl_id, cl))
+    return MR_SUCCESS;
+
+  /* If not amcn, dmcn, we lose. */
+  if (strcmp(q->shortname, "amcn") && strcmp(q->shortname, "dmcn"))
+    return MR_PERM;
+
+  if (find_member(memacl_type, memacl_id, cl))
+    return MR_SUCCESS;
+
+  /* Otherwise fail. */
+  return MR_PERM;
+}