use sms_complete_operation() which checks alternate input as well

[moira.git] / lib / mr_connect.c

diff --git a/lib/mr_connect.c b/lib/mr_connect.c
index 25ba36eac12fbe1cf11788df9234e0199b46156e..1dc75ce593e3fb962c440a9eb5805ecc82dea69c 100644 (file)
--- a/lib/mr_connect.c
+++ b/lib/mr_connect.c
@@ -4,99 +4,103 @@
  *     $Header$
  *
  *     Copyright (C) 1987 by the Massachusetts Institute of Technology
+ *     For copying and distribution information, please see the file
+ *     <mit-copyright.h>.
  *     
  *     This routine is part of the client library.  It handles
- * creating a connection to the sms server.
+ *     creating a connection to the sms server.
  */
 
 #ifndef lint
 static char *rcsid_sms_connect_c = "$Header$";
 #endif lint
 
+#include <mit-copyright.h>
 #include "sms_private.h"
+#include <strings.h>
+
+static char *sms_server_host = 0;
 
 /*
  * Open a connection to the sms server.
  */
 
-int sms_connect()
+int sms_connect(server)
+char *server;
 {
-       extern int errno;
-       
-       if (!sms_inited) sms_init();
+    extern int errno;
+    char *p;
        
-       /* 
-        * should do a hesiod call to find the sms machine name & service
-        * number/name.
-        */
-       /* XXX gdb doesn't give real return codes. Can we trust errno?*/
-       errno = 0;
-       _sms_conn = start_server_connection(SMS_GDB_SERV, ""); 
-       if (_sms_conn == NULL) {
-               return errno;
-       }
-       return 0;
+    if (!sms_inited) sms_init();
+    if (_sms_conn) return SMS_ALREADY_CONNECTED;
+               
+    /* 
+     * XXX should do a hesiod call to find the sms machine name & service
+     * number/name.
+     */
+    errno = 0;
+    if (!server || (strlen(server) == 0))
+      server = SMS_GDB_SERV;
+    _sms_conn = start_server_connection(server, ""); 
+    if (_sms_conn == NULL)
+       return errno;
+    if (connection_status(_sms_conn) == CON_STOPPED) {
+       register status = connection_errno(_sms_conn);
+       if (!status) status = SMS_CANT_CONNECT;
+       sms_disconnect();
+       return status;
+    }
+
+    /*
+     * stash hostname for later use
+     */
+
+    sms_server_host = strsave(server);
+    if (p = index(sms_server_host, ':'))
+       *p = 0;
+    sms_server_host = canonicalize_hostname(sms_server_host);
+    return 0;
 }
        
 int sms_disconnect()
 {
-       if (!_sms_conn) {
-               return SMS_NOT_CONNECTED;
-       }
-       /* Is this guaranteed NOT to fail?? I don't believe it, but.. */
-       _sms_conn = sever_connection(_sms_conn);
-       return 0;
+    CHECK_CONNECTED;
+    _sms_conn = sever_connection(_sms_conn);
+    free(sms_server_host);
+    sms_server_host = 0;
+    return 0;
 }
 
-int sms_noop()
+int sms_host(host, size)
+  char *host;
+  int size;
 {
-       int status;
-       struct sms_params *parms = NULL;
-       struct sms_params *reply = NULL;
-       
-
-       parms = (struct sms_params *) malloc(sizeof(*parms));
-       
-       parms->sms_procno = SMS_NOOP;
-       parms->sms_argc = 0;
+    CHECK_CONNECTED;
 
-       if ((status = sms_do_call(parms, &reply)) || (status = reply->sms_status))
-               goto punt;
-       
-       
-punt:
-       sms_destroy_reply(reply);
-ok:
-       free(parms);
-       return status;
+    /* If we are connected, sms_server_host points to a valid string. */
+    strncpy(host, sms_server_host, size);
+    return(0);
 }
 
-int sms_shutdown(why)
-       char *why;
+int sms_noop()
 {
-       int status;
-       sms_params *parms=NULL;
-       sms_params *reply=NULL;
+    int status;
+    sms_params param_st;
+    struct sms_params *params = NULL;
+    struct sms_params *reply = NULL;
 
-       parms = (sms_params *) malloc(sizeof(*parms));
-       
-       parms->sms_procno = SMS_SHUTDOWN;
-       parms->sms_argc = 1;
-       parms->sms_argv = (char **)malloc(sizeof(char *) * 2);
-       parms->sms_argv[0] = why;
-       parms->sms_argv[1] = NULL;
-
-       if ((status = sms_do_call(parms, &reply)) || (status = reply->sms_status))
-               goto punt;
+    CHECK_CONNECTED;
+    params = &param_st;
+    params->sms_version_no = sending_version_no;
+    params->sms_procno = SMS_NOOP;
+    params->sms_argc = 0;
+    params->sms_argl = NULL;
+    params->sms_argv = NULL;
        
+    if ((status = sms_do_call(params, &reply)) == 0)
+       status = reply->sms_status;
        
-punt:
-       sms_destroy_reply(reply);
-ok:
-       if(parms) {
-               if(parms->sms_argv)
-                       free(parms->sms_argv);
-               free(parms);
-       }
-       return status;
+    sms_destroy_reply(reply);
+
+    return status;
 }