fix bogus "List is empty" message on permission denied.

[moira.git] / clients / moira / lists.c

diff --git a/clients/moira/lists.c b/clients/moira/lists.c
index d193052de6182e946545bbf1176c9fc11751ed3b..05f25a39650c7329905dc4679c6d6a85dd69f2f1 100644 (file)
--- a/clients/moira/lists.c
+++ b/clients/moira/lists.c
@@ -198,7 +198,7 @@ Bool name;
     GetYesNoValueFromUser("Is this a public list", &info[L_PUBLIC]);
     GetYesNoValueFromUser("Is this a hidden list", &info[L_HIDDEN]);
     GetYesNoValueFromUser("Is this a maillist", &info[L_MAILLIST]);
-    GetYesNoValueFromUser("is this a group", &info[L_GROUP]);
+    GetYesNoValueFromUser("Is this a group", &info[L_GROUP]);
     if (atoi(info[L_GROUP]))
        GetValueFromUser("What is the GID for this group.", &info[L_GID]);
 
@@ -430,7 +430,7 @@ char **argv;
        case SMS_LIST:
            Put_message("This list does not exist.");
            return(DM_QUIT);
-       case SMS_ACCESS:
+       case SMS_PERM:
            Put_message("You are not allowed to view this list.");
            break;
        default:
@@ -481,8 +481,10 @@ char * type;
 
     found_some = FALSE;
     if ( (status = sms_query("get_members_of_list", CountArgs(args), args, 
-                            PrintByType, type)) != 0)
+                            PrintByType, type)) != 0) {
        com_err(program_name, status, " in ListMembersByType");
+       return(DM_NORMAL);
+    }
     if (!found_some) {
        if (type == NULL)
            Put_message("List is empty (no members).");
@@ -757,7 +759,7 @@ ListByAdministrator()
                            BUFSIZ, "user")) )
        return(DM_NORMAL);
 
-    if ( YesNoQuestion("Do you want a recursive search (y/n)", TRUE) == 1 ) {
+    if ( YesNoQuestion("Do you want a recursive search (y/n)", FALSE) == 1 ) {
        sprintf(temp_buf, "R%s", buf);  /* "USER" to "RUSER" etc. */
        type = Strsave(temp_buf);
     }