*/
int aim_get_command(struct aim_session_t *sess, struct aim_conn_t *conn)
{
- u_char generic[6];
+ unsigned char generic[6];
struct command_rx_struct *newrx = NULL;
if (!sess || !conn)
if (conn->fd < 3) /* can happen when people abuse the interface */
return 0;
+ /*
+ * Rendezvous (client-client) connections do not speak
+ * FLAP, so this function will break on them.
+ */
+ if (conn->type == AIM_CONN_TYPE_RENDEZVOUS)
+ return aim_get_command_rendezvous(sess, conn);
+ if (conn->type == AIM_CONN_TYPE_RENDEZVOUS_OUT)
+ return 0;
+
/*
* Read FLAP header. Six bytes:
*
* 2 short -- Sequence number
* 4 short -- Number of data bytes that follow.
*/
+ faim_mutex_lock(&conn->active);
if (read(conn->fd, generic, 6) < 6){
aim_conn_close(conn);
+ faim_mutex_unlock(&conn->active);
return -1;
}
*/
if (generic[0] != 0x2a) {
faimdprintf(1, "Bad incoming data!");
+ aim_conn_close(conn);
+ faim_mutex_unlock(&conn->active);
return -1;
}
/* allocate a new struct */
- newrx = (struct command_rx_struct *)malloc(sizeof(struct command_rx_struct));
- if (!newrx)
+ if (!(newrx = (struct command_rx_struct *)malloc(sizeof(struct command_rx_struct)))) {
+ faim_mutex_unlock(&conn->active);
return -1;
+ }
memset(newrx, 0x00, sizeof(struct command_rx_struct));
newrx->lock = 1; /* lock the struct */
+ /* we're doing OSCAR if we're here */
+ newrx->hdrtype = AIM_FRAMETYPE_OSCAR;
+
/* store channel -- byte 2 */
- newrx->type = (char) generic[1];
+ newrx->hdr.oscar.type = (char) generic[1];
/* store seqnum -- bytes 3 and 4 */
- newrx->seqnum = aimutil_get16(generic+2);
+ newrx->hdr.oscar.seqnum = aimutil_get16(generic+2);
/* store commandlen -- bytes 5 and 6 */
newrx->commandlen = aimutil_get16(generic+4);
newrx->nofree = 0; /* free by default */
/* malloc for data portion */
- newrx->data = (u_char *) malloc(newrx->commandlen);
- if (!newrx->data) {
+ if (!(newrx->data = (u_char *) malloc(newrx->commandlen))) {
free(newrx);
+ faim_mutex_unlock(&conn->active);
return -1;
}
free(newrx->data);
free(newrx);
aim_conn_close(conn);
+ faim_mutex_unlock(&conn->active);
return -1;
}
+ faim_mutex_unlock(&conn->active);
newrx->conn = conn;
sess->queue_incoming = NULL;
if (!tmp->nofree) {
+ if (tmp->hdrtype == AIM_FRAMETYPE_OFT)
+ free(tmp->hdr.oft.hdr2);
free(tmp->data);
free(tmp);
} else
tmp = cur->next;
cur->next = tmp->next;
if (!tmp->nofree) {
+ if (tmp->hdrtype == AIM_FRAMETYPE_OFT)
+ free(tmp->hdr.oft.hdr2);
free(tmp->data);
free(tmp);
} else
return;
}
+
+/*
+ * Since aim_get_command will aim_conn_kill dead connections, we need
+ * to clean up the rxqueue of unprocessed connections on that socket.
+ *
+ * XXX: this is something that was handled better in the old connection
+ * handling method, but eh.
+ */
+void aim_rxqueue_cleanbyconn(struct aim_session_t *sess, struct aim_conn_t *conn)
+{
+ struct command_rx_struct *currx;
+
+ for (currx = sess->queue_incoming; currx; currx = currx->next) {
+ if ((!currx->handled) && (currx->conn == conn))
+ currx->handled = 1;
+ }
+ return;
+}